- 19 Feb, 2020 40 commits
-
-
Victor Costan authored
This CL is a follow-up from the review on https://crrev.com/c/2052251. Bug: 989611 Change-Id: I251fc8bb4cda138bc0bc94701efc09dc9553650f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058008 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#742488}
-
Joey Scarr authored
Bug: 1007686 Change-Id: I806d9c065a0ddc89d74ab6f9d382388b976d3560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059750 Commit-Queue: Joey Scarr <jsca@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Daichi Hirono <hirono@chromium.org> Cr-Commit-Position: refs/heads/master@{#742487}
-
Alex Danilo authored
Bug: 992823 Change-Id: I43c39021345ef23f4274d203d817e66b11525074 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060405 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#742486}
-
Alex Danilo authored
Stops the underline being drawn in the cr-input element by setting the input focus color to transparent. Enables the caret to be visible by targeting the input element using the ::part() pseudo-element since the underline and caret are both managed by '--cr-input-focus-color' for -cr-input elements. Bug: 992823 Change-Id: I6f86b723c84662ff5923d50433751b74d7e7ab58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061570 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/123fd97000bb..fa9eff37c38a git log 123fd97000bb..fa9eff37c38a --date=short --first-parent --format='%ad %ae %s' 2020-02-18 shawn.p.huang@gmail.com Disable GL_EXT_semaphore_fd for Mesa version < 19.3.5 on AMD GPUs Created with: gclient setdep -r src/third_party/angle@fa9eff37c38a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1053516 Tbr: cwallez@google.com Change-Id: I624b38c938b8f18e88cec61c39ac56db6f11f33e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063096Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742484}
-
matterchen authored
Due to the spec change of not forwarding "active" ports on container start up, we have removed the active state in prefs as it is not required anymore. This change removes the active pref, resulting in changes to fit the new context such as: on deactivate all ports, we just need to remove ports from our lifeline fd map. Bug: 848127 Test: crostini_port_forwarder_unittest.cc Change-Id: I19ad693682122f1edd47c8a21fff5b69780fb4c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063191Reviewed-by:
David Munro <davidmunro@google.com> Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: Matthew Chen <matterchen@google.com> Cr-Commit-Position: refs/heads/master@{#742483}
-
Daniele Castagna authored
TextureLayer::SetVertexOpacity is not used anywhere outside tests. This CL removes it. The final goal is to get rid of vertex_opacity in viz:TextureDrawQuad that affects the size of QuadList. Bug: None Change-Id: I584dc3315b7a5d26e57ed067f2974866bef5d284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059788 Auto-Submit: Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#742482}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a48a607cba32..333b29e11603 Created with: gclient setdep -r src-internal@333b29e11603 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024586,chromium:149759085 Tbr: jbudorick@google.com Change-Id: I4c5c4eda17ca9541d0ed54e206e39d37ac181c23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063095Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742481}
-
Peter Kotwicz authored
This CL: - Daggerizes: - WebappDisclosureSnackbarController - WebappActionsNotificationManager - Moves the management of the following classes out of WebappActivity/WebApkActivity and into WebappActivityCoordinator/WebApkActivityCoordinator - WebappDisclosureSnackbarController - WebappActionsNotificationManager - WebApkUpdateManager - Introduces new class - WebappDeferredStartupWithStorageRegistrar - for getting notified once the WebappDataStorage has been fetched (and potentially created) during deferred startup. BUG=1042147 TEST=WebApkInitializationTest Change-Id: I98ea759d4f1186da4e58d899aab6f3aec2caaecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005976 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Cr-Commit-Position: refs/heads/master@{#742480}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1fbe7c0bb24b..10e0e6d6c19a git log 1fbe7c0bb24b..10e0e6d6c19a --date=short --first-parent --format='%ad %ae %s' 2020-02-19 tandrii@chromium.org Roll bb tool to @ 37d99607 Created with: gclient setdep -r src/third_party/depot_tools@10e0e6d6c19a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1052637 Tbr: agable@chromium.org Change-Id: I8e0d987ad297d1c4d2067a8c9bac2b0b6c4d6037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063098Reviewed-by:
-
Rachel Wong authored
Bug: 1014839 Change-Id: Ieaf9f19ec95e4b46f8ce06f3cbd5585a04babaa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049144 Commit-Queue: Rachel Wong <wrong@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#742478}
-
Mitsuru Oshima authored
TBR=hashimoto@chromium.org Bug: None Change-Id: I457fe3cbe97948a28d7a0eb3d019af9d4aba128a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063771Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Auto-Submit: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#742477}
-
Bang Lee authored
Team identifier is the same with application id prefix for newer Apple developer accounts. However Apple did allow creating multiple prefixes in one account years ago. More information: https://developer.apple.com/library/archive/technotes/tn2311/_index.html Change-Id: Ie9bc6cd10eb131cdfbcf60e21570a1b950e919d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059830 Commit-Queue: Bang Lee <banl@microsoft.com> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#742476}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromium.org Change-Id: Icec4bc2664e6508c4817f5990ac10c9b8d51a59c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063895Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742475}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cc42eb9c..6caa2be2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I61e12063b7b6da69120ed488721a8e7bf1b52027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062099Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742474}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/83f5cce214ee..515e6dafedc4 git log 83f5cce214ee..515e6dafedc4 --date=short --first-parent --format='%ad %ae %s' 2020-02-18 estade@chromium.org WebLayer telemetry: use TelemetryActivity Created with: gclient setdep -r src/third_party/catapult@515e6dafedc4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1045609 Tbr: wenbinzhang@google.com Change-Id: I3af73570f655300cb79676c4c52b3927f0e40b11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063576Reviewed-by:
-
Isabella Scalzi authored
Add a TestEntryInfo entry for image added in CL:2063190 so that it can be used for testing RAW images that only have an embedded "thumbnail", and also have an image orientation (6 in our case) Bug: 1039141 Change-Id: Id81156887507203c8db7881469d4dd422e139b42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062836Reviewed-by:
-
Manoj Gupta authored
Fix for the error in CrOS SDK because of the older clang version that does not support '-debug-info-kind=constructor': chromeos-chrome-82.0.4061.0_rc-r1: error: invalid value 'constructor' in '-debug-info-kind=constructor Bug: 1050118 Change-Id: I5b5b038027c6111ba6501e23e4b46f23f664fae9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062251 Commit-Queue: Manoj Gupta <manojgupta@chromium.org> Auto-Submit: Manoj Gupta <manojgupta@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#742471}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 24defce3. With Chromium commits locally applied on WPT: ec83d167 "Update performance.measureMemory to the latest proposal" d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ibcfb62f0bfab986516435e2ad438891b9a8ff4f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063750Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742470}
-
Isabella Scalzi authored
I made a .NEF test image. It contains only a "thumbnail" image, and it has no "preview" image. To be used in resolving issue 1039141 and issue 1039147. The RAW .NEF image has orientation 6 (when rendered the image should appear rotated 90 degrees clockwise) Bug: 1039141 Change-Id: Iebac90707d823ffacf5ddff962a0ab51e210909c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063190Reviewed-by:
-
Victor Costan authored
Bug: 989611 Change-Id: I02b19b518be883feb8692003a398a34c6a9a1041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052251 Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Chase Phillips <cmp@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#742468}
-
Hiroki Sato authored
Bug: b:145262516 Test: unit_tests --gtest_filter="AXTreeSourceArcTest.*" Test: manual. Using "talkback test app" and LiveRegion change is announced by ChromeVox. Change-Id: Ia83a35d81da5bf6a8b3d7540760c5fdd25efc9c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053944 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#742467}
-
Noel Gordon authored
The id was a hangover from a time when PIEX image extraction used NaCl to do thumbnail image extraction. It serves no purpose: remove it from @typedefs and object properties. Reformat @typedefs for consistency. No change in behavior, no new tests. Bug: 1039141 Change-Id: I8c50b7e5906ce3763ba2396b677b7f74f1ec4a09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062014Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
In cases like <div style="display: contents; cursor: pointer">Text</div>, previously WebViewImpl::BestTapNode() returned the text node, which caused crash in LinkHighlightImpl::Paint() because a text node can't have paint properties. Let WebViewImpl::BestTapNode() return nullptr in the case because a text node can't have touch actions, to fix the crash. Bug: 1052650, 1016587 Change-Id: If9f6d3f8c7368649e00ea804e9d48a17eef3fbc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063770 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#742465}
-
John Lee authored
This CLs moves off of the chrome.tabs Extensions API for moving tabs as the API does not allow preserving pinned or active states. This also removes the dependency on getting a window ID for the tab strip. This is in preparation for a tab being able to be placed at a specific index and will allow dragging a pinned tab from one window to another window, and preserve its pinned state. Bug: 1048894 Change-Id: Id1a58d55e95b235370abdd8e00f65592fd1306ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063670Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#742464}
-
Jiawei Shao authored
This patch puts WGPUDevice, wire_server_ and wire_seralizer_ and all the operations related to these objects into one object DawnDeviceAndWireServer as one of the preparations of supporting multiple devices in one WebGPU context. BUG=chromium:996713 Change-Id: I65fe5abe54a79394ca7d68a2c0ea8f41b0e1ac93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050324Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Jiawei Shao <jiawei.shao@intel.com> Cr-Commit-Position: refs/heads/master@{#742463}
-
Xinghui Lu authored
Same as GetPasswordProtectionService, it is ok to return nullptr for GetVerdictCacheManager, since SafeBrowsingService::GetVerdictCacheManager already returns nullptr when safe browsing is off. The validity of cache manager is already measured from the caller: uma/p/chrome/timeline_v2/?sid=c936612232d60ca29d3ad4da77436787 Bug: 1049694 Change-Id: I53016d115bb33ab37dbd6eb78bca08bcaf9cb91c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057864Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#742462}
-
Julie Jeongeun Kim authored
This CL converts FrameHostMsg_UpdateTitle to LocalFrameHost mojom interface. It's called only when the frame is the top frame. Bug: 1047349 Change-Id: I6835a41b98f39756fe806e19a843cd705f82fb05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044253Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#742461}
-
Brian Sheedy authored
Switches the "Win10 FYI Exp Release (Intel HD 630)" GPU bot to trigger tests on the stable driver version. This is so that the machines with the experimental driver version can be upgraded to a newer experimental version. TBR=kbr@chromium.org Bug: 1053803 Change-Id: I094d3534993c194ee2648e3699698291c6a50631 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063890Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#742460}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/07a952baa2fe..1217cd17daba git log 07a952baa2fe..1217cd17daba --date=short --first-parent --format='%ad %ae %s' 2020-02-19 tsepez@chromium.org Tidy CFGAS_DefaultFontManager::GetDefaultFont(). 2020-02-19 tsepez@chromium.org Remove unused CXFA_FFWidgethandler::OnSetCursor(). 2020-02-14 tsepez@chromium.org Remove redundant loop in CFX_CSSSyntaxParser 2020-02-14 tsepez@chromium.org Add some more CFX_CSSStyleSheet test cases. 2020-02-14 tsepez@chromium.org Move CSS unit tests build to core/fxcrt/css/BUILD.gn. 2020-02-14 tsepez@chromium.org Add unit tests for CSS Syntax Parser declaration-only mode. 2020-02-14 tsepez@chromium.org Remove unused member CFX_CSSStyleSheet:m_StringCache Created with: gclient setdep -r src/third_party/pdfium@1217cd17daba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ifa79405bbe19bd29874546e981269bd64f38f1d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063657Reviewed-by:
-
James Cook authored
PeopleHandler handles the browser settings "People" section and mostly deals with sync. Long-term, we should not use it in OS settings. Refactor the quick unlock settings WebUI handler into its own class. Bug: 1013466 Test: manual, PIN unlock settings still work Change-Id: I3601fcf56a899889710a607d2dd145e52be07f54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062793 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#742458}
-
Joey Scarr authored
Bug: 1007685 Change-Id: If25ab8acb34bc501271d8a081a23aa0ea6e7211c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060436 Commit-Queue: Joey Scarr <jsca@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#742457}
-
Sorin Jianu authored
This change allows the run loop to wait more than the default test execution in this particular case where the task is posted with BEST_EFFORT traits. Bug: 1053812 Change-Id: I3c85cbe07f2d1e647f0dc2191bea63d38ea3d026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063426Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#742456}
-
David Black authored
AssistantResponseObserver will be used in response processing V2. This CL just introduces the observer, follow up CLs will use it and refine when its methods are invoked. Currently OnUiElementAdded is fired when the UI element is added to the response, but in a follow up CL it will first be pended and pre-processed before being added. Bug: b:129411551 Change-Id: I905ea9a2322d241fdc609b95b98ebd7713f79bc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063034 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#742455}
-
Tim Song authored
This is a reland of 2117f1ba TBR=peter@chromium.org,holte@chromium.org Original change's description: > Ash Tray: Add more observer callbacks to notifications for metrics collection. > > This CL adds more hooks into MessageView and MessagePopupCollection > to log when certain user actions occur, so we can log them. > > BUG=1050809 > > Change-Id: Ic2e23d0c8169e588d2d86556685f0e4549ed128c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045191 > Commit-Queue: Tim Song <tengs@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#741354} Bug: 1050809 Change-Id: I50440955e4e2f76c830c85a36ad5a960787744c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063266Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#742454}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/851532894fe9..1fbe7c0bb24b git log 851532894fe9..1fbe7c0bb24b --date=short --first-parent --format='%ad %ae %s' 2020-02-19 tandrii@chromium.org Roll lucicfg tool to @ 3b479f0e v1.12.3. Created with: gclient setdep -r src/third_party/depot_tools@1fbe7c0bb24b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:925080 Tbr: agable@chromium.org Change-Id: I00dae97c40d47ecded5c62af6927a239a8eec518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063094Reviewed-by:
-
Kent Tamura authored
This makes LayoutNG transition easier. Some other elements are going to apply this flag. This CL has no behavior changes. Bug: 1040828 Change-Id: Ic3d95e67a6f61c3231b59706a9c5c42ea4a6f155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060402 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#742452}
-
Kunihiko Sakamoto authored
This patch implements the following restrictions on Signed Exchange inner responses, added in https://github.com/WICG/webpackage/pull/354: - Inner response must have a Content-Type header (step 7. of [1]). - Clients must not sniff a media type from the payload bytes. In the loading spec, parser injects "X-Content-Type-Options: nosniff" header while parsing response headers (step 8. of [1]) to achieve this. [1] https://wicg.github.io/webpackage/loading.html#parse-b2-cbor-headers Bug: 1051390 Change-Id: Ia7274f32e43dac28affd718a2965d575b955353c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059751Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
-
Demetrios Papadopoulos authored
Bug: None Change-Id: I3fb8f1b55f913960669d69bdf3e301efd8f1bd02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057640 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#742450}
-
Joey Scarr authored
I've converted these two in the same CL because they depend on each other. Bug: 1007686,1007635,1007788 Change-Id: I6cbb695ac18badca7f75ac5bc96dc2051c2d122c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059891Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
-
