- 22 Feb, 2019 40 commits
-
-
Alexandre Courbot authored
We are planning to introduce VideoFrames backed by a V4L2-allocated buffer. Such VideoFrames need to prevent that buffer from being reused during their lifetime. They will do so by retaining a reference to the V4L2ReadableBufferRef they were created from. However, contrary to V4L2 buffer references VideoFrames are typically passed between threads, and have a more blurry lifetime. Thus we may destroy the VideoFrame and release the V4L2ReadableBufferRef in a thread different from the one it was created in. Worse, this can also happen after the thread in question or even the V4L2 queue the buffer originated from has been deleted, rendering it impossible to post the destruction to the correct message loop. This CL thus makes it legal to destroy a V4L2ReadableBufferRef from any thread, and even after their originating V4L2Queue has been destroyed. To allow this the only task performed during buffer reference destruction, namely returning the reference to the free buffers list, must be made thread-safe. Also the free buffers list must be able to survive the V4L2Queue's destruction. For this, the thread-safe V4L2BufferList class in introduced, and referenced using a scoped_refptr from the V4L2Queue and all the buffer references. When buffers are freed on the queue, it creates a new instance of V4L2BuffersList, so buffer references can still reference and return to the old one. Bug: 792790 Bug: b:119794200 Test: VDA unittest passed in regular and import mode on Hana. Change-Id: Ib37cf55232aca040f1267e3d0357ebb7c40c7d6c Reviewed-on: https://chromium-review.googlesource.com/c/1481185Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#634573}
-
Risan authored
This CL implements OpenFile logic using DriveFS if it is enabled. Otherwise, VirtualFileProvider is used. BUG=b:119597913 TEST=Manually "Open With" a file in Google Drive (FilesApp) with an Android app (with and without DriveFS enabled). TEST=Tested that FSP still works (open zip mounted file with Google Photos). Change-Id: Ie206f22e717f4c31330f6beb33520d151ec07e66 Reviewed-on: https://chromium-review.googlesource.com/c/1475143Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Risan <risan@chromium.org> Cr-Commit-Position: refs/heads/master@{#634572}
-
Sarthak Kukreti authored
This adds histogram declarations and enums for the histogram added in https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1152301 BUG=chromium:808303 CQ-DEPEND=CL:1152301 TEST=None Signed-off-by:
Sarthak Kukreti <sarthakkukreti@chromium.org> Change-Id: I91f8775cf49b78f4689e143142323d85a7e528fc Reviewed-on: https://chromium-review.googlesource.com/c/1227503Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#634571}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9431161ca973..969659dbb313 git log 9431161ca973..969659dbb313 --date=short --no-merges --format='%ad %ae %s' 2019-02-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 962c222aa3be..b9039bf76bf3 (2 commits) 2019-02-22 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-02-22 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@969659dbb313 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: Iaad7f887cd9c37566db8b14f787570687a4861d6 Reviewed-on: https://chromium-review.googlesource.com/c/1482613Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634570}
-
Alexandre Courbot authored
This class was lacking a proper sequence checker. Add it. Bug: 792790 Bug: b:119794200 Test: VDA unittest passed in regular and import mode on Hana. Change-Id: If2ee4d272b396ba28df4082da59a98e5f1f4b5d6 Reviewed-on: https://chromium-review.googlesource.com/c/1481187 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4a5fcd9f3541..a74495a2956d git log 4a5fcd9f3541..a74495a2956d --date=short --no-merges --format='%ad %ae %s' 2019-02-22 crouleau@chromium.org Update chrome reference builds Created with: gclient setdep -r src/third_party/catapult@a74495a2956d The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:932615,chromium:932595 TBR=sullivan@chromium.org Change-Id: I5a96c0f5f9a19dbb0603c1988c101cea052ffc6c Reviewed-on: https://chromium-review.googlesource.com/c/1482614Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2fdee39b44ee..c0546b9817ee git log 2fdee39b44ee..c0546b9817ee --date=short --no-merges --format='%ad %ae %s' 2019-02-22 crouleau@chromium.org presubmit: support 'Bug: 1234, 5678' Created with: gclient setdep -r src/third_party/depot_tools@c0546b9817ee The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I6ae0ee34fc7b6c34c3645cf5bf7d283d50852bb8 Reviewed-on: https://chromium-review.googlesource.com/c/1482611Reviewed-by:
-
Nate Fischer authored
No change to logic. This splits Safe Browsing code out of android_webview/browser/ and into a subdirectory, for better code layout. This adds an OWNERS file to list me as the owner, since I worked on the original integration and have acted as reviewer since. This does not split this into a separate GN target, since there's still circular dependencies with android_webview/browser/. This move was auto-generated with tools/git/move_source_file.py. R=boliu@chromium.org Bug: 934597 Test: ninja -C out/Default system_webview_apk Change-Id: Ib7157fe635032ebd76fd3564c9ad13fc9f6c0213 Reviewed-on: https://chromium-review.googlesource.com/c/1480637 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#634566}
-
Gyuyoung Kim authored
Thanks to all effort to replace the uses of Blink's WaitableEvent with base::WaitableEvent, there is no uses of Blink's WaitableEvent now. So this CL removes waitable_event.h/cc files in blink finally. Bug: 919388 Change-Id: I8b5105fc2a14ae515617bd5059869bb6df4ff8aa Reviewed-on: https://chromium-review.googlesource.com/c/1482097Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#634565}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6817d76a0fbc..509f53e8e4d4 Created with: gclient setdep -r src-internal@509f53e8e4d4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I38d67da2f5c7f8133984ce988af4cc98b2cfe69e Reviewed-on: https://chromium-review.googlesource.com/c/1482612Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634564}
-
Kouhei Ueno authored
Bug: 923213 Change-Id: Ie7a311b3aef623d0cd5a0aa9dd5f9da0a94444d5 Reviewed-on: https://chromium-review.googlesource.com/c/1420498 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#634563}
-
Anand K. Mistry authored
BUG=934541 Change-Id: Ibd06bda730bd10c270d187d83f68315159fa6a43 Reviewed-on: https://chromium-review.googlesource.com/c/1482172Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#634562}
-
Zhuoyu Qian authored
As now we use blink instead of webkit, this CL rename check_webkit_style* to check_blink_style*. Change-Id: I340719a4c80cbc1dc4934fbdc4fa40b56347d8f8 Reviewed-on: https://chromium-review.googlesource.com/c/1482274Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#634561}
-
Dominic Mazzoni authored
Propagates the command-line flag for experimental accessibility labels to the renderer process, so that if the flag is enabled but the user hasn't opted in yet, we can still add a flag to unlabeled images that could possibly be described by Google to advertise it. Then, skips images that have an explicitly empty label or images that are already labeled, and for the remaining images either queries the annotator as before, or marks them as eligible for annotation if the annotator isn't running yet. Bug: 905419 Change-Id: I360670c6caa2200ae5016546f3ac5d89055f8e60 Reviewed-on: https://chromium-review.googlesource.com/c/1480303 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#634560}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5100fd8f459d..4a5fcd9f3541 git log 5100fd8f459d..4a5fcd9f3541 --date=short --no-merges --format='%ad %ae %s' 2019-02-22 crouleau@chromium.org Disable failing scroll tests on Android Created with: gclient setdep -r src/third_party/catapult@4a5fcd9f3541 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:934649 TBR=sullivan@chromium.org Change-Id: Ic25f8f6d6a435d4e460362ba5388814992671653 Reviewed-on: https://chromium-review.googlesource.com/c/1482610Reviewed-by:
-
Christopher Lam authored
This is a reland of cd38dfe2 Original change's description: > [Mojo Lite] Remove externs generators and use for-compile generators everywhere. > > This CL removes the Mojo Lite externs generators and compiles all WebUIs > with the for-compile targets instead. > > Structurally, all Mojo types are now Closure record typedefs, and their > generated business logic is underneath a Spec object to prevent the name > collisions that were happening in the original implementation. > > All goog.requires have also been dropped, and goog.provides are now > per interface/struct/enum. > > This CL paves the way for generating single file Closure compiled blobs > that have all the Mojo bindings for a single WebUI. > > TBR=kinuko@chromium.org > > Bug: 914149 > Change-Id: I8866fa9eaa707b2db42369e695ed0a51c373c6b6 > Reviewed-on: https://chromium-review.googlesource.com/c/1476886 > Commit-Queue: calamity <calamity@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#634527} TBR=kinuko@chromium.org, rockot@chromium.org Bug: 914149 Change-Id: I415071a2bf94abc78eb331152b1818bba1c4753b Reviewed-on: https://chromium-review.googlesource.com/c/1482353Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#634558}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6a00e68a3448..9431161ca973 git log 6a00e68a3448..9431161ca973 --date=short --no-merges --format='%ad %ae %s' 2019-02-22 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@9431161ca973 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I51c04ec86ac2fd7c5a2ec54cb93f8707ff76fde8 Reviewed-on: https://chromium-review.googlesource.com/c/1482331Reviewed-by:
-
Matt Falkenhagen authored
This happened when the eager code caching started a task but the timeout timer aborted it. The eager code caching code wasn't aware of the timeout so would call EndTask() and cause a crash when the timeout timer couldn't find the task. Bug: 933273 Change-Id: I09e9b2472f32413343c22d0d271b7b3dda40ef90 Reviewed-on: https://chromium-review.googlesource.com/c/1482433Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#634556}
-
dstockwell authored
Bug: 902646 Change-Id: I445c807725f5fef4bc987be9759dd346fdf55c06 Reviewed-on: https://chromium-review.googlesource.com/c/1482355 Commit-Queue: dstockwell <dstockwell@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: dstockwell <dstockwell@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#634555}
-
dstockwell authored
Bug: 902646 Change-Id: I69015588df66c1d80817c141580f9fc29b248ece Reviewed-on: https://chromium-review.googlesource.com/c/1482354 Commit-Queue: dstockwell <dstockwell@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Auto-Submit: dstockwell <dstockwell@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#634554}
-
Aleks Totic authored
We have not maintained our virtual expectations in a while. Bug: 635619 Change-Id: Id9961eb9685b237af80a0c565de2eacfc8858ae1 Reviewed-on: https://chromium-review.googlesource.com/c/1482333Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#634553}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dda2895279c9..6817d76a0fbc Created with: gclient setdep -r src-internal@6817d76a0fbc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I1d5630a5319773d828f8badf131c48efe838d0e9 Reviewed-on: https://chromium-review.googlesource.com/c/1482332Reviewed-by:
-
Koji Ishii authored
Bug: 934129, 922407, 934634, 922645 Change-Id: Ia85a2ee6d94fc56df83b0677338ed2206564ce07 Reviewed-on: https://chromium-review.googlesource.com/c/1482291Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
-
David Trainor authored
The update app menu item has an odd alignment when there is no summary to show. This is because the summary is still taking vertical space, which leaves a larger than normal gap between the update app menu item and the next menu item. This CL makes the summary visibility GONE when there is no text to show, which removes it from layout calculations. Bug: 922711 Change-Id: I34d62ff1ba0cdf68a8b53df3b75a9e91a21f55df Reviewed-on: https://chromium-review.googlesource.com/c/1479301Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#634550}
-
Shao-Chuan Lee authored
ArcSessionManager state is reset before final UMA recording happens on browser shutdown, which result in missing Arc.State and incorrectly recorded Arc.StateByUserType. This CL adds fields to ArcSessionManager to persist state across Shutdown() for UMA recording purposes. Bug: 929583 Change-Id: I5fdf58ec60f9720599fa15c997cd2a23ed524fd9 Reviewed-on: https://chromium-review.googlesource.com/c/1481180 Commit-Queue: Shao-Chuan Lee <shaochuan@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Auto-Submit: Shao-Chuan Lee <shaochuan@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#634549}
-
Anand K. Mistry authored
BUG=934541 Change-Id: I6615fd0cdaa91f3806147fe44ecfbc1595e4b36b Reviewed-on: https://chromium-review.googlesource.com/c/1482091Reviewed-by:
-
Dan Beam authored
mojo_bindings_lite.js should be used in new (and eventually current) code. R=dpapad@chromium.org BUG=931798 Change-Id: I6499a02c848412d7a2ba4c3d84fcc202e2813bf3 Reviewed-on: https://chromium-review.googlesource.com/c/1474517 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#634547}
-
Oksana Zhuravlova authored
This change adds .mojom-blink-test-utils.h to the list of allowed header suffixes in the presubmit checks. Bug: 922875 Change-Id: I2cb51817c43a56480ad780f40372dca67ae14e71 Reviewed-on: https://chromium-review.googlesource.com/c/1481088Reviewed-by:
-
Elly Fong-Jones authored
Per email discussions, this will expire for now in M76. Bug: None Change-Id: Iaad798936c451a8e5dbf7f93ec2bf9bb9902d53f Reviewed-on: https://chromium-review.googlesource.com/c/1479836 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#634545}
-
Alex Danilo authored
Sub-menus are reduced in height when the viewport height is reduced so the sub-menu won't fit without clipping, however it isn't increasing height when viewport height is increased. This CL fixes it, by always setting the sub menu height and toggling the overflowY behaviour (auto or scroll). Bug: 934207 Tests: Ran all browser and unit tests, added unit test. Change-Id: I33ec8720b8350924b8e631debede8cad4eb5fb05 Reviewed-on: https://chromium-review.googlesource.com/c/1481285Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#634544}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ee4fa0785090..b9039bf76bf3 git log ee4fa0785090..b9039bf76bf3 --date=short --no-merges --format='%ad %ae %s' 2019-02-22 syoussefi@chromium.org Vulkan: fix numerous formats missing support Created with: gclient setdep -r src/third_party/angle@b9039bf76bf3 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Ia79cef965f2e4d60fdac184d9722b0a760a66f19 Reviewed-on: https://chromium-review.googlesource.com/c/1481967Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/76fb06310126..5100fd8f459d git log 76fb06310126..5100fd8f459d --date=short --no-merges --format='%ad %ae %s' 2019-02-22 simonhatch@chromium.org Pinpoint - Use buildset tags instead of properties. 2019-02-22 rmhasan@google.com Adds a new function to the serially executed browser test API 2019-02-22 sadrul@chromium.org Reland "speed: Look only for the appropriate devices/browsers." 2019-02-22 crouleau@chromium.org Make testScrollDistanceSlowWheel accept more delta Created with: gclient setdep -r src/third_party/catapult@5100fd8f459d The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:828649,chromium:698902,chromium:932409,chromium:934537 TBR=sullivan@chromium.org Change-Id: I62a1e8a42e9b4c494612049e188e60f42b6c868b Reviewed-on: https://chromium-review.googlesource.com/c/1481963Reviewed-by:
-
Takuto Ikuta authored
This reverts commit cd38dfe2. Reason for revert: speculative revert for https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-cronet-arm-rel/14109 Original change's description: > [Mojo Lite] Remove externs generators and use for-compile generators everywhere. > > This CL removes the Mojo Lite externs generators and compiles all WebUIs > with the for-compile targets instead. > > Structurally, all Mojo types are now Closure record typedefs, and their > generated business logic is underneath a Spec object to prevent the name > collisions that were happening in the original implementation. > > All goog.requires have also been dropped, and goog.provides are now > per interface/struct/enum. > > This CL paves the way for generating single file Closure compiled blobs > that have all the Mojo bindings for a single WebUI. > > TBR=kinuko@chromium.org > > Bug: 914149 > Change-Id: I8866fa9eaa707b2db42369e695ed0a51c373c6b6 > Reviewed-on: https://chromium-review.googlesource.com/c/1476886 > Commit-Queue: calamity <calamity@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#634527} TBR=kinuko@chromium.org,calamity@chromium.org,rockot@google.com Change-Id: I58267fe8c16088a33fcc067a61b2d869b855a899 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 914149 Reviewed-on: https://chromium-review.googlesource.com/c/1482430Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#634541}
-
Ramin Halavati authored
Incognito Window Counter's view is moved from incognito_window_count_view.* into profile_chooser_view.* to make it compatible with other profile menues. Bug: 896235, 931320, 932048, 933697 Change-Id: I21600e64560be6a0bd309e73ff735ad59b13cafa Reviewed-on: https://chromium-review.googlesource.com/c/1477012Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#634540}
-
CJ DiMeglio authored
Previously, the user got no indication via screenreader that a media element was unplayable. This CL adds aria attributes onto the element to indicate the unavailability of playback. Bug: 926277 Change-Id: I2fc1c4b3a5a95d0a8686b3dd3aa20041780b105b Reviewed-on: https://chromium-review.googlesource.com/c/1444813 Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#634539}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromiue.org Change-Id: I340703d1ec143fb45cb1be12e797b3ee2b0446d4 Reviewed-on: https://chromium-review.googlesource.com/c/1482147Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#634538}
-
Prabir Pradhan authored
This CL creates the creates the relative pointer manager that uses the wayland extension relative-pointer-unstable-v1. It also adds and implements the RelativePointerDelegate, which the is used to send relative motion events through the OnPointerRelativeMotion method. Whenever pointer capture is requested, we hide the pointer and send relative movements though the RelativePointerDelegate. If a RelativePointerDelegate is created, we assume that pointer capture is enabled, and when it is destroyed, we assume pointer capture is disabled. Bug: 121287287 Change-Id: Ie7f662afcc15cb2e538cd22ad56409798d1757c1 Reviewed-on: https://chromium-review.googlesource.com/c/1388298 Commit-Queue: Prabir Pradhan <prabirmsp@chromium.org> Auto-Submit: Prabir Pradhan <prabirmsp@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#634537}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e9912ca049a0..6a00e68a3448 git log e9912ca049a0..6a00e68a3448 --date=short --no-merges --format='%ad %ae %s' 2019-02-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 3fc635ac4a7f..b607bc8800c1 (2 commits) Created with: gclient setdep -r src/third_party/skia@6a00e68a3448 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I577f13f997658afb096cad7c0b76b37f15f03b2d Reviewed-on: https://chromium-review.googlesource.com/c/1481966Reviewed-by:
-
Zhenyao Mo authored
This is a followup from https://chromium-review.googlesource.com/c/chromium/src/+/1480973 BUG=867155 TEST=GPU Win10/Intel bots,manual R=sunnyps@chromium.org Change-Id: I6dbc86fab7c056498d57fa72b4df83b3ef845ced Reviewed-on: https://chromium-review.googlesource.com/c/1482132Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#634535}
-
Nate Fischer authored
No change to the legacy code path. This implements #hasCookies for the network service code path. Because removeExpiredCookies() depends on this, this fixes that API as well. This removes passing tests from the filter. Bug: 931641, 933629, 902641, 933462 Test: run_webview_instrumentation_test_apk \ Test: --enable-features=NetworkService,NetworkServiceInProcess \ Test: -f CookieManagerTest.testRemoveSessionCookiesNullCallback: \ Test: CookieManagerTest.testCookiesExpire: \ Test: CookieManagerTest.testHasCookie: \ Test: CookieManagerTest.testRemoveAllCookies: \ Test: CookieManagerTest.testSetCookieNullCallback Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo Change-Id: Iee74af405862b34225b779c5b7636052772da5df Reviewed-on: https://chromium-review.googlesource.com/c/1477922 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#634534}
-
