GitLab

This is a reland of 765c53e1

Original change's description:
> infra: Migrate builders to Goma RBE (iOS Week 1a)
> 
> These are the two builders in webrtc.fyi:
> - WebRTC Chromium FYI ios-device
> - WebRTC Chromium FYI ios-simulator
> 
> These builders are small. They are expected to have a peak traffic of
> 15 QPS:
> https://docs.google.com/spreadsheets/d/1-XKh-CqSoUcXEqCETVywjmIo1C18P0qEBDCY50ozBb0/edit#gid=1721756715
> 
> Schedule of migration:
> https://docs.google.com/spreadsheets/d/1TZhpasm6iceYm7zqkyEtZ1wn9ZcpREfH4LV4cusICJA/edit#gid=0
> 
> R=agable@chromium.org, bpastene@chromium.org, jbudorick@chromium.org, tikuta@chromium.org
> 
> Bug: 950413
> Change-Id: Id47cc7887bbefaf4dfe9f72275b80c8f04c428a7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043185
> Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
> Reviewed-by: Ben Pastene <bpastene@chromium.org>
> Reviewed-by: smut <smut@google.com>
> Commit-Queue: Simon Que <sque@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#739771}

Bug: 950413
Change-Id: Idf2146ed92e80075675c15b79f9d65633458258f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074178Reviewed-by: smut <smut@google.com>
Reviewed-by: Aaron Gable <agable@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Simon Que <sque@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746203}

This happens when the WebContents being destroyed. If the
InterstitialPage is showing we only clear the reference
to the native WebContentsAccessibility from InterstitialPage's
BrowserAccessibilityManager, use-after-free will be happened
when the |WebContents->GetMainFrame|'s BrowserAccessibilityManager
destroyed.

Change RawPtr of WebContentsAccessibilityAndroid to WeakPtr.

Bug:1056882

Change-Id: Id1efea84aef6c7437a178f7006bc09035949bbcb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063789
Commit-Queue: Bo <boliu@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746202}

Bug: 1057855
Change-Id: I7a2ffbea114ffffefaaed2c011fb9de5fe7e1923
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084032
Commit-Queue: Rakesh Soma <rakeshsoma@google.com>
Auto-Submit: Rakesh Soma <rakeshsoma@google.com>
Reviewed-by: Yusuf Sengul <yusufsn@google.com>
Cr-Commit-Position: refs/heads/master@{#746201}

TabletModeTransitionTest.EnterExit and HomeScreenTest.DragginPerformance
are failing on Linux ASAN bots. We will probably be removing them
sometime soon but for now, keep the bots happy by disabling.

TBR=xiyuan@chromium.org

Test: none
Bug: 1057864
Change-Id: Ib434d6295289a0795dd25cc15ac6c150b57bde6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083939Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746200}

Round sensor values to multiples of a reasonably small value to
protect user privacy. This makes the readings slightly less
accurate, but protects users from fingerprinting attacks which
might allow a site to generate a unique id based on the sensor
calibration data. The affected sensors are:

1. ACCELEROMETER.
2. LINEAR_ACCELERATION.
3. GYROSCOPE.
4. ORIENTATION (Euler & Quaternion, absolute & relative).

Bug: 1018180, 1031190
Change-Id: Iafe84ec9fcf12cfdfde1898da011d63dd419bfa4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003614Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Vincent Scheib <scheib@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Chris Mumford <cmumford@google.com>
Cr-Commit-Position: refs/heads/master@{#746199}

This change fixes bug introduced in https://crrev.com/c/2079298.
Android views include view paddings when computing view size (both
height and width), resulting in the padding being accounted for when
comparing the resulting dimensions against minimum dimension hints.

As an effect, the view becomes much more compact than originally
intended.

Bug: 1050813

Change-Id: Icffff1a6bbd4c4608fc77f25a4ba0c9708431835
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083921Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Ender <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#746198}

This is a reland of 95ad9e5a

Original change's description:
> media/gpu/vaapi: Create VAImage with va surface size on UploadVideoFrameToSurface()
>
> This is a workaround of the failure at 1080p video encoding
> test on grunt.
>
> Originally vaCreateImage is created with a coded frame size.
> However, it causes SEGV_MAPERR on vaPutImage, which copies
> vaImage to vaSurface.
>
> As a result of experiments, the vaImage size needs to be the
> same as va surface size. Since this is not stated in VA-API
> document, so this might be a bug of AMD gallium driver.
>
> Besides of the workaround, this CL copies visible size area
> of VideoFrame to the VAImage.
>
> Bug: 1048908
> Bug: 1050377
> Bug: b:148744040
> Test: video.EncodeAcel.* on grunt, eve and soraka
> Test: camera.* on grunt, eve and soraka
> Change-Id: I1ee853964387846d2452e72cfbd4c939f0a18f62
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041382
> Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
> Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#744953}

TBR=andrescj@chromium.org

Bug: 1048908, 1050377, b:148744040
Change-Id: If43571fdc386a7f92f36689a9c78cbcda5ba6829
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082301Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746197}

Just moved all the methods across for now to ensure tests were not
affected by this cleanup change. Some duplication (now within TABM)
could be cleaned up in future.

In prep for making an ABM factory as suggested by bsep@ in
crrev.com/c/2075001

Change-Id: Idcaad639bcc270a7ed3cc1f77f88b0fd5f2366a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082220
Commit-Queue: Glen Robertson <glenrob@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746196}

Using wpt-import in Chromium ef326b6a.
With Chromium commits locally applied on WPT:
d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=smcgruer

No-Export: true
Change-Id: Id9bc3d6c6e4ac268251cfd651788b18a56596436
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083692Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#746195}

There was a small jump observed when we scaled the icon on long press.
We need to scale the padding of the icon as well as we are making the
icon bigger.

Bug: 1050730
Change-Id: I0aaa015a121963742e179319a8aa6ccc333251e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083605
Commit-Queue: Ana Salazar <anasalazar@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746194}

These subpages have existed for a long time, but they did not have
associated constants.

Change-Id: Ib5612190dde72ee66ed53d6b76ee7f5d90e5f826
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080891
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746193}

To ensure that ARC would consistently get IP properties from the host
for all networks, change-id I24d26d6492f133e0c38949c8c3b4403687bfac21
(https://chromium-review.googlesource.com/c/chromium/src/+/2028881)
added a delayed property update request to shill when ArcNetHostImpl
cannot retrieve IP properties for a Shill connected Service.

However, one such request will trigger multiple property updates from
Shill and will retrigger the same codepath in ArcNetHostImpl that asked
for the property update request. This amplification can lead to an
infinite loop between Chrome and Shill incurring high CPU usage on the
system when ArcNetHostImpl will keep failing to find the IP properties
from the ONC properties or from the Device cached state.

This patch prevents this loop from happening at a high frequency by
making sure that at most one delayed property update request is
scheduled. A follow-up patch will add exponential backoff for the retry
delays.

It was reported in crbug/1054676 to happen consistently for the case of
native VPNs backed by a WiFi connection (i.e it does not happen with
VPNs backed by ethernet). The reason why ArcNetHostImpl fails to find IP
properties in that specific scenario is still unknown and will be
investigated separately.

BUG=1054676
TEST=Compiled, connected L2TP VPNs, observed that logs patterns seen in
crbug/1054676 do not happen and that cpu% of shill, chronos, and
system_server stays at normal levels.

Change-Id: I2a39ba9c8d14cf42b6b0dbdd10c885bf5be09cfa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078372
Commit-Queue: Hugo Benichi <hugobenichi@google.com>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746192}

This CL recognizes that https://url.spec.whatwg.org/#scheme-start-state
only allows "ASCII alpha" as the first letter of a URL scheme.  Thanks
to this change, "1:..." is not treated as an absolute URL.

Fixed: 530123
Change-Id: I5ebadaebab18aebb5903968d14f39f092057f3cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080075Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746191}

Modify the log replay tool so it can pass arbitrary flags to
ChromeDriver. This is needed for the investigation of an internal
bug, to pass flags such as --disable-build-check.

Bug: b/147732888

Change-Id: Ic38ce33da006965e4861467a37cb0209c9ca9b3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079609
Commit-Queue: John Chen <johnchen@chromium.org>
Auto-Submit: John Chen <johnchen@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746190}

TBR=rsleevi@chromium.org

Change-Id: I7f2aa4433f7686c116285a03c919fc74e6364560
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083396Reviewed-by: Nick Harper <nharper@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746189}

A previous CL (https://crrev.com/c/2001745) only sets the rounded
corners of shelf container when the ink drop of the app icon is
activated by gesture. However, it misses the case that during scroll
animation the rounded corners are also needed. This CL enables the
rounded corners during hotseat scroll animation.

In addition, this CL utilizes shelf button delegate to call the host
view's function from shelf app button. It improves the code readability.

Bug: 1055992
Change-Id: I59285bd693ab6e8833f1f82f9212c7a5195ce3ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076538Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746188}

Change-Id: I01d2cd7b2202cc3acc59a189001f76d9ed980c7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080448Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746187}

This reverts commit 95ad9e5a.

Reason for revert: crbug.com/1057857

Original change's description:
> media/gpu/vaapi: Create VAImage with va surface size on UploadVideoFrameToSurface()
>
> This is a workaround of the failure at 1080p video encoding
> test on grunt.
>
> Originally vaCreateImage is created with a coded frame size.
> However, it causes SEGV_MAPERR on vaPutImage, which copies
> vaImage to vaSurface.
>
> As a result of experiments, the vaImage size needs to be the
> same as va surface size. Since this is not stated in VA-API
> document, so this might be a bug of AMD gallium driver.
>
> Besides of the workaround, this CL copies visible size area
> of VideoFrame to the VAImage.
>
> Bug: 1048908
> Bug: 1050377
> Bug: b:148744040
> Test: video.EncodeAcel.* on grunt, eve and soraka
> Test: camera.* on grunt, eve and soraka
> Change-Id: I1ee853964387846d2452e72cfbd4c939f0a18f62
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041382
> Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
> Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#744953}

TBR=hiroh@chromium.org,andrescj@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1048908, 1050377, b:148744040, 1057857
Change-Id: I21fa0d014fdf2bd18fa2629772fb4b822913c82d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083867Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746186}

Change-Id: I51ff41c1ceece2f8e7d059fb29b12710ab814f07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083932Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746185}

This reverts 5c7bccda.

It will be re-landed along with a fix for the memory leak.

TBR=boliu@chromium.org

Bug: 1057127
Change-Id: I4c4cf16a9b94a37a5b77f77c89b948d8aecc48ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083745Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746184}

... as SelectType::DidBlur().

DispatchEventsIfSelectedOptionChanged() is now used only by
MenuListSelectType. This CL removes |SelectType::
DispatchEventsIfSelectedOptionChanged()|, and makes |MenuListSelectType
::DispatchEventsIfSelectedOptionChanged()| private.

This CL has no behavior changes.

Bug: 1052232
Change-Id: I791b4377719cc629d26d96f5c79a4ccd91ac9bbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081721Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746183}

When moving code around to ensure the token displays on
chrome://safe-browsing, the std::move(token) was placed before the last
usage of token.

Fixed: 1057309
Change-Id: Ic44c71f35d69fac0996246a6b7159c1b5c5fb011
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083393
Auto-Submit: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Bettina Dea <bdea@chromium.org>
Reviewed-by: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746182}

This causes test to fail faster and with better output if there's a
typo in the page's URL, for example.

Only one test was relying on a 404 to be counted as "success", and
it's easily updated.

Change-Id: Iccdbbbf87ae05db4e128583fb7a2a612cc01b26e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083622
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746181}

non_fast_scrollable_region has been moved onto cc::Layer and no longer
needs to be set from PropertyTreeManager::CreateCompositorScrollNode.

Change-Id: I36419beb55980b102de1c818cf9e6b5bf301bffb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083385
Commit-Queue: Philip Rogers <pdr@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Auto-Submit: Philip Rogers <pdr@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746180}

This is a reland of b9f529d2

The underlying host has been updated to 10.14.

Original change's description:
> Promote Mac10.14 Tests to main waterfall
>
> Mac10.14 Tests is now stable and green, and is ready to be promoted
> to the main waterfall alongside its prior-release siblings. This CL
> makes a few changes to accomplish that:
> 1) Updates the OS of the existing main waterfall Mac Builder to 10.14
> 2) Moves Mac 10.14 Tests to be triggered by Mac Builder
> 3) Moves it from just master (like all FYI bots) to exist in branch CI
>    as well
> 4) Moves it from FYI to CI consoles
>
> This change leaves Mac Builder Next intact, so that it can be updated
> and used for 10.15 soon.
>
> Bug: 1018852
> Change-Id: I3d5723ab7c565c37681696acb2f2de79ddcac1f2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036769
> Commit-Queue: Aaron Gable <agable@chromium.org>
> Auto-Submit: Aaron Gable <agable@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#746074}

Bug: 1018852
No-Try: true
Change-Id: Iba891f297a9c9a492f1d289d72a3dd178a2b5b19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083953Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746179}

ElementRareData is already traced in Node::Trace(), so there's no need
to double-trace it in Element::Trace().

By removing the conditional tracing that depends on node flags, this
also fixes a data race between main thread and GC thread, which should
not check node flags.

Bug: 1056233
Change-Id: If51f7946c5c41240cdc28969fb6eaad8891ff66e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083817Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Omer Katz <omerkatz@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746178}

https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/11975fe9f6ed..6a431038c911

git log 11975fe9f6ed..6a431038c911 --date=short --first-parent --format='%ad %ae %s'
2020-03-02 moazinkhatri@gmail.com [gzip] Support `gzip' encoded header conditionally.

Created with:
  gclient setdep -r src/third_party/freetype/src@6a431038c911

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/freetype-chromium
Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel
Bug: None
Tbr: bungeman@google.com,drott@google.com,thestig@google.com
Change-Id: I6a8ed93422566b44098eb445be33a2bc3437f741
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083218Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: Ben Wagner <bungeman@chromium.org>
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746177}

Register cras_audio_handler to be an observer of MediaController in
order to receive update of media session playback status. Parse such
playback status into string and call corresponding AudioClient function
to propagate the information further to DBUS.

BUG=b:147367681
TEST=chromeos_unittests

Change-Id: I122fa0d3aa5f59a5828c0075617271fcf61ede94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076061Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Michael Sun <michaelfsun@google.com>
Cr-Commit-Position: refs/heads/master@{#746176}

We change this early return to a DCHECK as we are guaranteed to have a
committed navigation entry, since about:blank cannot host a portal.

Bug: 914108
Change-Id: I41f998711b6d7d2ec1163dc9ccbdb5f0edc63969
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082906
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Auto-Submit: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746175}

map() returns a list in Python 2. Python 3 returns an iterator.
Wrapping in a list() results in the same behaviour on both.

Traceback (most recent call last):
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 569, in <module>
    sys.exit(main())
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 564, in main
    return args.func(args, remaining_args)
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 280, in _Generate
    processor._GenerateModule(
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 225, in _GenerateModule
    AddComputedData(module)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\generator.py", line 191, in AddComputedData
    _AddInterfaceComputedData(interface)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\generator.py", line 152, in _AddInterfaceComputedData
    method.param_struct = _GetStructFromMethod(method)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\generator.py", line 172, in _GetStructFromMethod
    _AddStructComputedData(False, struct)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\generator.py", line 126, in _AddStructComputedData
    struct.packed = pack.PackedStruct(struct)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\pack.py", line 141, in __init__
    src_fields.append(PackedField(field, index, ordinal))
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\pack.py", line 86, in __init__
    self.size = self.GetSizeForKind(field.kind)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\pack.py", line 63, in GetSizeForKind
    raise Exception("Undefined type: %s. Did you forget to import the file "
Exception: Undefined type: x:IndexId. Did you forget to import the file containing the definition?

Traceback (most recent call last):
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 565, in <module>
    sys.exit(main())
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 560, in main
    return args.func(args, remaining_args)
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 276, in _Generate
    processor._GenerateModule(
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 245, in _GenerateModule
    generator.GenerateFiles(filtered_args)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 491, in GenerateFiles
    self.WriteWithComment(self._GenerateModuleSource(),
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\template_expander.py", line 37, in GeneratorInternal
    return ApplyTemplate(args[0], path_to_template, parameters, **kwargs)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\template_expander.py", line 31, in ApplyTemplate
    return template.render(params)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\..\..\..\..\..\..\..\third_party\jinja2\asyncsupport.py", line 76, in render
    return original_render(self, *args, **kwargs)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\..\..\..\..\..\..\..\third_party\jinja2\environment.py", line 1008, in render
    return self.environment.handle_exception(exc_info, True)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\..\..\..\..\..\..\..\third_party\jinja2\environment.py", line 780, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\..\..\..\..\..\..\..\third_party\jinja2\_compat.py", line 37, in reraise
    raise value.with_traceback(tb)
  File "gen\mojo\public\tools\bindings\cpp_templates.zip\tmpl_443233f41d2b3f893c5bf0eb0f069e01da908ebe.py", line 89, in <module>
  File "gen\mojo\public\tools\bindings\cpp_templates.zip\tmpl_c45f6ba3b78f1db0b9ac3d8f2287ed476074b615.py", line 15, in <module>
  File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 521, in _DefaultValue
    expression = self._ExpressionToText(field.default, kind=field.kind)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 852, in _ExpressionToText
    return self._TranslateConstants(value, kind)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 830, in _TranslateConstants
    return self._GetNameForKind(token, flatten_nested_kind=True)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 530, in _GetNameForKind
    return _NameFormatter(kind, self.variant).FormatForCpp(
  File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 73, in FormatForCpp
    return self.Format(
  File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 68, in Format
    parts.extend(self._GetName(internal, flatten_nested_kind))
  File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 94, in _GetName
    name_parts.append(self._token.name)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\module.py", line 273, in name
    return self.field.name
AttributeError: 'EnumField' object has no attribute 'name'

Traceback (most recent call last):
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 565, in <module>
    sys.exit(main())
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 560, in main
    return args.func(args, remaining_args)
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 276, in _Generate
    processor._GenerateModule(
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 245, in _GenerateModule
    generator.GenerateFiles(filtered_args)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 491, in GenerateFiles
    self.WriteWithComment(self._GenerateModuleSource(),
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\template_expander.py", line 37, in GeneratorInternal
    return ApplyTemplate(args[0], path_to_template, parameters, **kwargs)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\template_expander.py", line 31, in ApplyTemplate
    return template.render(params)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\..\..\..\..\..\..\..\third_party\jinja2\asyncsupport.py", line 76, in render
    return original_render(self, *args, **kwargs)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\..\..\..\..\..\..\..\third_party\jinja2\environment.py", line 1008, in render
    return self.environment.handle_exception(exc_info, True)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\..\..\..\..\..\..\..\third_party\jinja2\environment.py", line 780, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\..\..\..\..\..\..\..\third_party\jinja2\_compat.py", line 37, in reraise
    raise value.with_traceback(tb)
  File "gen\mojo\public\tools\bindings\cpp_templates.zip\tmpl_443233f41d2b3f893c5bf0eb0f069e01da908ebe.py", line 95, in <module>
  File "gen\mojo\public\tools\bindings\cpp_templates.zip\tmpl_cdddecaaf43ca3c14ffb4bf4ac7c495e7415ba70.py", line 2, in <module>
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\..\..\..\..\..\..\..\third_party\jinja2\environment.py", line 430, in getattr
    return getattr(obj, attribute)
jinja2.exceptions.UndefinedError: map object has no element 0

Traceback (most recent call last):
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 565, in <module>
    sys.exit(main())
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 560, in main
    return args.func(args, remaining_args)
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 276, in _Generate
    processor._GenerateModule(
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 221, in _GenerateModule
    AddComputedData(module)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\generator.py", line 187, in AddComputedData
    _AddStructComputedData(True, struct)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\generator.py", line 126, in _AddStructComputedData
    struct.packed = pack.PackedStruct(struct)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\pack.py", line 141, in __init__
    src_fields.append(PackedField(field, index, ordinal))
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\pack.py", line 86, in __init__
    self.size = self.GetSizeForKind(field.kind)
  File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\pack.py", line 63, in GetSizeForKind
    raise Exception("Undefined type: %s. Did you forget to import the file "
Exception: Undefined type: x:EnforcementLevel. Did you forget to import the file containing the definition?

Bug: 941669
Change-Id: Ia19f39d4134fb063c4407eb20a4f909f693e6f27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081812
Auto-Submit: Raul Tambre <raul@tambre.ee>
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#746174}

RadioButtonWithDescription#setCheckedWithFocusChange is trying to
unchecked other radio button when this current radio button is checked.
For those flipping-to-unchecked radio buttons, we want to call
#setChecked rather than #setCheckedWithFocusChange to cooperate focus
changes.

Bug: 1048863, 1053747
Change-Id: Ia12f5a613594a283f5289c1516bc5e6dfeef2aae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081524Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746173}

BUG=1057570

Change-Id: Id1575ae9ff546a3f0d3ecb7353f3f4a60fd7c82e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084031Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746172}

This CL trades space for time in |MergeSequentialAdjustments|. By
allocating a new |Adjustments| vector, we can avoid calling
|std::vector::insert| in a loop, which costs roughly O(n^2) time. With
the additional vector, we only need to call |std::vector::push_back|,
costing roughly O(n) time in total.

Bug: 1017193
Change-Id: I7beb2c3c0b6a9cb7616a22f4a4355285fd281894
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070605Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746171}

Bug: 1009005b
Change-Id: I629c8f297758366383922d33e6f646d2ce2fbad2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082023Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746170}

In Python 3 operations on files opened in binary mode have to be done with bytestrings.
Python 2 doesn't care, so it happens to work.
Don't open the files in binary mode, as they aren't used as such.

Traceback (most recent call last):
  File "../../mojo/public/tools/bindings/concatenate_and_replace_closure_exports.py", line 73, in <module>
    main()
  File "../../mojo/public/tools/bindings/concatenate_and_replace_closure_exports.py", line 70, in main
    exit(0 if ConcatenateAndReplaceExports(args) else 1)
  File "../../mojo/public/tools/bindings/concatenate_and_replace_closure_exports.py", line 58, in ConcatenateAndReplaceExports
    FilterLine(filename, line, target)
  File "../../mojo/public/tools/bindings/concatenate_and_replace_closure_exports.py", line 30, in FilterLine
    if line.startswith("goog.require"):
TypeError: startswith first arg must be bytes or a tuple of bytes, not str

Bug: 941669
Change-Id: Ic373069e87707eb28ca1b3bf60556f066c19c5d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081413
Auto-Submit: Raul Tambre <raul@tambre.ee>
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#746169}

ExtensionPopup::OnExtensionUnloaded() deletes the ExtensionHost,
we destroy the WebContents, this leads to detaching of DevTools
sessions which will be reported to
ExtensionPopup::DevToolsAgentHostDetached where we access host.
Oops.

Bug: 1052057
Change-Id: I34e03582beb61c0308ad35bc973dc5cd4e26a5b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066506
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Johannes Henkel <johannes@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746168}

If you open app window (e.g., chrome://apps,
right click on Youtube, check "open in window", and open it),
then left click just to the right of "Youtube" in the title bar of the app
window, and then right click, a second context menu gets opened.

This CL makes HwndMessageHandler ignore the right click when displaying
a system menu opened with left click.

Bug: 1053460
Change-Id: I0c32cf30995ce6e970c93d40a2e20b7b2f63d3a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071253Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746167}

This reverts commit 2e28f009.

Reason for revert: suspecting to cause crashes, http://crbug.com/1052107

Original change's description:
> Remove ScriptContext::ScopedFrameDocumentLoader
> 
> This scope is used to map Frame to just-about-to-commit DocumentLoader.
> 
> With https://crrev.com/706529, we now call ReadyToCommitNavigation
> after the commit (as opposite to before the commit). Therefore,
> WebLocalFrame::GetDocumentLoader is already the right one and we don't
> need a scoped mapping.
> 
> Bug: 855189
> Change-Id: I95621b00ee4391986f063e56f20d8d7d25b5c532
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2046210
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#740198}

TBR=dgozman@chromium.org,rdevlin.cronin@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 855189
Change-Id: I7021f96e4c6db2a41f048113b369eee7a21b07ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083390Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746166}

FullURLLookupWithToken is enabled when:
1 FullURLLookup is enabled.
2 The user is syncing their browsing history.
3 Custom passphrase is disabled.

Bug: 1041912
Change-Id: Ie477512e9cd311d7db8891cc8a0bd7daf0559293
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071385
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746165}

Bug: 1041047
Change-Id: I43fafa456579ab0c760e278f8972bd82b2bc187a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078555
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746164}