- 16 Dec, 2020 40 commits
-
-
Victor Hugo Vianna Silva authored
- Make sure the non-obsolete/expired ones have at least 2 owners. - Move components/invalidations/ histograms from */others/histograms.xml to a new */invalidation/histograms.xml. - Remove code recording expired/obsolete histograms. Fixed: 1158383 Change-Id: Ie3c7ab0334b0458057e63429927c09c88e1cef4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589975Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#837492}
-
Victor Hugo Vianna Silva authored
Sync.{CookieJarEmptyOnMismatch,CookieJarMatchOnNavigation} have been expired since M77. This CL marks them as obsolete and removes the associated plumbing to record them, which is considerable. Bug: 1158449 Change-Id: I03a9c48c17ba71508f96fb122b522ba03300d773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589836Reviewed-by: -
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/98b56e604256..328f72ae21cb 2020-12-16 jmadill@chromium.org Update VVL directories in Android build. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: Icfecc90a301694ad1edd3fdf750f3adc5dc337dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593600Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837490}
-
Nick Diego Yamane authored
Do not dcheck for mouse button state when processing the drop event as it causes crashes in lacros when the tab drag session is triggered by touch events. Upcoming CLs will add actual support for touch-based tab drag sessions. R=msisov@igalia.com Bug: 1158557 Change-Id: Ic68a076934dbe669fb713d4a4f9ce9a02d008e91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594021Reviewed-by:
Maksim Sisov (slow) <msisov@igalia.com> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Auto-Submit: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#837489}
-
Alan Cutter authored
This CL updates the YouTube default web app to install as opening in a window. This only affects new users on Chrome OS. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=481158&signed_aid=oxtHhds0ncHcPrMr76xdvA==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=481159&signed_aid=B2AAZpgZRJqHpeXt61yyrw==&inline=1 Bug: 1159306 Change-Id: I59b3f83c801596520c37995d849a156e4c0fd89c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592076 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#837488}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d224369988e1..c29aca88aeb5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC aboxhall@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1159112 Tbr: aboxhall@google.com Change-Id: If19650b99c8b850e89a79218149b2be954342444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594194Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837487}
-
Alice Wang authored
This CL refactors account_picker MVC with LayoutViewBuilder. Bug: 1158373 Change-Id: I7f9ea3959eb7922a40f3bc2a05673332a1a1d025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588913Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#837486}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1608076760-b9ea13a2a007bc956431b47b7a25fe6a939d9e2a.profdata to chrome-mac-master-1608097529-4473bb129a43d499a6f4ca2ef772a18f6300cda1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I05495bad6f0a11e6e9d37d62bde91d84ff8805e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594197Reviewed-by:
-
Mike West authored
We never landed metrics to measure the impact of the proposal in https://github.com/w3c/webappsec-referrer-policy/pull/124. This patch remedies that oversight. Bug: 1158426 Change-Id: Iccde2a755d7003a401a80e6c085a5ad97ac87389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589875Reviewed-by:
Eric Lawrence [MSFT] <ericlaw@microsoft.com> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#837484}
-
Nancy Wang authored
Add the class RestoreHandler to call FullRestoreFileHandler to read the full restore data file, and load the RestoreData. RestoreHandler is used at the system startup phase to load the restore data for restoration. There will be a separate CL to add tests. Bug:1146900 Change-Id: If43082936394997f5b8e90125b43baa6577e9f38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592275 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#837483}
-
Shik Chen authored
This reverts commit 135a698d. Reason for revert: http://b/175756864 Original change's description: > camera: Support focus distance control > > This CL adds focusMode(continuous/manual) and focusDistance > MediaTrackCapabilities. > > Bug: b:151048287, 1068176 > Test: Tested logitech camera on eve. Test WFC of kukui. > Change-Id: I85fa31b8b4f147b8cc054eac3f94974595545c05 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371843 > Commit-Queue: Hsu Wei-Cheng <mojahsu@chromium.org> > Reviewed-by: Wei Lee <wtlee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#836565} TBR=shik@chromium.org,mojahsu@chromium.org,wtlee@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b:151048287 Bug: 1068176 Change-Id: Id5a76aa173401b9f7f1391c8de2e65709cef38ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594618Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#837482}
-
Jan Wilken Dörrie authored
This reverts commit f41cb9eb. Reason for revert: Likely culprit of https://crbug.com/1159333. Original change's description: > Re-enable Mac Document/Window idlharness WPT > > This reverts commit 0e528de2. The test > should be passing now that web platform tests has fully synced its IDL > with the HTML spec, and the -expected.txt files have been regenerated > with the latest Chrome implementation. > > Original change's description: > > Sheriff: Fix Mac WPT > > > > TBR: domenic > > Bug: 1158672, 1157917 > > Change-Id: Ie10cad8aa48f989a8fd76eda0ed3e605b09fafb0 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592228 > > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > > Commit-Queue: Luciano Pacheco <lucmult@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#836992} > > Bug: 1158672 > Bug: 1157917 > Change-Id: If3e717b05de26d26595c649979f52e5d3343ae62 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593887 > Reviewed-by: Stephen McGruer <smcgruer@chromium.org> > Commit-Queue: Domenic Denicola <domenic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#837250} TBR=domenic@chromium.org,smcgruer@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Id76f561ca0c38c735fa9861be9c43a3329e01f2b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1158672 Bug: 1157917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594907Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#837481}
-
Antonio Sartori authored
In the Blink Content Security Policy code, for parsing the 'plugin-types' directive, we switch from using the internal blink type blink::MediaListDirective to using a Vector<String> as in the mojo type network::mojom::blink::ContentSecurityPolicy. This is part of a project to harmonize the CSP code in Blink and in services/network, and will make it easier to synchronize Content Security Policies between the two. Bug: 1021462,1149272 Change-Id: I26e2625f825c23f0e8ea557f5acfe3c94313ce9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563547 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#837480}
-
Maggie Cai authored
This CL extends the intent-picker-pwa-persistence flag to M92 given it is not lanched yet. BUG=853604 Change-Id: If996223ce26e2865d4b33528af2bc02fa6492c2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594828Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1608076760-d4793f464fd5473cef2d681bda9559291286bad5.profdata to chrome-linux-master-1608097529-96e83b64d2e55c9fef1094979ebe73b794f619fe.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic15c17a9590b78b1309e530aad05db6d78e47016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594195Reviewed-by:
-
Alice Wang authored
This CL moves SignOutDialogRenderTest to signin.ui module. Bug: 1157415 Change-Id: I67fc8bc55c1779a6f27f8cdc6efb807c34e40814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593090Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#837477}
-
Alice Wang authored
This CL adjusts the access level for confirm sync data classes as the modularization for this part is done. Bug: 1155123 Change-Id: Idf8ab39b655799f75c68486ec3a06b67ea2acb5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593097Reviewed-by:
-
Jason Lin authored
Bug: b/167491603 Change-Id: Ie4da3308869873ba57699daa4cc32659d188615e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592577 Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#837475}
-
Tal Pressman authored
Before this CL, DomWindow was marked as const, but returned a mutable LocalDOMWindow*. This CL creates two overloads of DomWindow(): - const LocalDOMWindow* DomWindow() const; - LocalDOMWindow* DomWindow; See: https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++-dos-and-donts.md#use-correctly Change-Id: I786fc68ebe92a81ee1822ac06841aed1445889f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592274Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Tal Pressman <talp@google.com> Cr-Commit-Position: refs/heads/master@{#837474}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2f649421. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/css-contain NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I18c22142b0b981a5211d7dbe740a68e73ca653b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592143Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837473}
-
Alice Wang authored
This CL moves the SigninHelper init and getter part to a new class SigninHelper. This helps to isolate the dependency on SyncController in a relatively simple class SigninHelperProvider, so that we can modularize SigninHelper class in short term. In long term, we only need to expose SigninHelperProvider and SigninHelper interface to public, the real implementation of SigninHelper will be package private. Bug: 1158801 Change-Id: I1648ca59778f8c5410843cd1824325bd1fea1f01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593115Reviewed-by:
-
Christopher Cameron authored
Change CanvasResourceParams to use - SkColorType instead of CanvasPixelFormat - SkAlphaType instead of OpacityMode This will allow us to cull CanvasPixelFormat down to just the types that users can specify. Bug: 1157747 Change-Id: I70b23024d6fda00d031e013610347eebae896d92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589354 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#837471}
-
dpapad authored
Specifically: - Serve mocha.js from chrome://test - Load mocha.js and mocha_adapter.js within test_loader.html This allows JS module based tests to simply load mocha.js and mocha_adapter.js with a <script> tag instead of relying on the old |extraLibraries| injection mechanism. Tests that don't already use test_loader.html will be addressed in a follow-up CL. Bug: 1158471 Change-Id: If1c2db28dab3a6de4af04eebb89dd72d9e04a60f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586026Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#837470}
-
Mason Freed authored
Some styles (e.g. webkitUserModify) should not propagate from a ShadowRoot to the children. Note [1] that it is possible all such properties are deprecated. But they still have decent [2] usage. See [3] for what happens if this check is removed. [1] https://crbug.com/687462 [2] https://chromestatus.com/metrics/css/timeline/popularity/338 [3] https://ci.chromium.org/p/chromium/builders/try/linux-rel/570174? Fixed: 1158424 Change-Id: I994691cb63d96d60d8a47d8698ad86a43f8ea10e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593285 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#837469}
-
Sven Zheng authored
This test is flaky only on Lacros. Disable it first. Bug: 1154365 Change-Id: Ie0b5db5f1c6ba2652e359769108262163750c7c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593216Reviewed-by:
-
Alexander Cooper authored
Now that OpenXR support is widespread, we can simplify our codepaths by relying solely on the OpenXR runtime. This change removes the last non-OpenXR runtime. Fixed: 1121632 Change-Id: I108af56cdf0e6c2f41af64e09f80b27b9e9f4183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587691 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#837467}
-
Mirko Bonadei authored
Bug: webrtc:9987 Change-Id: Iae028ac321bffb9c7b0980dd4323fe5d81d5b66f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593088Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#837466}
-
Nancy Wang authored
This is the preparing for the full restore file reading function. Add the construct function for RestoreData to convert the JSON format to the RestoreData. Add the unit tests to verify the convert function: RestoreData -> base::Value -> RestoreData. BUG=1146900 Change-Id: I54133e83e9b7abce62c5812cc5e87941e770f958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591987Reviewed-by:
-
Morten Stenshorne authored
Turns out we can actually just walk down the fragment tree and get this right, now that relative positioning is baked into the offsets. We need to disable some workaround code in NGOutOfFlowLayoutPart, however. That code compensated for the discrepancy between how NG layout works and how NG pre-painting works. This discrepancy doesn't exist when LayoutNGFragmentTraversal is enabled. This simplifies code for NG fragment traversal considerably in FragmentPaintPropertyTreeBuilder::UpdatePaintOffset() (to basically a one-liner), and we can back out the laxness added to some past DCHECKs, since this code path is now only run for non-fragment-traversal. We can also stop using the separate absolute_position and fixed_position contexts. The fragment tree structure should match perfectly with the containing block structure. We should also stop using container_for_absolute_position and container_for_fixed_position in LayoutNGFragmentTraversal. Added TODO. Bug: 1043787 Change-Id: I548fe9537b352ea2b0d5fdeb2d6c3eeed9f30a21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593110Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Alison Maher <almaher@microsoft.com> Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#837464}
-
Jason Lin authored
When camera privacy switch is on, even if a vm is accessing the camera, the camera is considered inactive since the vm can only get black frames. Bug: b/167491603 Change-Id: I159501040da557661a17d61a1fed4499c74d6907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593795 Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
-
Alan Cutter authored
The install path used by offline manifest installation was not updating the WebApplicationInfo according to the InstallParams passed in. This CL fixes that by putting the user_display_mode setting application in the shared ApplyParamsToWebApplicationInfo() helper function that every install path should be using. Bug: 1159306 Change-Id: Ib632621ac3178dd84bbcd805cffe89e438b8572e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593799 Commit-Queue: Alan Cutter <alancutter@chromium.org> Commit-Queue: Glen Robertson <glenrob@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
-
Bao-Duy Tran authored
Extension-based Input Method Framework (IMF) of Chrome OS and Chromium OS for both 1P and 3P has never supported multiple XKB layouts per input method. Likely this is by design, and has been the case for almost 10 years, presumably ever since the migration to extension-based IMF. As of now, each input method ubiquitously implies one and only one XKB physical keyboard layout, throughout IMF and CrOS. The notion also extends to virtual keyboard and other input modalities, given "input method" is really a suite of inputs-related functionalities in CrOS. Also, certain CrOS components rely on this implication, too. This CL removes all anticipative "plural layouts" that's always been unused. Their existence is misleading and illusive; they'd better be gone in the spirit of YAGNI "you aren't gonna need it". For 3P backward compat, unfortunately "plural layouts" need to be kept in the manifest. NOTE: It doesn't quite make sense to arbitrarily fit "multiple layouts per input method" paradigm into IMF in its current form. It'd require major re-design and overhaul of IMF to do so, and probably also need to consider how extension-based input methods would interact with the new paradigm, and whether 1P ones support such paradigm. A discussion [1] took place 4 years ago to support "multi-layouts per input method", given "the manifest allows a list of XKB layout IDs". It was also when "plural layouts" impls were added [2] but ended up being unused while confusing readers and adding clunkiness ever since. Outcome of the discussion aligns with the points above that IMF in its current form and many 1P IMEs aren't at all ready for "multiple layouts per input methods". The solution back then was an ad-hoc private JS API for specific 1P input methods [3], rather than a generic IMF solution. [1] https://crbug.com/170601 [2] https://chromiumcodereview.appspot.com/13949015 [3] https://codereview.chromium.org/1656083003 Bug: 1134465 Change-Id: Iad6dc717b859748cf58f77a4a1bb3b20212c2c73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554280 Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Jing Wang <jiwan@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#837461}
-
Clark DuVall authored
Defining providers in the base module can improve startup performance by giving the chrome split more time to preload. Now that all providers have been moved to the base module, this CL adds a check to make sure we don't accidentally add any in another module. Bug: 1150600 Change-Id: Ifd49034cbf7f1fce1ad2dd7d562b520e0876e93b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591725Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#837460}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b528247a5a9e..d224369988e1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC aboxhall@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1154371 Tbr: aboxhall@google.com Change-Id: I56599520baa1f6a3d659118d4880ea7cfc0e982b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593601Reviewed-by:
-
Nektarios Paisios authored
When an AXTree of Views is added to the existing forest of accessibility trees, and when AXPosition starts being used more on Chrome OS, we'll need a way to determine if a particular node is at the root of a window-like container, in order to be able to easily jump to its beginning or its end. Window-like containers include webpages, PDFs, browser windows, the App List, and the whole desktop. AX-Relnotes: n/a. R=dmazzoni@chromium.org, aleventhal@chromium.org Change-Id: Ic0d0d36d9aba80e50b171d82e8fc97215a4b1694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575259 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#837458}
-
Zach Trudo authored
Within RecordHandlerImpl::HandleSuccessfulUpload there was unguarded access to a base::Optional member. Bug: chromium:1158638 Change-Id: I57d160c15b0d4b2609772e7f792a2df67151a369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592142 Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#837457}
-
Tarun Bansal authored
This CL deletes some parts of the resource loading hints preview code. More deletion will come in subsequent CL. Change-Id: I9aa76f6c1db8ba691c7366b5dcdd75895419240c Bug: 1159182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578697 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#837456}
-
k.mishra authored
This patch removes data member |mSurfaceCallback| from ContentViewRenderView which is not being used at class level. Bug: None Change-Id: Ib7d55dc13cb767df11cbfaf7c7942edecaa1709d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522794Reviewed-by:
Prashant Nevase <prashant.n@samsung.com> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#837455}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d6661897486a..f600415e9265 2020-12-16 dberris@chromium.org sheriff-config: Support serving anomaly configs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1158326 Tbr: skyostil@google.com Change-Id: Ie46bfefce1a2eccd9d772a4717a018cb4d9e7500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594632Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4fa506cee933..b528247a5a9e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC aboxhall@google.com,btolsch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1150600 Tbr: aboxhall@google.com,btolsch@google.com Change-Id: Ie96ce47e9ae6ff53a1d46ecbb05d797be05daabe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594125Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837453}
-
