- 25 Aug, 2020 40 commits
-
-
Ana SollanoKim authored
A fieldset-specific regression was introduced by the following change https://chromium-review.googlesource.com/c/chromium/src/+/2263353. This change fixes the bug crbug.com/1097012, addressing now all the TODOs that were added as a result of this issue. Because the padding of the fieldset's content is applied to the anonymous fieldset content box rather than the fieldset itself, we don't want to directly subtract the block-end padding from the fieldset in the finish fragmentation function. For this reason, we're only passing the border so that when subtracting to get the final block size, we're not mistakenly eliminating the padding as well. The minimum border box block size was not being calculated in every case due to legends not fragmenting, thus resulting in missing padding and border for some fragments. Additional conditions were added to allow that calculation when needed. Bug: 1097012 Change-Id: I8e9fd55ae11a14ce83e035a591ab0ec6a7f34261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373382 Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#801460}
-
Kyungsun Lee authored
The code in //components/payments has a lot of raw pointers that rely on careful memory management. It would be better to use base::WeakPtr to avoid mistakes. This CL is a part of those changes, which replaces the raw pointer of PaymentRequestState::Delegate with the base::WeakPtr. BUG=1086284 Change-Id: Ieeef4f5be886d78fce7f3f28cbb902691f1aa341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364380Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#801459}
-
John Delaney authored
What: Move base::PathExists() check for database file to the storage task runner. Because ConversionStorageSql is created on the UI thread, this call blocks startup execution. How: Defer initialization of |db_status| to LazyInit() Fixes the startup regression introduced on https://crrev.com/c/2360471 Bug: 1121307 Change-Id: I3842320f507695643a306cac709aba605b1b276e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372596 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#801458}
-
Yuki Shiino authored
Supports property installation of IDL operations with enabling V8 Fast API mechanism. This is a preparation of https://crrev.com/c/2315680 . Bug: 1052746 Change-Id: I0f1a4ac0e12f32f2db32f161b3fe65198052a7cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361939 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#801457}
-
Yu-Hsuan Hsu authored
Add --use-cras flag when it is running on ChromeOS. BUG=b:151905045 Change-Id: I336a928b512fb1489a82c90a7fd1b776107ef0a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374487 Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#801456}
-
Antonio Gomes authored
This is a follow up of https://crrev.com/c/2360325, that moved the respective files from content/renderer to Blink. Since this class is used in chromecast/, it is not expected that it will be moved out of the Blink API layer any soon. TBR=spang@chromium.org BUG=787252 R=guidou@chromium.org, haraken@chromium.org Change-Id: I5fe091066e03a0e3d147601196bf3a4da7ef056f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363708 Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#801455}
-
Gayane Petrosyan authored
When right-clicking on media element, selection is "\n" and associated doc is null. Thats why creating a range with null document in TextFragmentSelectorGenerator results in referenced crash. Fix the issue by creating the range in TextFragmentSelectorGenerator only when data.selected_text was assigned. Bug: 1119309 Change-Id: Ib8a035d6779a3c8636d0ec6e5cf9167a2a9bdaf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362873 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#801454}
-
Sammie Quon authored
Test: compositor_unittests LayerWithDelegateTest.Cloning Change-Id: I13496c5e339db87ad2b78f868cf135e53c1f1aed Fixed: 1121302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374025Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#801453}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f6256ac5. With Chromium commits locally applied on WPT: 9f52c7e4 "COOP: add reporting to redirects" d18db804 "Fix test flake in animation-state-changes-positive-playback-rate.html" 9f6eb4ab "[scroll-animations] Support animation-timeline:none" 407a71e3 "[fetch] Empty destination should be the empty string, not "empty"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Id8ab9fd635bdc7733db44bd02b523f6f24806a88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375070Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801452}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b19dea038322..b8ae5a73f875 2020-08-25 tvanderlippe@chromium.org Typecheck bindings/CompilerScriptMapping.js with TypeScript 2020-08-25 pfaffe@chromium.org AsyncScope-ify the console helpers 2020-08-25 pfaffe@chromium.org Language Extension API: First-class support for constant variable values If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1113662 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1d491d2d696357641fd0690ec7f18bf2e1130720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375665Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801451}
-
Theresa Wellington authored
This is a reland of 90d9fea6 Added a wild card for the test name. Original change's description: > Disable P/CompositorImplBrowserTestRefreshRate.VideoPreference on M x86 > > Test flakes frequently on M emulator. > > BUG=1120813 > > Change-Id: I481b39088f22e295e31ec5eed155f168e0fbad78 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373284 > Commit-Queue: Theresa <twellington@chromium.org> > Commit-Queue: Haiyang Pan <hypan@google.com> > Auto-Submit: Theresa <twellington@chromium.org> > Reviewed-by: Haiyang Pan <hypan@google.com> > Cr-Commit-Position: refs/heads/master@{#801172} Bug: 1120813 Change-Id: Ideade1b3c2bb4959d20f26014a131925a8ae1a3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375545 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#801450}
-
Caroline Rising authored
Add a new menu triggered by the StarView which gives the option to either bookmark the tab or save it for later. If bookmark is selected the user flow matches previous behavior. If save to read later is selected the tab will be saved to the reading list model. Note this change is hidden behind the read later feature flag. Follow-up work: Update the read later icon in the menu when new icons are available. Update the omnibox star tooltip. Update StarView/bookmark metrics and add metrics for read later. Update menu size. Bug: 1117023 Change-Id: I09c6cf4973338faa272bc6ec6da06e26f0f9aa8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359550 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#801449}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 32 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 60 days of 2020-11-23. TBR=chromium-metrics-reviews@google.com Change-Id: I125c148476a40629faca017a9d396f2b172af1eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375605Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#801448}
-
Nohemi Fernandez authored
Disallows clients from accessing internal library SigninEarlGreyAppInterface. If they need to access sign-in internals developpers may use the SigninEarlGrey test API. Bug: 1103274 Change-Id: Ib437ae134beaab81bde6dacad69b3f8179b5c9dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372303Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#801447}
-
Richard Knoll authored
This adds a fuzz target for the DecodeFrame method of the NearbyDecoder. Bug: 1091349 Change-Id: Iac7eabc35d57c2786e5cffbe2b292910d859c244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374868Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#801446}
-
Lei Zhang authored
Newer distros have lib32gcc-s1, but older, supported distros have lib32gcc1. Support both, rather than only one of the two. Bug: 1119692 Change-Id: I2ba4ee25507976683c987ea89623e7e0d80957af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372588Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Junichi Uekawa <uekawa@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#801445}
-
Clark DuVall authored
Recycler view is only being used in WebLayer. When experimenting with WebLayer in a DFM, the recycler view code still gets added to the base APK since R8 does not (yet) have support for adding proguard rules that only apply to a DFM instead of globally. This change removes all recycler view deps from WebView, and splits out the code from //ui/android that depends on recycler view since most places that use ui/android don't actually need it. See go/chrome-webview-isolated-splits for more info. Bug: 1105096 Change-Id: I808cba5530a4d211361db0beab8ab1e9aa57137f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363873Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#801444}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ic436e3540d038b8cf8f6df81725ae5d3ebc5336a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375068Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801443}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3a96e2c4c1ca..8025507f746b 2020-08-25 robertphillips@google.com Simplify SkComputeBlurredRRectParams 2020-08-25 mtklein@google.com refactor SkArenaAlloc footers 2020-08-25 brianosman@google.com SkRuntimeEffect SkSL has a new signature for main() If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: mtklein@google.com Change-Id: I3ffac2765495063ffdfed7d4cfdb9be7af4e71d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375027Reviewed-by:
-
Richard Knoll authored
Before crrev.com/c/2232978 the icon size was hardcoded in MenuItemView, but that CL changed it to respect the incoming vector icon size. We can't modify the vector source so we need to set a size when using it. This also cleans up the duplicated *WithIcon methods and unifies them to a single one taking a ui::ImageModel instead. Bug: 1109643 Change-Id: Ib78f683ffee672668c79397122a0e3f5725f58f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369181Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#801441}
-
Anders Hartvoll Ruud authored
This CL adds CSSScrollTimeline, which is like a regular ScrollTimeline except it originates from an @scroll-timeline rule. For now, the CSSScrollTimeline doesn't do anything beyond what ScrollTimeline does, but in the future CSSScrollTimelines will contain additional information needed to invalidate attached Animations when @scroll-timelines, the computed value of animation-timeline, or other circumstances change. All the Compute* utilities have been moved to css_scroll_timeline.cc without any changes. In general this CL is a pure refactor, and should have no behavior change. Bug: 1074052 Change-Id: I42291cc5fda4d8386c37803a3bf461c007fb5198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374646 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#801440}
-
Boris Sazonov authored
Removes ChromeSigninController as it is no longer used - all callers of ChromeSigninController have been migrated to IdentityManager. Bug: 1046412 Change-Id: Ic1923ac33007be61156f76627e9da50fa5a8e195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372424 Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#801439}
-
Xiaocheng Hu authored
Bug: 1119361 Change-Id: Id75173327b6bb53706489225ca95c500e8a95ba7 NoTry: True Tbr: ellyjones@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375927Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#801438}
-
Peter Wen authored
Lint does not correctly determine whether chromium targets depend on appcompat since it uses string matching that does not match our library name. Since this is the same for all chromium targets, ignore this lint warning globally. Bug: 1116130 Change-Id: I106f4dbbabd50e2e781b6152816c02ae8036f999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373206 Auto-Submit: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#801437}
-
Arthur Eubanks authored
Be more specific about "reasonably green". Add instructions on how to roll your own Clang. Change-Id: If5fd297e41f9a66c7c6e736903c14e911fe5819f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373265Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Arthur Eubanks <aeubanks@google.com> Cr-Commit-Position: refs/heads/master@{#801436}
-
Torne (Richard Coles) authored
Check the useragent set by apps to see if it's valid (as per the simple rules from //net), and if not, see if there's a plausible interpretation of the string as an attempt to do something clever or if it just looks like nonsense. Also check headers passed to loadUrl() for validity, but since apps can already add arbitrary headers here, just record a boolean histogram for valid/invalid as there's no reason to allow creative uses. Fixed: 1108405 Bug: 1105745 Change-Id: Iba562c2b9b17b0615e48dee5c58bd4b435b79442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355049 Commit-Queue: Richard Coles <torne@chromium.org> Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
David Van Cleve <davidvc@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#801435}
-
Jun Mukai authored
It turns out that timestamp data for the PresentationFeedback is not set on some board, which makes the delta value to be negative. This should be errors and should not report data points. Bug: b/165951963 Test: tast.ui.LauncherDragPerf on lazor to see failures Change-Id: Ie04e57d173601a827d581eb51918a2471c82fc94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373262 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#801434}
-
Maksim Sisov authored
Fixes lld.elf: error: undefined symbol: content::GetFontsInFamily_SlowBlocking. R=fangzhoug, thomasanderson Bug: 1121319 Change-Id: Idc9fec3ad300aa963ffc2ee1dfa626657906e86d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374525Reviewed-by:
Kramer Ge <fangzhoug@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#801433}
-
Aaron Leventhal authored
Sometimes the menuitem role was incorrectly exposed for the role of <option> elements in a <select size=1> depending on which ancestors were ignored. These elements should always be exposed as listitems. The code that does this was intended to be removed as part of a previous refactoring. This removes it now. to screen readers as menuitems instead of listitems (Windows only) AX-RelNotes: in rare cases, select drop down options were reported Bug: 1114273 Change-Id: I618a883912cca5809661d919bbb48cfdc355e3d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369252 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#801432}
-
Erik Chen authored
Change-Id: Ie087134b40d69010ec06c03486b77d7f7907e9d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373234 Auto-Submit: Erik Chen <erikchen@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#801431}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ab849683685b..65f9045b37a9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rogerm@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1085115 Tbr: rogerm@google.com Change-Id: I10cf7a9ef63b0ff7bf9e22e1b0f8cd30621751cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374808Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801430}
-
Chris Cunningham authored
This CL adds a CodecState, and uniformizes to which operations are allowed in which states for encoders and decoders. No operation is allowed on closed codecs. Only close() and configure() are allowed on unconfigured codecs(). All operations are allowed on configured codecs. Bug: 1120840, 1120861 Change-Id: Iefac89a26b14f150a19c371ca8d502520c3b7c8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369677 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#801429}
-
Mohamed Amir Yosef authored
This is a reland of a39032ce It's not 100% clear that this patch the culprit for the failures in iOS tests, and hence landing again! Original change's description: > [Passwords] Save CompromisedCredentials in the correct store > > Bug: 1108422 > Change-Id: I3a96f9d3a422590df5c0b0947e6b803c074ef9a0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372322 > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801346} TBR=jdoerrie@chromium.org Bug: 1108422 Change-Id: I373567952e3d040931204b941325a0da1b9992d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375290 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#801428}
-
Bo Liu authored
Renderer process that died from RenderProcessHost::Shutdown should not be treated as out of memory kill from android. This is a very small percent of current OOM counts that it should not affect overall metrics very much. Fixed: 1115517 Change-Id: Iaf584db90d8a54e5e900667aff20ada4afb8ea5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373273Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#801427}
-
Regan Hsu authored
* Creates initial, connecting, and final states which will control which title and which description to use. * Adds the flow to a dialog containing cancel, confirm, and ok buttons. * Hooked up to Notification Manager via MultideviceHandler. * Strings are not final yet so no screenshots are taken. Video: https://nimb.ws/2VGQZs Note the toggle does not actually turn on at the end of the flow because the feature is currently not supported, and won't send the settings.MultiDeviceFeatureState.ENABLED_BY_USER unless faked out. Bug: 1106937 Change-Id: Iead4848ef4b946cbafddf0651af6ae183fabfd11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358791 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#801426}
-
Scott Violet authored
to components/metrics/content and renames ContentStabilityMetricsProvider. I'm doing this to share with WebLayer. Having components depend upon extensions seems bad (and has compile errors). So, I had to refactor that dependency out. I will sort out unit-test next. BUG=1120537 TEST=pure rename. Change-Id: I4fd9907fa5b52c3a06222b96bb7550f02a12ab95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372779 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#801425}
-
evliu authored
This CL disables the Live Caption feature if the kLiveCaption feature flag is disabled. Previously, the Live Caption feature would only be enabled if the kLiveCaptionEnabled user pref is enabled, which can only be enabled if the kLiveCaption feature is enabled. The feature should be completely off if the kLiveCaption feature is disabled, even if the feature and pref were previously enabled. Bug: 1121296 Change-Id: I6f642f025d69b411223cc137e999d7980d5d4917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372734Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#801424}
-
Xiaocheng Hu authored
Bug: 1033002 NoTry: True Tbr: alexmos@chromium.org Change-Id: I79403c51a519c3708421a3c59450d969a6bcbc49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375925Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f6e6c933..70f0b007 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id25c56bca969f423270d42978512c2b160e41877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375067Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801422}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ac74b9c703be..7f786caa5d60 2020-08-25 batrapranav@chromium.org portage_util: Detect ebuild multilib_src_test() 2020-08-25 davidriley@chromium.org zork-borealis: Disable unittests for zork-borealis. 2020-08-24 geohsu@google.com Setup builders for M86 ChromeOS If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Id3d0111b7a83434c6e8987a56b65d2f8191e8187 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375445Reviewed-by:
-
