- 01 Feb, 2019 40 commits
-
-
Reilly Grant authored
This comment was added in r518002 but is no longer relevant because both Generic Sensors API and deviceorientation / devicemotion events are now using Feature Policy to control access from iframes. Bug: 787019 Change-Id: Ia66eb56fee88681e258017fb9a1c9522e1931f7b Reviewed-on: https://chromium-review.googlesource.com/c/1449313 Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#628213}
-
Jonathan Metzman authored
Don't use explicitly link against fuzzer_no_main-x86_64.lib since it duplicates symbols that are in some of the asan runtime libraries. This likely breaks the old instrumentation (which we dont use) and definitely breaks compiling libFuzzer targets on Windows without ASAN (which we don't use on CF). It is unclear if there is a problem for Windows users of LF or if this was just a chrome problem since Chrome doesn't link using the compiler driver. Bug: 927352 Change-Id: Iefb657cee55c31b8ea2546d3a1e39a5235875f9d Reviewed-on: https://chromium-review.googlesource.com/c/1449163 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#628212}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b2818db71e6e..b6cc5a6baf93 git log b2818db71e6e..b6cc5a6baf93 --date=short --no-merges --format='%ad %ae %s' 2019-02-01 benjhayden@chromium.org Add RecentBugsRequest for v2spa. Created with: gclient setdep -r src/third_party/catapult@b6cc5a6baf93 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:918193 TBR=sullivan@chromium.org Change-Id: I054dc1c8dd6ea8506778d2b44f614b8374c1f365 Reviewed-on: https://chromium-review.googlesource.com/c/1448570Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628211}
-
Jiajia Qin authored
This CL adds more enum parameters to WebGL 2.0 Compute IDL. In addition, those parameters are really supported in corresponding APIs. Bug: 859249 Change-Id: I3ff55a845c0540604297f5ab1834287bb319d071 Reviewed-on: https://chromium-review.googlesource.com/c/1445795 Commit-Queue: Jiajia Qin <jiajia.qin@intel.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#628210}
-
Thomas Guilbert authored
This reverts commit 7fa769eb. Bug: 927285 Change-Id: I003834a44cc27075be7071fca091869bb85e427f Reviewed-on: https://chromium-review.googlesource.com/c/1448680Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#628209}
-
Alexander Dunaev authored
The TestRegion class is introduced, and the mock surface now handles region-related methods. Bug: 847740 Change-Id: I38151f729548033043786e6828c8c97e1f56b67f Reviewed-on: https://chromium-review.googlesource.com/c/1447871 Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#628208}
-
Xiaocheng Hu authored
InputMethodController::SetComposition() uses RevealSelectionScope to scroll to selection at finishing. As the operation dispatches events that may remove the frame, to avoid crashing, RevealSelectionScope should check whether the frame is still alive, which is done by this patch. Bug: 925974 Change-Id: I15d7c27c29ce0f75d7a90ca5c1b30f84781a6c0e Reviewed-on: https://chromium-review.googlesource.com/c/1448883Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#628207}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/db987e614ff8..7a629886aed9 git log db987e614ff8..7a629886aed9 --date=short --no-merges --format='%ad %ae %s' 2019-02-01 zhuo@hexoasis.com Update the "BaseFont" value of Type0, Type1, and TrueType. 2019-02-01 thestig@chromium.org Clean up CXFA_TextLayout. 2019-02-01 thestig@chromium.org Mark more CPDF_Annot methods and members as const. 2019-02-01 tsepez@chromium.org Remove final Windows fxge dependence on fpdfapi. Created with: gclient setdep -r src/third_party/pdfium@7a629886aed9 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ia10fc807fc042ad15571f64aebb5ba38d9832eb0 Reviewed-on: https://chromium-review.googlesource.com/c/1449251Reviewed-by:
-
Fumitoshi Ukai authored
- WinMSVC64 Goma Latest Client is cl.exe (as goma.latest does) - Mac Goma Canary LocalOutputCache short_name should be loc, not clb. Change-Id: Ie681b8754b2c38dec02fbe4d90cbb1db9105f595 Reviewed-on: https://chromium-review.googlesource.com/c/1447998 Commit-Queue: Fumitoshi Ukai <ukai@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Auto-Submit: Fumitoshi Ukai <ukai@chromium.org> Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#628205}
-
Dale Curtis authored
BUG=none TEST=compiles R=liberato Change-Id: I186c9c8b26f63ad20879452e33cb58c895ecdfe6 Reviewed-on: https://chromium-review.googlesource.com/c/1448780 Commit-Queue: Frank Liberato <liberato@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#628204}
-
Kyle Horimoto authored
This CL: (1) Renames CryptAuthEnrollmentSchedulerImpl to PersistentEnrollmentScheduler. I'm working on a second CryptAuthEnrollmentScheduler implementation, so it makes sense to give this implementation a more descriptive name. (2) Updates PersistentEnrollmentScheduler's constructor so that it schedules the next enrollment as part of a new task instead of doing so synchronously. This ensures that the setup code needed to initialize the scheduler can complete correctly (note: setup code is coming as part of a follow-up CL). (3) Adds default parameters to the class' factory. (4) Provides a clear class description which differentiates it from the other CryptAuthEnrollmentScheduler implementation I'm working on. Bug: 899080 Change-Id: Ia8f7c06d8012d02fa0d9d064b5a157a33524f473 Reviewed-on: https://chromium-review.googlesource.com/c/1448410Reviewed-by:Jeremy Klein <jlklein@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#628203}
-
Nick Diego Yamane authored
Fix cyclic dependency error when trying to use CharacterComposer in ozone/platform (e.g: ozone/wayland). The issue shows up on chromeos builds due to the following dependency chain: //ui/ozone:ozone -> //ui/ozone:platform -> //ui/ozone/platform/wayland:wayland -> //ui/base/ime:ime -> //services/ws/public/cpp/input_devices:input_devices -> //ui/ozone:ozone This CL fixes it by moving character_composer.* files into //ui/base/ime:ime_types component, which is already in //ui/base/ime deps when is_chromeos=true and can automatically used in ozone/platform/wayland becaused ime_types is included in //ui/base/ime/linux's public_deps, which is in //ui/ozone/platform/wayland's deps. BUG=921947 Change-Id: I9d01445325066f9c5a89d7d44729ec07f21c20c7 Reviewed-on: https://chromium-review.googlesource.com/c/1448471 Auto-Submit: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#628202}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I8befc9238bf2b0d62082a9e967a9dbc76cc0a3fa Reviewed-on: https://chromium-review.googlesource.com/c/1448565Reviewed-by:
-
Vlad Tsyrklevich authored
ClusterFuzz uses a larger -max_len than the default so the stack VLA of length Size*10 could overflow the stack. Dynamically allocate that buffer instead. Also, change the unpacked size to use entries instead of Size as that's the correct lower bound. Bug: 927502 Change-Id: I2f9bfc74b69a96a1595468eb14cab1e21ddb04ef Reviewed-on: https://chromium-review.googlesource.com/c/1449169Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#628200}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/846d12afedbf..453b7c85c8fd git log 846d12afedbf..453b7c85c8fd --date=short --no-merges --format='%ad %ae %s' 2019-01-31 stevenperron@google.com Fix up some test (#2351) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@453b7c85c8fd The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I017b770aae68898b342c2887614c25ff0872330c Reviewed-on: https://chromium-review.googlesource.com/c/1448566Reviewed-by:
-
Alexei Filippov authored
Make all tests run in sampling mode. That should fix the timeout errors while still covering all the execution paths. Make all the tests run both streaming and non-streaming mode. BUG=921036 Change-Id: I7cd164ab91c4e8f786799b56d0582e69c467831a Reviewed-on: https://chromium-review.googlesource.com/c/1449162 Commit-Queue: Alexei Filippov <alph@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Alexei Filippov <alph@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#628198}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/232527952597..2cde328881f0 Created with: gclient setdep -r src-internal@2cde328881f0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I3614baf459b32c4b35bbadd582f9c697beef013a Reviewed-on: https://chromium-review.googlesource.com/c/1448564Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628197}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/50b187ca8371..39b0b8e32a4e git log 50b187ca8371..39b0b8e32a4e --date=short --no-merges --format='%ad %ae %s' 2019-01-31 vadimsh@chromium.org Add presubmit check that runs 'lucicfg validate <script>'. Created with: gclient setdep -r src/third_party/depot_tools@39b0b8e32a4e The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:925532 TBR=agable@chromium.org Change-Id: Iddc65d57ba840b7be37319502e363b90e3d3e226 Reviewed-on: https://chromium-review.googlesource.com/c/1448563Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/67957c299322..2e5e7db63cd9 git log 67957c299322..2e5e7db63cd9 --date=short --no-merges --format='%ad %ae %s' 2019-01-31 cjmcdonald@chromium.org chromeos_config: Added documentation for goma-full builder Created with: gclient setdep -r src/third_party/chromite@2e5e7db63cd9 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I48ffd12957138bf370abd7bd76d24aa7faa4a90e Reviewed-on: https://chromium-review.googlesource.com/c/1448679Reviewed-by:
-
Bret Sepulveda authored
This patch deletes ChromeLayoutProvider::UseExtraDialogPadding, which always returns false, and any code guarded by it. This patch also adds a margin between the title and content to the collected cookies dialog, which is currently guarded by the above method, but upon reviewing designer comments was probably intended to be replaced by the proper Harmony constant instead. Bug: 867557, 610428 Change-Id: I6d30e93e213cd235e66156b097d01a4cf6a40a1f Reviewed-on: https://chromium-review.googlesource.com/c/1449156Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#628194}
-
Joel Einbinder authored
There was 1px of margin on items in the elements tree outline. If that area was clicked, selecting a new element would fail. Change-Id: I62c3aeb814759349c05582ac6b23309901e6d98e Reviewed-on: https://chromium-review.googlesource.com/c/1387453Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#628193}
-
Becca Hughes authored
This is a follow up from https://crrev.com/c/1334661 which splits out spec metadata between Blink/Content with its own SpecMediaMetadata. BUG=892771 Change-Id: I48825f4c97e526888d5a9840cdcc129e2eed11e9 Reviewed-on: https://chromium-review.googlesource.com/c/1423400 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#628192}
-
Johannes Henkel authored
- Python3 changes - Maybe_h fix for UBSan warning - more encoding changes Change-Id: I8045bfb1f47b95171e3e395c85b6de05f6973e42 Reviewed-on: https://chromium-review.googlesource.com/c/1448995Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#628191}
-
Devlin Cronin authored
Opening a window to a blank URL and then navigating it previously did not properly instantiate extension bindings, since the created script context was evaluated to be "unknown" (and then reused in the navigated page). This was fixed by https://crrev.com/305d2102dc, which landed in M72. Though this has already been fixed, add a regression test specifically for extension bindings to expand our coverage. Bug: 925118 Change-Id: Id5d7748a09f6eb8b60d25935ab4efcbde3d0d5c6 Reviewed-on: https://chromium-review.googlesource.com/c/1446570 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#628190}
-
rbpotter authored
PDFAnnotationsTest.AnnotationsFeatureEnabled was failing when run with --enable-features=WebUIPolymer2. Fixing: - Test uses /deep/, which is deprecated in Shadow DOM v1. - Production code relies on the lookup_ function not being called when |strings| is undefined, which is an invalid assumption in Polymer 2. - Production code sets |disabled| for elements in a dom-repeat that are not actually available in attached(). Also add the PDFAnnotationsTests to the filter file, to help prevent future regressions. Bug: 860069, 923625 Change-Id: I48b353ecd06fdff5b773b1959b4625662a2ca5c0 Reviewed-on: https://chromium-review.googlesource.com/c/1446509Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#628189}
-
git config --global authored
Check Info.plist to get Failed/Passed status and ignore Error messages and return code of "xcodebuild test..." command. Bug: 924818 Change-Id: Ibcc91f253747667a7b673f3c9cb5863afd7da965 Reviewed-on: https://chromium-review.googlesource.com/c/1432156 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Cr-Commit-Position: refs/heads/master@{#628188}
-
Moe Ahmadi authored
Use UIView's alpha property instead of hidden to hide the button and show the spinner on translate infobar's language tab. As opposed to hidden, alpha is an animatable UIView property: https://developer.apple.com/library/archive/documentation/WindowsViews/Conceptual/ViewPG_iPhoneOS/AnimatingViews/AnimatingViews.html Bug: 910994 Change-Id: I35a853f52f4f7291412a51cacbd61a13e3c00087 Reviewed-on: https://chromium-review.googlesource.com/c/1448773 Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#628187}
-
Joshua Peraza authored
Set the native library search path to first search a directory named for the current ABI, adjacent to the chrome package nativeLibraryDir, which will be the 32-bit ABI directory. The package's nativeLibraryDir is moved to the end of the path list because if a wrong bitness library is found first, the loader won't continue the search. Bug: crashpad:276 Change-Id: I5f0c13112b7423576f9e353cb3afef4e919e586c Reviewed-on: https://chromium-review.googlesource.com/c/1449005Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#628186}
-
Hui(Andy) Wu authored
Add a flag for the upcoming assisted actions feature. It will only be activated when the flag is enabled, which is defaulted to disabled. Change-Id: I715d933bb13952c63f54968cb628c1fccb549998 Bug: crbug/925947 Reviewed-on: https://chromium-review.googlesource.com/c/1446555Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Hui Wu <wuandy@chromium.org> Cr-Commit-Position: refs/heads/master@{#628185}
-
John Z Wu authored
It says "Search or type URL" like in //ios/chrome. Change-Id: I3d58b0487f76e174e9779f361c28869833fe943e Reviewed-on: https://chromium-review.googlesource.com/c/1448118 Auto-Submit: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#628184}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/258398020826..48d040e8c524 git log 258398020826..48d040e8c524 --date=short --no-merges --format='%ad %ae %s' 2019-01-31 geofflang@chromium.org D3D11: Fix reads and writes to EGL image textures with mip offsets. Created with: gclient setdep -r src/third_party/angle@48d040e8c524 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ife51223f5d11aaaa50a8080ab839a8ca59b6c8c6 Reviewed-on: https://chromium-review.googlesource.com/c/1448678Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/8926f0f331d8..db987e614ff8 git log 8926f0f331d8..db987e614ff8 --date=short --no-merges --format='%ad %ae %s' 2019-01-31 thestig@chromium.org Make CPDF_Annot::IsAnnotationHidden() non-static. 2019-01-31 tsepez@chromium.org IJS_Runtime::Create() can not return null. 2019-01-31 tsepez@chromium.org Break core/fpdfapi/{edit,parser} circular dependence 2019-01-31 thestig@chromium.org Add constants for PDF 1.7 spec, table 8.15. 2019-01-31 thestig@chromium.org Add EmbedderTest::OpenSavedDocumentWithPassword(). 2019-01-31 thestig@chromium.org Use RenderLoadedPageWithFlags() instead of RenderPageWithFlags(). 2019-01-31 thestig@chromium.org Add EmbedderTest::RenderPage(). Created with: gclient setdep -r src/third_party/pdfium@db987e614ff8 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I1e405c3486457bd8c66596a3a4f5ddee32346f76 Reviewed-on: https://chromium-review.googlesource.com/c/1448562Reviewed-by:
-
Dan Beam authored
Screenshots: https://imgur.com/a/uqczMTg, https://imgur.com/a/OnNFo4u BUG=926935 R=aee@chromium.org Change-Id: Ib613901512e557695a66859b22abcbc5e84f63a7 Reviewed-on: https://chromium-review.googlesource.com/c/1446799 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#628181}
-
Andres Calderon Jaramillo authored
This CL modifies the ImageDecodeAcceleratorStub unit tests to test that service-side transfer cache entries are created correctly for completed image decodes. Additionally, a "return true;" is added to GpuChannelMessageFilter::OnMessageReceived() to make sure that image decode accelerator requests early out. Test: all the ImageDecodeAcceleratorStub unit tests pass. Bug: 868400 Change-Id: I95db80df9ef1f7651807177ffcc3d653b96e1374 Reviewed-on: https://chromium-review.googlesource.com/c/1368600Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#628180}
-
Adithya Srinivasan authored
We don't currently send a message because the RenderFrameProxy created has no parent (so it looks like a main frame). This ensures that same-origin frames within the portal are also detached. The test added would fail with --enable-leak-detection without this change (the iframe inside the portal would leak). Bug: 923898 Change-Id: I2b56b8e303b40d275976da5ed8a0fdde7726b51c Reviewed-on: https://chromium-review.googlesource.com/c/1430586Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#628179}
-
Jacob DeWitt authored
This is required due to WebXR breaking API changes made in M73. The associated test now checks that the WebXRDeviceM73 token works and that the WebXRDeviceM69 token no longer works. Bug: 925983 Change-Id: Ibca4bf9476a3f5958a34ed8a162a75748ce313a0 Reviewed-on: https://chromium-review.googlesource.com/c/1448976Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Commit-Queue: Jacob DeWitt <jacde@chromium.org> Cr-Commit-Position: refs/heads/master@{#628178}
-
Dale Curtis authored
Mostly just structural changes to return early instead of having a large set of nested conditionals. The only real change is when color accuracy is turned off, we won't blindly set SRGB mode anymore. This won't fix the default path, but may resolve issues where color accuracy has been turned off. BUG=854438, 902550, 825578, 851216 TEST=none R=liberato, sunnyps Change-Id: I5f5e12d1520e15e92167a1fc2e03f6606467c95d Reviewed-on: https://chromium-review.googlesource.com/c/1448741 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
Robbie McElrath authored
We're not supporting in-process network service on ChromeOS for now. Bug: 927435 Change-Id: I88f4e62ac1534c88cf77635fa6b8c4ac5464397e Reviewed-on: https://chromium-review.googlesource.com/c/1449109 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#628176}
-
David Jacobo authored
Smart text selection already has a metric for usage, more specifically this is recorded everytime an apps request is done to the ARC container. Currently the feature can be accessed via touch gestures or the context menu. This CL adds tracking to the access via touch gesture, since context menu was already covered. Bug: None Test: Build. Change-Id: Id394796f140605041efa0a37e298fd0764571292 Reviewed-on: https://chromium-review.googlesource.com/c/1449002 Auto-Submit: David Jacobo <djacobo@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1345366c21ea..88bfed46ab6e git log 1345366c21ea..88bfed46ab6e --date=short --no-merges --format='%ad %ae %s' 2019-01-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 794364ebd51c..258398020826 (1 commits) 2019-01-31 egdaniel@google.com Fix type in Andoird string. 2019-01-31 reed@google.com fix tiler to handle large float rects Created with: gclient setdep -r src/third_party/skia@88bfed46ab6e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:927075 TBR=borenet@chromium.org Change-Id: I226b13831d3b8170118b9e102ff1701e612a1708 Reviewed-on: https://chromium-review.googlesource.com/c/1448117Reviewed-by:
-
