GitLab

Bug: 901542
Change-Id: Id262dc5a842f624ab6452e5b6eed5947500bc0d5
Reviewed-on: https://chromium-review.googlesource.com/c/1318174Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605386}

This reverts commit 5528336d.

Reason for revert: Broke VR tests: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/3533

Original change's description:
> Reland "Reland "[blink] Control ScriptStreamer with ScriptResource""
> 
> This reverts commit c564235f.
> 
> No changes from the original, VR flakes are caused by issues with
> loadUrl and have been deflaked (see 894796 for details)
> 
> Original change's description:
> > Revert "Reland "[blink] Control ScriptStreamer with ScriptResource""
> > 
> > This reverts commit dd9df78c.
> > 
> > Reason for revert: Makes VR tests flaky (https://crbug.com/894796)
> > 
> > Original change's description:
> > > Reland "[blink] Control ScriptStreamer with ScriptResource"
> > > 
> > > This is a reland of 7bd91635
> > > 
> > > No changes from the original, revert reason is fixed with
> > > https://chromium-review.googlesource.com/c/1283037
> > > 
> > > Original change's description:
> > > > [blink] Control ScriptStreamer with ScriptResource
> > > >
> > > > Move the ScriptStreamer control logic from ClassicPendingScript to
> > > > ScriptResource. In the future, this will allow us to start streaming
> > > > a ScriptResource before the ClassicPendingScript is available, e.g on
> > > > preload.
> > > >
> > > > The ClassicPendingScript now only sends one "finished" callback, from
> > > > ScriptResource. This callback is either when the streaming completes,
> > > > or when there is no streaming and the ClassicPendingScript has told
> > > > the ScriptResource that it doesn't intend to start streaming. In the
> > > > long run, we want all scripts to go through the streaming interface,
> > > > and we want ScriptResource to control when streaming starts, so the
> > > > "no more streaming" call will disappear -- however it is necessary to
> > > > maintain the current behaviour, and be able to control it with a
> > > > runtime flag.
> > > >
> > > > Bug: chromium:865098
> > > > Change-Id: I2c4cc16635a6538b7ff24a24463fe6f34efd8a2e
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/1181430
> > > > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> > > > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
> > > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> > > > Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#599148}
> > > 
> > > TBR=kouhei@chromium.org,kinuko@chromium.org
> > > 
> > > Bug: chromium:865098
> > > Change-Id: I0df324ef8e284f4d3d55a1721d71be5a66a3285c
> > > Reviewed-on: https://chromium-review.googlesource.com/c/1286450
> > > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> > > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#601143}
> > 
> > TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org
> > 
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> > 
> > Bug: chromium:865098
> > Change-Id: Ibdbd7e80d0fcfacc84a73e83d165581c7f1d02d2
> > Reviewed-on: https://chromium-review.googlesource.com/c/1297138
> > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#602310}
> 
> TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: chromium:865098
> Change-Id: I9794fe5366aa8cfc9291d53271ed680465b29a76
> Reviewed-on: https://chromium-review.googlesource.com/c/1317566
> Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#605295}

TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org

Change-Id: I0a42464953d0c3f07977b03e868a1fb252a2ab66
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:865098
Reviewed-on: https://chromium-review.googlesource.com/c/1318084Reviewed-by: Dmitry Titov <dimich@chromium.org>
Commit-Queue: Dmitry Titov <dimich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605385}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0f6050fb228f..5f64f594fd65


Created with:
  gclient setdep -r src-internal@5f64f594fd65

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: If563576fe06bf1329946268f4db11e17db959b7f
Reviewed-on: https://chromium-review.googlesource.com/c/1318131Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#605384}

https://drafts.csswg.org/cssom/#serializing-css-values

"To serialize a CSS component value depends on the component, as follows:
keyword
The keyword converted to ASCII lowercase."

Bug: 901666
Change-Id: Iff579a363de13441c75bbebfc951095b071f6060
Reviewed-on: https://chromium-review.googlesource.com/c/1317300
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605383}

Selection tests are stored under blink/renderer/modules/accessibility/testing/data/selection
There are three files per selection test:
<testname>.html - the actual HTML to be tested. AXSelection::SetSelection will be used to set the selection.
<test_name>_dom.html - The selection resulting from AXSelection::GetSelection on the selection that the first file has produced.
<test_name>-ax.txt - The resulting accessibility tree.
The test framework will use the embedded selection markers "^" and "|" in the HTML to:
A) set the selection specified in the first file and compare it with the selection in the "dom" file.
B) Dump the accessibility tree after applying the selection and compare it with the tree in the "ax" file.
R=dmazzoni@chromium.org

Change-Id: I7c3c9e3a1eb222aac0afb69d1c4ffa2247a9cd49
Reviewed-on: https://chromium-review.googlesource.com/c/1240633
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605382}

Inline expected Links instead of initializing at the start of the test.

Change-Id: I7077b5f00ddbc712bed603ed55ff8bc7a002b484
Reviewed-on: https://chromium-review.googlesource.com/c/1316431
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605381}

This makes sure that notifications are shown to the user after a screen unlock
or after exiting fullscreen mode.

Bug: 899106
Change-Id: Iac5efa2f784e2681a41357bf7aa8f5da33830c16
Reviewed-on: https://chromium-review.googlesource.com/c/1315567
Commit-Queue: Richard Knoll <knollr@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605380}

Bug: 901840
Change-Id: Ib6b385e0b8cea19ec69b317853f6eb3eb5171412
Reviewed-on: https://chromium-review.googlesource.com/c/1317895
Commit-Queue: Richard Knoll <knollr@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605379}

This is a followup patch to [1] and paints LayoutReplaced hit test rects
into the scrolling contents layer. In this way we don't need to repaint
on every scroll change.

[1] https://crrev.com/603335

Bug: 888269
Change-Id: Ic8196f59b8a2f7d08285c5234ed562a61386ee6b
Reviewed-on: https://chromium-review.googlesource.com/c/1310754
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605378}

Add few browser tests that create component info with
experimental and/or default loading hints. Then, load a webpage
to verify that the resources specified by experimental/default
hints are blocked based on the finch experiment settings.

Change-Id: Id2d20d6f696d8de88a8cf0ed65a319ed67e9a500
Bug: 900699
Reviewed-on: https://chromium-review.googlesource.com/c/1314135
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605377}

This reverts commit 4df3f6e1.

Reason for revert: This CL causes crash in RasterCommandBufferStub.
The raster decoder still uses GL context and GL APIs even with vulkan.
Before removing the GL contect for vulkan, we need remove all
unnecessary GL context usage and GL calls for raster decoder.

#0 0x55d1ec37f6ef base::debug::StackTrace::StackTrace()
#1 0x55d1ec37f261 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7fe55e62d0c0 <unknown>
#3 0x55d1ed30103e gpu::RasterCommandBufferStub::Initialize()
#4 0x55d1ed25f35c gpu::GpuChannel::OnCreateCommandBuffer()
#5 0x55d1ed25ed0a bool IPC::MessageT<GpuChannelMsg_CreateCommandBuffer_Meta, std::__1::tuple<GPUCreateCommandBufferConfig, int, base::UnsafeSharedMemoryRegion>, std::__1::tuple<gpu::ContextResult, gpu::Capabilities> >::Dispatch<gpu::GpuChannel, gpu::GpuChannel, void, void (gpu::GpuChannel::*)(GPUCreateCommandBufferConfig const&, int, base::UnsafeSharedMemoryRegion, gpu::ContextResult*, gpu::Capabilities*)>(IPC::Message const*, gpu::GpuChannel*, gpu::GpuChannel*, void*, void (gpu::GpuChannel::*)(GPUCreateCommandBufferConfig const&, int, base::UnsafeSharedMemoryRegion, gpu::ContextResult*, gpu::Capabilities*))
#6 0x55d1ed25fcc4 gpu::GpuChannel::HandleMessageHelper()
#7 0x55d1ec3058f1 base::debug::TaskAnnotator::RunTask()
#8 0x55d1ec3050af base::MessageLoop::RunTask()
#9 0x55d1ec305432 base::MessageLoop::DoWork()
#10 0x55d1ec30743f base::(anonymous namespace)::WorkSourceDispatch()
#11 0x7fe55def6fc7 g_main_context_dispatch
#12 0x7fe55def7200 <unknown>
#13 0x7fe55def728c g_main_context_iteration
#14 0x55d1ec3072f2 base::MessagePumpGlib::Run()
#15 0x55d1ec31fba5 base::RunLoop::Run()
#16 0x55d1eeaedd3c content::GpuMain()
#17 0x55d1ebb80562 content::ContentMainRunnerImpl::Run()
#18 0x55d1ed68984c service_manager::Main()
#19 0x55d1eb1d6081 content::ContentMain()
#20 0x55d1ea8e316b main
#21 0x7fe559a992b1 __libc_start_main
#22 0x55d1ea8e302a _start

Original change's description:
> Add VulkanContextProvider to RasterDecoderContextState.
> 
> Add VulkanContextProvider to RasterDecoderContextState which is needed
> to get VkDevice in shareable image. Refactor RasterDecoderContextState
> class to have seperate constructors for Vulkan and GL.
> 
> Bug: 891060
> Change-Id: I0ca7e657d33fdcfa62ab6465f7023a914610b7ce
> Reviewed-on: https://chromium-review.googlesource.com/c/1312194
> Commit-Queue: vikas soni <vikassoni@chromium.org>
> Reviewed-by: Eric Karl <ericrk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#605146}

TBR=ericrk@chromium.org,vikassoni@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 891060
Change-Id: I4ceebc7033b4bd74e643a5f89bbbd6791b3eb6c0
Reviewed-on: https://chromium-review.googlesource.com/c/1318073Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605376}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/6386fdec9f49..3d2886849216


git log 6386fdec9f49..3d2886849216 --date=short --no-merges --format='%ad %ae %s'
2018-11-05 achuith@chromium.org cros_run_vm_test: cwd should not be of type 'path'
2018-11-04 yshaul@chromium.org chromeos_config: Remove hw_tests from GeneralTemplates
2018-11-02 chrome-bot@chromium.org Update config settings by config-updater.
2018-11-02 dgarrett@google.com chromeos_config: Fix release branch trigger syntax.
2018-11-02 dgarrett@google.com chromeos_config: Use triggers for branched Chrome PFQs.
2018-11-01 chrome-bot@chromium.org Update config settings by config-updater.
2018-11-01 jdufault@google.com chromeos_config: Mark tricky-chrome-pfq as experimental
2018-11-01 dgarrett@google.com gen_luci_scheduler: Correctly handle triggers for branched builds.
2018-11-01 dhanyaganesh@chromium.org cbuildbot: Schedule VMTest after autotest frees up
2018-11-01 dgarrett@google.com chromeos_config: Create factorybranch configs for existing branches.
2018-11-01 dgarrett@google.com chromeos_config: Create placeholder prototype-factorybranch build.
2018-11-01 chrome-bot@chromium.org Update config settings by config-updater.
2018-10-31 dgarrett@google.com commands: PushImages, log --buildroot.
2018-10-31 achuith@chromium.org cros_run_vm_test: type 'path' for arg parsing.


Created with:
  gclient setdep -r src/third_party/chromite@3d2886849216

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ibc73752b3e2ddac0131d88f1f9b64b92c0a49278
Reviewed-on: https://chromium-review.googlesource.com/c/1318132Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#605375}

Bug: 901414
Change-Id: I48deea892c422385fc6a1bb7efabf824b8efc4ea
Reviewed-on: https://chromium-review.googlesource.com/c/1316102Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605374}

Deleting characters from a generated password until only 3 or fewer
characters are left, results in the password not counting as generated
anymore.

Until now, the leftover characters were masked immediately after the
password length was shorter than 4 chars. This CL changes the behavior
to keep the password unmasked until the user completely deletes it or
it loses focus.

Bug: 874822,899798
Change-Id: I19a4116374388d51a5d5bafcba6d45076dde2800
Reviewed-on: https://chromium-review.googlesource.com/c/1305555Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605373}

We called AttachLayoutTree on a new Document which just got its
LayoutView created. It will not do anything useful as the document does
not yet have any child nodes.

Change-Id: I1af44b96b86dcb0a597c662b4c47fe9ab3d972aa
Reviewed-on: https://chromium-review.googlesource.com/c/1317889Reviewed-by: Anders Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605372}

The initial implementation has a bug that the frame index is assigned to the
record when a record is created. This is incorrect. This should happen when
the image is loaded instead, as frame index is used to indicate which frame a
loaded image belongs to in order for the swap time to be assigned to the right
records. This CL is to correct this bug.

Bug: 869924
Change-Id: I4a371183d66ed33b7ac87cb9a570e7221a2a7c4f
Reviewed-on: https://chromium-review.googlesource.com/c/1316663
Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605371}

Let's use "test@test.com" to make it more explicit that we're passing
an email address to MakePrimaryAccountAvailable(), and avoid using
an accessor method when we can simply reference an object directly.

Bug: 890825
Change-Id: Id84246d3c07e7494c7b9188000a18277fce92621
Reviewed-on: https://chromium-review.googlesource.com/c/1317862Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#605370}

https://webrtc.googlesource.com/src.git/+log/26341990a1c3..aed3070ad40c


git log 26341990a1c3..aed3070ad40c --date=short --no-merges --format='%ad %ae %s'
2018-11-05 sprang@webrtc.org Replace GetScalingSettings() with GetEnocderInfo() in TestEncoder
2018-11-05 nisse@webrtc.org Refactor RtpSender to use absl::string_view for payload name.


Created with:
  gclient setdep -r src/third_party/webrtc@aed3070ad40c

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ib13ad32cc17b44f6ae134b33187bd0497b165511
Reviewed-on: https://chromium-review.googlesource.com/c/1318130Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#605369}

ios/chrome is not allowed as chrome application layer.

ios/web is not allowed as private implementation.
ios/web/public is allowed as public API layer for ios/web

Bug: 872759
Change-Id: I0900bfe2adf740836fdf4572d356913a3901af0e
Reviewed-on: https://chromium-review.googlesource.com/c/1315350
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605368}

BUG=889871

Change-Id: I52a65e016b3e243af3356991eebe8621d9636f03
Reviewed-on: https://chromium-review.googlesource.com/c/1316930
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605367}

The Init function in ProtoDatabase currently assumes that we're dealing
with a unique proto database in that it takes a database directory and
leveldb_env::Options for opening a new DB.

In the case of a DB client using an underlying shared database, this
isn't necessary, so I've added a new Init function that only takes the
client name for UMA purposes and the Init callback, as well as adding
a constructor that takes the database dir and open options instead.
This allows clients in the new world can rely on just using the 2
parameter Init and not concern themselves with what version of the DB
they're using.

The old Init function is left for compatibility, and we ensure that the
new Init function isn't called after using the old constructor. A unit
test is added to test the logic that ensures we return false in the
InitCallback if this happens.

Bug: 870813
Change-Id: I7ec46228d964ddab3f4944163b91430a1cd72ac9
Reviewed-on: https://chromium-review.googlesource.com/c/1297465
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605366}

Converted implementations for GoogleSigninFailed, GoogleSigninSucceeded
and GoogleSignedOut, and updated unit tests accordingly.

Bug: 887457
Change-Id: I9ced1e6e5b91d5b05dd10b4520201b48e202fe75
Reviewed-on: https://chromium-review.googlesource.com/c/1286824Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#605365}

Remove dependencies on AccountTrackerService and SigninManagerBase
and rely instead on IdentityManager, IdentityTestEnvironment and
IdentityTestEnvironmentProfileAdaptor for the unit tests.

Note that this CL also changes the implementation of the tests
slightly, but this shouldn't change the logic that the test
is trying to check (that a valid account ID is always returned
for a valid profile even after revoking the refresh token).

The reasoning behind this modification (which has been bigger than
in other migrations) was based on several factors:

  - Since we're relying on IdentityTestEnvironment now, there's
    no need to keep using the fake SigninManagerBase nor the
    AccountTrackerService directly anymore.

  - With the AccountTrackerService (ATS) out of the way, we no
    longer simulate the token being revoked by directly removing
    the account from the ATS, meaning that further calls to the
    MultiUserTestingProfile::GetProfileUserName() method would
    never return an empty string. This is because that method would
    be now implemented in terms of IdentityManager, which would
    still be returning a valid email after the revoking since
    calling IdentityTestEnvironment::RemoveRefreshTokenForAccount()
    won't cause the account to be removed, just invalidated.

  - As a result, the way the ReturnValidAccountIdIfTokenRevoked test
    used to check whether the token is revoked, based on checking
    whether GetUserProfileName() returned an empty string or not,
    is no longer valid. Fortunately, we can simply use another API
    that is more accurate: IdentityManager::HasAccountWithRefreshToken().

  - Finally, since we're not using GetUserProfileName() at all anymore,
    there's also no need at all to subclass TestingProfile since overriding
    that method in terms of SigninManagerBase was its sole purpose for
    existing in the first place. Thus, we can drop that class as well.

In summary, quite some changes to the tests but the essence of it should
remain the same, relying in IdentityManager::HasAccountWithRefreshToken()
now instead of in the override for TestingProfile::GetUserProfileName(),
which is probably more precise and accurate.

Bug: 890799
Change-Id: I8210678c4486c226abbe920c1945ae473d8e28cf
Reviewed-on: https://chromium-review.googlesource.com/c/1307442Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#605364}

According to the code's comments (and caller's expectations), the method
should return last committed URL instead of visible URL.

"last committed URL" is URL of the page, while "visible URL" is the URL
which should be displayed in the omnibox (one that the user has typed
for example).

Bug: 897506
Change-Id: I13148cc2dee62c707cbceebab0d8d19622f942b8
Reviewed-on: https://chromium-review.googlesource.com/c/1316427Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605363}

Maintain a set of resource IDs that should be kept because they are
referred to by DOM elements that are being kept. This avoid trimming
away resources that are shared between "kept" and "trimmed" DOM elements.

Bug: b/118395372
Change-Id: I23489a400f4b9028daf3de50e78f403b816d6446
Reviewed-on: https://chromium-review.googlesource.com/c/1312934
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605362}

Found unused code while looking at code for tab reload after crash.

Change-Id: I2073d7038f46df14a4c2bfbdce2ae3c22f175595
Reviewed-on: https://chromium-review.googlesource.com/c/1316358Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605361}

This CL renames the following feature policy features:
image-compression > unoptimized-images
max-downscaling-image > oversized-images

Change-Id: I4a4a8e96e4a422087a4ef51f57ff70bc5c3ac745

BUG: 899761, 889185
Change-Id: I4a4a8e96e4a422087a4ef51f57ff70bc5c3ac745
Reviewed-on: https://chromium-review.googlesource.com/c/1308533
Commit-Queue: Luna Lu <loonybear@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Jason Chase <chasej@chromium.org>
Reviewed-by: Luna Lu <loonybear@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605360}

This was originally added in an attempt to remove SMIL [1] but that is
no longer being pursued.

[1] https://chromium.googlesource.com/chromium/src/+/e1ddf6ccc2e25dd02b7e97cc861c8a87fb6eca47

TBR=wangxianzhu@chromium.org

Change-Id: Ieb69c21e4848497b25890acac7a2c2125a70b075
Reviewed-on: https://chromium-review.googlesource.com/c/1313116
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605359}

This CL adds test coverage for closing and garbage collecting peer
connections while a setLocal/RemoteDescription's callback has been
queued to fire.

For more information see the CL that these tests were written for:
https://chromium.googlesource.com/chromium/src.git/+/18cb7920ca96d7832ae9fd0276958069bd4ad11c

Bug: 897251
Change-Id: Ia3abb09e15b4c4a051bed57f15811f93b44ecd68
Reviewed-on: https://chromium-review.googlesource.com/c/1309792
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605358}

As this is work-in-progress, it is behind a new feature flag.

Users that are managed (e.g. because they have policies set) will have a
message show up at the bottom of Chrome's App Menu. Clicking that
message redirects to a help center article, describing how to find out
whether your computer is managed.

Bug: 893626
Change-Id: Ie073c2f5d21db235736bc3dcf51005a4123d59b0
Reviewed-on: https://chromium-review.googlesource.com/c/1297072Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605357}

R=hansberry@chromium.org

Bug: 899324
Test: none
Change-Id: I7a7c5f4c56029da02a0d14c2351115cbdd7fbcc9
Reviewed-on: https://chromium-review.googlesource.com/c/1316101Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605356}

https://skia.googlesource.com/skia.git/+log/534e77651190..0909331d958f


git log 534e77651190..0909331d958f --date=short --no-merges --format='%ad %ae %s'
2018-11-05 reed@google.com add SkFontTypes.h
2018-11-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 9911aca4f7c6..20622c0194bd (1 commits)
2018-11-05 fmalita@chromium.org [skjson] Unescape strings
2018-11-05 reed@google.com add SkFontPriv.h


Created with:
  gclient setdep -r src/third_party/skia@0909331d958f

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=allanmac@chromium.org

Change-Id: Ib8dd0ace665ca79b96945385ed5c9adacd26a0bd
Reviewed-on: https://chromium-review.googlesource.com/c/1318052Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#605355}

https://android.googlesource.com/platform/external/perfetto.git/+log/48bcc1c45295..dd5c8ce56be8


git log 48bcc1c45295..dd5c8ce56be8 --date=short --no-merges --format='%ad %ae %s'
2018-11-05 taylori@google.com Merge "Add signal events to t2t and trace processor"


Created with:
  gclient setdep -r src/third_party/perfetto@dd5c8ce56be8

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I75c679ec2feeb688fefcc5a5e67dbe3b2a51a696
Reviewed-on: https://chromium-review.googlesource.com/c/1318129Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#605354}

The compositor viewholder relies on a layout change as signal that the
keyboard might have changed its state.
As the accessory doesn't emit this by default (because the activity
remains of the same size), emit this signal when the keyboard would
trigger it.

Bug: 900510
Change-Id: I9f78661f9835b6d04b202ea8dbd02df77d402b54
Reviewed-on: https://chromium-review.googlesource.com/c/1317913Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605353}

This CL prints the reason for invalid credentials in a human readable
format (instead of an int).

Bug: NONE
Change-Id: Ie3d622e66638f5940534e89f83588ee545a6e840
Reviewed-on: https://chromium-review.googlesource.com/c/1316772
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605352}

This reverts commit c2c962cc.

Reason for revert: The crash being debugged was fixed by https://chromium-review.googlesource.com/c/1310505

Original change's description:
> [mojo-core] PCHECK for invalid process handles
>
> Changes a DCHECK to a PCHECK in an attempt to help sort out some crashes
> we see in the wild where the broker process apparently receives handles
> but doesn't attempt to duplicate them to itself. This should only be
> possible if it doesn't know a valid handle for the remote (sending)
> process, which points to potential application raciness in ownership of
> the process handles passed into Mojo.
>
> Bug: 887576
> Change-Id: I1f8786af8170b7db03804a98125365eeb44fc598
> Reviewed-on: https://chromium-review.googlesource.com/1241197
> Commit-Queue: Ken Rockot <rockot@chromium.org>
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#593733}

R=rockot@google.com,reillyg@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 887576
Change-Id: Ic31379f9a85a20c8c47caccc185180768156eaa4
Reviewed-on: https://chromium-review.googlesource.com/c/1318069Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605351}

Handlers exists in two flavors, WebRtcSetLocalDescriptionObserverHandler
which is used for setLocalDescription(), and
WebRtcSetRemoteDescriptionObserverHandler which is used for
setRemoteDescription(). They have the same functionality but have to be
different classes due to webrtc observer interfaces being different
classes.

Each handler can operate in two modes: surfacing transceiver states
(includes senders and receivers) or only surfacing receiver states.

Prior to this CL, only the "remote" handler and "receiver only" mode
was tested. With this CL, all four combinations
"(local/remote) x (transceivers/receivers)" are tested using
parameterized gtests.

This improves test coverage and unblocks testing that is needed to solve
a bug related to surfacing transceivers (https://crbug.com/897251).

Bug: 865006
Change-Id: Iaf40b498b0fef0978c4179c47118f6cff0bcdf66
Reviewed-on: https://chromium-review.googlesource.com/c/1309747
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605350}

This harness contains the APIs necessary for all press benchmarks, but
they will remain separate benchmarks.  There is just now common
functionality that they can gain from this harness.

This CL includes:
1) New press benchmark that enables both in test javascript metrics
as well as tracing metrics
2) New press pages that implements the new measurement
3) Converted speedometer, speedometer2, and dromaeo benchmarks

Bug: 714231
Change-Id: I487612d38f06ecd8a4c8905102972b134497d0c0
Reviewed-on: https://chromium-review.googlesource.com/c/1299739
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#605349}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/60dcc070e823..0f6050fb228f


Created with:
  gclient setdep -r src-internal@0f6050fb228f

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I8c95cee42fd0f61e3780efb103f11889cf7f5cbd
Reviewed-on: https://chromium-review.googlesource.com/c/1318050Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#605348}

This is a reland of 0301a791

I don't think this would have caused a runtime chromeos error, since it's
a build time android change. If it pops up again that I broke the test,
I will investigate further.

TBR=retry

Original change's description:
> Android: turning on bytecode checker
>
> This arg was defaulting to false when it should have defaulted to true.
>
> TBR=turning off bytecode checks for certain dirs
>
> Bug: 874854
> Change-Id: I248ccab0ed52079106b07e43a302927bfa4414c8
> Reviewed-on: https://chromium-review.googlesource.com/c/1309973
> Commit-Queue: Sam Maier <smaier@chromium.org>
> Reviewed-by: agrieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#605068}

Bug: 874854
Change-Id: Idc95750d4465ca53b72db26a98ce74724fe21968
Reviewed-on: https://chromium-review.googlesource.com/c/1318071Reviewed-by: Sam Maier <smaier@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605347}