GitLab

This CL fixes a reentrancy issue in MessagePopupCollection that might
cause crash on devices with small screen height.
We should set |is_updating_| to true when we call MessagePopupView::
UpdateContents(). Updating contents can change its height, and it might
cause the popup to be dismissed because the screen height might not be
enough to show the notification. The popup should be closed after the
update is finished, but we didn't set |is_updating_| to true, so the
popup could accidentally close during UpdateContents().

We didn't catch this until a11y related change
https://crrev.com/c/1166231 because |message_view_| was not used after
NotifyPopupResized() in MessagePopupView::UpdateContents().

TEST=MessagePopupCollection.UpdateContentsCausesPopupClose
BUG=874777

Change-Id: I29cfffec7e967254da0d880667e38805d0cded5a
Reviewed-on: https://chromium-review.googlesource.com/1179506
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584362}

There are three places that use |IDS_CONTROLLED_SETTING_POLICY|, but
AFAIK there's no need to change the other two places
(arc_support_host.cc and extensions_ui.cc).

Bug: 873946
Change-Id: I34e9fb0a20139b0aaca6380e949248745f50ed58
Reviewed-on: https://chromium-review.googlesource.com/1180526Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584361}

Have DemoModeResourcesRemover keep track of amount of time the user is
interacting with the device (using UserActivityDetector), and once the
total amount of active usage is over 8 hours, attempt demo mode
resources removal - substantial amount of active usage should be a good
signal that the device has been owned by a real user.

BUG=827368
TEST=unittests

Change-Id: Ib7b90da7da41bdcebbead0f0239579e727f07ae8
Reviewed-on: https://chromium-review.googlesource.com/1180603Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584360}

This test has been flaky on Mac10.13 Tests

TBR=weili@chromium.org

Bug: 875707
Change-Id: I71e1f70fb1e7628ba810dccf603d4d58885abb9c
Reviewed-on: https://chromium-review.googlesource.com/1180798Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584359}

When PreDispatchEventHandler is called, Event object was passed as a
parameter. and it is never nullptr.
so it can be changed to reference instead of pointer.

Bug: 871637
Change-Id: Id8f1b05c51024e6418eaf2e7517f6dfb2ec70699
Reviewed-on: https://chromium-review.googlesource.com/1179520Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Cr-Commit-Position: refs/heads/master@{#584358}

This brings us into alignment with the Fetch Standard as well as Firefox and
Edge.

Bug: 165083, 874536
Change-Id: Id06d07d301aeae8bd0c48bfe94df68cf1ed68db9
Reviewed-on: https://chromium-review.googlesource.com/1176263Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Timothy Gu <timothygu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584357}

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iccd919105fd31fbe83b75d87f15f206e5ad30d36
Reviewed-on: https://chromium-review.googlesource.com/1179514
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584356}

Change-Id: I7d9700f70be42f30239d0b6c5a73a0c852ae416c
Reviewed-on: https://chromium-review.googlesource.com/1179723Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584355}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=amineer@chromium.org

Change-Id: Ief7b6878df09e6aae94c1ef3febbdad6cfc04f3a
Reviewed-on: https://chromium-review.googlesource.com/1180711Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584354}

This patch fixes the incorrect updating algorithm of |bytes_compared_|
in DoReadDataForCompareDone. This variable represents the amount of data
from the network which is confirmed to be identical with the cached data,
and is updated every time the comparison finishes for a chunk of data
from the network. Previously it was incremented only by the amount of
bytes read from the cache, which can be less than the size of the chunk
of data from the network in the cases where the cache writer does not
finish the comparison in single read from the cache because the network
data is too large.

Bug: 871655
Change-Id: Ie3e0f192713b5d38582628c72175e4f7aa6771da
Reviewed-on: https://chromium-review.googlesource.com/1172222Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Momoko Hattori <momohatt@google.com>
Cr-Commit-Position: refs/heads/master@{#584353}

Update FooEvent* arguments of functions called by DefaultEventHandler()
in core/html/.
The arguments of functions never be nullptr, so it need to be reference
instead of pointer.

Bug: 874385
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I65925d4cf194482dd7216347fcbbec15e7f31089
Reviewed-on: https://chromium-review.googlesource.com/1180627Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com>
Cr-Commit-Position: refs/heads/master@{#584352}

Disables SaveType/SavePageOriginalVsSavedComparisonTest.ObjectElementsViaFile
which is flaky on several platforms (and fails consistenly on linux/asan).

TBR=lukasza

Bug: 840063
Change-Id: I7ac546dcb8f4a60417e45ca9b7ce20667b31abcb
Reviewed-on: https://chromium-review.googlesource.com/1180709Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584351}

This reverts commit 28ac1ad7.

Reason for revert: Looks like this broke components_unittests on iOS:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-simulator/36547

Original change's description:
> [unified-consent] Refactor migration code and add settings updates
> 
> The migration code in the UnifiedConsentService is refactored:
>  - The migration state IN_PROGRESS_SHOULD_SHOW_CONSENT_BUMP is
>  extracted to it's own pref kShouldShowUnifiedConsentBump.
>  - The migration state kInProgressWaitForSyncInit is introduced
>  to be able to update the settings for migration when sync is
>  initialized.
> 
> Additional changes:
>  - ShouldShowConsentBump only returns true if the consent bump
>  feature is enabled.
>  - The rollback enables sync-everything now also when the user is
>  not syncing USER_EVENTS (which is disabled during the migration).
> 
> Users that previously had the unified consent feature enabled and
> for which ShouldShowConsentBump=true, will not be shown the consent
> bump anymore after this CL is landed. This will only affect a few
> users on Canary and Dev.
> 
> Bug: 863932
> Change-Id: I211805f9059cd26056ed81d01ff19470b8caed3c
> Reviewed-on: https://chromium-review.googlesource.com/1172690
> Reviewed-by: David Roger <droger@chromium.org>
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Commit-Queue: Thomas Tangl <tangltom@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#584341}

TBR=ellyjones@chromium.org,droger@chromium.org,tangltom@chromium.org

Change-Id: Ic50e5f7e4ac7d04be1c170b3811fd594980c71c3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 863932
Reviewed-on: https://chromium-review.googlesource.com/1180682Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584350}

Changes in-process NavigableContentsView to work on any platform
supporting Views UI rather than restricting it to Aura platforms.

Adapts simple_browser to run in a non-Aura environment as well.

Bug: 855092
Test: Run DCHECK build of chrome --launch-in-process-simple-browser on Mac
Change-Id: Ibdf7ccd83a4c2f3d2c4d667898d3723166c257a3
Reviewed-on: https://chromium-review.googlesource.com/1178802
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584349}

Receiving the unmount error code will let Chrome properly handle various
types of errors, and produce better logging.

BUG=873903

Change-Id: I792a806440be6725ceba0663afc4b4ee3069d9bd
Reviewed-on: https://chromium-review.googlesource.com/1179109Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Anand Mistry <amistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584348}

- PlatformAppBrowserTest.PictureInPicture consistently fails with a
  (apparently windows-only) use-after-free on win/asan. That code is new,
  so just revert it (see below), https://crbug.com/873234

- PDFExtensionHitTestTest.MouseLeave flakes fairly often on win/asan, so
  disable the test in that config, https://crbug.com/856169

- SaveType/SavePageOriginalVsSavedComparisonTest.ObjectElementsViaFile/0
  fails fairly consistenly on win/asan (and elsewhere) in
  network_service_browser_tests, so don't enable that suite on the win/asan
  bot just yet (https://crbug.com/840063).

Bug: 869973

Revert "Enable Picture-in-Picture for chrome apps."

This reverts commit e031e566.

Reason for revert: Test has a use-after-free, https://crbug.com/873234

Original change's description:
> Enable Picture-in-Picture for chrome apps.
>
> This CL enables Picture-in-Picture in chrome apps by implementing
> EnterPictureInPicture and ExitPictureInPicture in AppDelegate.
>
> Bug: 863309
> Change-Id: Ib35e83b03373abe864b3a0674ab1e0b341ce291b
> Reviewed-on: https://chromium-review.googlesource.com/1156513
> Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580497}

TBR=beaufort.francois@gmail.com,rdevlin.cronin@chromium.org,jochen@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 863309
Change-Id: Ib6eda55a3b0889646c43ea3e7bfccdb590cea0b2
Reviewed-on: https://chromium-review.googlesource.com/1180763
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584347}

suggest_owners.py looks at commit history and suggests chromium
developers to be added as owners to subdirectories in the repo.

Change-Id: Ia7f2df2dbf7d96dc9322532b4c5cdab1443c95b8
Reviewed-on: https://chromium-review.googlesource.com/1174701Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584346}

net::NetworkChangeNotifier and base::PowerObserver are not hooked to
correct platform code on Mac, thus make background download service not
working correctly.

This CL provides default implementation for device status monitoring on
Mac that always treat the device connected to internet and power source.

This is mostly a temporary solution before platform code is implemented
correctly.

Also pull out BatteryStatusListener and NetworkStatusListener to a
separate file.

Bug: 825878
Change-Id: If34d8eb0cbe5d0575920c4251eda5e5161695adf
Reviewed-on: https://chromium-review.googlesource.com/1178689Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584345}

This removes parts of crrev.com/583350, preserving the following
- explicitly require that NSWindows be NativeWidgetMacNSWindow

This removes the ability to create an NSWindow in the AppShim process
for now. That will be re-added later.

This is a re-land of crrev.com/584323 (reverted in crrev.com/584323),
with the changes in lifetime management (use of autorelease) removed,
because it appears that tests make assumptions about lifetime. Added
a comment about this.

TBR=tapted

Bug: 859152
Change-Id: Ia0e2811c903316a0c1ed07be6cd7275bb8cf421d
Reviewed-on: https://chromium-review.googlesource.com/1180707Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584344}

This CL adds a Google G icon next to
"Sync and Google services" on the chrome://settings
page.

Bug: 872486
Change-Id: I8ef68cd0969dc7e926c40d91b05784e72106153d
Reviewed-on: https://chromium-review.googlesource.com/1179753Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584343}

This reverts commit 63fab7f6.

Reason for revert: breaking android-go-perf on chrome perf waterfall
BUG:875640

Original change's description:
> Reland "metrics: Initialize persistent metric allocator early."
> 
> This is a reland of 0cdc1458
> 
> Original change's description:
> > metrics: Initialize persistent metric allocator early.
> >
> > The PersistentMemoryAllocator in the gpu (and other) process is created
> > asynchronously. If any uma-histogram is reported before that time, then
> > those Histograms are not stored in the shared memory. This has some
> > implications:
> >  . If the process crashes (which is common for the gpu process on
> >    android), then these metrics are lost.
> >  . If the process stays alive, then the metrics are reported
> >    periodically, but because it is buffered, it doesn't match up
> >    correctly with the other metrics that are reported in the shared
> >    memory.
> >
> > The allocator is created in response to a message from the browser,
> > which includes the handle for the shared memory to use for the allocator.
> > The browser waits until the process has been launched and connected.
> > So this happens much later, compared to other messages which are sent
> > from browser over mojo without waiting for the connection to have
> > been established first. Therefore, change this so that the browser
> > immediately shares the shared-memory segment with the gpu process. mojo
> > takes care of waiting for the process-launch etc.
> >
> > BUG=865179, 778749
> >
> > Change-Id: Iccd3d4422de3e22ead4bc6510afc5ea207bf6b6e
> > Reviewed-on: https://chromium-review.googlesource.com/1174709
> > Reviewed-by: Brian White <bcwhite@chromium.org>
> > Reviewed-by: Avi Drissman <avi@chromium.org>
> > Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#583673}
> TBR=avi,sadrul
> 
> Bug: 865179, 778749
> Change-Id: I205221ed82b073464e1c4d52593ba727ebc211a5
> Reviewed-on: https://chromium-review.googlesource.com/1179346
> Reviewed-by: Matthew Jones <mdjones@chromium.org>
> Commit-Queue: Matthew Jones <mdjones@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#584203}

TBR=avi@chromium.org,sadrul@chromium.org,bcwhite@chromium.org,mdjones@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 865179, 778749
Change-Id: I7fd057c81494dff8072a2e847510821ec6ff8530
Reviewed-on: https://chromium-review.googlesource.com/1180741Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#584342}

The migration code in the UnifiedConsentService is refactored:
 - The migration state IN_PROGRESS_SHOULD_SHOW_CONSENT_BUMP is
 extracted to it's own pref kShouldShowUnifiedConsentBump.
 - The migration state kInProgressWaitForSyncInit is introduced
 to be able to update the settings for migration when sync is
 initialized.

Additional changes:
 - ShouldShowConsentBump only returns true if the consent bump
 feature is enabled.
 - The rollback enables sync-everything now also when the user is
 not syncing USER_EVENTS (which is disabled during the migration).

Users that previously had the unified consent feature enabled and
for which ShouldShowConsentBump=true, will not be shown the consent
bump anymore after this CL is landed. This will only affect a few
users on Canary and Dev.

Bug: 863932
Change-Id: I211805f9059cd26056ed81d01ff19470b8caed3c
Reviewed-on: https://chromium-review.googlesource.com/1172690Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584341}

This reverts commit 740a6c4c.

Reason for revert: views_unittests WidgetTest.FullscreenStatePropagated ,
WidgetTest.FullscreenStatePropagated_DesktopWidget consistently started failing on 10.10 (other versions seem happy):

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/34348

Original change's description:
> RemoteMacViews: Re-separate test code
> 
> This removes parts of crrev.com/583350, preserving the following
> - explicitly require that NSWindows be NativeWidgetMacNSWindow
> - return a scoped_nsobject from CreateNSWindow, and remove requirement
>   of autoreleasing the result, to clarify lifetimes
> 
> This removes the ability to create an NSWindow in the AppShim process
> for now. That will be re-added later.
> 
> Bug: 859152
> Change-Id: Ife70a91ac9557f2ec7a488a8714f907eaecea0e3
> Reviewed-on: https://chromium-review.googlesource.com/1177276
> Commit-Queue: ccameron <ccameron@chromium.org>
> Reviewed-by: Trent Apted <tapted@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#584323}

TBR=tapted@chromium.org,ccameron@chromium.org

Change-Id: I9c16deb13126c51171bdd180200025cbcf808a03
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 859152
Reviewed-on: https://chromium-review.googlesource.com/1180762Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584340}

This reverts commit 5f99a2c0.

Reason for revert: WebDialogBrowserTest.SizeWindow fails on max 10.11, 10.12 (10.10 and 10.13 seem happy):

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/28636
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/14984

Original change's description:
> RemoteMacViews: Remove browser dependencies of SetBounds
> 
> The function BridgedNativeWidget::SetBounds calls back into the
> NativeWidgetMac to determine
> - the minimum content size
> - if the widget's position should be relative to the parent or the
>   screen (and the offset to do that computation)
> - if the widget is a modal sheet
> This call will eventually be running in the app shim process, where
> these values will not be available (without adding a synchronous IPC).
> 
> Change NativeWidgetMac::SetBounds to call BridgedNativeWidgetHostImpl::
> SetBounds, and have that function pre-compute the required parameters,
> - minimum content size
> - offset necessary to be applied to compensate for position being
>   relative to the parent or the screen
> - (but not if the widget is a modal sheet, that's coming later)
> and pass these as parameters to BridgedNativeWidget::SetBounds.
> 
> Split out the SetBounds calls made during initialization from
> being within BridgedNativeWidget::Init to being made by its caller,
> BridgedNativeWidgetHostImpl::InitWindow, to allow the additional
> parameters to be passed in.
> 
> Bug: 859152
> Change-Id: I2f33ab08f60d2ed1bc3b6af5ecf3402e3715ffd4
> Reviewed-on: https://chromium-review.googlesource.com/1178813
> Commit-Queue: ccameron <ccameron@chromium.org>
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#584327}

TBR=ellyjones@chromium.org,ccameron@chromium.org

Change-Id: I1300db812416881fb539b586e7d7fab2597d60c5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 859152
Reviewed-on: https://chromium-review.googlesource.com/1180761Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584339}

One recently re-enabled test fails, so to be able run the whole suite, also:
Revert "Reland "[Sync:USS] Enable more two client bookmarks integration tests""

This reverts commit f846b651.

Reason for revert: One of the tests fails on win/asan, https://crbug.com/875239

Original change's description:
> Reland "[Sync:USS] Enable more two client bookmarks integration tests"
>
> This is a reland of 94d8037b
>
> Original change's description:
> > [Sync:USS] Enable more two client bookmarks integration tests
> >
> > This CL enables more integration tests for bookmarks to run
> > against USS archiecture.
> >
> >
> > Bug: 516866
> > Change-Id: Icece27bdf1b2070ca72d667b1a70e623c45c315f
> > Reviewed-on: https://chromium-review.googlesource.com/1158691
> > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
> > Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#580434}
>
> Bug: 516866
> Change-Id: Ia922ab75b92c013cc2e06cb3ec5a549875390316
> Reviewed-on: https://chromium-review.googlesource.com/1161882
> Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580499}

TBR=mastiz@chromium.org,mamir@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 516866, 875239
Change-Id: I85e49dbfd4e6c2aba675854efb42c4a87d3243b8
Reviewed-on: https://chromium-review.googlesource.com/1180661
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584338}

All the logic was hooked up for calculation of the metric but the UMA metric
itself was missing.

Bug: 859155
Change-Id: Iab4e3c726e2627d1f1325ee30bebd1ee9eae6f76
Reviewed-on: https://chromium-review.googlesource.com/1179985Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584337}

https://skia.googlesource.com/skia.git/+log/ae7229480cbe..fb65db10aa31


git log ae7229480cbe..fb65db10aa31 --date=short --no-merges --format='%ad %ae %s'
2018-08-19 reed@google.com show inflextion on cubic


Created with:
  gclient setdep -r src/third_party/skia@fb65db10aa31

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=fmalita@chromium.org

Change-Id: I6bccee3e00ab11f2ed6be2420b524e7d0a9246b6
Reviewed-on: https://chromium-review.googlesource.com/1180723Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#584336}

The methods for computing start and end index for a shape result compute
the values on demand, while not too expensive these methods are called a
lot during both layout and paint. By pre-computing the values text paint
performance is improved by about 10% for LayoutNG & about 2% for legacy.

Bug: 714962
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ib652b947d6cc670e657d72d753e96ecb4e2aa85d
Reviewed-on: https://chromium-review.googlesource.com/1176202
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584335}

https://skia.googlesource.com/skia.git/+log/5cc10c8cd6db..ae7229480cbe


git log 5cc10c8cd6db..ae7229480cbe --date=short --no-merges --format='%ad %ae %s'
2018-08-19 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version


Created with:
  gclient setdep -r src/third_party/skia@ae7229480cbe

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=fmalita@chromium.org

Change-Id: I8ec3f5bcb57e1a90af908c53cc2a70ca54c95a20
Reviewed-on: https://chromium-review.googlesource.com/1180721Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#584334}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/df1dcd998db4..0e1fc1042fe0


git log df1dcd998db4..0e1fc1042fe0 --date=short --no-merges --format='%ad %ae %s'
2018-08-19 dhanyaganesh@chromium.org CreateTarball: Refactor and clean up debug code


Created with:
  gclient setdep -r src/third_party/chromite@0e1fc1042fe0

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I605ad564f6aad6c6d52b727d48b7697452590910
Reviewed-on: https://chromium-review.googlesource.com/1180722Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#584333}

Bug:676612
Change-Id: Ia884ea757f60c625442a7564955f4f0eea8a1164
TBR=ksakamoto@chromium.org, kouhei@chromium.org

NOTRY=true

Change-Id: Ia884ea757f60c625442a7564955f4f0eea8a1164
Reviewed-on: https://chromium-review.googlesource.com/1180213
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#584332}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

The AutoRoll server is located here: https://afdo-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: I631e2f562686bafc3a78b8fd7a251edc984dcf0c
Reviewed-on: https://chromium-review.googlesource.com/1180660
Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#584331}

This is a precursor to https://crrev.com/c/1053338 which introduces
base::CheckedObserver. Existing observers will be unchecked (as they
are already). There is no behavior change with this CL.

The CL is mechanical. The bulk was done with variations on a sed script:

git grep -l ' base::ObserverList<.*> .*;' -- '*.cc' '*.h' '*.mm' | \
  xargs -IX sed -i -r 's/(^[ ]*)base::ObserverList<([^>]*)> (.*);/'\
    '\1base::ObserverList<\2>::Unchecked \3;/' X

With some manual follow-ups to get special cases.

TBR=gab@chromium.org

Bug: 842987
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_mojo;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Idffe88e2b52f67f9226eb7b6d922070349dacc22
Reviewed-on: https://chromium-review.googlesource.com/1175511
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584330}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=mmoss@chromium.org

Change-Id: Ic65a498a89afdaa77da052cd7378deb16c75665d
Reviewed-on: https://chromium-review.googlesource.com/1180702Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584329}

It introduces wayland_util.cc/h and moves the code to create shared
memory buffer and draw bitmap on it from WaylandCursor, as it could
be used generally rather than specific to cursor area.
On upcoming patch for drag and drop on Wayland, it's also required
to pass the drag icon surface to Wayland.

It doesn't bring behavioral changes.

Bug: 578890, 875164
Change-Id: I0cd4603c2abacaa899a9fcf19d97186d6f493146
Reviewed-on: https://chromium-review.googlesource.com/1179487
Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Maksim Sisov <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#584328}

The function BridgedNativeWidget::SetBounds calls back into the
NativeWidgetMac to determine
- the minimum content size
- if the widget's position should be relative to the parent or the
  screen (and the offset to do that computation)
- if the widget is a modal sheet
This call will eventually be running in the app shim process, where
these values will not be available (without adding a synchronous IPC).

Change NativeWidgetMac::SetBounds to call BridgedNativeWidgetHostImpl::
SetBounds, and have that function pre-compute the required parameters,
- minimum content size
- offset necessary to be applied to compensate for position being
  relative to the parent or the screen
- (but not if the widget is a modal sheet, that's coming later)
and pass these as parameters to BridgedNativeWidget::SetBounds.

Split out the SetBounds calls made during initialization from
being within BridgedNativeWidget::Init to being made by its caller,
BridgedNativeWidgetHostImpl::InitWindow, to allow the additional
parameters to be passed in.

Bug: 859152
Change-Id: I2f33ab08f60d2ed1bc3b6af5ecf3402e3715ffd4
Reviewed-on: https://chromium-review.googlesource.com/1178813
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584327}

Using wpt-import in Chromium e57c623d.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22916

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: Id7f2b07592d744cd563d75f7bf95bb2ba03ad8d3
Reviewed-on: https://chromium-review.googlesource.com/1180652
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584326}

This reverts commit ee9ee634.

Reason for revert: Likely broke remoting tests on Win7, https://crbug.com/875619

Original change's description:
> [Windows Host] Prevent connection hang for hosts with 3D Display Mode enabled
> 
> This change prevents a hang when connecting to a Windows machine
> which has curtain mode and 3d display mode enabled.  The root cause
> of the hang is that creating a D3D11 device takes several seconds so
> function calls which used to take a few milliseconds now take 5+
> seconds.  I did not see a mechanism to control this display mode
> programatically so I am adding code which can detect the condition
> and the logic to prevent D3D usage when 3D mode is enabled.
> 
> Of note is the change in BasicDesktopEnvironment where I requery the
> D3D apis.  DesktopEnvironmentOptions are queried in Session 0 and
> then passed on to the Desktop process.  There is a non-obvious
> problem with this as many D3D methods cannot be queried or will
> not return reliable results.  This results in a base set of options
> being set in Session 0 (which includes user / experiment overrides)
> and then passed into a session where D3D will return new values.  In
> this CL, I requery the D3D APIs and update the capturer options if
> they should be disabled.
> 
> BUG=836007
> 
> Change-Id: Ib7a6e61fa7987bd093e93a6100b97cc49e3aff05
> Reviewed-on: https://chromium-review.googlesource.com/1164403
> Commit-Queue: Joe Downing <joedow@chromium.org>
> Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#583276}

TBR=jamiewalch@chromium.org,joedow@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 836007
Change-Id: I464ba6eb37560ef6fc687516e9e33682bee4ac7a
Reviewed-on: https://chromium-review.googlesource.com/1180681Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584325}

When the user clicks on the shutdown button in the system tray we start
a process that tears down ash::Shell and closes the tray bubble. This
dispatches mouse exit events to windows as the system is being torn
down. In production this sometimes crashes. I cannot repro on device,
on linux-chromeos, or under ASAN, using the M69 code.

The crash started after we turned off the new unified system tray
in M69, so it's likely related to the old system tray. It should
go away when we switch to the new tray.

As a workaround, skip dispatch of mouse exits during shutdown and
don't process any new events.

Bug: 874156
Test: manually exercise sign out and shutdown
Change-Id: Ic898d15270661b3275a4f396d154ad2c02ba0644
Reviewed-on: https://chromium-review.googlesource.com/1180070
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584324}

This removes parts of crrev.com/583350, preserving the following
- explicitly require that NSWindows be NativeWidgetMacNSWindow
- return a scoped_nsobject from CreateNSWindow, and remove requirement
  of autoreleasing the result, to clarify lifetimes

This removes the ability to create an NSWindow in the AppShim process
for now. That will be re-added later.

Bug: 859152
Change-Id: Ife70a91ac9557f2ec7a488a8714f907eaecea0e3
Reviewed-on: https://chromium-review.googlesource.com/1177276
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584323}