- 28 Sep, 2018 40 commits
-
-
Kevin Bailey authored
Also added enum for "tab switch offered". This allows UMA to treat the data (0,1) as entities, not quantities. Bug: 854714 Change-Id: I891aa38603c741070013a6cb06cc52df2bce14cb Reviewed-on: https://chromium-review.googlesource.com/1247028 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#595094}
-
Alex Clarke authored
By mistake SequenceManagerImpl is crashing on exit if CreateUnboundSequenceManager(null) is called but BindToMessageLoop is not. This patch fixes that. Bug: 863341, 872372 Change-Id: I2827ab40c1e32553f1c42229762732b5cd42801d Reviewed-on: https://chromium-review.googlesource.com/1251448Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#595093}
-
Mario Sanchez Prada authored
Neither signin_manager.h nor profile_oauth2_token_service.h are being used from this implementation file, we can clean these includes up. Bug: 890236 Change-Id: I3d6e55bc63e5c6e43115de1e46022fdee404d83e Reviewed-on: https://chromium-review.googlesource.com/1251623Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#595092}
-
Dominic Farolino authored
This CL adds the getResourcePriority method to the WorkerInternals interface via the partial interface defined in core/fetch. This will help testing resource priorities fetched from worker contexts (i.e., Service Workers). Before this CL, getResourcePriority was only exposed on Internals, and thus all ResourceFetchers associated with WorkerGlobalScopes could not be queried. R=kinuko@chromium.org, yhirano@chromium.org, yoav@yoav.ws Bug: 872776 Change-Id: I010b95441c191cf90dfda7b0d5f58c7e7d6c7c21 Reviewed-on: https://chromium-review.googlesource.com/1249882Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Cr-Commit-Position: refs/heads/master@{#595091}
-
Marc Treib authored
next_token_request_time is always supposed to be equal to the scheduled run time of request_access_token_retry_timer_. Instead of keeping this redundant state (and risk it getting out of sync), let's just compute next_token_request_time when we need it. Bug: 889859 Change-Id: I2b47d5dd78ef55bbfe1c0b43657cf9125e3f4586 Reviewed-on: https://chromium-review.googlesource.com/1250927 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#595090}
-
Lukasz Anforowicz authored
Changing the type of the parameter from GURL to url::Origin is desirable because: 1) The only user of the parameter (ProxyingURLLoaderFactory::MaybeProxyRequest) was looking at the origin, rather than at the URL. 2) Current users of the WillCreateURLLoaderFactory's parameter (ProxyingURLLoaderFactory::MaybeProxyRequest) and future callees of RenderFrameHostImpl::CreateNetworkServiceDefaultFactoryInternal (extensions::URLLoaderFactoryManager - see https://crrev.com/c/1228478) should make decisions based on the origin rather than URL (URLs with blob:, data: and about: schemes are tricky here). Bug: 846346 Change-Id: Ia1acc3735664c2f6f6290bd23b5431b633381644 Reviewed-on: https://chromium-review.googlesource.com/1234361Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#595089}
-
Denis Kuznetsov authored
Bug: 854101 Change-Id: Ibd9375295ea26ff0533dadcc8153cabfe71ba786 Reviewed-on: https://chromium-review.googlesource.com/1251443 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#595088}
-
Jérôme Lebel authored
The alert dialog property should be set to nil in the dialog callback before doing anything else. DCHECK is failing since the first alert dialog still exist in _alertCoordinator, when creating the second alert dialog: https://cs.chromium.org/chromium/src/ios/chrome/browser/ui/authentication/authentication_flow_performer.mm?l=321 There is no consequence since when cleaning up _alertCoordinator for the first dialog (while the second dialog is already set into _alertCoordinator). _alertCoordinator is not set to nil because of that test [1] when the cleanup is done [2]. [1]: https://cs.chromium.org/chromium/src/ios/chrome/browser/ui/authentication/authentication_flow_performer.mm?l=387 [2]: https://cs.chromium.org/chromium/src/ios/chrome/browser/ui/authentication/authentication_flow_performer.mm?l=218 Bug: 890332 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I012baa44c3a129a54bc8a3d4c0f442b06e04b68a Reviewed-on: https://chromium-review.googlesource.com/1251601 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#595087}
-
Etienne Pierre-doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /device/bluetooth/bluez. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=rkc@chromium.org Bug: 874080 Change-Id: I4ab9d5ae6b94c448f3e30e6e9c607fb88a1078bf Reviewed-on: https://chromium-review.googlesource.com/1191183Reviewed-by:Rahul Chaturvedi <rkc@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#595086}
-
Mugdha Lakhani authored
Change-Id: Iff2fac58c58042d4ddf55ef962df61954414a1fd Reviewed-on: https://chromium-review.googlesource.com/1230025 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#595085}
-
Ryan Cui authored
The tests were previously flaky because of crbug.com/884589. Now that it's fixed, renable these tests. The EncryptedMediaTest's used to fail for the same reason, but are now failing because of a memory leak (crbug.com/889993), so keep these disabled for now. Bug: 884589 Change-Id: Ia394e710d47f995f64ce858a51439ad11bdc2518 Reviewed-on: https://chromium-review.googlesource.com/1249913Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ryan Cui <rcui@chromium.org> Cr-Commit-Position: refs/heads/master@{#595084}
-
Rayan Kanso authored
This solves the issue of auto-resuming notifications. OnItemUpdated was being called after the notification was paused with an offline item containing an out-of-sync status. There is also a race condition between pausing the job (OIC) and the download completing (DS), so new downlaods need to be throttled in case the job is paused. Bug: 855856 Change-Id: I537789e7b1607fc4ce69b9cc7593a6499152475c Reviewed-on: https://chromium-review.googlesource.com/1241157 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#595083}
-
Reilly Grant authored
An entire URLRequestContext was created for extensions when it was only used to hold a CookieStore for the chrome-extension:// origin. This patch simplifies this situation by removing this concept and replacing it with just an extensions-specific CookieStore. This should reduce further confusion that this URLRequestContext is used for actual URL requests. Bug: 158386 Change-Id: Iaab7b19c578eae75c79a1fb93434e0b04db95c7c Reviewed-on: https://chromium-review.googlesource.com/1250098Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#595082}
-
Hans Wennborg authored
This reverts commit 7c58d162. Reason for revert: This broke win-asan, see 2nd bug. Original change's description: > Roll clang 342523:343189. > > Bug: 888476 > Change-Id: Iccb39603a10261d1bdf3fcb26b008bb02fc371e6 > Reviewed-on: https://chromium-review.googlesource.com/1245465 > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594765} TBR=thakis@chromium.org,hans@chromium.org Change-Id: I003bbfca7a542fe18c31a679ea58cf1da2c3fdb3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 888476, 890310 Reviewed-on: https://chromium-review.googlesource.com/1251606Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#595081}
-
Denis Kuznetsov authored
Bug: 854101 Change-Id: Iea1248fd7d8bcb8c5eb0443c713fbf8717b1255a Reviewed-on: https://chromium-review.googlesource.com/1251542 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#595080}
-
Mirko Bonadei authored
This reverts commit 7c77c254. Reason for revert: Probably breaks some chromium.webrtc Original change's description: > Roll src/third_party/webrtc 89f64d305eff..cbcbc225687f (3 commits) > > https://webrtc.googlesource.com/src.git/+log/89f64d305eff..cbcbc225687f > > > git log 89f64d305eff..cbcbc225687f --date=short --no-merges --format='%ad %ae %s' > 2018-09-28 nisse@webrtc.org Reland "Replace VideoDecoder with VideoDecoderFactory in VideoReceiveStream config." > 2018-09-28 kron@webrtc.org Parse two-byte header extensions. > 2018-09-28 henrika@webrtc.org Improves threading model in AudioDeviceTest. > > > Created with: > gclient setdep -r src/third_party/webrtc@cbcbc225687f > > The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng > TBR=webrtc-chromium-sheriffs-robots@google.com > > Change-Id: I047923cf7501cf353a3b50b6c560e0ab42a550da > Reviewed-on: https://chromium-review.googlesource.com/1250948 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#595070} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,webrtc-chromium-sheriffs-robots@google.com Change-Id: Icb55c9c65ef78633440b412a6b7ecddac7437e75 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1251450Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#595079}
-
Gemene Narcis authored
This change is supposed to delete obsolete HTTP data from the password store 60 seconds after start up. This CL will delete HTTP credentials with HSTS enabled for that host and for which an equivalent (i.e. same signon_realm, PasswordForm::Scheme,username and password) HTTPS credential exists. Also it replaces HTTP credentials by an HTTPS version of that form if site has HSTS enabled and no HTTPS credential with same signon_realm, same PasswordForm::Scheme and username exists. Bug: 871140, 879244 Change-Id: I605e39f25ce1052aa67d95cf84601a9db94c33a6 Reviewed-on: https://chromium-review.googlesource.com/1178282Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Narcis Gemene <gemene@google.com> Cr-Commit-Position: refs/heads/master@{#595078}
-
Chromium WPT Sync authored
Using wpt-import in Chromium dfabb6a5. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25461 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: Ia29fac6b63b6fb1cf3d7d038570100033399d4d4 Reviewed-on: https://chromium-review.googlesource.com/1251227 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#595077}
-
Mihai Sardarescu authored
When loading the primary account, the SigninManager may decide to force sign-out (e.g if the user disallowed signed in). In this case, the GAIAInfoUpdateService is not notified (as it is created only after the SigninManager), so it fails to clear the GAIA name, given name and picture from the profile entry cache. This CL clears the GAIA name, given name and picture from the profile entry cache when the GAIAInfoUpdateService is created if the profile does not have any primary account. Bug: 890309 Change-Id: I21211cc355672e4ecdc4e911a56187c63b97b8f1 Reviewed-on: https://chromium-review.googlesource.com/1251442Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#595076}
-
Chris Lu authored
- Updates _currentPage properly in response to 3-finger accessibility swipe. This will now properly read out the currently visible page if a user swipes to a different page. - Ensures that only the currently visible page's elements can be selected in the scroll view. This resolves an issue VoiceOver was having with what page to readout and to focus on. Oftentimes the visible page was not readout or selectable. Video: https://drive.google.com/open?id=1Q62MUlrVcNlqnFIQOfw_YiGHinTKb_45 Bug: 880079 Change-Id: Ic9a91762e9a5f04b267ac588c83a675d61bd53cf Reviewed-on: https://chromium-review.googlesource.com/1221474 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#592818} Reviewed-on: https://chromium-review.googlesource.com/1238995 Cr-Commit-Position: refs/heads/master@{#595075}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/40a2e1ea2449..5cfa93810a40 git log 40a2e1ea2449..5cfa93810a40 --date=short --no-merges --format='%ad %ae %s' 2018-09-28 hjd@google.com Merge "perfetto-ui: Factor checkerboard out" Created with: gclient setdep -r src/third_party/perfetto@5cfa93810a40 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I4638054db03af150d38ea83923ccdc147e88e23e Reviewed-on: https://chromium-review.googlesource.com/1250951Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595074}
-
Vladislav Kuzkokov authored
This adds new policy that allows admin to restrict duplex mode to either one-sided only or two-sided only. Bug: 853877, 885265 Change-Id: I3698ca4d248415693590b895d0f3c28ad95755c2 Reviewed-on: https://chromium-review.googlesource.com/1224310 Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#595073}
-
momohatt authored
This patch enables ServiceWorkerSingleScriptUpdateChecker to check if there are any differences between the stored scripts and its counterparts loaded from the network. The comparison is only performed for scripts that are used in the instance of requested SWVersion. This impl doesn't yet allow SWNewScriptLoader to continue the aborted comparison, but future patches will implement: * passing the result of update check to SWNewScriptLoader * record the info about scripts which are already compared and known to be identical Bug: 648295 Change-Id: If89dd415578b1c5809159f196d398447a96a812f Reviewed-on: https://chromium-review.googlesource.com/1224610 Commit-Queue: Momoko Hattori <momohatt@google.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#595072}
-
François Doray authored
This reverts commit 5cae37b5. Reason for revert: Find-it identified this as culprit for multiple failures as shown on https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.linux/builders/linux-xenial-rel/builds/3696 Failures in: virtual/layout_ng_experimental/fast/multicol/balance-float-with-margin-top-and-line-after-break.html virtual/layout_ng_experimental/fast/multicol/dynamic/remove-abspos-next-to-spanner.html Original change's description: > [LayoutNG] Make constraint space for column balancing intermediate > > Fragment caching and paint needs to know if fragments created > for a constraint space are for the regular layout that are to > be painted, or it's for intermediate computation. > > Since the layout results for column balancing should not be > painted, this patch marks so. > > This change alone doesn't fix all weird paint data > inconsistencies when block fragmentation is turned on. Other > issues need further investigation. > > Bug: 714962 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng > Change-Id: I14d44ca10fd23726f2c08be45b10c2b0abe16bf7 > Reviewed-on: https://chromium-review.googlesource.com/1250685 > Commit-Queue: Koji Ishii <kojii@chromium.org> > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595051} TBR=kojii@chromium.org,mstensho@chromium.org Change-Id: Id550d1f9cafa348eebf378e2aeb7c213cf16a75f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 714962 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/1251228Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#595071}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/89f64d305eff..cbcbc225687f git log 89f64d305eff..cbcbc225687f --date=short --no-merges --format='%ad %ae %s' 2018-09-28 nisse@webrtc.org Reland "Replace VideoDecoder with VideoDecoderFactory in VideoReceiveStream config." 2018-09-28 kron@webrtc.org Parse two-byte header extensions. 2018-09-28 henrika@webrtc.org Improves threading model in AudioDeviceTest. Created with: gclient setdep -r src/third_party/webrtc@cbcbc225687f The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I047923cf7501cf353a3b50b6c560e0ab42a550da Reviewed-on: https://chromium-review.googlesource.com/1250948Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595070}
-
Justin Cohen authored
Bug: 807330 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Iaa0935d3d3c10a5ad80a9cf4e758d84e9af95c3a Reviewed-on: https://chromium-review.googlesource.com/1249885 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#595069}
-
Tonko Sabolčec authored
Chrome doesn't handle failures when initializing PasswordStore. This causes a bug that user is asked to save passwords when Chrome is not able to save them. This CL includes: - Check if encryption is available on Mac. - Check if login database was successfully initialized. Bug: 479725 Change-Id: Ic491e2b04c98270b984a6f08a431b99863419116 Reviewed-on: https://chromium-review.googlesource.com/1243069 Commit-Queue: Tonko Sabolčec <tsabolcec@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#595068}
-
Lei Zhang authored
One small missing bit from r560988. Change-Id: Ib6afc4957fdc8eae24b1f21f7929cedbe056cac2 Reviewed-on: https://chromium-review.googlesource.com/1250205Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#595067}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/76007858f065..bea5a39cb895 Created with: gclient setdep -r src-internal@bea5a39cb895 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I083213f356df89843320d60f041e66b5c9aaf12e Reviewed-on: https://chromium-review.googlesource.com/1250950Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595066}
-
Tsuyoshi Horo authored
This reverts commit 4762a830. The difference from the original patch is that in this patch SignedExchangeAcceptHeaderBrowserTest uses SetUp() instead of SetUpOnMainThread() to avoid the failures in TSAN bots. Bug: 887201 TBR=kinuko@, kouhei@, ksakamoto@ Original change's description: > Send SXG accept header of navigation only to limited origins for Origin Trial. > > Before this patch: > The SXG accept header is sent to all origins when SignedHTTPExchange feature > or SignedHTTPExchangeOriginTrial feature is enabled. > > After this patch: > The SXG accept header is sent when > - SignedHTTPExchange feature is enabled. > or > - SignedHTTPExchangeOriginTrial feature and SignedHTTPExchangeAcceptHeader > feature are enabled and the origin of the URL is in the OriginList of > SignedHTTPExchangeAcceptHeader field trial. > > Bug: 887201 > Change-Id: Ic67a8bc0644b1b6172030ff75162c04663dd33f0 > Reviewed-on: https://chromium-review.googlesource.com/1242768 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Commit-Queue: Tsuyoshi Horo <horo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595002} Change-Id: Iff188ffe2096c35d2c9fb4eee3723e78f5901b26 Reviewed-on: https://chromium-review.googlesource.com/1251144Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#595065}
-
Yuta Kitamura authored
Bug: 826203 Change-Id: I0d8a2ad46df93e3bf50b71a34b4abb315844a84e Reviewed-on: https://chromium-review.googlesource.com/1250522Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#595064}
-
Yuta Kitamura authored
This CL moves most of the actual work of initializing compositor thread from RenderThreadImpl to Platform. This further reduces //content's dependency to WebThread. A new virtual function is introduced to Platform so we can change the thread priority of the created compositor thread on Linux, where we need to talk to the browser process to change the thread priority. Additionally, a new function Platform::CompositorThreadTaskRunner() is introduced, because RenderThreadImpl needs to post tasks to the compositor thread after the thread is initialized. Bug: 826203 Change-Id: Ic80e6452cdfe8af25ae2b277125687854859d106 Reviewed-on: https://chromium-review.googlesource.com/1249424 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#595063}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e14a15df1635..76007858f065 Created with: gclient setdep -r src-internal@76007858f065 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I54e330693fa5e39e6d7eb48e4bb0c61778146008 Reviewed-on: https://chromium-review.googlesource.com/1250947Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595062}
-
Stephane Zermatten authored
This change introduces support for the action navigate, which tells the browser to go to a specific URL. The action finishes without waiting for the new page to load. Bug: 806868 Change-Id: Ibe354eb627b836e6e1d5ad5ff461a8b392102faa Reviewed-on: https://chromium-review.googlesource.com/1248783 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#595061}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1ee9160a2e0b..89f64d305eff git log 1ee9160a2e0b..89f64d305eff --date=short --no-merges --format='%ad %ae %s' 2018-09-28 crodbro@webrtc.org Move network trace calculation from analyzer to rtc_event_log_parser. 2018-09-28 mbonadei@webrtc.org Remove deprecated field_trial_default and metrics_default. 2018-09-28 peah@webrtc.org AEC3: Remove killswitches in AecState 2018-09-28 phensman@webrtc.org Add option to call VMAF in compare_videos.py. Created with: gclient setdep -r src/third_party/webrtc@89f64d305eff The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:b/116768521 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iaf84f48258437048eba24462cabc1b0971408fc1 Reviewed-on: https://chromium-review.googlesource.com/1250946Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595060}
-
Rayan Kanso authored
The BackgroundFetchCrossOrigin filter is conservative and does not expose any headers if something shouldn't be exposed. Bug: 838837 Change-Id: I3a9f91ba5f2e7c57f2975419f192b5de64c6d886 Reviewed-on: https://chromium-review.googlesource.com/1249210Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#595059}
-
Jamie Madill authored
This reverts commit 9803c0eb. Reason for revert: WebGL 2 video test failures on Win/Mac. Blocking the ANGLE CQ. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20FYI%20Release%20%28NVIDIA%29/2542 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20FYI%20Release%20%28Intel%29/6848 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20FYI%20Release%20%28NVIDIA%29/2571 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20FYI%20Release%20%28AMD%29/2795 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20FYI%20Retina%20Release%20%28AMD%29/8042 Also reverts "[media] Fix video frame copy when context is lost." Bug: 890281 Original change's description: > [media] Fix video to canvas GPU-CPU race. > > VideoFrames marked with VideoFrameMetadata::READ_LOCK_FENCES_ENABLED > must be retained until all reads have been completed. Such frames are > produced when software frames are uploaded to GpuMemoryBuffers. The > VideoResourceUpdater handles this, but PaintCanvasVideoRenderer > implemented only sync tokens. > > As a result, WebGL reads of software-decoded frames can tear when the > storage is reused for later frames. > > This CL adds a GL_COMMANDS_COMPLETED_CHROMIUM query after each potential > VideoFrame read in PaintCanvasVideoRenderer, and retains a reference to > the VideoFrame until it completes. This ensures that the memory is not > reused until after the reads complete in the GPU process. > > Bug: 819914 > Change-Id: I3e6e5f83cff86beedbd76a406aa31c4eb84a0929 > Reviewed-on: https://chromium-review.googlesource.com/1244835 > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Commit-Queue: Dan Sanders <sandersd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594900} TBR=pfeldman@chromium.org,tedchoc@chromium.org,sandersd@chromium.org,dcastagna@chromium.org,sunnyps@chromium.org,piman@chromium.org Change-Id: Ib21a4879a9ca6fc4b84f6f2c2f1171c794db54b7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 819914 Reviewed-on: https://chromium-review.googlesource.com/1251321 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#595058}
-
Alex Clarke authored
The intent of this patch is to define the interfaces which will be implemented by subsequent patches. The interfaces are a subset of the C++ ones including what we believe is the minimum requried to be useful. Design doc: https://docs.google.com/document/d/1z1BDq9vzcEpkhN9LSPF5XMnZ0kLJ8mWWkNAi4OI7cos/edit# Bug: 863341, 872372 Change-Id: Ic608660a13c55c4b17d3ba5fa3bb636783735645 Reviewed-on: https://chromium-review.googlesource.com/1245790 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#595057}
-
Michael van Ouwerkerk authored
This reflects the implementation of onNavigationEvent. Bug: 882442 Change-Id: I15a96adf98707e6c18fe19646724076623db85c4 Reviewed-on: https://chromium-review.googlesource.com/1246161Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#595056}
-
Vadym Doroshenko authored
That's good both for privacy and storage reasons. Bug: 831123 Change-Id: Ie41b6d1f25fe37f86aea9eb4625d8aa878e0a52e Reviewed-on: https://chromium-review.googlesource.com/1249205 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#595055}
-