GitLab

BUG=481588

Review-Url: https://codereview.chromium.org/2280153002
Cr-Commit-Position: refs/heads/master@{#419072}

This CL is a step toward deep linking to site details in the site
settings. This CL adds the c++ handler backend and does show the
exceptions in the UI. The page title is not updated with the subject URL,
but that is not a regression and will be addressed in a future CL.

BUG=635874
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2338163004
Cr-Commit-Position: refs/heads/master@{#419071}

BUG=646443
NO_DEPENDENCY_CHECKS=true

Review-Url: https://codereview.chromium.org/2338333002
Cr-Commit-Position: refs/heads/master@{#419070}

This patch renames createVisiblePosition() (all overloads) to
createVisiblePositionDeprecated() to discourage creating a VisiblePosition
in dirty layout and waiting for layout update lazily. This patch also
introduces new createVisiblePosition() which assumes clean layout.

This patch is a preparation for hoisting the layout update call from the old
createVisiblePosition(). In follow up patches, the callers should ensure
clean layout by themselves and call the new createVisiblePosition() instead.

This patch is a mechanical substitution
's/createVisiblePosition(/createVisiblePositionDeprecated(/g', followed
by the following changes:
- Introduce the new createVisiblePosition() in VisiblePosition.h/cpp.
- Revert the substitution in modules/accessibility/AXLayoutObject.cpp,
  since callers there already ensure clean layout

BUG=647219

Review-Url: https://codereview.chromium.org/2341053002
Cr-Commit-Position: refs/heads/master@{#419069}

These were disabled ~12 months ago for being flaky. 50 runs
through the linux_chromium_rel_ng trybot revealed no flakiness.

BUG=527437

Review-Url: https://codereview.chromium.org/2336903004
Cr-Commit-Position: refs/heads/master@{#419068}

BUG=646323
TESTS=webkit_unit_tests DocumentLoadingRenderingTest.ShouldNotPerformRepeatedLayoutWithPendingImport DocumentLoadingRenderingTest.ShouldClearPlaceholderStyleWhenIgnoringPendingStylesheet

Review-Url: https://codereview.chromium.org/2333263002
Cr-Commit-Position: refs/heads/master@{#419067}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/537cdb699a70d5d55f3eefb923eae1dc5104a8eb Add goma to wasm waterfall (sbc@chromium.org)
  https://crrev.com/b6d326d6f6f9608bba307109cc4a1c5efc5946bb Run the ninja "up-to-date" check for all compiles, but just as an fyi (agrieve@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=646165

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2343803006
Cr-Commit-Position: refs/heads/master@{#419066}

Running a task on a worker thread after forcible termination may cause a crash
because of an access to an empty handle returned by V8 API.

BUG=646861

Review-Url: https://codereview.chromium.org/2339983003
Cr-Commit-Position: refs/heads/master@{#419065}

BUG=647169,645949
TEST=CompositedLayerMappingTest.BackgroundPaintedIntoGraphicsLayerIfNotCompositedScrolling
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2346883003
Cr-Commit-Position: refs/heads/master@{#419064}

The TabStripModel is no longer needed inside the event
handlers.

Review-Url: https://codereview.chromium.org/2339393003
Cr-Commit-Position: refs/heads/master@{#419063}

This is a step towards removing SidebarTreeElement, and moving
all tree outlines into shadow dom.

BUG=none

Review-Url: https://codereview.chromium.org/2347483002
Cr-Commit-Position: refs/heads/master@{#419062}

TBR=kbr@chromium.org
BUG=598902
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2344983002
Cr-Commit-Position: refs/heads/master@{#419061}

The stack in this crash report indicates that we're inside
UnpackedInstaller::InstallExtension, and we know that function gets
called via a posted task (via OnInstallChecksComplete). The code inside
InstallExtension uses the weak pointer to the ExtensionService without
validating it first, so we strongly suspect a null ExtensionService to
be the root cause of the crash.

BUG=647265

Review-Url: https://codereview.chromium.org/2348633002
Cr-Commit-Position: refs/heads/master@{#419060}

BUG=644669
TEST=deqp/functional/gles3/shaderloop_for/while.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2319023002
Cr-Commit-Position: refs/heads/master@{#419059}

This changes the template stamping parts of cr-lazy-render to look more
like iron-list. This simplifies the code and makes it play nicely with
Closure.

BUG=642200
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2344803002
Cr-Commit-Position: refs/heads/master@{#419058}

Threads seem to be exiting unexpectedly, so to help debugging set a
crash key if an unexpected WM_QUIT message is received.

BUG=647068
TBR=scottmg@chromium.org

Review-Url: https://codereview.chromium.org/2342713002
Cr-Commit-Position: refs/heads/master@{#419057}

This is done using:
./httparchive.py remap-host maps_004.wpr localhost:10020 map-test
(https://codereview.chromium.org/2346853003)

BUG=646924
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2347483004
Cr-Commit-Position: refs/heads/master@{#419056}

BUG=none

Review-Url: https://codereview.chromium.org/2340403002
Cr-Commit-Position: refs/heads/master@{#419055}

Updates TemplateURL to know how to request Now on Tap data for Contextual Search.
Also remove the old unused flag about whether to resolve or not.

BUG=646664,641543

Review-Url: https://codereview.chromium.org/2343523002
Cr-Commit-Position: refs/heads/master@{#419054}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/596285fbd59f..7eb57a183493

$ git log 596285fbd..7eb57a183 --date=short --no-merges --format='%ad %ae %s'
2016-09-15 aiolos Add chart-legend-tooltip element.

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2349433003
Cr-Commit-Position: refs/heads/master@{#419053}

w/o this, WebAudio will always think there are only two channels
available. Untested since I don't have a 5.1 setup on Linux.

BUG=646435
TEST=verified that 2 channels are reported locally.

Review-Url: https://codereview.chromium.org/2345813002
Cr-Commit-Position: refs/heads/master@{#419052}

This CL moves the site URL out of the subpage title and into the body of
the subpage. The new title is Site settings. In the new position, the
url has its favicon. This is similar to a previous revision done by
Finnur@.

BUG=646616
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2342473003
Cr-Commit-Position: refs/heads/master@{#419051}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e9b7e550..ad5be95d

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2340183003
Cr-Commit-Position: refs/heads/master@{#419050}

Replace usage of single-threaded SequencedWorkerPool with a base::Thread in image_fetcher_unittest.mm

Also cleaned up a TODO for 440857 on the way.

BUG=646443, 440857

Review-Url: https://codereview.chromium.org/2333023003
Cr-Commit-Position: refs/heads/master@{#419049}

Skia is changing a few signatures to use smart pointers in its API. This
requires that Chromium be updated to match. This define will keep the
old API around while the Skia change is rolling into Chromium.

Review-Url: https://codereview.chromium.org/2341963004
Cr-Commit-Position: refs/heads/master@{#419048}

List from
https://cgit.freedesktop.org/vaapi/intel-driver/tree/src/i965_pciids.h

BUG=646135
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2337863002
Cr-Commit-Position: refs/heads/master@{#419047}

These weren't caught in the original CL
(https://codereview.chromium.org/2310563002) since that CL
intentionally didn't exercise everything.

I neglected to test the follow-up CL completely before
landing the first one, so I missed these bugs:

  1. WebContentsBindingSet::Binding needs to be exported
  2. The RouteProvider proxy in RPHI needs to reset on Init
  3. RenderFrameImpl never implemented
     IPC::Listener::OnAssociatedInterfaceRequest.

*crawls into shame cube*

Landing these fixes separately from the follow-up CL
(https://codereview.chromium.org/2310583002) to retain its
purpose as a minimal example of WebContents IPC conversion.

BUG=612500

Review-Url: https://codereview.chromium.org/2346903002
Cr-Commit-Position: refs/heads/master@{#419046}

Needs to be done in MediaCodecUtil otherwise the EME types won't
incorrectly reject encrypted vp8 support.

BUG=612909
TEST=none

Review-Url: https://codereview.chromium.org/2348683002
Cr-Commit-Position: refs/heads/master@{#419045}

For better tracking.

BUG=647433,647412,647416,647409,647421,647417
TEST=none

Review-Url: https://codereview.chromium.org/2345613003
Cr-Commit-Position: refs/heads/master@{#419044}

We still have one instance where ChildThreadImpl is used without
ChannelMojo (utility processes launched by a service process),
causing a nullptr dereference in ChannelProxy when trying to add
the associated interface.

This CL replaces a DCHECK with a branch to avoid the crash, since
silently ignoring the call is safe and reasonable.

In examining this bug I also realized that ChildThreadImpl was
incorrectly adding the RouteProvider interface after Channel
connection, which is only safe to do in the browser, where the
remote endpoint hasn't been launched yet. So this CL fixes that
too, and clarifies the documentation in ipc_channel_proxy.h.

BUG=647251
R=jam@chromium.org

Review-Url: https://codereview.chromium.org/2343783003
Cr-Commit-Position: refs/heads/master@{#419043}

We can remove this duplicate checked math implementation and use the one
in base (proxied by way of WTF) instead.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2339323003
Cr-Commit-Position: refs/heads/master@{#419042}

TBR=jbudorick@chromium.org, stip@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2347713002
Cr-Commit-Position: refs/heads/master@{#419041}

Currently, DirectoryBackingStore::VerifyReferenceIntegrity only verifies
that all parent ids are valid. This ignores the case of a single, corrupted
root node, which can happen during first sync. This CL adds a check that the
root node exists with the expected id("r").

R=pavely@chromium.org

BUG=642690

Review-Url: https://codereview.chromium.org/2342133002
Cr-Commit-Position: refs/heads/master@{#419040}

The original CL got reverted due to failing on a Lollipop bot. This
CL avoids Lollipops while investigations continue.

Original CL description ------------------------------------------------

This CL enables VideoCaptureDeviceTest.TakePhoto for
Android. (Note that, due to other circumstances, it'll
only be enabled for devices implementing the Camera2
API in non-legacy mode).

The only modification is that Android creates JPEGs
with APP1 JFIF header, because it includes EXIF information.

BUG=518807, 626857

TBR=emircan@chromium.org since the addec change is trivial.

Review-Url: https://codereview.chromium.org/2344683003
Cr-Commit-Position: refs/heads/master@{#419039}

This is a preliminary refactoring CL which is intended to consolidate related logic into one place, and prepare for the real change that I want to make: That is, apply git changes only once in _rebaseline after all changes are made, to fix http://crbug.com/639410.

I want to make two follow-up changes after this:
 (1) Change _rebaseline to apply git changes only once after all commands are run.
 (2) Refactor and simplify ChangeSet, _serial_commands, and _run_in_parallel.

BUG=639410

Review-Url: https://codereview.chromium.org/2347643002
Cr-Commit-Position: refs/heads/master@{#419038}

This is part of getting shutdown of displays working correctly.

BUG=none
TEST=covered by tests
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2347493003
Cr-Commit-Position: refs/heads/master@{#419037}

BUG=594244

Review-Url: https://codereview.chromium.org/2345013002
Cr-Commit-Position: refs/heads/master@{#419036}

Under very specific circumstances, LayoutBlockFlow::layoutBlock will
loop infinitely in this stanza:

    while (!done)
        done = layoutBlockFlow(...);

... due to fluctuations in the existence of overflow:auto scrollbars
in descendants.  Any layout type that does multi-pass layout is
especially susceptible to this, hence this bug affecting flexbox,
and another recent bug affecting tables: crbug.com/64635.

This fix supercedes the existing fix for the table bug, and it
should fix any other variations of this bug involving multi-pass
layout and overflow:auto.

BUG=644450
R=cbiesinger@chromium.org,eae@chromium.org

Review-Url: https://codereview.chromium.org/2345103002
Cr-Commit-Position: refs/heads/master@{#419035}

BUG=642059

Review-Url: https://codereview.chromium.org/2340743003
Cr-Commit-Position: refs/heads/master@{#419034}

Revert of Roll ANGLE 09cfac6..415f29e (patchset #1 id:1 of https://codereview.chromium.org/2347683002/ )

Reason for revert:
broke sizes with static initializer:
https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/25612/steps/sizes/logs/stdio
# Static initializers in /b/c/b/linux_clobber/src/out/Release/chrome:
# HINT: To get this list, run tools/linux/dump-static-initializers.py
# HINT: diff against the log from the last run to see what changed
# Compiler.cpp std::ios_base::Init::Init()@plt
# Compiler.cpp std::__ioinit [#includes <iostream>, use <ostream> instead]
# Compiler.cpp __cxa_atexit@plt [registers a dtor to run at exit]
# Compiler.cpp __dso_handle
# Compiler.cpp __init_array_end+0x2520

Original issue's description:
> Roll ANGLE 09cfac6..415f29e
>
> https://chromium.googlesource.com/angle/angle.git/+log/09cfac6..415f29e
>
> BUG=
>
> TBR=geofflang@chromium.org
>
> TEST=bots
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
>
> Committed: https://crrev.com/ac2a4e916123d43293eb9d47e31b469045ca068e
> Cr-Commit-Position: refs/heads/master@{#418995}

TBR=geofflang@chromium.org,cwallez@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2341613005
Cr-Commit-Position: refs/heads/master@{#419033}