GitLab

Bug: None
Change-Id: Id361efb087daf048b5a360e73b57a59a97c1691c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525901Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Chunbo Hua <chunbo.hua@intel.com>
Cr-Commit-Position: refs/heads/master@{#825616}

Since JavaScript may detach the underlying buffers, we need to check
to ensure they're still valid before using them for decoding.

Test: Updated unittests. Manual test case breaks.
Change-Id: Iefe5f8adf619cd6afdfedcb08a13c2996bfe0d32
Fixed: 1146761
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527542
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825615}

Bug: 1146245
Change-Id: Icabb754484ffd570fa754021cea672d0e4553fb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522671
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825614}

A resizer on an element containing composited stacked descendants
needs to be painted after the descendants. In pre-CompositeAfterPaint
this can only be achieved by using composited scrolling for the element
so that we'll composite the resizer even if the element is not
scrollable.

In CompositeAfterPaint everything is good because we always use the
correct paint order.

Bug: 1135676
Change-Id: Ic69b830ae3d71cd9f6b8f55deca591b485b189a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523748
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825613}

Bug: 925072
Change-Id: Ib86cd7d6f99a8489e81f679f9f10265d02574a1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525962Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Ce Chen <cch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825612}

First batch of type aliases for cppgc which are just forwarding
existing Blink types to their cppgc counterparts.

Bug: chromium:1056170
Change-Id: I186ffd39e69feef2f96f1979c94c040f307e7926
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527143
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Auto-Submit: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Omer Katz <omerkatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825611}

TBR: dullweber@chromium.org
Bug: 1147236
Change-Id: I683395e551bb31c9f0e3448fe5c75e06583390d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527529Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825610}

As part of the generalization of the Trust Token redemption record,
the protocol no longer specifies these as needing to be 'signed', so
the API types are updated to match, from send-srr to
send-redemption-record and srr-token-redemption to token-redemption.

Design: https://docs.google.com/document/d/1-4n1RLaJs8ANw34TsS6BVt7ARa7lK70F6aHFG2CL3Rc/edit#heading=h.6a92f2gfl9le
Bug: 1133310
Change-Id: Id6d668d10f59f3f0eac6a8f423e7c9a59134f2de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437697
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: David Bertoni <dbertoni@chromium.org>
Reviewed-by: David Van Cleve <davidvc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825609}

Doing multiple passes here is inefficient. It's more efficient to simply
iterate through the characters and check that the lowercase version of
each character in the query value equals the corresponding character in
the bucket value.

An early out for equal bytes is preserved, but must now check that those
bytes are in fact not upper ASCII.

Comments are added and variable names expanded for clarity, because it
was previously difficult to discern what |str| and |buf| were.

Bug: 1138487
Change-Id: I8219ce1594e39606b59513d5823dc107bb10656e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481442
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825608}

This reverts commit 7cca28c8.

Reason for revert:

Updating test at https://crrev.com/c/2518956

Original change's description:
> Revert "[InputMethodNames] Update English-related strings"
>
> This reverts commit d90a3ba0.
>
> Reason for revert: This breaks inputs.VirtualKeyboardChangeInput.stable
>  because it refers to "US keyboard" by name.
> https://ci.chromium.org/p/chrome/builders/ci/chromeos-betty-pi-arc-cfi-thin-lto-chrome/12881
>
> Original change's description:
> > [InputMethodNames] Update English-related strings
> >
> > Proposal: http://go/cros-input-methods-naming
> > Proposed names: http://go/cros-input-methods column C
> > Screenshot view: http://screen/9RB3jeFjhWq4kvS
> >
> > Bug: 889763
> > Change-Id: I5393f7e64ecc5251ab31127f9337ebe2b579a417
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517402
> > Commit-Queue: My Nguyen <myy@chromium.org>
> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#823898}
>
> TBR=xiyuan@chromium.org,myy@chromium.org
>
> Change-Id: Ia59ebb17355dca65e4221e4ecfbcc24b4a372c89
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 889763
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517565
> Reviewed-by: Christian Dullweber <dullweber@chromium.org>
> Commit-Queue: Christian Dullweber <dullweber@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#823943}

TBR=xiyuan@chromium.org,dullweber@chromium.org,myy@chromium.org

# Not skipping CQ checks because this is a reland.

Bug: 889763
Change-Id: I46173a9358766b79cc43d57fa376916f06efe74a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519337Reviewed-by: Shuo-Peng Liao <deanliao@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: My Nguyen <myy@chromium.org>
Commit-Queue: My Nguyen <myy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825607}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/c19c1b2c..b5e18417

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I22cae4a93fc47ff25992efd3de5d11856d3fc172
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527706Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#825606}

Proposal: http://go/cros-input-methods-naming
Proposed names: http://go/cros-input-methods column C
Screenshot view: http://screen/5FSSGTbv247BXfG

Bug: 889763
Change-Id: I630e97538b18236fa2d0f75e3e186810aa3d093d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521877Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: My Nguyen <myy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825605}

Add a new state property to scanning-app and use the state to
enable/disable and show/hide the various UI elements.

Bug: 1059779
Change-Id: Id9f3c46bd30dc3ac8ccde905c023da81bac49d77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523469
Commit-Queue: Jesse Schettler <jschettler@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825604}

It had been used by PPAPI Flash, but now isn't being used by anything.

Bug: None
Change-Id: I97fefe47a124baf12b233cb87b29a7a59734fc25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525770Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825603}

As blink::mojom::ResourceType is deprecated[1], this CL uses
network::mojom::RequestDestination in
DedicatedWorkerHost, SharedWorkerServiceImpl,
WorkerScriptFetchInitiator, and
WorkerScriptLoaderFactory.

[1] https://crbug.com/960143

Bug: 1059639
Change-Id: Idfc79101e4c9fde230aa4f06ce24964f3a84c0c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524819Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Julie Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#825602}

Logs installation, removals and current usage of widgets.

Updates widget names for consistency.

Currently we don't have support for swift tests. So this was tested
manually. ObjC Testing tools and unit tests will follow up in a follow
up CL.

Bug: 1138721
Change-Id: I45751faa98ab19ef57ecc631c2d1674f72295579
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500267
Commit-Queue: Javier Flores <javierrobles@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Javier Flores <javierrobles@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825601}

Previously this caused problems with hanging, but I was not able
to reproduce that. Turning this on only for the general CI builder
to see if we can reproduce it.

The choice of 3 processes was based on a study from 1 to 5 processes,
choosing the least number of processes (for stability) that had a
sizeable performance impact:

https://docs.google.com/spreadsheets/d/1hMIoOB1oaC9iyWK5GEy5xIwUJLoDRaI77ReJ1lKjpZk/edit#gid=0

Bug: 1023835
Change-Id: If6aab5edea3fda38ffa98efd97ae018eac7fe242
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463966Reviewed-by: Erik Staab <estaab@chromium.org>
Reviewed-by: Luke Z <lpz@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825600}

This CL fixes the issue that clipboard data cannot be pasted by tapping
at the multipaste menu.

Bug: 1142088
Change-Id: Id90aba9270520fd0394427f1d6f3c82fe7d08655
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525222Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: David Black <dmblack@google.com>
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825599}

This CL removes blink::mojom::ResourceType from
InspectHistograms() which is a helper method for
CrossSiteDocumentBlockingTest as it's unused and
blink::mojom::ResourceType is deprecated[1].

[1] https://crbug.com/960143

Bug: 1059639
Change-Id: I8679d716a3de44c2a8fe78a5ef5b330c073a488c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525383Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Julie Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#825598}

Proposal: http://go/cros-input-methods-naming
Proposed names: http://go/cros-input-methods column C
Screenshot view: http://screen/8jzvjjrzhQLK8JH

Bug: 889763
Change-Id: I38bf77914dff548997b2a7876383dec7c85db4c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522795Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: My Nguyen <myy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825597}

Adds error divs and styling to the send confirmation page, error
strings, and displays them when the corresponding transfer statuses
are received for the following error types:
- Rejected share
- Timeout while waiting for accept
- Unsupported file type

Bug: 1123934
Change-Id: I7d07ab29814bb21ba06a10e20e072d2ee877d559
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522004
Commit-Queue: Curt Clemens <cclem@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#825596}

A recent change, still being tracked down, has made this test flaky on
macOS and ChromeOS.

Bug: 1146687
Change-Id: If22497aeefa8fa582124dce83c1e8fcf53bde479
No-Try: True
Tbr: jdarpinian@chromium.org
Tbr: schenney@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528295
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: James Darpinian <jdarpinian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825595}

ScopedObserver is being deprecated in favor of two new classes:
- base::ScopedObservation for observers that only ever observe
  a single source.
- base::ScopedMultiSourceObservation for observers that do or may
  observe more than a single source.
This CL was uploaded by git cl split.

R=sky@chromium.org

Change-Id: I1fad30d867891377a5575027c45eb18d466c5d8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526923
Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825594}

This reverts commit 202e93e8
and the ones that come after it.



Reason for revert:
immediately after this landed (not the build this landed), the one after it, the Windows deterministic builder started failing consistently during the compare_build_artifacts step.

https://ci.chromium.org/p/chromium/builders/ci/Windows%20deterministic

Step with first failure:
https://ci.chromium.org/p/chromium/builders/ci/Windows%20deterministic/17458

Failure:

swiftshader\libEGL.dll                                                                                                                                           : None
swiftshader\libEGL.dll.pdb                                                                                                                                       : None
swiftshader\libGLESv2.dll                                                                                                                                        : DIFFERENT (unexpected): 19159 out of 2435584 bytes are different (0.79%)
...
swiftshader\libGLESv2.dll.pdb                                                                                                                                    : DIFFERENT (unexpected): 1227 out of 17125376 bytes are different (0.01%)

and in the summary section:
Equals:           4495
Expected diffs:   2
Unexpected diffs: 2
Unexpected files with diffs:

  swiftshader\libGLESv2.dll
  swiftshader\libGLESv2.dll.pdb


Original change's description:
> Roll Skia from ee0ce9858cbc to cffe7e631c4e (3 revisions)
>
> https://skia.googlesource.com/skia.git/+log/ee0ce9858cbc..cffe7e631c4e
>
> 2020-11-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from a4f272b3 to 083976a7 (536 revisions)
> 2020-11-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 612ded0654a0 to 4ed9d3498dcf (2 revisions)
> 2020-11-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 3dfaeeb00271 to d4439824c554 (28 revisions)
>
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://autoroll.skia.org/r/skia-autoroll
> Please CC jlavrova@google.com on the revert to ensure that a human
> is aware of the problem.
>
> To report a problem with the AutoRoller itself, please file a bug:
> https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
>
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Cq-Do-Not-Cancel-Tryjobs: true
> Bug: None
> Tbr: jlavrova@google.com
> Test: Test: Test: Capture Clash of ClansTest: Test: angle_end2end_tests.exeTest: Test: angle_perftests --gtest_filter="*clash_of_clans*"
> Change-Id: I9fa84e51de5c3fd8f7464fef222631d3de74dc48
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524758
> Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#825267}

TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,jlavrova@google.com

Change-Id: Idb300b9c17c2405a679c46b5555836a460b3357f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527777Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825593}

Previously FuchsiaVideoDecoder was setting
min_buffer_count_for_camping to reserve output buffers. Updated it to
use min_buffer_count_for_shared_slack instead.  Also removed dependency
on StreamBufferConstraints.packet_count_for_client_max, since it's being
deprecated.

Bug: fuchsia:61424, fuchsia:55146
Change-Id: Ice65f44e4f53117a50ceb3c0bb0f82e9326c9957
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518720
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825592}

The 'FullRestore' flag is added in ash considering the window manamement
might use it as well, and if it is added in the chrome/browser directory
then the window manamement in ash can't include the file in the
chrome/browser directory.

BUG=1146900

Change-Id: Ib61186739832048e52ce4c87dd9e40b996cddc8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525461
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825591}

For some trunk builders, they set env var CHROMIUM_TEST_LAUNCHER_BOT_MODE.
For unit test, we need to unset the var to test some scenario.
https://source.chromium.org/chromium/chromium/src/+/master:ui/base/test/skia_gold_pixel_diff.cc;l=153;drc=07e4c76dd0f6b37146a1c35e4a96fae53aff7371

Bug: 1146399
Change-Id: Ifb71831060a4bd779ef48e83ca8d66741e5e57e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523555Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825590}

Proposal: http://go/cros-input-methods-naming
Proposed names: http://go/cros-input-methods column C
Screenshot view: http://screen/8jZbxyJfqwvFAuq

Bug: 889763
Change-Id: Ifeaf20f918c80ba7dbed68c25d4982b9b1a47410
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521879Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: My Nguyen <myy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825589}

Change-Id: I1bedf8383e3cd46d5e37d8a5778e47a060521f82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518526
Commit-Queue: John Palmer <jopalmer@chromium.org>
Reviewed-by: Keith Lee <keithlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825588}

While implementing file drag and drop, I have discovered that
net::FilePathToFileURL does not correctly handle paths which end with a
space char.

GURL does some modifications to the path in its constructor so we must
percent-encode control chars before calling it to avoid corruption.

Bug: 1144138
Change-Id: Ie8e601edbc42033e33389ff4bd48046d16571ab8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522735
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825587}

When a scanner only supports one source, the selected source is not
being set. Fix the function that sets the selected source to account for
this case.

Bug: 1059779
Change-Id: I1ee927506bf4c2b0f6be412db39c7f6cdca670d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527774Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Jesse Schettler <jschettler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825586}

The default GTK error handler exits the process, which we don't want.
We used to reset the error handler at some point after GTK
initialization, but this became lost after r815319.

Also refactor the XlibLoader instance to be global so it doesn't have
to be created multiple times for each connection.

R=sky

Bug: 1145929
Change-Id: I73a3f27551534c2262bd8994d33e30fc2a0a4e27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527743
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825585}

https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/26e2a89598d6..32b14552d662

2020-11-09 wl@gnu.org * src/type42/t42parse.c (t42_parse_sfnts): More tracing messages.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/freetype-chromium
Please CC thestig@google.com,bungeman@google.com,drott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel
Tbr: thestig@google.com,bungeman@google.com,drott@google.com
Change-Id: Ia093dde5916f38386b323910bb6f1288e79aa324
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527801Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: Ben Wagner <bungeman@chromium.org>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825584}

This CL disabled the Python 3 version of the GRIT presubmit as it causes
bots to hang when running test_suite_all.py.

Bug: 1145395

Change-Id: I90426733f40496a97a029d79e83cb0a91945bb37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518306
Auto-Submit: calamity <calamity@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#825583}

It was dropped in https://crrev.com/c/2464518 which may result in all
errors being reported as base::File::FILE_ERROR_NOT_FOUND.

Bug: 1049966
Change-Id: I78e1ac5bf664c49ecebf130d23737f8dad3721a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505341
Commit-Queue: Alexander Bolodurin <alexbn@google.com>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825582}

Before the CL, PaymentRequestUi takes waitForUpdatedDetails from
CPRService by PaymentUiService.Delegate.waitForUpdatedDetails(). Using
a delegate is not as simplified as a method parameter.

After the CL, PaymentRequestUi takes the value by method parameters.

Change-Id: Icb61a32c6df6d6f2b01d6f6669483cd4b2111b30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527543
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825581}

It's replaced by base::ScopedObservation for observing a single source,
or base::ScopedMultiSourceObservation for observing multiple sources.

Bug: 1145565
Change-Id: Iadc2e3efee7860e1b17b86b077d4c6a2566b6a95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527541
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825580}

This CL cleans up checkout_presubmit_ash_chrome DEPS hook because all
CI/CQ builders have been switched to build ash-chrome from ToT.

Bug: 1129223
Change-Id: I9de1f832ae29d3fe7eea85d67cd822b8c999c767
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518080
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Sven Zheng <svenzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825579}

This flag gates whether or not we specify kCGLPFAAllowOfflineRenderers,
and whether or not we call CGLSetVirtualScreen to manually migrate our
compositing/raster contexts on GPU switch.

ARM DTKs only have the single integrated AGX GPU, and do not recognize
external GPUs, so this is necessarily untested. Indications are that
it would be a good idea to add this to our initial ARM shipping build.
Note that this would enable the flag even on single-GPU systems,
because we haven't been able to test multi-GPU detection code on
multi-GPU ARM machines (and so this could end up being unused if that
code failed to detect the multi-GPU configuration).

Bug: 1131312
Change-Id: I38404a8fc380d9f7542f0aaf93f969893815fac2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522431Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825578}

This CL corrects the message card close button color in incognito mode
under dark theme.

Bug: 1145869
Change-Id: I4803b7d9c078b7c16f4e6b39aca7be99228e0f09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527342Reviewed-by: Yue Zhang <yuezhanggg@chromium.org>
Commit-Queue: Zhiyuan Cai <zhiyuancai@google.com>
Cr-Commit-Position: refs/heads/master@{#825577}