- 26 Mar, 2015 40 commits
-
-
rch authored
Review URL: https://codereview.chromium.org/1035533006 Cr-Commit-Position: refs/heads/master@{#322323}
-
calamity authored
This CL stops AppListServiceAsh handling an event it shouldn't care about, preventing the AppListServiceViews on Linux handling it correctly. BUG=469032 Review URL: https://codereview.chromium.org/1020133002 Cr-Commit-Position: refs/heads/master@{#322322}
-
anandc authored
app-streaming builds, cleanup definition of those variables. Move variables to common include file. Tested by building in a shell with only GYP_DEFINES': 'component=shared_library use_goma=1 BUG= Review URL: https://codereview.chromium.org/1031203004 Cr-Commit-Position: refs/heads/master@{#322321}
-
ananta authored
This causes wrong fallback fonts to be picked leading to text displaying badly. To avoid duplicate fonts from being processed, the proposal is to use a set to track those and skip them. BUG=470397 Review URL: https://codereview.chromium.org/1037863002 Cr-Commit-Position: refs/heads/master@{#322320}
-
shuchen authored
The physical keyboard autocorrect feature (crbug.com/422869) is targeted to be launched in M43. The feature should be turned off if the input field is marked as autocorrect==off, which is only supported by web input field for now. This cl is to make certain native fields (views::TextField) to be marked as autocorrect==off so that physical keyboard autocorrect feature can stop working on it. Note: this cl will also impact virtual keyboard. The suggestions on virtual keyboard will also stop working on those input fields. BUG=455865 TEST=Verified on linux_chromeos. Review URL: https://codereview.chromium.org/1029543002 Cr-Commit-Position: refs/heads/master@{#322319}
-
kouhei authored
Before this CL, no GC was run in between test, so setting --pageset-repeat > 1 lead to increased memory usage per test run, reporting inaccurate results. This CL forces V8 GC (and attached Oilpan GC) after each test run for stable result. More background: Blink used to trigger V8 major GC after page unload, but this was changed to less aggressive GC since r181187, suspected as source of this "leak". BUG=465997 Review URL: https://codereview.chromium.org/1027133002 Cr-Commit-Position: refs/heads/master@{#322318}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/9c59ebc..05035d4 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=hcm@google.com Review URL: https://codereview.chromium.org/1031213003 Cr-Commit-Position: refs/heads/master@{#322317}
-
mukai authored
In some languages, the current logic (iteration over code points and then get the glyphs by CharRangeToGlyphRange) makes wrong effect, because both a character and its diacritic marks can point to the same glyph range and it misunderstands the width of the word for wrapping. This CL changes the iteration logic for clusters so that it skips the code points for the diacritic marks. BUG=470073 R=msw@chromium.org, ckocagil@chromium.org TEST=the new test case covers Review URL: https://codereview.chromium.org/1036663003 Cr-Commit-Position: refs/heads/master@{#322316}
-
thestig authored
These fields are often grouped together, but in different orders. In several cases, fields have labels that are ambiguous but names that are not. When there is ambiguity, parse fields with the name and label separately and see which field type they best match. BUG=442552 Review URL: https://codereview.chromium.org/1028633004 Cr-Commit-Position: refs/heads/master@{#322315}
-
mdempsky authored
BUG=466847 Review URL: https://codereview.chromium.org/1015063003 Cr-Commit-Position: refs/heads/master@{#322314}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/34f0727..554befb TBR=jchaffraix@chromium.org,loislo@chromium.org Review URL: https://codereview.chromium.org/1025323006 Cr-Commit-Position: refs/heads/master@{#322313}
-
thestig authored
- Modify unit tests to test relevant field types. - Cleanup code. - Update heuristics test expectations. Review URL: https://codereview.chromium.org/1010743007 Cr-Commit-Position: refs/heads/master@{#322312}
-
joedow authored
Updated the formatting for the app remoting test driver files using clag-format for consistency. No logic changes. BUG= Review URL: https://codereview.chromium.org/1037723003 Cr-Commit-Position: refs/heads/master@{#322311}
-
sandersd authored
BUG=470754 Review URL: https://codereview.chromium.org/1036513007 Cr-Commit-Position: refs/heads/master@{#322310}
-
eroman authored
ICANN designated the IPv4 address 127.0.53.53 as meaning a name collision occurred during resolution (as a way to discover real world conflicts around the new gTLDs). This change makes such resolutions now fail with: ICANN_NAME_COLLISION. IP literals are exempt from the policy and will continue to work as before (meaning you can still navigate to http://127.0.53.53). This only affects IPv4 results. BUG=470704 Review URL: https://codereview.chromium.org/1035803003 Cr-Commit-Position: refs/heads/master@{#322309}
-
anandc authored
BUG= Review URL: https://codereview.chromium.org/1030013004 Cr-Commit-Position: refs/heads/master@{#322308}
-
jrw authored
The Xhr class can now use the remoting.Identity API to request OAuth tokens, and it can convert HTTP errors into rejected promises. Also replaced the responseType parameter with the simpler acceptJson parameter. Review URL: https://codereview.chromium.org/1028683004 Cr-Commit-Position: refs/heads/master@{#322307}
-
jdduke authored
Trace the following events: * CompositorImplAndroid::SetVisility * RenderWidgetHost::WasHidden * RenderWidgetHost::WasShown * RenderProcessHostImpl::SetBackgrounded These events give greater context to content behavior with respect to visibility changes. BUG=466213 Review URL: https://codereview.chromium.org/1032703002 Cr-Commit-Position: refs/heads/master@{#322306}
-
sammc authored
Currently, ConstrainedWindowMac uses the embedder WebContents of the GuestView if the WebContents is in a GuestView. However, with OOP PDF, a mime handler view can be embedded in a webview that is embedded in an app window; in this case, the webview WebContents is used instead of the app window WebContents. This CL changes ConstrainedWindowMac to use the outermost embedder WebContents. This is the same fix as http://crrev.com/321248, but for mac. BUG=457672 Review URL: https://codereview.chromium.org/1029583007 Cr-Commit-Position: refs/heads/master@{#322305}
-
dyen authored
BUG=467202 TEST=Shut down during gpu.device trace has no warnings. Review URL: https://codereview.chromium.org/1018773002 Cr-Commit-Position: refs/heads/master@{#322304}
-
reveman authored
Some of our tests apparently rely on these threads having specific names. BUG=470091 Review URL: https://codereview.chromium.org/1036923002 Cr-Commit-Position: refs/heads/master@{#322303}
-
jfb authored
BUG= https://code.google.com/p/chromium/issues/detail?id=460432 TBR= jvoung@chromium.org Review URL: https://codereview.chromium.org/1012673011 Cr-Commit-Position: refs/heads/master@{#322302}
-
halliwell authored
Seems like it's incorrect to defer this creation the way we do currently. BUG=468362 Review URL: https://codereview.chromium.org/1021483005 Cr-Commit-Position: refs/heads/master@{#322301}
-
chrome-tpm authored
Cr-Commit-Position: refs/heads/master@{#322300}
-
imcheng authored
Background: mojo rolled out a new version that requires callbacks (as defined by the => syntax in mojom) must be invoked before they go out of scope, otherwise it indicates a connection error on the callback's recipient, which will destroy mojom implementations that are strongly bound to the connection. Note that a partial fix was added in crrev.com/1019173002. This patch addresses the remaining points. BUG=468575 Review URL: https://codereview.chromium.org/996173006 Cr-Commit-Position: refs/heads/master@{#322299}
-
sadrul authored
This moves code out of //java/apps/chrome/.../precache into: . //components/precache/android/: classes that provide information about device-state, network connectivity etc. . //chrome/android/.../precache/: precache service and service launchers. BUG=401552 Review URL: https://codereview.chromium.org/1031003003 Cr-Commit-Position: refs/heads/master@{#322298}
-
estade authored
BUG=none Review URL: https://codereview.chromium.org/1002283004 Cr-Commit-Position: refs/heads/master@{#322297}
-
tsergeant authored
This prevents whitespace and non-ASCII characters from being displayed in the url, stopping attacks where a carefully crafted URL can be used to display a message in the popup. BUG=466351 Review URL: https://codereview.chromium.org/1011383005 Cr-Commit-Position: refs/heads/master@{#322296}
-
meacer authored
Screenshots: Old plugin blocking UI: https://drive.google.com/file/d/0B9q2eN9gDoUIX1NFVjAtY0w2V2c/view?usp=sharing New plugin blocking UI: https://drive.google.com/file/d/0B9q2eN9gDoUITk5jVDVuZDIwUmc/view?usp=sharing New plugin blocking UI (Mac): https://drive.google.com/file/d/0B9q2eN9gDoUIc3RhLVdzVExOQTQ/view?usp=sharing Old popup blocking UI: https://drive.google.com/file/d/0B9q2eN9gDoUIZzdTZHg4czJCMFU/view?usp=sharing New popup blocking UI (unchanged): https://drive.google.com/file/d/0B9q2eN9gDoUIVFFNNXRDU1dDWTQ/view?usp=sharing BUG=414399 Review URL: https://codereview.chromium.org/1025503002 Cr-Commit-Position: refs/heads/master@{#322295}
-
michaelpg authored
Review URL: https://codereview.chromium.org/1027383003 Cr-Commit-Position: refs/heads/master@{#322294}
-
pkotwicz authored
touch noise filtering is at https://chromium.googlesource.com/chromiumos/platform/touch_noise_filter/+/master When a touch is detected as touch noise, an ET_TOUCH_CANCELLED event is sent and all of the subsequent events for that touch are dropped. A "touch press" initiates a new touch. BUG=407840 TEST=TouchNoiseFinderTest.*, TouchEventConverterEvdevTouchNoiseTest.* Review URL: https://codereview.chromium.org/991533002 Cr-Commit-Position: refs/heads/master@{#322293}
-
dalecurtis authored
On OSX the main audio thread is the UI thread due to limitations in the CoreAudio API. Since we're making effectively read only calls sending the audio hardware config from the worker task runner should be fine. We already do this in several other places for device enumeration (since it's way to slow on UI thread). BUG=469737 TEST=none Review URL: https://codereview.chromium.org/1029933003 Cr-Commit-Position: refs/heads/master@{#322292}
-
lgarron authored
This string will have an accompanying code change that we hope to have ready in time to merge into Chrome 42 for Android. The string needs to land early so we can kick off the translation process. BUG=469853 Review URL: https://codereview.chromium.org/1034863003 Cr-Commit-Position: refs/heads/master@{#322291}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/862b1f1..34f0727 TBR=jchaffraix@chromium.org,loislo@chromium.org Review URL: https://codereview.chromium.org/1031273003 Cr-Commit-Position: refs/heads/master@{#322290}
-
servolk authored
Should make clearer the remaining dependencies of net/ on mime_util.h BUG=none Review URL: https://codereview.chromium.org/1028233004 Cr-Commit-Position: refs/heads/master@{#322289}
-
byungchul authored
Some netifs could be ignored by command line flag, --netifs-to-ignore, and internet could be accessible via those netifs. Many testing scripts and developers set this for ethernet link and use ethernet to get testing results. BUG=internal b/19593970 Review URL: https://codereview.chromium.org/1037693005 Cr-Commit-Position: refs/heads/master@{#322288}
-
rtenneti authored
+ Formatting changes found while merging. + Added private: to MockAckNotifierDelegate class. Merge internal change: 89527377 R=rch@chromium.org Review URL: https://codereview.chromium.org/1034823002 Cr-Commit-Position: refs/heads/master@{#322287}
-
jrummell authored
Mask values are seperated out into consts of type SupportedInitDataTypes. Also removes unused function IsSaneInitDataTypeWithContainer(). BUG=417440 TEST=EME layout tests pass Review URL: https://codereview.chromium.org/1027363002 Cr-Commit-Position: refs/heads/master@{#322286}
-
rdevlin.cronin authored
Instead of just having Function or Function= for each callback, use the function() Closure Compiler type documentation. Additionally, add support for @deprecated function documentation. BUG=461039 Review URL: https://codereview.chromium.org/1036593004 Cr-Commit-Position: refs/heads/master@{#322285}
-
estade authored
BUG=468583 Review URL: https://codereview.chromium.org/1029233002 Cr-Commit-Position: refs/heads/master@{#322284}
-