- 07 Mar, 2018 40 commits
-
-
Filip Gorski authored
This patch rolls the Feed library forward to revision: 4dedff6189bbd8f3dc594ba3e2159ccdf929359a This patch also fixes the BUILD.gn: * adds missing files. * reduces the number of targets, to simplify management. Because none of the code is presently used, it has no impact on DEX sizes. There is a minor impact on resources size (1kB). Change-Id: Idcd00ea084c137f2b9d9f4bf46ea1051930b1b0c Reviewed-on: https://chromium-review.googlesource.com/952185Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#541548}
-
Pavel Feldman authored
Bug: 813540 Change-Id: I9338aa2475c15090b8a60729be25502eb866efb7 Reviewed-on: https://chromium-review.googlesource.com/952522Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#541547}
-
Boris Sazonov authored
This CL adds explicit assertNotNull to check results of Instrumentation.waitForMonitorWithTimeout calls. It also removes removeMonitor calls, as waitForMonitorWithTimeout removes the monitor from the monitor list once it has been hit. Bug: 758751 Change-Id: I217b6e78a2c91b9e2c2db1810c1a128195347e51 Reviewed-on: https://chromium-review.googlesource.com/952970Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#541546}
-
Corentin Wallez authored
BUG=chromium:811827 BUG=chromium:811806 BUG=chromium:811790 BUG=chromium:811825 BUG=chromium:811872 BUG=chromium:811829 BUG=chromium:811819 BUG=chromium:811810 BUG=chromium:811808 BUG=chromium:811832 BUG=chromium:811797 Change-Id: I96d2032cc7bb5f9e0ade06485fbf28941a2e47f5 Reviewed-on: https://chromium-review.googlesource.com/953085Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#541545}
-
Jose Dapena Paz authored
GCC does not support int32x4_t loading using braces wrapping 4 ints. Instead we should use the NEON intrinsic to load from an array of ints. Bug: 819294 Change-Id: I13b877405273e4ebcc944d50c155ee29ff31cc99 Reviewed-on: https://chromium-review.googlesource.com/951773 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by:
Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#541544}
-
Randy Smith authored
Bug: None Change-Id: Ibe78762cf8a01d326a3540e325fedfd16730c355 Reviewed-on: https://chromium-review.googlesource.com/951282Reviewed-by:
Julia Tuttle <juliatuttle@chromium.org> Commit-Queue: Randy Smith <rdsmith@chromium.org> Cr-Commit-Position: refs/heads/master@{#541543}
-
Mikel Astiz authored
The patch refactors the code without behavioral changes: ~800 LoC are removed and various friend classes accessing private or protected APIs. The resulting code is simpler and less error-prone. In the new implementation, ModelTypeStore::WriteBatch is made an interface, in consistency with ModelTypeStore itself. The actual production implementation talks to leveldb directly, which avoids the need for a protected, type-unsafe API in ModelTypeStore (and impls). Because protos are now delivered as-is to the actual implementation of MetadataChangeList, and serialized to string in a very late stage, some tests become unnecessary and are removed. Bug: 681921 Change-Id: Ib9f8a6ede63d7f32116c14e75c1d25d49e1eb7bd Reviewed-on: https://chromium-review.googlesource.com/951304Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#541542}
-
Adrienne Walker authored
This fixes a fuzzer null dereference. Bug: 819562 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ia2e7138b6fd143ecd187679843f695c81e65bb63 Reviewed-on: https://chromium-review.googlesource.com/953143Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#541541}
-
Sebastien Marchand authored
Move the WebContentsObserver from TabLifeCycleUnit to TabLifeCycleUnitSource, this allows for a better tracking of the WebContents lifetime, in some situation a WebContents might get detached from the TabStrip and then destroyed, which mean that we won't get a TabClosingAt notification for this tab destruction. Another solution would be to implement the TabStripModelObserver::TabDetachedAt function and track the tabs which are in a detached state but this is slightly more complex because TabDetachedAt might be called for several reasons: - A TabDetachedAt usually come after a TabClosedAt event. - TabDetachedAt might be followed by TabInsertedAt, or not if it get destroyed. because of this we won't know if we should keep the TabLifeCycleUnit for this WebContents around (i.e. if it'll get re-inserted in a tab strip) or destroy it because it's being destroyed. Observing WebContentsObserver::WebContentsDestroyed and moving the logic that was in TabClosingAt to this method address these issues, it's the same approach than the one we took in TabStatsTracker. Bug: 819352, 818454 Change-Id: Ibd3fe49b2798ade19ee781cb70eb30e52372d686 Reviewed-on: https://chromium-review.googlesource.com/952405 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#541540}
-
Xiaoqian Dai authored
Bug: 814631 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8456707c5d72052e1dbda6a364d6b2c1d2a7ec8b Reviewed-on: https://chromium-review.googlesource.com/952084 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#541539}
-
https://pdfium.googlesource.com/pdfium.git/+log/3f4befb26224..749b609d11e8 $ git log 3f4befb26..749b609d1 --date=short --no-merges --format='%ad %ae %s' 2018-03-07 dsinclair [formcalc] Handle bad elseif conditionals Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I77bb9ed4fa41899555f45d1b5e39f9607c1f998e Reviewed-on: https://chromium-review.googlesource.com/953145 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#541538}
-
Aaron Leventhal authored
This is split out from the CL to test all widgets and views for nameless focusable objects. See crrev.com/c/951933. Bug: 819350 Change-Id: I87e8b7ec9ec968ea5f3b2648b1242ddf60be4514 Reviewed-on: https://chromium-review.googlesource.com/952709Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#541537}
-
bsheedy authored
Applies the workaround that allows locally triggered swarming tasks to work properly to the VR auto bisect script. Change-Id: I3d729c1257dba6e228a7b78eabdd9a4ddeb38f7d Reviewed-on: https://chromium-review.googlesource.com/952536 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#541536}
-
Pavel Feldman authored
Bug: 818508 Change-Id: Ifec83109163e18c1e358ada8a1be477b98f3e931 Reviewed-on: https://chromium-review.googlesource.com/952266Reviewed-by:
-
Sidney San Martín authored
Bug: 815361 Change-Id: If996ee8d38af8a07fb615eb422a816dfd9bd9963 Reviewed-on: https://chromium-review.googlesource.com/941909Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#541534}
-
Eugene But authored
crbug.com/819416 was happening, because WebStateObserver::WasShown was called before the animation was completed. This CL moves actual tab switch operation to animation completion block to fix WasShown timing. However it is necessary to send WebStateObserver::WasHidden before animation is started, so this cl adds WebState::WasHidden call if the tab was actually changed. Bug: 819416 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic45ad02e76674a4bd861fe2626f7d3c32aea3a11 Reviewed-on: https://chromium-review.googlesource.com/953075Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#541533}
-
Chandan Padhi authored
This CL typemaps blink::mojom::FacingMode to media::VideoFacingMode. This is required for adding a FacingMode field to MediaDeviceInfo mojom struct when we support facingMode for InputDeviceInfo.getCapabilities(). Bug: 817769 Change-Id: Idd4a8d80b2070a9add6b8d305b30f37c0a3565b1 Reviewed-on: https://chromium-review.googlesource.com/951672Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Chandan Padhi <c.padhi@samsung.com> Cr-Commit-Position: refs/heads/master@{#541532}
-
https://webrtc.googlesource.com/src.git/+log/2e18061033d3..12edf4ce344d $ git log 2e1806103..12edf4ce3 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I4aae1c907af7aeebb4475b116fd4c52145406765 Reviewed-on: https://chromium-review.googlesource.com/953078 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#541531}
-
Kyle Horimoto authored
This is in preparation for MojoWebUIController to be a base class for derived classes which reside in //ui. MojoWebUIController did not have any dependencies in //chrome, so //ui is a more fitting location anyway. Change-Id: Id032a3b36f4e3d15534f47bc62192c712c2674f9 Reviewed-on: https://chromium-review.googlesource.com/946869Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#541530}
-
Pavel Feldman authored
Bug: 818076 Change-Id: Iab6b751bc8e436294e3f32de3f6cd73bf9366525 Reviewed-on: https://chromium-review.googlesource.com/952272Reviewed-by:
-
Oystein Eftevaag authored
Change-Id: I1b356ea67cdcdf21a4338bbb81f35ce02a54f736 Reviewed-on: https://chromium-review.googlesource.com/952562 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#541528}
-
Mina Almasry authored
This is a reland of ca8bb6e7 Original change's description: > [Chromecast] Add support for mixer compatible CMA backend > > enable_video_with_mixed_audio gn flag has been added to turn on the new > CMA backend. > > Created libcast_media_1.0_avsync, a target that implements this new CMA > backend. > > AudioDecoderForMixer now owns an instance of a new interface, AvSync. > AudioDecoderForMixer will notify AvSync of its current status, and > AvSync will call into a new interface, VideoDecoderForMixer. > VideoDecoderForMixer will give AvSync enough control over the video > clock. > > BUG=internal 73746352 > > Change-Id: Id7f991ec9606b6f04dbb68f819ad5bf1c3da9cce > Reviewed-on: https://chromium-review.googlesource.com/947258 > Reviewed-by: Sergey Volk <servolk@chromium.org> > Reviewed-by: Kenneth MacKay <kmackay@chromium.org> > Commit-Queue: Mina Almasry <almasrymina@chromium.org> > Cr-Commit-Position: refs/heads/master@{#541293} Bug: internal 73746352 Change-Id: I7bca4c61ec5ef0338116f57d235eb74fa88133b6 Reviewed-on: https://chromium-review.googlesource.com/952167Reviewed-by:
Sergey Volk <servolk@chromium.org> Commit-Queue: Mina Almasry <almasrymina@chromium.org> Cr-Commit-Position: refs/heads/master@{#541527}
-
ckitagawa authored
binary tree. std::vector followed by std::sort and std::unique is a cheaper operation that saves a lot of RAM. Zucchini-read approximately halves in memory consumption (binary dependent) as a result of this change. std: :set is expensive in 64 bit binaries as it uses pointers to store a Change-Id: Ib7dd8242f8629ba436943695aa8ed3c3b8803ee4 Reviewed-on: https://chromium-review.googlesource.com/951753 Commit-Queue: Calder Kitagawa <ckitagawa@google.com> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#541526}
-
Muyuan Li authored
Bug: 807015 Test: Manual Change-Id: Icfaab55423a1a816d6c35a43c7a844d4c9ec3aee Reviewed-on: https://chromium-review.googlesource.com/952190Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
-
Jiaquan He authored
Bug: 733662 Change-Id: I09d889dd86f8bb8129e5c90a7c3d49dbe5fc49de Reviewed-on: https://chromium-review.googlesource.com/952629Reviewed-by:
-
Jiaquan He authored
When we have the app list UI in ash, UI behaviors in ash unit tests may invoke calls into chrome in many cases. We will use this fake client to consume these calls and limit all activities in ash only. Bug: 733662 Change-Id: I34361e3b76cac70643540c763e890e3d12865c85 Reviewed-on: https://chromium-review.googlesource.com/952526 Commit-Queue: Jiaquan He <hejq@google.com> Reviewed-by:
-
Corentin Wallez authored
BUG=chromium:811827 BUG=chromium:811806 BUG=chromium:811790 BUG=chromium:811825 BUG=chromium:811872 BUG=chromium:811829 BUG=chromium:811819 BUG=chromium:811810 BUG=chromium:811808 BUG=chromium:811832 BUG=chromium:811797 Change-Id: Ie58e7e869441afff42ef522f2da35fbb1e43c1ce Reviewed-on: https://chromium-review.googlesource.com/953084Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#541522}
-
Yuly Novikov authored
BUG=819661 TBR=kbr@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: If9d0357866a390ad88cf049ebb76f80588dfe0b2 Reviewed-on: https://chromium-review.googlesource.com/953073 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#541521}
-
Helen Li authored
This CL removes the special case in proxy_resolving_client_socket.cc to not skip retryable errors when connect to proxy fails. Bug: 817094 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I664a4b8926b73afc44480b240ad3b0b6e5446ad0 Reviewed-on: https://chromium-review.googlesource.com/952986Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#541520}
-
Emily Hanley authored
Bug: 758632 Change-Id: I05afa2de700600c4082ddca82fca8fbbd2cab3c4 Reviewed-on: https://chromium-review.googlesource.com/953067 Commit-Queue: Emily Hanley <eyaich@chromium.org> Reviewed-by:
Ashley Enstad <ashleymarie@chromium.org> Reviewed-by:
-
Hidy Han authored
Change-Id: I688b76fee2fc9b5aa2ac6b83fb0c818e20bc8741 Reviewed-on: https://chromium-review.googlesource.com/950237 Commit-Queue: Hidy Han <hidyhan@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#541518}
-
Kenneth Russell authored
BUG=chromium:811811 BUG=chromium:811905 BUG=chromium:811815 BUG=chromium:811796 BUG=chromium:811831 BUG=chromium:811789 BUG=chromium:811809 BUG=chromium:811821 BUG=chromium:811869 BUG=chromium:811866 BUG=chromium:811781 BUG=chromium:811799 BUG=chromium:811814 BUG=chromium:811864 BUG=chromium:811835 BUG=chromium:811834 Change-Id: I91e9f88b93354a27f6ca04622399218fd0dd5d42 Reviewed-on: https://chromium-review.googlesource.com/952046Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#541517}
-
Jose Dapena Paz authored
Compilation in GCC fails because of https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80654 if T in WTF::Optional<WTF::Vector<T>> is not trivially copy constructible. The problem already happened in std::vector and was workarounded. This change implements a similar fix for WTF::Vector. Bug: 816952 Change-Id: If87f01beb952e03eb49dcaf0c5db6efd745bf05e Reviewed-on: https://chromium-review.googlesource.com/944404 Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#541516}
-
Dominic Farolino authored
This makes the Fetch API more standards compliant by enforcing the enum values in the RequestInit dictionary, as this is not taken care of by the IDL bindings themselves. This enforces the mode, credentials, cache, and redirect properties of RequestInit. R=yhirano@chromium.org, yoav@yoav.ws Bug: 777116 Change-Id: I8db5fd991b5ffa039dc2f67b4d8f525647fbf915 Reviewed-on: https://chromium-review.googlesource.com/841270 Commit-Queue: Yoav Weiss <yoav@yoav.ws> Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#541515}
-
chrome://gpukylechar authored
Bug: 787097 Change-Id: I1db9b3edcd0fd7a5686b3a7c2f0993c551b3e9f6 Reviewed-on: https://chromium-review.googlesource.com/953070Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#541514}
-
Jao-ke Chin-Lee authored
This reverts commit d979063b. Reason for revert: Reasonable pending times, right now; let these builders back on the CQ while we keep any eye on things and work on a more permanent solution. Original change's description: > Mark builders with Win10 GCE slaves as experimental. > > Bug: 819355 > Change-Id: Ib242933a5a3d1cf4d03edac0cb4b4e6be468b12d > Reviewed-on: https://chromium-review.googlesource.com/952777 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: smut <smut@google.com> > Cr-Commit-Position: refs/heads/master@{#541326} TBR=smut@google.com,jchinlee@chromium.org,jbudorick@chromium.org Change-Id: I827b55a796c8e41f273552a9ea42e222b59b8d4d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 819355 Reviewed-on: https://chromium-review.googlesource.com/953030Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#541513}
-
Muyuan Li authored
Bug: 807015 Test: Manual Change-Id: I532b1a9441208ecf794c4975d3871880f6c43896 Reviewed-on: https://chromium-review.googlesource.com/945144 Commit-Queue: Muyuan Li <muyuanli@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Menglu Huang authored
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Idf5ef903e9e1eb9c1a55e62df3ed173731fa1920 Reviewed-on: https://chromium-review.googlesource.com/939864Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Menglu Huang <huangml@chromium.org> Cr-Commit-Position: refs/heads/master@{#541511}
-
Mounir Lamouri authored
R=isherman@chromium.org Bug: None Change-Id: I0c8907156c04dbd37fa64acd52648d3e34a5fdf8 Reviewed-on: https://chromium-review.googlesource.com/946188 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#541510}
-
Peter Beverloo authored
Change-Id: I458faa93c93fba0d32b81f2de54d7c370a2d9219 Reviewed-on: https://chromium-review.googlesource.com/952454Reviewed-by:
Anita Woodruff <awdf@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#541509}
-
