Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 05 Dec, 2019 5 commits
    • Balazs Engedy's avatar
      Add ContextualNotificationPermissionUiSelector. · ed2c2176
      Balazs Engedy authored 
      ContextualNotificationPermissionUiSelector determines if the quiet prompt UI
should be used to display a notification permission request on a given site.

This is the case when:
  1) the quiet UI is enabled in prefs for all sites, either directly by the
     user in settings, or by the AdaptiveQuietNotificationPermissionUiEnabler.
  2) the quiet UI is triggered by crowd deny, either through:
     a) CrowdDenyPreloadData, that is, the component updater, or
     b) CrowdDenySafeBrowsingRequest, that is, on-demand Safe Browsing pings.

The ContextualNotificationPermissionUiSelector is also wired up to the
PermissionRequestManager instead NotificationPermissionUiSelectorBasedOnPrefs.

Bug: 1028642
Change-Id: Ibb44ec1e0f0fe95d4fb350e9c2211199719df103
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944395
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: default avatarAndy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721748}
      ed2c2176
    • Clark DuVall's avatar
      [WebLayer] Fix CrashReporterController crashing if used before WL init · c530ad90
      Clark DuVall authored 
      This adds minimal initialization needed for CrashReporterController, as
well as delaying the call to processNewMinidumps() until after native
initialization has happened. Also cleans up the creation of
CrashReporterController to use AIDL instead of reflection.

Bug: 1027076
Change-Id: Ib1969c82eb93b88965de8ee793fa3d6eb46c7bf0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951551
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: default avatarTobias Sargeant <tobiasjs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721747}
      c530ad90
    • Ken Rockot's avatar
      Mojo: Support ConnectionGroup hierarchies · 6c2fb5f1
      Ken Rockot authored 
      This changes makes it possible for one ConnectionGroup to retain a
reference to another "parent" group.

The result allows multiple endpoints within a group to set their own
idle handler without becoming detached from the original group:
if an an idle handler is set on an endpoint which already belongs
to a group, a new group is created with the original group as its
parent and the endpoint references the new group instead. Thus this
interface and any interfaces bound transitively through it will now
reference the new group, but the new group will in turn keep the
original group alive as if all those interface endpoints were
referencing it directly.

This change is useful to support the migration of the Audio Service
off of Service Manager, as its client library currently uses an idle
handler on an interface which will already belong to the main service
interface's connection group under the new service model.

Bug: 977637
Change-Id: I43443ca96a260c9860785eb30450896a95d7ffe2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940654
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: default avatarOksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721746}
      6c2fb5f1
    • Mitsuru Oshima's avatar
      Zoom lookup should use the correct dsf. · 72e92ee9
      Mitsuru Oshima authored 
      Bug: b/141898654
Test: updated the test to catch this type of regression
Change-Id: Icee3d5aeb825748333bbe7094f10124d0e61f59f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951152
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: default avatarMalay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721745}
      72e92ee9
    • Connie Wan's avatar
      Revert "Implement TabGroupHighlight" · 4fa43718
      Connie Wan authored 
      This reverts commit a8ebb5e6.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Implement TabGroupHighlight
> 
> See attached bug for screencast. Confirmed with UX that the highlight should only appear on drag, not hover.
> 
> Bug: 1017822
> Change-Id: I0921f5cf425d82c25344adb4801de6de8746f771
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929490
> Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
> Commit-Queue: Connie Wan <connily@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#721705}

TBR=tbergquist@chromium.org,cyan@chromium.org,connily@chromium.org

Change-Id: Ifd307f56a9c7db57e928a310f60f1a01e770a800
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1017822
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951556Reviewed-by: default avatarConnie Wan <connily@chromium.org>
Commit-Queue: Connie Wan <connily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721744}
      4fa43718
  3. 04 Dec, 2019 35 commits