GitLab

Detect the GL_VENDOR string from the default GL implementation.
If it is the ATI proprietary driver then do not switch to EGL/GLES2
as there is a known bug and this driver crashes in eglInitialize
instead of failing properly.

BUG=822716

Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I00b883012c31867f938bf3f68440058738bb312b
Reviewed-on: https://chromium-review.googlesource.com/966662
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543735}

Although it is not spec compliant, many websites intentionally call
Window.print() on display:none iframes.

Bug: 819327
Change-Id: I02c2b8c9dad0cb6c8c4601c6104986aceb469bba
Reviewed-on: https://chromium-review.googlesource.com/964610Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543734}

Add missing flags to the iframe sandbox supported list, and add tests.
Also remove the runtime config for 'allow-top-navigation-by-user-activation' since the feature has shipped a long time ago.

Bug: 662506
Change-Id: I458210f6133ddd5e30b507214b003ff0fb596761
Reviewed-on: https://chromium-review.googlesource.com/965843
Commit-Queue: Bin Lu <binlu@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543733}

Change-Id: I75ecc7e893dfababd7669554433e674d77d95c1a
Reviewed-on: https://chromium-review.googlesource.com/953502
Commit-Queue: Julia Tuttle <juliatuttle@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543732}

The only remaining memory related column will be "Memory Footprint" [and Swapped
Memory on CrOS].

For one-pager that was sent to chromium-dev, see:
https://docs.google.com/document/d/1fSTVHKl8K7wLpx8755LCxbacnPBes8GiEmyAtHshohU/edit#

Bug: 819678
Change-Id: If579b0fb4f9ed8a4ef35010a1f22d00eb780ff7a
Reviewed-on: https://chromium-review.googlesource.com/957623
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543731}

Refactor the scheme where TaskQueueImpl notifies TimeDomain about a
delayed wake up and TimeDomain notifies TaskQueueImpl about next wake-up for it.

Make TaskQueueImpl be the ground truth for delayed wake-ups for the
particular queue and task TimeDomain with aggregating wake-ups across
different queues.

R=alexclarke@chromium.org,skyostil@chromium.org

Change-Id: I7d56d35e9c7b5b2bb1240a6a659d0d9a1f00c473
Reviewed-on: https://chromium-review.googlesource.com/955847Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543730}

Bug: 818699
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I0d24cfa9617876d313dd0f5cd7a44766b61d2844
Reviewed-on: https://chromium-review.googlesource.com/965382
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543729}

This is needed to handle focus changes correctly. The focus client in
this case is extremely minimal.

BUG=821602
TEST=covered by test

Change-Id: I6e1cbd686edf8e0080b8a21a28c3ddeae4e640a4
Reviewed-on: https://chromium-review.googlesource.com/965445
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543728}

Changes the use of Bind and Closure to BindOnce and OnceClosure in
GpuMemoryBufferVideoFramePool.

It additionally introduces a trampoline in MailboxHoldersReleased so
that if the callback is called on media_thread it can skip going trough
the message loop.
Previous the callback would be bound to the media_thread loop.

Two DCHECKs have also be added to check thread expectations.

TBR=dalecurtis, mcasas

Change-Id: I871e5505691b53a1871d2bd3e8a79ab1b75d2e69
Reviewed-on: https://chromium-review.googlesource.com/966583Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543727}

The touch selection controller may be null on Android for a few reasons,
one of which is that selection is disabled in VR currently.

Bug: 822374
Change-Id: Ie19fc8a4b148f64dc0fda391a45e758940d39154
Reviewed-on: https://chromium-review.googlesource.com/963680Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543726}

This patch adds a mention of OptionalOrNullptr to the optional.md docs.

Change-Id: I7d09afa336bcd06a11756b5d655370d162b80318
Reviewed-on: https://chromium-review.googlesource.com/965585Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543725}

https://github.com/w3c/web-platform-tests/pull/9986 has introduced some
flakiness to the test that is currently blocking WPT imports.

TBR=lukebjerring

Bug: 822757
Change-Id: Iddc3adf65989506b72fba003a2bbbd8d9cbf062f
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/966604Reviewed-by: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#543724}

This reverts commit a646eeb2.

Reason for revert: Turns out the supposedly deprecated field is still
widely used on the server. Will clean up those usages first and then
reland.
I considered manually undoing only those parts that actually touch the
protocol, but that seems much more confusing and error-prone. I might
reland the local parts of this separately though.

Original change's description:
> Sync cleanup: Deprecate GetUpdatesCallerInfo.GetUpdatesSource
>
> This enum deprecated years ago and replaced by GetUpdatesOrigin,
> but it was still in use for debug info. Now we're using
> GetUpdatesOrigin there too.
> Unfortunately GetUpdatesSource is a required field in the
> GetUpdatesCallerInfo message, so its definition has to stay.
>
> Bug: 510165
> Change-Id: Ib5ee13cd46c00e4aecb7af5913ee8c47af32f6c3
> Reviewed-on: https://chromium-review.googlesource.com/911628
> Commit-Queue: Marc Treib <treib@chromium.org>
> Reviewed-by: Nicolas Zea (slow) <zea@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#541140}

TBR=zea@chromium.org,treib@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 510165
Change-Id: Icb680a1071497274a78477be04dc18040483c58c
Reviewed-on: https://chromium-review.googlesource.com/966381
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543723}

TBR=kereliuk@chromium.org

Change-Id: I5910c15bcb442cb152f50f75a9008cc7a37887b7
Reviewed-on: https://chromium-review.googlesource.com/966585Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543722}

This reverts commit 247dee23.

Reason for revert: Failing on iOS 10 32-bit builder.

Original change's description:
> Log MobileDownloadFileUIInstallGoogleDrive in New Download Manager.
> 
> This CL also changes InstallationNotifier class to be compatible
> with OCMock (UIApplication shared instance is not stored in ivar anymore)
> and adds resetDispatcher method to allow restoring InstallationNotifier
> to its default state.
> 
> Bug: 791806
> Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
> Change-Id: Iaee0d80938639d23862b254732eb49c97ddd4e86
> Reviewed-on: https://chromium-review.googlesource.com/958123
> Commit-Queue: Eugene But <eugenebut@chromium.org>
> Reviewed-by: Peter Lee <pkl@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#543515}

TBR=eugenebut@chromium.org,pkl@chromium.org

Change-Id: I4c90614507c14322c6ab946ac4f8caeedc214cc3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 791806
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/966682Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543721}

This reverts commit b921591d.

Reason for revert:
Probable cause of WebView segfault in https://crbug.com/822732

Original change's description:
> Move websocket.mojom from third_party/WebKit to services/network
> 
> As a preparation to integrate websocket with the network service, this
> CL moves the mojom file to /services/network.
> 
> Bug: 721400
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
> Change-Id: I1284cbd9dd3292c41d1acba34835c6c6d44d48a3
> Reviewed-on: https://chromium-review.googlesource.com/961173
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#543632}

TBR=kinuko@chromium.org,jam@chromium.org,yhirano@chromium.org

Change-Id: I6062a78052b82364418c9f57ab768c8f001cb549
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 721400,822732
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/966761Reviewed-by: Anita Woodruff <awdf@chromium.org>
Commit-Queue: Anita Woodruff <awdf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543720}

https://webrtc.googlesource.com/src.git/+log/8870f553f3d0..af9e87b8c5bb

$ git log 8870f553f..af9e87b8c --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=None


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I052c004ae08b5ff2be6af51bd9a2f5eb1a9fd88a
Reviewed-on: https://chromium-review.googlesource.com/965932
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#543719}

Align lists of targets with chromium.webrtc

Bug: chromium:820041
Change-Id: Iad5a23becb61182fe729ac86f9e83747b71d6211
Reviewed-on: https://chromium-review.googlesource.com/955565
Commit-Queue: Oleh Prypin <oprypin@chromium.org>
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543718}

Currently some DOM objects in DevTools heap snapshot show up as
"UnknownNode" because the corresponding TraceWrapperBase objects do
not implement the NameInHeapSnapshot method. This patch fixes it.

The patch also makes NameInHeapSnapshot pure.

Bug: 811925
Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I495a75c5ee0c9f765a6d94daed62cf34c345d124
Reviewed-on: https://chromium-review.googlesource.com/966423
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543717}

This CL wires the tab grid page controls tab counts into the grid
view controllers. To do this, a public |itemCount| property is added to
the GridViewControllers, and the TabGridViewController updates the
counts in the page control whenever an event occurs that would change
the count (opening or closing a tab), and when the VC is initially set
up.

Bug: 804501, 804552
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I9162b45e04b102ce4c1b885356ebf3bf0873396b
Reviewed-on: https://chromium-review.googlesource.com/964143Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543716}

This CL adds two new ResultsSeen histograms that apply to all users.

One records whether results were seen for the tap gesture, and the other
for any gesture that triggers the Contextual Search UI.

All the previous histograms slice the data one way or another, usually
based on whether the user opted-in to our privacy policy.

These new histograms will make it easy to see the overall impact of
experiments that affect CTR.

BUG=821893

Change-Id: I0a20ca56668d2086a213fd946b0704e4db601714
Reviewed-on: https://chromium-review.googlesource.com/963291Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543715}

lld doesn't support /debug:fastlink, and so we used to assert when
trying to use those two together.

However, as we're planning to switch over to lld by default, we don't
want to break the builds of those who have specified is_win_fastlink
manually. Instead, ignore the flag when linking with lld, and eventually
it will be phased out altogether.

Bug: 792131
Change-Id: I83ff749254d4dbc55aedbfc6e87702e8e8a06a23
Reviewed-on: https://chromium-review.googlesource.com/966225Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543714}

Adds new feature signals from Blink about the page at the
location tapped.  These signals will be useful for deciding
whether to trigger Contextual Search.

Signals include the text run-length of the element tapped and
the effective font size.

BUG=754862

Change-Id: I02227479ecfae4d3b174a1845fed7c3d24e355b8
Reviewed-on: https://chromium-review.googlesource.com/920325Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543713}

Bug: 811661
Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I02a7aa880ad407afe0dc2c79e8a99be90bd59bd8
Reviewed-on: https://chromium-review.googlesource.com/960582
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543712}

Timeouts are seen accross most of the builders.

TBR=iannucci@chromium.org
NOTRY=true

BUG=820190

Change-Id: Id7122242be4fcfe34893a305c32fa4d05f49a80b
Reviewed-on: https://chromium-review.googlesource.com/966588Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543711}

AuthenticatorImpl doesn't support the callbacks being made immediately.
Instead, defer them via the current MessageLoop.

Change-Id: I57b43049e8dca8e1d113f86eb1ea5728e7d953a8
Reviewed-on: https://chromium-review.googlesource.com/963096Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543710}

Move the 'href' lookup to a helper function (as seen in the very similar
SVGGradientElement.) Use a similar setup in SVGGradientElement
equivalent method.
Move attribute synchronization from LayoutSVGResourcePattern into
SVGPatternElement::CollectPatternAttributes.
Change the SetPatternAttributes helper to take a SVGPatternElement
reference.
Remove the element null-check in the LayoutObject.

Bug: 769774
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I16901de05437bbeea1981f5340bec1a3e4329b50
Reviewed-on: https://chromium-review.googlesource.com/966221Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#543709}

This thread was recently removed, and is no longer used.

BUG=815225

Change-Id: I11e14933e9f30791be835034f59296bdbbedb708
Reviewed-on: https://chromium-review.googlesource.com/963597Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543708}

https://skia.googlesource.com/skia.git/+log/bcc00b2a612c..6e9a4f6327d1

$ git log bcc00b2a6..6e9a4f632 --date=short --no-merges --format='%ad %ae %s'
2018-03-15 egdaniel Make TestForPreservingPMConversions helper use lazy createTextureProxy call.

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=stephana@chromium.org

Change-Id: I7473d080bb9cc0c855a6b1d6f1c5da809e65853c
Reviewed-on: https://chromium-review.googlesource.com/965616
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#543707}

Bug: 822721
Change-Id: If0d5768d344580ce7da3b8cf07eaacece34614eb
Reviewed-on: https://chromium-review.googlesource.com/962141
Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com>
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543706}

This CL fix text wrapping issue. It also fixes text in Buttons do not
transform to upper case.

Bug: 814988
Change-Id: I1ba4d4270f5cf0d315ddf9aad4c7c3171be020e2
Reviewed-on: https://chromium-review.googlesource.com/964990Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Biao She <bshe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543705}

https://chromium-review.googlesource.com/904547 hasn't fix the crashes.
This cl checks the validity of the event router before sending the wheel
end events.

Bug: 791963
Change-Id: I5af23c24e5dcd9a8351ba00a8fdcfde4e2109b7d
Reviewed-on: https://chromium-review.googlesource.com/964736Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543704}

Change-Id: I52aee8a9046f00dd2d61a8361724ffacddd51677
Reviewed-on: https://chromium-review.googlesource.com/964664
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543703}

Traffic annotations FYI bot cannot access some files in build_path/gen.
Some Debug data is added to find out why?

TBR=msramek

Bug: 690323
Change-Id: I4fb716d8b843704bf48cfbb62d5b09a3791eb732
Reviewed-on: https://chromium-review.googlesource.com/966303Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543702}

Bug: 821873
Change-Id: I957926f214481ece2f9fba1d8d6357e0b61377a5
Reviewed-on: https://chromium-review.googlesource.com/964597Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543701}

external/wpt/FileAPI/BlobURL/test1-manual.html and
external/wpt/FileAPI/BlobURL/test3-manual.html were removed in
https://github.com/w3c/web-platform-tests/pull/8612

external/wpt/quirks-mode/active-and-hover-manual.html was renamed in
https://github.com/w3c/web-platform-tests/pull/8895, and the new name is now
in NeverFixTests.

Change-Id: I04804bfc5f9a3d37b44e5bc0f45308e6fe8bd639
Reviewed-on: https://chromium-review.googlesource.com/966289
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543700}

Just making const some things that can be made const. Primarily
stemming from template_url_service.

Change-Id: If7e368a15fcf3ada82c074f808de5fa8b7c4a878
Reviewed-on: https://chromium-review.googlesource.com/959055
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543699}

Following bot results are included.
4203 4207 4215 4216 4218 4221 4224 4227 4229 4230 4232 4235 4236 4237
4239 4240 4250

14 lines were removed and 35 lines were deflaked by consecutive
results since 4203.

4211 was manually excluded because it has 32 unexpected passes,
and it is questionable. Probably it was a flaky run.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I5da2f53155dbd38fcd8a4c80a05b4ee564334ec8
Reviewed-on: https://chromium-review.googlesource.com/964025
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543698}

Change-Id: If60cff3630b80ca0002287b600dd0ad31fe9d183
Reviewed-on: https://chromium-review.googlesource.com/964797Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Adam Parker <amp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543697}

Ideally, we should respect users' PATH when searching for Chrome binary.
For now, change the order of search paths to a better approximation of
the most common defaults across Linux distros.

In particular, try Chrome's default installation location AT LAST, so
that symlinks created by tools like update-alternatives are tried first,
which means honoring users' preferences of Chrome channels.

Change-Id: Ic77e439d3a3b428194af45b38bb85cfbb8a97508
Reviewed-on: https://chromium-review.googlesource.com/965444Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543696}