- 02 Jun, 2020 40 commits
-
-
Chris Hall authored
- Migrating IsDefault method - Migrating HasPopup method - Inverting control flow for NativeRoleIgnoringAria Written collaboratively with Aboxhall and Meredithl. Change-Id: Ic516fecf0f9e9d010e033ec46c8bd09df7869983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186874Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#774035}
-
Fergal Daly authored
Adds a frame_tree() accessor to RenderFrameHostImpl. Adds an accessor for NavigationControllerImpl to FrameTree. Using both of these, remove a lot of chained accesses in code. Change-Id: Ic195217e249eb41744a0d7fd8f77340ab708ce07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212185 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#774034}
-
Giovanni Ortuño Urquidi authored
This reverts commit e00873cb. Reason for revert: Causing a lot of SafeBrowsingBlockingPageDelayedWarningBrowserTest tests to fail: https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20%281%29/63042 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8878647092646084928/+/steps/browser_tests/0/logs/Deterministic_failure:_SafeBrowsingBlockingPageWithDelayedWarningsBrowserTest__x2f_SafeBrowsingBlockingPageDelayedWarningBrowserTest.KeyPress_ESCAndCharacterKey_WarningShown__x2f_1__status_CRASH_/0 Original change's description: > [SB Delayed Warnings] Allow non-character keys such as Escape > > Users may sometimes press non character keys such as ESC when on a > webpage (e.g. to close popups or other prompts). This CL ignores > these cases and does not undelay the warning. > > Bug: 1057157 > Change-Id: I4cfc2c621e4c0a84f46fdaa8f800e6843ed6b4b4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225361 > Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> > Reviewed-by: Varun Khaneja <vakh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773833} TBR=meacer@chromium.org,vakh@chromium.org Change-Id: I660f1e2b2b05472df75fbe34600672d53594e95e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1057157 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225682Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#774033}
-
David Bokan authored
This ensures scroll-related unit tests in this file run with both unification enabled and disabled. Bug: 1086625 Change-Id: Ic64d466ff8b93bb208aa676be4c1188d58964186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222141 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#774032}
-
Nick Diego Yamane authored
This is a reland of 5930a9fd Original change's description: > ozone/wayland: Fix data objects initialization and ownership > > DataDevice-related wrappers initialization and ownership, for both > standard and GTK's primary selection, are quite confusing and spread > over different parts of the backend code. This CL fixes and simplifies > it by: > > - Moving {WaylandData,GtkPrimarySelection}Device ownership to their > respective DataManager wrapper class. E.g: WaylandDataDeviceManager owns > WaylandDataDevice singleton; > > - Fix WaylandClipboard initialization whether the compositor happens to > advertise GtkPrimarySelectionDeviceManager after wl_seat and > wl_data_device_manager; > > - Use dependency injection to provide DataSources with the correct > DataDevice instance at their construction time; > > - Clean up WaylandConnection by getting rid of the multiple (and almost > unused) data device getters from it as well as removing unneeded header > includes. > > Bug: 896640 > Change-Id: Ie12964fdf4e7b78bbbd9a11e133ab082613f1c7b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216320 > Reviewed-by: Maksim Sisov <msisov@igalia.com> > Commit-Queue: Nick Yamane <nickdiego@igalia.com> > Cr-Commit-Position: refs/heads/master@{#773235} Bug: 896640 Change-Id: I52ec359c5339847674ab0ab8f89a96c15ededf59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225502 Auto-Submit: Nick Yamane <nickdiego@igalia.com> Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#774031}
-
Alex Rudenko authored
This CL removes inspect_tool_highlight.html and replaces it with resources produced by DevTools[1], where the implementation has been moved to in a separate CL[2]. [1]: https://goo.gle/devtools-overlay-reuse [2]: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2192892 Bug: 1078267 Change-Id: I95d3faef98470e13430ed251cf135e59269358d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194865 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#774030}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/d39b8afc47a1..f15982ebebb2 2020-06-02 dj2@everburning.com Remove install to the SPIRV/ folder. (#2256) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,ynovikov@google.com Change-Id: I534dee9c82879fae34149a6c6c06fa48c15aaa8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226054Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774029}
-
Yoshifumi Inoue authored
This patch changes "click-before-and-after-table.html" to utilize |selection_test()| for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: I675249309b62567be60c15854624c3eede648b85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226105 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#774028}
-
Johann authored
Change-Id: Ic5d84ea643161a33ed724c2576d75f4171413386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225680 Commit-Queue: Johann Koenig <johannkoenig@google.com> Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Johann Koenig <johannkoenig@google.com> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#774027}
-
Alexander Dunaev authored
This CL is the first step that prepares us to get rid of DWTHX11. As we proceed with that, at some point we will have to throw off the DesktopDragDropClientAuraX11 because it is used by DWTHX11, and migrate DnD to DDDCOzone. As the latter will be used on both Ozone and non-Ozone, it needs the X11window to handle DnD. Hence this change. I move the DnD-related code from X11WindowOzone into X11Window. Change-Id: I682c794d9cfab4b7ad6b6a9b89331526f31d227a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213578Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/master@{#774026}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1591055861-2c929ca1d8463b09aee877402f62f07b9528b0a1.profdata to chrome-mac-master-1591070241-ce04e1e2e870e385b3dffbd254a1f6cdfc41d3e5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I4d9fa6154b0310e7b10b8d7bf62d820413301dc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226052Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8eeff5ccf3a3..6e5288a5ef2a 2020-06-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from c70c5e32 to 0fa61969 (402 revisions) 2020-06-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 471c120ac92a to 11dd7183c4d2 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tdenniston@google.com Change-Id: Ia4325268b10d2babced73888075ec74165806b81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226050Reviewed-by:
-
Alex Rudenko authored
This CL adds editing support for stylesheet objects constructed using `new CSSStyleSheet()`. Editing still won't work for styles added to a <style> tag using CSSOM API. Doc: https://goo.gle/devtools-css-in-js Video: https://www.youtube.com/watch?v=i68cl5r2c-g Bug: 946975 Change-Id: I203663f4a2addacfcbfbd54d1a2c396aa6d693ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217413Reviewed-by:
-
Julie Kim authored
This reverts commit e8136dba. Reason for revert: It causes the crash on Windows on handling sync CheckForCancel in a sync PrintHostMsg_SetupScriptedPrintPreview IPC message. Original change's description: > [printing] Mojofy PrintHostMsg_CheckForCancel > > This CL replaces the PrintHostMsg_CheckForCancel IPC message > with a new CheckForCancel Mojo method in the PrintPreviewUI > interface. > > Bug: 1008939 > Change-Id: Ic694b892744387bfc0c4c1232ed4b6a9cb1b6388 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212181 > Commit-Queue: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Sam McNally <sammc@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771581} TBR=sammc@chromium.org,dtapuska@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1008939,1090147 Change-Id: I06a869b7b98c6d48e89a2744739393bbe729857c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226002 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#774022}
-
Giovanni Ortuño Urquidi authored
This reverts commit 4370f074. Reason for revert: Causing HomeToOverviewNudgeControllerTest.NudgeHiddenDuringShowAnimation to fail. https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/38470 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8878645531766485392/+/steps/ash_unittests/0/logs/Deterministic_failure:_HomeToOverviewNudgeControllerTest.NudgeHiddenDuringShowAnimation__status_CRASH_/0 Original change's description: > Reland "wm: Improve cross fade animation." > > This is a reland of 3abaa7f0. > > Changes: Now that the observer observes the new layer, on window > destroying or removing from root window we should stop animating the > new window as well. > > Original change's description: > > wm: Improve cross fade animation. > > > > *Destroy old layer when new layer animation is aborted. > > *Only log histograms once after animation. > > > > The old layer is owned by a observer which does not know when the new > > layer is being aborted. Change this so that the observer observers the > > new layer and destroys the old layer accordingly. > > > > The pass animations reporter will be used for every LayerAnimationElement, > > for cross fade, we animate opacity in addition to transform when the old > > bounds is wider than the new bounds. This results in double counting, > > which skews the smoothness numbers as animating two properties should be > > slower. > > > > Test: manual, ash_unittests WindowAnimationsTest.CrossFadeHistograms > > Bug: 868170, 1087460 > > Change-Id: I3bc5b597e8109a3e87f432f6aa352ba94860f8ed > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218557 > > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#773397} > > Bug: 868170, 1087460, 1088169 > Change-Id: I3a2f6af334ca0cd325e49107e812824f7a39340e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224990 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773921} TBR=oshima@chromium.org,sammiequon@chromium.org Change-Id: I043c684a88133cf6210c5b2d53ecd3d31583bc2a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 868170, 1087460, 1088169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226004Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d74336e50254..bfe5e4df6de2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ortuno@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1090082 Tbr: ortuno@google.com Change-Id: Ia36d0431285de603be60c15304a271f1387eb146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226045Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774020}
-
Alex Gough authored
Note: check for successful call to Done() before calling AddTarget() is retained. Tests: removing functionality. Bug: 1059129, 1089326 Change-Id: If500d2c2b8aedaa1925fcbaf5b6fa9d32c718a71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225223Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#774019}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/24e74c9857fa..03a0d5b08cac 2020-06-02 tandrii@chromium.org git-cache: delete support for internal repos. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I0255bfc07c4dd4f212701b5add7103e6fb3f810d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226051Reviewed-by:
-
Cherie Cheung authored
For ARCVM, DriveFS path will be handled by Seneschal SharePath request. For ARC++, legacy fd passing will be kept for the time being (b/157297349). Bug: 147618164 Test: Files on DriveFS can be opened by an android app Change-Id: I99e5704610d5a922a95e4c3d885b6b62d9b9a144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212114Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Cherie Cheung <cherieccy@chromium.org> Cr-Commit-Position: refs/heads/master@{#774017}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5891b0910066..77e5316a515d 2020-06-02 jiajie.hu@intel.com Pull in Android-only dependencies behind a condition If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: I7e8fac65ada179512f523fe195b54a45b091ed18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226044Reviewed-by:
-
rbpotter authored
Closure compiling: - copies_settings_test - color_settings_test - custom_margins_test Bug: 1000989 Change-Id: I4e9d9068d1f5d63d5a618bcc9980f52358fd1ce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223265 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#774015}
-
Austin Eng authored
These were marked as failing on only Windows and Linux. A Dawn change is coming which will update the Metal backend to also throw OOM on large buffer allocations. Pre-emptively marking as failing to prevent test failures. The main issue here is that the test incorrectly does not allow the implementation to throw an OOM error on enormous buffer allocations. Bug: dawn:433 Change-Id: Id5123ea1608bf68916a5c40d2d682f8c715e3a0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225792 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#774014}
-
Kuo Jen Wei authored
Bug: 1087777 Test: tast run <DUT> camera.CCAUIIntent Change-Id: I98bdafe9f131fc5b3e2b8194e9687f9a1b491fda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224937 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#774013}
-
David Bokan authored
This CL makes it so that all tests in layer_tree_host_impl_unittest.cc pass when the scroll unification flag is turned on. A followup mechanical CL adds parameterized test suites to ensure it stays that way. The main changes here are that under unification, cases where ScrollBegin would previously cause a scroll to be routed to the main thread are now handled on the impl thread. In cases where the hit test was unreliable or had a non-fast scrollable region, the return now requests a main thread hit test. For simple main thread scrolling reasons, a hit test isn't necessary. Also made some minor updates to a few tests to ensure they're running under the most realistic scenario by making sure they setup the viewport correctly. Bug: 1086625 Change-Id: I20fbd4c431c583e0a63241e91a3adaeb298bed0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222262 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
-
Peter Kotwicz authored
This CL extends the expiry date for the following histograms: WebApk.Startup.Cold.NewStyle.ShellLaunchToSplashscreenVisible WebApk.Uninstall BUG=1086221,1072540 Change-Id: I7f1f031ba05dbb094467853042e36f588cbda1b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222036Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#774011}
-
Fergal Daly authored
The previous expectation was that navigating a subframe would not change the WbUI object. This changes the test to expect a new object. It's still unclear if having a new object is actually OK. This is behind a flag, so we can figure it out. Change-Id: I6fc1703c7997942412d66e8b29d32fc94cf3a910 Bug: 1064944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141486Reviewed-by:
-
nancylingwang@google.com authored
For Crostini, though LoadIconFromVM loads the penguin icon, fallback_icon_resource_ is set as the default icon IDR_APP_DEFAULT_ICON. So the penguin icon is reloaded by the default icon. Modify LoadIconFromFileWithFallback and set the fallback resource as kInvalidIconResource to not load the default icon for Crostini. BUG=1088393 Change-Id: Icd7b264f225047224a6d0b3d0dac04dedbfe2ce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226102Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#774009}
-
Fergal Daly authored
The crash has not occurred since https://crrev.com/c/2186901, submitted on May 12. Some of the dchecks etc remain and some todos updated to point to the main RenderDocument bug. Bug: 1006814 Change-Id: Id078eed913addbc4444050dff5f76e357e8a3e40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214766 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#774008}
-
Hirokazu Honda authored
We formerly settle enabled features in the test initialization. However, if base::TestSuite::Initialize() is called, it turns out that these features are overwritten and thus no effect in the test. There is no way to stop the overwrite. Therefore, this workarounds the behavior by re-enabling features in TEST_P. Bug: None Test: video_encode_accelerator_unittest on eve Change-Id: I26ec9afcbb4d88786fd18d4701a6dde3938ecc99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210186 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#774007}
-
Yuzu Saijo authored
This CL removes the call to DeleteForCurrentDocument from the destructor of ManifestManagerHost. This intends to fix a crash which happens from time to time using RenderDocumentHostUserData. Change-Id: I1336fb62328dcb0cf9991499f399bf3665d29b75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224737Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#774006}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ced839500960..ab74e294602d 2020-06-02 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I09be1ba1e40e75b71e338c6adeee8081f2c5f006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226047Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e9a386951413..a5d0662b82d0 2020-06-02 dberris@chromium.org refactoring: Remove MockIssueTrackerService If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1087803 Tbr: nuskos@google.com Change-Id: I36c6a2c41d125ce826e6be38a57b2ddfec548c68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226046Reviewed-by:
-
shrekshao authored
Mark conformance2/textures/misc/origin-clean-conformance-offscreencanvas.html as RetryOnFailure. No-Try: True Tbr: kbr@chromium.org Bug: 1082525, 1090201 Change-Id: I9a59e245a6b3cfa765ad43a434b08fbcc8b8eec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226085Reviewed-by:
Shrek Shao <shrekshao@google.com> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#774003}
-
Tetsui Ohkubo authored
It is possible for a Wayland client to trigger drag & drop operation from the touchscreen. Exo have used GetCursorScreenPoint() as the initial drag shadow position, but the method does not return the expected location when DnD is triggered from the touchscreen. TEST=manual BUG=None Change-Id: I7febd3dacd60603893dee16a96adba05460d6422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224886Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#774002}
-
Hirokazu Honda authored
video_encode_accelerator_tests can accept compressed data as input and decode it by using SW decoder before encoding. The code copies the entire decoded frames to encoder input data. However, the decoded frames might have different stride from the expected resolution. For instance, compressed data has 320x192 video frames and the SW decoder produces 384x192 video frames. The test must copy the resolution area that is specified by json file. Bug: 1045825 Test: video_encode_accelerator_tests on eve Change-Id: I3f6b5a78a30ef0e9e96211bee2c981af437607cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217831 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
Ian Kilpatrick authored
As above - this fixes: external/wpt/css/css-overflow/webkit-line-clamp-004.html We weren't performing the correct relayout if the lines exactly matched the requested number of lines. Bug: 993813 Change-Id: I4ab3a702161bcb8e8cd10fc8ea6837931ebac16d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224601 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#774000}
-
Kenichi Ishibashi authored
This test depends on ServiceWorkerRegistrationInfo. The test should be moved to ServiceWorkerRegistryTest as a preparation for moving ServiceWorkerStorageTest to the Storage Service. The test is renamed as we might want to remove GetAllRegistrationsInfo in the future (but we won't remove ServiceWorkerRegistrationInfo). Bug: 1055677 Change-Id: Ib3c6a86ed9d364d43dd5cbcd94a02e5276973699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224936Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#773999}
-
David Munro authored
We keep forgetting to update the dashboard scripts when adding new return codes, add a link in a comment above the enum so we hopefully remember. Test: None Bug: None Change-Id: I07a8b8b49118dc19bf352282f658ab95f1d21253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220115 Commit-Queue: David Munro <davidmunro@google.com> Auto-Submit: David Munro <davidmunro@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#773998}
-
Hitoshi Yoshida authored
Implements fooNonNull() and hasFooNonNull() APIs for nullable dictionary members whose return type requires base::Optional<T>. Bug: 839389 Change-Id: I1696645234338b36ff54e6f01a13e7e1b578c322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224484 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#773997}
-
Jarryd authored
Extend by a year so that we can continue to monitor eviction behavior around the new quota paramaters such as extended quota. Bug: 1072671 Change-Id: I6aa30f620d3c933c49c81519b0f50437c27b927c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207628Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#773996}
-
