- 19 Dec, 2019 40 commits
-
-
sandromaggi authored
Previously the source for contacts and shipping addresses was the same sorted list of profiles. There may be cases where we want to sort them differently, which is enabled by splitting the list in two. On view we transform the profiles into either Contacts or Addresses. Note: This change breaks the default selection based on the account's address. This is moved to native in crrev/c/1954393 and has not been recreated here. Bug: b/144005336 Change-Id: I1e8e085f1de2fc7710969e778078495b3b54704b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961197 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#726331}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a1e2eee578bf..4de162fd4924 git log a1e2eee578bf..4de162fd4924 --date=short --first-parent --format='%ad %ae %s' 2019-12-19 taylori@google.com Merge "perfetto-ui: Add origin trial" Created with: gclient setdep -r src/third_party/perfetto@4de162fd4924 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I2912e8cef779a8bbfa81e8eb6fc4052d7574b897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975654Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726330}
-
Mathias Carlen authored
Remove the trusted apps whitelist and the AGREED_TO_TC logic that was introduced for a now obsolete flow. Bug: b/145907489 Bug: 1031697 Change-Id: I330f1ee91e43c93ccdaedd90126737bf064e957b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967241Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4b80fbc8f94a..f321db9a8ea2 git log 4b80fbc8f94a..f321db9a8ea2 --date=short --first-parent --format='%ad %ae %s' 2019-12-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 38d7fbaad0a3..e70b009b0f1e (1 commits) 2019-12-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 21be09d8e699..4fd7fccd6db5 (4 commits) 2019-12-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 2b19f3916726..e8e8f32d1b7a (4 commits) 2019-12-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src 9c5719ab7149..246503e9c085 (1 commits) Created with: gclient setdep -r src/third_party/angle@f321db9a8ea2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jmadill@google.com Change-Id: I587fc36de24b668a94bb03d7ba525461e195fa47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974927Reviewed-by:
-
Dan Elphick authored
This CL was created automatically with tools/perf/update_wpr script R=crouleau@chromium.org Bug: 878390 Change-Id: I21c9733cd10e46b1983c936b7b9b7d9081329e41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970563 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#726327}
-
Mike West authored
This patch partially reverts [1], which began applying the context document's CSP to the document fragment produced from `DOMParser.parseFromString`. This application broke the expectations of GMail's dynamic email feature, and we ought to pull it out until we understand whether our CSP implementation is wrong, or whether GMail is wrong. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/1917532 Bug: 1030830, 951536 Change-Id: Id7e86ca85df8790bb58fda15827a3f34e00239fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975710Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#726326}
-
Santiago Aboy Solanes authored
This CL was created automatically with tools/perf/update_wpr script R=crouleau@chromium.org Bug: 878390 Change-Id: Ia60ab1c6c3607e85fe07dd1887ce144c8c8f790a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973811Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1a5c0d36940b..849b3de2b2d7 git log 1a5c0d36940b..849b3de2b2d7 --date=short --first-parent --format='%ad %ae %s' 2019-12-19 changhaohan@chromium.org bypass URL trimming for style panel URL Created with: gclient setdep -r src/third_party/devtools-frontend/src@849b3de2b2d7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1027168 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4e6086ef48cd039206f70269e4f2b74e3af21513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975650Reviewed-by:
-
Philipp Hancke authored
adds calculators for the number of retransmitted packets and bytes sent Bug: none Change-Id: I3b5622c16e307c858c09cdcf14fc2ca7dd9e3d9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972834Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#726323}
-
Mythri A authored
This CL was created automatically with tools/perf/update_wpr script R=crouleau@chromium.org Change-Id: I8c3270ba0369681dba7e5710e6d8ea580666e33c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973824Reviewed-by:
-
Mathias Bynens authored
A long time ago in a galaxy far, far away, there was a property order mismatch between the DevTools Console Preview and the expanded view. For example: input> ({ c: 1, b: 1, a: 1 }) preview> {c: 1, b: 1, a: 1} expanded> {a: 1, b: 1, c: 1, __proto__: Object} We then attempted [1] to remove the confusing mismatch as follows: input> ({ c: 1, b: 1, a: 1 }) preview> {c: 1, b: 1, a: 1} expanded> {c: 1, b: 1, a: 1, __proto__: Object} In addition to avoiding the mismatch, this patch made DevTools more closely resemble the internal shapes of objects [2] instead of hiding this information from developers. However, since shipping, we've heard overwhelming feedback in favor of restoring the old behavior, where the expanded view is sorted. As a result of this feedback, a DevTools patch [3] restores the sorting logic. Now that the DevTools front-end change has landed and rolled into Chromium [4], we can re-enable the tests. Note that their expectations have already been updated as part of a prior CL [5] which disabled them. [This patch updates the test expectations accordingly. Note that for each test, only the order in which properties/values are printed changes. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/1806457 [2]: https://mathiasbynens.be/notes/shapes-ics [3]: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1969479 [4]: https://chromium-review.googlesource.com/c/chromium/src/+/1972163 [5]: https://chromium-review.googlesource.com/c/chromium/src/+/1971832 Bug: chromium:989514, chromium:1008910 Change-Id: I17aa627cd91ee9edbc28bf4778db6be056b89bda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973814 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#726321}
-
Mathias Carlen authored
Before this patch, building desktop chrome using code from autofill_assistant doesn't link. This patch moves the static member in wait for navigation to the cc file to resolve that. R=sandromaggi@google.com Bug: b/143736397 Change-Id: I9c0c70657037b66316dff42d07494c6536956596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975530Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#726320}
-
Emanuel Ziegler authored
This CL replaces calls to deprecatedByteLengthAsUnsigned by calls to byteLengthAsSizeT. If the byte length is larger then a RangeError is thrown to avoid problems in passing a wrongly cast size to the underlying stack. Background: we prepare ArrayBuffers to be bigger than 4GB. Therefore we changed the size field to size_t. Now we are changing all uses of ByteLength to be able to deal with size_t, either by accepting a size_t, or by throwing an exception if the size is too big. R=jsbell@chromium.org Bug: chromium:1008840 Change-Id: Icb8a40032624405458d180ec107f354b166dc60f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1964491Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> Cr-Commit-Position: refs/heads/master@{#726319}
-
Emanuel Ziegler authored
This CL replaces calls to deprecatedByteLengthAsUnsigned by calls to byteLengthAsSizeT. If the byte length is larger then a RangeError is thrown to avoid problems in passing a wrongly cast size to the underlying stack. Background: we prepare ArrayBuffers to be bigger than 4GB. Therefore we changed the size field to size_t. Now we are changing all uses of ByteLength to be able to deal with size_t, either by accepting a size_t, or by throwing an exception if the size is too big. R=reillyg@chromium.org Bug: chromium:1008840 Change-Id: Id713040b55384d2b427d97ffdd66d4963eb614ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1964610Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> Cr-Commit-Position: refs/heads/master@{#726318}
-
Dan Elphick authored
This CL was created automatically with tools/perf/update_wpr script R=crouleau@chromium.org Bug: 878390 Change-Id: Ie092bb7448d697516db61db7eb747a0f764cb969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970011 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Olivier Robin authored
Bug: 1033180, 1024750 Change-Id: I55719298534c29e6a5387c37671363fb0a3ce493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975611Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#726316}
-
Rune Lillesveen authored
Bug: 1035708 Change-Id: Icc959ee73f3cebaf5c9c3890d3db98bba0127923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975610Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#726315}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I3ec099991c45508fc234fd17d44d288e22c30d4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974926Reviewed-by:
-
Rijubrata Bhaumik authored
We did not add focusMode constraint in V4L2CaptureDelegate::SetPhotoOptions(). This CL fixes it. We tested by setting auto-focus to be true v4l2-ctl -d /dev/video1 --set-ctrl=focus_auto=1 and then try the demo at https://codepen.io/rijuB/pen/BPyWzp where the demo (JavaScript) does applyConstraints({advanced: [{focusMode:"manual"}]}) Bug: 1029540, 732807 Change-Id: Id5f7ecf06993b5cf8bed2d046254fa8bfc0740cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970314Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#726313}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/60e4a93e3e4d..a1e2eee578bf git log 60e4a93e3e4d..a1e2eee578bf --date=short --first-parent --format='%ad %ae %s' 2019-12-19 treehugger-gerrit@google.com Merge "Added parsing of ChromeHistogramSample typed trace events" Created with: gclient setdep -r src/third_party/perfetto@a1e2eee578bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I22ffb571983034f8504f20ab61133ee69f007b16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974928Reviewed-by:
-
Kunihiko Sakamoto authored
This makes it possible to load web bundles from network where the exact length of application/webbundle stream is unknown, e.g. when content- length header is not provided or the response is content-encoded. Bug: 1033404 Change-Id: I58e9c44cde2e49c92076bcbf1383135416eb6cb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971173Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#726311}
-
Oriol Brufau authored
Even if a list item has 'list-style-position: outside', Chromium may force its marker to be inside when it's a <li> outside a list element. This information was stored in layout, but this created an undesirable dependency since the computed 'display' value of the marker depends on whether it's inside or outside. And it wasn't possible to force a marker with non-normal 'content' to be inside. This patch fixes it by adding an internal 'IsInsideListElement' flag in ComputedStyle. This design also avoids traversing all the ancestors of every <li> element. BUG=457718 TEST=external/wpt/css/css-pseudo/marker-content-015.html The test fails in legacy since 'content' is not supported yet. Change-Id: I2df70841e8e9d729fd4aa47ec9b9973c09a82dcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973914Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#726310}
-
Hitoshi Yoshida authored
Web IDL spec allows to include _ and - in identifiers. Our IDL compiler generates bindings functions with removing them. Then the generated functions' names can conflict easily with others. This CL replaces them some special strings to avoid conflicts. Bug: 850972, 700338 Change-Id: Ic1fbd76b9f341a961ccc21871d86c3aaed4b791c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975389 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#726309}
-
Ross McIlroy authored
This CL was created automatically with tools/perf/update_wpr script R=crouleau@chromium.org Bug: 878390 Change-Id: Ice34b78fcc327f5793edcdc91871cf19ade2389e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974151Reviewed-by:
-
James Cook authored
This is more consistent with the other SyncUserSettings function names. No behavior changes. Bug: 1013466 Change-Id: I06428f53d9ebab8ea2c7dffd319bea8ee9f1d388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974192 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#726307}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4b40870fb128..1a5c0d36940b git log 4b40870fb128..1a5c0d36940b --date=short --first-parent --format='%ad %ae %s' 2019-12-19 comoody@microsoft.com DevTools: Make expandable text in ObjectPropertiesSection accessible. Created with: gclient setdep -r src/third_party/devtools-frontend/src@1a5c0d36940b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibe57f77e9229bb18b6163f150ee443554c1f29bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974925Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/38d7fbaad0a3..e70b009b0f1e git log 38d7fbaad0a3..e70b009b0f1e --date=short --first-parent --format='%ad %ae %s' 2019-12-18 dneto@google.com Add support for SPV_KHR_non_semantic_info (#3110) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@e70b009b0f1e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,jmadill@google.com Change-Id: I8d402cd13e69ebb37521502d487abff8e19c677d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974924Reviewed-by:
-
Chih-Yu Huang authored
This CL replaces Closure with OnceClosure to reduce the copy of callback. Bug: 1020668 Test: run vda_tests on kevin Change-Id: I36814346c52217eb8b17cda4799d7f947ccec817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974723 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#726304}
-
Mario Sanchez Prada authored
The three migrations proposed in this CL are the only instances left inside //content after the massive migration to the new types, so let's migrate these ones too and then update the PRESUBMIT script so that any attempt to re-introduce old types in this part of the code will raise an error, instead of a warning. TBR=kenrb@chromium.org Bug: 955171 Change-Id: Ib006c869576d122289781d065629db957cd9f347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972847 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#726303}
-
Chih-Yu Huang authored
The Chromium smart pointer guidelines [1] says "don't pass or return a smart pointer by reference". This CL remove "const scoped_refptr<T>&" at V4L2 VEA and VDA. [1] https://www.chromium.org/developers/smart-pointer-guidelines Bug: 1020668 Test: run vda_tests on kevin Change-Id: I577ecf143f48f5fd3b0749a7a964e84ef1533cbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974722 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
-
Eric Willigers authored
WebAppBrowserTest.HasMinimalUiButtons created an opened 5 PWAs. It now only creates and opens 3 PWAs, to avoid flaky timeout failures. Bug: 1034029 Change-Id: I9de602007f2f9648dc8dd1f1c5fd9f1c6f15d065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975375 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#726301}
-
Chih-Yu Huang authored
The Chromium smart pointer guidelines [1] says "don't pass or return a smart pointer by reference". This CL remove "const scoped_refptr<T>&" at V4L2 Picture. [1] https://www.chromium.org/developers/smart-pointer-guidelines Bug: 1020668 Test: run vda_tests on kevin and octopus Change-Id: I0186208ee905433859f65fd0e86b88d81c7b2c39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974721 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
-
Chih-Yu Huang authored
This CL adds sequence check at each method, and check the release callback is null when setting it. Bug: 1020668 Test: run vda_tests on kevin Change-Id: Ia2760e1a787b0ca65a652b58a4f7ecfc66b61e8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974720 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
-
Hitoshi Yoshida authored
Set a GN args variable |use_v8_bind_gen_for_dictionary| to use the new bindings generator. This CL adds a new file core/v8/generated.gni to list names of generated files as we do in modules/v8/generated.gni. Bug: 839389 Change-Id: I2513ae6b43478b9e3b07b1042467ef3c9624bf49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969292 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
-
Vadym Doroshenko authored
Along the way, removed my test config for feature that was already launched several release ago. Bug: 959776 Change-Id: Ia0653f7b806b440b429fb41290e98bada2751de1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974093 Auto-Submit: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#726297}
-
Eric Willigers authored
WebAppEngagementBrowserTest/ManyUserApps now launches only 2 apps instead of 4, to avoid test timeouts. Bug: 1034028 Change-Id: I346605d69a8fbb7b043996b7af4e947799ca4610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975384 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
-
Chih-Yu Huang authored
The Chromium smart pointer guidelines [1] says "don't pass or return a smart pointer by reference". This CL remove "const scoped_refptr<T>&" at V4L2DecodeSurfaceHandler. [1] https://www.chromium.org/developers/smart-pointer-guidelines Bug: 1020668 Test: run vda_tests on kevin Change-Id: Ic33f8c3e7162ac4c0648287cc7d7132a0ae8da96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974719Reviewed-by:
-
Chris Lu authored
TBR=sczs@chromium.org Bug: 1035764 Change-Id: I7347d737954e25c9f35ae22e6614eb9fdcbf5ff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974308Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#726294}
-
Kunihiko Sakamoto authored
This disables the following tests failng on Win7 Tests (dbg)(1): - GlTestEnvironmentTest.InitializeAndCleanup - UiPixelTest.DrawVrBrowsingMode Bug: 1035767 Tbr: mthiesse@chromium.org Change-Id: Idfa12ccd58421cd79c9d46c57a8fad1d4e672954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975471Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#726293}
-
Chih-Yu Huang authored
The Chromium smart pointer guidelines [1] says "don't pass or return a smart pointer by reference". This CL remove "const scoped_refptr<T>&" at VP8Decoder. [1] https://www.chromium.org/developers/smart-pointer-guidelines Bug: 1020668 Test: run vda_tests on kevin and octopus Change-Id: Ic22d3317c9f1f92dda76bba4c56c150883b1e7ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974718Reviewed-by:
-
