GitLab

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269797 0039d316-1c4b-4281-b951-d872f2087c98

https://code.google.com/p/skia/source/list?num=22&start=14688
TBR=borenet
BUG=

Review URL: https://codereview.chromium.org/278323003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269796 0039d316-1c4b-4281-b951-d872f2087c98

Dispatch geolocation IPCs on the UI thread. Aside from simplifying the code to avoid a lot of thread hops, this sets things up for converting the code to work on RenderFrames instead of RenderViews.

In the process I also switched the code to use CallbackList which simplifies the registration.

BUG=304341
R=benm@chromium.org, brettw@chromium.org, bulach@chromium.org, caitkp@chromium.org, isherman@chromium.org, mvanouwerkerk@chromium.org, nasko@chromium.org

Review URL: https://codereview.chromium.org/273523007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269795 0039d316-1c4b-4281-b951-d872f2087c98

Mark the "copy" target as a target function so it appears in the correct section of "gn help".

Use get_target_outputs() in the template example, since you should generall do this instead of process_file_template.

Update docs for process_file_template to state that you should use get_target_outputs if possible.

R=cjhopman@chromium.org

Review URL: https://codereview.chromium.org/270613006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269793 0039d316-1c4b-4281-b951-d872f2087c98

Also StubUserAccountsDelegate was replaced with real implementation, so now we have fully functional version of mirror UI on Chrome OS.

BUG=344844
TEST=manually

Review URL: https://codereview.chromium.org/256623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269792 0039d316-1c4b-4281-b951-d872f2087c98

GetPNaClResourceInfo() currently performs a 1 megabyte allocation. Though any
memory allocation can fail, this one is more likely due to its size.

This change mitigates this problem in two ways. If memory allocation fails, we
report an error and return early instead of using memory.

Additionally, this change checks the size of the file before performing a
memory allocation. This should lead to smaller allocations and more successful
plugin loads.

BUG=370965

Review URL: https://codereview.chromium.org/274673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269791 0039d316-1c4b-4281-b951-d872f2087c98

BUG=372381

Review URL: https://codereview.chromium.org/281433004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269790 0039d316-1c4b-4281-b951-d872f2087c98

Creation of a new signin_metrics class to track components/signin UMA.

BUG=357693
TEST=New histograms are called Profile.NumberOfAccountsPerProfile,
Signin.ReconcilerAddedToChrome and Signin.ReconcilerAddedToCookieJar.
There is also a UserCount called
AccountReconcilerDifferentPrimaryAccounts. These can be viewed in
chrome://histograms and chrome://user-actions respectively.
The Profile one can be viewed any time a profile is opened. The others
are best tested the first time you Sign In to Chrome, assuming you
already were signed in to google in the content area with 1 or more
accounts.

Review URL: https://codereview.chromium.org/270673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269789 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269786 0039d316-1c4b-4281-b951-d872f2087c98

commit 919148f94db54fc04d287eb6a42c0c36b166bbfa
Merge: e2ca3c3 84a5bd9
Author: Jonathan 'Wolf' Rentzsch <jwr.git@redshed.net>
Date:   Sun May 11 21:51:20 2014 -0500

    Merge pull request #16 from mark-chromium/patch-1

    [FIX] Stop using mach_host_self and host_page_size, fixing a port
    right leak. (Mark Mentovai)

commit 84a5bd929213b9e0f059d3bc8c5b738e9fe4e620
Author: Mark Mentovai <mark@chromium.org>
Date:   Fri May 9 16:40:10 2014 -0400

    Stop using mach_host_self and host_page_size, fixing a port right
    leak

    It is incorrect to use mach_host_self without disposing of the send
    send right to the host port with mach_port_deallocate when done with
    it. http://crbug.com/105513 shows the sorts of problems that can
    arise when send rights aren’t properly deallocated.

    mach_host_self was only used by mach_override to be able to call
    host_page_size. host_page_size is unnecessary, because it always
    returns a constant value, PAGE_SIZE, which is also known at
    user-land compile time. See libsyscall/mach/mach_init.c. User code
    is better off just using this macro directly, and not fumbling with
    the system calls to obtain and properly dispose of a send right to
    the host port.

    (You need to mach_port_deallocate the ports you get from
    mach_host_self and mach_thread_self, but you must not normally
    deallocate the one from mach_task_self, because mach_task_self is
    actually just a macro that references a global variable. It doesn’t
    add any port rights at all. See <mach/mach_init.h>. If you bypass
    the macro and call the real mach_task_self system call, you do need
    to call mach_port_deallocate, but this situation is incredibly
    rare.)

R=rsesek@chromium.org

Review URL: https://codereview.chromium.org/282523004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269785 0039d316-1c4b-4281-b951-d872f2087c98

This simplifies NexeLoadManager, which is getting pretty big. This also removes
an unused field from ProgressEvent, and adds a convenience function for posting
a task to dispatch a progress event from the main thread, which is often
necessary to ensure that progress events are posted to the DOM after other
state changes.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269362

R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/270453004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269784 0039d316-1c4b-4281-b951-d872f2087c98

BUG=360588
NOTRY=true

Review URL: https://codereview.chromium.org/284513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269782 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269781 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=173849:173856&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/273423006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269780 0039d316-1c4b-4281-b951-d872f2087c98

This makes it possible for the android_webview component to generate
strings.xml files from .grd files in the android_webview_build
configuration.

BUG=internal b/11505352
TESTS=compile
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/270633015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269779 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Removed uninitialized error supressions for WebCore::PinchViewport (https://codereview.chromium.org/276403002/)

Reason for revert:
Build bots haven't picked up new Blink rev with fix yet. Reverting until they do.

Original issue's description:
> Removed uninitialized error supressions for WebCore::PinchViewport
> 
> Should be fixed by r173871 http://crrev.com/280473002
> 
> TBR=zhaoqin@chromium.org
> BUG=372226
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269775

TBR=
NOTREECHECKS=true
NOTRY=true
BUG=372226

Review URL: https://codereview.chromium.org/280183003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269778 0039d316-1c4b-4281-b951-d872f2087c98

Should be fixed by r173871 http://crrev.com/280473002

TBR=zhaoqin@chromium.org
BUG=372226

Review URL: https://codereview.chromium.org/276403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269775 0039d316-1c4b-4281-b951-d872f2087c98

This will be selectable by clients that want to avoid I420 artefacts.

BUG=260879,134202

Review URL: https://codereview.chromium.org/261753013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269774 0039d316-1c4b-4281-b951-d872f2087c98

Tests checking for eroro message buble can be flaky, because on-screen message
can disappear before test checks for it. This CL adds special flag for tests.

BUG=339348

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268924

Review URL: https://codereview.chromium.org/268373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269773 0039d316-1c4b-4281-b951-d872f2087c98

Changing const char* kFoo to const char kFoo[]

Review URL: https://codereview.chromium.org/233713005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269772 0039d316-1c4b-4281-b951-d872f2087c98

The set of bookmark node initially visible can be controlled by the
embedder (on iOS only "Mobile" node is visible). The order of the
nodes depends on the visibility since the first node must be visible.

BUG=364044

Review URL: https://codereview.chromium.org/265853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269771 0039d316-1c4b-4281-b951-d872f2087c98

Clean up ServiceWorkerDatabaseTest using helper functions. Mechanical changes only.


BUG=n/a
TEST=content_unittests --gtest_filter=ServiceWorkerDatabaseTest.*

Review URL: https://codereview.chromium.org/282533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269770 0039d316-1c4b-4281-b951-d872f2087c98

Previously, AppListControllerTest's "centered" tests were actually
testing the non-centered app list mode (due to an uncaught semantic
merge conflict between SVN 268479 and 269208). Now the centered tests
run the app list in centered mode.

BUG=372268

Review URL: https://codereview.chromium.org/283443003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269769 0039d316-1c4b-4281-b951-d872f2087c98

BUG=349816

Review URL: https://codereview.chromium.org/277873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269768 0039d316-1c4b-4281-b951-d872f2087c98

as interfaces.

BUG=367094
R=rockot@chromium.org

Review URL: https://codereview.chromium.org/270323003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269767 0039d316-1c4b-4281-b951-d872f2087c98

Android uses gcc 4.8 for target on arm64, so -Wno-unused-local-typedefs
gets added to the gcc command line; unfortunately the host toolchain on
mac does not support this flag. We have no way to detect the host
toolchain version in the WebView build because we generate makefiles in
advance instead of on the build machine, so just hardcode an exception
until the instances of this warning can be fixed and this entire
conditional section removed.

BUG=321833

Review URL: https://codereview.chromium.org/277983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269766 0039d316-1c4b-4281-b951-d872f2087c98

Fixes an issue where transient untrusted state is reported as permanent.

BUG=362430
TEST=browser_tests

Review URL: https://codereview.chromium.org/271063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269765 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334149
R=haraken@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/273873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269764 0039d316-1c4b-4281-b951-d872f2087c98

Two failures were observed:

1. If the GPU process crashed between EstablishGpuChannel and
   CreateViewCommandBuffer, the channel would never be properly marked
   as lost. Now, if CreateViewCommandBuffer fails, mark the
   GpuChannelHost as lost on the renderer side. The RenderThreadImpl
   will then establish a new connection to the new GPU process.

2. In Issue 308675, support was added to allow Telemetry to navigate
   to about:gpucrash, specifically for this test. It turns out that
   each navigation from Telemetry was provoking *two* GPU process
   crashes. Depending on when they came in, the test would
   intermittently receive two lost context events and fail. Squelch
   the second debug URL handling in NavigationControllerImpl.

These fix the locally reproducible failures of this test.

BUG=365904
TEST=src/content/test/gpu/run_gpu_test.py context_lost --browser=debug --show-stdout -v --page-filter=WebGLContextLostFromGPUProcessExit --page-repeat=30

Review URL: https://codereview.chromium.org/277113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269763 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
This seems to have broken ResetFirstAfterBootTest.SuccessOnRollbackRequested on http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%282%29/builds/23801.

Original issue's description:
> Rollback option put behind the flag.
> 
> BUG=368860
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269753

TBR=nkostylev@chromium.org,merkulova@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=368860

Review URL: https://codereview.chromium.org/279203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269762 0039d316-1c4b-4281-b951-d872f2087c98

Now that blink side's landed and rolled we no longer need
HAS_SERVICE_WORKER_CONTEXT_DESTROYED ifdefs

BUG=366617
TEST=no functional changes

Review URL: https://codereview.chromium.org/273423003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269761 0039d316-1c4b-4281-b951-d872f2087c98

This is roughly how this works.
- Takes the bounds of the edge indicator in screen coords
  and convert to native coords
- If the location of mouse in native coords moves into this
  bounds, we need to warp the mouse.
- Convert the current mouse location in screen coords to the
  destination window's host coords. Adjust so that the location is inside the host window's bounds.

No flag. I'll simply flip the flag if I need to disable this on branch.

BUG=321699,306632
TEST=TBD

Review URL: https://codereview.chromium.org/270863005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269758 0039d316-1c4b-4281-b951-d872f2087c98

To distinguish serious failures from not-found cases.

BUG=None
TEST=unit_tests

Review URL: https://codereview.chromium.org/276313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269757 0039d316-1c4b-4281-b951-d872f2087c98

To abort as soon as possible when encoutering serious errors.

BUG=None
TEST=unit_tests

Review URL: https://codereview.chromium.org/278273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269756 0039d316-1c4b-4281-b951-d872f2087c98

BUG=341353

Review URL: https://codereview.chromium.org/276263004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269755 0039d316-1c4b-4281-b951-d872f2087c98

BUG=368860

Review URL: https://codereview.chromium.org/267393011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269753 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a basic version of a start page to the experimental app list.
This page contains a WebView that displays the Google Logo and a grey bar
which are currently only placeholders.

This CL also modifies the StartPage WebUI to have the google logo.

BUG=349727

Review URL: https://codereview.chromium.org/186483004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269752 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168147

Review URL: https://codereview.chromium.org/279143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269751 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269750 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=173842:173849&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/277233003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269749 0039d316-1c4b-4281-b951-d872f2087c98