GitLab

https://quiche.googlesource.com/quiche.git/+log/b5f2d72f536f..a89eee387569

$ git log b5f2d72f5..a89eee387 --date=short --no-merges --format='%ad %ae %s'
2019-11-22 wub gfe-relnote: (n/a) In quic::test::TestQuicSpdyServerSession, do not call Initialize() in constructor. Test only, not protected.
2019-11-21 bnc Move NoopQpackStreamSenderDelegate to qpack_test_utils.h.
2019-11-21 renjietang Change window_update frame's byte_offset to max_data to incorporate IETF spec.
2019-11-21 wub gfe-relnote: (n/a) Only enable QUIC MTU discovery in the server->client direction. No behavior change in GFE, not protected.

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

Change-Id: Ib3df7f9ef286727cb0f33938db2bd49ac785ebc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931496
Commit-Queue: Renjie Tang <renjietang@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718363}

This reverts commit aa147bcb.

Reason for revert: Fix compile on Android x64

Original change's description:
> Revert "Fill in the first pass of the parser to analyze hprof files."
>
> This reverts commit b30f46fd.
>
> Reason for revert: Compile error in hprof_buffer_android_unittest.cc on x64 bot.
> https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8896255126674550192/+/steps/compile/0/stdout
>
> Original change's description:
> > Fill in the first pass of the parser to analyze hprof files.
> >
> > The main purpose of the java heap profiler is to obtain a heap dump in
> > the form of an hprof file and then parse the hprof file. Currently,
> > there exists an empty parser that skips over everything in the hprof
> > file.
> >
> > With CL, we first parse each instance for given fields (object_id,
> > names, etc..) and then store these values in different instance
> > objects. We will be using these instance objects in the next CL which
> > is the second pass over.
> >
> > Bug: 1012072
> > Change-Id: Ibe249056c180dd07b907ada129898248c91cbaec
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898481
> > Commit-Queue: ssid <ssid@chromium.org>
> > Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
> > Reviewed-by: ssid <ssid@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#716986}
>
> TBR=nyquist@chromium.org,ssid@chromium.org,zhanggeorge@google.com
>
> Change-Id: Ic1a61810ab7d669b2f2fbae5786e30c17eff1970
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1012072
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926535
> Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#717040}

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1012072
Change-Id: I1064dd7e7d33002ae870ad632224fccc7547b09b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931264Reviewed-by: ssid <ssid@chromium.org>
Commit-Queue: ssid <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718362}

googletest will no longer support empty prefix
for parameterized INSTANTIATE_TEST_SUITE_P.
Adding "All" prefix to existing empty prefix test suites.

This CL was uploaded by git cl split.

R=jsbell@chromium.org

Bug: 1023677
Change-Id: I5a1ecdffd989113476f8e29b6625c2a0894446ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927020
Auto-Submit: Ilia Samsonov <isamsonov@google.com>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Ilia Samsonov <isamsonov@google.com>
Cr-Commit-Position: refs/heads/master@{#718361}

https://chromium.googlesource.com/angle/angle.git/+log/4c7db77e0185..f3d35f8f9c6f

git log 4c7db77e0185..f3d35f8f9c6f --date=short --no-merges --format='%ad %ae %s'
2019-11-22 courtneygo@google.com Suppress flaky failure with Win7/NVIDIA/D3D11

Created with:
  gclient setdep -r src/third_party/angle@f3d35f8f9c6f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: courtneygo@google.com
Change-Id: I81b40b357b550a851682e5ab86173e853b1cf91d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931172Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#718360}

This change creates a modified copy of CertNetFetcherImpl (renamed
to CertNetFetcherURLRequest) that uses URLLoader's (implemented by
the Network service) instead. This new version is called
CertNetFetcherURLLoader. It will be used by default in the
CertVerifyProc's created by the network service.

Bug: 1015164
Change-Id: I5dde69e3dba8b1abd7133c83c91f0601bb6e9074
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866194
Commit-Queue: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718359}

This was reverted because grit ran out of ID space and builds started failing.

Creates a WebUI-based Crostini Upgrader

The UI is behind the new crostini-webui-upgrader flag
(currently disabled by default)

The main areas for review are

calamity@:
html/js  - chrome/browser/chromeos/crostini_upgrader/
mojo and webui glue classes - chrome/browser/ui/webui/crostini_upgrader/

davidmunro@
crostini business logic - chrome/browser/chromeos/crostini/

In this CL, the optional container backup stage is stubbed, and will be
in a subsequent CL.

A suite of unit/browser tests are also currently lacking. I intend them for
follow-up CLs.


Bug: 930901
Change-Id: I6d3a63ffb319c762839a830ee76f4dfcc56445bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928383
Auto-Submit: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718358}

This reverts commit 3fb77161.

Reason for revert: trace collection timeout was increased to fix the
failures.

Original change's description:
> Reland "Disable failing tests on android-go_webview-perf"
> 
> This reverts commit 5d686312.
> 
> Reason for revert: turns out this was caused by a different patch afterall. 
> 
> Original change's description:
> > Revert "Disable failing tests on android-go_webview-perf"
> > 
> > This reverts commit 7a502f46.
> > 
> > Reason for revert: patch that caused the failures was reverted
> > 
> > Original change's description:
> > > Disable failing tests on android-go_webview-perf
> > > 
> > > Disabling the following tests on android-go_webview-perf:
> > > * system_health.common_mobile/browse:media:youtube:2019
> > > * system_health.common_mobile/browse:news:nytimes:2019
> > > * system_health.common_mobile/browse:news:cnn:2018
> > > 
> > > TBR=crouleau@chromium.org
> > > NOTRY=true
> > > 
> > > Bug: 1026822
> > > Change-Id: I2581e3c21158edff2563de628bfa41de7349271d
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927216
> > > Reviewed-by: John Chen <johnchen@chromium.org>
> > > Commit-Queue: John Chen <johnchen@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#717272}
> > 
> > TBR=crouleau@chromium.org,johnchen@chromium.org
> > 
> > Change-Id: I0cf407e4ec8f3a44afa229c9fae82c064d9bb9a0
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 1026822
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928322
> > Reviewed-by: Eric Seckler <eseckler@chromium.org>
> > Commit-Queue: Eric Seckler <eseckler@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#717618}
> 
> TBR=crouleau@chromium.org,eseckler@chromium.org,johnchen@chromium.org
> 
> Change-Id: I0c6f3f761c335df3463564ba84946735b552c713
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1026822
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928557
> Reviewed-by: Eric Seckler <eseckler@chromium.org>
> Commit-Queue: Eric Seckler <eseckler@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#717662}

TBR=crouleau@chromium.org,eseckler@chromium.org,johnchen@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1026822
Change-Id: Ia60707051f4f341bfa35dafd13338f49f2d046c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931151Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718357}

When making query to swarming for bots with dimension values, it is
possible that no bot is returned. Normally, the return JSON looks
like this:
{
  "death_timeout": "xxx",
  "items": ["list","of","bots"]
  "now": "xxx"
}
When there's no bot, the "items" key is gone:
{
  "death_timeout": "xxx",
  "now": "xxx"
}
In this case, we will see a KeyError in pre_run stage because we try to
read values using "items" key in perf_device_trigger.py:
  for bot in query_result['items']:
    ...

KeyError doesn't tell what is actually happening. To fix, we check this
key before using it. Then when no bot exists, we will see a message saying
there's not enough machines.


Bug: chromium:1027147
Change-Id: I38fe0e1a015e29d9b223515f49c527641bcebf60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929871Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718356}

Previously we disabled some vulkan_native_blink_web_tests due to them timing out on Linux+Intel

The root cause has since been fixed. So let's remove the Slow tag from them.

TBR=penghuang@chromium.org
TEST=vulkan_native_blink_web_tests
Bug: 1021575

Change-Id: Ibfed5fba8766d3b5fbc9867aa8c681125926d5d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930218Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718355}

The internal configuration name was changed. Update fieldtrial
configuration to match.

Bug: 333943
Change-Id: I70eb78ec4829788d78ef9c925ae2866cd54575d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929845Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718354}

This CL addresses two issues.

1: It corrects the problem outlined in https://crbug.com/546640 by
having the TestingProfile reside in a directory that outlives the task
environment.
2: It changes the creation of KeyedServices from explicit constructor
calls or deprecated functions to the preferred builder based approach.
(Recommended in the code at testing_profile.h:226)

This is done to prepare HistoryServiceUsesTaskScheduler activation.
This finch trial will soon become default and the changes it introduces
exposed the brittleness of this test.

Bug:661143

Change-Id: If9d1403a5486d0050ea218cfb0d28fc261a472f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926676
Commit-Queue: David Trainor <dtrainor@chromium.org>
Auto-Submit: Oliver Li <olivierli@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718353}

This migrates Utility processes to direct ChildProcess API usage instead
of bootstrapping IPC through the Service Manager.

As this is the last remaining use of Service Manager IPC to bootstrap
Content child processes, this also rips out a bunch of infrastructure
that existed only to support that.

Bug: 977637
Change-Id: I08e542f1d9f294bc1c387ea5845e8ba0d5a7d2b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919719
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718352}

DO NOT LAND: This is a silly change.

TBR=tbansal@chromium.org

Change-Id: Iad6a0f30a8bb82b7c008505ffcb899c2dd0b857f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931545Reviewed-by: Robert Ogden <robertogden@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718351}

Currently if there is more than one Chrome window, activating Chrome
from launcher does nothing.

The bug is less obvious in clamshell mode where the app list closes
immediately after Chrome icon activation. If the most recent active
app was Chrome (which is often the case), it looks like everything
worked correctly. However, if another window was active prior to
the app list opening, it will stay open after Chrome icon is activated.

It tablet mode the app list stays active and the bug is very obvious.

This is a regression introduced by http://crrev.com/c/1449104 which
did not take into account the fact that
BrowserShortcutLauncherItemController::ItemSelected is called both
when activating Chrome from shelf and from app list. This method should
be no-op only if called with multiple windows from shelf (but not other
sources).

Bug: 1026639
Test: manual, new browser test
Change-Id: I5c24339e97724018f65d919e2c95f143465ce505
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931146
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Auto-Submit: Vladislav Kaznacheev <kaznacheev@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718350}

This reverts commit 3d8fa26a.

Reason for revert: Sorry, looks like this is causing compile failures on the waterfall (https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/7869)

I don't know why the archive builders aren't on the CQ...

Original change's description:
> Support audio channel count and sample rate changes on Windows.
> 
> This fixes a TODO in AudioDeviceListenerWin on listening for
> property value changes... by listening for them in a completely
> different way.
> 
> Unfortunately forcing mono audio for accessibility doesn't
> generate IMMNotificationClient events, so we need to instead
> use the IAudioSessionEvents interface, but that can only be
> hung off a fully initialized IAudioClient... which is only
> done during WASAPI audio output setup.
> 
> So the original TODO is fixed by adding a 1-to-1 path for device
> changes (in addition to the 1-to-many path). We still need both
> paths since just switching your default device won't generate an
> IAudioSessionEvent notification, only an IMMNotificationClient
> event. Additionally fake and WaveOut based devices don't have a
> IAudioSessionEvents interface, so still need the old path.
> 
> Misc other cleanups:
> - Expands the AudioDeviceListenerWin unit tests.
> - Fixes broken --force-wave-audio switch in AudioManagerWin.
> 
> Fixed: 1020006
> TEST=property changes, mono audio changes, default changes work.
> 
> Change-Id: I257219a32cbcb22c1590aa07f82c6e5d4c7948e4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917091
> Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
> Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
> Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
> Reviewed-by: Henrik Andreasson <henrika@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#718342}

TBR=dalecurtis@chromium.org,tguilbert@chromium.org,henrika@chromium.org

Change-Id: I8d94920dde4716570db6148202a54d0ca11606c1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930189Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#718349}

This reverts commit e38327e1.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 718338 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2UzODMyN2UxZDQ5MDE5N2M5ZDdhMDk3Mjg5ZmVlN2FmMzhiMWZhN2UM

Sample Failed Build: https://ci.chromium.org/b/8896048495893501824

Sample Failed Step: compile

Original change's description:
> Spellcheck cleanups
> 
> Introduce a build flag for the remote spelling service, and stop
> compiling/instantiating SpellingServiceClient on platforms that
> don't use it (Android). Also try to reduce the number of platform
> ifdefs in spellcheck code, in favor of buildflag usage. Reduce
> the amount of code that's compiled but never used by removing
> several SpellCheckHostImpl methods on mac/win.
> 
> Also remove a couple of obsolete includes.
> 
> Change-Id: I5697a5d3f891f69159d5bba855ee72e11a3ca8be
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927412
> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
> Reviewed-by: Bo <boliu@chromium.org>
> Commit-Queue: Bo <boliu@chromium.org>
> Auto-Submit: Evan Stade <estade@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#718338}


Change-Id: Ia990162d2d72055c99af51fc165c52c4aa3fe1c9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929466
Cr-Commit-Position: refs/heads/master@{#718348}

BUG=1027769

Change-Id: I3cd13fb208b1118e49ce5f4e6576d94c9442abec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928235
Commit-Queue: S. Ganesh <ganesh@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718347}

This reverts commit af8f7390.

Reason for revert: FakeChromeIdentity is now a subclass of ChromeIdentity. So ChromeIdentity has to be compiled in test side when FakeChromeIdentity is used.

Original change's description:
> [iOS] Ensure no ChromeIdentity class is compiled in EG2 tests.
> 
> This will prevent unnecessary dependencies from being pulled to EG2
> tests.
> 
> Bug: 1015907
> 
> Change-Id: I45c5ec755761f1903b405542967c8a7321500ab5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929761
> Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#718290}

TBR=rohitrao@chromium.org,zhaoyangli@chromium.org

Change-Id: Id95e387ee91738ec277a2321133ba899b24a9902
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1015907
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931536Reviewed-by: Yun Liu <yliuyliu@google.com>
Commit-Queue: Yun Liu <yliuyliu@google.com>
Cr-Commit-Position: refs/heads/master@{#718346}

https://skia.googlesource.com/skia.git/+log/db80f6936cbc..3bc4235baa96

git log db80f6936cbc..3bc4235baa96 --date=short --no-merges --format='%ad %ae %s'
2019-11-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader f2c9ce1e08ed..c8d4d4254ca1 (15 commits)
2019-11-22 jvanverth@google.com Add checks for TextureSampler count in text GeoProcs.

Created with:
  gclient setdep -r src/third_party/skia@3bc4235baa96

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:None,chromium:1027314
Tbr: robertphillips@google.com
Change-Id: I8b4f577e9fbb2375f99534cb7e22ec8156ebd481
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930209Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#718345}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c50b0963e3f2..9dabaedfa33c

git log c50b0963e3f2..9dabaedfa33c --date=short --no-merges --format='%ad %ae %s'
2019-11-22 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/depot_tools@9dabaedfa33c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: agable@chromium.org
Change-Id: Icb3e8ab821d86eb5cfd1970909ae71589a74f342
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930210Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#718344}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e75a355406dc..9e32eb6fc6fc


Created with:
  gclient setdep -r src-internal@9e32eb6fc6fc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:None,chromium:None,chromium:None,chromium:None
Tbr: jbudorick@google.com
Change-Id: I976631707e0e77097a96c8deae0502ffd99e7613
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931476Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#718343}

This fixes a TODO in AudioDeviceListenerWin on listening for
property value changes... by listening for them in a completely
different way.

Unfortunately forcing mono audio for accessibility doesn't
generate IMMNotificationClient events, so we need to instead
use the IAudioSessionEvents interface, but that can only be
hung off a fully initialized IAudioClient... which is only
done during WASAPI audio output setup.

So the original TODO is fixed by adding a 1-to-1 path for device
changes (in addition to the 1-to-many path). We still need both
paths since just switching your default device won't generate an
IAudioSessionEvent notification, only an IMMNotificationClient
event. Additionally fake and WaveOut based devices don't have a
IAudioSessionEvents interface, so still need the old path.

Misc other cleanups:
- Expands the AudioDeviceListenerWin unit tests.
- Fixes broken --force-wave-audio switch in AudioManagerWin.

Fixed: 1020006
TEST=property changes, mono audio changes, default changes work.

Change-Id: I257219a32cbcb22c1590aa07f82c6e5d4c7948e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917091
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Henrik Andreasson <henrika@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718342}

This CL converts ClassInterface, StandaloneApp, IdentityTest,
ExposedInterface, BlockedInterface, AlwaysAllowedInterface from
connect.test-mojom to new Mojo types with using ReceiverSet,
PendingReceiver, and Receiver instead of BindingSet,
InterfaceRequest, and binding.

It also introduces a new variant of Connect() which takes callback
to Connector.

Bug: 955171
Change-Id: Ia7a1d5a48607018419b8b4d36887fee65f2f237c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930364Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Julie Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#718341}

No change to production behavior.

This extends https://crrev.com/c/1910811 by sending the toggled flag
state to a central service (which will, in a later CL, distribute this
information to the WebView implementation running within apps).

For simplicity, both the UI and the service maintain copies of the full
flag override state (rather than the UI sending only updates).

Bug: 981143
Test: run_android_webview_junit_tests -f *ServiceNamesTest.*
Change-Id: I8644c730a9641fe44d6177bca8019dd8060ca743
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923500Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Hazem Ashmawy <hazems@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718340}

Bug is simply an example of something that we are fixing
in trigger scripts codebase.

Bug: 1027147

Change-Id: Idfc990f9557ed618695dd6ea7b5fcc707ac33fe2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931141
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Auto-Submit: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718339}

Introduce a build flag for the remote spelling service, and stop
compiling/instantiating SpellingServiceClient on platforms that
don't use it (Android). Also try to reduce the number of platform
ifdefs in spellcheck code, in favor of buildflag usage. Reduce
the amount of code that's compiled but never used by removing
several SpellCheckHostImpl methods on mac/win.

Also remove a couple of obsolete includes.

Change-Id: I5697a5d3f891f69159d5bba855ee72e11a3ca8be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927412Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Auto-Submit: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718338}

This CL converts ShutdownTestService, ShutdownTestClient, and
ShutdownTestClientController to new Mojo types using PendingReceiver,
PendingRemote, Remote, and Receiver.

Bug: 955171
Change-Id: I3731946c426df305ac59657fa8c255485362a496
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930242Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Julie Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#718337}

This CL converts DeferredDestroyStrongBindingSet to new
Mojo types using UniqueReceiverSet.
It renames DeferredDestroyStrongBindingSet to
DeferredDestroyUniqueReceiverSet which holds UniqueReceiverSet
instead of StrongBindingSet.

Bug: 955171
Change-Id: Iaf5655eb7050d5c7db49745fec60a6e9a504a300
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930286Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Julie Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#718336}

TBR=meacer@chromium.org

Change-Id: I9adbb27ee0b80a0c589928d145b2c83b27349e38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931386Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718335}

This is a reland of 45cef59a

Original change's description:
> Move Renderer processes off Service Manager
>
> Migrates Renderer processes to use the simpler ChildProcess IPC
> interface in place of deprecated Service Manager IPC.
>
> Support for preloaded files in service manifest definitions is
> effectively removed in favor of explicit parameters on
> BrowserChildProcessHost and ChildProcessLauncher. The only use case (V8
> snapshot files) has been migrated from manifest data to a simple map
> definition, and it's used during renderer and utility process launching.
>
> After this CL, only utility processes remain to be moved off of Service
> Manager IPC.
>
> NOPRESUBMIT=true
>
> Bug: 977637
> Change-Id: I1d8205cb73ead904aa21b85d6cbee11cb3fc84f5
> Tbr: boliu@chromium.org
> Tbr: yucliu@chromium.org
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918375
> Reviewed-by: Martin Barbella <mbarbella@chromium.org>
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Commit-Queue: Ken Rockot <rockot@google.com>
> Cr-Commit-Position: refs/heads/master@{#717920}

NOPRESUBMIT=true

Bug: 977637
Change-Id: I9dd89104626ef73f81abd93c8a35310a2d6997a2
Tbr: boliu@chromium.org
Tbr: yucliu@chromium.org
Tbr: mbarbella@chromium.org
Tbr: avi@chromium.org
Tbr: rsesek@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930104Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#718334}

This change adds support to schedule when prediction model and host
model features are fetched from the remote Optimization Guide Service.
This change also updates naming for all fetch related permissions
checks to be not hint specific.

A future change will persist any models or host model features successfully
fetched.


Bug: 1001194
Change-Id: I412d2b36814cb1da092bab58c47419df277fddbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930052
Commit-Queue: Michael Crouse <mcrouse@chromium.org>
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718333}

This removes MC autoupgrades for blockable content (including
websockets) and adds a parameter to disable them for images. This
matches the behavior planned for launch.

Bug: 1025274, 1027686
Change-Id: Iaef5800c09368a547f6301c88208c535b60f9bdf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928239Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Auto-Submit: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718332}

This CL updates some of the scrolling tests with platform specific test
expectations. (Since MockScrollbars no longer exist). The CL also gets
rid of duplicated tests without losing coverage.

Bug: 953847
Change-Id: I0bf10ef0434f9630624f73d9deb3986bd67661cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925180Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Rahul Arakeri <arakeri@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#718331}

Using a ui::LatencyTracker to record all collected latency info
after drawing buffers have been swapped. This records a system health
metric (Event.Latency.ScrollBegin.Wheel.TimeToScrollUpdateSwapBegin4)
as well as the recording of latency info for debugging.

Bug: 992026
Change-Id: I904cbec84418426f06c9b237c2ead86566570302
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929264Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Chris Mumford <cmumford@google.com>
Cr-Commit-Position: refs/heads/master@{#718330}

Will delete unnecessary logs later.

Bug: 1026891
Change-Id: I56cbd4d73b5805418167c70ff142ce9a4a1e40a3
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929528Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Yun Liu <yliuyliu@google.com>
Cr-Commit-Position: refs/heads/master@{#718329}

Using wpt-import in Chromium 4d49b6d2.
With Chromium commits locally applied on WPT:
e83dd93c "Limit backtracking on regexp called from blink."
500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I2f5692c8f03714f6b05143f015c06aeaf05d2569
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929525Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#718328}

This adds a new chrome://connection-monitoring-detected page that
gives greater detail when Chrome detects known network interception
certificates.

Screenshots:
- Desktop: https://drive.google.com/file/d/14idB9uoKa4ezUqx-8VbtQJL0ayPWJwFJ/view
- Android: https://drive.google.com/file/d/1H2JMlxNcT2XVjb_ug-hsIRySoaFRTvqE/view

Bug: 1014711
Change-Id: Ic462a23c9d2e5fb3ca3ac4a1e6f1184d5d0ffc29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913715
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718327}

https://swiftshader.googlesource.com/SwiftShader.git/+log/c8d4d4254ca1..4584a9c2ccb9

git log c8d4d4254ca1..4584a9c2ccb9 --date=short --no-merges --format='%ad %ae %s'
2019-11-22 sugoi@google.com Handle new device extension properties

Created with:
  gclient setdep -r src/third_party/swiftshader@4584a9c2ccb9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:b/144945388
Tbr: swiftshader-team+autoroll@google.com
Change-Id: I58afe1273165df11ffc2c295bc245314b9e37153
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931274Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#718326}

This diverged from original implementation, which did not use such 250ms delay,
and is potentially causing issues when xrandr and scale factor change events
come in a short interval, as observed in crbug.com/1019344.

Rationale:

With delayed update, events are coalesced thus leading to issues when
DisplayObserver is waiting only for display metrics changes, e.g: scale factor
changes. This is what RenderWidgetHostViewAura does, in order to react to
system's scale factor changes and sync with the compositor, etc.

In this specific issue, the delayed display list update behaves as follows:

Assuming display list initially has a single display (Display 1). XRandR/Gtk
events start coming:

1. Display 2 added
2. Display 1 removed
3. Display 2 metrics changed (scale factor)

Then they are coalesced into (and delivered through DisplayObserver interface):

1. Display 1 removed
2. Display 2 added

So, RenderWidgetHostViewAura::OnDisplayMetricsChanged() is never called and it
gets out of sync with the compositor.

Bug: 1019344
Change-Id: Ic6a7b1264b5656d36a0b25fd7e3bc07ab419568a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930853
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718325}

Explain the change to the isFallback attribute in the configuration file
for AOSP.

Change-Id: I3ade53829a8b3726434c0dc7a982505715a6be95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931197
Commit-Queue: Richard Coles <torne@chromium.org>
Auto-Submit: Richard Coles <torne@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718324}