- 25 Aug, 2016 40 commits
-
-
ricea authored
A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to MakeUnique<Foo>(...). See the thread at https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k for background. To avoid requiring too many manual fixups, the change skips some cases that are frequently problematic. In particular, in methods named Foo::Method() it will not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because Foo::Method() may be accessing an internal constructor of Foo. Cases where MakeUnique<NestedClass>(...) is called within a method of OuterClass are common but hard to detect automatically, so have been fixed-up manually. The only types of manual fix ups applied are: 1) Revert MakeUnique back to WrapUnique 2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL correctly) 3) Add base:: namespace qualifier where missing. WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might change behaviour if Foo does not have a user-defined constructor. For example, WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>() creates an integer initialised to 0. git cl format has been been run over the CL. Spot-checking has uncovered no cases of mis-formatting. BUG=637812 Review-Url: https://codereview.chromium.org/2255123002 Cr-Commit-Position: refs/heads/master@{#414343}
-
brianderson authored
Disables the SGI_video_sync extension and assumes a vsync interval of 59.9Hz on Linux. Also adds an --enable-sgi-video-sync command line flag to re-enable the extension. Use of the extension on a thread other than the main GPU thread is encountering issues with Chrome's sandbox for certain combinations of Linux window managers and NVIDIA drivers. Before this patch, we were assuming a frequency of 60Hz on Linux and re-aligning the phase every 5 seconds. Since we can no longer align the phase, we assume a frequency of 59.9 Hz. On a 60Hz monitor, this avoids driver backpressure on the GPU thread at the cost of skipping a frame every 10 seconds. BUG=636644 Review-Url: https://codereview.chromium.org/2277883003 Cr-Commit-Position: refs/heads/master@{#414342}
-
lgarron authored
BUG=551728 TEST=For all tests below, first open DevTools to the Security panel overview. 1) Visit google.com and check that there is a green bullet point with the following summary and description: - Secure Connection - The connection to this site is encrypted and authenticated using a strong protocol (QUIC), a strong key exchange (ECDHE_RSA), and a strong cipher (AES_128_GCM). 2) Visit cbc.badssl.com and check that there is a gray info bullet point with the following summary and description: - Obsolete Connection Settings - The connection to this site uses a strong protocol (TLS 1.2), a strong key exchange (ECDHE_RSA), and an obsolete cipher (AES_256_CBC with HMAC-SHA1). 3) Visit cbc.badssl.com/mixed/script/ and check that there are two gray info bullet points: "Obsolete TLS cipher suite" and "Blocked mixed content". 4) Visit static-rsa.badssl.com and check that there is a gray info bullet point with the following summary and description: - Obsolete Connection Settings - The connection to this site uses a strong protocol (TLS 1.2), an obsolete key exchange (RSA), and a strong cipher (AES_256_GCM). 5) Visit https://tls-v1-0.badssl.com:1010/ and check that there is a gray info bullet point with the following summary and description: - Obsolete Connection Settings - The connection to this site uses an obsolete protocol (TLS 1.0), a strong key exchange (ECDHE_RSA), and an obsolete cipher (AES_128_CBC with HMAC-SHA1). Review-Url: https://codereview.chromium.org/1727133002 Cr-Commit-Position: refs/heads/master@{#414341}
-
grunell authored
Adds total number of render calls, similar to what's logged in AudioInputSyncWriter. This makes it easier to see the proportion of glitches. Review-Url: https://codereview.chromium.org/2270863002 Cr-Commit-Position: refs/heads/master@{#414340}
-
yosin authored
This patch converts "editing/execCommand/format-block-multiple-paragraphs-in-pre.html" to use w3c test harness to simplify test script for improving readability. BUG=n/a TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2277673002 Cr-Commit-Position: refs/heads/master@{#414339}
-
haraken authored
TBR=hiroshige@chromium.org BUG=640886 NOTRY=true Review-Url: https://codereview.chromium.org/2275213002 Cr-Commit-Position: refs/heads/master@{#414338}
-
aiolos authored
Revert of Roll src/third_party/catapult/ 06af11370..956b57099 (2 commits). (patchset #1 id:1 of https://codereview.chromium.org/2280473003/ ) Reason for revert: The Chromium autoroller thinks this patch failed and is trying to re-commit it. All subsequent rolls are failing to patch as a result. Original issue's description: > Roll src/third_party/catapult/ 06af11370..956b57099 (2 commits). > > https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/06af1137071d..956b570999cf > > $ git log 06af11370..956b57099 --date=short --no-merges --format='%ad %ae %s' > 2016-08-24 nednguyen [tracing] Fix implementation of TTI when new nav is detected > 2016-08-24 benjhayden Migrate sampleMetric from ScalarNumeric to Histogram > > BUG=630300 > > TBR=catapult-sheriff@chromium.org > > Committed: https://crrev.com/0ed4e89d70b8d462237dbf592bfa8fdd990d4ecc > Cr-Commit-Position: refs/heads/master@{#414320} TBR=catapult-sheriff@chromium.org,catapult-deps-roller@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=630300 Review-Url: https://codereview.chromium.org/2281433002 Cr-Commit-Position: refs/heads/master@{#414337}
-
nhiroki authored
This CL... 1) introduces ThreadState enum that represents a state of the worker thread, 2) stops accessing |m_globalScope| from the main thread for detecting worker thread initialization and instead checks ThreadState, 3) renames |m_started| and |m_terminated| with |m_requestedToStart| and |m_requestedToTerminate| in order to emphasize that these fields represent not a state of the worker thread but facts that the worker thread has been requested to start/terminate from the main thread, and 4) removes mention of |m_microtaskRunner| from a comment about |m_threadStateMutex| because the member is accessed only from the worker thread. BUG=638877, 640843 Review-Url: https://codereview.chromium.org/2268183005 Cr-Commit-Position: refs/heads/master@{#414336}
-
Lucas Garron authored
R=davidcadrian@gmail.com TBR=palmer@chromium.org BUG=638031, 639031, 638953 Review URL: https://codereview.chromium.org/2129543003 . Cr-Commit-Position: refs/heads/master@{#414335}
-
hirono authored
The CL adds a new wayland request 'pin_with_trusted_flag' that replaces the existing request 'pin'. The new request takes a trusted flag so that trusted apps can be allowed to enforce users to stay in pinned mode. The CL also adds new window state 'trusted_pinned' which will be used in further implementation to specify pinned state invoked by trusted apps. BUG=b/29325086 TEST=None Review-Url: https://codereview.chromium.org/2276443002 Cr-Commit-Position: refs/heads/master@{#414334}
-
xiaochengh authored
This patch cleans up the two overloads of the function as follows: SpellChecker::isSpellCheckingEnabledFor(const VisibleSelection&) is changed into a static function in SpellChecker.cpp since it does not have call site outside SpellChecker. SpellChecker::isSpellCheckingEnabledFor(const Node*) is absorbed by is wrapper SpellChecker::isSpellCheckingEnabledInFocusedNode(). BUG=n/a TEST=n/a; no behavior change Review-Url: https://codereview.chromium.org/2273253002 Cr-Commit-Position: refs/heads/master@{#414333}
-
posciak authored
Currently, V4L2VEA assumes that the first H264 bitstream buffer coming from the hardware encoder will contain exactly an SPS+PPS pair. It then caches that buffer and prepends its contents before each keyframe. It also uses it for the remainder of the session, even if additional/new SPS+PPS pairs are provided later on. However, the first buffer may contain additional NALUs, and only SPS+PPS should be extracted and used. Moreover, the SPS+PPS pair may change later on. Finally, some hardware encoders may support prepending each IDR with the header, without the need for V4L2VEA to handle this. This CL adds support for the V4L2_CID_MPEG_VIDEO_H264_SPS_PPS_BEFORE_IDR V4L2 control, which instructs the HW encoder to inject SPS+PPS pair before each IDR in the stream. If that control is supported, we do not have to inject the header ourselves. If the control is not supported, we need to keep injecting, however - instead of making the above assumptions - we parse the stream, cache the latest SPS and PPS, and inject them before any found IDR, if possible. The VEA unittest is also modified, to verify that the stream includes an SPS+PPS pair before each IDR. Also, remove usage of linked_ptr for clearer ownership management of buffers. BUG=639238 TEST=veatest on various ARM platforms Review-Url: https://codereview.chromium.org/2274493002 Cr-Commit-Position: refs/heads/master@{#414332}
-
timvolodine authored
Add spellcheck functionality to webview. Spellchecking feature will be enabled if the kEnableAndroidSpellChecker flag is present. Historical note: Blink used to have unified_textchecker_enabled setting which was false by default in android webview and needed to be enabled in order for spellchecking to work. It was recently removed in https://codereview.chromium.org/2235643002/ though. BUG=583616, 629609 Review-Url: https://codereview.chromium.org/2264633002 Cr-Commit-Position: refs/heads/master@{#414331}
-
alancutter authored
The size of the list can be read from the m_values vector, no need to store the size separately. Review-Url: https://codereview.chromium.org/2273233002 Cr-Commit-Position: refs/heads/master@{#414330}
-
azurewei authored
When the IME refreshes, we need to update the view of the list in IME menu. Saves the created ImeListView and updates it when get IME refreshing event. Add ImeMenuTrayTest.RefreshImeWithListViewCreated test. BUG=640432 TEST=Verified on local build. Review-Url: https://codereview.chromium.org/2271483003 Cr-Commit-Position: refs/heads/master@{#414329}
-
xiaochengh authored
SpellChecker::chunkAndMarkAllMisspellingsAndBadGrammar() does not really need a TextCheckingParagraph as its parameter; an EphemeralRange of text to check is sufficient. Hence, this patch changes its parameter from a TextCheckingParagraph to an EphemeralRange, simplifying code and improving performance by eliminating the overhead for finding the paragraph containing the text to be checked. BUG=n/a TEST=n/a; no visible change Review-Url: https://codereview.chromium.org/2273453003 Cr-Commit-Position: refs/heads/master@{#414328}
-
yosin authored
This patch converts "editing/execCommand/indent-empty-root.html" to use w3c test harness to simplify test script for improving readability. BUG=n/a TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2264283004 Cr-Commit-Position: refs/heads/master@{#414327}
-
kochi authored
The spec was changed for discussion at github issue: https://github.com/w3c/webcomponents/issues/548 BUG=640236 Review-Url: https://codereview.chromium.org/2277713002 Cr-Commit-Position: refs/heads/master@{#414326}
-
khushalsagar authored
Currently the BlimpCompositor is the compositor that owns the cc::Display and delegated frames from it are directed to the display by the BlimpDelegatingOutputSurface. The lifetime of the display and the surfaces system is tied to the lifetime of the cc::OutputSurface, which is tied to the lifetime of the native widget. This diverges from the behavior expected when Blimp is embedded in Clank, which owns the Surfaces system and holds the UI compositor, which is the parent compositor that will embed content from the BlimpCompositor. This patch adds a BrowserCompositor to the blimp app, which performs the work of the UI compositor in Chrome. This ensures that Blimp always shares its content using a cc::SurfaceLayer, and the embedder is expected to own the cc::Surfaces system and push this content to the cc::Display. BUG=639950 Review-Url: https://codereview.chromium.org/2266863003 Cr-Commit-Position: refs/heads/master@{#414325}
-
jbauman authored
The Swiftshader component is 32-bit only and doesn't work there (though it shouldn't really hurt to have it around). Review-Url: https://codereview.chromium.org/2273703004 Cr-Commit-Position: refs/heads/master@{#414324}
-
zmo authored
BUG=639145 TEST=https://github.com/KhronosGroup/WebGL/pull/1982 R=kbr@chromium.org,tkent@chromium.org,haraken@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2277603005 Cr-Commit-Position: refs/heads/master@{#414323}
-
yyanagisawa authored
BUG=314403 Review-Url: https://codereview.chromium.org/2278813002 Cr-Commit-Position: refs/heads/master@{#414322}
-
ianwen authored
When there is no download item available, there should be a View telling the user that the list is empty. Currently the download manger ui only shows a blank screen if there are no items. This CL fixes this. BUG=616324 Review-Url: https://codereview.chromium.org/2270233003 Cr-Commit-Position: refs/heads/master@{#414321}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/06af1137071d..956b570999cf $ git log 06af11370..956b57099 --date=short --no-merges --format='%ad %ae %s' 2016-08-24 nednguyen [tracing] Fix implementation of TTI when new nav is detected 2016-08-24 benjhayden Migrate sampleMetric from ScalarNumeric to Histogram BUG=630300 TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2280473003 Cr-Commit-Position: refs/heads/master@{#414320}
-
thomasanderson authored
BUG=638394 Review-Url: https://codereview.chromium.org/2274003002 Cr-Commit-Position: refs/heads/master@{#414319}
-
mariakhomenko authored
BUG=640734 Review-Url: https://codereview.chromium.org/2272863004 Cr-Commit-Position: refs/heads/master@{#414318}
-
qinmin authored
When OfflinePageDownloadBridge is created, it will load all the offline page items. However, openItem() can get called before all page items are loaded. This causes the native side unable to find the downloaded item. As a result, nothing happens when user clicks offline page download success notification. This CL waits for all the page items to get loaded before calling openItem(). BUG=640467 Review-Url: https://codereview.chromium.org/2272883004 Cr-Commit-Position: refs/heads/master@{#414317}
-
dgozman authored
It's used in ConsoleView messages and UISourceCodeFrame messages. BUG=none Review-Url: https://codereview.chromium.org/2272193002 Cr-Commit-Position: refs/heads/master@{#414316}
-
ricea authored
A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to MakeUnique<Foo>(...). See the thread at https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k for background. To avoid requiring too many manual fixups, the change skips some cases that are frequently problematic. In particular, in methods named Foo::Method() it will not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because Foo::Method() may be accessing an internal constructor of Foo. Cases where MakeUnique<NestedClass>(...) is called within a method of OuterClass are common but hard to detect automatically, so have been fixed-up manually. The only types of manual fix ups applied are: 1) Revert MakeUnique back to WrapUnique 2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL correctly) 3) Add base:: namespace qualifier where missing. WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might change behaviour if Foo does not have a user-defined constructor. For example, WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>() creates an integer initialised to 0. git cl format has been been run over the CL. Spot-checking has uncovered no cases of mis-formatting. BUG=637812 Review-Url: https://codereview.chromium.org/2254173002 Cr-Commit-Position: refs/heads/master@{#414315}
-
tsergeant authored
MD History is not launching in M54, so we are disabling it until after branch point. BUG=425625 Review-Url: https://codereview.chromium.org/2271533005 Cr-Commit-Position: refs/heads/master@{#414314}
-
shuchen authored
BUG=607425,517773 Review-Url: https://codereview.chromium.org/1925983002 Cr-Commit-Position: refs/heads/master@{#414313}
-
ricea authored
A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to MakeUnique<Foo>(...). See the thread at https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k for background. To avoid requiring too many manual fixups, the change skips some cases that are frequently problematic. In particular, in methods named Foo::Method() it will not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because Foo::Method() may be accessing an internal constructor of Foo. Cases where MakeUnique<NestedClass>(...) is called within a method of OuterClass are common but hard to detect automatically, so have been fixed-up manually. The only types of manual fix ups applied are: 1) Revert MakeUnique back to WrapUnique 2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL correctly) 3) Add base:: namespace qualifier where missing. WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might change behaviour if Foo does not have a user-defined constructor. For example, WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>() creates an integer initialised to 0. git cl format has been been run over the CL. Spot-checking has uncovered no cases of mis-formatting. BUG=637812 Review-Url: https://codereview.chromium.org/2254833003 Cr-Commit-Position: refs/heads/master@{#414312}
-
haraken authored
This reverts commit 693c002f. This CL broke compilation of Chrome OS Debug: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20%28dbg%29/builds/78413 BUG= TBR=xiaoyinh@chromium.org NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2271223003 Cr-Commit-Position: refs/heads/master@{#414311}
-
msw authored
Revert of Add POINTER_TYPE_ERASER to EventPointerType (patchset #5 id:80001 of https://codereview.chromium.org/2235933002/ ) Reason for revert: Broke the build: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder/builds/45081/steps/compile/logs/stdio ../../ash/wm/stylus_metrics_recorder.cc:62:11: error: enumeration value 'POINTER_TYPE_ERASER' not handled in switch [-Werror,-Wswitch] Original issue's description: > Add POINTER_TYPE_ERASER to EventPointerType > > This pointer type can be used by graphics tablets, frequently the > back-side of a stylus. > > BUG=636458 > TEST=Use rubber tool and watch generated mouse events. > > Committed: https://crrev.com/b90b789aea11dd97a7daa98bec8dd96d2f89f205 > Cr-Commit-Position: refs/heads/master@{#414146} TBR=reveman@chromium.org,sadrul@chromium.org,spang@chromium.org,denniskempin@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=636458 Review-Url: https://codereview.chromium.org/2278033003 Cr-Commit-Position: refs/heads/master@{#414310}
-
achuith authored
BUG= Review-Url: https://codereview.chromium.org/2276183003 Cr-Commit-Position: refs/heads/master@{#414309}
-
yosin authored
This patch converts "editing/execCommand/4641880-2.html" to use w3c test harness to simplify test script, and renames to "indent_at_end_of_paragraph.html" to provide hint what this test script verifies, for improving readability. BUG=n/a TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2267363005 Cr-Commit-Position: refs/heads/master@{#414308}
-
haraken authored
As discussed in blink-dev@ (https://groups.google.com/a/chromium.org/d/topic/blink-dev/kk4VX0xRB7I/discussion) and platform-architecture-dev@ (https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/Zc12k91NTFk/discussion), there is no reason we have to shut down the renderer gracefully. It's just causing use-after-free bugs and wasting performance. This CL removes a graceful shutdown sequence from TestingPlatformSupport. BUG=639244 Review-Url: https://codereview.chromium.org/2279563003 Cr-Commit-Position: refs/heads/master@{#414307}
-
tkent authored
setSelectionRange(s, e) unexpectedly called the four-argument version of HTMLTextFormControlElement::setSelectionRange() with SelectionHasNoDirection. So it set "none" direction without EditingBehavior check. This CL renames the implementation function of web-exposed setSelectionRange() to setSelectionRangeForBinding(), and makes its third argument optional so that seSelectionRange(s, e) calls it. On non-macOS platforms, two tests in textfieldselection-setSelectionRange.html correctly fail. BUG=640861 Review-Url: https://codereview.chromium.org/2274103002 Cr-Commit-Position: refs/heads/master@{#414306}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/168261287136..9d08cbc8c613 $ git log 168261287..9d08cbc8c --date=short --no-merges --format='%ad %ae %s' 2016-08-24 fmalita Experimental parsing expression grammar (PEG) template library 2016-08-24 bsalomon Update GrShape test to allow more flexible shape creation. 2016-08-24 mtklein GN: misc 2016-08-24 mtklein We can't infer the right type for voidp for old png_jmpbuf() 2016-08-24 halcanary SkPDF: set SK_SFNTLY_SUBSETTER uniformly CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=bungeman@google.com Review-Url: https://codereview.chromium.org/2277113002 Cr-Commit-Position: refs/heads/master@{#414305}
-
xiaoyinh authored
1. Number of “down” events generated by stylus/touch/mouse 2. Number of “down” events received by clamshell vs touchview BUG=630070 Review-Url: https://codereview.chromium.org/2270173002 Cr-Commit-Position: refs/heads/master@{#414304}
-