- 27 Nov, 2019 40 commits
-
-
Yuri Wiitala authored
Includes trivial changes to ChromeTlsConnectionFactory, after Open Screen API changes. https://chromium.googlesource.com/openscreen/+log/8e6db3b055ba..fddca10f23f5 $ git log 8e6db3b05..fddca10f2 --date=short --no-merges --format='%ad %ae %s' 2019-11-26 miu Remove dependencies on openssl from platform/api. 2019-11-26 mfoltz [Open Screen] Move osp/ code into openscreen::osp namespace. 2019-11-26 btolsch Add virtual connection routing 2019-11-22 miu Replace OSP_DCHECK→assert to remove many platform/base deps on util/. 2019-11-23 miu Remove RepeatingFunction, use Alarm instead. 2019-11-25 miu Network interfaces platform API: Separate structs from API. 2019-11-21 rwkeane mDNS: Add Comparison Operators 2019-11-22 miu Move streaming/cast/* to cast/streaming/* and cast/standalone_receiver/* 2019-11-21 fdegans Fix a build issue for platforms with different host and target toolchains. 2019-11-20 rwkeane mDNS: Fix mDNS Receiver Bug 2019-11-20 miu Move platform/api/internal/logging_macros.h → util/logging.h Created with: roll-dep src/third_party/openscreen/src TBR=mfoltz@chromium.org Change-Id: I5348d0dd196790c25d3576734df66869d6d77799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938455Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#719490}
-
Michael Spang authored
This patch is corrupt: patch: **** malformed patch at line 54: return PR_FALSE; Bug: 1027853 Change-Id: I8cee1172c2dbd5abe28f65c648df343a0c91d882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937464Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#719489}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/341d41ba593d..9a5941edd0cf git log 341d41ba593d..9a5941edd0cf --date=short --first-parent --format='%ad %ae %s' 2019-11-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@9a5941edd0cf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I98bcb6941b2c919c41fc0625edf8be5fddcc49db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938436Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719488}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dca6bba47d07..415874734c70 Created with: gclient setdep -r src-internal@415874734c70 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I5323c4ee075690977252045376f256f7ed532a19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938437Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719487}
-
tby authored
We have a lot of dead code behind unused feature flags from past experiments in the search ranking codebase, so I'm going to do some clean up CLs. This one removes the utility code for expanding omnibox result subtypes, used for the original cat model. Bug: 1028447 Change-Id: I2f88c68e08505edbc559b7bae63310c2b850c8a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935629Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#719486}
-
Changwan Ryu authored
Adding a simple script to run simpleperf for WebView. Unfortunately for WebView, there is no easy way to symbolize the native stack output. This is a somewhat quick and dirty workaround to use stack script to do the post-processing on the original report HTML file that simpleperf produces. Bug: 1015236 Change-Id: Ica49b8af3af809162d2f895663c37f913c646028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929765Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Andrew Luo <aluo@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#719485}
-
Demetrios Papadopoulos authored
Move Settings subpages currently residing in the main module to the lazy module. This change further reduces the amount of code (both JS and HTML) that is part of the main module. Previously it was assumed that only elements in the "Advanced" section resided under the lazy_load.html module. With this change, subpages that are part of the basic module are also moved to lazy_load.html. The change in main_page_behavior.js is necessary to ensure that subpages are force loaded before we attempt to display them. Numbers from Linux build (before -> after): vulcanized.html 298K -> 239K, -59K, -19.8% crisper.js 346K -> 285K, -61K, -17.6% lazy_load.vulcanized.html 149K -> 207K, +58K, +38.9% lazy_load.crisper.js 179K -> 240K, +61K, +34.1% In this CL intentionally not touching any ChromeOS specific subpages (will address in follow up CL). Bug: 1026064 Change-Id: I3b1ef541ce9d6e3a267e0b2434154c632b0b1a3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922295 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#719484}
-
Fergal Daly authored
All other sensors remain blocklisted. Bug: 1024716 Change-Id: I3548648fb85b71ceb2d4b5808c63fbf9be5a7402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915643 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#719483}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1ef02beb6e51..f9d71508e42b git log 1ef02beb6e51..f9d71508e42b --date=short --first-parent --format='%ad %ae %s' 2019-11-27 crouleau@chromium.org [Telemetry] Fix abridged-story-set bug. Created with: gclient setdep -r src/third_party/catapult@f9d71508e42b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:965158 Tbr: skyostil@google.com Change-Id: I9f613457213a34da5999cfb6228f6642093cd78a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938432Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2a6b3b1f7f2d..c363982eeab3 git log 2a6b3b1f7f2d..c363982eeab3 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 steveanton@webrtc.org Convert proxy.h helper classes to variadic templates Created with: gclient setdep -r src/third_party/webrtc@c363982eeab3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib8f425a0d98033ed3f24d1fa488b0e008ba6d537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938431Reviewed-by:
-
Jay Harris authored
This makes file handling paths more consistent across different operating systems we support file handling on. The intention is to make the logic for enabling/disabling file handling for PWAs as similar as possible, which should simplify the logic we need to implement for origin trials. Bug: 1028448 Change-Id: I3ca522bc804e1bded96f070c2d0775a1600b12b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935296 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#719480}
-
Bin Wu authored
https://quiche.googlesource.com/quiche.git/+log/a89eee387569..7e8ae0dee24d $ git log a89eee387..7e8ae0dee --date=short --no-merges --format='%ad %ae %s' 2019-11-26 renjietang Remove redundant private keyword. 2019-11-26 wub gfe-relnote: (n/a) In QuicTimeAccumulator, change a "static constexpr data member" to a "static constexpr function". No behavior change, not protected. 2019-11-26 renjietang Remove QuicSession::SendRstStreamInner() because the |close_write_side_only| code paths share so little with each other. 2019-11-26 bnc Do not call MarkConsumed() from OnHeadersFramePayload() after decoding error. 2019-11-26 quiche-dev Adds a unit test demonstrating that SpdyHeaderBlock can store header names containing uppercase characters. 2019-11-26 wub gfe-relnote: (n/a) Change member initializer list to default member initializers in QuicConnectionStats. No behavior change, not protected. 2019-11-25 wub Internal QUICHE change 2019-11-25 wub gfe-relnote: (n/a) Deprecate --gfe2_reloadable_flag_quic_bbr2_fix_inflight_bounds. 2019-11-25 wub gfe-relnote: For server side QUIC connection, mark version_negotiated_ earlier. Protected by --gfe2_reloadable_flag_quic_version_negotiated_by_default_at_server. 2019-11-25 wub gfe-relnote: (n/a) Refactor Bbr2ProbeBwMode::OnCongestionEvent such that it only has one return point. No behavior change, not protected. 2019-11-25 wub gfe-relnote: (n/a) Do not call Initialize() in QuicTransportSimpleServerSession's constructor. Not used in production, not protected. 2019-11-24 wub gfe-relnote: Refactor how QuicConnectionStats.slowstart_duration is calculated in QUIC BBR1, and start populate it in QUIC BBR2. Not protected. (Worst case we get some incorrect values in transport connection stats) Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=rch@chromium.org Change-Id: I35ddd5af3c98af640a888bc8792d411c0a6c8ff0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937656 Commit-Queue: Bin Wu <wub@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#719479}
-
Jiewei Qian authored
Fixed: 1026452 Change-Id: I705bde13f9f3cc6c45d5ef9365cb9c685a07c5f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933849 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Stephen Lin authored
R=pkasting@chromium.org Bug: 1028831 Change-Id: I8a01cf3454ca10e8af91279cd43c341a0e7feb40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938456 Auto-Submit: Stephen Lin <stephenlin@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#719477}
-
Victor Costan authored
Looking into two crashers revealed misconceptions in the initial Cookie Store API implementation for change events in service works. This CL reworks the API surface and brings it closer to other features. The current API shape is that a SW version specifies the cookie changes it's interested in by calling subscribeToCookieChanges() on the SW global scope. getChangeSubscriptions() is available on the SW global scope, and reflects the cumulative effect of all subscribeToCookieChanges() calls during the install event. Implementation errors aside, this API shape doesn't have a simple model for continuously monitoring a cookie's change -- in the window between deactivating an old SW version and activating the new version, there is no obvious list of cookie change subscriptions. The new API shape brings Cookie Store in line with the other SW APIs. Cookie change subscriptions are associated with the SW registration, and can be managed using registration.cookies.{subscribe,unsubscribe,getSubscriptions}(). Unlike other SW APIs, the registration's subscriptions can be managed from the SW itself, as well as from windows. We expect that most applications will prefer to manage subscriptions from the SW code. This exposes a rough edge -- a registration cannot be modified until the first version of a SW is installed, so the methods listed above will fail during a SW's first install event, but succeed during later install events. We intend to evaluate the impact of this rough edge in an Origin Trial. Associated spec change: https://github.com/WICG/cookie-store/pull/111 Bug: 729800, 956732, 963042 Change-Id: I106a7d9b2e50a7304c5ad126e0f699ecac1de531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837146 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Staphany Park <staphany@chromium.org> Cr-Commit-Position: refs/heads/master@{#719476}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5e94b80c348b..341d41ba593d git log 5e94b80c348b..341d41ba593d --date=short --first-parent --format='%ad %ae %s' 2019-11-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@341d41ba593d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ibbe60f0ca3f6a701d0035cb0ec207ba301b848d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938210Reviewed-by:
-
Sunny Sachanandani authored
This CL adds support for preventing crashes when using single buffered canvas resource provider in more cases such as getImage, commit, etc. It also fixes a potential bug due to recent refactoring that switched the order of swap chain present and drawing buffer resource export. Also adds some pixel tests for drawImage due to which a bug with y flip in low latency 2d canvas was found and fixed. Bug: 1015643 Change-Id: I9c8ff3a6f4b3f78488ab0543e1b8b59c0f20a709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867376 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#719474}
-
Collin Baker authored
When the WebUI tab strip's WebContents gains focus, the focused TextInputClient changes while the focused View does not. This causes text input to stop working in the omnibox despite it having Views-focus. This blurs and re-focuses the currently focused View. For the Omnibox, this makes it re-install itself as the focused TextInputClient. This is a workaround and should be removed once bug 994350 is fixed. Bug: 1027375, 994350 Change-Id: I2be055110535dc6164a7d31a64a3cf503fae7a7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935729Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#719473}
-
Wez authored
Replacing hyphens with underscores in package target names is not necessary, and causes our GN target names to differ from those used in the Fuchsia build, creating more scope for clashes or other issues. Bug: fuchsia:42135 Change-Id: I036e851ddf802b12dce4933a8c18292e34eff7c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937910 Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#719472}
-
John Chen authored
It required too much boilerplate code to write a unit test case that calls a WindowCommand. Add a convenience function to make it easier. Change-Id: I30afb834269877afc833f188f64383731547d9ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938458 Commit-Queue: John Chen <johnchen@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Auto-Submit: John Chen <johnchen@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#719471}
-
Gang Wu authored
In this patch. 1. Add IPH for home button. 2. set null for callback of tabswitcher to avoid double click. 3. Remove buildForView in FeatureHighlightProvider.java, which is not used any more. Bug: 1021970, 1028470 Change-Id: Ieac6f2b86d174dedc5c11e0c5856986f25c7c757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929104 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#719470}
-
Javier Ernesto Flores Robles authored
Enable the help action to open a new view controller containing more info related to the feature. More info in https://docs.google.com/presentation/d/16XlBDqPZ5dQ0hRyaOn7r6G3apqrpi2Ng0VUUnoX3o4M Screenshots: attached in bug Bug: 1028095 Change-Id: I651c7e44254d37dff9d525ffdc47fe723311b5de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937371Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#719469}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/88752889c721..c373dfd84194 git log 88752889c721..c373dfd84194 --date=short --first-parent --format='%ad %ae %s' 2019-11-26 m.maiya@samsung.com Vulkan : Handle dirty state correctly when there are muiltiple VAOs Created with: gclient setdep -r src/third_party/angle@c373dfd84194 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: I3709383f45918a9046935ef766c796b32d7d592a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938197Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0f6ef7e793d5..dca6bba47d07 Created with: gclient setdep -r src-internal@dca6bba47d07 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I6765d216956979367de45a286bcdbee1815d916d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938199Reviewed-by:
-
Maggie Chen authored
(1) Added two histograms - GPU.WatchdogThread.ExtraThreadTime(Windows) and GPU.WatchdogThread.WaitTime. Record the extra time given to the GPU main thread before it makes a progress. (2) Fixed a bug that it fails to determine if the watchdog is in the stage of power_resume, foregrounded or a normal situation. Bug:988344, 949839 Change-Id: Idc0f9d3c13330ace99c5566dc8da84578c22822e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935209 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
-
Kevin Babbitt authored
This is a reland of 701b32b0 Reason for revert: Failing Win7 accessibility tests Fix: Update expectation files for Win7 tests Original change's description: > Include raw view elements in UI Automation tree dumps > > While working on tuning which nodes we include in the UI Automation > control and content views, I discovered that our tree dumper was only > dumping nodes in the control view. This CL applies a filter to dump the > raw view, which is a superset of the control view, giving us dumps that > are more complete. > > R=iapres@microsoft.com > > Bug: 1028345 > Change-Id: I98d53285abb77eb8490903f85a2c21e63e1f8c33 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935027 > Reviewed-by: Ian Prest <iapres@microsoft.com> > Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#718915} Bug: 1028345 Change-Id: I95196087e3633bab9bdeb0879ad4bf31a5f19c9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935212 Auto-Submit: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Ian Prest <iapres@microsoft.com> Commit-Queue: Ian Prest <iapres@microsoft.com> Cr-Commit-Position: refs/heads/master@{#719465}
-
Tomasz Wiszkowski authored
TBR=hnakashima@chromium.org Bug: 1028821 Change-Id: I8d5b9d9a92f9ae4bd5d587fa2b4bcb4ad3ddc960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938044Reviewed-by:
Ender <ender@google.com> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#719464}
-
Yuchen Liu authored
The struct contains two bitmaps for passthrough codecs' properties: -- Supported bitstream codecs -- A bit mask specifying which of the corresponding codecs support spatial rendering This allows renderer process to get more information on passthrough codecs from browser process. Merge-with: eureka-internal/336787 Bug: internal b/139027108 Test: Build, unit test Change-Id: I834ac35abc827bed9618b508e89209333e31afbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922981 Commit-Queue: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#719463}
-
Vikas Soni authored
SurfaceControl was currently using AHardwareBuffer dimensions as a valid region of pixels to calculate src rect. This do not work always since actual region of valid pixels could be smaller than the buffer dimensions. Hence use valid region of pixel instead of buffer dimensions. Bug: 1027766 Change-Id: Ic289712b71b22be2fc645c771ddcb297b1c6687c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929632Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#719462}
-
Owen Min authored
Disable WebViewTest, Dialog_TestConfirmDialogDefaultGCCancel on Win, Linux and ChromeOS Disable WebViewAPITest.TestDialogConfirmDefaultGCCancel on all platforms These tests are timeout. Bug: 937461 Tbr: lfg@chromium.org Change-Id: I46d846e07ae04ed9077fb9a167f3fe625b335c69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937667 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#719461}
-
Tim Song authored
The current TrayBubbleView::Delegate implementation is causing the message center to be activated before it is ready, so we will just use the default stub implementation. Change-Id: Ibc73de7d1516d2ebd72e870ab5d3db3963887845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938253Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#719460}
-
mark a. foltz authored
Removes code for the following launched features: - kEnableCastDiscovery (and associated field trial params) - EnableViewsDialog() - dial-media-route-provider flag We can't remove the kDialMediaRouteProvider feature until tests that disable it are fixed. BUG=900723,969091,969098,1028753 Change-Id: I5bfdf406ee1aababd1f65f1ec050b094cfd02bed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937138 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#719459}
-
Sara Kato authored
Follow-up of crrev/c/1903171 to make GetWindowID() return an optional. The window_id variable is also an optional. Bug: None (follow-up CL) Test: Do not observe crash in crbug/1020413 Change-Id: Ic3dd6a009871c725bbb97e0a565d7eec84e7c362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930532 Commit-Queue: Sara Kato <sarakato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#719458}
-
Alex Danilo authored
CL:1935567 changed the focus behavior to take focus on mousedown if some other button was currently focussed. Make the menu button take focus on mousedown for the case where a <cr-input> element is currently focussed. Extend unit test to cover the 'cr-input' case. Bug: 1028461 Tests: browser_test --gtest_filter="*MultiMenu" Change-Id: I89b067d2eafd547363bbcf289124f0253a87b9c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937948 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#719457}
-
Dan Beam authored
Bug: 877109 Change-Id: I8131723663b31439f3c809e433eb59716f25df33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936462 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#719456}
-
Ilya Sherman authored
We strongly discourage histograms that have an expiry date more than 1 year out. Also, add a link to the design doc for automatic expiry date management for histograms that we can detect as actively in use. R=bcwhite@chromium.org Bug: none Change-Id: Ifcfcd831c80e047799be49d6c14d21ba4bb4e49f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935728 Commit-Queue: Ilya Sherman <isherman@chromium.org> Auto-Submit: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#719455}
-
Jing Wang authored
1. Add an extra error param to GetEngineIfActive, so that we can tell if it fails because the engine is unavailable or inactive. 2. Add LOGs for engine errors. 3. Add error handling to more functions. 4. Add some helper functions to reduce code duplication. 5. Minor change on constants name for readability. 6. Disable some browser tests, they were actually testing nothing before (because there was no active engine, they actually skipped everything...). Eventually we should rewrite those tests in the new fashion as https://cs.chromium.org/chromium/src/chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc R=keithlee, shend, shuchen Bug: 1024606 Change-Id: I9902e42a472122c5c1a02c36e70f71b52cdd80d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933855Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Keith Lee <keithlee@chromium.org> Commit-Queue: Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#719454}
-
Adrienne Walker authored
This changes the "reading blobs" part of IndexedDB to use the storage.mojom.BlobStorageContext mojo interface for creating file-backed blobs. It uses this mojo interface from the idb task runner, owned by the IndexedDBDispatcherHost. CreateAllBlobs no longer can fail (as all callsites already check that the dispatcher host exists), which cleans up some code as well. Instead of having files, they use the BlobDataItem(Reader) types to provide the file information to the blob system. This also frees IndexedDB in the future to back these blobs in any way that it chooses, not necessarily via files. Because ShareableFileReference is used by both the browser and in IndexedDB, a new way of tracking live file references is used. IndexedDBDispatcherHost has a map of file paths to active BlobDataItemReaders, and calls the release callback when all the mojo pipes to that reader have been closed. This lets ShareableFileReference continue to live on the IO thread for the browser use cases and will let IndexedDB more easily move to the storage service without this dependency. The followup to this cl is to change IndexedDBBlobInfo to use blob remotes instead of BlobDataHandle and to return clones of those remotes rather than using BlobImpl::Create directly. Bug: 1022214 Change-Id: Ia1abc519fd5877aaf2313e45d0daea4a38c52d7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902474 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#719453}
-
Daniel Rubery authored
This CL changes the structure of the reporting event for large unscanned files. Future CLs will report this event with additional reasons. Bug: 1014949 Change-Id: I8e75fd9c6bb55b09fd3b72553a636991d37d4b39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935488 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#719452}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7a9a092708f1..2a6b3b1f7f2d git log 7a9a092708f1..2a6b3b1f7f2d --date=short --first-parent --format='%ad %ae %s' 2019-11-26 peah@webrtc.org Correcting the analog AGC re-initialization at device changes Created with: gclient setdep -r src/third_party/webrtc@2a6b3b1f7f2d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I7fe11d131cea9d08de5ad1a88ea1164c5efd5ff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938189Reviewed-by:
-
