GitLab

The 'wakeup device' tap gesture should happen on
double tap while in screen reader mode, not single
tap.

Bug: None
Test: Manual
Change-Id: I683f2d8859d1b2ab127cfa57883246bdda844e68
Reviewed-on: https://chromium-review.googlesource.com/1176214Reviewed-by: Kevin Schoedel <kpschoedel@chromium.org>
Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Commit-Queue: Randy Rossi <rmrossi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583373}

Fixes two issues which were leading to failures in
content_shell_test_apk:

1) We weren't correctly linking in the Android external begin frame
source java code into content shell, leading to crashes due to class
resolution failure.

2) Scroll tests assume that the browser is notified of every scroll
offset change, whether or not it impacts the UI. As an optimization,
SurfaceSync/Viz doesn't send this data unless needed. Adds a test
only hook to always send data allowing for test inspeciton.

Note that this addresses all but one remaining failure in:
org.chromium.content.browser.VSyncPausedTest#testPauseVSync

Bug: 871774, 871772
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I031d6616bcef11d302b6ecd43ee75586fbae8d71
Reviewed-on: https://chromium-review.googlesource.com/1173736Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583372}

TBR=wjmaclean@chromium.org
NOTRY=true

Bug: 874556
Change-Id: I3118312936415efcdbf4c5054f96d8a7a04b236c
Reviewed-on: https://chromium-review.googlesource.com/1176341Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583371}

This CL is adding trace events under the tracing category "safe_browsing"
to determine whether or not chrome cleanup tool is running.

This is useful to determine if the cleanup tool scanning/cleaning is
affecting chrome by looking to the slow-reports. We currently can't
determine whether or not the tool is running.

R=csharp@chromium.org
CC=etienneb@chromium.org

Bug: 874448
Change-Id: I4b54ea470caab6ce63542bedd1169ab667aac008
Reviewed-on: https://chromium-review.googlesource.com/1176137Reviewed-by: Chris Sharp <csharp@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583370}

The MaybeSendSyntheticTapGesture can be called in PreProcessMouseEvent,
in which case the TouchActionFilter::allowed_touch_action_ has no value
and will result in a crash.

This CL set the allowed_touch_action_ to auto to fix the issue. A
browser test is added.

Bug: 873211
Change-Id: If776a93fe2c8f7a311a10bc0fec42cda15d0ae9a
Reviewed-on: https://chromium-review.googlesource.com/1169585
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583369}

This allows a passable interface separate from NetworkContext that can
be passed to places where NetworkContext is not easily available. The
old NetworkContext::ResolveHost still exists as a shortcut as it is
trivially implemented using an internal HostResolver.

Implementation mostly consisted of moving the ResolveHost code from
NetworkContext to the new class and adding a bit of code in
NetworkContext to manage ownership of the HostResolver objects.

Bug: 821021
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I2cbb675bc584783a4add17ad7d8a6701dbaf9098
Reviewed-on: https://chromium-review.googlesource.com/1158618Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583368}

When a <select size=1> receives focus, a focus event should be fired on
the combobox/menupopupbutton object.

When the value changes in a collapsed state, only the value change event
should be fired, but not a focus or activedescendantchanged event.

When the value changes in an expanded state, then the focus and/or
activedescendantchanged events can be fired.

This fixes some strange behavior with NVDA when Alt+Down is used to open
the select.

Bug: 621510
Change-Id: I30fd744157ecbb5180d5c77f2713a73fa168397a
Reviewed-on: https://chromium-review.googlesource.com/1175034
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583367}

BUG=705713
TEST=none

Change-Id: Ic8679c208d015e5019684e581e520b343bf411e1
Reviewed-on: https://chromium-review.googlesource.com/1176107Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583366}

Remove the PulledFromSync and PushedToSync histograms, as those
don't appear to be needed anymore.  As a result of removing those,
remove the whole framework for observing preference changes.

Also add additional owners for the Settings.ShowHomeButton,
Settings.StartupPageLoadSettings, and the
Settings.GivenShowHomeButton_HomePageIsNewTabPage histograms.
Set their expiration dates for one year.  Likely we'll decide to
extend them again after that.  We'll see.

In the process of touching these files which haven't been touched
in years, properly clean it up by removing unnecessary fields,
includes, and friends.

Bug: 871470
Change-Id: I1fa89dbf31b669b8f7805410dd246b8ffc2ec37a
Reviewed-on: https://chromium-review.googlesource.com/1175142Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583365}

Integrated PageHints whitelisted optimization checking to the
PreviewsHints::IsWhitelisted() which is used at commit time to
decide what PreviewsState bit to use.

Bug: 871795
Change-Id: Ifa0080a51f9df5ec9aefd4044b563259d0ce4978
TBR: dougarnett@chromiumn.org
Reviewed-on: https://chromium-review.googlesource.com/1176188Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583364}

TBR=kbr@chromium.org

Bug: 874531
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ib8ee30c3514dff841f185367642d13f271a59ac0
Reviewed-on: https://chromium-review.googlesource.com/1176195
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583363}

Refactoring vr_display_host into xr_device_impl, and making it so that
there is only one XRDeviceImpl, inline with what the WebXR spec expects.
The xr_device_impl is not returned until requested, which is a step
towards making the renderer not expect runtimes to be available until
requested.

Bug: 842025, 701027
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Iedb7dd4956ae1d98a9ae7811948ae645899df423
Reviewed-on: https://chromium-review.googlesource.com/1159468
Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583362}

This stops UI animation and video from freezing during the animation.
Also move some constants to test-accessible location and delete the
duplicates in the tests.

Bug: 554993
Change-Id: Ie4585fa405b32e8bdae984d5a4ffac700c1375ab
Reviewed-on: https://chromium-review.googlesource.com/1166169Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583361}

presentation feedback.

This CL adds support for reporting egl_composite_interval and
presentation_time via the presentation feedabck.
GLSurfacePresentationHelper uses the new interface
EGLTImestampClient to query the egl timestamp info.

Bug: 790761
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I7e1f3200bba41bf3252b8acedc68393eeeb76df5
Reviewed-on: https://chromium-review.googlesource.com/1106600
Commit-Queue: vikas soni <vikassoni@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583360}

This class determines the active state of each multi-device feature. A
future CL will integrate this class with the MultiDeviceSetup service
so that the settings page as well as each individual feature can query
the service for the correct state to show in the UI.

Bug: 824568
Change-Id: I11db1713e19a20f442e73a1f0e61c568ce340e49
Reviewed-on: https://chromium-review.googlesource.com/1171789Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583359}

The capture window should only be cleared if it's part of the client.

Fixes the case where dragging a touch edit handle closes the context menu.
(the context menu closing shouldn't reset client-side touch handle capture)
(otherwise, capture release isn't sent to the ws when ending the touch drag)

Bug: 873743
Test: Automated, KSV (Ctrl-Alt-/) touch text edit handles work.
Change-Id: I4e28115de92f7b8cb0355b6a9e4c0b470634ad2b
Reviewed-on: https://chromium-review.googlesource.com/1176073Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583358}

Also, verified using local Chrome android build. Network
quality change messages appeared on chrome://interventions-internals

Change-Id: I9b958b7fff922fdf8af369c5ba6e29872ceac6dc
Bug: 819244
Reviewed-on: https://chromium-review.googlesource.com/1175554Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583357}

From the review of build 8882.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I013dc2010ed440008bd76ce6afdb3f0e0d920dcb
Reviewed-on: https://chromium-review.googlesource.com/1175756
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583356}

I think this is why the fallback isn't working at all:
https://chromium-swarm.appspot.com/tasklist?c=name&c=state&c=created_ts&c=duration&c=pending_time&c=pool&c=bot&et=1534289040000&f=buildername-tag%3Amac_chromium_rel_ng&f=name-tag%3Awebkit_layout_tests&f=os%3AMac-10.12&l=50&n=true&s=created_ts%3Adesc&st=1534202640000

It's inheriting the "gpu:none" that the recipe default to:
https://codesearch.chromium.org/chromium/build/scripts/slave/recipe_modules/swarming/api.py?rcl=48ebe7c7e93d140e1746c034fbf39d2480bd34f0&l=188

And we don't have any 10.12 VMs:
https://chromium-swarm.appspot.com/botlist?c=id&c=os&c=task&c=status&f=os%3AMac-10.12&f=pool%3AChrome&f=gpu%3Anone&l=100&q=gpu%3Anone&s=id%3Aasc

Hopefully this helps things. If it doesn't, I'm going to move the
entire suite back over to 10.12. We simple don't have the capacity for
this... and won't for a while.

Bug: 854874
Change-Id: I87f218a932266a0eef311741f20209f4ece0f8f8
Reviewed-on: https://chromium-review.googlesource.com/1174919Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583355}

Adds a test to ensure that making a payment request from JavaScript in
the VR Browser gets auto-rejected and the native UI does not appear.

Bug: 862162
Change-Id: I1e29c2e4ed0feef5b0a46d329787159e366be84c
Reviewed-on: https://chromium-review.googlesource.com/1176118Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583354}

Do this only in the pre-Refresh UI, where on Windows (and possibly
some other circumstances?), the text styling is dependent on the
selection state.

Bug: 869768
Change-Id: If4ec69bb2316b0596116210f6e3aa70d1866b182
Reviewed-on: https://chromium-review.googlesource.com/1176196Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583353}

Previously, compare_build_artifacts.py used some basic heuristics to figure out
which files to compare. This new option instead scans the .isolate files in the
output directories, and uses their contents to determine which files to compare.

Change-Id: I78bba7d3c06be682da694eeeb0dbe195fe312ace
Bug: 870731
Reviewed-on: https://chromium-review.googlesource.com/1175043
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583352}

Record the result of all major Low Entropy Credential authentication
operations. The CL that introduced the code that generates this data
is http://crrev.com/c/1093957

Bug: chromium:809749
Test: None
Change-Id: I6de70122930d81ba753af750caaaa4bcd1a05d66
Reviewed-on: https://chromium-review.googlesource.com/1091296Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Commit-Queue: Prashant Malani <pmalani@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583351}

Because BridgedNativeWidget will be living in its own process, it will
be necessary for BridgedNativeWidget to create its own NSWindow, instead
of having one be provided during initialization.

This requires substantial refactoring, and two of the NSWindow classes
that BridgedNativeWidget are provided live in chrome/browser/ui, and
will need moving to a new location.

For the moment, allow either creating a new NSWindow or specifying an
NSWindow via the methods BridgedNativeWidget::CreateWindow and
BridgedNativeWidget::SetWindow. This unblocks cross-process development.

Also, be explicit that BridgedNativeWidget's NSWindow is always a
NativeWidgetMacNSWindow or a sub-class thereof. The only exceptions to
this are in tests, so merge testing functionality into
NativeWidgetMacNSWindow.

Bug: 859152
Change-Id: I61edb34d773fc11dff921da5edb34da1e306105b
Reviewed-on: https://chromium-review.googlesource.com/1175051
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583350}

The compositor delegate will own and manage the surfaces, viewports and
buffers. The newly added public interface restricts the manipulation of
contexts to the client (RenderLoop). A native GL implementation is
provided.

Bug: 767282
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I23138f85ba859a64cbcc60c2d8f32757ec941f22
Reviewed-on: https://chromium-review.googlesource.com/1173394Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583349}

https://android.googlesource.com/platform/external/perfetto.git/+log/624fec3ddbea..2ae6f8e569a3


git log 624fec3ddbea..2ae6f8e569a3 --date=short --no-merges --format='%ad %ae %s'
2018-08-15 primiano@google.com Merge "TraceProcessor: fix cost estimation of process and thread vtables"


Created with:
  gclient setdep -r src/third_party/perfetto@2ae6f8e569a3

The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: Ie9187cade7c824c5dae44c896b28ba0cb583e6eb
Reviewed-on: https://chromium-review.googlesource.com/1174808Reviewed-by: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#583348}

Fixing the focusing issue when mixing up both keyboard navigation mode
and mouse navigation mode. Focus on the first available option when we
are on the mouse navigation mode but use tab or arrow key at the first
time.

Bug: 873071
Change-Id: I0a18ac3a92bff9eafef5788b4ced5755d4fa196e
Reviewed-on: https://chromium-review.googlesource.com/1173754Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583347}

Change-Id: If8206c443eee80987c4528d6aaeb58fb348dc57b
Reviewed-on: https://chromium-review.googlesource.com/1176113Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583346}

Mark virtual/user-activation-v2/fast/events/touch/touch-latched-scroll-node-removed.html flaky on Mac

TBR=wjmaclean@chromium.org
NOTRY=true

Bug: 869726
Change-Id: Iefe61d4ed93988b886a5c00f8f3574d9c3f59477
Reviewed-on: https://chromium-review.googlesource.com/1176215Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583345}

This was accidentally introduced in r580764.

Bug: 873785
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ie1e1aa9321f9863c5036a38d88cc7ca560127c00
Reviewed-on: https://chromium-review.googlesource.com/1175549
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583344}

It has been flaky for a while

TBR=wjmaclean@chromium.org
NOTRY=true

Bug: 874538
Change-Id: Ia598f4367f0d90ff407395ffe69fb96ed707b59c
Reviewed-on: https://chromium-review.googlesource.com/1176208Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583343}

cfi-icall is now enabled on all of the CFI bots so a separate bot is no
longer required.

Bug: 874112
Change-Id: I4d3b066c8622e03f1085d06a3ea1c638e22c960e
Reviewed-on: https://chromium-review.googlesource.com/1174912
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583342}

The crash that these were meant to help debug has been long fixed.
They are no longer needed.

Bug: 770886
Change-Id: I7abf99be6cd00b9ae9a99934edaca95fe48e638d
Reviewed-on: https://chromium-review.googlesource.com/1174992Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583341}

This CL removes old audio playback code that is no longer in used.

Bug: 868088
Change-Id: I0dc350fc6d7fcabe89c6c7deba1da34fe53c3667
Reviewed-on: https://chromium-review.googlesource.com/1171855Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583340}

These are existing User Actions, which were not logged on iOS.

Bug: None
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Id1700628a2c54dbd2ba2bbc43bf631a9e474b1ff
Reviewed-on: https://chromium-review.googlesource.com/1175208Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583339}

Bug: None
Change-Id: I00f80dc9050109303747534b78216b67a9f310d3
Reviewed-on: https://chromium-review.googlesource.com/1176109Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583338}

Use AppCompatButton in modal_dialog_view so that the text appearance
can be applied to pre L devices.

Bug: 872212
Change-Id: Ib84be209d086306983267cff5be0151202093ad6
Reviewed-on: https://chromium-review.googlesource.com/1173450
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583337}

1) Merge the abstract class _Top25RuntimeStats with V8Top25RuntimeStats since it's the only one inherit from the abstract class.
2) Remove the disabling Android in perf/expectations.config & switch to use SUPPORTED_PLATFORMS which is meant for permanent disabling logic like this case

Change-Id: I07fecfd3d9cce3e7d35ac71b274bb9416f0cdcac

TBR=perezju@chromium.org

Change-Id: I07fecfd3d9cce3e7d35ac71b274bb9416f0cdcac
Reviewed-on: https://chromium-review.googlesource.com/1175928Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#583336}

This relands 3dcaec6e with a fix to the test.

BUG=873080
TEST=as in bug

Change-Id: Ie68b197fc6b92447e9633f233354a68fefcf20c7
Reviewed-on: https://chromium-review.googlesource.com/1175925Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583335}

* While investigating the problem of not reporting triggering on some
  pages, I discovered a race condition in fetching canonical URL ->
  in some cases the tab does not provide correct infromation yet.
* This patch postpones fetching of canonical URL until later, when
  we are about to perform the fetch.
* Fetching URLs would also cause some problems with marking fetch as in
  progress, which could prevent actual fetch from happening.
* It appears to also be positively affecting the EoC start time when
  loading a page for the first time.

Bug: 873004, 841811
Change-Id: Ic7e91579d083efd54a695a10e251ec245797ba84
Reviewed-on: https://chromium-review.googlesource.com/1175108Reviewed-by: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583334}