- 14 May, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f80ec7eedf59..fc43dd4cbbcb git log f80ec7eedf59..fc43dd4cbbcb --date=short --first-parent --format='%ad %ae %s' 2020-05-14 dberris@chromium.org Dashboard: Log the number of rows created 2020-05-14 dberris@chromium.org auto-triage: Auto-close issues with recovered regressions 2020-05-14 abennetts@google.com pinpoint-ux: Improve readability of “Found n differences” message. Created with: gclient setdep -r src/third_party/catapult@fc43dd4cbbcb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1069331,chromium:1081607 Tbr: nuskos@google.com Change-Id: I2857f4c3738ca17170f7fc079201082888bcca55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200742Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#768769}
-
Manas Verma authored
If the port of an origin is the default port for its scheme, then it should be trimmed. Fixed: 1082499 Change-Id: I40631dd6f6fd0525f92e623f0e207bf9f60ccba2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199869 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#768768}
-
Henrique Nakashima authored
Bug: 1082248 Change-Id: I51b883c8fbefcf391750110b3477ea84c78f7a5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199890Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#768767}
-
Erik Staab authored
TBR=blundell@chromium.org Bug: 1081407 Change-Id: I8726a5c75a151a8bf638461821f381de9ee5a5bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201406Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#768766}
-
Matthias Körber authored
Currently, autofill::FillCreditCardNumberField() fills the complete rest of the credit card number from an offset calculated from the previous field's |max_length| attribute. The logic relies on the automatic truncation of the value. If the |max_length| value is changed in by JS in the meantime, autofill would fill the whole rest of the number and not only the intended portion. With this change, the value is already truncated by autofill. Change-Id: I7eef43d8abd83081e903bbdb0b12dc78846c9b4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2190214 Auto-Submit: Matthias Körber <koerber@google.com> Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#768765}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/effa3ad93640..e9ada4599375 git log effa3ad93640..e9ada4599375 --date=short --first-parent --format='%ad %ae %s' 2020-05-14 treehugger-gerrit@google.com Merge "Support ion_stat" 2020-05-14 primiano@google.com Merge "Use exec(curl) for downloading artifacts" Created with: gclient setdep -r src/third_party/perfetto@e9ada4599375 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I47005aed4283ee32f0e7a56e03eec1cda0c7c471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201736Reviewed-by:
-
Clemens Arbesser authored
Previously, implicit login selection was only enabled if the list of available choices had degenerated to a single item. Now, it is also enabled if a default option is set and there are no password manager logins available. This CL also fixes a number of issues where the action would be allowed to prematurely terminate because the check for OnlyLoginRequested was erroneous and did not account for some of the more recent section like date/time and additional prepended/appended input sections. Bug: b/155971226 Change-Id: Ic7df9e8381265207debe6c1f17229285ade2112f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199115Reviewed-by:
Marian Fechete <marianfe@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#768763}
-
Mathias Carlen authored
We forgot to reenable these tests. They pass locally and were already passing when we last looked into this. The reason for the flakes is usually the underlying testing infra that has a hick-up. The last instance being a "Power off" widget obscuring the button we needed to click. Bug: 1057806 Change-Id: Idbbd63afca3d8df0da20b228f863498677d40024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201556Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#768762}
-
Alan Cutter authored
GURL::GetOrigin() doesn't handle blob:* URLs. Use Origin class instead. Also update web app window UI to use full URL if we are unable to parse the origin out of it instead of showing nothing. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=446212&signed_aid=n--6M0MuMy7reB9rCSzlBQ==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=446381&signed_aid=32H8pSYcBHXM7jZ9LMdxEg==&inline=1 Bug: 1080934 Change-Id: Ifd107797a9e6c40ec6dbbd4891e991db5725484a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198697 Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#768761}
-
Hesen Zhang authored
Bug: 1073550 Change-Id: I2a9d0d10839007a1a170a44014a3f9dbbe1f1904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198719 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#768760}
-
Amr Aboelkher authored
This reverts commit 7f416325. Reason for revert: the ios-simulator-cronet builder is failing because of that change Original change's description: > [ios] Update application extension rpath > > As application extension may share private frameworks with the app > they are bundled in, the rpath needs to look both in the extension > private frameworks and the app private frameworks. > > Bug: none > Change-Id: I5686d20d8e3f131929ec14caa932bda18bf7d517 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201096 > Reviewed-by: David Jean <djean@chromium.org> > Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#768745} TBR=sdefresne@chromium.org,javierrobles@chromium.org,djean@chromium.org Change-Id: Ie83c0aca04c83581ef9bd0bcbff992d9449cc0d1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201601Reviewed-by:
Amr Aboelkher <amraboelkher@google.com> Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Cr-Commit-Position: refs/heads/master@{#768759}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a0a4480f1261..f8cb70a343a7 git log a0a4480f1261..f8cb70a343a7 --date=short --first-parent --format='%ad %ae %s' 2020-05-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9330db6b..8ffd7240 (768590:768712) Created with: gclient setdep -r src/third_party/webrtc@f8cb70a343a7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I124e85739c153b10e21d3f545bff82f85fdeb9af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201738Reviewed-by:
-
Anton Paymyshev authored
Button callbacks should clear |controller_| pointer as |controller_| deletes itself after calling Accept(), Cancel() or Close(). Otherwise SettingsResetPromptDialog dtor crashes trying to Close() already freed |controller_|. Bug was recently introduced with https://crrev.com/c/2028171. Change-Id: I9c9bc91f15bc639d4ebbb279091171fb07173825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199056Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#768757}
-
Elly Fong-Jones authored
TOOLKIT_VIEWS is always defined when building //cbui/views, so these are dead code. Bug: None Change-Id: Id22b091c647c754c52077efbfa0a91da61aa9043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199317Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#768756}
-
Luke Zielinski authored
TBR=robertma Bug: 1082739 Change-Id: If1ec42f8176fe4a187e4dc0ffb3f7e6bbcbfc16b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201403Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#768755}
-
Travis Skare authored
Previously, the last-used QR code was used. Change-Id: I00d35ba688af4290eda0c606803d0a5103ee30a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169067 Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#768754}
-
Peter Wen authored
This check duplicates our presubmit unused imports check. Most IDEs also already allow optimize imports on save action. This allows intermediate builds to contain unused imports and leaves enforcing no unused imports to presubmit checks. Bug: None Change-Id: Ib959ae52ccd93b4f71a29dfe6f605923503a2fcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199600 Auto-Submit: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#768753}
-
Esmael El-Moslimany authored
Bug: 1082276 Change-Id: I38408bdf2fde98ae3599b5f10b6001f9fdffb1a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199995 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#768752}
-
Chromium WPT Sync authored
Using wpt-import in Chromium cac6d369. With Chromium commits locally applied on WPT: 59c99fcd "Clipboard API Tests: Automate Web Platform Tests" 7a588d8c "[client hints] Match update behavior to the spec." 46619c73 "[client hints] Enforce the top-frame requirement." 3c2baf64 "[Client-Hints] Fix cross-origin redirect leak" c15bc63c "[EventTiming] Test more event types" 6640d9f9 "[EventTiming] Wrap lines better in event-timing-test-utils" 200214d5 "[client-hints] Ensure by-default&legacy hints behave with XO redirects" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ie2afa59ac11d17f54aa001ac2a448123d647923f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201456Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#768751}
-
Michael Thiessen authored
Bug: 1081861 Change-Id: Ife8c169371fafdfb5b4b45de8a4f71e28d600310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197150 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Matt Menke authored
Also make IsolationInfo mandatory for requests using a profile's main NetworkContext. In the future this will be extended to other APIs that take NIKs (WebSockets, DNS lookups, etc). Bug: 1082280 Change-Id: I630f501cfaf57ea01af8af05c37c9bd79bda20ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2180542 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#768749}
-
Lukasz Anforowicz authored
In template specializations template parameters (e.g. |T| or |T2| in MyTemplate in tests/template-specializations-original.cc) get substituted with an actual class (e.g. |SomeClass| or |int|). In an *implicit* specialization, these substitutions are "overlaid" / "overimposed" on top of the template definition and this can lead to generating conflicting replacements - for example the same |t_ptr_field| definition can get replaced with: 1. T* t_ptr_field -> CheckedPtr<T> t_ptr_field // expected 2. T* t_ptr_field -> CheckedPtr<SomeClass> t_ptr_field // undesired After this CL, the FieldDecls in an implicit template specialization (i.e. example2 above) are ignored. This avoids generating a conflicting replacement. Bug: 1069567 Change-Id: I8d2487fdece703421ceb08be67bf6f817e44c03d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156068 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#768748}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ff46862e0fb2..f348b224a38d Created with: gclient setdep -r src-internal@f348b224a38d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC amraboelkher@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: amraboelkher@google.com Change-Id: I03a50026df7306a420ff7f48aff3b088972c0815 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201298Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Allen Bauer authored
Bug: 1044687 Change-Id: I71c5a1e0d01be2c8581327cbc3094c464dea8b2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200087Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#768746}
-
Sylvain Defresne authored
As application extension may share private frameworks with the app they are bundled in, the rpath needs to look both in the extension private frameworks and the app private frameworks. Bug: none Change-Id: I5686d20d8e3f131929ec14caa932bda18bf7d517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201096Reviewed-by:
David Jean <djean@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#768745}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2e2f67443e9c..a0a4480f1261 git log 2e2f67443e9c..a0a4480f1261 --date=short --first-parent --format='%ad %ae %s' 2020-05-14 tommi@webrtc.org Migrate CallStats and RtpStreamsSynchronizer timers over to RepeatingTask 2020-05-14 nisse@webrtc.org Reland "Delete unused code to handle posix signals in PhysicalSocketServer" Created with: gclient setdep -r src/third_party/webrtc@a0a4480f1261 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I34a0fb1eb033da314968c0286d11bc9f5d8ba749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201303Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3a9098412b8c..c9ed32549988 git log 3a9098412b8c..c9ed32549988 --date=short --first-parent --format='%ad %ae %s' 2020-05-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 64da65bd1bd5..d748e1651af8 (2 commits) Created with: gclient setdep -r src/third_party/angle@c9ed32549988 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@chromium.org Change-Id: I8b55f4f0b5b71aa8ce405024c29f9d81b278f3a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200746Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8ad44a779e85..493b76784ef1 git log 8ad44a779e85..493b76784ef1 --date=short --first-parent --format='%ad %ae %s' 2020-05-14 wolfi@chromium.org Port Script.js to TypeScript Created with: gclient setdep -r src/third_party/devtools-frontend/src@493b76784ef1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811,chromium:1079233 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2066579b16021c87ac21c38c18dc436223ca120f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201304Reviewed-by:
-
Tanmoy Mollik authored
As SyncAndServicesSettings page is going to deprecated the google services section in that page is going to be shown in a new page. This cl creates that new class mainly by reusing code from SyncAndServicesSettings and sync_and_services_preferences.xml Screenshot: https://crbug.com/1068229#c2 Bug: 1068229 Change-Id: I75fc368d0273476171202bce31f9c5712bd1d719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2193664 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#768741}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I31977e7ddd9a6b12c6f1074987c3c48cce0b3a5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201300Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9eaf6cc64b84..effa3ad93640 git log 9eaf6cc64b84..effa3ad93640 --date=short --first-parent --format='%ad %ae %s' 2020-05-14 lalitm@google.com ftrace: update descriptors Created with: gclient setdep -r src/third_party/perfetto@effa3ad93640 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I8fde85419e4ec732de7118249a4aaa9b1d23c1a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201297Reviewed-by:
-
Denis Kuznetsov authored
Bug: 1082670 Change-Id: Ib99e5af1d1c637b3ceb6786c121e430d0620f670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201196Reviewed-by:
Renato Silva <rrsilva@google.com> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#768738}
-
Anders Hartvoll Ruud authored
A "dependency" for a given CachedMatchedProperties object is defined as a CSS property, whose computed value must be equal for the cached parent style and the incoming parent style in order for a given cache lookup to be considered a cache hit. This CL makes it possible to add such a list of dependencies to a CachedMatchedProperties object, but doesn't actually use this capability yet (except from unit tests). Bug: 1057072 Change-Id: I37cf3b88b6e09d2503865c5d7d9c2c7b2539d13f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2193682 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#768737}
-
Natalie Chouinard authored
Fixed this lint issue in https://crrev.com/c/2196833 but missed removing the suppression. Bug: 1081236 Change-Id: I2ff8a372483adf3109cd585619d61a4555c85865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200086 Auto-Submit: Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#768736}
-
Peter Wen authored
Remove min_sdk_version and android_manifest_for_lint GN variables. Remove the extra not_needed in internal_rules. It allowed time for downstream projects to remove these args from their gn templates. Commit after webrtc CL is merged into chromium: https://webrtc-review.googlesource.com/c/src/+/174983 Previously, min_sdk_version was used to package our apks and to pass to android lint for linting each java target. We've since migrated to minSdkVersion being specified in our AndroidManifest.xml (thus no longer using the GN min_sdk_version variable for apks). Since then it's only been used for linting each java target. I've migrated lint to only lint for apks and bundles, and so min_sdk_version is only necessary for apks and bundles, not for any other java target. Thus these GN variables are no longer used by non-apk/bundle java targets (GN complains about them being unused). Bug: 1017190 Change-Id: Ia75becae168fdd9151c91b14dc22e0c4ac5ca77f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198608 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#768735}
-
Nidhi Jaju authored
To optimise the code, this change is made to change ServiceWorkerStorage::StoreUserData to take |user_data| so that we do not need to convert it. Bug: 1055677 Change-Id: I68ed640f2957b0849cb4131d453b5f02490e345b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200479Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#768734}
-
sandromaggi authored
This prototype implements the design doc. It allows the fallback handler of Autofill actions to click a base element, wait for a specific option to appear and click it. Bug: b/156238665 Change-Id: I4bc61b1dd6036616e09f21b1375aa883154649c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2193580 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/457095815d1f..8ad44a779e85 git log 457095815d1f..8ad44a779e85 --date=short --first-parent --format='%ad %ae %s' 2020-05-14 caseq@chromium.org Ignore getResourceTree responses with invalid URLs 2020-05-14 tvanderlippe@chromium.org Update TypeScript to 3.9.2 2020-05-14 tvanderlippe@chromium.org Emit fixes for TypeScript 3.9.2 Created with: gclient setdep -r src/third_party/devtools-frontend/src@8ad44a779e85 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811,chromium:10781354,chromium:1081270 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie94d4ab113ca211fa78cc668fdf2fb38dfb994b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200743Reviewed-by:
-
Jinsuk Kim authored
ContextMenuHelper and ContextMenuPopulator refer to each other. This CL breaks the dependency by the populator having its own native layer to process the tasks. This leaves ContextMenuPopulator free of the reference to Context- MenuPopulator, effectively allowing for the definition of a modularized build target chrome/browser/contextmenu:java. Bug: 952703 Change-Id: I2bdabe167e2c98a1d2fef24eb68af993d3beab57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2172176 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#768731}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b088a952ee9f..2e2f67443e9c git log b088a952ee9f..2e2f67443e9c --date=short --first-parent --format='%ad %ae %s' 2020-05-14 eshr@google.com Add VideoStreamEncoder tests for DegredationPreference switching. 2020-05-14 danilo.bargen@threema.ch docs: Improve Android testing docs Created with: gclient setdep -r src/third_party/webrtc@2e2f67443e9c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I9b6991fcda8a1078b16ad38a171fb5cc12157c62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200744Reviewed-by:
-
