Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 23 Feb, 2019 37 commits
  3. 22 Feb, 2019 3 commits
    • Marcin Wiącek's avatar
      Migrate Orientation to the @IntDef · 7fb0508e
      Marcin Wiącek authored 
      @IntDef/@StringDef annotation are preferred way for declaring
set of String/int values

1. they need less space in APK than enum, see
https://developer.android.com/topic/performance/reduce-apk-size#remove-enums
2. they give more control over allowed values than "static final" values

Main goal of patch is writing @Orientation interface in the form common with Chrome @IntDef:

1. with @IntDef first, @Retention second
   and related @interface third
2. with values inside @interface
3. with @Retention(RetentionPolicy.SOURCE)
4. without "static final" in the @interface

BUG=919666

Change-Id: I6e96496eedf82253687c287ea7a70b3c92f63ace
Reviewed-on: https://chromium-review.googlesource.com/c/1480450Reviewed-by: default avatarDavid Trainor <dtrainor@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#634876}
      7fb0508e
    • Ahmed Fakhry's avatar
      Add flag to list all modes of external displays · 15d707e7
      Ahmed Fakhry authored 
      This CL adds a flag that enables listing all display
modes in the display settings for external displays,
which can be very useful for debugging and development
purposes.

BUG=927848
TEST=Added tests, tested on device with 4k display

Change-Id: I748f2c2b645071723b94a37f759528b6437558aa
Reviewed-on: https://chromium-review.googlesource.com/c/1465682
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: default avatarSteven Bennetts <stevenjb@chromium.org>
Reviewed-by: default avatarDominick Ng <dominickn@chromium.org>
Reviewed-by: default avatarGabriel Charette <gab@chromium.org>
Reviewed-by: default avatarElly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: default avatarMitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634875}
      15d707e7
    • Kenneth Russell's avatar
      Revert "Enable -Wextra-semi in non-cros non-chromecast non-fuzzer linux builds... · 00ddedc7
      Kenneth Russell authored 
      Revert "Enable -Wextra-semi in non-cros non-chromecast non-fuzzer linux builds that have DCHECKs enabled."

This reverts commit 5b911be8.

Reason for revert: broke linux_optional_gpu_tests_rel trybot per Issue 935033

Original change's description:
> Enable -Wextra-semi in non-cros non-chromecast non-fuzzer linux builds that have DCHECKs enabled.
> 
> Only enables the warning for chromium_code.n
> 
> Also fix the last few -Wextra-semi instances in sanitizer and linux/ozone builds.
> 
> Getting to this state required fixing > 3000 unique warnings in 15+ different
> repositories.  If this breaks some internal-only build somewhere, either consider
> using no_chromium_code for your internal code, or fix the warnings -- it's
> pretty easy. (Build with treat_warnings_as_errors=false, then open the error log
> in vim, run `:%g/warning:/t$` to copy the warnings to the end of the buffer,
> remove all but just those lines, run `:sort u` to get uniques, then save as
> `tmp.txt` and run `:cf %` and then use something like `:map m :w<cr>:cn<cr>`
> to go through them quickly.)
> 
> TBR=rsesek
> 
> Bug: 926235
> Change-Id: Ica629737523ff6bbd756edc44d182f35ff6cf8ac
> Reviewed-on: https://chromium-review.googlesource.com/c/1483396
> Reviewed-by: Scott Violet <sky@chromium.org>
> Auto-Submit: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#634826}

TBR=sky@chromium.org,thakis@chromium.org,rsesek@chromium.org

Change-Id: I3fbcb763dbe448619b55f6dbb0cd1bf6d4eebc03
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 926235, 935033
Reviewed-on: https://chromium-review.googlesource.com/c/1484509Reviewed-by: default avatarKenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634874}
      00ddedc7