- 12 Aug, 2019 40 commits
-
-
Tommy Li authored
Disable SystemNetworkContextManager.MaxConnectionsPerProxyBrowsertest Flaking since it was landed. https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests?limit=200 TBR=niarci@microsoft.com Bug: 993059 Change-Id: Ibd624f36f712ef0a314532ae2bef4bd8406285b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747984Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#686195}
-
Xiaohan Wang authored
Currently in NewSessionCdmResultPromise::reject(), we missed the |key_system_uma_prefix_| when reporting UMA. As a result, all failure cases are reported to a wrong UMA name. For the record, the bug was first introduced in: https://codereview.chromium.org/2691673002/ This CL is manually tested as follows: 1. Update ClearKeyCdm::CreateSessionAndGenerateRequest() to unconditionally reject the promise with system code 111. 2. Build browser_test and run the following: out/Debug/browser_tests --gtest_filter=MSE_ExternalClearKey*Playback_VideoOnly_MP4_VP9/0 -v=1 where -v=1 will print out all histograms at the end. 3. Made sure we have the following: Histogram: Media.EME.Unknown.GenerateRequest recorded 1 samples, mean = 2.0 (flags = 0x41) 0 ... 2 ------------------------------------------O (1 = 100.0%) {0.0%} 3 ... Histogram: Media.EME.Unknown.GenerateRequest.SystemCode recorded 1 samples (flags = 0x41) 111 -----------------------------------------------O (1 = 100.0%) Bug: 690722 Test: See above Change-Id: I81a81a7e8a0e650494209dc1c7dd0e6d950d8353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747045 Auto-Submit: Xiaohan Wang <xhwang@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#686194}
-
Min Qin authored
Sandboxed iframes has an opaque origin, so the DownloadPermissionRequest popup and the download omnibox decoration cannot show the URL of the download correctly. Also querying the content setting won't work either. This CL change the default setting for all opaque URLs to be blocked, so that only one download can be performed. And it switches DownloadRequestLimiter to use url::Origin instead of GURL to handle opaque origins. Omnibox decoration and DownloadPermissionRequest popup won't be shown for opaque origins. BUG=991617 Change-Id: I72599c9fa35bbe92637ef6a7165564d4584581b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746957Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#686193}
-
Xiaohui Chen authored
Extended a couple assistant feature flags which are still in use. Bug: None Test: locally build and test Change-Id: Ic614695e8c9973431666db778600c9e0e74386a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748077Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#686192}
-
Sammie Quon authored
The new scrolling may be a fairly heavy operation, add a test so we can catch regressions and optimize it later on. Test: interactive_ui_tests OverviewScrollTest.Basic Bug: 978112 Change-Id: Ia77b1548ae8ce5dd95a222db2c8aef4bee3c468c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742118 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Mitsuru Oshima (OOO 8/12,13) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#686191}
-
Bo Liu authored
Add a boolean uma that's recorded each draw. Bug: 956709 Change-Id: Iaf6b2027562e0ab75602a8f476f18689cfec32f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745428Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#686190}
-
Pavol Marko authored
This CL contains two changes that are necessary to enable extension-scoped policy-provided certificates in the Chrome OS sign-in profile. Change 1: Move the responsibility of deciding whether and which policy-provided certificates should be used to the PolicyCertService. Allow a PolicyCertService on the Chrome OS sign-in profile, but without profile-wide certificate. Change 2: Make PolicyCertService receive a StoragePartition path when retrieving certificates from it, so it can customize certificates based on StoragePartition. Currently it doesn't care about the StoragePartition path, but this will be used in a follow-up CL. Bug: 939344 Test: browser_tests --gtest_filter=*PolicyProvidedTrustAnchors* Change-Id: I9c7ed89aa30fa48d921f09f5a0fd56313ebb03ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689190Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#686189}
-
Suzy Li authored
Bug: n/a Change-Id: Iff18d329e97129219e45f1387bc05f992a2983ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744543 Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#686188}
-
Anastasia Helfinstein authored
Previously, Switch Access used the setSwitchAccessKeys function to specify which keycodes were selected as switches by the user. Now that we have migrated to the new Settings page, that information no longer needs to be communicated between the extension and the chrome/ code. Bug: 958081 Change-Id: I749fd7e5fcb99fa567805c211f4f130cfbaf0706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729566Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#686187}
-
Derek Schuff authored
Bug: 918374 Change-Id: I1087df5974f531c8ecb2ae3aa3cd45578d977eef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747373 Auto-Submit: Derek Schuff <dschuff@chromium.org> Commit-Queue: Sam Clegg <sbc@chromium.org> Reviewed-by:
Sam Clegg <sbc@chromium.org> Cr-Commit-Position: refs/heads/master@{#686186}
-
James Cook authored
The compiler can count our arguments for us. go/totw/164 This also revealed an unused mock method for exo::KeyboardDelegate. Bug: none Test: ash_unittests Change-Id: I8b864c2766986c8df5b0fd74f9ac2eb28de3def7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749708Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#686185}
-
Xiaohan Wang authored
This is useful for encrypted AV1 testing on platforms that doesn't not support component updated CDM (where codec support is read from CDM manifest). Bug: 953507 Change-Id: If43dc7d5fcbb8a8e69777831a9a3e52593f77ff2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747232Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#686184}
-
Tommy Li authored
Flaking on Linux Debug: virtual/audio-service/media/controls/doubletap-to-jump-backwards.html Bug: 783154 Change-Id: I89bfdfdcf14f3af52142020c9fd1f76d4182622a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747976Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#686183}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ca9e187dfaa7..f815301b1ad2 git log ca9e187dfaa7..f815301b1ad2 --date=short --no-merges --format='%ad %ae %s' 2019-08-12 mtklein@google.com add GM for skbug.com/9331 2019-08-12 egdaniel@google.com For non-ccpr draws make sure all inputs to GrGPUCommandBuffer are long lived. 2019-08-12 halcanary@google.com gm: GMFactory returns a unique_ptr<> 2019-08-12 bsalomon@google.com Remove some uses of GrSurface::config() 2019-08-12 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@f815301b1ad2 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@google.com Bug: None Change-Id: Ibfc239c0c22312dc0f0d5d0d2167e65fcd6aff47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749743Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686182}
-
Pete Williamson authored
Bug: 986504 Change-Id: I64ec4341235914687c9bc8ec2d7c8ce905e3ef19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747378Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#686181}
-
Mike Dougherty authored
This reverts commit 58978f33. Reason for revert: Breaks the following tests. It appears that the content is loaded beneath the top toolbar after this change landed: ExternalURLTestCase/testSearchByImageWith404Image ExternalURLTestCase/testSearchByImage See first failure at https://ci.chromium.org/p/chrome/builders/ci/iphone-simulator/3202 Original change's description: > [iOS] Update FullscreenWebStateListObserver logic. > > The FullscreenWebStateListObserver's WebStateList is reset to nullptr > when in the tab switcher, so it was missing changes to the active > WebState that occurs when switching tabs using the tab grid. This CL > updates SetWebStateList() to move the page content below the header if > the active WebState in the list has not previously been activated. > > Also in this CL: > - Decomposes repeated FullscreenWebStateListObserver logic. > - Sets the FullscreenController's WebStateList after updating broadcast > values in BVC so that the toolbar insets are correct when the content > is moved below the header. > > Bug: 992354 > Change-Id: I4ab9d2245ec662dcd167b5178d4abf2395889ed9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745809 > Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> > Reviewed-by: Chris Lu <thegreenfrog@chromium.org> > Commit-Queue: Chris Lu <thegreenfrog@chromium.org> > Cr-Commit-Position: refs/heads/master@{#685800} TBR=kkhorimoto@chromium.org,thegreenfrog@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 992354 Change-Id: Ia41267619af9e257bff106b112796390070d43b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746710Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#686180}
-
Maksim Ivanov authored
According to the crbug, the implementation described in the browser_view_resizer.md doc was reverted a few years ago, and the crbug was WontFix'ed. Bug: 458 Change-Id: Ibd28339f1f4c57dbcbf379058ffa178c438352ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749962 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#686179}
-
Meilin Wang authored
This change modifies the thinking dots dimensions for embedded UI while keeps the spec unchanged for standalone. Bug: b/128914298. Test: manually test. Change-Id: Id9976d82c4446eb64ff34efa4020a2ee5d4f5b5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731297 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#686178}
-
Sophie Chang authored
Bug: 969558 Change-Id: Ia3d2240b8fb3444f1ed2f43c34a79caf6a9066ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747136Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#686177}
-
Nicolás Peña Moreno authored
This change adds a map |background_image_timestamps_| of load timestamps of background images tracked by StyleFetchedImage, which are the background images with url. The map only tracks the load time, as |images_notified_| must still be used to track the background image paints. Otherwise we'd only report an entry per background image even when applied to multiple elements. This change also makes computations a bit more efficient by only calling base::TimeTicks::Now() on the first time we load an entry. It also fixes a problem of calling Set() in between usages of an iterator, which is not allowed. Before this change, the added test would crash due to this problem. Bug: 879270, 986891 Change-Id: I86640f5587f69f94e13c429f3e55b3d5d6978cc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745497Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#686176}
-
https://crrev.com/c/1715553Bo Cupp authored
Revert: https://crrev.com/c/1735548 Issue leading to revert: https://crbug.com/990672 The original change introduced use of uninitialized memory. This change adds the missing initialization. The update is limited to native_theme_base.cc which can be seen in patchset 2. TBR'ing the original reviewers except Elly (owner for the fix under native_theme). Bug: 987292 Change-Id: Ia091807203df5a17a240238dd4968dc031aa1476 TBR=chrishtr@chromium.org,masonfreed@chromium.org,haraken@chromium.org,tkent@chromium.org Change-Id: Ia091807203df5a17a240238dd4968dc031aa1476 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747855Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Bo Cupp <pcupp@microsoft.com> Cr-Commit-Position: refs/heads/master@{#686175}
-
Ben Kelly authored
Bug: 985379 Change-Id: I97fec3bf531e32ea8c8fc30693db59f22dee7a5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746767Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#686174}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/44d77e47f726..6ef342fb6645 Created with: gclient setdep -r src-internal@6ef342fb6645 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:None Change-Id: I9836ea19d44598b476129bca580460415c620248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747971Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686173}
-
Chris Lu authored
If a currently active web state is replaced, the delegate of the InfobarBadgeTabHelper associated with the new web state needs to be set. Bug: 976901 Change-Id: I7a564c3c38628ad1700cae372a14c26f700bdd2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747383 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#686172}
-
Jared Saul authored
This is a followup CL to add tests for https://chromium-review.googlesource.com/c/chromium/src/+/1676674 which is being requested for merge. Bug: 978514 Change-Id: Id6b8bc88454f27f9e1ca584f27b4e04e3894f325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676831 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#686171}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ef773214..4b56460d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic661924f99174a5b21215ac3f0e0903b7cb67b12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749623Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686170}
-
Matthew Cary authored
This change wraps the FD-based protected buffers in a base::subtle::PlatformSharedMemoryRegion rather than the legacy SharedMemoryHandle. Aside from a couple of new validation checks, functionality is unchanged. Bug: 849207 Change-Id: I2df619dc58c6313393e41eef7e4807edf340875e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697183 Commit-Queue: Matthew Cary (CET) <mattcary@chromium.org> Reviewed-by:
Matthew Cary (CET) <mattcary@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#686169}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: I3cf54a38e569cb109d8465fed57c6bc2788e4152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747860 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#686168}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I14a63161ad7c37da12d6c2ed79e18e10c0dac6f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749742Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686167}
-
Henrik Grunell authored
Enables features AudioServiceOutOfProcess and AudioServiceOutOfProcessKillAtHang by default on Mac. Also * Fixes audio process study names for Win and Linux in field trial config. * Sets default audio service teardown to 15 minutes on all platforms since it has been launched on all platforms (corrects a miss in some of the previous launches). This change is similar to the previous launch for Linux: https://chromium-review.googlesource.com/c/chromium/src/+/1648499 Bug: 974450 Change-Id: I6aae36d0635266187cee2081c1105a7b323aa244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745992Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#686166}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/36eb20a7aba8..aba68fe5a5cc git log 36eb20a7aba8..aba68fe5a5cc --date=short --no-merges --format='%ad %ae %s' 2019-08-12 cjmcdonald@chromium.org parallel_emerge_old: Set both SYSROOT and ROOT via --board arg Created with: gclient setdep -r src/third_party/chromite@aba68fe5a5cc The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ibaa6f0213629c87cb79f3dc6c9636d0db0235ea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749605Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686165}
-
Josh Nohle authored
Adds metrics to track the result--success, failure, timeout--of async function calls during the CryptAuth v2 Enrollment flow. Bug: 899080, 936273 Change-Id: Id60e1025e012e04b5bc8d984559a313fa0aedff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745366Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#686164}
-
Evan Stade authored
ProfileManager doesn't need its own boolean tracking whether all browsers are being shut down as it can just check browser_shutdown::IsTryingToQuit(). Thus it doesn't need to listen to NOTIFICATION_CLOSE_ALL_BROWSERS_REQUEST and NOTIFICATION_BROWSER_CLOSE_CANCELLED. It also doesn't need to save the active profiles when those notifications are sent out because saving the profiles when a browser is opened or closed should be sufficient. Bug: 268984 Change-Id: I2a81be1c1f04440ee4e8fc05375742d52cac9169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730191Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#686163}
-
Robert Ogden authored
Bug: 969163 Change-Id: I3e437c9927a339a5d5fe5be68e8d057434d893c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748081Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#686162}
-
Hector Carmona authored
Refactored how the toolbar shows toast to avoid having two toasts. Also noticed bug in cr-toast-manager that would try to announce an element instead of its textContent. Bug: 27175 Change-Id: I1128106498f159242c5e0011d5e879641cf863fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1740652Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#686161}
-
Andrew Grieve authored
Wasn't quite unused - but was used only for Android Studio's layout previewer. I don't know of a good way to have non-shipped resources, so deleting is probably the best option for now. Bug: 988047 Change-Id: Ic002ed2cbf2408100b70110436c01a9922a0fb03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749705 Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#686160}
-
Adrian Taylor authored
Also, pointing at a chromium.org copy of the source document which is accessible outside Google without individual access requests. Change-Id: I4caef90f2a77127173251d014adef4b6f72be801 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747790 Auto-Submit: Adrian Taylor <adetaylor@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Adrian Taylor <adetaylor@chromium.org> Cr-Commit-Position: refs/heads/master@{#686159}
-
Kristyn Hamasaki authored
Adds test coverage for toggling bubble locking and debug rectangles, and sources. Change-Id: Id03f45888467a8791c113dece1d4648db88e41a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747147 Commit-Queue: Kristyn Hamasaki <khamasaki@google.com> Reviewed-by:
Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#686158}
-
Sammie Quon authored
Test: manual Bug: 991933 Change-Id: I0215fc86997fe17f07fec11263f358b9b3cf756c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743877Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#686157}
-
behdad authored
Values used in this patch are the 99 percentile of the last 200 perf results of runs of GPU fyi bots. https://docs.google.com/spreadsheets/d/1vYnVrG0QnBl5_zQ9fVuzYW80xPhIGsXowOMiNtn0DGc/edit?usp=sharing Bug: chromium:982769 Change-Id: Iad3c2bd99714f9ffb9eae11619b5447c9d40809f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748793Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#686156}
-