- 23 Jul, 2018 40 commits
-
-
Marc-Antoine Ruel authored
https://chromium.googlesource.com/infra/luci/client-py.git/+log/9a518d097dca..486c9b53c4d5 $ git log 9a518d097..486c9b53c --date=short --no-merges --format='%ad %ae %s' 2018-07-23 maruel [client] lower default task priority to 200 2018-07-23 maruel Roll infra_libs, gae_event_mon and gae_ts_mon. 2018-06-28 maruel client: fix exception on symlink 2018-06-26 martiniss Revert "Bump version of infra_libs to 1.4.0" 2018-06-25 martiniss Bump version of infra_libs to 1.4.0 2018-06-22 maruel [swarming] more task state documentation 2018-06-20 nodir Add Google RPC protobufs 2018-06-18 maruel [client] Fix regression in d335c4bf86 2018-06-18 maruel [client] Fix regression in a768d983f4 Created with: roll-dep src/tools/swarming_client Bug: 855253,864655 Change-Id: Ic98b9572df6ec364afa2595802abf266e3202a46 Reviewed-on: https://chromium-review.googlesource.com/1147154Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#577327}
-
Justin Novosad authored
BUG=866273 Change-Id: Ie53ffb789b005089813f11f26f4425a8f8884b0f Reviewed-on: https://chromium-review.googlesource.com/1147461Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#577326}
-
Tom McKee authored
According to the spec (https://w3c.github.io/server-timing/#the-server-timing-header-field), optional whitespace is allowed amongst parameter names and values. We should be discarding this whitespace during parsing but, when there are tabs, we were treating it like an error and discarding the whole value. Changed the code that tokenizes HTTP headers to skip tabs and spaces when consuming optional whitespace. BUG=798446 Change-Id: If776761e5ea199e662ec7b2b5aa245e4581131fd Reviewed-on: https://chromium-review.googlesource.com/1147258Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Tom McKee <tommckee@chromium.org> Cr-Commit-Position: refs/heads/master@{#577325}
-
Wei-Yin Chen (陳威尹) authored
Right now Android build uses platform_font_linux if the VR support is enabled. VR support is enabled on all Android ARM builds (see |enable_gvr_services| and crbug/733935). We'd like to use RenderText in compositor UI, so this CL makes all Android builds use platform_font_linux, regardless of whether VR is enabled. This only affects non-ARM Android builds. Bug: 853281, 642010 Change-Id: I843c53964f1af932ad9f00b67ac690c5b43916ab Reviewed-on: https://chromium-review.googlesource.com/1142484 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#577324}
-
Fritz Koenig authored
Push mesa to invert the framebuffer if the GL_MESA_framebuffer_flip_y extension is available. BUG=680851 Change-Id: Ib22dfb1d03fcc54acc016de29bdead16398ef416 Reviewed-on: https://chromium-review.googlesource.com/1091917 Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#577323}
-
Justin Novosad authored
BUG=866241 Change-Id: Ic789573da753fe1e438778d777556a659fbf0ba9 Reviewed-on: https://chromium-review.googlesource.com/1147460Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#577322}
-
Christopher Cameron authored
The GLFences used for backpressure in ImageTransportSurfaceOverlayMac are objects that should be scoped to a GLContext, not a GLSurface. Add methods to GLContext to allow creation and waiting on fences, and call those methods from GLSurface. Bug: 863817 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib0fc8cac3efdd50f88c197c6bdeb2ee2e22696bd Reviewed-on: https://chromium-review.googlesource.com/1146483 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#577321}
-
Gabriel Marin authored
We are trying to uprev the tcmalloc version used in Chromium. As part of the transition to a new tcmalloc, we plan to run experiments with the new tcmalloc on a small number of boards before we enable the new version globally. This CL adds a build flag to select between the two tcmalloc versions at build time. By default, the old tcmalloc version is used. BUG=724399,b:70905156 Change-Id: I6839bba721b0d2a5f3515e7346bff418b0155221 Reviewed-on: https://chromium-review.googlesource.com/1130672Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#577320}
-
Ricardo Quesada authored
Use correct TexCoord precision in GLRenderer::EnqueueTextureQuad. Under certain cases, specially when resizing ARC++ windows, the surface size == fullscreen size. But when EnqueueTextureSize asks for the TexCoord precision, it passes visible_quad_layer_rect which could be less than the highp_threshold_cache. So it will use a mediump qualifier instead of a highp. Probably this is only reproducible on Kevin because its mediump is only 10 bits, and I guess other GPUs use a higher precision for mediump. * Add unit test for the fix * Remove unused vars from gl_renderer_unittest.cc * Replace bottom_right() with size() before calling TexCoordPrecisionRequired, since it only cares about sizes and not positions. * Add #include <utility>, <map>, <memory> since "git cl lint" complained about it BUG=862452 TEST=viz_unittest in Linux. Passed all tests. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I51ec129db3369c45192f4f0c69ec38f3a2ec511d Reviewed-on: https://chromium-review.googlesource.com/1132607 Commit-Queue: Ricardo Quesada <ricardoq@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#577319}
-
May Lippert authored
This fixes an issue where an existing user's passwords are not saved in the UserContext if views-based login is used. This in turn meant that the user's password would not be saved in the kernel keyring in cases where the ${PASSWORD} variable is used in the OpenNetworkConfiguration policy. BUG=chromium:866566 TEST=run unit tests, run autotests Change-Id: I2d43ebfb6869d8d333e61505d1987081076fc3da Reviewed-on: https://chromium-review.googlesource.com/1147207Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: May Lippert <maybelle@chromium.org> Cr-Commit-Position: refs/heads/master@{#577318}
-
Stephan Stross authored
This CL adds a quick change to boot_data.py that makes the output directory path absolute before provisioning SSH files, to work around ZX-2397 Bug: https://fuchsia.atlassian.net/browse/ZX-2397 Change-Id: Iae0c2f8bd992e14bc3d7bcce88c82e65407b829b Reviewed-on: https://chromium-review.googlesource.com/1147247 Commit-Queue: Stephan Stross <stephanstross@google.com> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#577317}
-
Hiroshige Hayashizaki authored
Before this CL, ExecutePendingScriptAndDispatchEvent() implements two different spec concept depending on its two call sites, and ScriptStreamer::Type parameter is used just to distinguish the two call sites. This CL splits the method into two (one for each call site), to remove unnecessary dependency to ScriptStreamer::Type and make spec correspondence clearer. Bug: 865098, 686281 Change-Id: I2ddb10ebe4c20861121d42d11d4a83cb349c3369 Reviewed-on: https://chromium-review.googlesource.com/1144462 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#577316}
-
Stephen Martinis authored
This CL enables logic to only retry failed tests for most isolated script tests. The following test suites are affected: * angle_perftests * chromedriver_py_tests * components_perftests * content_shell_crash_test * devtools_closure_compile * devtools_eslint * heap_profiling.mobile.disabled * heap_profiling.mobile.native * heap_profiling.mobile.pseudo * memory.leak_detection * metrics_python_tests * mini_installer_tests * monochrome_apk_checker * passthrough_command_buffer_perftests * performance_test_suite * site_per_process_webkit_layout_tests * telemetry_gpu_unittests * telemetry_perf_unittests * telemetry_perf_unittests_viz * telemetry_unittests * telemetry_unittests_viz * validating_command_buffer_perftests * views_perftests * webkit_python_tests These should all work with this logic; I've tested these manually myself. NOTRY=true NOPRESUBMIT=true Bug: 533481 Change-Id: If3a5a03410fd7f1f597197d98ae3060bd91ff487 Reviewed-on: https://chromium-review.googlesource.com/1141340 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#577315}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/2c7a5d6a83b6..5bc35fd6c631 git log 2c7a5d6a83b6..5bc35fd6c631 --date=short --no-merges --format='%ad %ae %s' 2018-07-23 yunlian@google.com Re-eanble cfi on eve-arcnext Created with: gclient setdep -r src/third_party/chromite@5bc35fd6c631 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I9354b2b8cff903b1ab21f5185564db205a8753b3 Reviewed-on: https://chromium-review.googlesource.com/1147061Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577314}
-
Jonathan Ross authored
So TouchInputBrowserTest.TouchHandlerConsume was failing somewhat consistently. However I cannot reproduce the error locally. Nor on trybot runs. I want to re-enable it on the FYI bot Mojo Android to see if it still reproduces, or has happened to be fixed. TBR=fsamuel@chromium.org TEST=TouchInputBrowserTest.TouchHandlerConsume Bug: 855532 Change-Id: Ib6b6bfe013f69b692b8975d70077fed92401299a Reviewed-on: https://chromium-review.googlesource.com/1147070Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#577313}
-
Eric Karl authored
Currently, the transfer cache has a large (128MB) memory limit, but no limit on individual entries. As we have the potential to flood the cache with thousands of small entries, causing an explosion of handle allocations, I've added a 2000 element cap. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1245220bca1ea47546be7d28eaea2e494e3468db Reviewed-on: https://chromium-review.googlesource.com/1147311Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#577312}
-
Quan Nguyen authored
cros: Fix a views-login bug where clicking Add User too quickly could cause the Gaia screen not to load. With this fix, clicking Add User very quickly will show a blank dialog that gets filled in once the Gaia screen finishes initializing. Bug: 837501 Change-Id: Ia87e4c20f80a08a739afc79f3978be11729db15d Reviewed-on: https://chromium-review.googlesource.com/1147490Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#577311}
-
Clark DuVall authored
This is a reland of 574add02 Added DevToolsFrontendInWebRequestApiTest.HiddenRequests to the filter file, will fix it in a follow up. Original change's description: > Reset URLLoaderFactory bindings for web request proxy > > Previously, if a request was made before any web request listeners or > rules were added, the URLLoaderFactory would not be proxied through the > browser process to run the WebRequest code. Now, if it is detected that > WebRequest listeners/rules are added, we reset the bindings so they will > be recreated and proxied through the browser process. > > Observers were added for a few classes so WebRequestAPI can listen to > rule changes. > > Changes in URLLoaderFactoryGetter were needed due to crbug.com/613371. > > Bug: 857577 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: I7805be86512545b496e30b9693374981fdc2633e > Reviewed-on: https://chromium-review.googlesource.com/1139048 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Ken Rockot <rockot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577036} TBR=rockot@chromium.org,kinuko@chromium.org Bug: 857577 Change-Id: I83f266cfcd572ccbde36405d7cff501f92122b2d Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1147042Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#577310}
-
Mustafa Emre Acer authored
This CL adds an infobar for navigation suggestions for IDN URLs that match top domains. The match between the navigated and the suggested domain is made using the ICU skeletons of top domains list in url_formatter. This UI is disabled by default and can be enabled via the IDNNavigationSuggestions feature flag via chrome://flags. Screenshot: https://drive.google.com/open?id=1QloUKbwYIE7QlPX_NRY3Yljt9ZkwtO-S Change-Id: I317a143d363d2a4830ee511f03ede0966312bb57 Bug: 843361 Reviewed-on: https://chromium-review.googlesource.com/1110945 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#577309}
-
Fernando Serboncini authored
If a RAF takes too long, OnBeginFrame may flood the task runner with tasks and not allow postMessages to pass. This makes sure that RAFs are executed in the same task queue as postMessages. We also change BeginFrameProvider logic to only disable setNeedsBeginFrame with one frame delay, to minimize the number of mojo calls. Bug: 863962 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iec4b21d9e41571a9fc2d9880aa26ce45704d8d0c Reviewed-on: https://chromium-review.googlesource.com/1139188 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#577308}
-
Jochen Eisinger authored
Omit them from the profile info cache, and show a profile picker if the default profile is supervised. BUG=866578 R=bauerb@chromium.org,tschumann@chromium.org,msarda@chromium.org Change-Id: Ice583daee39eb1efc987af6a16de256d5bb1fc65 Reviewed-on: https://chromium-review.googlesource.com/1145271 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#577307}
-
Koji Ishii authored
This patch supports the rendering of the '-webkit-box-decoration-break' property. This property is used by 0.73% of pages according to UMA. Also cleanup how NGLineBreaker commmunicates margins/borders/ padding to NGInlineLayoutAlgorithm through NGInlineItemResult. The work for line breaker to take this property into account is deferred to future work. Gecko (unprefixed) supports it, while Blink and WebKit (prefixed) takes only the start edge into account, ignoring the end edge. Edge does not support this property yet. Also CSS WG resolved a change in its behavior recently when used in bidi context. It will need a bit more investigations. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I8d87db5cd35441133a73fcead67901763026155d Reviewed-on: https://chromium-review.googlesource.com/1146125Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#577306}
-
Tibor Goldschwendt authored
Also, add android_app_bundle_module type to build config. Bug: 862696 Change-Id: Ic893f47d44d8dd98ff7e70d3a8e09cbf2ce5a444 Reviewed-on: https://chromium-review.googlesource.com/1135834 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#577305}
-
Peter Kvitek authored
This is an initial portion of the set of tests that are going to be converted to JS. Change-Id: I42eecccf4bf1abef520fce21ae940559e2f0ac39 Reviewed-on: https://chromium-review.googlesource.com/1145823Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Cr-Commit-Position: refs/heads/master@{#577304}
-
Jordy Greenblatt authored
Two new BUILD files, namely chrome/browser/chromeos/device_sync/BUILD.gn and chrome/browser/chromeos/multidevice_setup/BUILD.gn Are already in the parent directory's BUILD and we mistakenly added separately as well: https://cs.chromium.org/chromium/src/chrome/browser/chromeos/BUILD.gn?l=584 https://cs.chromium.org/chromium/src/chrome/browser/chromeos/BUILD.gn?l=1277 Change-Id: Ia9499d229eb4d6e09f406d784a791b732efaee34 Reviewed-on: https://chromium-review.googlesource.com/1147431 Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#577303}
-
Khushal authored
R=ericrk@chromium.org Bug: 866434 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I453b7fa115932366f9e6210bc6404d05358adb67 Reviewed-on: https://chromium-review.googlesource.com/1147102Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#577302}
-
Ian Vollick authored
While VR and AR may one day be able to share code, this will complicate our lives in the short term. With this change I've added an ArRenderer to handle the modest GL work that's required by AR. Bug: 838013 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ibdbcb5729a7f70f0c63ef4c72ffd2804ed351eab Reviewed-on: https://chromium-review.googlesource.com/1147218 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#577301}
-
Sebastien Marchand authored
- Ignore the title/favicon changes happening during the first few seconds following the transition to the loaded state for a tab, some sites seems update their favicon immediately after loading (e.g. cs.chromium.org) without this being an attempt to communicate with the user. The grace period is controlled by the "TitleOrFaviconChangeGracePeriod" variation of the "SiteCharacteristicsDatabase" feature. - Ignore the audio usage happening during the first few seconds after backgrounding a page: this is something that can happen if a user start some media (e.g. a video on YouTube) and switch to a different tab before the video has actually started to play. The grace period is controlled by the "AudioUsageGracePeriod" variation of the "SiteCharacteristicsDatabase" feature. Bug: 773382 Change-Id: I4790fa976add5840bdb9cb5d78c402cba8577669 Reviewed-on: https://chromium-review.googlesource.com/1145707 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#577300}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b907757c0db1..2bfa78540c37 git log b907757c0db1..2bfa78540c37 --date=short --no-merges --format='%ad %ae %s' 2018-07-23 art-snake@yandex-team.ru Rework of CPDF_Object writing. 2018-07-23 tsepez@chromium.org Remove second argument to CFXJSE_Engine::ToObject() 2018-07-23 art-snake@yandex-team.ru Add support of rebuilding crossrefs with compressed objects. 2018-07-23 tsepez@chromium.org Remove unused CScript_DataWindow::JSDataWindow(). 2018-07-23 tsepez@chromium.org Replace CFXJSE_HostObject::type_ with polymorphic conversion methods 2018-07-23 tsepez@chromium.org Remove second argument to ToJSContext(). Created with: gclient setdep -r src/third_party/pdfium@2bfa78540c37 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I7294527ababd458bf60e88b3f32b6ca222aa7287 Reviewed-on: https://chromium-review.googlesource.com/1147340Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577299}
-
Mathieu Perreault authored
Bug: 853780 Test: ntp_render_browsertests Change-Id: I57d4321f6a72d1171066b1578128117c91521bfd Reviewed-on: https://chromium-review.googlesource.com/1145693 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#577298}
-
Robert Ma authored
as another test in the same directory. Blink test runner isn't able to handle such duplicate basenames because it relies on filename mangling extensively. Bug: 866520 Change-Id: I0c9671e83dcf9c61bc20f16a43dcace827145024 Reviewed-on: https://chromium-review.googlesource.com/1146989Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#577297}
-
Ehsan Karamad authored
MacOSX scrollWheel event already provides the correct behavior. If the event (physical) source has precise deltas and comes from a trackpad or apple mouse then it has bidirectional deltas already and pressing shift key should not swap the axis. If the source of the event is an ordinary single-axis mouse, then the NSEvent already packs |delta_x| instead of |delta_y| (for shift-scroll). Also, it turns out that rails mode should only be used for trackpad. The logic in MosueWheelRailsFilter uses an auto-regressive filter to smooth out rails latching. This state is reset for a kPhaseScrollBegan. However, apple mice would always have a phase of kPhaseNone. Since it never resets it might lead to a large value in one axis (i.e., in y-axis after a vertical scroll phase) and when scrolling in the other direction occurs, the rails mode is set incorrectly. The side effects of this are zero scroll deltas which also fires a DCHECK in mouse_wheel_event_queue.cc: DCHECK(needs_update). To repro use an apple mouse and scroll vertically and then horizontally using the bidirectional wheel. Bug: 862661 Change-Id: I4e5210454fe7352ab0230b312f44e1a374f22f0c Reviewed-on: https://chromium-review.googlesource.com/1134434Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#577296}
-
Dan Elphick authored
String::Utf8Length and StackTrace::GetFrame should now be called with an Isolate, which means gin::V8ToString now needs an Isolate hence the cascade of changes. Change-Id: I03f3bb91a2e985626bfa62dc1b4cd0874d00630d Reviewed-on: https://chromium-review.googlesource.com/1146651Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#577295}
-
Justin Novosad authored
This reverts commit 56151bcd. This reland fixes the MSAN error from the original CL by making sure the filter_quality field of CanvasResource is always initialized TBR=zmo@chromium.org Bug: 788439 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7dd29f123cbfd75598005532fc5b2135e6bfebc9 Reviewed-on: https://chromium-review.googlesource.com/1147317 Commit-Queue: Justin Novosad <junov@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#577294}
-
Avi Drissman authored
The shadow around the omnibox results popup eats mouse events. Manually forward events occurring in the shadow area to the underlying widget to fix the tab strip. BUG=864963, 838667 Change-Id: I5c6499f5d024863dad611f8670fb12e1a01ff073 Reviewed-on: https://chromium-review.googlesource.com/1144225 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#577293}
-
Dan Elphick authored
This convert one ToString to use the Isolate form in v8_script_runner.cc rather than ToString(Context), as the no-argument form is the more immediate problem. Change-Id: I0d79f29fd937458cbaf8bb0342b8c4efa8b5ee1c Reviewed-on: https://chromium-review.googlesource.com/1146805Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#577292}
-
Tommy Steimel authored
This CL re-adds media type UMA metrics to the MediaLauncherActivity. In order to prevent the native initialization issues from the previous CL, this CL uses CachedMetrics to only record once native is initialized. Bug: 861954 Change-Id: I424dc1c6d8d65a031c573375f3cf1686ec1f6614 Reviewed-on: https://chromium-review.googlesource.com/1138978 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#577291}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9e8a0b2b37d9..1381813c377d git log 9e8a0b2b37d9..1381813c377d --date=short --no-merges --format='%ad %ae %s' 2018-07-23 nednguyen@google.com Increase default timeout limit of setting tsproxy's traffic settings to 20 seconds 2018-07-23 nednguyen@google.com Add '--story-shard-begin-index' and '--story-shard-end-index' flags 2018-07-23 nednguyen@google.com Fix PRESUBMIT errors in catapult Created with: gclient setdep -r src/third_party/catapult@1381813c377d The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:865250,chromium:866095,chromium:866260 TBR=sullivan@chromium.org Change-Id: I0f4b0a06fa6b8e5312fbbd6f6385910004841801 Reviewed-on: https://chromium-review.googlesource.com/1147060Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577290}
-
Victor Costan authored
This CL is extracted from https://crrev.com/c/1137851 because that CL may uncover brokenness and get reverted. Landing these changes separately minimizes the impact of a potential revert. Bug: 863724 Change-Id: I9b8888faf7a736f086ca5e496f85a78e0754a0c5 Reviewed-on: https://chromium-review.googlesource.com/1145837Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#577289}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/94ef424b3160..a76af0ca2e8c git log 94ef424b3160..a76af0ca2e8c --date=short --no-merges --format='%ad %ae %s' 2018-07-23 titovartem@webrtc.org Move base64.h to the proper location. 2018-07-23 titovartem@webrtc.org Fixing py lint errors 2018-07-23 saza@webrtc.org Revert "Add one-stop-shop for built-in AEC toggling in APM" 2018-07-23 saza@webrtc.org Add one-stop-shop for built-in AEC toggling in APM 2018-07-23 buildbot@webrtc.org Roll chromium_revision 5e7b1029..0aff707f (577041:577150) 2018-07-23 peah@webrtc.org AEC3: Added dumping to wav files for the filter outputs 2018-07-23 oprypin@webrtc.org Fix paths that were trying to go above the root by using too many "../.." 2018-07-23 sakal@webrtc.org Remove dead code from videoframe.cc. 2018-07-23 oprypin@webrtc.org Add `is_android` guard to all Android rule usages. 2018-07-23 mbonadei@webrtc.org Fixing -Wsign-compare errors. Created with: gclient setdep -r src/third_party/webrtc@a76af0ca2e8c The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib0cb33a4564e1a989eba594282c3599353bb8fbd Reviewed-on: https://chromium-review.googlesource.com/1147063Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577288}
-