GitLab

Loading the owner key is a prerequisite to making stored device (policy)
settings available over DeviceSettingsService, which can be user visible
for many uses. Thus increase the priority of loading the public key (in
the async path) to base::TaskPriority::USER_VISIBLE.

This also fixes current issues with enrollment in autotest by avoiding a
race condition where a DeviceSettingsService::Load operation started at
chrome process start finishes during the active enterprise  enrollment
process. The fix for the root cause of that is tracked in
https://crbug.com/1001822 .

Bug: 979195
Test: in cros_sdk: test_that --board=${BOARD} ip_addr policy_DeviceServer.AllowBluetooth_notset passes
Change-Id: I5e430d704137b0e8f6e23e4eea26346ec86834a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791143Reviewed-by: A Olsen <olsen@chromium.org>
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694693}

This reverts commit 5abd4a9f.

Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/linux-gcc-rel/108347


Original change's description:
> infra: Re-migrate linux-ozone-rel to Goma RBE
> 
> This was previously reverted due to reaching the Goma RBE server
> capacity limit.
> https://chromium-review.googlesource.com/c/chromium/src/+/1786872
> 
> The limit has since been increased.
> 
> R=​bpastene@chromium.org, jbudorick@chromium.org, tikuta@chromium.org
> 
> Bug: 1001231,950413
> Change-Id: I820be1e6128db0d6ff16c9e8d3b12207db71cf92
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789220
> Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> Commit-Queue: Simon Que <sque@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#694653}

TBR=sque@chromium.org,tikuta@chromium.org,bpastene@chromium.org,jbudorick@chromium.org

Change-Id: Ib0e1e6fe8fb7768247dcd7ce1383c583c75e70dd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1001231, 950413
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792505Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694692}

Full Sync uses the profile storage, so if we don't clear the
account storage we'll get duplicates.

Bug: 998455
Change-Id: Ia60fc39cc9de36ab21d2105641062f6f6373f426
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789526
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694691}

This CL removes node.h dependency from many of binding-generated .cc
files.

This CL doesn't change compiled code at all on macOS with the current
toolchain.

Bug: 242216
Change-Id: I0d00edad349b08960d7d0c0c16f42cc3cd4c5273
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789208
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694690}

For workers and webview, the v8 extras versions of CountQueuingStrategy
and ByteLengthQueuingStrategy were being used even when StreamsNative
was enabled.

Stop adding the queuing strategies unconditionally to the global in the
v8 extras JavaScript. Instead put them on the binding object, and only
copy them to the global in InitializeV8ExtrasBinding() if the
StreamsNative feature is not enabled.

This is a reland of
https://chromium-review.googlesource.com/c/chromium/src/+/1757411
modified to let values be copied to the bindings object even
when they are not needed because we are using the C++ implementation.

This modification is sufficient to avoid triggering a leak in
http/tests/clipboard/async-write-image-read-image.html, which was
the cause of the original CL being reverted.

BUG=994324

Change-Id: I29ccdc69a09027d1f89af859d002e8ac7fd4583e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787623Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694689}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/27325b90a86c..8629d82b7f98


Created with:
  gclient setdep -r src-internal@8629d82b7f98

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: Iee275c71806866077aa660f34b46690d20549e8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791790Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#694688}

Using wpt-import in Chromium 4c33cade.
With Chromium commits locally applied on WPT:
1f146124 "[WPT/common/security-features] Remove {mixed-content,referrer-policy}-test-case.sub.js"
bfd6ddf8 "[WPT/common/security-features] Update subresource and redirection type names"
9d7721df "Strip the fragment directive and update scroll-to-text WPT"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=lpz

No-Export: true
Change-Id: Ib83aa8d1d19c973b3f88d3a4f6dac4862c14a97f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792305Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#694687}

https://chromium.googlesource.com/angle/angle.git/+log/a7ff7df26f28..4f431ad17465

git log a7ff7df26f28..4f431ad17465 --date=short --no-merges --format='%ad %ae %s'
2019-09-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src b218ad19949f..76261e2a7df1 (1 commits)

Created with:
  gclient setdep -r src/third_party/angle@4f431ad17465

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC syoussefi@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=syoussefi@chromium.org

Bug: chromium:None
Change-Id: I56cf54188f8021865b3a9aa96ccd84c2eb438407
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791788Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#694686}

Each proto corresponds to one print job.

Bug: 992889
Change-Id: Ib63b3b6c9c90ef990ecfe008b954ce5bc13dd648
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771605Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com>
Cr-Commit-Position: refs/heads/master@{#694685}

Legacy supervised users were eliminated in M75; this CL rips out the
corresponding IdentityManager support.

Note: This CL makes the minimal changes to SupervisedUserService to
eliminate the usage of these APIs; followup elimination of now-dead
flows in that class should be possible.

Bug: 860492
Change-Id: Id503f5473304a146e71e3c513d3b5018f4cb31cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729631
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694684}

Translations are not always under the application control and they can
contain special characters. If they are used in HTML context then this
can result in XSS.

This change addresses it by escaping < in chrome.i18n.getMessage before
substituting the placeholders (which often contain trusted HTML) if the
new {escape_lt: true} option is set.

This will be used by Closure Templates which generate
goog.getMsg('', {}, {html: true}) which will be translated by Closure
Compiler to chrome.i18n.getMessage('', {}, {escape_lt: true}) for
Chrome extensions.

Bug: 989413
Change-Id: I5c56af375dc443a0f6fc7ebddc038fb4a074db3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728572
Commit-Queue: Jakub Vrana <jakubvrana@google.com>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Auto-Submit: Jakub Vrana <jakubvrana@google.com>
Cr-Commit-Position: refs/heads/master@{#694683}

This fixes a UAF when closing a tab while there is a
SharingDialog open.

Bug: 1000934
Change-Id: Ie8f6e52626ee834bc72acfe318c5a28aafe27635
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789150
Commit-Queue: Alex Chau <alexchau@chromium.org>
Reviewed-by: Alex Chau <alexchau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694682}

We made ScriptValue Traceable to replace SharedPersistent
with TraceWrapperV8Reference in a follow-up CL.

In this CL, most of the changes are just:
- Replace Vector<ScriptValue> with HeapVector<ScriptValue> because
ScriptValue has a Trace method.
- Add a trace method for ScriptValue because ScriptValue is traceable.
- Add a trace method for ScriptPromise because it has a ScriptValue.

We recommend you to mainly check
- script_value.h where I add VectorTraits.
- script_promise.h where I add VectorTraits.
- v8_callback_function.py where I add a code to generate HeapVector.
- v8_types.py
 * Add ScriptValue and ScriptPromise to "is_traceable==True"
which is used to generate Trace method for ScriptValue and ScriptPromise.
 * Add ScriptValue and ScriptPromise to "is_gc_type==True"
which is used to generate HeapVector instead of Vector.

Bug: 998994
Change-Id: I595a87636464e9fbf30533373995b61c89e464b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787483
Commit-Queue: Rika Fujimaki <rikaf@google.com>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694681}

This reverts commit 48946365.

Reason for revert: https://crbug.com/1001905

Original change's description:
> Rolldep for QUICHE and update QUIC flags.
> 
> 
> Roll src/net/third_party/quiche/src/ 43652ca17..b2486b8ca (10 commits)
> 
> https://quiche.googlesource.com/quiche.git/+log/43652ca1735a..b2486b8ca513
> 
> $ git log 43652ca17..b2486b8ca --date=short --no-merges --format='%ad %ae %s'
> 2019-09-06 wub gfe-relnote: (n/a) Update QuicIetfFramerTest.(Application|Connection)Close to use the new QuicConnectionCloseFrame constructor. Test only, not protected.
> 2019-09-06 dschinazi Deprecate quic_drop_invalid_small_initial_connection_id
> 2019-09-06 vasilvv Support the use of MESSAGE/DATAGRAM frames in QBONE.
> 2019-09-06 vasilvv Switch QuicMakeUnique to std::make_unique, part 1: //third_party/quic
> 2019-09-06 renjietang Remove QuicSession::RegisterStaticStream() and merge it into QuicSession::ActivateStream().
> 2019-09-06 fkastenholz Add version-aware QuicConnectionCloseFrame constructor
> 2019-09-06 renjietang Use QuicSession::transport_version() instead of QuicConnection::transport_version() to make code cleaner.
> 2019-09-06 fayang gfe-relnote: n/a (TODO added)
> 2019-09-06 fkastenholz Change Application and Transport ConnectionClose codes to uint64_t
> 2019-09-06 wub gfe-relnote: (n/a) Only increment flag count for quic_simple_inflight_time when the flag is true. Flag count only.
> 
> Created with:
>   roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src
> 
> R=​rch@chromium.org
> 
> Change-Id: I6a831fe8ab9072a639d8f6f9e16c617b325d2b0b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790486
> Commit-Queue: Bin Wu <wub@chromium.org>
> Commit-Queue: Ryan Hamilton <rch@chromium.org>
> Reviewed-by: Ryan Hamilton <rch@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#694539}

TBR=rch@chromium.org,wub@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I4147cfcd0f7cb488884a730e32e0a1f2a71b0b84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791145Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694680}

This patch changes the default values as below:
--websocket-renderer-receive-quota-max:
32768-> 65500
--websocket-read-buffer-size
32768-> 131000

Performance improvement:
Win10(ToT->Patch@MB/s):
 270->362
Linux(ToT->Patch@MB/s):
 543->683

Because this change makes Chrome consume much memory and the request
is from desktop user, we've decided to leave values for Android as-is.

Bug: 865001
Change-Id: I5803f60f55f7aef375c896e5a0090db1c1481dfb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792208
Auto-Submit: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694679}

Change-Id: I3882a3d0a1e49beb08c8b998a2ac10e39fa7cf74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789218Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694678}

Only the root element and ::backdrop pseudo elements inherit style from
the initial styles.

Ideally, per spec, we should only compute style for elements in the flat
tree, but that requires careful deprecation/unshipping. That's why we
need to add non-slotted shadow host children (they don't have a flat
tree parent to inherit styles from).

This CL is preparing for flat tree style recalc traversal.

Bug: 972752
Change-Id: I25bc186cb358b483d3017e336877d0ef8467d9b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789293
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694677}

Before this patch, moving callback was executed only if there was a slot
associated with it. Floating garbage was not taken into account - that
led to problems if finalization of backing store relied on the callback
being executed. This was the case for HeapLinkedHashSet, backing
store values of which unlinked themselves from other values. Another
issue was when a collection was reallocated during incremental marking
and the corresponding callback for the old backing store was not
executed or the callback was not associated with the new region.

This patch associates backing stores with moving callbacks (as opposed
to slot -> callback, which was before) so that the moving callback is
always executed.

This fixes crashes having FinalizerTrait<LinkedHashSet<Member<...>>> in
their signatures.

Bug: 992506
Change-Id: Ib397988ba0d790496b948c6f79fc68a6e608d1b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773152
Commit-Queue: Anton Bikineev <bikineev@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694676}

The 4GB limit is causing real-world problems, especially for big
WebAssembly workloads.
After ref-counting is checking for overflows
(https://crrev.com/c/1622483), there is no reason to keep the limit
that low. This CL increases it to 16GB.

R=palmer@chromium.org

Bug: 912764
Change-Id: I13ab10640a578eb6835a94128ff40c2e0a6a2e49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786446
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694675}

This CL adds a feature flag for using the App Service to provide data
for intent handling.

BUG=853604

Change-Id: I3d67dcb56071bc958e598459fb2c68fdc2d9fd4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792034
Commit-Queue: Maggie Cai <mxcai@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694674}

TBR: wittman@chromium.org
Bug: 1001923
Change-Id: Ib2e5f19650f6ac4dbda6586f6e4e3dd64e3b8182
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789153Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694673}

Now the tests run without OOR-CORS on CQ and try. But we already
have oor-cors fyi bot to run major tests with OOR-CORS enabled.

# Please update test expectations for flaky tests

NOAUTOREVERT=true

Bug: 1000554
Change-Id: Ie4fbee82495640effb974304409467719613e4b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786375
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694672}

This CL applies pending_remote to VideoCaptureObserver argument
int VideoCaptureHost::Start.

 - Convert mojo::Binding to mojo::Receiver
 - Convert VideoCaptureObserverPtr to mojo::PendingRemote<>.

Bug: 955171
Change-Id: I8943efcd102ad265b3b7b95553a0123f0f1684b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777347Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#694671}

This reverts commit 7c516511.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> [ios] Enable SlimNav and dependent features by default.
> 
> Tentatively enabling this by default for M79.
> 
> Bug: 789582
> Change-Id: I030902ddbb1a19f5b49a847b727c439cfd10fcf9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787885
> Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> Reviewed-by: Gauthier Ambard <gambard@chromium.org>
> Reviewed-by: Eugene But <eugenebut@chromium.org>
> Commit-Queue: Justin Cohen <justincohen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#694620}

TBR=rohitrao@chromium.org,justincohen@chromium.org,eugenebut@chromium.org,gambard@chromium.org

Change-Id: Idb139bf5eed97036ccd2d0f26d331db77786b6e8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 789582
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789152Reviewed-by: Yi Su <mrsuyi@chromium.org>
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694670}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/chrome.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

Edit: Revert changes in v8_unit_test.h

R=treib@chromium.org

Bug: 891670
Change-Id: I20b5a2f1635c3b515370ea689d2515b4536c9b83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787103
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Auto-Submit: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694669}

Enable views_unittests for Ozone/X11 platform and add a filter
file, which disables crashing/failing tests.

Bug: 1001075
Change-Id: I2b4cd26ccdae8d86e78f020a653e042daad4edb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787646Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#694668}

Service worker tests had its own mechanism to override the network
factory, called EmbeddedWorkerTestHelper::SetNetworkFactory(). But this
doesn't set the network factory for StoragePartitionImpl, which we'll
need for ServiceWorkerOnUI, and it doesn't play well with the mechanism
used by other tests, URLLoaderInterceptor. Remove the
EmbeddedWorkerTestHelper mechanism in favor of the standard mechanism.

Also extend URLLoaderInterceptor to override the factory of
MockRenderProcessHost, which service worker tests use.

This CL enables "*ServiceWorker*" content_unittests to pass when
ServiceWorkerOnUI is enabled.

Bug: 1001435, 824858
Change-Id: Ibccb0fc2c04c6f9cbd55bc89f081caaf6edb9072
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786710Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694667}

This causes failing dchecks if we call on an unconnected shadowroot,
which turns out to be allowed!

Bug: 999874
Change-Id: Iecaa3786817cacaf4ffb02809c44a0c104fcdb6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792203
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694666}

Close and CloseNow were move to DWTHPlatform. The same was done with the
container of children DWTH.

Bug: 990756
Change-Id: Ic09852c3a22e780738d98da3f4fdfee4a6741a52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771407
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694665}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/dbus.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

R=hashimoto@chromium.org

Bug: 891670
Change-Id: I05ed8a9c81b692d2deda1ebb32abfce3011f15cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786754
Auto-Submit: Gabriel Charette <gab@chromium.org>
Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694664}

Instead, all the call sites should DCHECK if extension is enabled.

BookmarkAppFinalizer is ready for the situation when Extension gets disabled
and listed in disabled_extensions() instead of enabled_extensions().

BookmarkAppFinalizer (and the install pipeline) returns kWebAppDisabled error
in this case.

Drive by: Rename the function as GetEnabledExtension.

Bug: 993666
Change-Id: I6dd8aca33f4f123e63bfd063a022e86512c2f8e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792033
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694663}

This CL implements permission-item using the toggle-row element,
removing the need for a permission-toggle.

Bug: 999896
Change-Id: I49be9065eee6731adc6e2718cd0fdb7b4d022410
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784238
Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Auto-Submit: Jeevan Shikaram <jshikaram@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694662}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/chromeos/cryptohome.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

R=hashimoto@chromium.org

Bug: 891670
Change-Id: I682201afc209ceed93ea2f248580506db382fe5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787076
Auto-Submit: Gabriel Charette <gab@chromium.org>
Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694661}

This tests whether the contentSize property exists and if it does,
uses rendersubtree and contentSize.

Bug: 1001293
Change-Id: Ifef8d60388d865d119b19de872a2cfe69504b16c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787494
Commit-Queue: Fergal Daly <fergal@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694660}

https://skia.googlesource.com/skia.git/+log/7588f07cd928..627d15588f4d

git log 7588f07cd928..627d15588f4d --date=short --no-merges --format='%ad %ae %s'
2019-09-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 df0ce01870fa..a7ff7df26f28 (5 commits)
2019-09-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 64926377..a0cef9f5 (522 commits)

Created with:
  gclient setdep -r src/third_party/skia@627d15588f4d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=mtklein@google.com

Bug: chromium:None,chromium:None
Change-Id: I0fd4435c1ff6dc72db446c2828d39838ca6e5d8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791785Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#694659}

It seems we should check if WorkerScheduler is ready in
CallOnAllWorkerThreads() because:
* The ctor of WorkerThread adds itself to WorkerThreads().
* WorkerScheduler is initialized when Start() is called.
* WorkerThread::CallOnAllWorkerThreads() can be called
  at any time.

The above things imply that WorkerScheduler may not be
ready when CallOnAllWorkerThreads() is invoked. Skip
calling the given function on threads which don't have
a valid WorkerScheduler.

This should be safe because the only callsite of
CallOnAllWorkerThreads() is SetIcuTimeZoneAndNotifyV8().
The purpose of the SetIcuTimeZoneAndNotifyV8() seems
to notify timezone changes to V8 isolates. Since we
initialize a V8 isolate for a worker after WorkerScheduler
is initialized, we don't have to care about workers
which don't have scheduler.

Bug: 1000077
Change-Id: I7476cefcbebd323a7f95c0dcb06eec62ec28b25a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792028
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694658}

This is a reland of 5c872c1a

Original change's description:
> IDL: Fix invalid extended attributes
> 
> An invliad extended attribute [Enabled] was used in IDLs of WebRTC,
> and some APIs are visible regardless a runtime enabled feature.
> This CL fixes the IDL description and hide them behind a flag.
> 
> 
> Bug: 999690, 986069
> Change-Id: I1214c717706f52dacdc0648aa8d8ddeb951ea888
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781923
> Reviewed-by: Harald Alvestrand <hta@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> Reviewed-by: Florent Castelli <orphis@chromium.org>
> Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#693038}

Bug: 999690, 986069
Change-Id: I9d225027c377935ca70948359887096a701275c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792036Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694657}

aluo@ is a committer now (for 3+ months), so this is a reland of
https://crrev.com/c/1419901 (but adding in the cts_archive, since it's
related).

Test: N/A
Change-Id: Ic1c0890c89a3ec64d69340525a2e7f123930ef91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790387
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Andrew Luo <aluo@chromium.org>
Reviewed-by: Andrew Luo <aluo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694656}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d0fb30ed6419..27325b90a86c


Created with:
  gclient setdep -r src-internal@27325b90a86c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I6fa2eb6e11246fa5cba0deade92857682c56b975
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791784Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#694655}

TBR=rego@igalia.com

Bug: 1001817, 1001816, 1001814, 1001928
Change-Id: If8682aff08adb18675d2fd0c18daa77711a90095
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792037Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694654}