- 16 Nov, 2018 40 commits
-
-
Akihiro Ota authored
Build on existing naive PosInSet and SetSize implementation to handle cases such as inconsistent or invalid assignments of kPosInSet and kSetSize attributes Change-Id: I966f3ad00e778e0d68bcb48d160f1be5818b587b Reviewed-on: https://chromium-review.googlesource.com/c/1340523 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#609017}
-
Justin DeWitt authored
Bug: 904986, 906151 Change-Id: I5aef21b730446234742c2420435aeba8fb81f76e Reviewed-on: https://chromium-review.googlesource.com/c/1334274 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#609016}
-
Asanka Herath authored
Under several circumstances, the network transaction or the HttpAuthController may invalidate an authentication handler with the intention of retrying the same transaction. During this process, any sources of identity that were consumed should be made available for reuse. Otherwise the behavior of the retry operation could end up being wildly different from the original transaction. This is particularly pronounced when dealing with HttpAuthHandler implementations that support both ambient and explicit credentials. For those, the retry attempt will switch from ambient to explicit identity. This CL updates HttpAuthController to restore the identity source such that the retry correctly attempts the ambient identity again. Bug: 857228 Change-Id: If4a9cfa30aa0ddb996a4856ae282c7f7358dce7b Reviewed-on: https://chromium-review.googlesource.com/c/1329902Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#609015}
-
Florin Malita authored
In the presence of an opaque background, BoxPainterBase::PaintNormalBoxShadow() insets the shadow clip by one unit (in order to mitigate seaming artifacs), effectively expanding the shadow inwards, and relies on the opaque background overdrawing this inset. But <body> doesn't paint its own background -- it gets transferred to the view and painted in a different context => the shadow inset remains visible. To address this, pass background-skip information to PaintNormalBoxShadow(), and disable the inset logic when the background is not being drawn. Bug: 899342 Change-Id: I5e04a1c17c2be324bf4c6767d2159372f546cc24 Reviewed-on: https://chromium-review.googlesource.com/c/1336495 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#609014}
-
Gabriel Charette authored
Aligning with the POSIX impl in preparation for https://chromium-review.googlesource.com/c/chromium/src/+/1283010 Also adds two trivial ScopedAllowBaseSyncPrimitivesForTesting around existing thread joins in tests (more advanced changes were extracted to precursor CLs). Bug: 707362 Change-Id: If4c4c49b4a20554518ca4a25ae1ea16b84d3a510 Reviewed-on: https://chromium-review.googlesource.com/c/1324370 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#609013}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5705acabe03a..6343daaa40fe git log 5705acabe03a..6343daaa40fe --date=short --no-merges --format='%ad %ae %s' 2018-11-16 iannucci@chromium.org [led] Update led to latest version. Created with: gclient setdep -r src/third_party/depot_tools@6343daaa40fe The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I694e2a34951176ccb92e51f278ebdb3204cc3a36 Reviewed-on: https://chromium-review.googlesource.com/c/1340396Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609012}
-
Eugene But authored
This fixes the issue when side swiping from one SadTab to another. Since -[SadTabCoordinator start] is idempotent it is important to start coordinator for new sad tab, not for the old one which is not visible anymore. Bug: 901563 Change-Id: I9dfb488037da18be5fdb1079e849b723fa723c08 Reviewed-on: https://chromium-review.googlesource.com/c/1337814 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#609011}
-
Leonard Grey authored
This should cover: - Infobar - Detached bookmark bar - Avatar menu text (but not icons yet) - Default bookmark icon - Toolbar buttons - Secondary UI controls Bug: 850098 Change-Id: I6583f06e9470e320826f766e18d9c6e9141b75fa Reviewed-on: https://chromium-review.googlesource.com/c/1337793 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#609010}
-
Saman Sami authored
Observe mojo connection errors and re-establish the connection once it's lost. Bug: 780514 Change-Id: Ic393f737bee97b97ed588ea47040327a4b639a4b Reviewed-on: https://chromium-review.googlesource.com/c/1340945Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#609009}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c1d08bca895a..721662b8ce13 Created with: gclient setdep -r src-internal@721662b8ce13 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8b8ad31d13e61679c68d93467c11b1eb136c195b Reviewed-on: https://chromium-review.googlesource.com/c/1340392Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609008}
-
Greg Kraynov authored
TaskQueues shouldn't be confused with task runners. Bug: 865411 Change-Id: Ibc37eb30de002f126a76231122f77c16fc3e8e35 Reviewed-on: https://chromium-review.googlesource.com/c/1336470Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Greg Kraynov <kraynov@chromium.org> Cr-Commit-Position: refs/heads/master@{#609007}
-
danakj authored
The early out comes from initial.commit, but I think it was not needed even then. We also RemoveRoute for the IPC channel in OnClose() which means no new IPCs can arrive. Then GetWebWidget() will return null after the OnClose() is fully handled, so by then there are no IPCs. RenderViewImpl can also route messages to RenderWidget, which could violate the above, but OnWasShown is only sent to the RenderWidget's routing id. R=avi@chromium.org Change-Id: I19438c840c916cb09da8a26e265d390558dbca70 Bug: 896836 Reviewed-on: https://chromium-review.googlesource.com/c/1340483Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#609006}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/28d8d7bc673a..8e9be303b00b git log 28d8d7bc673a..8e9be303b00b --date=short --no-merges --format='%ad %ae %s' 2018-11-16 dneto@google.com Validator: Support VK_EXT_scalar_block_layout Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@8e9be303b00b The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I23f0fb768b6ba97bad5b4ef0fe123752846b4d4c Reviewed-on: https://chromium-review.googlesource.com/c/1340394Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609005}
-
Ryan Hansberry authored
Bug: 906162 Change-Id: I564bcbf2ac8c600e357f10ffaf085279ab7fe12e Reviewed-on: https://chromium-review.googlesource.com/c/1340954Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#609004}
-
Shawn Gallea authored
Move stylus_tools interface out of server.cc This CL only moves code around. Bug: 896710 Test: Built on ChromeOS Change-Id: Ie891710ea8df139f49ae350cd40ec9f083870460 Reviewed-on: https://chromium-review.googlesource.com/c/1324141 Commit-Queue: Shawn Gallea <sagallea@google.com> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#609003}
-
Eric Karl authored
Threading issues have been fixed. Re-enabling. Bug: 529678 Change-Id: Ie8b0a3ed0821bc388f678f45b418e75794e3a063 Reviewed-on: https://chromium-review.googlesource.com/c/1336490Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#609002}
-
Joe Mason authored
R=csharp@chromium.org Bug: 830892 Change-Id: Ib3157dc17c2e2c7738f6b2a6af7d88ed72eb4d33 Reviewed-on: https://chromium-review.googlesource.com/c/1338402Reviewed-by:
Chris Sharp <csharp@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#609001}
-
James West authored
Bug: internal b/118727323 Test: manual Change-Id: I9623edf4e221d477d9e44b63357f86092b24f332 Reviewed-on: https://chromium-review.googlesource.com/c/1338112Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: James West <jameswest@chromium.org> Cr-Commit-Position: refs/heads/master@{#609000}
-
Theresa authored
Update the TRIGGER_EVENT description in ukm.xml to accurately reflect the values recorded. This update was missed in previous patchset that added metrics for the toolbar button triggering UI. BUG=859563 Change-Id: Ia270c452195a46120802d6de00032583007f7459 Reviewed-on: https://chromium-review.googlesource.com/c/1333998Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#608999}
-
Andrew Grieve authored
Change-Id: I4f0b2cf77e12561743380a192d20d1c6d438cd2f Reviewed-on: https://chromium-review.googlesource.com/c/1324145Reviewed-by:
David Turner <digit@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#608998}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/4d0fac4a2c9e..75d214c50d2f git log 4d0fac4a2c9e..75d214c50d2f --date=short --no-merges --format='%ad %ae %s' 2018-11-16 tsepez@chromium.org Pack XFA_SCRIPTATTRIBUTEINFO tighter on 64-bit platforms 2018-11-16 thestig@chromium.org Remove DOS line endings from bug_713197.in. 2018-11-16 tsepez@chromium.org Use macros to deselect strings in cxfa_node_statics.cpp 2018-11-16 thestig@chromium.org Fix some nits in CBC_PDF417HighLevelEncoder. 2018-11-16 thestig@chromium.org Make CBC_PDF417HighLevelEncoder::encodeText() faster. 2018-11-16 thestig@chromium.org Use the {{trailer}} macro in more PDFs. 2018-11-16 tsepez@chromium.org Add tests for radiobutton/checkbox JS properties. 2018-11-16 tsepez@chromium.org Remove unused strings from XFA_SCRIPTATTRIBUTEINFO. Created with: gclient setdep -r src/third_party/pdfium@75d214c50d2f The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:902302 TBR=dsinclair@chromium.org Change-Id: I6b3dde8c5ecc8da9a4737fd36746bdcc7e7bcd3a Reviewed-on: https://chromium-review.googlesource.com/c/1340393Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608997}
-
Hans Wennborg authored
This is part of cleaning up for a new Clang warning that's currently disabled: ../../chrome/chrome_cleaner/scanner/urza_scanner_impl_unittest.cc(121,3): error: explicitly defaulted default constructor is implicitly deleted [-Werror,-Wdefaulted-function-deleted] TestScanner() = default; ^ ../../chrome/chrome_cleaner/scanner/urza_scanner_impl_unittest.cc(119,21): note: default constructor of 'TestScanner' is implicitly deleted because base class 'chrome_cleaner::UrzaScannerImpl' has no default constructor class TestScanner : public UrzaScannerImpl { ^ Bug: 890307 Change-Id: I0ae013e278b85ae3ea706b1ecb716d5382a32132 Reviewed-on: https://chromium-review.googlesource.com/c/1340316 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#608996}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/a2c529b5dda1..7cb43009d543 git log a2c529b5dda1..7cb43009d543 --date=short --no-merges --format='%ad %ae %s' 2018-11-16 dj2@everburning.com Add option to skip examples. Created with: gclient setdep -r src/third_party/spirv-headers/src@7cb43009d543 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-headers-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I313986008cf3d7a94fbc36f8c5b41ee325d557cc Reviewed-on: https://chromium-review.googlesource.com/c/1340395Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608995}
-
Sigurdur Asgeirsson authored
At present this is only done at navigation time, which can leave frames disconnected from their hosting process. Bug: 901828 Change-Id: I611eafebe5e7e54c046def38bbaf5b348dedfcb9 Reviewed-on: https://chromium-review.googlesource.com/c/1318405 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#608994}
-
Eric Stevenson authored
This reverts commit 4a1125d8. Reason for revert: Issue fixed elsewhere. See crbug.com/905230. Original change's description: > Android: manually list test for multidex on all platforms. > > This small change removes the KitKat restriction for manual > listing of tests. > > Bug: 905230 > Change-Id: Ib66544873017fd0c5261af0ad1d57358ea97a167 > Reviewed-on: https://chromium-review.googlesource.com/c/1337493 > Reviewed-by: Eric Stevenson <estevenson@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: Matthew Cary <mattcary@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608446} TBR=mattcary@chromium.org,estevenson@chromium.org,jbudorick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 905230, 906181 Change-Id: I029036b3b529cad6c3e84933ea1827484d2d02fc Reviewed-on: https://chromium-review.googlesource.com/c/1340960 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#608993}
-
Lukasz Suder authored
Bug: 806868 Change-Id: I1006e4cb3e2d77a2a83b2a1a00d5aacd70aba820 Reviewed-on: https://chromium-review.googlesource.com/c/1340269Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Lukasz Suder <lsuder@chromium.org> Cr-Commit-Position: refs/heads/master@{#608992}
-
Tibor Goldschwendt authored
To make this work this CL adds a specific build of the Play Core SDK that exposes a verification method. Bug: 901920 Change-Id: Icbf15a17f9345085d8ccd812d50d208f5279fe49 Reviewed-on: https://chromium-review.googlesource.com/c/1338563Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#608991}
-
Jacob Dufault authored
Validate that we can show the lock screen, enter a bad password, and then enter a good password. Bug: 899777 Change-Id: Ie3c8ff629524374362db5fe51f648defdf5331dc Reviewed-on: https://chromium-review.googlesource.com/c/1323701 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#608990}
-
Robert Liao authored
This seems to work fine with gtest_repeat=100. BUG=613428 Change-Id: I045735c4174c8656bfa8d51669142385d35f1233 Reviewed-on: https://chromium-review.googlesource.com/c/1340793Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#608989}
-
Jesse Selover authored
https://boringssl.googlesource.com/boringssl/+log/e6eef1ca16a022e476bbaedffef044597cfc8f4b..f241a59dcca617c5b9d9880a8a9fd92996a654be The following commits have Chromium bugs associated: f241a59dc In 0RTT mode, reverify the server certificate before sending early data. Bug: 347402 Change-Id: I3c4e186cf94b8338cea5fa8ec0000d960923500f Reviewed-on: https://chromium-review.googlesource.com/c/1340825 Commit-Queue: Jesse Selover <jselover@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#608988}
-
Stephen McGruer authored
Previously we would get writing-modes/directionality completely wrong for composited ScrollTimelines. This CL teaches cc::ScrollTimeline about 'reverse' axes, without exposing the concepts of writing-mode or directionality to it. Bug: 906115 Change-Id: Id843668956b0766469148c1ae6ad33fca582ba63 Reviewed-on: https://chromium-review.googlesource.com/c/1310567 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#608987}
-
gogerald authored
Bug: 806868 Change-Id: Ia8700f880c820f05e4b231d2833db24d61c5484b Reviewed-on: https://chromium-review.googlesource.com/c/1340951Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#608986}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/eee39206a2f6..b5bb51306614 git log eee39206a2f6..b5bb51306614 --date=short --no-merges --format='%ad %ae %s' 2018-11-16 yvesg@webrtc.org Disable RTCStatsIntegrationTest.GetsStatsWhileDestroyingPeerConnection 2018-11-16 srte@webrtc.org Exposing audio and video engines directly. Created with: gclient setdep -r src/third_party/webrtc@b5bb51306614 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia386fdcd67c3b653efdcf8c0b672aca178fc33c4 Reviewed-on: https://chromium-review.googlesource.com/c/1340576Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608985}
-
Ehsan Karamad authored
This CL adds support for generating violation reports for 'layout-animations' feature policy. The new implementation triggers a report when: 1- CSS Parser finds usage of @keyframes for one of the banned styles. 2- element.animate() changes a banned style. Bug: 902836,867471 Change-Id: I79900603eb0166514d7986dc189ec914bd95f899 Reviewed-on: https://chromium-review.googlesource.com/c/1324138 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#608984}
-
David Black authored
A previous version of this CL was reverted because it caused any cards in the first Assistant response to be laid out with zero width: https://chromium-review.googlesource.com/c/chromium/src/+/1336525 This was caused by UiElementContainerView's width being set to zero due to its flex behavior when animating growth for the first time. We now impose a minimum height restriction on UiElementContainerView so that its width will not be set to zero and cards, which are sized according to the width of UiElementContainerView, will be laid out appropriately. Bug: b:119498360 Change-Id: I7c7a85aa1f3b506ed6a0f6dbdca628ae639e232b Reviewed-on: https://chromium-review.googlesource.com/c/1338960Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#608983}
-
Danyao Wang authored
Navigating away from an app-specific URL in restored session history is a special case that requires a reload to trigger theclient-side redirect in restore_session.html. about:newtab, which is used by the BrowserContainerContainsNTP feature, should be treated as an app-specific URL for this case. This fixes the regression in NavigationTestCase/testRestoreHistoryToNTPAndNavigateForward after enabling BrowserContainerContainsNTP. Bug: 905688 Change-Id: I96d4612152a003f3c7275720a01eb6376c3ff806 Reviewed-on: https://chromium-review.googlesource.com/c/1340761 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#608982}
-
Robbie McElrath authored
Depending on the startup timing, it's possible for NetworkChangeNotifier to create additional net logging, which can cause flakes in the NetExportFileWriterTest test. Change-Id: Ifb2217440b44620dc04769dea5c409992065499a Reviewed-on: https://chromium-review.googlesource.com/c/1340913Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#608981}
-
khmel@chromium.org authored
This allows not to use expensive and fragile set of adb commands and returns ARC provisioning state as it appears in Chrome. TEST=in context of crrev.com/i/717828 BUG=b:119349367 Change-Id: I3582fcca3e36a084dbe8e0ff3522930504ebeb85 Reviewed-on: https://chromium-review.googlesource.com/c/1340797Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#608980}
-
Xiaohan Wang authored
The explainer has been updated to formalize the minHdcpVersion string format to be "1.0", "1.1" etc. This CL updates Chromium's implementation to use the new string format instead of the old format, e.g. "hdcp-1.0", "hdcp-1.1", etc. Bug: 709348 Test: Existing tests updated. Change-Id: I4fe1061077228564fd6931d9900cfd19553dcf09 Reviewed-on: https://chromium-review.googlesource.com/c/1338576Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#608979}
-
Micah Morton authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/9a5d5fab32aa..eb9630f2312f $ git log 9a5d5fab3..eb9630f23 --date=short --no-merges --format='%ad %ae %s' 2018-11-15 mortonm system_api: Add constant for IsFsNosymfollowEnabled dbus method. 2018-11-12 cmtm login: support creating ARC server socket in Chrome Created with: roll-dep src/third_party/cros_system_api Bug: 867807 Change-Id: Ic0ebfda7528c999e4dd45738a93156dafe727786 Reviewed-on: https://chromium-review.googlesource.com/c/1340566Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Micah Morton <mortonm@chromium.org> Cr-Commit-Position: refs/heads/master@{#608978}
-