- 09 Oct, 2019 40 commits
-
-
Michael van Ouwerkerk authored
The navigation that fails is in SetUpOnMainThread, before RunTestOnMainThread. Bug: 1011765 Change-Id: I23d551e7ccd57aeaf31d6aed2fac2a0c3be73c46 TBR: fdoray Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848377Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#704135}
-
Yutaka Hirano authored
https://github.com/whatwg/html/pull/1782 removed same-origin data URL flag from request We should follow that. Data URLs should be treated as same-origin. This is a follow up of https://crrev.com/5825804e1054dff6b812fa9df63c16777ad827a9. Bug: 1012624 Change-Id: I200d30d9c39a22b7dc395966a7df51426a335b43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849472 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#704134}
-
Miyoung Shin authored
This change converts InsecureInputService mojom interface client in blink to use BrowserInterfaceBroker. Bug: 936482 Change-Id: I29b03ddfadd7fbfb8e026039b751f22ee885b20f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844523 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#704133}
-
Ehimare Okoyomon authored
page. Previously, from the site settings page users could only create first party exception rules. Now added a checkbox to enable users to add new rules that affect third parties on a given website. https://screenshot.googleplex.com/VT4Zcb4Cp3Q.png Bug: 1009408 Change-Id: If7670d6928380d22303a68bfd60fc658136d5571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833586 Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#704132}
-
Tsuyoshi Horo authored
Loading local files from bundled exchanges file is prohibited. So no need to set FileURLLoaderFactory while loading bundled exchanges files. Bug: 995177 Change-Id: Ia3ce8a20d331be3a94cad89d3283e6b30b4975fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847604 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
-
Rune Lillesveen authored
Set appropriate NativeThemeBase colors when color-scheme is dark. Bug: 939811, 929098 Change-Id: I4bc7db9b5792f3b5bc4c2ca220e3ed61bff5e51d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835495 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#704130}
-
Christopher Cameron authored
This function never worked. - It should search the Chrome Apps folder for the bundle to delete. - Instead, it searched some path inside the profile path. Change WebAppShortcutCreator::GetApplicationsDirname to be a global GetChromeAppsFolder method. - DeleteAllShortcutsForProfile function doesn't have a WebAppShortcutCreator object, so it couldn't use the member function - Many test override the WebAppShortcutCreator::GetApplicationsDirname method. Add a SetChromeAppsFolderForTesting method to replicate this functionality. Change tests to explicitly set DIR_USER_DATA. - Ensure that the app data dir be a sub-path of the user data dir - This is required for BundleInfoPlist::IsForCurrentUserDataDir, called by DeleteAllShortcutsForProfile, to behave correctly. Bug: 1011951 Change-Id: I512566914ef918c9421cbc4605d1f464ab4dbccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846755 Auto-Submit: ccameron <ccameron@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#704129}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6092f6bc..50e5ba2d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id2d7714700e11fb120b29d5cbb433965d85163dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849232Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704128}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/713e9ad3279d..70a8316d8b67 git log 713e9ad3279d..70a8316d8b67 --date=short --no-merges --format='%ad %ae %s' 2019-10-09 perezju@chromium.org [Telemetry] Replace Speed>Telemetry with Test>Telemetry Created with: gclient setdep -r src/third_party/catapult@70a8316d8b67 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: None Change-Id: Ib7c5be9ec7f268fc6855a76069cc0574fb2bfa26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848898Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704127}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cb5338375637..9608b4a1db16 Created with: gclient setdep -r src-internal@9608b4a1db16 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I96b5480b11823310cd54afc7b634cd0c74de4e9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848897Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704126}
-
Mikhail Khokhlov authored
This CL turns on native handling of all output format for two benchmarks: power.desktop and startup.mobile. This is an experiment to make sure that Results Processor is ready to handle output formatting on all platforms. Bug: 981349 Change-Id: I760f51b8daf2594655cd9a2b4d05bb0fb21e7a89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841552 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#704125}
-
Thomas Tangl authored
- The sync icon is added. - When there is no description text (e.g. sync is on), the sync info is made a hover button. - The separator at the top is removed. Screenshots: https://drive.google.com/open?id=10kaxE5u_m6CgLaHZpf-6iz7LUK_T9Mcm https://drive.google.com/open?id=1rssB_Q6tRzYosA7p7Nep3JwINEajzaXH https://drive.google.com/open?id=1PwFOFAs_bAHseCarkAd7yo2f7-12J6ec Bug: 995720 Change-Id: Ie1eb23e6eb62bd7accfd67a7c522dd0365b995a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847913Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#704124}
-
Dominik Röttsches authored
This reverts commit 6e443093. Reason for revert: Causes failures on WebKit Linux Leaks and Webkit Linux MSAN, see https://crbug.com/1012652 Original change's description: > CompressionStream > > Implement compression for "gzip" and "deflate". That implementation is > hidden behing ExperimentalCompressionStream flag. > > For unit tests, we compress and stream and uncompress it with pako, and > we make sure its output is the same as our original data. > > Change-Id: I89dde0e06a07b695be93a3b4f81fa6b3ee80d760 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763344 > Commit-Queue: Adam Rice <ricea@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Adam Rice <ricea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#704009} Bug: 1012652 TBR=kinuko@chromium.org,ricea@chromium.org,yhirano@chromium.org,robertma@chromium.org,acomminos@fb.com,arenevier@fb.com Change-Id: I3d57975faa0206478048f518b53dcb617192b016 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849376Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#704123}
-
Clemens Arbesser authored
This CL fixes two bugs that caused flaky AA tests involving the bottom sheet: - First, the tests were waiting for |isDisplayed()| and then immediately calling |perform(click())|. This is flaky, because |isDisplayed()| succeeds with widets that are >= 50% on screen, but |perform(click))| requires >= 90%. During the initial bottom sheet animation, it was possible to click the button before it was completely visible. - Second, and more importantly, |waitUntilViewMatchesCondition| did not correctly wait for the full duration. Rather, if a matching view exists that did not fulfill the specified condition, it would erroneously return, because the thrown exception in that case was an |AssertionError| rather than a |NoMatchingViewException|. b/142317318 Bug: 990118 Change-Id: I0c47e92ac8e77ae804eff5f05ac2c80ce9d77082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848372Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#704122}
-
Marc Treib authored
This is a followup to crrev.com/c/1844969 and crrev.com/c/1845225. GetBestMatches now returns the best matches in a vector, instead of in a map keyed by username. Bug: 1011399 Change-Id: If539984b1b2538c0bb2c48a34fcd3d998707f7f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844989 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#704121}
-
Piotr Pawliczek authored
This CL activates ExternalPrintServers policy. BUG=chromium:902085 TEST=none Change-Id: I0f273326e8984f3bf6c5d99a7c1fd513e73216f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848006 Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#704120}
-
Gyuyoung Kim authored
This is a reland of 126c42bd There was no build error on Android with is_asan=true option. So, the original CL was not the culprit of the build error. Merge the original CL again. Original change's description: > Migrate CdmFactory to new Mojo type > > This CL applies pending_receiver to CreateCdm function > in CdmFactory interface. Additionally, this CL converts > mojo::StrongBindingSet to mojo::UniqueReceiverSet. > > Bug: 955171 > Change-Id: I4bc983708e394800c3a31d3d6a598a39381fa3b5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826755 > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> > Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Cr-Commit-Position: refs/heads/master@{#700895} Bug: 955171 Change-Id: I05175a44c4543cf6e2f99a710480a05377a5db50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830477Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#704119}
-
Kent Tamura authored
'states' is represented by blink::CustomStatesTokenList inherited from DOMTokenList. It passes a null QualifiedName to DOMTokenList as the associated attribute name. CustomStatesTokenList doesn't keep a serialized string, and 'value' getter serializes tokens on the fly. This CL doesn't contains changes for ':state()' pseudo class. The 'states' IDL attribute is behind a new runtime flag, CustomStatePseudoClass. Bug: 1012098 Change-Id: Icee5f1703f5930603117c1ba73994f3bbba4e2cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847606Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#704118}
-
Dominik Röttsches authored
Bug: 1005234, 1012627 Tbr: drott Change-Id: I7bfb08332643abcb050dbc494a803f37ce343300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848373 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
-
Christian Dullweber authored
Show a page explaining the effect of third-party cookie blocking. https://screenshot.googleplex.com/pWGgd3OzxK8.png Bug: 967668 Change-Id: I3f2167c455ac4ef3a4600f0d4483783bae95a763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835365 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
-
Oleg Davydov authored
Chrome management API (used, for example, by Chrome Web Store) sets mayDisable flag according to whether requesting extension has access to modify settings of requested one, but not that requested one can be disabled at all (eg. if it is extension from force list, it should always remain enabled). This commit fixes this behavior. Also this commit fixes ExtensionManagementApiTest.ManagementPolicyProhibited test: when supplying PROHIBIT_MODIFY_STATUS to TestManagementPolicyProvider is't better to specify why status modification is prohibited. Bug: 954144 Change-Id: Iaa4a31502dffca45b3d7eca3def56d3281a796e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823873 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#704115}
-
Jeevan Shikaram authored
This CL removes the existing App Management router and uses the existing settings router. Bug: 999443, 1009397 Change-Id: Ife6232a27fb042b26d0eec3582388a2e8fbcaa26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833393 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#704114}
-
Oleg Davydov authored
Class ContentHashWaiter is declared in content_hash_fetcher_unittest.cc but can also used in other tests, so it makes sense to move it to test_utils.h under content_verifier directory. Bug: 796395 Change-Id: I238a77018efa730153ede75a659b846d2a181103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847296 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
-
Eric Seckler authored
This reverts commits bea22be5 and d51c2555 Reason for revert: crbug.com/914092 should now be fixed Original change's description: > Disable tracing benchmark amazon and bing on Windows. > > tracing.tracing_with_background_memory_infra/http://www.amazon.com > is flaky on windows. See https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=tracing.tracing_with_background_memory_infra%2Fhttp%3A%2F%2Fwww.amazon.com&testType=performance_test_suite > > Bing is also flaky on windows: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=tracing.tracing_with_background_memory_infra%2Fhttp%3A%2F%2Fwww.bing.com%2F&testType=performance_test_suite > > THe error is > > (ERROR) 2018-12-20 01:29:53,039 page_test_results.Fail:587 Failure recorded: TraceImportError: Unable to select a master clock domain because no path can be found from "TELEMETRY" to "WIN_QPC". > at ClockSyncManager.ensureAllDomainsAreConnected_ (/tracing/model/clock_sync_manager.html:283:17) > at ClockSyncManager.selectModelDomainId_ (/tracing/model/clock_sync_manager.html:254:12) > at ClockSyncManager.getModelTimeTransformer (/tracing/model/clock_sync_manager.html:156:14) > at TraceEventImporter.toModelTimeFromUs_ (/tracing/extras/importer/trace_event_importer.html:3368:42) > at TraceEventImporter.processCompleteEvent (/tracing/extras/importer/trace_event_importer.html:586:16) > at TraceEventImporter.processEvent_ (/tracing/extras/importer/trace_event_importer.html:1245:30) > at TraceEventImporter.importEvents (/tracing/extras/importer/trace_event_importer.html:1148:16) > at importer (/tracing/importer/import.html:198:65) > at task.subTask (/tracing/importer/import.html:145:32) > at Task.run (/tracing/base/task.html:80:50) > > See https://chrome-isolated.appspot.com/browse?namespace=default-gzip&digest=a09f20a96be90a851afcae573b59b2e9c47b55f7&as=tracing.tracing_with_background_memory_infra%5Cbenchmark_log.txt > TBR=charliea@chromium.org > NOTRY=true > > > Bug: 914092 > Change-Id: I1125eaccf4b68863d75b48998f5731330074c169 > Reviewed-on: https://chromium-review.googlesource.com/c/1387551 > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#618289} TBR=crouleau@chromium.org TBR=charliea@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 914092 Change-Id: Id1956e8e7a8d29539ff92fcd038b8f5ce53bf6cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849372 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#704112}
-
Kinuko Yasuda authored
TBR=wangxianzhu@chromium.org Bug: 1012638 Change-Id: Ic7af4fd1616459f5858d829c77c502748be5b0f6 No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849490 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Rune Lillesveen authored
For native rendering of form controls on Mac, use a dark theme when the used value of color-scheme is dark, and a dark theme is available in the MacOS version. Bug: 929098 Change-Id: If5af6192a6b1d722b6c16926e3b14c05a75bca0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848691Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#704110}
-
Ionel Popescu authored
This CL updates the datalist UI for date related types. Pixel tests are added to validate the new UI. Bug: 1011681 Change-Id: I4a6fd18f563fa1d8cf9247bb4c024c1cebe45440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844071 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#704109}
-
Adam Rice authored
Check that the "connection" and "closed" promises are resolved or rejected correctly in the WebSocketStream unit tests. BUG=983030 Change-Id: I1c6b8aa72438f75a7b078fa49c58b844fe6bde0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847231Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#704108}
-
Himanshu Jaju authored
This change would be followed up by transport mode name changes. Bug: 1009454 Change-Id: I53041f711e157df69ef03218539032229cb9fc64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845391Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#704107}
-
Alexander Timin authored
Do not put offline pages in back-forward cache as if we have network, we should reload the full page and if there is no network, offline page will be reloaded. R=jianli@chromium.org CC=bfcache-bugs@chromium.org BUG=1001087 Change-Id: I2dd9fea312a4ced6355ad3aaa052aeb44ca99779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837625Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#704106}
-
Dominik Röttsches authored
Mark virtual/threaded/external/wpt/css/css-animations/animation-opacity-pause-and-set-time.html as flaky under threaded compositing. Bug: 1012600 TBR: drott Change-Id: I5519ff7dc239ffafcc0526f354ba663e9f0c4a8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849012 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
-
Adam Rice authored
Previously, initialisation of ReadableStreamNative, WritableStreamNative and TransformStreamNative objects was done in the constructor. However, this resulted in calling into JavaScript inside the constructor, which could cause problems with garbage collection. Move the code from inside the constructor to a separate InitInternal() method which is called from Create(). The content of the new methods is copied verbatim from the constructors so there should be no functional differences. Manually tested. There are no automated tests as I don't know how to make them not be flaky. BUG=1008470 Change-Id: I394cc60b0bac397dccbef18ca166a66528c22bd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837326Reviewed-by:
-
Huanzhong Huang authored
At this point cookie controls setting is exposed only in incognito mode. This cl makes changes to the setting being persisted across incognito sessions. Bug: 967668 Change-Id: Icc42a7365186af5ccc74777236574ee9813ae3a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844819 Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#704103}
-
Yoshifumi Inoue authored
This patch changes |LayoutInlineCollector| to use |IsDescendantOf()| instead of using |HashSet<T>| to make |SelftFragmentsOf()|, which is used by hit testing and others, faster. I found the slowness of |LayoutInlineCollector| by CPU profiling[1] where |HashSet<T>::insert()| consumes most of time. So, it seems traversing fragment tree + LayoutObject::IsDescendnatOf()| is faster than two times of traversing fragment tree + |HashSet<T>::insert()|. [1] https://bit.ly/2pXQbcE Bug: 1008523 Change-Id: I825197f2b85fd2ef573e8ff159ddf966489361be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847602 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#704102}
-
Roman Sorokin authored
Bug: 1001458 Change-Id: Id88dd59b8a97df515c3bbaa3f4e5cea3c356eda2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844982 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#704101}
-
Lukasz Anforowicz authored
This CL partially reverts r666946 [1] - after r694827 [2] same-origin requests can be detected directly, by looking at the request_initiator field of network::ResourceRequest. [1] https://crrev.com/c/1642752: [CORS] Partially rely on factory bound initiator origin. [2] https://crrev.com/c/1633232: Set |request_initiator| to the website, not to the content script's origin. Bug: 940068 Change-Id: Ib82b83a8b25338c40a5d0a3a550d98e8e09db67b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834952Reviewed-by:
Mike West <mkwst@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#704100}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I543d9b9e31bae35abb6ea749514d4724f6cdc24e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848855Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e986cb92544a..c932f3309322 git log e986cb92544a..c932f3309322 --date=short --no-merges --format='%ad %ae %s' 2019-10-09 beaufort.francois@gmail.com Attribute offset needs to be multiple of 4 bytes Created with: gclient setdep -r src/third_party/dawn@c932f3309322 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I6c3a9356bffabccdaa02b5f77edb3a5024990c73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848878Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c6dbc23aeca4..713e9ad3279d git log c6dbc23aeca4..713e9ad3279d --date=short --no-merges --format='%ad %ae %s' 2019-10-09 simonhatch@chromium.org Pinpoint - Cache resolves to HEAD Created with: gclient setdep -r src/third_party/catapult@713e9ad3279d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:1012200 Change-Id: Ie90850f5047a5d0964367d5767eeb010920aae29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848853Reviewed-by:
-
Julian Watson authored
Change-Id: Ib5ed389fe154f5c32d1db4f8ea5c8be281ac9d2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846619 Commit-Queue: Julian Watson <juwa@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Auto-Submit: Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#704096}
-
