GitLab

For UMA opted-in users, this adds a new field to the omnibox event record that's uploaded when the user uses the omnibox.  In particular, it records a simple enum of what type of page the user was looking at, such as a generic web page or the new tab page.

This change only adds the field to the protocol buffer upload format, not the XML format.  If I decide later I want to add it to the XML format, I'll do it in another changelist.

BUG=
TEST=using VLOG(1) of what would be uploaded


Review URL: http://codereview.chromium.org/10273019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134824 0039d316-1c4b-4281-b951-d872f2087c98

Turning on by default before M20 branch, but leaving flag code for now so that
it's just a one-liner to disable if necessary post-branch.

BUG=118552,112879

Review URL: http://codereview.chromium.org/10281003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134823 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134822 0039d316-1c4b-4281-b951-d872f2087c98

BUG=115967
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134740

Review URL: https://chromiumcodereview.appspot.com/10273023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134821 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=tree
Review URL: https://chromiumcodereview.appspot.com/10285004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134820 0039d316-1c4b-4281-b951-d872f2087c98

Clean up LoginUIService::ShowLoginUI() API to not take a force_login flag.
Moved force_login code into the only place that needs it - AppNotifyChannelUI.

Fixed AppNotifyChannelUI code to gracefully handle having sync UI visible when the
user tries to re-auth.

BUG=118795
TEST=bring up sync UI via various methods (promo, app notifications infobar, wrench menu, error link in settings page, etc)


Review URL: http://codereview.chromium.org/10192005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134819 0039d316-1c4b-4281-b951-d872f2087c98

view model with a -1.

BUG=125127
TEST=covered by unit test
R=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10291002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134818 0039d316-1c4b-4281-b951-d872f2087c98

To be re-enabled tomorrow.

R=dennisjeffrey@chromium.org
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10265019

TBR=nirnimesh@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10283009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134817 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=functional/apptest.py

Review URL: https://chromiumcodereview.appspot.com/10282006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134816 0039d316-1c4b-4281-b951-d872f2087c98

BUG=no
TEST=no

Review URL: https://chromiumcodereview.appspot.com/10280005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134815 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125795,110212


Review URL: http://codereview.chromium.org/10262035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134814 0039d316-1c4b-4281-b951-d872f2087c98

This function is no longer used as it was replaced by
GetEntryInfoByPathAsync(), GetFileInfoByPathAsync(), and
ReadDirectoryByPathAsync().

BUG=chromium-os:30251,chromium-os:30204
TEST=compiles

Review URL: https://chromiumcodereview.appspot.com/10280004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134813 0039d316-1c4b-4281-b951-d872f2087c98

BUG=122641
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10291004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134812 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134810 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=tree
Review URL: https://chromiumcodereview.appspot.com/10287003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134809 0039d316-1c4b-4281-b951-d872f2087c98

GetDownloadDataCallback parameter in GDataFileSystem::GetFileByPath()
was optional hence a null callback was passed in many places, and
the null callback was posted to a message loop without checking if
it's null or not.

BUG=chromium-os:30198
TEST=double clicking on an image file on gdata; copy-pasting from gdata to Downloads; both don't crash

Review URL: https://chromiumcodereview.appspot.com/10288006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134808 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123657
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10278006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134807 0039d316-1c4b-4281-b951-d872f2087c98

Also, build more stuff on win_aura.

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10260033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134806 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134805 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10260036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134804 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123382
TEST=Manual


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134428

Review URL: http://codereview.chromium.org/10083056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134801 0039d316-1c4b-4281-b951-d872f2087c98

TBR=zelidrag@chromium.org
BUG=125833
TEST=waterfall.sh

Review URL: https://chromiumcodereview.appspot.com/10286003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134800 0039d316-1c4b-4281-b951-d872f2087c98

BUG=115363
TEST=manual
R=binji@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10281006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134799 0039d316-1c4b-4281-b951-d872f2087c98

The scons build is failing to copy the extension when putting exe in the
tools output directory.

Added batch file to simplify tries on Windows.

BUG=125762
Review URL: https://chromiumcodereview.appspot.com/10260032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134798 0039d316-1c4b-4281-b951-d872f2087c98

TBR=palmer@chromium.org
BUG=125807
TEST=waterfall.sh

Review URL: https://chromiumcodereview.appspot.com/10283007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134797 0039d316-1c4b-4281-b951-d872f2087c98

Trial to see if this will resolve the current flakiness issues in policy tests.

BUG=chromium-os:30221
TEST=functional/policy.py policy.PolicyTest.testBlacklistPolicy

Review URL: https://chromiumcodereview.appspot.com/10287002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134796 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Visual. Bubbles look more up-to-date on later OSes.


Review URL: http://codereview.chromium.org/10272035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134795 0039d316-1c4b-4281-b951-d872f2087c98

Two steps:
1. moving chrome/browser/extensions/extension_omnibox* to a new directory chrome/browser/extensions/api/omnibox, along with dropping the prefix "extension_"
2. putting the classes, structs and functions from [extension_]omnibox_api.h to namespace extensions

BUG=125622
TEST=N/A


Review URL: http://codereview.chromium.org/10265022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134794 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10285003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134793 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134792 0039d316-1c4b-4281-b951-d872f2087c98

The function glProduceTexture(target, mailbox) removes a texture from a context group and puts it in a "mailbox" that is accessible to all context groups on the same channel.

Then glConsumeTexture(target, mailbox) adds the texture to a context group, possibly a different one, if the caller knows the name of the mailbox.

From the point of view of the caller, the texture objects themselves do not move, just the texels. In terms of the underlying GL, the TextureInfo service IDs are reassigned as necessary.

A texture in a mailbox is destroyed when the context group that put it there is destroyed.

Expected usage is:

// Context 1
glBindTexture(GL_TEXTURE_2D, foo);
glProduceTexture(GL_TEXTURE_2D, secret_name);
glFlush();

// Context 2
glBindTexture(GL_TEXTURE_2D, bar);
glConsumeTexture(GL_TEXTURE_2D, secret_name);

Review URL: http://codereview.chromium.org/10106015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134791 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10270034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134790 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=manual
TBR=binji@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10277002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134789 0039d316-1c4b-4281-b951-d872f2087c98

If pinned app is unloaded, put it to pending_pinned_apps_ list and pin it again when it is loaded again.

BUG=123293
TEST=manual


Review URL: http://codereview.chromium.org/10170029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134788 0039d316-1c4b-4281-b951-d872f2087c98

TBR=zhaoqin@google.com
BUG=125801
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10278002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134787 0039d316-1c4b-4281-b951-d872f2087c98

R=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10262027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134786 0039d316-1c4b-4281-b951-d872f2087c98

This was introduced in crrev.com/134770

- DCHECK(entry || error != base::PLATFORM_FILE_OK);
+ DCHECK(error != base::PLATFORM_FILE_OK);

The latter does not make sense, as we are mostly expecting
error to be base::PLATFORM_FILE_OK. Besides, the read directory
operation can fail for various reasons.

BUG=chromium-os:30251
TEST=the DCHECK failure is gone with --enable-dcheck

Review URL: https://chromiumcodereview.appspot.com/10279002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134784 0039d316-1c4b-4281-b951-d872f2087c98

BUG=122085
R=asanka@chromium.org


Review URL: http://codereview.chromium.org/10237010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134783 0039d316-1c4b-4281-b951-d872f2087c98

every call to GetDragDestDelegate() destroying local state.

BUG=123359
TEST=dnd works on bookmark manager


Review URL: http://codereview.chromium.org/10273030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134782 0039d316-1c4b-4281-b951-d872f2087c98

Revert 134774 because of win aura compile and chromium os browser_test crashes - Created uber tray UI for monitoring ongoing WebDrive sync operations

BUG=chromium-os:30075
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10214013

TBR=zelidrag@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10285002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134778 0039d316-1c4b-4281-b951-d872f2087c98