- 19 Jul, 2018 40 commits
-
-
Christian Dullweber authored
This reverts commit 0ea138d6. Reason for revert: The CL probably broke a number of tests: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.13%20%28retina%29/63 Original change's description: > [Blink] Unify pre-snapping of <video> to match <iframe> > > This CL changes the pre-snapping policy of <video> so that only the size > of the contents is pre-snapped, while the location will exactly match the > content box's final location. > > BUG=730284 > > Change-Id: Id10bd0fbd8021a11b7db4a2950a908f3d1b50ac0 > Reviewed-on: https://chromium-review.googlesource.com/1141328 > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Commit-Queue: Tien-Ren Chen <trchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576317} TBR=trchen@chromium.org,chrishtr@chromium.org Change-Id: I518e659cbab820263480b02ae347c99468dd95fa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 730284 Reviewed-on: https://chromium-review.googlesource.com/1143205Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#576438}
-
Mark Cogan authored
- Fade in the grid toolbars and the other grid cells sooner in the animation (20% delay instead of 40%) - Start the cell fade-in from 20% opacity (not 0%). - Adjust the timing of the presentation and dismissal animations. - Add spring to the resize animations when entering/exiting the grid. - Adjust the timing curve of the inactive cell appearance animations. - Match the device corner radius in the "tab" state of the animations (meaning that on iPhone X, the active cell transitions to/from more rounded corners). Bug: 865028 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iddea1d4addfe2192f8175f02599eca39c59edffd Reviewed-on: https://chromium-review.googlesource.com/1142156 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#576437}
-
Friedrich Horschig authored
This CL causes the accessory sheet to close when a user selected a valid filling suggestions. There is no indicator of the negative case yet (i.e. error during filling). TBR=rouslan@chromium.org TBR Reason: The test has been flaky for a while and also doesn't make much sense. Like all the others, I am disabling it. The feature it tests isn't even activated yet. Bug: 856026, 857592 Change-Id: I8ccdbe2b06c49215b0799fd435823e584dfe4f11 Reviewed-on: https://chromium-review.googlesource.com/1126244 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#576436}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 96e63637. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21544 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kozyatinskiy@chromium.org: external/wpt/console TBR=foolip No-Export: true Change-Id: Ia010fb7467e3a5df5870eb88e74ef9d4abf03aab Reviewed-on: https://chromium-review.googlesource.com/1143018 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#576435}
-
Henrik Grunell authored
Change-Id: I7d74cb5fa93c2b271f9238ca28e243fc126bfd60 Reviewed-on: https://chromium-review.googlesource.com/1135005Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Oskar Sundbom <ossu@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#576434}
-
Jérôme Lebel authored
Second part of crrev.com/c/1138621 after crrev.com/i/652748 is landed. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ibff91f4bfb24351ea66b77c730e182bcb48426f2 Reviewed-on: https://chromium-review.googlesource.com/1140323Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#576433}
-
Matt Falkenhagen authored
Follow-up to the interface name change in r576345. TBR=kinuko Bug: 629701 Change-Id: Ia330b4c96871b109004bc917a232c592bc75d83e Reviewed-on: https://chromium-review.googlesource.com/1143099Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#576432}
-
Colin Blundell authored
Minor cleanup to always access the information of whether signin is prohibited via the accessor method rather than directly via the ivar. Change-Id: I208930ce094d40d22a325cdca6fd36cf26da441a Reviewed-on: https://chromium-review.googlesource.com/1142771Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#576431}
-
Yutaka Hirano authored
With this CL, CORSURLLoaderFactory rejects ill-configuared requests. - CORS needs a proper origin (including an opaque unique origin) attached to a request. Hence CORSURLLoaderFactory rejects a request which has a CORS-enabled mode and null request_initiator. Also, a request with null request_initiator won't set the CORS flag with this CL. - The relationship between fetch credentials mode and load_flags is a bit unclear. If a request's credentials mode is "omit" but one of LOAD_DO_NOT_SAVE_COOKIES, LOAD_DO_NOT_SEND_COOKIES and LOAD_DO_NOT_SEND_AUTH_DATA is not set on load_flags, that is likely a mis-configuration, so fail the request. Bug: 736308, 862184 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I51fb491b865de330b22b028a0eddbc30043e6b69 Reviewed-on: https://chromium-review.googlesource.com/1136342 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#576430}
-
Keishi Hattori authored
Oilpan: Mark navigation-interrupted-by-fragment.html as Timeout in HeapIncrementalMarkingStress mode Bug: 865348 Change-Id: Ie0b5b7d0db19b880293b84fe14d3431b8d9ebfc0 Reviewed-on: https://chromium-review.googlesource.com/1143117Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#576429}
-
François Beaufort authored
This CL make sure the Picture-in-Picture window playback state is reflected when video src changes. It is a follow-up to https://chromium-review.googlesource.com/1089331 Bug: 726619 Change-Id: Ic756c03aa023d3e4e229c7495686ea8f322503e3 Reviewed-on: https://chromium-review.googlesource.com/1133168 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#576428}
-
Trent Apted authored
This affects file manager tests, gallery tests, and others. With a few exceptions, these tests have no use for the browser() that StartupBrowserCreator creates during startup. Not creating one leaves more time for the tests to do things they really care about before potentially timing out. In fact, _not_ creating the Browser surfaces an existing bug more prominently. That is, some tests have an iceberg dependency on the existence of this Browser* that they should never have had in the first place. Bug: 736930 Change-Id: I1030e41800f3d2e0e5868ecd64d70c7d30f47c28 Reviewed-on: https://chromium-review.googlesource.com/1117977Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#576427}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/639bc9086732..6a5d98c4b528 git log 639bc9086732..6a5d98c4b528 --date=short --no-merges --format='%ad %ae %s' 2018-07-19 jiawei.shao@intel.com ES31: Implement Vertex Attrib Binding on D3D11 2018-07-18 geofflang@chromium.org Vulkan: Disable the depth/stencil states when there are no depth/stencil buffers Created with: gclient setdep -r src/third_party/angle@6a5d98c4b528 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I568d1fe855b0a6183728e749812ec0cc61eb372a Reviewed-on: https://chromium-review.googlesource.com/1142175Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576426}
-
Marc Treib authored
IsSyncActive can now be implemented in terms of GetState (as an intermediate step before fully removing it). Moving the implementation into the base class makes sure tests can't expose inconsistent state. This does require a good number of test changes, since IsSyncActive can't be overridden anymore. The following ones are entirely trivial/ mechanical and will be TBRed: chrome/browser/extensions/external_pref_loader_unittest.cc chrome/browser/ui/cocoa/app_menu/app_menu_controller_unittest.mm components/autofill/core/browser/test_sync_service.h/cc components/unified_consent/unified_consent_service_unittest.cc components/unified_consent/url_keyed_data_collection_consent_helper_unittest.cc TBR=jochen Bug: 839834 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I27c6568330e0377d903eb0548221fc264a0d5dd6 Reviewed-on: https://chromium-review.googlesource.com/1138613 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#576425}
-
Mikel Astiz authored
Prior to this patch, ModelTypeStoreImpl and ModelTypeStoreBackend internally maintain singleton maps to achieve what KeyedServices are designed for: have single instances of certain objects per profile. The implementation was rather error-prone (e.g. to leak data across profiles) and the object lifetime questionable. Instead, this patch replaces them with a newly introduced keyed service, ModelTypeStoreService, which is designed to abstract away sync's needs to persist data. The associated semantics wrt lifetime, incognito etc. are more standard now. For directory, we don't migrate the code other than making the keyed service the authoritative source for defining where data should be persisted (FS path). We do this to minimize the diff, and because we expect all datatypes to be eventually migrated to USS in the long term. Bug: 862942 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib444220ead181b6765c863703439eec18fcb0886 Reviewed-on: https://chromium-review.googlesource.com/1134774Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#576424}
-
Dominic Mazzoni authored
Otherwise rows and cells aren't renumbered properly. We can possibly make this more efficient in the future by only computing cell row and column indexes downstream, but for now this is necessary. Bug: 864012 Change-Id: I270481c78ee6e10bdf0140c5f4d221af3918c0fc Reviewed-on: https://chromium-review.googlesource.com/1142392 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#576423}
-
Hiroshi Ichikawa authored
Bug: 862537 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9316b45024968ae37b51fe9547897f5e82a5d238 Reviewed-on: https://chromium-review.googlesource.com/1141553 Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#576422}
-
Naoki Fukino authored
When "Show all Play folders" is toggled, we make modification on FileFilter instance which filter visible folders/files. FileFilter dispatches 'changed' event, and we can remember the current option on the event handler. Bug: 863200 Test: Manually tested on ARC-enabled devices. Change-Id: I517cabfea04e1c17e2e2a844fb2ca35c4becb648 Reviewed-on: https://chromium-review.googlesource.com/1143101Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#576421}
-
Vasilii Sukhanov authored
Bug: 860737 Change-Id: If8da3ee3c9f9e68fd39f99b7b9458558426b0133 Reviewed-on: https://chromium-review.googlesource.com/1140157 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#576420}
-
Jan Wilken Doerrie authored
This change augments the fix in https://crrev.com/c/1140853 to cover other cases the first change missed. Bug: 862119 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I59ca0f37aba90009b645b6ddb4b1413c5325f933 Reviewed-on: https://chromium-review.googlesource.com/1142146Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#576419}
-
Vadym Doroshenko authored
This flag is cross-plaform flag, that was already added on all other platforms on CL https://chromium-review.googlesource.com/c/chromium/src/+/1016648. Bug: 831123 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9de727ac5203e0680eb113aa2531512ba6245198 Reviewed-on: https://chromium-review.googlesource.com/1141946Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#576418}
-
Keishi Hattori authored
This CL: - adds support for multiple RAILModeObservers - adds ThreadState::should_optimize_for_load_time_ flag that disables kIncrementalV8FollowupGC Change-Id: I7e3f321472e9c724ebeb3c06cd50412b6d334433 Reviewed-on: https://chromium-review.googlesource.com/1134814 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#576417}
-
Kent Tamura authored
Windows Aura(?) has a bug on moving a popup window. See crbug.com/863770. This CL reverts a part of crrev.com/370091, and SELECT popups won't be moved to work around the issue. Bug: 137495, 863770 Change-Id: I1d50aa6eb47204b8fe6ea83fddba6966861dff76 Reviewed-on: https://chromium-review.googlesource.com/1143062Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#576416}
-
Matt Falkenhagen authored
It's used by workers too. Change-Id: Ibb274557d08fff00c7e2f88e58a501ecaaf776d4 Reviewed-on: https://chromium-review.googlesource.com/1143049Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#576415}
-
Matt Falkenhagen authored
Change-Id: I24e31e7327ea57c4848bedb7140382cdfbcfda8f Reviewed-on: https://chromium-review.googlesource.com/1143051Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#576414}
-
Sergio Villar Senin authored
This CL moves proxy_browsertest.cc away from URLFetcher, replacing it by SimpleURLLoader. Bug: 844915 Change-Id: Id0fd3ec4168f8b1c272906e6620c11b5418d2f54 Reviewed-on: https://chromium-review.googlesource.com/1141948 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#576413}
-
Orin Jaworski authored
To deemphasize answer descriptions, a font with explicit size delta was being used, resulting in two font fetches. Now there is a new entry in ChromeTextContext so only one is needed. The appearance and behavior should remain the same, but this follow-up CL simplifies API usage, speed, and maintainability. Change-Id: I3a171cddf7b6e1620879b76239cfdf4f975615a1 Bug: 838733 Change-Id: I3a171cddf7b6e1620879b76239cfdf4f975615a1 Reviewed-on: https://chromium-review.googlesource.com/1142019Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#576412}
-
Renee Wright authored
Bug: 858832 Change-Id: I959d55b8fe6cbc143d494c236b6fca46d82c4807 Reviewed-on: https://chromium-review.googlesource.com/1142852 Commit-Queue: Renée Wright <rjwright@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#576411}
-
Matt Falkenhagen authored
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3da9b8dab7ecaf9ef4552a43160b029f5147774e Reviewed-on: https://chromium-review.googlesource.com/1143048Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#576410}
-
Hiroshi Ichikawa authored
This is mainly to avoid having two files with too similar names (web_view_inttest vs. web_view_int_test). Also replaced Bind() with BindRepeating(). Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2988cd25cbcf24495fc7e039cf1610d03e15bff0 Reviewed-on: https://chromium-review.googlesource.com/1141447 Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#576409}
-
Gauthier Ambard authored
This CL adds HapticFeedback when the popup menus are displayed when long pressing the toolbar buttons. Bug: 864923 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7fad41d33b500874e578d1f913d792a20baf5a15 Reviewed-on: https://chromium-review.googlesource.com/1141949Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#576408}
-
Yuichiro Hanada authored
Bug: 845079 Test: unit_test Change-Id: I3cde5faf60848583a0b39684c7dae5dc08bbd754 Reviewed-on: https://chromium-review.googlesource.com/1120101 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#576407}
-
Esmael El-Moslimany authored
Bug: 864393 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: If82f47605a9cc86e8e1d17e5f6ad1a27027c90b7 Reviewed-on: https://chromium-review.googlesource.com/1141152 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#576406}
-
Tetsui Ohkubo authored
This CL closes UnifiedSystemTray when other widgets are activated. With this CL, we can also remove some CloseBubble() that manually closes UnifiedSystemTray. TEST=manual BUG=864247 Change-Id: I7ef09aec5bb79213ee87407d2fe04179847968f7 Reviewed-on: https://chromium-review.googlesource.com/1140096 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#576405}
-
Christopher Lam authored
This CL moves WebContents AutoResizing behavior into Webview rather than handling it in subclasses of Webview. This will enable the addition of other AutoResizing Webviews without the need for a custom subclass. Bug: 849551 Change-Id: I2a31a57180ff43b6cda9827ba9d19dcddcd1db24 Reviewed-on: https://chromium-review.googlesource.com/1127216 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#576404}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 39623028. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21543 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=foolip No-Export: true Change-Id: I09b79ae9bab6a02173730424b977b6a3802f3fb4 Reviewed-on: https://chromium-review.googlesource.com/1143005 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#576403}
-
Renee Wright authored
Bug: 822488 Change-Id: Idf9d2dcf7af98004bdecdeb191c11612dcac2f6f Reviewed-on: https://chromium-review.googlesource.com/1142850Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Renée Wright <rjwright@chromium.org> Cr-Commit-Position: refs/heads/master@{#576402}
-
Min Qin authored
This CL calls the InProgressDownloadManager to delete ResourceDownloader after response is completed. It also fixes the issue when download is cancelled. The new CL fixes an issue that StreamHandleInputStream::OnStreamCompleted() could get called twice TBR=xingliu@chromium.org BUG=864189 Change-Id: Ia46040ceee88fd9978911c26ee32765a1ac4a099 Reviewed-on: https://chromium-review.googlesource.com/1142462Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#576401}
-
Darren Shen authored
When we use the IME menu tray in laptop mode, we temporarily enable the accessibility virtual keyboard. When the keyboard is dismissed, we disable the accessibility keyboard again. However, when we change the keyboard between docked and floating mode, the keyboard has to hide first before showing again. This causes the accessibility keyboard to be disabled and the keyboard doesn't show up again. We fix this by adding an additional parameter to OnKeyboardHidden which indicates whether the keyboard is hidden temporarily. TBR=sky@chromium.org Bug: 858953 Change-Id: I162917e5e32e6081be49127a3e7e9cf5fbeeb11c Reviewed-on: https://chromium-review.googlesource.com/1137803 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Blake O'Hare <blakeo@chromium.org> Cr-Commit-Position: refs/heads/master@{#576400}
-
Luciano Pacheco authored
Change NavigationListModel to expose the flag state and use it from DriveVolumeItem to only expand if My files is disabled. Fix comment comment changed in crrev.com/c/1141454. browser tests check for collapsed behaviour. Test: Manually checked that Drive is expanded when flag is disabled, Bug: 864291 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Iff2c364ce5ad8d50dfd8f7850d9773c8ddf47b3d Reviewed-on: https://chromium-review.googlesource.com/1143044Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#576399}
-