- 23 Jun, 2020 40 commits
-
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592902529-27c1b0c2ad05930b1841cdb3fc1b8d5f930926e0.profdata to chrome-win32-master-1592913526-aa0369974c74051e60d9fc3c83a0a362a402bc87.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I3d8de61c0c4529a761ac6fb9ddc6225d08fcac46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260518Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781344}
-
Sebastien Marchand authored
Use "(dis)allowlist" instead of non-inclusive term "(white|black)list". This affects some UKM entry but it's not something that we're recording now (and this code could maybe be removed anyway). Bug: 842296 Change-Id: Ie0e9fe16ffc6361c9891d01ff6aaf94f7564f2dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249720 Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#781343}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/caa519ca532a..43c639f0906a 2020-06-23 rharrison@google.com Roll 5 dependencies and update tests/expectations (#1087) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: I855b004b8364eba303ff05b5bf7c03aded85ec42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260517Reviewed-by:
-
Guillaume Jenkins authored
In preparation for moving BrowserDMTokenStorage to components, this change moves platform-specific DM token management code to delegates instead of using derived classes. In this case, the derived class approach won't work after the move to components because the current code has the derived classes implementing the parent's Get() singleton method, which won't work when the base and the derived classes are in different DLLs. Summary of the changes: - Pure virtual methods in BrowserDMTokenStorage have been moved to a delegate inner class. - Platform-specific token management classes now derive from the delegate instead of the BrowserDMTokenStorage singleton. - CBCMController is responsible for creating the correct platform delegate and assigning it to the BrowserDMTokenStorage singleton during early initialization. - For tests, this refactor is completely transparent, as the FakeBrowserDMTokenStorage creates and manages its own fake delegate implementation. Bug: 1091929 Change-Id: I02ae185cc5cbde46016039b49cefaeb8e963ec4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246979 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#781341}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bbe343d8..dfc4c1d4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I354475103613638f1fa76b95eee157955fb5c814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260417Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781340}
-
Joe Mason authored
R=siggi Bug: 1096543 Change-Id: I42a0f40fa895117ed03b6173f5f1bb27b905b9e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259485 Auto-Submit: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#781339}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2841ab4841b1..60aab5ad138e 2020-06-23 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-06-23 mathias@chromium.org Roll Puppeteer v4.0.0 2020-06-23 kimanh@chromium.org Re-enable and adapt disabled e2e tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibc12ebd27e9deb5832810d5c1b268b05d4bee6a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260520Reviewed-by:
-
Gavin Williams authored
This error message will be displayed only on Chrome OS in Print Preview whenever the currently selected printer is in an error state. Bug: 1059607 Change-Id: I14449ff21892c21106b7319b8f99bc421897b8b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227860 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#781337}
-
Etienne Bergeron authored
Thread priority should not be modified after a test. If that is happening, it needs to be fixed in the code. This CL remove the code that disable the priority checks. NOTE TO SHERIFF: * please paste failure logs when reverting, the goal is to remove flaky tests related to thread priority. * assigned flaky test to etienneb@ Bug: 1097092 Change-Id: I6462e3aff2a0d1b0febc2eae7cd97bf580292768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254466Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#781336}
-
Charlie Hu authored
This CL adds presubmit check for: - document_policy_feature.mojom & document_policy_features.json5 sync - document_policy_feature.mojom & enums.xml sync Example presubmit warning messages generated by adding kNewFeature to document_policy_feature.mojom: DocumentPolicyFeature enum has been updated and the UMA mapping needs to be regenerated. Please run update_document_policy_enum.py in src/tools/metrics/histograms/ to update the mapping. third_party/blink/public/mojom/feature_policy/document_policy_feature.mojom third_party/blink/renderer/core/feature_policy/document_policy_features.json5 and third_party/blink/public/mojom/feature_policy/document_policy_feature.mojom are out of sync: ['NewFeature'] are missing in json5 config. third_party/blink/public/mojom/feature_policy/document_policy_feature.mojom \ third_party/blink/renderer/core/feature_policy/document_policy_features.json5 Change-Id: I21a73d75075ca9e0b7ddbaf30d934a8047dd6a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248752Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#781335}
-
Miguel Casas authored
This CL fixes three things in the mentioned files: - Removes the unnecessary namespace resolution of ::media::Status. - Comments out unused parameter names in Initialize(). - Remove unimplemented static method GetCreateVDFunctions(). No new code/functionality intended, only style refactoring. TBR=hiroh@chromium.org since changes are just cosmetic. Bug: 1040291 Change-Id: I711683337aca0e018f19131dfad15887d36d0f36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259486Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#781334}
-
Jamie Madill authored
This reverts commit 2d9c6117. Reason for revert: Still flaky on Win/Vulkan at least. You can even see one flaky in win_optional in the try job for this CL. Breaking ANGLE CQ. Bug: 1098291 Original change's description: > Remove WebGL suppression conformance/buffers/buffer-data-dynamic-delay.html > > Remove suppression for [win nvidia passthrough] conformance/buffers/buffer-data-dynamic-delay.html > > > Tbr: kbr@chromium.org > Bug: 1082826 > Change-Id: I9ec1ba97527a35fbd0f29601494cb8a98a433228 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255223 > Reviewed-by: Shrek Shao <shrekshao@google.com> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Shrek Shao <shrekshao@google.com> > Cr-Commit-Position: refs/heads/master@{#781153} TBR=kbr@chromium.org,shrekshao@google.com Change-Id: I9e0d036c97d159a3c899504ed5dc63e655c1e1a0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1082826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260812Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#781333}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I6586ab4b6c7b03a9f98209cedc1c205275f54ff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259147Reviewed-by:
-
Kushagra Sinha authored
For some browser tests, it is useful to create an in-memory instance of Account Manager. Allow this by checking the provided cryptohome root directory during initialization. If it is an empty path, then Account Manager should not perform any disk I/O. Bug: 1068240 Change-Id: I1e0278bf65631e01f246ea85074af4e2ca5e4807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254780Reviewed-by:
Anastasiia N <anastasiian@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#781331}
-
Wan-Teh Chang authored
The ReadYUV() function and the StaticAVIFTests.YUV test in avif_image_decoder_test.cc are adapted from the ReadYUV() function and the JPEGImageDecoderTest.yuv test in jpeg_image_decoder_test.cc. Declare ImageDecoder::CanDecodeToYUV() as a const method. Test: 1. blink_platform_unittests --gtest_filter=*AVIF* 2. Run chrome with --enable-features=AVIF and visit https://resources.link-u.co.jp/avif/images.html. Bug: 1087056 Change-Id: I8cd6375cc0824e71ec80622328f288a19c67bc90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229840 Commit-Queue: Wan-Teh Chang <wtc@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#781330}
-
Clark DuVall authored
The components scaled resources were added in http://crrev.com/c/2250920, and are only needed for WebLayer. Bug: 1023811 Change-Id: I58d9b8aa331e6a102bc9b97367d095f0bd7ed089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258686 Auto-Submit: Clark DuVall <cduvall@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#781329}
-
Ioana Pandele authored
Change-Id: I2327855180203f746dc91e966c7c4a6b18749c64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260613Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#781328}
-
Hans Wennborg authored
Bug: 1097990 Change-Id: Ic77aecc775a879a937282698d1dddfcefcf76d82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259916 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#781327}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c2f46c16ab67..2bf27f21f8d1 2020-06-23 jvanverth@google.com Revert "Reland "Fill in GrD3DGpu::onUpdateBackendTexture"" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I03197af1d990ce054e9f4c1b0b441c2bbb853568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260514Reviewed-by:
-
Chris Sharp authored
This reverts commit 1e56c551. Reason for revert: Broke compile on Mac Builder (dbg) Failure Step compile failed. Error logs are shown below: [724/7143] CXX obj/base/base_unittests/power_monitor_device_source_unittest.o FAILED: obj/base/base_unittests/power_monitor_device_source_unittest.o /b/s/w/ir/cache/goma/client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF...(too long) ../../base/power_monitor/power_monitor_device_source_unittest.cc:32:3: error: use of undeclared identifier 'DVLOG' DVLOG(1) << PowerMonitorSource::DeviceThermalStateToString(current_state); ^ 1 error generated. More information in raw_io.output[failure_summary] Original change's description: > base/power_monitor: Add method to query thermal state > > wip wip > > Add PowerMonitor::GetCurrentThermalState() > > Bug: 1071431 > Change-Id: Id3083e06f16fd2f05e685e77ddee94e274158758 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248729 > Reviewed-by: Henrik Boström <hbos@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781322} TBR=fdoray@chromium.org,mcasas@chromium.org,hbos@chromium.org Change-Id: I54bbdc02423890b8443cb2f1deec909b68d87ebf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1071431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260792Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#781325}
-
Liviu Tinta authored
Adding this TRACE would make it easier to look into wheel events bugs. Bug: 1087088 Change-Id: Id90516476e6112699e8d030107f16c80a97e0773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250592Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#781324}
-
Nohemi Fernandez authored
The NewSigninArchitecture feature has been enabled by default. Bug: 971989 Change-Id: I7289a97541d239edbfc1b3b65aea04abe9c46edd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260553Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#781323}
-
Miguel Casas-Sanchez authored
wip wip Add PowerMonitor::GetCurrentThermalState() Bug: 1071431 Change-Id: Id3083e06f16fd2f05e685e77ddee94e274158758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248729Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#781322}
-
Oriol Brufau authored
ListMarker::MarkerText was not checking whether the marker had 'content' set to 'normal' or something else. Therefore, in the accessibility tree, something like <style>::marker { content: "foo" }</style> <li style="list-style-type: decimal"></li> would appear as ▽ listitem ▽ ListMarker "1." text "foo" with the "1." despite 'list-style-type' being overridden by 'content'. This patch turns it into ▽ listitem ▽ ListMarker text "foo" Bug: 457718 TEST=All/DumpAccessibilityTreeTest.AccessibilityListMarkerStyles/linux Change-Id: Id022ab6dab5268101380a06936275598b225a0ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255598Reviewed-by:Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#781321}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592902529-d2a08100040b803a390f39eecb31cf1400764c19.profdata to chrome-win64-master-1592909179-8c9bd637e5cbc50bd35bf53946c51dca562e57cb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I9fbb19589759012404960c28c50f7245aaca4fdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260513Reviewed-by:
-
Victor Hugo Vianna Silva authored
This CL adds metrics that record, every time Chrome offers to move a password from the profile store to the account store, what was the user action that triggered the flow to be offered. Bug: 1063852 Change-Id: Ie416b1b234dbd94421ecd13125377abbe6db148e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254028 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#781319}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1592891992-7e90ec0b60a74a0e681805c7cbe855e46353b429.profdata to chrome-mac-master-1592913526-8a6b109b6b3679eaf9b2e9a04d6e6b258b48adc2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I16ec7ac90360f951211602586e5ed390c17e5bab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260515Reviewed-by:
-
Mikel Astiz authored
This patch deletes a bunch of semi-related tests that are no longer interesting because they only exercise the legacy codepath, and the concepts being tested no longer exist in core sync machinery or at all. Roughly, the deleted tests are about: 1. Naming-related requirements: outdated long ago, no longer relevant. 2. Hierarchy-related: now specific to bookmarks, have decent coverage under components/sync_bookmarks. 3. Local conflict-resolution: no longer implemented within the sync engine and a core responsibility of ModelTypeProcessor implementations, e.g. tested in ClientTagBasedModelTypeProcessorTest. Change-Id: If8572374bff2ebd27e0c6798f79dcb7273d07883 Bug: 923287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257327Reviewed-by:
-
arthursonzogni authored
1. A test should check only one things. Previously, support for every "CrossOrigin" attribute was checked in 4 different tests. This part is now merged into property.https.html. The 4 other tests are now checking only one property and are now passing/failling consistently without timeouting. 2. Checking all the accesses to "CrossOrigin" attributes are now also checked in the same-origin case. 3. The helper file try-access.js has been added to check the reported source location. 4. Several simplification here and here. Bug: 1090273 Change-Id: I6cb53aa20b48e8b4d9064d8d593120323dbdf8de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259912 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#781316}
-
Andrey Zaytsev authored
Bug: 1070620 Change-Id: I3b61e067b09c70c555ccd37bb048d8b78bba9f0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241682Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#781315}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ia09cd19fa8d3d4dd69f46168478225994cbef7c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259482Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781314}
-
Etienne Pierre-doray authored
A UniversalSuccessor lock can be taken after any other lock but another UniversalSuccessor. This is needed in https://chromium-review.googlesource.com/c/chromium/src/+/2248159 in order for JobTaskSource to use worker_lock_ as a inner lock. Change-Id: If2d6fc25083cecf285d066289a170b43da00fb3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610646Reviewed-by:
-
Makoto Shimazu authored
Let's extend the expiry date because it's one of the health check metrics. Bug: 1089490 Change-Id: I49622b3ec2f14b2b8a6e4878802558f881b27e99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259395 Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#781312}
-
Stephen Nusko authored
android go webview This test flakes 21% of the time due to a timeout. See bug for details. Bug: 1098225 Change-Id: Ia0daed5759712abea78c43557dc192fb31d30a4d No-Try: True TBR: johnchen@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260733 Commit-Queue: Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#781311}
-
Henrik Boström authored
The variable still has the "k" in its name, but the string name used in --enable-features is now without it; "WebRtcThermalResource". Bug: chromium:1094844 Change-Id: Id32c0de43b9fc7ab0b977defda675b1e3bfb4af3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260633Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#781310}
-
Maks Orlovich authored
Experiment showed not using the heuristic prevents accumulating too many files and performs well Bug: 1075545, 1073514 Change-Id: I7cb374e7f3283ea809f1bf7635f1ade91009742b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255651Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#781309}
-
Side Yilmaz authored
This CL replaces deprecated functions of IdentityServicesProvider with the newer service getters with profile parameter. Currently, IdentityServicesProvider gives |Profile#getLastUsedRegularProfile| param to the native. By this CL, sync classes pass |Profile#getLastUsedRegularProfile| to the IdentityServicesProvider to be used by native. Note: This CL is only clean-up and does not change code behaviour. Bug: 1041781, 1075562 Change-Id: Ib987c4b1e57c6490cd3b844dd9786a3b8459fe17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253749Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#781308}
-
Sebastien Marchand authored
Bug: 1061899 Change-Id: Iae643053601f2d9553212418deb72adb08d19b8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240043 Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Patrick Brosset authored
Users can configure settings in chromium for the fonts they prefer. These settings are set in the page frame that the DevTools overlay creates for itself. This change just adds a missing setting for fixed size fonts. Additionally, this fixes a bug whereby the font-family defined in the grid overlay for line number labels was not applying correctly. Before: https://i.imgur.com/kox646s.jpg After: https://i.imgur.com/4AOLmiY.jpg Bug: 1096542 Change-Id: I727932184f5ddd04336539d1849d8233103a6933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251086Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com> Cr-Commit-Position: refs/heads/master@{#781306}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d69e945fe7dd..2841ab4841b1 2020-06-23 sigurds@chromium.org Update protocol for HeavyAds 2020-06-23 wolfi@chromium.org [Issues] Change style of 'issues infobar' If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1095617,chromium:1096973 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I630b117571bbeed9d8445c45718ed31448464f98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260512Reviewed-by:
-
