- 30 Dec, 2020 40 commits
-
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1609306855-ad6e8d3c7e491bfd58012e29cb21279df55a8ecd.profdata to chrome-mac-master-1609329117-c3020fc1a675822543105a1cb9c7edc2d0728727.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ibdcc71ae01311f06056cd740a19c2b830f1fcac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607367Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839742}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2fec1a3206d1..3b3a5d369325 2020-12-30 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-12-30 bmeurer@chromium.org [cleanup] Asyncify SourceMapNamesResolver.js and remove redundant Promise.resolve()s. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1161501 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I436aa0db25ba8b534b46ff3663872c5537b5cacd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607365Reviewed-by:
-
Hui Yingst authored
[iOS]Disable [CreditCardViewControllerTestCase testOTRAddCreditCardsActionOpensAddCreditCardSettings]. TBR=javierrobles@chromium.org Bug: 1162354 Change-Id: Ib7f5998012837b9ff760f25712181791cf827b25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606805 Commit-Queue: Javier Flores <javierrobles@chromium.org> Reviewed-by:
Javier Flores <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#839740}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/67c61fc86af7..deeb34ab4759 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sauski@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: sauski@google.com Change-Id: I15756bf0f666eec97fbc31d4ac192086cf5109ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607404Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839739}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ice25f450155322079e0d8dcaa3054974605cadce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606949Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839738}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8f0f9afdb63d..2fec1a3206d1 2020-12-30 bmeurer@chromium.org [cleanup] Remove unused `pathSymbol` export. 2020-12-30 yangguo@chromium.org Change network emulation option "online" to "no throttling" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1028078 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I160ce0c911c73e2d52428df4672a1276f8d2d73e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606777Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fbc75f9ebfca..67c61fc86af7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sauski@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: sauski@google.com Change-Id: If4504bdd945c6b3299482704e92ea73be225483c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604952Reviewed-by:
-
sauski authored
Disabling test due to consistent flakes on the "Linux Tests" builder. Flakes only appear to impact the release version of this builder. TBR=dbertoni@chromium.org Bug: 1162432 Change-Id: Iab290479c737b9381ce1f65bcbe061bc5ca4fa83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605871Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#839735}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/de62b251b73b..938399865e72 2020-12-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from aba6331a to 03e3aa54 (163 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: I7afb13a6a2be46980001bf0c7b299ea397ed6740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607179Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ff9ab02a3093..8f0f9afdb63d 2020-12-30 bmeurer@chromium.org [sources] Properly indicate when Scope view is being loaded. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1083146,chromium:1154154 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I44cc083b0bea913415845d601450b512cf0a3af9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606773Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8325d1db179d..fbc75f9ebfca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sauski@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: sauski@google.com Change-Id: I70893bcd841829a33ad9ad88734ad987979c3a97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607151Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1609286132-d2fd9f570fcad76cddcb2f7c9b47595a72cdd5a8.profdata to chrome-win64-master-1609296856-113e120700eba270dcd036921c5e32263182097d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3214c44d5da04656d21d20ee8bb1bf25aad495f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607164Reviewed-by:
-
Alice Wang authored
This CL refactors the method SigninHelper#updateAccountRenameData to get rid of multiple obscure break/continue flow redirections in the code. Bug: 1152460 Change-Id: I8dbaba75ddc3886a59c3ae4ffb29584f096bad68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604905Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#839730}
-
Monica Basta authored
Fixed: 1162274 Change-Id: I558d64f03bd09bd3e8871eae37912e3760b2765b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603308Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#839729}
-
Greg Thompson authored
Make a copy of the Controller's RepeatingClosure before running it in case the Controller is deleted by the callback. This is a speculative fix for a crash seen on macOS when running a Controller's callback. R=fdoray@chromium.org Bug: 1156603 Change-Id: Ib6049c9346f37071ae6a690fff3d6e8585b4a356 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598902 Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#839728}
-
Peter E Conn authored
Change-Id: I99cdeba5761834b3efa71912356fa24d4c98201a Bug: 1160727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606264Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#839727}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1609275440-37f4e219f6f270063631f0695ad136083abdbbb6.profdata to chrome-win32-master-1609296856-3fea7f3d249c98b97623c8f9c4217af37580b20d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6e372ca4eb8d11abff672068ac0cb061fd7a78d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607064Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I943e2791c405657a740012eff0ee2ce6775a69c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601355Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839725}
-
Josiah K authored
Before: https://screenshot.googleplex.com/ngSJzMNZMtLu95d After: https://screenshot.googleplex.com/7REh7ucV3JWtMJk AX-Relnotes: N/A Fixed: 1159696 Change-Id: I132fcd6a8cc953ddba833f515eb5c3aaf26b9f7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596239 Commit-Queue: Josiah Krutz <josiahk@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Auto-Submit: Josiah Krutz <josiahk@google.com> Cr-Commit-Position: refs/heads/master@{#839724}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Id16aa1e88db4e0d0a9fee911de868688c3aeb587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607066Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I7f7b10525e380d3733b2df0a79bcd03d14dd573e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601353Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839722}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I1924f83a9236d90cd61c0eba85bc080aeaa5bb12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607170Reviewed-by:
-
Findit authored
This reverts commit c52857a9. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 839697 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2M1Mjg1N2E5ZTkzOWQ3YzgwNDMxNzJjNWMwMjRhNmY3NmIxMWMwYjYM Sample Failed Build: https://ci.chromium.org/b/8859507199964097568 Sample Failed Step: unit_tests Original change's description: > Observe file modifications in FileChangeService > > Adds OnFileModified observer interface to FileChangeServiceObserver > called when the file is written, truncated, or copied to. > > Fixes file change service unit tests to verify that mocked observer > methods actually get called. The observers were previously not > getting invoked because the test suite did not set up fake chrome > user manager, so user account IDs were not correctly mapped to the > associated test profile, which is something > ObservableFileSystemOperationImpl depends on to get the > FileChangeService to notify of file changes. > > BUG=1139115 > > Change-Id: I9829db0a496eec301a7f7547ac74f61bc1a18bdf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603467 > Reviewed-by: Sergei Datsenko <dats@chromium.org> > Reviewed-by: David Black <dmblack@google.com> > Commit-Queue: Toni Baržić <tbarzic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#839697} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=1139115 Change-Id: I50684606bca59d7b7c3b3f5c9a2aae78de66b3f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606948 Cr-Commit-Position: refs/heads/master@{#839720}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1609286132-6b2bb166adffd428e5bb2e6ce712526c0f94dd16.profdata to chrome-linux-master-1609306855-1926b12895f9a814b281e1425986ef952069eec6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia57cfb4aec91f52422fbec1273c17ba7db080cb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607171Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I2c8249d983fe2a83384a764ee1bc94e202a60aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607169Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I8c06f5d15dcd652f1f500f1765acecd0bb9d763f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607172Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/418801eab36c..8325d1db179d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I50d1da76fdec51bb76d86cd0c35c143df8151ea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606995Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1609286132-e98aa58d6cc3a7d229eb36e271def84a0465b555.profdata to chrome-mac-master-1609306855-ad6e8d3c7e491bfd58012e29cb21279df55a8ecd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I282bfed8c84dbb0091692e616d38b28318198f7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607167Reviewed-by:
-
rajendrant authored
Currently redirects are also counted for applying the maximum number of navigations limit between OAuth start and complete. This CL changes it to only consider the navigations and not the redirects. Bug: 1162327 Change-Id: I44d11f4c04256bebeeb743513f605720092ae2c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604946 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#839714}
-
rajendrant authored
Opening of popup window is detected to track the OAuth requestor site. Then start of OAuth is detected similarly to the existing mechanism. Closing of the popup window is then used to detect OAuth completion. Bug: 1161606 Change-Id: Ifab8be54263adcac298e82a6a362f5271ac5dde7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605003 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
-
Joel Hockey authored
Log WEBUI_UNTRUSTED_CONTEXT extension functions such as the terminalPrivate API used by chrome-untrusted://terminal with new UMA Extensions.Functions.WebUIUntrustedCalls. TBR=mlippautz@chromium.org Bug: 1161001 Change-Id: I188a364c129605205662ab780ab273a894f268ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599649 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#839712}
-
David Black authored
Holding space child bubbles animate out when their sections no longer have finalized items to display. They animate in when at least one of their sections becomes populated. Bug: 1154998 Change-Id: I2d4bc1dc27346aa085c7d12e373d5618639926a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606667 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#839711}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1609221064-65e0288b21a9cea51e4f1fac1a8b654b327fc015.profdata to chrome-win64-master-1609286132-d2fd9f570fcad76cddcb2f7c9b47595a72cdd5a8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7e118a356c6c455539f7fffc40006faf2aaf508b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607005Reviewed-by:
-
Dan McArdle authored
Change-Id: I046a5c433af41cdcdd7fa958e291d279b5c19504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605645 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#839709}
-
Amanda Deacon authored
Bug: none Change-Id: I0031dfe9e9281c328407f6606bd2cc70db127bef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583589 Auto-Submit: Amanda Deacon <amandadeacon@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#839708}
-
Toni Barzic authored
The CL fixes the issue where HoldingSpaceImage was trying to load item thumbnail from the file path the item had when it was first created. This mean that thumbnail load attempts after a file rename would regularly fail. This changes the async bitmap resolver callback to take a file path from HoldingSpaceImage, instead of binding the item path to the callback passed to the HoldingSpaceImage. BUG=1160352 Change-Id: Id1c24fba81e4d0a5b92ad3f87f1f24318b8f71db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606711 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#839707}
-
Chris Mumford authored
Moved access of force_keep_session_state_ origins_to_purge_on_shutdown_ to the IDB task runner sequence to avoid concurrency issues. Bug: 1155754 Change-Id: Ia021d10c52f233579aad7a8f10a9d6792ee173f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597746 Commit-Queue: Chris Mumford <cmumford@google.com> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#839706}
-
Giovanni Ortuño Urquidi authored
WebAppURLLoader is now an implementation detail of PendingAppInstallTask. PendingAppManager unit test shouldn't need to set a fake WebAppUrlLoader to control the timing of the test install tasks. This CL removes WebAppUrlLoader from PendingAppManager unit tests in favor of a "Task Manager" test class that tests can use to control the timing of test tasks. Bug: 1158722 Change-Id: If1d36c4e2ddd400f144b80df456a3ab7f4d58738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596488 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#839705}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ce202c065f97..418801eab36c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I1acf9db08d0f98e3f2c677a319f6eb1042d84293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604951Reviewed-by:
-
Piotr Pawliczek authored
Print servers are queried with the use of SimpleURLLoader. Objects of this class require instance of URLLoaderFactory. This patch changes the way an instance of URLLoaderFactory is provided. Before the patch, an object of URLLoaderFactory was acquired from the global instance of BrowserProcess. After applying this patch, URLLoaderFactory will be acquired from the Profile object. This change enables support for print servers using ipps protocol based on certificates signed with user-provided root CA certificate. To make it works, the proper root CA certificate must be added in the Chrome settings. Bug: b:173569336 Test: Tested on atlas with my own CUPS print server and root CA cert Change-Id: I1fb29e0aa19bf6d2b9942f4aeae460ec16bb28fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605964 Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org> Reviewed-by:
-
