- 07 Oct, 2019 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5750cdd8..62fdbf47 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9a840d00be16a4d6ee4a369c6c48ebea84c5df56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844397Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703341}
-
Nina Satragno authored
Update WebAuthn command responses to match the spec: * AddVirtualAuthenticator should return `authenticatorId` instead of an object containing `authenticatorId`. * GetCredentials should return an array instead of an object containing an array of credentials. Bug: 922572 Change-Id: Id7fc36eca79ae7624c662d8674be0f62a7df72e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841239 Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#703340}
-
Evan Stade authored
Simplify lifetime by making BackgroundContentsService own BackgroundContents. Bug: 268984 Change-Id: I1ee30300849a4549e97cef7f461106dfe2576dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832681 Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Cr-Commit-Position: refs/heads/master@{#703339}
-
Patrik Höglund authored
They sometimes leak on ASAN. TBR: tommycli@chromium.org Bug: 1010691 Change-Id: I663cb4fa70974b35832edacf77e0fdb094631135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844958 Commit-Queue: Patrik Höglund <phoglund@chromium.org> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#703338}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/27399bbb1d0e..af16026220a0 Created with: gclient setdep -r src-internal@af16026220a0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ib5bb1d61e5d7f346721c5909fe40e944806e3b6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845184Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703337}
-
Evan Stade authored
LastDownloadFinder only cares about normal profiles, not OTR. It's ultimately owned by SafeBrowsingService which is itself destroyed before Profiles are destroyed during browser shutdown. Also remove NOTIFICATION_PROFILE_ADDED and replace it with ProfileManagerObserve::OnProfileAdded. Bug: 268984 Change-Id: Ie0ba25eca1262ebb26a71d712b338dd5a3d47e19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830291 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#703336}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7c745839a728..647c7a97d32d git log 7c745839a728..647c7a97d32d --date=short --no-merges --format='%ad %ae %s' 2019-10-07 brianosman@google.com Particles: New confetti effect, minor tweaks elsewhere Created with: gclient setdep -r src/third_party/skia@647c7a97d32d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: None Change-Id: I337d3da3017673759694a5049b31fbf075aaeaf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845185Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703335}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c4f83cee. With Chromium commits locally applied on WPT: c19433ef "Reland "[ChromeDriver] Stop using --ignore-certificate-errors"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ia9c027a10a70221c5e5fd2ff5c231c3b4f27a287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844398Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703334}
-
Peter Wen authored
Add monochrome smoke test for fake modules. Runs on CQ (M) and on waterfall (N, O, P). Bug: 1000749 Change-Id: I3598152b383b45c26adeec72a2038bfb1a09fcca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836375 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#703333}
-
Fred Mello authored
Related to: https://crrev.com/c/1841694 Bug: 1005802 Change-Id: I344c4e408730d8b4c0c70bb22162839ff4171053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842863 Commit-Queue: Fred Mello <fredmello@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
-
Nicolás Peña Moreno authored
Now that we've removed the ElementTiming flag, there is never a reason to delete the TextPaintTimingDetector member from PaintTimingDetector since it should be used to track elements annotated with elementtiming. This CL simplifies the logic within PaintTimingDetector to account for this fact. It also adds tests to ensure that visible objects are not deleted after user input or scroll, since right now they are needed for ElementTiming. Bug: 1011009 Change-Id: Icd58dae42dab3ca65493724b88ab0b939cca53d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838351 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#703331}
-
Thomas Tangl authored
- The implementation is changed to use SyncTest and ProfileSyncServiceHarness for the setup. - If the sync confirmation dialog is opened, it is manually dismissed to not cause any crashes during shutdown. Flakiness should be removed now. Bug: 995720 Change-Id: I66064e40040447ac5a97329f9e5063630c32eebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840171 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#703330}
-
Jacob DeWitt authored
When a controller's PositionAccuracy is "approximate", emulatedPosition should be true. Also update a test page to only display the target ray/laser for a controller when emulatedPosition = false (the controller mesh itself remains visible). That gives an easy way to know the value of emulatedPosition while still in VR. Bug: 1011103 Change-Id: Ie90acc51afd914d1e082be7ddd12643257e9d9cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842477 Commit-Queue: Jacob DeWitt <jacde@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#703329}
-
Xiyuan Xia authored
Session manager daemon will query this feature after it starts chrome. If it is enabled, the daemon waits longer (12s) before killing chrome. Bug: 999214 Change-Id: I9ba16cb7a5eacbd1ed1c213385b350024bbb2f3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841739Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#703328}
-
Elly Fong-Jones authored
As part of the overall move of Views away from inheritance and towards explicit configuration, this change: 1) Introduces DialogDelegate::Params to store a dialog's creation-time parameters 2) Adds a setter that fills in the Params member for default button 3) Replaces all overrides of GetDefaultDialogButton with calls to that setter in the subclass constructors 4) Makes GetDefaultDialogButton non-virtual Bug: 1011446 Change-Id: Ia3c7ea71d6b4ade2e542150ae5a35ede3c3cedc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841945 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
-
Ioana Pandele authored
This change ads a basic toggle in Settings > Passwords that can be used to turn password leak detection on or off. This CL doesn't include customizing the toggle based on sign in state. Bug: 986322 Change-Id: Ia407ef70424de3e8ad1d506ee689d286ac7cb81c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821920 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#703326}
-
behdad authored
Missedframe histograms are for the case that we do not present frame or replaced a reporter by another. Unit test is updated to reflect this change. Bug: chromium:1010927 Change-Id: I0b1dd14d53ba7d17bfa92db6261e3cce6e2da8d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836987 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#703325}
-
Nico Weber authored
Mostly boring, but remove GOOGLE_CHROME_BUILD from two .h files again so that no public_deps on //build:branding_buildflags are needed. Bug: 961769 Change-Id: Iff4db52b895c9a0ab5fbc6c299956c28ef966b38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841977 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#703324}
-
Fredrik Söderquist authored
When the next "interesting" time is past the current presentation time, we don't need to perform an interval update step, but can just update the progress when updating the active animation stack. Bug: 998526 Change-Id: I5bd1c0f7476dcd89bc1879cac5851fba6e5a67bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844977Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#703323}
-
Pavel Shmakov authored
This corresponds to "fullscreen" mode of WebAPKs. In addition to what WebAPKs do, I suggest to allow TWA apps to customize the following parameters: - "stickiness", https://developer.android.com/training/system-ui/immersive#sticky-immersive - cutout mode, https://developer.android.com/guide/topics/display-cutout Both are very easy to support, and it should be up to the developers to pick these parameters. Why js fullscreen API is insufficient for TWAs? Aside from the problem mentioned in crbug://965329 there is a more fundamental one: js API can't be used before page loads, i.e. during splash screen. If an app wants immersive mode (e.g. a game), a non-immersive splash screen followed by a "jump" into immersive mode would look poorly. Other sides of this three-sided CL: https://android-review.googlesource.com/c/platform/frameworks/support/+/1120985 https://github.com/GoogleChrome/android-browser-helper/pull/25 Bug: 989610, 965329 Change-Id: I85759963561a4bb4da68f4d4e5020df3cb35cb67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803278 Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#703322}
-
Eric Lawrence authored
When EnableAuraTooltipsOnWindows was enabled, HTML title attributes and other content that display tooltips started rendering a box instead of whitespace for a tab character. This change replaces tab characters with six spaces, approximating the rendering of pre-EnableAuraTooltipsOnWindows display and that of other browsers. Bug: 993100 Change-Id: Ib0a39850bfd13b73a960828cd465cc965e6a713d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834889Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Cliff Smolinsky <cliffsmo@microsoft.com> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#703321}
-
James Zern authored
libyuv is referenced in aomenc.c but was never built or used anywhere in chromium. Make this explicit. previously for libvpx: https://chromium-review.googlesource.com/c/chromium/src/+/1838164 BUG=1011071 Change-Id: I8e18b76321699fef8769c2c38e18b3cfd9cfb1d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842621 Commit-Queue: Johann Koenig <johannkoenig@google.com> Reviewed-by:
Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#703320}
-
Evan Stade authored
This restores behavior broken by 6670c336 Change the name of BackgroundApplicationListModel::is_ready() to startup_done() to disambiguate from ExtensionService::is_ready(). Move BackgroundContentsService observation to OnExtensionSystemReady() so we don't run BackgroundApplicationListModel::Update() too early. Note that it's not sufficient to check whether the ExtensionService is ready because it may return true before BackgroundApplicationListModel::OnExtensionSystemReady runs. Bug: 1008890 Change-Id: Ib3e5013e7857e7a9aa6f94ed6b43f3839e08fe00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837486Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#703319}
-
Lan Wei authored
testActionsMultiTouchPoint is flaky, I change the test to listen to touch events instead of pointer events. We should received two touch start and two touch end events. Bug: 999982, 1011225 Change-Id: I5310f42b347d6376cd976f58ae5a33c2e5c3042c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841760 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
-
Nick Burris authored
Change the targetText= directive to text=. Also remove the non-fragment-directive case and the ## delimiter since we definitely won't be using them. Updated all tests to use :~:text= syntax. Updated web platform tests to reflect text= change and delimiter change to :~:. Tested updated WPT locally with run_web_tests.py --additional-driver-flag= '--enable-blink-features=TextFragmentIdentifiers' Bug: 1008874,1007016 Change-Id: Ic7f3db39e0a17d5adb8186b2ab5081d60553bd8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835892 Commit-Queue: Nick Burris <nburris@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#703317}
-
sandromaggi authored
Bug: 806868 Change-Id: I7fcccc58ac9e397c5809a06d5bb407600ce73fe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844960Reviewed-by:
Jordan Demeulenaere <jdemeulenaere@chromium.org> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#703316}
-
Adrian Taylor authored
This change notes that, for bugs being actively exploited in the wild, we should use a higher priority such that they are fixed and merged as rapidly as possible. The change deliberately does not specify the priority to use in this case, as this should be an extremely rare event and be subject to extensive discussion. However, it does go so far as to say we 'should' use a higher priority, which for a medium or high bug typically means it would end up being Pri-0. That seems like it would typically, but not always, be the right thing to do, so it feels like it gives the right guidance. Change-Id: Ied0ad4c9ab61425b748f4e8c78e7ea0a46bb060e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841509 Commit-Queue: Adrian Taylor <adetaylor@chromium.org> Reviewed-by:
-
David Van Cleve authored
The original patch, crrev.com/c/1834948, had deterministic test failures on Windows-7-SP1(x86-64) even though it passed the main flight of trybots. Hopefully, moving all the tests to the SSLClientsocketZeroRTTTest framework (suggested by svaldez) will fix this. -- Original commit message This commit extends metrics coverage to provide more descriptive logging of TLS 1.3 handshakes' 0-RTT state, by logging the ssl_early_data_reason computed in BoringSSL. This records whether TLS 1.3 early data handshake attempts succeed and, if they fail, why. R=csharrison,svaldez,davidben Bug: 1000659 Change-Id: I19a3dc2dff963e0a84b8de669c886241f5aea7b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834927 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#703314}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3eafc49228d0..cd2fb1efa170 git log 3eafc49228d0..cd2fb1efa170 --date=short --no-merges --format='%ad %ae %s' 2019-10-07 perezju@chromium.org [Telemetry] Record ad hoc measurements as artifacts 2019-10-07 perezju@chromium.org [Telemetry] Refactor more RunBenchmark unittests 2019-10-07 dproy@chromium.org Revert "Use chromium build on linux for dev server tests" Created with: gclient setdep -r src/third_party/catapult@cd2fb1efa170 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:999484,chromium:1008852,chromium:973847 Change-Id: If1842ba8e76c76f93ca3df3d01558efc742d7cd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844153Reviewed-by:
-
ckitagawa authored
Metadata tracker for paint previews to capture links, OOP subframe, and glyph usage information during capture. Bug: 1006832 Change-Id: Iab3e88e67d601d712905f263de7cf01ca1930a31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819618 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#703312}
-
Kent Tamura authored
I2DR: https://t.co/ngv1jxRKwk * relative-position-replaced-in-table-display-crash.html Add width and height properties to avoid 0x0 size on non-macOS. Bug: 981720 Change-Id: I83a3356bb87425d1b1628872a3f06cc875e2bd1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844003 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#703311}
-
Andrew Grieve authored
Binary files don't belong in target_gen_dir. Bug: 917446 Change-Id: I08611efc78c20ee7cdf65e0ed3090e96c7cb7242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839431Reviewed-by:
-
kylechar authored
This CL fixes four remaining cc_unittests that were failing when |enable_surface_synchronization| was enabled in LayerTreeSettings. These tests all required some structural changes as allocating a LocalSurfaceId changes the order of events that occur. Bug: 985009 Change-Id: I6ab67176b80f4e6d649f13b759a6d5fafa8149fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841880Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#703309}
-
Andrew Grieve authored
Change-Id: I8505a8a5509edaf08f479855d4a0b7ab14cf9567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844447 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Alex Clarke authored
Usually ChromeTabbedActivity.initializeState performs the initial navigation, however for view intents we know the URL and can start as soon as the profile is loaded (can be several hundred ms earlier on low end devices). In theory it might be possible to do this for main intents too but getting hold of the URL is beyond the scope of this patch. This change is guarded behind the kPrioritizeBootstrapTasks feature. BUG 863341, 835323 Change-Id: If296fde03b381178ed6feeba70bc50b786eac1e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663146Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#703307}
-
Vlad Tsyrklevich authored
Update the Android field trial to be enabled for WebView as well and update the parameters--they now match GwpAsanUnified. Bug: 973167 Change-Id: Ia657966e6e5b145f44afa06f9dfe80c91e370eda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844114 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#703306}
-
Rune Lillesveen authored
Since Document and ShadowRoot do not have dirty-bits set for layout tree rebuilding, and for style recalc with FlatTreeStyleRecalc enabled, the parent node in StyleTraversalRoot::Update might not be IsChildDirty(). Instead, move the DCHECKs to ClearChildDirtyForAncestors in the respective implementations. There was no known issue for this for LayoutTreeRebuild root, most likely because the tree does not change between Recalc, which sets the layout tree rebuild root, and RebuildLayoutTree. But, for StyleTraversalRoot there were a bunch of web_tests triggering DCHECKs when FlatTreeStyleRecalc is enabled. Bug: 972752 Change-Id: I258564f7eee6e155b8b4bbffaa286222cd98b6a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841453 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#703305}
-
John Delaney authored
This reverts commit abaf4c65. Reason for revert: Caused flakiness in AdsPLMO browsertests. See https://analysis.chromium.org/p/chromium/flake-portal/analysis/ culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb 21pdW0vYWJhZjRjNjU3MmM3NjA3YzQ3MWZhNTYyOGNkOWIzOTNmNTc1NGE5OAw Original change's description: > Add fuzzing to network threshold for heavy ads > > This CL adds up to 1303 KB of uniform random noise to the network threshold > for the heavy ad intervention. This is to done to prevent frames from > learning cross-origin resource sizes in the clear. > > We add a second computed type metric to measure > the number of frames that we are missing due to the fuzzing. > > Bug: 1010619 > Change-Id: Ia48a4253beafcfbfdbdc689f2ae381dfe5a34c43 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835166 > Commit-Queue: John Delaney <johnidel@chromium.org> > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702994} TBR=csharrison@chromium.org,johnidel@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1010619 Change-Id: I6f90c0a3be56df50331275305e9e9a0d6dd9aa12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845151 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#703304}
-
kylechar authored
This reverts commit 2e452bbf. Reason for revert: https://crbug.com/1000251 is fixed. Original change's description: > [Sheriff] Disable BookmarkBarInvisibleOnShutdown on Linux > > TBR=weidongg@chromium.org > > Bug: 1000251 > Change-Id: I8e3372766ab9e560c9f47f7c2f8292ebc8af644c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782637 > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#692666} TBR=jdoerrie@chromium.org,weidongg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1000251 Change-Id: Id9af5a221f5ca04873ce30737c2a9be58afd9fb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844854Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#703303}
-
Dmitry Gozman authored
This is decided per navigation, no need to later change it through WebDocument. Bug: none Change-Id: Ibae0f2ea53d56163f1dd59fa2f89ddd6993676f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844194Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#703302}
-
