- 31 Jul, 2019 40 commits
-
-
Alex Moshchuk authored
The comment said this is only used for subframes, whereas in fact it's been used for all frames for a while. For example, see https: //cs.chromium.org/chromium/src/content/browser/renderer_host/render_view_host_impl.cc?l=384&rcl=30ecc820 Change-Id: Ib5d03a4feb5047ae02021af448e2ebeb1a0a3002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729957 Auto-Submit: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#682963}
-
Mohsen Izadi authored
When a child surface has a damage, this damage should also be reflected in MirrorLayers of the parent surface. This CL forces entire boundaries of those MirrorLayers to be marked as damaged. This is a temporary workaround as the proper solution would need to calculate the actual damaged area in each MirrorLayer. BUG=947565 Change-Id: Iae8bd6f5860978f5eab75b5d845847c0a87796e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717452Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#682962}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/748b4c7b..22b6cbc9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I094328ca9f6034a5c39f5fce6c0b3474a03b2248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729475Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682961}
-
Kyle Milka authored
Bug: 937570 Change-Id: I2d4f0134a3734195082ecc5c003b5542a91cad30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728427Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#682960}
-
Carlos Caballero authored
MessageLoopForUI will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you believe your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=dcastagna@chromium.org Change-Id: I84f35ed846888a4a3e9c02645252f57127f57d8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715382 Auto-Submit: Carlos Caballero <carlscab@google.com> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#682959}
-
Mason Freed authored
Prior to this CL, backdrop-filtered elements that also had a mask or clip-path applied would render incorrectly, in software_renderer. See [1] for further explanation. [1] https://chromium.googlesource.com/chromium/src/+/310cae44aff889a75fc85ce5ec89d9341eccc665 Bug: 981207 Change-Id: I2df92384954d67812c7d7db4c7e0b9f72f4393ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724798 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#682958}
-
Ramin Halavati authored
Since planning for private browsing modes is still in progress and we would need to measure the changes after the changes as well, the expiry incognito lifetime metric is moved to M-85 and the second owner is set to chrome-privacy-core@google.com Bug: 988709 Change-Id: I1224e593ba60651c3edd5a1ce22a5db52822b9e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724528Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#682957}
-
Robbie Gibson authored
Bug: 976664, 976665, 976667 Change-Id: I2d9c83aece57b6272d65c9b81f4579a749a1163a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728566 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#682956}
-
Anastasia Helfinstein authored
Bug: None Change-Id: I3da18fe44f11fb9b791ba7be8b89d3b73bb94f02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726652 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Auto-Submit: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#682955}
-
sczs authored
- Changes Settings dispatcher to support Browser Commands. - Adds a new method to Snackbar Commands to display a snackbar with no offset. Bug: 804656 Change-Id: I83ccba84f83e781ebd169de984e1f3f031590c0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719992 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#682954}
-
Mike Dougherty authored
TBR=jlebel@chromium.org Bug: 989726 Change-Id: I391c68caa6fb7804a6162f1fc78343e192b3ba0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728341Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#682953}
-
Hiroki Nakagawa authored
Before this CL, ApplicationCacheHostForSharedWorker was created via WorkerShadowPage and DocumentLoader. That was blocking WorkerShadowPage removal. This CL removes the dependency by creating the host for shared workers in WebSharedWorkerImpl instead. Bug: 538751, 982996 Change-Id: I64e4a0cbba835d126c5144072e369f8bad3dc477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724641Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#682952}
-
Owen Min authored
Disable the test on Mac and Win-ASAN according to https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests&tests=RenderFrameHostManagerUnloadBrowserTest.PostMessageToParentWhenSubframeNavigates Bug: 989704 Change-Id: I306f6527650adb385a9a026a52da986b94201873 Tbr: arthursonzogni@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728716Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#682951}
-
Lucas Furukawa Gadani authored
This is a reland of f9763b52 Original change's description: > Convert content::CommitNavigationParams to mojom. > > Bug: 984550 > Change-Id: Ic966c764e7fb52a9fb8d2ea44d9777bd8c1e4011 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725096 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Scott Graham <scottmg@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Commit-Queue: Lucas Gadani <lfg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#682795} Tbr: zmin@chromium.org Bug: 984550 Change-Id: I3ec99e6c57e33cd85203125c250a26b4e50384a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729921Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#682950}
-
Marc Treib authored
Bug: 950269 Change-Id: I3fd1e103b675166b4bbc69205d8f92b02ce63c9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720832Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#682949}
-
rbpotter authored
- Include previously added JS module files in release builds. This is necessary to migrate Web UI pages to use Polymer 3. - To avoid a large increase in size on Android, minify files with uglify, since closure doesn't support modules. This allows the JS module files to be minified in Android official builds, instead of using the skip_minify mechanism previously added for Blink modules. Bug: 965770, 839512, 729689 Change-Id: I195d7d2e53b9ad5a3b3f6045fc5268ba7ea664be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721303 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#682948}
-
Michael Ludwig authored
SkArithmeticImageFilter was previously being included transititvely via SkXfermodeImageFilter.h, but we are cleaning up Skia's includes and SkXfermodeImageFilter.h will not be including it anymore. Change-Id: I3ae38cb892526c10bb76a0584edba13f59d14dbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729802 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Commit-Queue: enne <enne@chromium.org> Auto-Submit: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#682947}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fee597729b1d..16a3e45749cb Created with: gclient setdep -r src-internal@16a3e45749cb The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ie37328444c02e44f3be5f94c249c46cc34c01533 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729911Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682946}
-
Elly Fong-Jones authored
This change implements step 2 of the process outlined in //docs/flag_expiry.md. This change will be merged to the M77 branch after it lands so that these flags are actually expired in M77 :) This change: 1) Adds a new bit to the supported_platforms mask in flag entries, named 'kExpireM77', which is set if a flag expired in M77; 2) Adds a new feature "TemporaryUnexpireFlagsM77" and a matching flag "temporary-unexpire-flags-m77"; 3) Adds code to the flags UI to hide flags with kExpireM77 in their supported_platforms mask unless TemporaryUnexpireFlagsM77 is enabled. 4) Removes already-gone flags from //c/b/flag-metadata.json 5) Removes already-gone flags from //docs/flag_expiry.md Future iterations of this process will use two more bits in the supported_platforms mask, since the flag expiry process maintains a window of two milestones between flag expiration and final removal, so (e.g.) at M78 kExpireM77 and kExpireM78 will be live, and at M79 kExpireM77 will be removed and kExpireM79 added, such that kExpireM78 and kExpireM79 will be live. After this change, all the flags annotated with kExpireM77 show as "unsupported platform" in the flags UI and are greyed out. A follow-up change will add a specific annotation to these flags in that UI marking them as expired. Bug: 953690 Change-Id: I2d7361b6f3f070ecf469bf4eccb9b42b5a19d704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729449 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#682945}
-
Chris Harrelson authored
This is an expensive operation. See LayoutBoxModelObject::RelativePositionOffset. Bug: 984965 Change-Id: I487d2eaa96ee63c8cff88d12a062feec53ddb05a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726896Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#682944}
-
Kinuko Yasuda authored
They use the include guards in a very specific, peculiar way Bug: 814776 Change-Id: I5ff8b8840f88ee993b42d7792be6267d3864f583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728533Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#682943}
-
Dmitry Torokhov authored
These keys can be generated by any external keyboard, not only Wilco-specific one, and therefore should be handled in the common event rewriter path. Bug: b/135045276 Change-Id: I66f42f41c2875f3279a9f80cb46394b7e7645cd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700649Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Dmitry Torokhov <dtor@chromium.org> Cr-Commit-Position: refs/heads/master@{#682942}
-
James Forshaw authored
This CL allows the setting of process mitigation options when using an AppContainer. Prior to Windows 10 RS5 setting process mitigation options at creation time resulted in an ERROR_INVALID_PARAMETER failure when calling CreateProcess. Since RS5 this seems to have been fixed so ensure we pass all the required mitigations to the new sandbox process. Bug: 976906 Change-Id: I455eed62b702c34687617cd45ed6fd17382cd947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727735Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#682941}
-
Justin Cohen authored
This reverts commit 7b9599f6. Reason for revert: Speculative revert to see if anything changed. Original change's description: > Disable RememberCertDecision test. > > TBR=rohitrao@chromium.org > > Bug: 973635 > Change-Id: Ibdd73fa2c40cbea322e22271dc02017cd2d9326a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656589 > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#668609} TBR=rohitrao@chromium.org,eugenebut@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 973635 Change-Id: I69295a9f56101678466744e38279a01f814503c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729400Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#682940}
-
Gayane Petrosyan authored
As top and left change for selected tile, it doesn't align with other tiles anymore. Therefore keyboard navigation doesn't work for selected tile. This CL searches for the next tile taking into account the position of the parentElement which doesn't change when the tile is selected. screencast: https://drive.google.com/file/d/1i4CeDhe3LIc-6VntqiCFoK55HT1kbNWm/view?usp=sharing Bug: 989221 Change-Id: I917467b524460ea0d31c1b74ef228a6313264126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727718 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#682939}
-
Brandon Jones authored
The WebXR spec now states that this value is implied based on the mode of the session the layer was created with. Bug: 987352 Change-Id: I5f5999822a3504fbc79934ded29310074c454680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729799Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#682938}
-
Caitlin Fischer authored
Follow-up on this CL comment: https://chromium-review.googlesource.com/c/chromium/src/+/1721083/1/tools/metrics/histograms/extract_histograms.py#279 Bug: 988089, 924136 Change-Id: I1b398d1ce808e511308ae5e3c002a3f70648410d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726596 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#682937}
-
Morten Stenshorne authored
(continued from (abandoned) CL:1719269) During relayout, when we get a cache hit for a node, we still recalculate overflow (why?). This may cause scrollbars to appear or disappear, which will mark for layout. If this happens, we need to discard the cached result and perform regular layout instead. There *may* be legitimate reasons for adding or removing scrollbars on a node that doesn't need relayout (although I cannot think of any), but in this case (the test case), we gain a scrollbar because of some amazing code in LayoutBlock::ComputeLayoutOverflow(), which adds 1px hardcodedly, to the overflow rectangle width. Bug: 919415 Change-Id: Icd49db76065f8ac50ff3616b97c0d05ca0e2b348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728562 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#682936}
-
Fei Ling authored
Change-Id: I8db4b6ac9afd6f54d0f9cb5defea72456f4f2b87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713708 Commit-Queue: Fei Ling <feiling@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#682935}
-
Roberto Carrillo authored
This change makes the merge script remove the results file for bad shards. This should make the rest of the pipeline properly treat those shards as missing and retry them if appropriate. R=liaoyuke,martiniss Bug: 955012 Change-Id: I4bddc82fe1219b68adeb11d76a299962dddf65c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719265 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#682934}
-
Sanket Joshi authored
Prior to this CL, the new color picker only supported the HEX color format. Now, users can also view and/or manually change the selected color in the RGB color format. Users can switch between the HEX and RGB formats by clicking on the format toggler, and if the user changes the color value in one format, the color value for the other format also needs to be updated. To make it easier to translate values from one format to another, helper functions like hexToRGB and rgbToHex are being added to the Color class. Bug: 982087 Change-Id: Id6926f25cc01a94044be7f0d4ed876451c3e9719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717188Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Sanket Joshi <sajos@microsoft.com> Cr-Commit-Position: refs/heads/master@{#682933}
-
Hiroki Nakagawa authored
Reland "AppCache: Reduce dependencies on DocumentLoader from ApplicationCacheHost for shared workers (4)" This is a reland of 1ac215fe The original CL was reverted because of MSan failures on content_browsertests. That was caused by using uninitialized |WorkerShadowPage::appcache_host_id_|. WorkerShadowPage's constructor calls WebLocalFrameImpl::CreateMainFrame() that will access |appcache_host_id_|, but the host id will be initialized after calling CreateMainFrame(). Changing the initialization order is one of solutions, but it causes another bug. Interestingly, AppCacheHostForSharedWorker is created twice for the same appcache host id via WorkerShadowPage's constructor (CreateMainFrame()) and WorkerShadowPage::Initialize() because both the functions initiate DocumentLoader::StartLoading(). This results in bad mojo message "ACSI_REGISTE" in AppCacheServiceImpl::RegisterHostInternal(). Changing the initialization order doesn't avoid this bug. Before this CL, the first host creation uses a nonexistent appcache host id, and the second host creation uses a real appcache host id. This CL takes the similar way: first WorkerShadowPage initializes its |appcache_host_id_| with an invalid id in the constructor for the first host creation, and then sets it to the real appcachec host id in WorkerShadowPage::Initialize() for the second host creation. Note that |appcache_host_id_| will be removed by the next CL soon: https://chromium-review.googlesource.com/c/chromium/src/+/1724641 Original change's description: > AppCache: Reduce dependencies on DocumentLoader from ApplicationCacheHost for shared workers (4) > > In the current implementation, WorkerShadowPage provides DocumentLoader to > ApplicationCacheHost for shared workers. This blocks WorkerShadowPage removal > (see the issue). To unblock it, this series of CLs reduce dependencies on > DocumentLoader from ApplicationCacheHost for shared workers. > > This CL... > > - moves WillStartLoading(), WillStartLoadingMainResource(), > IsApplicationCacheEnabled(), and |document_loader_| from ApplicationCacheHost > to ApplicationCacheHostForFrame. > - introduces WebLocalFrameClient::GetAppCacheHostIDForSharedWorker() to take an > appcache host ID from WorkerShadowPage with bypassing DocumentLoader. This is > a stopgap implementation, and will be removed by follow-up CLs soon. > - makes ApplicationCacheHostForSharedWorker binds itself with the backend in the > constructor instead of WillStartLoadingMainResource() that is a part of the > lifecycle of DocumentLoader. > > The follow-up CLs will create ApplicationCacheHostForSharedWorker in > WebSharedWorkerImpl instead of DocumentLoader. That will completely remove > DocumentLoader association from ApplicationCacheHost for shared workers. > > Bug: 982996 > Change-Id: I5beedd7600291a6f4867d35505e658b7f7194fbd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722932 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> > Cr-Commit-Position: refs/heads/master@{#682075} Bug: 982996, 988997 Change-Id: I816ab546dd02b5c653300759338fcb0af728fa90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725327Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#682932}
-
Juanmi Huertas authored
Improving the DCHECKS to control that we are being on the correct thread and copying the buffer if we are not coming from mainthread. Bug: 986792 Change-Id: I45436b2a778c72586719f88aa579ad3e24cc48cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721790 Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#682931}
-
Brian Sheedy authored
Re-enables the Android Webview GPU pixel tests on Nexus 5X devices since the issue that was causing them to fail has been fixed. TBR=ynovikov@chromium.org Bug: 987623 Change-Id: Iae0a13488e023ac9969e462970441aa382bbd0c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728042Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#682930}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/53571c75c695..8d3e4bd9a6c5 git log 53571c75c695..8d3e4bd9a6c5 --date=short --no-merges --format='%ad %ae %s' 2019-07-31 srte@webrtc.org Adds simulated network node builder. 2019-07-31 srte@webrtc.org Adds non-forwarding frame tap to video frame matcher. Created with: gclient setdep -r src/third_party/webrtc@8d3e4bd9a6c5 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Id6b354f4e6938ad8e1b324efa6a48f0bd2e51835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729909Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682929}
-
Ilya Sherman authored
Among other things, correct a typo: "reminder" -> "remainder". R=mpearson@chromium.org Bug: None Change-Id: Ic8f35a7024e7cb18128a05b043b37b866abc65e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729797 Commit-Queue: Ilya Sherman <isherman@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Auto-Submit: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#682928}
-
Alberto Herrera authored
"mus" doesn't exist anymore, so it should be safe to re-enable back these tests. Bug: 765794 Change-Id: I8efa18d8d514d902e9f7654da8a810ed633481e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729790Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Alberto Herrera <ahrfgb@google.com> Cr-Commit-Position: refs/heads/master@{#682927}
-
Dan Beam authored
There are duplicate names in ChromeCodingConvention.java inside of third_party/closure_compiler/compiler/compiler.jar that match assert, assertNotReached, and cr.ui.decorate. Recently, @closurePrimitive {...} was created in order to annotate these methods instead of needing to duplicate their names in Java. Use this syntax in Chrome while concurrently removing it from the compiler's Java internally (eventually released externally). R=dpapad@chromium.org BUG=970885 Change-Id: I24f7bad0f52cf9c5af8984b9f8e4c063743c35e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729835 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#682926}
-
Josh Nohle authored
Updates test device data to reflect the fact that the local device should always have access to its own BetterTogetherDeviceMetadata. The local device now also requests the group private key. Also, added the missing GetAllTestDevices() declaration. Bug: 951969 Change-Id: I913c2281cb3bd101bd67137bf66f3181976b64d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728336 Commit-Queue: Josh Nohle <nohle@chromium.org> Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#682925}
-
Brett Kilty authored
This flag hasn't been used in code in a while. Delete some unused code. Test: local build, no breaks. Bug: none. Change-Id: Id642f5c9424332395d5abc5d338bb8fe9fcb602e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667607 Commit-Queue: Brett Kilty <brettk@google.com> Auto-Submit: Brett Kilty <brettk@google.com> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#682924}
-