- 22 Jan, 2020 40 commits
-
-
Adam Ettenberger authored
[1] https://www.w3.org/TR/html-aam-1.0/#html-element-role-mappings [2] https://w3c.github.io/core-aam/#mapping_role_table For UIA the only difference between a <form> with an accessible name and one without is a <form> that does not have an accessible name : 1. Has no corresponding ARIA Role. 2. Does not have a UIA Landmark Type Unfortunately if a role is not mapped, then the node becomes a generic container which can break expectations for both aria-setsize and aria-posinset because |AXTree::PopulateOrderedSetItems| cannot detect the form without adding a check for StringAttribute::kHtmlTag and will recursively include descendants of the form with the siblings of the form. In particular, not mapping a role broke : DumpAccessibilityTreeTest.AccessibilityAriaPosinset/* ... the 2 radioButton nodes inside the form and the 2 radioButton siblings of the form would all have setSize=6, and the posInSet of the later 2 nodes was also offset to be 5 and 6 respectively. Because the reasoning behind these differences is to prevent an unlabeled form from acting as a landmark, I kept the change local to UIA Landmark Type. Bug: 1042420 Change-Id: I2bc4e052e81d447aea42d3585cbe65a2baa1165c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003257Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Commit-Queue: Adam Ettenberger <adettenb@microsoft.com> Cr-Commit-Position: refs/heads/master@{#734109}
-
Dave Tapuska authored
Fix a bad cast that had existed for years (originally written by in crrev.com/d322c5ca) This was only recently uncovered by clusterfuzz when we added virtuals to the WebInputEvent in crrev.com/547be407. Fortunately the cast shouldn't have caused any issues. BUG=1044379 Change-Id: I47463bd671b17beba9e2ebd5803ec1ea93236bb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013477Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#734108}
-
Mohammad Refaat authored
SideSwipeController initializer now take a Browser instead of browserState and tabModel. SideSwipeView will be initialized with webStateList instead of tabModel. Bug: 783777, 1043370 Change-Id: I5ed4e20b9bb6f8def9f6fff89a333bdfc142b59d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008003 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#734107}
-
Nate Chapin authored
This wrapping up of parameters leaves SecurityContext construction much more readable. To enable this, SecurityContextInit needs to be usable as a const reference in the SecurityContext constructor. This doesn't work currently, because there are two functions that move and return a std::unique_ptr. This CL therefore changes construction of the SecurityContextInit to store the state need to later construct the objects that will be returned wrapped in a std::unique_ptr. Bug: 1029822 Change-Id: Ic1f17ac22aa38eb77614735d41609941457d6698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006074 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#734106}
-
Eric Stevenson authored
NativeLibraries.java has a dependency issue that creates problems for Trichrome Webview 64 bit component builds. This CL adds a workaround of these issues by just listing a single native library, libmonochrome.cr.so, which does have the right dependencies (listed in the "NEEDED" section of the binary). The problem and fix both only affect trichrome component builds. Bug: 1042107 Change-Id: Ib4873daeccf89373cacf1aace1240b6d708331f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008464Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#734105}
-
Shawn Pickett authored
Bug: 984851 In http://crrev.com/c/1708013, a change was committed to improve battery life by avoiding unnecessary media caching. This submission, driven by feedback from http://crbug.com/984851, makes an additional adjustment in preparation for testing trials. It adds a check to verify that the device is running on battery and is not connected to AC power. Since the goal is to improve battery life, this scopes the change so that it doesn't impact scenarios when the device is connected to power. The potential disadvantage is that the caching behavior can now be different depending on whether the device is connected or not. Since the entire change is under a feature key, the idea is to verify that the reduction in media caching does not lead to any discernible difference in user-facing functionality between the scenarios during the testing trials. Change-Id: I8b73da81a509962701e30cfd43f36b34b0dc70b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830069Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Shawn Pickett <shawnpi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#734104}
-
Alexei Svitkine authored
Removes a method declaration that no longer exists and fixes a comment reference. Bug: None Change-Id: Ic80f0c0acc391d0eb4d9dd5459054a438d282327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013891 Auto-Submit: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#734103}
-
rbpotter authored
This test only appears to have failed in the CL that disabled it on the Mac bot. Re-enable it for other platforms. Bug: 1044390 Change-Id: Ic1d6290e7ae2cb9ebfdb6d4d2038cb7a64a3ee7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013911Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#734102}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/afc469d68c53..71fa12130a57 Created with: gclient setdep -r src-internal@71fa12130a57 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: If328a1db5f93bea9a06e6e472d7d19db5b833f6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013771Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734101}
-
Robbie Gibson authored
The text zoom level is stored in a user pref and keyed based off the current url host and the current iOS content size category. This means that if the user changes the zoom on one page and then changes the accessibility text size, the earlier change won't affect the page in the new text size. Thus, if a page is broken at one accessibility text size, any user adjustments will not affect other text sizes. This does not clear the preferences when browsing data is cleared. That will be added later. Bug: 1028938 Change-Id: I5a3a71f2bfa3d84750f714d2e2cffa869f40ccc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002520 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#734100}
-
khmel@chromium.org authored
This one is important to estimate health of secondary account sign-in. This stats should also be used for estimation of secondary account sign-in improvements. BUG=1036943 BUG=b:/146792085 TEST=N/A Change-Id: I80c2ec4886fcaad79cb1de07899c01e2a9f9b997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980897 Commit-Queue: Yury Khmel <khmel@chromium.org> Auto-Submit: Yury Khmel <khmel@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#734099}
-
Jeremy Roman authored
This could happen if such an element is created in a document with portals enabled and moved into a document with portals disabled. Bug: 1040627 Change-Id: I8925a02d21c7d6a124def303d903d0b715836d93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013473 Auto-Submit: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#734098}
-
Sajjad Mirza authored
The win10_chromium_x64_coverage_rel_ng tryjob needs to run the same test targets as win10_chromium_x64_rel_ng to make sure that coverage mode will not break the latter when it is enabled. Bug: 1041689 Change-Id: Ib1edad65f58770930475bdb354d8dee7e8ae6ccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006265Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> Cr-Commit-Position: refs/heads/master@{#734097}
-
Rafael Cintron authored
Remove ddorwin from the OWNERS file since he no longer works on VR. Change-Id: Idb8fdcc8e55295d2be23c1f172e88b2a1ac75d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014145 Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#734096}
-
Ben Pastene authored
Will be release version of current Lollipop phone tester. Bug: 1032336 Change-Id: Ib5832b91867243dddf9fae23236a483a68644453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012838 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
-
Matt Menke authored
This is needed to correctly isolate any DNS requests made by PPAPI in the context of one page from those made in the context of other pages. Bug: 1021661 Change-Id: Ibbca8db7df8c7e61cb9522630e70c8ccd365b5c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008050 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#734094}
-
Hwanseung Lee authored
strike_database_ variable seems not used anymore. Bug: None Change-Id: I984da6158b01b2d36b3e43da563b4ea912bec0ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014213 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#734093}
-
Mohammad Refaat authored
Also update users to call the new methods. Bug: 1042277, 783777 Change-Id: Ie318b3828f9a1e00c86e5e731c9ff758a9283931 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008071 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/84dafa149509..56d4671ce783 git log 84dafa149509..56d4671ce783 --date=short --first-parent --format='%ad %ae %s' 2020-01-22 treehugger-gerrit@google.com Merge "tp: allow embedders to disable parsing typed ftrace into raw" 2020-01-22 primiano@google.com Merge "ui: small fixes to service worker / offline support" 2020-01-22 lalitm@google.com Merge "ui: fix async and global slice tracks" 2020-01-22 eseckler@google.com Merge "processor: Fix order of async events in json export" 2020-01-22 lalitm@google.com Merge "tp: add sorted flag to ref_set_id and fix costing of sorted cols" Created with: gclient setdep -r src/third_party/perfetto@56d4671ce783 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I50b408208d9cbb77d1cc91c8e00fe4f20bc61684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015005Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734091}
-
Robert Ogden authored
NavigationPredictor is currently tied to a RFH via mojo channels but the lifetime of a RFH is difficult to reason about, especially during a navigation to a different origin. This CL moves NavigationPredictor to a WebContents-centric approach with the added benefits of easier lifetime management and easier use in dependent code. Of important note: * The mojo channels that manage the lifetime of a NavigationPredictor are still tied to the main frame RFH since that maps to how renderers actually work. * A NavigationPredictor can enter a "lame duck" state where it is observing a WebContents that has been destroyed, but has yet to be destroyed itself by mojo. Thankfully, this is easily detected since a WebContentsObserver's web_contents() method returns nullptr when this occurs. Both places where web_contents() is used are now guarded by this check. * Multiple RFHs may belong to one WebContents, but only one NavigationPredictor will be created for each WebContents because the RFH must be the single mainframe to construct a NavigationPredictor. Bug: 1023485, 1041828 Change-Id: I6234225132048c70539395a3d1869602e7b0a0ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008775 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#734090}
-
Dave Tapuska authored
Get rid of multiple definitions of ResourceTimingInfo in blink and content. Move it to a single mojom implementation and move callees to use the mojo versions. BUG=1040100 Change-Id: Id4ecf49ee8ff651dde67aa3816278a60e7b31b87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003562Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#734089}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3ff3368a..6b291043 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1e103c473051ee0437aab7fe70733cc78fca2bb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015060Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734088}
-
Stephen Nusko authored
v8.browsing_desktop/browse:search:google v8.browsing_desktop-future/browse:media:youtubetv:2019 NOTRY=true TBR=crouleau@chromium.org CC=mythria@chromium.org,ulan@chromium.org BUG=1044653 Change-Id: I131ca13b3e42865db1c8ea47c7353336a2f1a4f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015082Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#734087}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ba5dc20d6d6f..2e45f00d3687 git log ba5dc20d6d6f..2e45f00d3687 --date=short --first-parent --format='%ad %ae %s' 2020-01-22 aerotwist@chromium.org Fix JS config script 2020-01-22 tvanderlippe@chromium.org Generate proper tsbuildinfo and copy output files 2020-01-22 tvanderlippe@chromium.org Migrate heap_snapshot_worker/ to ESM internally 2020-01-22 tvanderlippe@chromium.org Remove whitespace at the end of the package.json lines 2020-01-22 aerotwist@chromium.org Migrates text_utils to ESM internally 2020-01-22 tvanderlippe@chromium.org Reland "Migrate accessibility/ to ESM internally" Created with: gclient setdep -r src/third_party/devtools-frontend/src@2e45f00d3687 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibbc9efc3952f919bd4699acd1105a70896e25db1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015003Reviewed-by:
-
Mason Freed authored
Prior to this CL, out of range floating point numbers gave a confusing error message with details about the regex being used: The specified value "1.79E+309" is not a valid number. The value must match to the following regular expression: -?(\d+|\d+\.\d+|\.\d+)([eE][-+]?\d+)? Now they just give this error: The specified value "1.79E+309" cannot be parsed, or is out of range. Fixed: 785972 Change-Id: I7eaa56d170317d7387c0a096956a96d0f68099d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010064 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#734085}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6ce033a863ac..ede69c0fbe58 git log 6ce033a863ac..ede69c0fbe58 --date=short --first-parent --format='%ad %ae %s' 2020-01-22 hbos@webrtc.org [Overuse] Setting the target bitrate through the interface. 2020-01-22 titovartem@google.com Propagate multicodec support to other places of PC level framework 2020-01-22 ilnik@webrtc.org Fix video_replay to build and actually work 2020-01-22 minyue@webrtc.org Add absolute capture time to video sender path. 2020-01-22 peah@webrtc.org Reduce the complexity of the multichannel echo subtractor test Created with: gclient setdep -r src/third_party/webrtc@ede69c0fbe58 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I607319caafff507fec03be00ea3cdde652a06827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015004Reviewed-by:
-
Gabriel Marin authored
BUG=1043700 Change-Id: Ia0eb308bb4f171eaa32e5950d7345b81a7cc5ef0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012839 Commit-Queue: Gabriel Marin <gmx@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#734083}
-
Scott Graham authored
This was showing up as a -Wconversion error on gcc, when used via saturated_cast<int16_t>(...). Change-Id: Ie643478c1678387ddc4b0386998c77bd74d92700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008277Reviewed-by:
Justin Schuh <jschuh@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#734082}
-
Dave Tapuska authored
This error description was largely unused (except for the Android PolicyAuditor) and the computation of it generates a localized string based on the user's locale. If we move the error description we can move the call of the API entirely into blink. BUG=1043768 Change-Id: I39c3e336ed212fc7c172761e01dba3fb8e365f17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011280Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#734081}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/b766e5e7fbf4..8fff8c3b7dc8 git log b766e5e7fbf4..8fff8c3b7dc8 --date=short --first-parent --format='%ad %ae %s' 2020-01-22 capn@google.com Don't use VK_TRUE comparisons Created with: gclient setdep -r src/third_party/swiftshader@8fff8c3b7dc8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I4581fee781df386a7d16646ceb9bda6575e61fe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014678Reviewed-by:
-
Robert Liao authored
BUG=177450 Change-Id: I91fd7a22a58e1c9dc43bcfe279192e25dc9a5eff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968153 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#734079}
-
Stephen Nusko authored
This reverts commit f0f19cb1. Reason for revert: pinpoint was unable to find cause of increased flakiness. Original change's description: > Disable rendering.mobile/canvas_animation_no_clear on android nexus 5x. > > NOTRY=true > TBR=crouleau@chromium.org > CC=sadrul@chromium.org,vmiura@chromium.org > BUG=1039344 > > Change-Id: Ib4d1567010f972ad1d58305f2d17d0430e45039f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985677 > Reviewed-by: Stephen Nusko <nuskos@chromium.org> > Commit-Queue: Stephen Nusko <nuskos@chromium.org> > Auto-Submit: Stephen Nusko <nuskos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#728567} TBR=crouleau@chromium.org,nuskos@chromium.org NOTRY=true CC=sadrul@chromium.org,vmiura@chromium.org Bug: 1039344 Change-Id: I6a215825a773b4a43b599b773c84709a9e58e09d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015102Reviewed-by:
-
Sebastien Lalancette authored
This reverts commit 4ccbed03. Reason for revert: Introduced a regression (test failing) Bug: 1044650 Original change's description: > Fix selected state when focused for ARIA gridcell and treeitem > > Before this change, focused gridcell were perceived as selected by ATs. > This is because we assumed that a focused gridcell was also selected, > but that can't be the case. > Gridcells are mentioned here, but all ARIA grid roles and treeitem were > affected by this misinterpretation of the specs. > > According to ARIA 1.0 and above, all ARIA grid cells, rows and columns > are selectable, but not necessarily selected. We can't assume a > relationship between the focused state and the selected state as they > are completely independent. We can only do so when the aria-selected > attribute is implied or required. To the best of my knowledge, it only > is implied and/or required for: > - ax::mojom::Role::kListBoxOption: > - ax::mojom::Role::kMenuListOption: > - ax::mojom::Role::kTab: > > This CL introduces AXLayoutObject::SelectionShouldFollowFocus(). > This method was implemented following the ARIA specs, so that only the > elements with an implied and/or required aria-selected attribute value > are also marked as selected when focused. > > Bug: 1030378 > Change-Id: I5875cf3f6198aeea73100806d365bb73f7a6c389 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996138 > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> > Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com> > Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#734001} TBR=aleventhal@chromium.org,kschmi@microsoft.com,benjamin.beaudry@microsoft.com Change-Id: I5728dba84f6faa4d8503a5aa867f5ca067ff0ae5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1030378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014175Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#734077}
-
weiliangc authored
This reverts commit 064c1945. Reason for revert: crbug.com/1044380 Original change's description: > viz: OverlayProcessor Sends Candidate Directly for Android Pre-SC > > For Andorid Pre-SurfaceControl, overlay processor can send the > overlay candidates directly. > > This is CL 6/? for sending the overlay candidates directly to gpu thread. > > R=rjkroege > > Bug: 979788 > Change-Id: I76d97e8c8cfece078f6ea8d90bf8d3e7ae02dbfc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985305 > Commit-Queue: weiliangc <weiliangc@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Cr-Commit-Position: refs/heads/master@{#733619} TBR=rjkroege@chromium.org,weiliangc@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 979788 Change-Id: I9cc2033bf6145b5d0b59e0680b7265403927b913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013811Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#734076}
-
Omer Katz authored
Blink concurrent marking tsan bot currently times-out on some tests. Copying relevant exceptions from bot "Linux TSan Tests" to make sure the bot has enough resources to finish the tests. Bug: 986235 Change-Id: Id805c02f0b8bd0786194d9115b78269673e26bc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013054 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#734075}
-
Mason Freed authored
The [1] CL enabled the FormControlsRefresh feature by default for Windows, Linux, and ChromeOS. In the process, many layout tests were disabled, because the form controls have a different appearance with the feature enabled. This is one of several patches rebaselining those disabled tests. SHERIFFS: If one of the tests touched in this CL becomes/is flaky, *please* add it to TestExpectations beneath the section for bug 1035582, and mark it with a *new* bug number. At this point, any further failing tests are flaky on their own, not because of this rebaseline. Thanks! [1] http://crrev.com/c/1967608 Bug: 1035582 Change-Id: Icf39d2aca9cf8c3d12c3f4e0709e3601ef30a014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008353 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#734074}
-
Mohammad Refaat authored
Use SessionRestorationAgent to restore the session directly using the browser instead of calling it through tabModel. Bug: 1010164, 783777 Change-Id: Ib1dd37941eccd3e85d0c6c72c2d463ea2cfc69f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007519Reviewed-by:
-
Oleh Lamzin authored
Introduce wilco_dtc NetworkContext to be able to continue establish TLS connection when server ask client authentication certificate. Bug: b:144545936 TEST=browser tests TEST=verified manually on the device that we are able to setup connection and receive response from the server Change-Id: I039c683fed6859641ea42a1bb79536a7629419de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1964071 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:Pavol Marko <pmarko@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#734072}
-
Alexei Svitkine authored
Bug: 1037118 Change-Id: If86843e59b7880878e39eda8d39aad72208f577e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003399Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
Ben Wagner authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/50b013871c53..e5038be70414 $ git log 50b013871..e5038be70 --date=short --no-merges --format='%ad %ae %s' 2020-01-19 wl Update all copyright notices. 2020-01-04 wl [base] Fix `FREETYPE_PROPERTIES=type1:hinting-engine=adobe`. Created with: roll-dep src/third_party/freetype/src R=bungeman@chromium.org,drott@chromium.org CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng Change-Id: Id71ab1c45b05cb211948381805f3fe2a491845d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014054 Commit-Queue: Ben Wagner <bungeman@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#734070}
-
