- 10 Sep, 2018 40 commits
-
-
Dominic Battre authored
This test crashes with a check on Linux. On Linux CFI it crashes very frequently. FATAL:render_frame_metadata_provider_impl.cc(41)] Check failed: render_frame_metadata_observer_ptr_. TBR=khushalsagar@chromium.org Bug: 880948 Change-Id: Ie2a536e1a72f9fb00f5f1515b1683b87e87d807e Reviewed-on: https://chromium-review.googlesource.com/1215286Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#589870}
-
Marc Treib authored
On a configuration failure, PSS is temporarily in an inconsistent state until the error is processed (by calling OnUnrecoverableErrorImpl). If we call an observer during that time, and the observer calls PSS::GetTransportState, then that could trigger a DCHECK. It's arguable whether calling OnSyncConfigurationCompleted on an error even makes sense. It looks like none of the clients can do anything useful in that case anyway. So let's just not call them. If they're interested in the error, then they should listen for OnStateChanged instead. Bug: 880080 Change-Id: If4179cd530f3e625bd53de466c059e051b36f42d Reviewed-on: https://chromium-review.googlesource.com/1210083Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#589869}
-
Daniel Bratell authored
There are more than one namespace named features, and specifically there are both ::printing::features and ::features. When the compiler knows about both and is inside namespace printing, referring to "features" will resolve to ::printing::features even if ::features was intended. This happens in jumbo builds in some configurations. The fix is to clarify what features namespace is intended by using a :: prefix. An alternative fix would be to remove ::printing::features to ::printing::printing_features. Change-Id: I0499ed98c3ad699e89dce8f1141c327937ba0a87 Reviewed-on: https://chromium-review.googlesource.com/1213167Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#589868}
-
Yutaka Hirano authored
It is flaky. Bug: 869758 Change-Id: Ic9c29ced0103a11ae284b10d49466fa317c605b2 Tbr: kenrb@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1215508 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#589867}
-
Yannic Bonenberger authored
Bug: 755477 Change-Id: I59ca20a9d958a2bcad929b9a83b1ab9053ee8d42 Reviewed-on: https://chromium-review.googlesource.com/1212062Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Yannic Bonenberger <contact@yannic-bonenberger.com> Cr-Commit-Position: refs/heads/master@{#589866}
-
Mohamed Amir Yosef authored
The directory implementation is different because directory keeps a copy of the server data and then compares it to the newly version. For USS, no copy is maintained and hence we have to create specifics and push to the server when there is a local update. Bug: 516866 Change-Id: Ic0a43b210866120c8ec209681e719d634fa10255 Reviewed-on: https://chromium-review.googlesource.com/1206410Reviewed-by:
-
Dominic Battre authored
It may make sense to increase the number of shards instead but I am not sufficiently knowledgable of capacity planning to do this change. The reason for increasing the timeout is that this bot times out consistently. TBR=rcui@chromium.org,sky@chromium.org Bug: 874090 BUG: 847585 Change-Id: I14f9d2eccbead7ef403e346deda5442a82d5ea27 Reviewed-on: https://chromium-review.googlesource.com/1215283Reviewed-by:
-
Daniel Bratell authored
Some test code was compiled into chrome which in jumbo builds broke the linking. In non-jumbo builds the code was probably eliminated by the implicit dead-code-removal in the linker (an .o file that is completely unused is ignored). Also changing an #include "foo.cpp" to #include "foo.h" since that caused similar linking errors related to duplicate code. Change-Id: I6c39314fadc3a82f48135755cc7de1a540006ae5 Reviewed-on: https://chromium-review.googlesource.com/1213166Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#589863}
-
Dominic Battre authored
Disabling this test as it regularly (~50% of times) times out on Linux and Windows. The test is fine on MacOS. TBR=rdevlin.cronin@chromium.org Bug: 882342 Change-Id: I23dd794332f57cbbd46ba167efc562041f7e9dff Reviewed-on: https://chromium-review.googlesource.com/1215284Reviewed-by:
-
David Jean authored
When opening: https://drive.google.com/file/d/1z4iyQgQOL9jUFNfIf9Qg1SmFz9INxN88/view?usp=sharing When searching: https://drive.google.com/file/d/1wdMrOC9GDzh7e97HY-1ObHergJH0rnoC/view?usp=sharing In action: https://drive.google.com/file/d/14NMZ4mkCUZM8QNyopWHQ6MyDX939bcni/view?usp=sharing Bug: 879570 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I51f88361a79703c55f03e2befb745ca3701ce577 Reviewed-on: https://chromium-review.googlesource.com/1193932 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#589861}
-
Erik Luo authored
Bug: none Change-Id: Ic24e0f08fa6d55461d7bdd50d6164b00e47ab950 Reviewed-on: https://chromium-review.googlesource.com/1200402 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#589860}
-
Sergio Villar Senin authored
It's currently using URLFetcher. It should use SimpleURLLoader instead to make it eventually work with the network service. Bug: 872876 Change-Id: I1b0a0b3fcab7f96ca576d8dae47c62f7218a31e2 Reviewed-on: https://chromium-review.googlesource.com/1203955Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#589859}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/038f252b7691..c55b114a75a0 git log 038f252b7691..c55b114a75a0 --date=short --no-merges --format='%ad %ae %s' 2018-09-10 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 1cee042197da..a735ee2f6df8 (1 commits) Created with: gclient setdep -r src/third_party/skia@c55b114a75a0 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: I14908a0bb00355089415b93e9178afc7940942f2 Reviewed-on: https://chromium-review.googlesource.com/1215086Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589858}
-
Dominic Battre authored
This test fails at least once in 95% of all try runs. It is the most flaky on Linux builders. TBR=shuchen@chromium.org,azurewei@chromium.org Bug: 882338 Change-Id: Ie7ca412494b5f4e89c28f58e8786b07615cda1e1 Reviewed-on: https://chromium-review.googlesource.com/1215025Reviewed-by:
-
Kunihiko Sakamoto authored
Now dump-signedexchange supports the b2 format, so let's use it. Bug: 803774 Change-Id: Ie0f1040f2c6428a4ada41095f1226f8ed8e12c99 Reviewed-on: https://chromium-review.googlesource.com/1215522 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#589856}
-
Darren Shen authored
In UpdateInsetsForWindow, we assume that a window can only have one RenderWidgetHostView. However, it looks like for the hangouts app, the window has multiple RenderWidgetHostViews, all of which need to be updated. Test: Manual Bug: 764211 Change-Id: I1c9b60e4c1f9a05a0c9e0c6683c72781115ee925 Reviewed-on: https://chromium-review.googlesource.com/1215424Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#589855}
-
Leo Zhang authored
Remove unused keyboard flag kEnableExperimentalInputViewFeatures which is faulty now. Bug: 880659 Change-Id: Ia4bb8ec3cfd4f38393fe9e6f270563fc7c313245 Reviewed-on: https://chromium-review.googlesource.com/1212427Reviewed-by:
-
Gauthier Ambard authored
I am adding myself as owner for BVC. Commits: crrev.com/c/1131511 crrev.com/c/1131191 crrev.com/c/1127031 crrev.com/c/1078734 crrev.com/c/1030393 Bug: none Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I3b721dc4476a8cd37ac737adad0f19711c5040fc Reviewed-on: https://chromium-review.googlesource.com/1199802Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#589853}
-
Raymes Khoury authored
The old NTP should show a permission prompt when the first voice search happens. However when permission delegation was enabled it caused the wrong origin to be used for the request: chrome://newtab instead of the search origin (e.g. google.com). This CL fixes the origin so that the search origin is again used for the request. This bug does not impact the new NTP. Bug: 881742 Change-Id: Ic70c39d2adb2efafbea3f5c8b89d462c9f01352c Reviewed-on: https://chromium-review.googlesource.com/1214976Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#589852}
-
Kenichi Ishibashi authored
This is a follow-up CL of crrev.com/c/1212423 and fixes timing ordering of PerformanceNavigationTiming attributes. Background: `fetchStart` of PerformanceNavigationTiming comes from |fetch_start| of NavigationTiming, which is set by NavigationRequest. Since NavigationRequest isn't aware of service worker interception `fetchStart` could come earlier than `workerStart` when the navigation is routed to a service worker. However, `fetchStart` is supposed to come after `workerStart`. We can address this mis-ordering by using worker ready time. When worker ready time is greater than |fetch_start| of NavigationTiming, use worker ready time as |fetch_start|. Justifications: - `fetchStart` is should be recorded after redirects end. - `fetchStart` is should be recorded after `workerStart` if a service worker intercepted the navigation. - There seems no particular ordering between `redirectEnd` and `workerStart`. - NavigationRequest already updates |fetch_start| for redirects. Bug: 782958 Change-Id: I90bdeaee73d361c9d35024f13fd0d3f91ba42b02 Reviewed-on: https://chromium-review.googlesource.com/1215426Reviewed-by:
-
Jia Meng authored
This reverts commit ea692f36. Reason for revert: broke the linux-chromeos-dbg (https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/7744) Original change's description: > [On-device adaptive brightness] Implement an AlsReader to ambient light. > > > Bug: 881215 > Change-Id: I1cd5bf7ea517e426b54df1f4ebbb5a843b991dbe > Reviewed-on: https://chromium-review.googlesource.com/1209000 > Reviewed-by: Michael Martis <martis@chromium.org> > Reviewed-by: Dan Erat <derat@chromium.org> > Commit-Queue: Jia Meng <jiameng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589843} TBR=derat@chromium.org,jiameng@chromium.org,martis@chromium.org Change-Id: Id12029b7d3b46eaed672525fe0bcf96960ea143c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 881215 Reviewed-on: https://chromium-review.googlesource.com/1215603Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#589850}
-
Trent Apted authored
ImageLoaderClient::tasks_ is effectively unused since r316185. All it does now is cause a big JS memory leak whenever a thumbnail is loaded. This obsoletes ThumbnailLoader.OptimizationMode. Only the Gallery app's "ribbon" uses this, and it just passed the default arg. It is the only caller of ThumbnailLoader.load(), so there's no need to have any optional arguments. Bug: 881680 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ic1e9a7affee8e81ed3ba4b235b956dd2c3c71d13 Reviewed-on: https://chromium-review.googlesource.com/1214966Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#589849}
-
Wei Li authored
Usually, user exits tab fullscreen mode by clicking 'ESC' button as suggested by exit bubble on Mac. However, during tab fullscreen user can still click the green traffic light button from the slide-down system menu to exit fullscreen. In this case, the toolbar style has to be updated as well. This CL fixes this by calling UpdateFullscreenTopUI() from BrowserNonClientFrameViewMac::OnFullscreenStateChanged() where all the transitions from fullscreen to non-fullscreen mode would pass through. BUG=879158 Change-Id: I089fa90a260d16681b84eada5759c4e7c60a4f6f Reviewed-on: https://chromium-review.googlesource.com/1213319Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#589848}
-
Alex Lau authored
This adds a fake local ARC volume for testing. Initial integration tests added check that 1) the "Toggle Play Folders" button work in hiding and showing the non-default Android files and folders. 2) the "Toggle Play Folders" button is shown inside Play Files but hidden from the "Recents" pane. Bug: 877371 Test: Tested on Chromium build. Change-Id: Ic35de5ebb06f901ad229c9b35f1917ac9353a459 Reviewed-on: https://chromium-review.googlesource.com/1201637 Commit-Queue: Alex Lau <alexlau@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#589847}
-
Luciano Pacheco authored
Metadata model provides an "update" event which is triggered anytime a metadata item has been updated from the backend. Any UI part that to display latest metadata should listen to it and update the UI accordingly. Change the directory tree to listen to Metadata "update" event to update the "shared" icon. A listener is added for every expanded folder to listen to updates for its sub-folders. When a folder is collapsed its listener is removed. Change |onExpand_| function to fetch all metadata values from |LIST_CONTAINER_METADATA_PREFETCH_PROPERTY_NAMES|, instead of |DIRECTORY_TREE_METADATA_PREFETCH_PROPERTY_NAMES|. Directory tree needs the metadata "can*" to setup permission accordingly in the context menu. This is only fetched for Drive roots, since only Drive implements these metadata. Change |updateSharedStatusIcon| function to use the cached metadata value. This fixes the issue where it would trigger metadata requests to backend too early, because this |updateSharedStatusIcon| is called from SubDirectoryItem constructor. Remove Metadata cache invalidation calls (notifyEntriesChanged and notifyEntriesRemoved) because directory tree doesn't update metadata directly. Fix MockVolumeManager to work with other volumes other than Drive, by extracting the VolumeManager implementation to detect RootType to a common function |getRootTypeFromVolumeType|. Remove constant |DIRECTORY_TREE_METADATA_PREFETCH_PROPERTY_NAMES| since its use has been removed in directory_tree.js. Add MetadataModel |removeEventListener| to be able to remove listener of MetadataModel "update" event. manual tests for Drive "shared" icon. New integration tests for "shared" icon will be added in follow up CL. Bug: 880187, 880189 Test: Unittest for |insideMyDrive| and |insideDrive| functions and Change-Id: Ibe8320e7b0981d8e9556ebb8a922d7db2f16860c Reviewed-on: https://chromium-review.googlesource.com/1203596 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Patrik Höglund authored
The idea is to duplicate the config for chromium.webrtc.fyi everywhere so I can safely experiment with my new test suites and make sure the config is in the right place. Bug: 877018 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I96b62965369a28b0984ec8aa8464899c89ce875c Reviewed-on: https://chromium-review.googlesource.com/1201857Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#589845}
-
Niels Möller authored
They've been moved from CodecSpecificInfo to EncodedImage. Bug: webrtc:9378 Change-Id: I291e2853e8dfeb672c286d2aab0e347f4ce176bd Reviewed-on: https://chromium-review.googlesource.com/1213163Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Niels Möller <nisse@chromium.org> Cr-Commit-Position: refs/heads/master@{#589844}
-
Jia authored
Bug: 881215 Change-Id: I1cd5bf7ea517e426b54df1f4ebbb5a843b991dbe Reviewed-on: https://chromium-review.googlesource.com/1209000Reviewed-by:
Michael Martis <martis@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#589843}
-
Stuart Langley authored
As per the attached bug, replace usage of Replace (bool, const std::string&) in filesystem_api_util.cc with base::Optional<std::string> for code health. Also, change from RepeatingCallback to OnceCallback for all filesystem_api_util defined methods. Also, fix linter warnings. There are no logic changes. Bug: 729442, 875700 Change-Id: Ib27634b9ba1372cb007ba6a190608ec4128bbeb3 Reviewed-on: https://chromium-review.googlesource.com/1215425Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
-
Maksim Sisov authored
This fixes the following error: wl::Object<wl_buffer> wl_buffer; ^~~~~~~~~ In file included from ../../ui/ozone/platform/wayland/wayland_buffer_manager.h:18:0, from ../../ui/ozone/platform/wayland/wayland_buffer_manager.cc:5: ../../ui/ozone/platform/wayland/wayland_object.h:12:8: error: changes meaning of 'wl_buffer' from 'struct wl_buffer' [-fpermissive] struct wl_buffer; ^~~~~~~~~ TBR=rjkroege@chromium.org Change-Id: I326abd95fec4d26a4d0497e5570ae4e9f0637afb Reviewed-on: https://chromium-review.googlesource.com/1213179 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#589841}
-
Trent Apted authored
This is used for unit tests in ui/file_manager, but it is neat and other targets should use it too. It's now pretty stable. It reduces boilerplate in BUILD.gn files and allows foo_unittest.html files to be automatically generated from build dependencies, rather than being handcrafted. js_unit_test.py currently lacks the performance optimization added for js_binary in r581961 to cache dependency subtrees, so it's a bit slow. Upstreaming allows the two python scripts to share the dependency walker in a sane manner. Bug: 860355 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Iedddd39907137dd40ec21f507cb560756251c8b1 Reviewed-on: https://chromium-review.googlesource.com/1212364 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
-
Hiroki Nakagawa authored
This CL adds the Save-Data header to browser-initiated requests for shared worker's main script. This has been tested by LayoutTests, but it's no longer available after NetworkService is enabled because LayoutTest's internal API to enable the data saver feature doesn't take effect on the preferences in the browser process. Therefore, this CL adds browser tests instead. Design doc of the PlzWorker: https://docs.google.com/document/d/1Jtn33bvqkqWxq6K7HIA4uU6HLWPTmOD7vFviacfTmhM/edit?usp=sharing Bug: 715632 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I1390205530742dba73057f6a866af8db158afe54 Reviewed-on: https://chromium-review.googlesource.com/1209004Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
-
Maksim Sisov authored
The memory header was missing from this header. Adding it here. Change-Id: Ic52dc3a194fabb50dd6758e6b1af693358b408cc Reviewed-on: https://chromium-review.googlesource.com/1213247 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#589838}
-
Ramin Halavati authored
The following preferences are removed from the persistent storage list for incognito mode. - kAutoplayAllowed, - kAutoplayWhitelist, - kDeviceOpenNetworkConfiguration, - kDownloadDefaultDirectory, - kDownloadDirUpgraded, - kDownloadExtensionsToOpen, - kDSEGeolocationSettingDeprecated, - kDSEPermissionsSettings, - kDSEWasDisabledByPolicy - kEnabledLabsExperiments - kIncompatibleApplications, - kIsolateOrigins, - kLocalConsentsDictionary - kModuleBlacklistCacheMD5Digest, - kObservedSessionTime, - kOpenNetworkConfiguration, - kProblematicPrograms, - kSitePerProcess, - kThirdPartyBlockingEnabled, - kUnsafelyTreatInsecureOriginAsSecure - kWebDriverOverridesIncompatiblePolicies - kWebShareVisitedTargets These preferences are either never changed from incognito mode, or the changed value is not supposed to be written to user profile. Bug: 861722 Change-Id: I67fdb205175d9656ef07fd3039a2496e74968ceb Reviewed-on: https://chromium-review.googlesource.com/1196384 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#589837}
-
Hayato Ito authored
Remove several TraversalXXXIterator, such as TraversalAncestorIterator, TraversalChildrenIterator, in favor of reusing TraversalIterator with TraversalXXX wrapper, such as TraversalParent or TraversalSibling. This CL also introduces several short names for some common traversal patterns, such as: TraversalAncestorRange = TraversalRange<TraversalIterator<TraversalParent<T>>>, for better ergonomics. No behavior change. Bug: 880052 Change-Id: I0ccf2a0de672932cff2df38591b8376df9d52175 Reviewed-on: https://chromium-review.googlesource.com/1205924 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#589836}
-
Leo Zhang authored
The feature was previously created under the IME service, I refactored it by moving it to ChromeOS features for a simple structure and passing it to the IME extension. This feature is used for switching whether the IME component extension is able to connect to IME service. Bug: 837156,880245 Change-Id: I832b60e1bcc90708771a935dc9f3172067eb8544 Reviewed-on: https://chromium-review.googlesource.com/1209131Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#589835}
-
Satoshi Niwa authored
mojo CL : 1164875 ARC CL : ag/4895169 BUG=b:111816608 TEST=manually tested with caroline Change-Id: I0fbcf66c91f3035fcd973d03a4ee63400a096ad8 Reviewed-on: https://chromium-review.googlesource.com/1203710Reviewed-by:
Shuhei Takahashi <nya@chromium.org> Reviewed-by:
-
Han Leon authored
This CL is the reland of https://chromium-review.googlesource.com/c/chromium/src/+/816085, which got reverted because it caused time out on service worker threads when transferring scripts. Now we found out the root cause: |ThreadSafeScriptContainer::waiting_url_| is a KURL, since it's supposed to be accessed on both the IO thread and the service worker thread, we must make a deep copy of KURL when assigning value to it, which was being missed by the original CL. This CL: - removes the unnecessary abstract layer WebServiceWorkerInstalledScriptsManager.h between Content and Blink. - merges web_service_worker_installed_scripts_manager_impl.{cc,h} out of content/renderer into blink/renderer/modules/service_worker/. - merges thread_safe_script_container.{cc,h} out of content/renderer into blink/renderer/modules/service_worker/. - revises related test codes. BUG=792778 Change-Id: I5225d1e1414a5e3859c9c108a86fe5f7447e8987 Reviewed-on: https://chromium-review.googlesource.com/1208903Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Yutaka Hirano authored
The test is flaky because speculative preloads start, and in some cases finish loading before disabling console message. Let's use testharness.js in order to ignore console messages. Bug: 882292 Change-Id: Ic6627f0bb941e7299ac611c2fd10e6469e1ed5e9 Reviewed-on: https://chromium-review.googlesource.com/1214978Reviewed-by:
-
Eriko Kurimoto authored
Each types of log (speech, event ...) can be filtered from URL params. To enable users to change URL easily, LogPage is now on tab, not panel. Bug: 879042 Test: None Change-Id: I64b80f828707f60df23afab6f57c68135199c57c Reviewed-on: https://chromium-review.googlesource.com/1195407 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#589831}
-
