- 06 Mar, 2020 40 commits
-
-
Aga Wronska authored
Add new method that returns current time limit for the app. Rename interface to reflect that it does not only apply to web time limits. AppService needs the information about current time limit to display the paused dialog when user clicks paused app's icon. AppService is already using the interface to communicate with AppTime component. Bug: 1056466 Test: AppActvitiyRegistryTest Change-Id: I4c663387a26d256f3c66b9ae5efaecc2f25b1725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086264Reviewed-by:
Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#747533}
-
Chong Gu authored
Bug: 1058255 Change-Id: Ic42f11923c0426d62e7274d908dd8e872dce154d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090627Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#747532}
-
Marijn Kruisselbrink authored
Also enabled the new permission model by default, as that is what we want to ship in M82. Bug: 984769 Change-Id: Iaa73376cdf893a2bb7c7f3e42336f8a2675c3609 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090600Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#747531}
-
Scott Violet authored
This makes block flow's line-clamp handling correctly add ellipsis when if clamping happens on a line where are the text fits, but there are subsequent lines. Common case for this is when using 'white-space:pre'. This does not give the exact same behavior as old. In particular, external/wpt/css/css-overflow/webkit-line-clamp-008.html is an example of a case that now renders differently (nested divs). See https://test-results.appspot.com/data/layout_results/mac-rel/302753/webkit_layout_tests%20%28with%20patch%29/layout-test-results/results.html for the set of failures. BUG=none Change-Id: Ie188d5b3efc1817377f7ba5523815ba6bdc4a986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050093 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#747530}
-
Jason Lin authored
Bug: 1055647 Change-Id: I7a7f197b18979bfd885a79c2fc2f96c665b8d6f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089188 Auto-Submit: Jason Lin <lxj@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#747529}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/56f1678437ba..1d54767364a8 git log 56f1678437ba..1d54767364a8 --date=short --first-parent --format='%ad %ae %s' 2020-03-05 natlee@microsoft.com Query if Texture subresource has been initialized Created with: gclient setdep -r src/third_party/dawn@1d54767364a8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1036080 Tbr: cwallez@google.com Change-Id: I8b7fbf64e6730ff6f1b751f030e336319ecbfc2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090634Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747528}
-
Behnood Momenzadeh authored
Bug: 1037049 Change-Id: I51bcdd26a6f5551a661f0c974c48b1f44709c009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090721 Auto-Submit: Behnood Momenzadeh <behnoodm@google.com> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Commit-Queue: Behnood Momenzadeh <behnoodm@google.com> Cr-Commit-Position: refs/heads/master@{#747527}
-
Josh Simmons authored
Treat video files on DriveFS as if they were local when launching Quick View. This results in auto-play (where the media is decodable). DriveFS streams large files so if the user cancels / pauses the playback there will not be unnecessary data transferred. Bug: 1059072 Test: browser_tests --gtest_filter="openQuickViewVideoOnDrive" Change-Id: I0bd6020acdaad8980c7fcf6f48891389d20e8a27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089439Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Josh Simmons <simmonsjosh@google.com> Cr-Commit-Position: refs/heads/master@{#747526}
-
Victor Hugo Vianna Silva authored
The feature has been successfully launched, so this CL removes it and cleans up HistoryUiFaviconRequestHandler. In particular, it: eliminates plumbing that was needed for feature experimentation; removes unit tests checking the influence of "field trial parameters" of the feature; updates the class documentation to remove mentions to the feature. Sync code is still exercised if user settings do not allow querying the favicon server, as before. Bug: 978775 Change-Id: Ibf474014f0f0a845c150c5ad64d2f13c72782493 Fixed: 978775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085374 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#747525}
-
yilkal authored
This CL corrrects the blocking page ui for websites for web time limit. This CL also corrects an error in web_time_limit_navigation_throttle.cc where a nullptr browser is being dereferenced. Bug: 1056480 Change-Id: I5b8b0ce29718015d26cb983e865c3d08238d0d56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079857 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#747524}
-
Jun Cai authored
This CL converts base::Bind and base::Callback in //ppapi/tests to Once or Repeating Bug: 1007818 Change-Id: I0613c200a4e5a7fe397bdf9d49193c7d2ea45066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083382Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#747523}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/55228e53750d..9acaf6626042 git log 55228e53750d..9acaf6626042 --date=short --first-parent --format='%ad %ae %s' 2020-03-05 jmadill@chromium.org Add timer query support to TracePerfTests. Created with: gclient setdep -r src/third_party/angle@9acaf6626042 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ianelliott@google.com Change-Id: I1baccdcd91af2877a27e5e927799182bbbcf9b06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090638Reviewed-by:
-
Mike Wittman authored
Adds an interface to allow unwinders to update the modules they're responsible for in the ModuleCache at each sample, prior to unwinding. To be used by the V8 unwinder after updating to the new V8 async unwinding API, to update its current set of modules after they are recorded in OnStackCapture(). Bug: 1035855 Change-Id: If6fb08fb91323d748facab0557e02a8f2a971c5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086297 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#747521}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/456f9b5fe9d2..8c1ae63310cb git log 456f9b5fe9d2..8c1ae63310cb --date=short --first-parent --format='%ad %ae %s' 2020-03-05 reed@google.com simplify SkDraw by passing down SkVertices as a whole 2020-03-05 mtklein@google.com re-enable fnma 2020-03-05 reed@google.com remove bone variant of drawVertices (unsupported) 2020-03-05 mtklein@google.com disable fnma peephole 2020-03-05 mtklein@google.com print colors which fail the asserts when they do 2020-03-05 csmartdalton@google.com Change the argument ordering for GrOpsRenderPass::bindTextures Created with: gclient setdep -r src/third_party/skia@8c1ae63310cb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: herb@google.com Change-Id: Id187271d35332f6bca92b914ae2a6005df6f61f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090636Reviewed-by:
-
Ted Choc authored
Mark MobileStartup.ColdStartupIntent obsolete. Extend MobileStartup.DailyLaunchCount and MobileStartup.LaunchType. LaunchType is being used for analysis right now, and DailyLaunchCount is a good durable proxy for whether we're seeing additional engagement. BUG=1055427,1053055 Change-Id: I8ac1d0851f490c1b0b06ce9255f87b560410f8de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087425 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#747519}
-
Clark DuVall authored
This file was added in http://crrev.com/c/2083714. This fixes the tools/translation/upload_screenshots.py tool. Bug: 1025609 Change-Id: I5c70e17ecc0e264b56f965108063efaa8316ee1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090712 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#747518}
-
Torne (Richard Coles) authored
Change how extra headers provided through loadUrl(url, extra_headers) are handled in WebView: 1) Remove any extra headers from the request if the request is redirected to a different origin, since they might be sensitive. 2) Don't attempt to add any extra headers for the redirect target URL when we encounter a redirect; this is likely to be surprising and unwanted. 3) Record metrics on when we add headers and what was done with them on redirect. 4) Add an additional test verifying that the extra headers are cleared if the app loads the same URL again via loadUrl(url). Bug: 1038002 Change-Id: Ib39e2938f7b76d212cd20773aab56da138088b63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999229Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#747517}
-
Brandon Tolsch authored
This reverts commit c401a7d6. Reason for revert: Added test fails on Mac 10.12 and 10.14 Original change's description: > [tbmv3] Add an integration test for run_tbmv3_metric > > Adding a simple smoke test to make sure run_tbmv3_metric does not break > silently. > > Change-Id: I54f4d525e221eef403678034efde505ee19cbc1e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078736 > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Reviewed-by: Deep Roy <dproy@chromium.org> > Reviewed-by: Mikhail Khokhlov <khokhlov@google.com> > Commit-Queue: Deep Roy <dproy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#747385} Bug: 1059109 TBR=crouleau@chromium.org,dproy@chromium.org,khokhlov@google.com Change-Id: I390c1e121e7dc26cb7d9b16af89c772afc0b623a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090361Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#747516}
-
Bailey Berro authored
This reverts commit 64d0d296. Reason for revert: crbug.com/1058503 Original change's description: > Add GetPlaneSurface to ui::GbmBuffer > > There is currently a GetSurface() api but it only gives > access to the plane 0. > > This new api GetPlaneSurface allows to get access to any > planes to support YUV formats. > > Bug: 1043007 > Test: ./out/ozone_build/ozone_unittests > Change-Id: I4116affcf168cdaeebf3b405234aa3e5f55cc30f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032060 > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> > Reviewed-by: Maksim Sisov <msisov@igalia.com> > Commit-Queue: Julien Isorce <julien.isorce@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740986} TBR=spang@chromium.org,dnicoara@chromium.org,thomasanderson@chromium.org,msisov@igalia.com,julien.isorce@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1043007 Change-Id: I014bf490affe19c4ce464cd866276cf287712c78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090358Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#747515}
-
George Burgess IV authored
""" ../../media/gpu/test/local_gpu_memory_buffer_manager.cc:100:26: warning: comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'int' [-Wsign-compare] """ Bug: 1058218 Change-Id: I351035831db7884f6e1f64866205e885a95cdea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088332 Commit-Queue: George Burgess <gbiv@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#747514}
-
Josh Simmons authored
Treat audio files on DriveFS as if they were local when launching Quick View. This results in auto-play (where the media is decodable) and the display of album artwork in Quick View. DriveFS streams large files so if the user cancels / pauses the playback there will not be unnecessary data transferred. Bug: 877283 Test: browser_tests --gtest_filter="openQuickViewAudioOnDrive" Change-Id: I1eec7eadd0d021b1708798d92d7ed811929681fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090554Reviewed-by:
-
sauski authored
Previously the Recent Site Permissions display list update needed to be manually triggered (probably by it's parent). This CL extends the element to be a route observer so that it can re-trigger updates when appropriate. Updates are triggered when the route matching that set on the route-path attribute of the element is navigated to. Bug: 1032584 Change-Id: Id29191b6586c138e1e1191aaab218c5f7ff92a2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088643Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#747512}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/987ef4825826..45affde3a9c5 git log 987ef4825826..45affde3a9c5 --date=short --first-parent --format='%ad %ae %s' 2020-03-05 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2d9b6439..4ea51a0a (746902:747324) 2020-03-05 titovartem@google.com Add printout of supported codecs in PC test framework 2020-03-05 ilnik@webrtc.org Fix RtpReplayer so what vp9 fuzzer would work Created with: gclient setdep -r src/third_party/webrtc@45affde3a9c5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1030755 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I6cf6e1d38553778a87ed73013075e69a65e0aff0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090637Reviewed-by:
-
Piotr Bialecki authored
This reverts commit 2f69de56. Reason for revert: bisect identified this CL as the reason for crashes on Android - see bug https://crbug.com/1059000. Original change's description: > heap: Enable concurrent marking for HashTable based collections > > All known data races in HashTable based collections have been resolved. > > Bug: 986235 > Change-Id: Ia7a22d707aaaea1ab3ebc70c47da0876fc426aa9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078617 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Omer Katz <omerkatz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#746694} TBR=haraken@chromium.org,mlippautz@chromium.org,omerkatz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 986235 Change-Id: I6eabcf000bcb8092c33aaf5691decf58fe110c27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089965Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#747510}
-
Pavel Yatsuk authored
[Modularization] Extract InfoBarContainerLayout#Item into separate file in chrome/browser/ui/messages The interface needs to be accessible to infobar implementation because some info bars override its methods (e.g. getPriority) to affect InfoBarContainerLayout behavior. BUG=1056346 R=mdjones@chromium.org TBR=juncai@chromium.org,benwells@chromium.org Change-Id: I6e79f031fad0d48feafb30fb8ae6064702589789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082874Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Jun Cai <juncai@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#747509}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/99df04e8aa24..ee8be8a36862 git log 99df04e8aa24..ee8be8a36862 --date=short --first-parent --format='%ad %ae %s' 2020-03-05 qyearsley@chromium.org git-cl: Don't throw AttributeError in git cl upload --retry-failed Created with: gclient setdep -r src/third_party/depot_tools@ee8be8a36862 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1057745 Tbr: agable@chromium.org Change-Id: I1fe6e17713b3bf12bf39245154a05febb46a69a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090639Reviewed-by:
-
Shakti Sahu authored
This CL contains: 1 - Enabled reduced mode for native task 2 - Added metrics for reschedule, in order to investigate its importance. 3 - Added some documentation to README file 4 - Fixed missing OWNERS file Change-Id: Ia9df91b5f1d8960078f89a1c4504b4704a5187d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069439 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#747507}
-
Robert Ogden authored
Syncs the server-side changes for PrefetchProxy and plumbs it up to the //chrome level, following the same basic pattern as proxy headers. Bug: 1042829 Change-Id: I61355f70df0af557ef781da1262bec763bfbd70b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090310Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#747506}
-
Tomasz Tylenda authored
We still use this metric, so we extend the expiry date by one year. BUG=chromium:1053236 TEST=none Change-Id: I0ebf273a66440fc14f6f443473415370c3571f8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087878Reviewed-by:
Shao-Chuan Lee <shaochuan@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Shao-Chuan Lee <shaochuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#747505}
-
Brandon Tolsch authored
This reverts commit 9a1ab2ea. Reason for revert: 8.2.264 introduced target with missing build dep that leads to flaky compile failures, e.g.: https://ci.chromium.org/p/chromium/builders/ci/Android%20Release%20%28Nexus%205X%29/29415 Original change's description: > Update V8 to version 8.2.264. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/d4ed59c4..4b1eadeb > > Please follow these instructions for assigning/CC'ing issues: > https://v8.dev/docs/triage-issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel > > TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com > > Change-Id: Icb829fe71c85f797f309b804f0cb9afa7e9f66f5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089397 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#747256} TBR=hablich@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5ce3211ad28119cd154d34509a94f32551a4f5b3 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090874Reviewed-by:
-
Kent Tamura authored
Property aliases in css_properties_ranking.json5 were ignored while ComputedStyle generation. So, if an alias rank is higher than the rank of the corresponding real one, the generated field could be added to a deeper layer though the field is used frequently. This CL changes make_computed_style_base.py so that it takes into account of alias rankings. - Introduce _best_rank() to determine the best ranking value including aliases. - _evaluate_rare_non_inherited_group() and _evaluate_rare_inherit_group() use _best_rank() instead of properties_ranking[property_['name'].original] This change moves |backface_visibility_| to a shallower layer. This CL is a preparation to add 'appearance' property and make '-webkit-appearance' its alias. Bug: 963551 Change-Id: I120ee0aa250671ef8f86806ca653eb2cec63ba85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086468 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#747503}
-
Evan Stade authored
This API allows embedders to dismiss one active UI element, such as a dialog, fullscreen or a selection popup. Its intended use is to facilitate handling system back presses. The implementation aligns WebLayer Shell with Chrome behavior in that a back press will dismiss the active text selection popup rather than navigating. It also simplifies the shell's onBackPressed somewhat, and allows for future enhancements without involving the embedder. Bug: 1056468 Change-Id: I1124515f2d8498847f19439a8e24ad84b1087ce7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086323 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#747502}
-
Thomas Lukaszewicz authored
Removed use of the global GetInstanceForNativeUI() from BadgedProfilePhoto. Created a wrapper class to encapsulate the badge ImageView that keeps the badge icon color in sync with the current theme colors. Bug: 1056916 Change-Id: I99a71d9912f16d8102a3a244a6db974ec46c371c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090309Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#747501}
-
Brandon Tolsch authored
This reverts commit 3e1332b1. Reason for revert: 8.2.264 introduced target with missing build dep that leads to flaky compile failures, e.g.: https://ci.chromium.org/p/chromium/builders/ci/Android%20Release%20%28Nexus%205X%29/29415 Original change's description: > Update V8 to version 8.2.266. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/4b1eadeb..fbadeeaf > > Please follow these instructions for assigning/CC'ing issues: > https://v8.dev/docs/triage-issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel > > TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com > > Change-Id: Iec9ca3c5afbacda564fa9f48919b31667be03f1b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089399 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#747325} TBR=hablich@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7df532cb2c70bf994cf8a4288eae013f953a1cd8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090498 Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Reviewed-by:
-
Allen Bauer authored
Bug: 1056761 Change-Id: Ib6d53cb2afd4b2c94f91f789dbc73ad268e01051 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080589 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#747499}
-
Joe DeBlasio authored
It turns out that there's a *lot* of churn in Page Info right now. This change lets me escape the torrential downpour of such changes. Change-Id: Id1468346eacc6b64afc67946f646e5c1ab48662c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090755 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#747498}
-
Xinghui Lu authored
Add tests for the StartLookup method. Bug: 1050859 Change-Id: Idfc261cdd5fbc75d359cfa40b0be5621e57f8c0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086812Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#747497}
-
tby authored
We are enabling a feature under experiment to add file recommenations into the suggestion chips in the launcher, see go/cros-suggested-files for more details. We have exisitng icons to use for most file types, but 5 of them need to be adjusted for the background color of the suggestion chips. This CL adds the tweaked icons. This is a temporary measure until the new SVG icons are ready. jennyz@ suggested /ui/chromeos/resources would be a good home for these, since they're Chrome OS UI-specific but need to be accessed outside of ash. But, let me know if there's a better place for them! Bug: 1034842 Change-Id: I0da77195161e43bd12173e8b48cec151e94ae19d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086360Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#747496}
-
Raul Tambre authored
In file included from ../../base/profiler/module_cache.cc:5: In file included from ../..\base/profiler/module_cache.h:14: In file included from ../..\base/containers/flat_set.h:10: ../..\base/containers/flat_tree.h(788,24): error: call to 'as_const' is ambiguous return const_cast_it(as_const(*this).find(key)); ^~~~~~~~ ../../base/profiler/module_cache.cc(36,58): note: in instantiation of function template specialization 'base::internal::flat_tree<std::__1::unique_ptr<const base::ModuleCache::Module, std::__1::default_delete<const base::ModuleCache::Module> >, std::__1::unique_ptr<const base::ModuleCache::Module, std::__1::default_delete<const base::ModuleCache::Module> >, base::internal::GetKeyFromValueIdentity<std::__1::unique_ptr<const base::ModuleCache::Module, std::__1::default_delete<const base::ModuleCache::Module> > >, base::ModuleCache::ModuleAndAddressCompare>::find<unsigned long long>' requested here const auto non_native_module_loc = non_native_modules_.find(address); ^ C:\Google\chromium\src\out\release\..\..\buildtools\third_party\libc++\trunk\include\utility(275,50): note: candidate function [with _Tp = base::internal::flat_tree<std::__1::unique_ptr<const base::ModuleCache::Module, std::__1::default_delete<const base::ModuleCache::Module> >, std::__1::unique_ptr<const base::ModuleCache::Module, std::__1::default_delete<const base::ModuleCache::Module> >, base::internal::GetKeyFromValueIdentity<std::__1::unique_ptr<const base::ModuleCache::Module, std::__1::default_delete<const base::ModuleCache::Module> > >, base::ModuleCache::ModuleAndAddressCompare>] template <class _Tp> constexpr add_const_t<_Tp>& as_const(_Tp& __t) noexcept { return __t; } ^ ../..\base/stl_util.h(167,32): note: candidate function [with T = base::internal::flat_tree<std::__1::unique_ptr<const base::ModuleCache::Module, std::__1::default_delete<const base::ModuleCache::Module> >, std::__1::unique_ptr<const base::ModuleCache::Module, std::__1::default_delete<const base::ModuleCache::Module> >, base::internal::GetKeyFromValueIdentity<std::__1::unique_ptr<const base::ModuleCache::Module, std::__1::default_delete<const base::ModuleCache::Module> > >, base::ModuleCache::ModuleAndAddressCompare>] constexpr std::add_const_t<T>& as_const(T& t) noexcept { ^ And others like this... Bug: 752720 Change-Id: I1eeb9c0b1ebaf90a9df503c5b7d9f4629236d8e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089821 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: -
Jan Wilken Dörrie authored
This change Simplifies the static_asserts in base::span's fixed subview API first<Count>(), last<Count>() and subspan<Count, Offset>(). These simplifications rely on the fact that dynamic_extent is equal to std::numeric_limits<size_t>::max(), and thus will never be smaller than any other possible value. References: - https://cplusplus.github.io/LWG/issue3103 - https://github.com/cplusplus/draft/commit/6a0aa7 Bug: 828324 Change-Id: I626b7e65b1ae8010485c4387a936704810e43fe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089843 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
