Commits · ef395109a308ef91e30b606ead5cb4736654285d · eriksson monteiro / tangled

25 Apr, 2014 40 commits

Stop passing chrome.test.fail as ErrorCallback · ef395109

hashimoto@chromium.org authored Apr 25, 2014

chrome.test.fail cannot be used as ErrorCallback because it throws exception when the number of arguments doesn't match.
This wrong use of chrome.test.fail makes the error output useless when something goes wrong.

BUG=None
TEST=browser_tests

Review URL: https://codereview.chromium.org/258523004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266271 0039d316-1c4b-4281-b951-d872f2087c98

ef395109

Update .DEPS.git · c899862a

chrome-admin@google.com authored Apr 25, 2014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266270 0039d316-1c4b-4281-b951-d872f2087c98

c899862a

MacViews: Introduce native_cursor.h to provide cursor "literals" · 01644b15

tapted@chromium.org authored Apr 25, 2014

The ui:: cursors constants like ui::kCursorIBeam are gfx::NativeCursors
on aura, but not other platforms.

This change introduces ui/views/native_cursor.h, which provides a set of
functions giving gfx::NativeCursor constants in a platform-independent
way.

BUG=366007

Review URL: https://codereview.chromium.org/248863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266269 0039d316-1c4b-4281-b951-d872f2087c98

01644b15

Add BUILD.gn to build ui strings from grit. · 141e6490

tfarina@chromium.org authored Apr 25, 2014

In Debug configuration:

$ gn gen out/Debug_gn
$ ninja -C out/Debug_gn strings

In Release configuration:

$ gn gen out/Release_gn --args=is_debug=false
$ ninja -C out/Release_gn strings

BUG=None
TEST=see above
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/246593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266268 0039d316-1c4b-4281-b951-d872f2087c98

141e6490

Perform navigation policy check on UI thread for --site-per-process. · 893558b0

nasko@chromium.org authored Apr 25, 2014

This CL adds a NavigateFrameToURL method, which will allow browser tests to navigate specific (sub)frames and more precise out-of-process iframes tests can be written.

It also changes how cross-site transition is done for --site-per-process. It used to depend on the Referer header, but if there is a navigation to data URL, it will be empty and there will always be a transfer to new renderer.
I'm changing it to do the check on the UI thread and for now to be a very simplistic one - is the URL in the same SiteInstance as the current renderer.

BUG=357747

Review URL: https://codereview.chromium.org/248963007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266267 0039d316-1c4b-4281-b951-d872f2087c98

893558b0

Blink roll 172520:172575 · b98c8b5d

aboxhall@chromium.org authored Apr 25, 2014

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=172520:172575&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/259773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266266 0039d316-1c4b-4281-b951-d872f2087c98

b98c8b5d

Revert of Remove oilevent from tough layout cases. (https://codereview.chromium.org/234813010/) · a2c020e2

tonyg@chromium.org authored Apr 25, 2014

Reason for revert:
Did not fix OOM, just moved it.

BUG=357326

Original issue's description:
> Remove oilevent from tough layout cases.
> 
> It OOMs on some android devices now and no one has the cycles to debug.
> 
> BUG=357326
> NOTRY=True
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266039

TBR=simonhatch@chromium.org,rschoen@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=357326

Review URL: https://codereview.chromium.org/252703005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266257 0039d316-1c4b-4281-b951-d872f2087c98

a2c020e2

veatest: Fix parameter string parse order. · 81ca720c

posciak@chromium.org authored Apr 25, 2014

Fix parsing order of the stream parameters string to match the
documented order.

TEST=Run
BUG=None
TBR=fischman@chromium.org

Review URL: https://codereview.chromium.org/257713003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266256 0039d316-1c4b-4281-b951-d872f2087c98

81ca720c

[Telemetry] Disable netsim page cycler on windows. · cbffb21e

tonyg@chromium.org authored Apr 25, 2014

It hangs for an unknown reason. This patch disables it while we invetigate and
should be reverted once solved.

BUG=353260
TBR=dtu@chromium.org

Review URL: https://codereview.chromium.org/253573005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266254 0039d316-1c4b-4281-b951-d872f2087c98

cbffb21e

[Telemetry] Disabling befamous in key silk cases. · 81aadf96

tonyg@chromium.org authored Apr 25, 2014

It fails to scroll on android due to a functional Chrome bug.

Please revert this patch after this bug is fixed.

BUG=366371
TBR=ernstm@chromium.org

Review URL: https://codereview.chromium.org/250773009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266253 0039d316-1c4b-4281-b951-d872f2087c98

81aadf96

webui: rename "DialogClose" to "dialogClose" to match other webui messages. · 81ad1796

dbeam@chromium.org authored Apr 25, 2014

R=thakis@chromium.org
BUG=none
TEST=no DCHECK()s about unhandled webui messages fire

Review URL: https://codereview.chromium.org/251623003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266246 0039d316-1c4b-4281-b951-d872f2087c98

81ad1796

ozone: dri: Remove CHECK failure on page flip failure · 1f16245c

spang@chromium.org authored Apr 25, 2014

This happens normally when the display is blanked by powerd.

BUG=333413
TEST=ran chrome on link_freon
NOTRY=true
R=dnicoara@chromium.org

Review URL: https://codereview.chromium.org/251843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266244 0039d316-1c4b-4281-b951-d872f2087c98

1f16245c

Update .DEPS.git · a97e99d7

chrome-admin@google.com authored Apr 25, 2014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266243 0039d316-1c4b-4281-b951-d872f2087c98

a97e99d7

Roll webrtc 5963 -> 5979 · 9c4cdd99

wjia@chromium.org authored Apr 25, 2014

R=ronghuawu@chromium.org

Review URL: https://codereview.chromium.org/256633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266242 0039d316-1c4b-4281-b951-d872f2087c98

9c4cdd99

Adding maps test expectation until we receive a better recording · a841c595

bajones@chromium.org authored Apr 25, 2014

BUG=367173
TBR=kbr@chromium.org

Review URL: https://codereview.chromium.org/255903003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266240 0039d316-1c4b-4281-b951-d872f2087c98

a841c595

Multiprofile: switch to newly added user to the session · 222e0ad2

dpolukhin@chromium.org authored Apr 25, 2014

This CL remember pending user switch and do it as soon as profile
ready. From UI perspective this look very smooth because profile loading
is actually fast so previous desktop is not shown. But if it will be
a problem on slow device we may need to stay on add user screen a bit longer.

BUG=333879
TEST=manual
R=nkostylev@chromium.org

Review URL: https://codereview.chromium.org/246253009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266239 0039d316-1c4b-4281-b951-d872f2087c98

222e0ad2

Suppress uninitialized read in CLD2::UTF8GenericReplaceInternal · 9eabd003

bruening@google.com authored Apr 25, 2014

BUG=334448
R=thestig@chromium.org
TBR=thestig@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/254773003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266238 0039d316-1c4b-4281-b951-d872f2087c98

9eabd003

webui: remove the precendent for silly, invalid end of jsdoc comments, e.g. · 7dba74b4

dbeam@chromium.org authored Apr 25, 2014

  /**
   * Some doc comment.
   **/ <-- this

I've had to tell people to change **/ -> */ more times than I can count.

Also make myself an OWNER of a webui testing directory.

R=estade@chromium.org, sky@chromium.org
BUG=366972
TEST=less review comments
NOTRY=true

Review URL: https://codereview.chromium.org/255503006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266237 0039d316-1c4b-4281-b951-d872f2087c98

7dba74b4

[Telemetry] Disable jsgamebench on linux. · c38c8afc

tonyg@chromium.org authored Apr 25, 2014

The benchmark is broken there due to a Chrome bug. This patch just papers
over the breakage to get the tree green.

Please revert this patch when chrome is fixed.

BUG=365237
TBR=fmeawad@chromium.org

Review URL: https://codereview.chromium.org/257953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266236 0039d316-1c4b-4281-b951-d872f2087c98

c38c8afc

Disable StatusTrayStateChangerWinTest.Setup due to COM errors. · c8957367

zturner@chromium.org authored Apr 25, 2014

BUG=367199
TBR=dewittj

Review URL: https://codereview.chromium.org/254853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266235 0039d316-1c4b-4281-b951-d872f2087c98

c8957367

[Telemetry] Disable robohornet pro because it is broken on Android. · 2060b7d4

tonyg@chromium.org authored Apr 25, 2014

This is a legit chrome bug, but we're papering over it to get the bots green.

Please re-enable benchmark when bug is fixed.

BUG=357338
TBR=pdr@chromium.org

Review URL: https://codereview.chromium.org/256803004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266233 0039d316-1c4b-4281-b951-d872f2087c98

2060b7d4

Update Windows UI on system color changes. · f58e31c5

msw@chromium.org authored Apr 25, 2014

Propagate system theme (high contrast, etc.) changes throughout Views.
(Win UI wasn't being notified; omnibox, find bar, etc. were broken, now aren't).
(Linux Aura didn't update on changes with "Use Classic Theme", now it does).

Make NativeTheme hold an observer list to be notified of changes.
NotifyObservers of system color changes on Win via SysColorChangeListener.
Nix NativeTheme duties for ThemeServiceAuraX11, and LinuxUI / Gtk2UI.

Make Widget a NativeThemeObserver to call PropagateNativeThemeChanged.
Start observing the relevant NativeTheme after native widget initialization.

Make View::AddChildViewAt only update child views, not itself and siblings.
(this was invoking redundant calls on itself as the parent and sibling views)

Implement the BrowserView::OnNativeThemeChanged override.
(update the frame and trigger a repaint with UserChangedTheme)
(call MaybeShowInvertBubbleView, nix SysColorChangeListener impl)

TODO(followup): Audit Views that need OnNativeThemeChanged overrides.

BUG=134766
TEST=Win/Linux UI updates better when applying high contrast black/inverse system themes.
R=erg@chromium.org, estade@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/239093007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266232 0039d316-1c4b-4281-b951-d872f2087c98

f58e31c5

content: Terminate early if the toolkit initialization fails. · d957b10b

sadrul@chromium.org authored Apr 25, 2014

On Chrome OS, it is possible for chrome to start without the X11
server (e.g. X server has crashed, and hasn't restarted since). In
such cases, Chrome ends up causing a crash. So instead of the crash,
abort the startup sequence if the toolkit initialization step fails.

BUG=364929
R=jam@chromium.org

Review URL: https://codereview.chromium.org/250723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266231 0039d316-1c4b-4281-b951-d872f2087c98

d957b10b

Mojo: Windows: Enable Channel::Shutdown() on fatal error. · ffe1703c

viettrungluu@chromium.org authored Apr 25, 2014

r266056 (crbug.com/366768) fixed the nested deletion bug.

R=yzshen@chromium.org

Review URL: https://codereview.chromium.org/253493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266227 0039d316-1c4b-4281-b951-d872f2087c98

ffe1703c

Remove GPU_FEATURE_TYPE_3D_CSS and --disable-accelerated-layers · 2a4c873d

piman@chromium.org authored Apr 25, 2014

We ignore GPU_FEATURE_TYPE_3D_CSS, so remove it.
Nothing sets --disable-accelerated-layers, and it doesn't correspond to
a production path, so remove it.
This lets us clean up some WebPreferences fields which are always set to
true.

Also remove WebPreferences::accelerated_compositing_for_plugins_enabled
which is always true.

BUG=362164,365847
R=bbudge@chromium.org, danakj@chromium.org, tsepez@chromium.org

Review URL: https://codereview.chromium.org/239973005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266226 0039d316-1c4b-4281-b951-d872f2087c98

2a4c873d

Remove uninstall extensions command line switch · ac46d03c

asargent@chromium.org authored Apr 25, 2014

BUG=351294
R=asargent@chromium.org

Review URL: https://codereview.chromium.org/238723008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266225 0039d316-1c4b-4281-b951-d872f2087c98

ac46d03c

Add WebGeolocationClient getter on RenderFrameImpl in preparation for getting... · 5ee7f18e

jam@chromium.org authored Apr 25, 2014

Add WebGeolocationClient getter on RenderFrameImpl in preparation for getting it from WebFrameClient.

BUG=304341
R=nasko@chromium.org

Review URL: https://codereview.chromium.org/256693005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266224 0039d316-1c4b-4281-b951-d872f2087c98

5ee7f18e

Add WebUserMediaClient getter on RenderFrameImpl in preparation for getting it from WebFrameClient. · 8538385f

jam@chromium.org authored Apr 25, 2014

BUG=304341
R=nasko@chromium.org

Review URL: https://codereview.chromium.org/256763003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266223 0039d316-1c4b-4281-b951-d872f2087c98

8538385f

Update test data file in content. · 82eb4555

dalecurtis@google.com authored Apr 25, 2014

BUG=366750

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266222 0039d316-1c4b-4281-b951-d872f2087c98

82eb4555

Fix unused variable warning. · dc7ebe01

dalecurtis@google.com authored Apr 25, 2014

BUG=none
TEST=compile
TBR=zturner

Review URL: https://codereview.chromium.org/258823004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266221 0039d316-1c4b-4281-b951-d872f2087c98

dc7ebe01

Disable content tests while test data is updated. · ad24d644

dalecurtis@google.com authored Apr 25, 2014

Can't use DISABLED_ macro for TEST_P so just commented out for now.

BUG=366750
TEST=compile
TBR=acolwell
NOTRY=true

Review URL: https://codereview.chromium.org/250953004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266220 0039d316-1c4b-4281-b951-d872f2087c98

ad24d644

Make AutocompleteInput::Parse() more strict: return QUERY for all inputs that · c448c889

pkasting@chromium.org authored Apr 25, 2014

can't be fixed up into valid URLs.

BUG=357172
TEST=Typing "google.com/%00" (no quotes) into a debug build omnibox should not cause a DCHECK
R=mpearson@chromium.org

Review URL: https://codereview.chromium.org/226283009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266217 0039d316-1c4b-4281-b951-d872f2087c98

c448c889

Add Pepper owners for mojo/examples/pepper_container_app. · 8c25a8f6

yzshen@chromium.org authored Apr 25, 2014

So that we don't have to bug Mojo owners everytime for any Pepper
interface change.

TEST=None
BUG=None
R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/253613004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266215 0039d316-1c4b-4281-b951-d872f2087c98

8c25a8f6

Mojo: Mojom: Add flag to force using bundled Python modules. · a11402e3

viettrungluu@chromium.org authored Apr 25, 2014

(And make it the default in mojom_bindings_generator.gypi, so people who
have other/older system-installed versions of ply or jinja2 don't get
broken.)

TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/258733003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266212 0039d316-1c4b-4281-b951-d872f2087c98

a11402e3

Disable ComApiTest and TraySizeApiTest due to COM errors. · adcfcda7

zturner@chromium.org authored Apr 25, 2014

BUG=367199
TBR=dewittj

Review URL: https://codereview.chromium.org/250813004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266211 0039d316-1c4b-4281-b951-d872f2087c98

adcfcda7

Revert 266051 "Remove files in /var/lib/whitelist before attempt..." · 8269e3df

achuith@chromium.org authored Apr 25, 2014

login_OwnershipNotRetaken failures due to this CL.

BUG=358728,367005

> Remove files in /var/lib/whitelist before attempting login with telemetry.
> 
> BUG=358728
> TEST=Manual
> NOTRY=True
> 
> Review URL: https://codereview.chromium.org/246353004

TBR=achuith@chromium.org

Review URL: https://codereview.chromium.org/256833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266209 0039d316-1c4b-4281-b951-d872f2087c98

8269e3df

Update .DEPS.git · 495d391d

chrome-admin@google.com authored Apr 25, 2014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266206 0039d316-1c4b-4281-b951-d872f2087c98

495d391d

Roll DEPS to bring in Syzygy 0.7.11.1 binaries. · 785687b0

chrisha@google.com authored Apr 25, 2014

The current binaries are blocking a WebRTC roll, and breaking the canary builder.

BUG=367059

Review URL: https://codereview.chromium.org/252633008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266205 0039d316-1c4b-4281-b951-d872f2087c98

785687b0

Add a string for translation. · e779800a

finnur@chromium.org authored Apr 25, 2014

BUG=None
R=asargent@chromium.org

Review URL: https://codereview.chromium.org/252693005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266202 0039d316-1c4b-4281-b951-d872f2087c98

e779800a

Add WebUserMediaClient getter on RenderFrameImpl in preparation for getting it from WebFrameClient. · bfe45e20

jam@chromium.org authored Apr 25, 2014

BUG=304341
R=nasko@chromium.org

Review URL: https://codereview.chromium.org/258693004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266201 0039d316-1c4b-4281-b951-d872f2087c98

bfe45e20