- 18 Nov, 2020 40 commits
-
-
Wan-Teh Chang authored
https://chromium.googlesource.com/external/github.com/AOMediaCodec/libavif.git/+log/4eb2d0b58ecc..93d5bf907aec $ git log 4eb2d0b58..93d5bf907 --date=short --no-merges --format='%ad %ae %s' 2020-11-17 jdrago avifDecoderNthImageMaxExtent(): Remove includeDependentFrameExtents argument, as it only added confusion, and the use-case with it set to false isn't useful 2020-11-17 wtc Replace firstExtent in avifDecoderItemMaxExtent 2020-11-17 wtc Fix bugs in MaxExtent and ExtentMerge 2020-11-17 wtc Miscellaneous cleanup in read.c 2020-11-17 wtc Clean up comments related to idat fox for an item 2020-11-17 wtc Use correct abbreviated function name in printf 2020-11-17 jdrago Reword comments for clarity 2020-11-17 jdrago avifGuessFileFormat() now guesses by header magic instead, if the file can be read 2020-11-13 jdrago Explicitly mark helper functions with a note about avifDecoderParse() returning OK first 2020-11-13 jdrago Expose avifDecoderItemExtent as avifExtent, and add avifDecoderNthImageMaxExtent() streaming helper function 2020-11-13 jdrago Reintroduce validity comment lost by the Ready revert 2020-11-13 jdrago Fix all offsets to be uint64_t and all sizes to be size_t in avifDecoderItemExtent and avifDecoderItem 2020-11-13 jdrago Revert "Add avifDecoderNthImageReady() avifIO helper function" 2020-11-05 jdrago Read/write one of each type of colr box, as allowed in HEIF 6.5.5.1 (Amemendment 3) Created with: roll-dep src/third_party/libavif/src In blink::AVIFImageDecoder::FrameIsReceivedAtIndex(), replace avifDecoderNthImageReady() with avifDecoderNthImageMaxExtent(). R=dalecurtis@chromium.org,pkasting@chromium.org Bug: 1136922 Change-Id: I17c60ddcd16bb4f8037c439552ba4260d85be8d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545583 Commit-Queue: Wan-Teh Chang <wtc@google.com> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#828538}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cca2a004..0b81ac61 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic3ec4720ec01867b16350b2a5db92f4dca8b8a8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545296Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828537}
-
Sophie Chang authored
This makes it easier to add support for the model file path that we are supporting in the near future for TFLite models Bug: 1146151 Change-Id: Ib63e2c68f3e5a227cca8db9d73db9765de41bb16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545872Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#828536}
-
Miguel Casas authored
Original CL (crrev.com/c/2344526) broke the newly added unit tests on some devices, concretely where there's a normal-encoding and a low power encoding variants: VaapiWrapper will try to use the low power version (maybe: IsLowPowerEncSupported()), which confused the test. The solution is to just try VaapiWrapper's preferred entrypoint (and not all of them), see crrev.com/c/2544368/1..5 has the delta. (Verified on Atlas which was one of the broken ones) Original CL description ----------------------------------------------- This CL queries the driver for the encoding quality range and, if available and the device is considered "low power" (celeron, pentium and Core -Y devices), sets it to its maximum value, for highest speed and lowest power consumption, albeit at lower encoding quality. The quality difference should not be noticeable for video conference scenarios. I followed the code in both of Intel's VA backends. For the legacy i965: - VP8 supports values 1-2 [1]. (ENCODER_LOW_QUALITY is 2 so at least this CL can supersede the patch in [2] which is what it was set off to do). - AVC1 and VP9 support 1-7 [3,4], ENCODER_QUALITY_RANGE_(AVC,VP9) == 7 see [5], but this only on Gen9 [6a, 6b] (VP9 encoding is only available in Gen9+ FTR). For the modern intel-media-driver iHD, values are configured with names, 1 being TARGETUSAGE_BEST_QUALITY ([7] and its following lines). By default, the TARGETUSAGE_RT_SPEED == 4 is used, and 7 would be TARGETUSAGE_BEST_SPEED. Improvements depend on the input content. I measured kohaku with EncodeAccelPerf.h264_1080p_i420 and when ToT is ~204fps, 4.75W, with this CL I see ~220 fps, 4.42W. [1] https://github.com/intel/intel-vaapi-driver/blob/d87db2111a33b157d1913415f15d201cc5182850/src/i965_drv_video.c#L1151 [2] https://source.chromium.org/chromiumos/chromiumos/codesearch/+/master:src/third_party/chromiumos-overlay/x11-libs/libva-intel-driver/files/vp8-encoder-Workaround-to-force-perforamce-mode-enco.patch;l=36 [3] https://github.com/intel/intel-vaapi-driver/blob/d87db2111a33b157d1913415f15d201cc5182850/src/i965_drv_video.c#L1142 [4] https://github.com/intel/intel-vaapi-driver/blob/d87db2111a33b157d1913415f15d201cc5182850/src/i965_drv_video.c#L1149 [5] https://github.com/intel/intel-vaapi-driver/blob/021bcb79d1bd873bbd9fbca55f40320344bab866/src/i965_drv_video.h#L76 [6a] https://github.com/intel/intel-vaapi-driver/blob/021bcb79d1bd873bbd9fbca55f40320344bab866/src/i965_encoder.c#L1599 [6b] https://github.com/intel/intel-vaapi-driver/blob/021bcb79d1bd873bbd9fbca55f40320344bab866/src/i965_encoder.c#L1653 [7] https://github.com/intel/media-driver/blob/105f0341a21324ae3bc458cfa6c25c7df0517f3a/media_driver/agnostic/common/codec/shared/codec_def_common.h#L333 Bug: b:141147405 Change-Id: I231f043edacc79cadd87b9f992505977e5802cda Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Sreerenj Balachandran <sreerenj.balachandran@intel.com> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544368 Cr-Commit-Position: refs/heads/master@{#828535}
-
Clark DuVall authored
The Play Store complains if the com.google.ar.core.min_apk_version is not present in the base manifest. This behavior was changed due to https://crrev.com/c/2538369. Bug: 1149022 Change-Id: I0498bae13e32e2fd2b0712e74533680843e91581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545725 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#828534}
-
Michael Checo authored
Screenshot: http://shortn/_NrxNEm5iXS Bug: 1125150 Test: browser_tests --gtest_Filter=DiagnosticsApp* Change-Id: Ia1b6f2079e659d0bba9726378b37bb5ed62e7c50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531054 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#828533}
-
My Nguyen authored
As ClearAutocorrectRange method is now available, update usage of SetAutocorrectRange. Bug: None Change-Id: I462f29d73f246bac18bcbaab2e0ecece85a8bf14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536211 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#828532}
-
Andrew Paseltiner authored
Bug: 1114213 Change-Id: I2465b566cfce6cb5eefab3c9c26dd0b2ee09a313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543129 Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#828531}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/f1223ce969c7..bb96f79d0e15 2020-11-17 capn@google.com Disable code generation optimization for MSan builds If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ic60554619650e9f56e62e33ce0bd74ac903e5adc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545606Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828530}
-
David Tseng authored
In https://chromium-review.googlesource.com/c/chromium/src/+/2261098 TtsUtteranceImpl started taking an optional WebContents in its constructor. When the WebContents is destroyed, the utterance is cleared and stopped from triggering tts. This change exposes this behavior up to c/p/b and cleans up AccessibilityManager which approximated this behavior by calling TtsController::Stop(). Some notable examples that benefit from this: - extensions that trigger tts utterances, when destroyed, stop those utterances - the tts settings webui, if closed, will stop tts utterances in progress Change-Id: I7169b7ea3093e24e093c6c478040d943f34353f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541002 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#828529}
-
Brian Salomon authored
Allows removal of combined enum from Skia: https://skia-review.googlesource.com/c/skia/+/334161 Bug: skia:10632 Change-Id: I6e89110694ba5808d493d9ff0670727f383a2577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533579 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
-
Max Curran authored
translated or not translated This new code tracks the amount of time the user spends on a page load while it is in the foreground and either translated or not translated. It then logs these totals at the end of the page load to UMA. Full design doc: https://docs.google.com/document/d/1dyWh1Xw5VgUA00VA-5PTgKQ6ItziPBnSyeDR8saJ9vM/edit?usp=sharing Bug: 1114868 Change-Id: Ib0eb752fa33d98ca9298d9d94cc705b4599b9fac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531058Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Max Curran <curranmax@chromium.org> Cr-Commit-Position: refs/heads/master@{#828527}
-
Dave Tapuska authored
This code is no longer called. Remove it. BUG=1097816 Change-Id: I7f00f96c5fa7de9e7219db19db2bd0fade3e2c12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536781 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#828526}
-
Evan Stade authored
This is a pretty generic file with no ties to //chrome, and is needed by code in components. Bug: 1147291 Change-Id: I9259a472354661e45bac8af6c56205a227a1978e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543125 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#828525}
-
Jesse Schettler authored
Dropdowns are currently disabled based on the app state and the number of options they contain. Only disable dropdowns based on the app state. Bug: 1059779 Change-Id: I6b817c0590d38091a26f639d434c9e975b2d90f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545688Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/90b4c0f76b33..868f530e6c5c 2020-11-17 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I340b5f7ea2b1506b19d72285a249bf9e0137d5cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545984Reviewed-by:
-
nohe@chromium.org authored
This change prevents the clipboard data from being accessed if the clipboard data happens to be null. This is to prevent crashes from occurring that happened when the nonbacked clipboard held a nullptr for the data field and we tried to access it. BUG=1147262 Change-Id: Ic778a18ed592e3d7ad8de1ea2fd949c6b31767db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544077Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Alexander Nohe <nohe@chromium.org> Cr-Commit-Position: refs/heads/master@{#828522}
-
Liquan (Max) Gu authored
This CL removes the following assumptions from CPRService: * PRService has to be alive when calling CPRService.close(). * PRService.disconnectFromClientWithDebugMessage() calls CPRService.close(). Reducing this kind of coupling would make it easier to maintain CPRService, PRService. Bug: 1025619 Change-Id: I17b278ae20a5cce305d9d1f9330fac2c13ce762f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543837 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#828521}
-
Yuly Novikov authored
Bot decommissioned in crrev.com/c/2541579 Bug: 1148989, 883500, 611945, 1002997, 1083320 Bug: 1056830, 663071 Change-Id: I56bf53efad8ac98fda8e9f91041677b5fa7ed88b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545093Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#828520}
-
Joao Victor Almeida authored
Bug: 1104938, 1104936 Change-Id: If8440bc8b17ab870f00d09773882f72a29c975bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541672Reviewed-by:
Olga Gerchikov <gerchiko@microsoft.com> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: João Victor Almeida de Aguiar <joalmei@microsoft.com> Cr-Commit-Position: refs/heads/master@{#828519}
-
Shakti Sahu authored
This CL 1 - Adds mark as read option for reading list items 2 - Removes select option for reading list items 3 - Removes edit, move menu buttons from multi-select toolbar menu if at least one reading list item is selected. Bug: 1148872 Change-Id: Ibb790a48d9f330436c1899bf7322a5432d3ec7b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539115 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#828518}
-
Yicheng Li authored
This enables websites/apps to decide whether to send a user-verification request without actually starting a dialog. BUG: b/144861739 Change-Id: Iaa5044aac25229e9a55f3e4b0f67236ffae941a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528635 Commit-Queue: Yicheng Li <yichengli@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#828517}
-
Julie Jeongeun Kim authored
This CL introduces feature_session_type.mojom and moves extensions::FeatureSessionType to it in order to use FeatureSessionType with mojo interfaces. It's a precursor to moving ExtensionMsg_SetSessionInfo to mojo interface. Bug: 1146103 Change-Id: Ied4b31e4010785e002610410217fede8ff31cb8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526649Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#828516}
-
Chris Ye authored
Resolve conflict with gesture navigation when dragging cursor handle view on the edge of the screen. Since Android 10(API 29) has supported system gesture navigation, if users try to swipe the cursor handle on the edge of screen, which will conflict with system navigation back. We should resolve this conflict via `View.setSystemGestureExclusionRects()` in `PopupTouchHandleDrawable.onSizeChanged()` Actually, it should be consistent with the behavior of the `Editor.HandleView` ``` @Override protected void onSizeChanged(int w, int h, int oldw, int oldh) { super.onSizeChanged(w, h, oldw, oldh); setSystemGestureExclusionRects(Collections.singletonList(new Rect(0, 0, w, h))); } ``` Bug: 1149803 Change-Id: Icd7669bcccfa975fbb97c0e3758a3648add0e3c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543647Reviewed-by:Changwan Ryu <changwan@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#828515}
-
Josh Nohle authored
Debug builds are seeing crashes after successful SyncMetadata responses, when serialized protos and public keys are being stored in prefs. These strings will likely contain non-UTF-8 characters, which are disallowed in pref values. In this CL, we base64-encode these values before persisting to prefs. We manually reproduced the crash without this patch and verified that this patch fixes the crash. We also updated unit test strings to include non-UTF-8 characters. Fixed: 1150031 Change-Id: I81d6f937110c8b010ce3bed3cad7c38c0099a025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545765 Auto-Submit: Josh Nohle <nohle@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#828514}
-
Marijn Kruisselbrink authored
This reverts commit 1e6b827e. Reason for revert: Tests are failing on https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29 For example: [ RUN ] ResetShortcutsComponentTest.ResetShortcutChromeTargetPreserveArguments [3748:3728:1117/162648.254:1947251:ERROR:reset_shortcuts_component.cc(62)] Number of shortcuts to reset: 1 ../../chrome/chrome_cleaner/components/reset_shortcuts_component_unittest.cc(144): error: Expected equality of these values: found_shortcuts[0].target_path Which is: L"E:\\b\\swarm_slave\\w\\itk5vfdk\\5116_696520538\\0\\scoped_dir3748_371919881\\d8473183-ca73-484f-bbdf-d7df1deebbed.tmp" fake_chrome_path_.value() Which is: L"e:\\b\\swarm_slave\\w\\itk5vfdk\\5116_696520538\\0\\scoped_dir3748_371919881\\d8473183-ca73-484f-bbdf-d7df1deebbed.tmp" Stack trace: Backtrace: chrome_cleaner::ResetShortcutsComponentTest_ResetShortcutChromeTargetPreserveArguments_Test::TestBody [0x0017FAAD+1389] [ FAILED ] ResetShortcutsComponentTest.ResetShortcutChromeTargetPreserveArguments (172 ms) Original change's description: > Create a ResetShortcutsComponent in CCT. > > The ResetShortcutsComponent will use the > existing sandboxed shortcut parser to retrieve > modified shortcuts and then overwrites the > existing shortcuts with new ones. The > component will be hooked up to the CCT in a > future CL. > > Bug: 1116017,1148930 > Change-Id: Ia6c8453af267b98884804eed3b18944afb0506ba > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520419 > Reviewed-by: Albert J. Wong <ajwong@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Varun Khaneja <vakh@chromium.org> > Commit-Queue: Bettina Dea <bdea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828453} TBR=ajwong@chromium.org,veranika@chromium.org,vakh@chromium.org,wfh@chromium.org,bdea@chromium.org Change-Id: I87e55d98da30d41141ca5c09585c02e78aa64022 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1116017 Bug: 1148930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545895Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#828513}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ecb7a9bbb816..80f68fb067c7 2020-11-17 jonross@chromium.org Remove uma_metric Subtract If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1145731 Tbr: rmhasan@google.com Change-Id: I689ea3e9e3418312fd0cdb95034d9bf24d8a3ef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545428Reviewed-by:
-
Josip Sokcevic authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //content. R=boliu@chromium.org Bug: 1113033 Change-Id: I409968b2318bd07214affd931c3db1b07431403a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544853 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Bo <boliu@chromium.org> Auto-Submit: Josip Sokcevic <sokcevic@google.com> Cr-Commit-Position: refs/heads/master@{#828511}
-
Ian Kilpatrick authored
Previously when determining the available size for distributing the table-grid into we'd simply resolve our overall fragment block-size. However when extrinsically sized (fixed, or stretched) we need to also subtract the space taken by the captions to correctly determine what space the distribute the grid into. This change performs layout on the table <caption>s up front, before computing the size of the sections/rows. Bug: 958381 Change-Id: I912d2b92928e6114eb205867acc807568f5b408e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539339 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#828510}
-
Sharon Yang authored
This test was disabled due to a change in the accessibility internals. The change necessary to get this test to work was included in CL https://crrev.com/c/2314758. Bug: 1122806 Change-Id: I71045e0e432d07b259fc56ed31abedc2316a0b2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544746Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sharon Yang <yangsharon@chromium.org> Cr-Commit-Position: refs/heads/master@{#828509}
-
Hirokazu Honda authored
I made a few mistakes at the last moment in the initial implementation. 1.) CHECK the validness of ref_frame_map is wrong in keyframe case. 2.) slice_data_offset in VASliceParameterBufferAV1 is not filled. This CL fixes them. Bug: b:172214398 Test: video_decode_accelerator_tests on volteer Change-Id: I24e9fada30dd56fe10a51fb3e5d8c448ee996666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542940 Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
Jiewei Qian authored
Bug: 1114939 Change-Id: I912370270185cd18225242ead50010c50a4baee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545324 Commit-Queue: Jiewei Qian <qjw@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Auto-Submit: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#828507}
-
Olivier Li authored
This is done by defining logging levels instead of just activating complete hang watching per thread type. Hang watching a thread type can be : 1) Deactivated. 2) Logging metrics to UMA only. 3) DumpWithoutCrashing on finding a hang. Bug: 1135528 Change-Id: I98d04c24447129cd28e2d7d04ce26743e922fef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529192 Commit-Queue: Oliver Li <olivierli@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#828506}
-
James Vecore authored
This reverts commit 842373f4. Reason for revert: causing a crash for nearby share: https://crbug.com/1146293 Original change's description: > [Sharesheet] Animate sharesheet open and close. > > This CL adds animation to Sharesheet appear and disappear. > Appear has a opacity fade in from 0 - 100 in 100ms with linear curve > and scale fade in 80-100% in 150ms with curve (0.4,0,0.2,1). > Disappear is a 100-0 in 80ms linear opacity fade out. > > In this CL we also disable sharesheet close on deactivate > when ShareActions have been selected. > > Bug: 1148692 > Change-Id: Id6a360438271ad62f5911ed97984c3230a448332 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537502 > Commit-Queue: Maggie Cai <mxcai@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828107} TBR=pkasting@chromium.org,mxcai@chromium.org,melzhang@chromium.org Change-Id: I4078300f21b2b9ab7f09563bf1bdcd3b17407f97 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1148692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545893Reviewed-by:
-
Xing Liu authored
This CL adds the folder icon provided by UX designer. Converted from svg file to xml in Android studio. The color is modified to use chrome color. Bug: 1133496 Change-Id: I1d8ecca180480653a078cdd1ab37bae8102c634e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538471Reviewed-by:
-
Joon Ahn authored
http://screen/7XAbyfjQY2eXkcm Bug: 1125150 Test: browser_tests --gtest_Filter=DiagnosticsApp* Change-Id: I64c89a4feacfc74d718b6ed32de60f252aace750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538200 Commit-Queue: Joon Ahn <joonbug@chromium.org> Reviewed-by:
-
Curt Clemens authored
Add new properties |progress| and |hasError| to nearby-progress, which allow setting a specific progress percentage and disabling the spinner during error states respectively. |progress| defaults to null. When null, a waiting animation is shown where the progress bar spins around the icon. |progress| will be used in future CLs to set specific progress percentages, but for now, only the default is used. |hasError|=true causes the progress bar to be red, icons to be grey, progress to be 100%, and stops any spinning animation. Bug: b/163036847 Change-Id: I74d88a1e4efefb6a5e73ba1fd77880b3397bc353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542850 Commit-Queue: Curt Clemens <cclem@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Josip Sokcevic authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //content. R=boliu@chromium.org, dtseng@chromium.org, kbr@chromium.org Bug: 1113033 Change-Id: Id2c963398829473e034373d3dc7909d325c77c0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543695 Auto-Submit: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#828501}
-
Nnamdi Theodore Johnson-Kanu authored
Screenshot: https://screenshot.googleplex.com/BNCSFDoGHTmY6Wm.png Reference: https://docs.google.com/presentation/d/1Mfk5ZMEmeHwSbadUbyRU0Si5k6XDIvw-j4u7TUaCIGY/edit#slide=id.g7d94e49b87_2_58 Bug: 1093185 Change-Id: Icb66ac3cc12331da0247e01fb84b4d36483d8ceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537100 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
-
Bailey Berro authored
Registers an a WebUIControllerInterfaceBinder for SystemRoutineController Bug: 1128204 Change-Id: I2cc423a94c58211ccd4b7310933ed4c30ed93a6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541814Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
-
