- 17 Dec, 2020 40 commits
-
-
Jarryd authored
* Implement |install_create_shortcut_tabbed| * Implement |set_open_in_window_internal| * Implement |assert_window_created| * Add a testing journey Bug: 1156363, 1156733, 1156379 Change-Id: I70293d6b4fd06773e6e01d9d4806ef8367794a41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595977 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#838162}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f8ca67ef2d09..fdd70108b562 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kmilka@google.com,gayane@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: kmilka@google.com,gayane@google.com Change-Id: I16ebd808502803bd7c2a71f1ae77a0410f99b792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597616Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838161}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/25c49a45ff39..7df55c21d64b 2020-12-17 wolfi@chromium.org Show service workers in the Application Panel's frame tree 2020-12-17 sigurds@chromium.org Show an issue if a SAB is passed to postMessage If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1051466,chromium:1122507 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id43d6be9ab6373c6a095f40f175c9ead2a186a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597413Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838160}
-
Eugene Zemtsov authored
Bug: 1155724 Change-Id: Icf0a258854ca518596c4b48a9b67bcfec9ec0928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596834 Auto-Submit: Eugene Zemtsov <eugene@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#838159}
-
Steven Bennetts authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/460536ec43e3..efa6d9547c85 $ git log 460536ec4..efa6d9547 --date=short --no-merges --format='%ad %ae %s' 2020-12-16 stevenjb shill: Rename kInhibited -> kInhibitedProperty 2020-12-11 vpalatin cellular: add a property to enable/disable passing the attach APN Created with: roll-dep src/third_party/cros_system_api Bug: b:172077101 Change-Id: Icb1b980c7abee9476d252f9b46ffe2ca2c1e4235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596958 Auto-Submit: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#838158}
-
Pavel Feldman authored
RenderFrameDevToolsAgentHost was listening to the page scale factor changes, but it did not obtain the current value upon creation. As a result, RFDAH had page scale factor =1 if it was not emulating it itself. Change-Id: Icf4af5527d4819ff17c3801344dbb7bd50cf80a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597185Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#838157}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/181d8baf8f01..d1469c60c1ab 2020-12-17 dneto@google.com spirv-reader: fix arity for depth texture builtins 2020-12-16 dsinclair@chromium.org Add Symbol to Variable. 2020-12-16 dsinclair@chromium.org Cleanup code using RegisterSymbol 2020-12-16 dneto@google.com spirv-reader: ignore storing 1.0 to PointSize builtin 2020-12-16 dneto@google.com spirv-reader: generalize skip reasons 2020-12-16 dneto@google.com spirv-writer: sampled type must be f32,i32,or u32 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: I710f3b2e230a194a201d15e1f8069f2340f1f94c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597412Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1608173994-6a2e9c3f805f7667eca640b2b557f764d57c9690.profdata to chrome-win64-master-1608195565-bd827a491b21adb0b88af96833fe918adc2826b3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I66a0dffadfadedd0a9aec2d10fe728b5102ca408 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596861Reviewed-by:
-
Mason Freed authored
These were previously linked to a closed bug, but we should track this specifically. TBR=schenney@chromium.org Bug: 1045510,1043488 Change-Id: I1217bd85c556bff6944906ef8f51a031103769bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595684Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#838154}
-
Rafael Cintron authored
Add xrGetViewConfigurationProperties to fake_openxr_impl_api.cc so we can use it in tests. Bug: 1131616 Change-Id: I9f367b428398c07aca73785ae00060971daff9e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597036Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Cr-Commit-Position: refs/heads/master@{#838153}
-
Mohamed Amir Yosef authored
Screenshot: https://screenshot.googleplex.com/6Ki84UvdP69rMEX.png Bug: 1139263 Change-Id: Icdaa25f0abc98affcfffb2e4e717db9bc887cf46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595278 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#838152}
-
Stepan Khapugin authored
Reason: I wrote all of this code. Bug: none Change-Id: I91d5df3b88c8f1845bd89f3b1fbbeb6c4d8d2bb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595048Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#838151}
-
Yuheng Huang authored
On windows 10 perf bots, it takes significant longer time to run the tab_search:top100:2020 story, which ofter leads to buffer overrun failure. This CL increases the buffer size to reduce the chance of the failure. Bug: 1152598 Change-Id: I4a15c0e6164661ea344df2461d79ece11e9e6eac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596827 Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#838150}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ibb4f28b8b1ff22834f2ef6ba1386c6826d134f72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597409Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838149}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0da7da798b33..cc9b7694ce3d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ided7734dbdc74632060c8a06a98eb8ad41db1c04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597061Reviewed-by:
-
Daniel Murphy authored
This change creates the basic WebAppMover class, but the functionality is currently a NOOP. However it is hooked in correctly, and the implementation would start where marked. Unittests are included to test the initial sanity checking of the source and destination URLs. Follow up patches will include the implementation and thorough browsertests. Bug: 1158066 Change-Id: I04b0a3971932f30c4bbb3b8605f84dc0ea64be99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587825 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#838147}
-
Stepan Khapugin authored
Disables the side swipes in BVC when the blocking UI is displayed. Bug: none Change-Id: Iff04be46bc078b2f523406770b757702732b8ced Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592798 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
-
Al Muthanna Athamina authored
Bug: chromium:1158374 Change-Id: Idf64a3fc636f4250ad9bb3ea6008676ec9c2d905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597437 Auto-Submit: Almothana Athamneh <almuthanna@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202012170600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/Lhu0LG_M8M2Pn2h_RBp-1HjjF6xbNUOUOu6DedtsKlQC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/174321021,b/174789628,b/174791266,b/175636382,b/175636948 Tbr: help-app@grotations.appspotmail.com Change-Id: I4b281a609780f3c293c1a3f94519c0f5f89e7d95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595982Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 89-4342.0-1607944823-benchmark-89.0.4351.0-r1 to 89-4342.0-1607944823-benchmark-89.0.4357.3-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I6c478891c4b21da4e4a4b289c5031c3b07fdf90e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597618Reviewed-by:
-
Mohamed Heikal authored
Bug: 1146511 Change-Id: Id1292c666d258a7d4bb38cd56cff7f33badba58f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596141 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#838142}
-
Fergal Daly authored
This is a reland of c669ac6b This is only the fix and not the test. Original change's description: > [Paint Preview] Post task captured callback > > This CL attempts to fix a bug where calling > WebContents::DecrementCapturerCount in the callback passed to > PaintPreviewClient can result in reloading a crashed render frame. > This is problematic and crashes if it occurs inside RenderFrameDeleted > and PaintPreviewClient::OnFinished is invoked. By posting the callback > it should be invoked after RenderFrameDeleted cleanup is done resulting > in DecrementCapturerCount no longer being called inside > RenderFrameDeleted. > > Bug: 1146573 > Change-Id: Iccb612d89135e058d8fc06de018e7c95cd91657a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595247 > Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> > Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> > Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#837649} Bug: 1146573 Change-Id: I19623734e3c16b8646c286f47420a432647e0e24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596727 Auto-Submit: Fergal Daly <fergal@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#838141}
-
Leonid Baraz authored
The purpose is to eliminate incompatibilities with server side code - written in Java - which caused overflows when treating large unsigned numbers as negative signed ones. Change in Proto will be reproduced in server code too, but there is no need to synchronize the two - uint and int in proto are compatible, as long as the numbers are not outside the limits. Bug: b:174509632 Change-Id: I996177f2580949a00a35ddc9e83ca18fdecc87e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596820Reviewed-by:
Zach Trudo <zatrudo@google.com> Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#838140}
-
Dominique Fauteux-Chapleau authored
This adds the main code to read the DM token from the profile instead of CBCM. The PerProfileConnectorsEnabled feature guards these changes from affecting working Connector policies. This change is insufficient to test per-profile Connectors since the authentication and reporting code still assume the DM token is from the browser. This adds a tweak to Connector policy test setters to ensure existing tests don't break and still use the browser DM token. Bug: 1148789, 1155585 Change-Id: I64bb1714667b0b61fdfdbadffbc153328e22f741 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590429Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#838139}
-
Francois Doray authored
Fixed: 1110729 Bug: 859963 Change-Id: I6149239d145ec58408914877a0787ac6f367fca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593934Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#838138}
-
Patrick Brosset authored
When capturing frames using the Page.screencast CDP API, the colors are a little off. It's hard to see with the naked eye, but using a color picker, you can see a difference between colors in those frames and colors in similar images taken with, e.g., the snip tool on windows. The reason for this is that the DevTools Video Consumer used by CDP does not specify any pixel format or color space when creating its underlying FrameSinkVideoConsumer, and therefore the default values are used: PIXEL_FORMAT_I420, COLOR_SPACE_HD_REC709 With this fix, we make it possible for the Page.screencast API to specify the ARGB pixel format and REC709 color space, and this seems to produce images with accurate colors. Bug: 1141314 Change-Id: If06f5419c1feaebb3134a5d422769d8123f5518b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593354 Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
Mikel Astiz authored
The general idea is to adopt sync cache GUID to identify the local session, making this datatype more similar to others. This also allows the adoption techniques like IsRecentLocalCacheGuid() to filter out copies of the local device and avoid listing them as remote devices. The old tag, stored in preferences, is kept around (marked as legacy in code) to avoid a one-off discrepancy that would run into a large traffic to servers and possibly degraded user experience. The new method is hence used for *newly* created sessions. This new logic is introduced behind feature toggle (enabled by default) in case it turns out to be problematic. Change-Id: I18b71291ea8ffc6991ce0c2ea4e388c048a880c5 Bug: 1159455 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595372 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Caleb Raitto authored
We want to determine the distribution of attempted system font family matches made by pages. Bug: 1025945 Change-Id: I6d651c26447f89ecdc57dd0664555e1b72f44edd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587435Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#838135}
-
Mila Green authored
Bug: 1159537 Change-Id: I5595f6fc3fb3efa7cd76175820dbd84d3d1f93fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595976Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Mila Green <milagreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#838134}
-
Danila Kuzmin authored
Bug: 1156672 Change-Id: I0f56c3ec6674e2040c509ef92793ae7ad6b602f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595034Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Danila Kuzmin <dkuzmin@google.com> Cr-Commit-Position: refs/heads/master@{#838133}
-
danakj authored
Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/2572896 Ensure that SkImageRep is always constructed with a valid bitmap. Instead of constructing an invalid SkImageRep then throwing it away when initializing an SkImage, we add an SkImage::CreateFromBitmap() that will just return a null SkImage directly if the bitmap is null/uninitialized. ImageSkia was creating a null ImageSkiaRep when searching for a representation in order to force use of the nearest one, but it also uses a boolean value to do the same, so stop making a null ImageSkiaRep. Then disallow null/empty ImageSkiaRep and also disallow their transport over mojo. Remove a few tests that were creating invalid ImageSkiaReps to test that they work - as they are no longer valid. Have ImageSkia constructed from ImageSkiaOperations check for the ImageSkiaRep that they get from their inner (non-null!) ImageSkia, as that can still return a null ImageSkiaRep. In that case, the resulting ImageSkiaRep must also be null. And we can do that without trying to perform operations on the (invalid, null) bitmap inside the null ImageSkiaRep. This fixes the tests included in the CL. We no longer try to serialize null or empty ImageSkiaRep since the class itself will not allow it. We do test that we will not deserialize such invalid ImageSkiaReps. And a test is also added to verify we do not allow non-n32 bitmaps to be deserialized in ImageSkiaRep. R=dcheng@chromium.org, sky@chromium.org Bug: 1155258 Change-Id: Ia18360dcd2a59be8c49b7104f01dbdd20bbe6bbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596131Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#838132}
-
Roman Aleksandrov authored
Bug: 1151292 Change-Id: Iff89c1871ad8c496a9a90dfc2f216d6f2d813a84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595428Reviewed-by:
-
adoneria authored
This will help in viewing test logs (if available) on the UI. Currently resultDB API does not pull these logs to be viewable on the build result page (crbug.com/1156255). But the logs are getting uploaded to the isolate server (for example, http://shortn/_bFsAgw8z8K). Bug: 1141075 Change-Id: I346b25740f7525af754f140c0a7e4278f79b5d96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593599Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5c18efa6. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I1016076c840e91d929f6b3ad8426ad680f6da6ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597536Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838129}
-
Karandeep Bhatia authored
This is in preparation of queueing API calls to ensure only one session or dynamic rules update for an extension takes place at a time. This will be needed for a shared rule limit between session and dynamic rules. Doc=https://docs.google.com/document/d/1FZuuQkG8Tl4ee_K3Ls37iFhjynqStfDjApPvB1N8qsw/edit?usp=sharing&resourcekey=0-kZHQzo1D3pIDAFgYoTSV5g BUG=1043200 Change-Id: Ib92866b9a707874828d4dcd1d95cb59888f3961e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578867 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#838128}
-
chromium-autoroll authored
Roll ChromeOS Atom AFDO profile from 89-4342.0-1607345364-benchmark-89.0.4351.0-r1 to 89-4342.0-1607345364-benchmark-89.0.4357.3-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ie0b4b650a5acc924ec28c67d2e4e7c20858e1dd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597415Reviewed-by:
-
Javier Ernesto Flores Robles authored
Worked on this doing pair programming with Sébastien today, and after debugging we found out that the change in the width of the text is what causes the animation to appear like it "jumps". Having the text width to be constant fixes that, and looks good on normal dynamic size fonts. However it does needs scrolling on the bigger a11y fonts. Would like to get your input in the way i'm fixing the bug, as this will decrease the horizontal space for text on iPads. Another issue we found was that on compact height the text is cropped into <1 line, and looks bad. Hiding it fixes that. Fixed: 1005249 Change-Id: I0651ec85ddbb5bbbf30f50518bbb9c6be7f9392a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595857Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Id4eada54a8699d7cfe0bd6a5e95032ccf32fb4dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595981Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7bbf434aef52..f8ca67ef2d09 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC gayane@google.com,koerber@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: gayane@google.com,koerber@google.com Change-Id: Ie9ea5d195b6ff5788c351479ff11229ddbb4f53e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596786Reviewed-by:
-
Alexandre Courbot authored
The V4L2 stateful decoder specification says the following about the drain (flush) sequence: The sequence can be only initiated if both OUTPUT and CAPTURE queues are streaming. We are currently not checking this condition, and sending the STOP command unconditionally. This makes us fail to flush properly if the flush event has been requested before the initial dynamic resolution change event has been processed, since the CAPTURE queue is not started before that. This fix by not sending the STOP command if a flush request is received while the CAPTURE queue is not streaming. Then, when the resolution is set and the CAPTURE queue streaming, check if a flush request is pending and execute it at that time. BUG=b:174449972 TEST=android.media.cts.DecoderTest#testEOSBehaviorH264 passes on Trogdor. Change-Id: I7bcb96bd761e36177bbea98df8b0b5da2c7c6791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597242 Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Reviewed-by:Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#838123}
-
