- 12 Feb, 2020 29 commits
-
-
Ahmed Fakhry authored
Fixed: 1050648 Change-Id: Iac07909fdccd3cd9536dbfd58b25a8317f037867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050933Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#740504}
-
Alex Danilo authored
Adds a bunch of style rule changes for the dialog header, managed by the CSS class 'files-ng'. Moved input styles from main.html since files-ng uses different colors. Note: text-transform is set to 'none' for the cancel selection button to retain the same behavior for the not files-ng styling. Bug: 992823 Change-Id: I153d6e2e9e4268a77bbe3d06941e85a50f5e3650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984785 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#740503}
-
Mason Freed authored
This test was marked flaky in crbug.com/660185 and it seems from the bug that many others were also flaky at the same time. Perhaps it was the victim of something else and never got re-enabled. The test itself looks fine, likely suffers from antialiasing around diagonals, but should be ok. Let's find out. From patches in this CL, it does appear that it has some flakiness on Windows only, which is covered by crbug.com/953591. Seems ok on Mac/Linux. Bug: 660185 Change-Id: I726c486f3db080141ae7c755890841c2d990d6b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047490 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#740502}
-
Mason Freed authored
The [1] CL enabled the FormControlsRefresh feature by default for Windows, Linux, and ChromeOS, which changed many layout tests. This is the final patch cleaning up after the rebaseline effort. One test just needed a modification (button-with-float), while the other four are test issues. I've created bugs for each and marked them in TestExpectations. [1] http://crrev.com/c/1967608 Bug: 1035582 Change-Id: I727aec7fe00fd1ced8e1ca6e84739710a0fbf55c Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028302 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#740501}
-
Luciano Pacheco authored
Some volumes can be displayed in the file list in addition to directory tree. This CL enable their special icons in the file list new design. Bug: 992821 Change-Id: Ieee8bc47b2a29ce1956bee6ce6a78a2ddd04c6ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043519 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#740500}
-
Peter Boström authored
This makes the close-x keyboard focusable in most cases. This serves a11y users who can detect its presence and use it, like other buttons, without the Esc shortcut. Adds the Close accessibility name back under Windows where the tooltip is removed in favor of ones generated by the platform from HTCLOSE. Bug: chromium:1019873, chromium:1049667, chromium:1049722 Change-Id: Ib33b992c1085d9368cc7573785b21e1ff05a9a3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047454 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#740499}
-
Dong Hwi Lee authored
Use '' (single quote) for string literals for consistency. Change map-based branching to switch statement to make it explicit for undefined calls. Change-Id: Ie8d6f6d27eb017bd1588f9c4a1bf528c855bc2f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041373Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Dong-Hwi Lee <leedh@google.com> Cr-Commit-Position: refs/heads/master@{#740498}
-
Sergey Ulanov authored
Previously FuchsiaVideoDecoder::Initialize() would keep the decoder when the stream config is changed from clear to encrypted. That didn't work correctly because the decoder needs to be re-initialized with secure input buffers and that mode can be selected only during decoder creation. Updated FuchsiaVideoDecoder::Initialize() to reset the decoder whenever protected mode needs to be changed. Bug: b/142274148 Change-Id: I236abd1e7d1f028ed8144adffc8b184febf789b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051364Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#740497}
-
Johannes Henkel authored
.data() may not be \0 terminated; switching this to const char* directly, no need to copy into std::string. to call Latin1().c_str() on these cache name params. String: :Format expects LATIN1 parameters, so I figure it's better Change-Id: I516f335ae41d760db91a7bd45ac7fba3432ec502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049998Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#740496}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9badae8a5df5..6a53dfe7459d git log 9badae8a5df5..6a53dfe7459d --date=short --first-parent --format='%ad %ae %s' 2020-02-11 treehugger-gerrit@google.com Merge "traced_perf: all cpus, configurable sampling rate, kernelspace samples" Created with: gclient setdep -r src/third_party/perfetto@6a53dfe7459d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Idcda674484afec51cda1dc2280f9554134955f08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051131Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740495}
-
Kyle Horimoto authored
We've simplified the design of our metrics collection, and these are no longer needed Fixed: 1047062 Change-Id: I60bf78c68b84a7a98b7e1bbb59649ac367517727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044436 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#740494}
-
Kristi Park authored
This reverts commit bae2a7ee. Reason for revert: Suspect for failing webkit_layout_tests on (none) GPU on Mac https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/51385 Original change's description: > [Shape Detection] Use IDL dictionaries for result types > > This change updates the DetectedBarcode, DetectedFace and DetectedText > types to be dictionaries rather than interfaces. This is okay because > they have only attributes and no methods. This reduces the amount of > manually written code necessary to implement them. > > This enables implementing a new field for issue 1023177 without having > to update the manual serialization and deserialization routines. > > Spec PR: https://github.com/WICG/shape-detection-api/pull/86 > > Bug: 1023177 > Change-Id: I3b93d1869c5457e2ce3da5b5690a5ff968a3c77c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040378 > Auto-Submit: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Victor Costan <pwnall@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740356} TBR=yukishiino@chromium.org,jbroman@chromium.org,reillyg@chromium.org,haraken@chromium.org,pwnall@chromium.org Change-Id: Ib2075266871bdae5651e684ac652617de91e2bb2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1023177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049945Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#740493}
-
Tricia Crichton authored
Prior to https://crrev.com/708243, the search order for Chrome binary on linux started with google-chrome. That change put chrome at the top of the search order, which breaks some user's test code. This cl restores the original search order. Bug: chromedriver:3336 Change-Id: I6307313c825bea8642028fa9718f6a6f2f3a561f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051148Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#740492}
-
Shimi Zhang authored
Android's policy doesn't allow to exchange file ownership. It should be caught by our test but we don't have up-to-date bots setup in Chromium yet. Bug: 1050064 Change-Id: I26c82e538817e68fd49f40c0c7c414c5a76078b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048271 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#740491}
-
George Steel authored
Update animation composite order on pseudo-element. Implement change found in https://github.com/w3c/csswg-drafts/pull/4616 making the sort order on pseudo-elements include all selectors. Add missing const declaration to KeyframeEffect::pseudoElement(). Remove empty-string case from KeyframeEffect::setPseudoElement(). Bug: 993365, 981894 Change-Id: I32ff6917b74fb490695299d0fde0c12393755437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031986 Commit-Queue: George Steel <gtsteel@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#740490}
-
Amr Aboelkher authored
Remove chrome.* version, because its already being shiped along with chrome_os, whenever its being used. Bug: TBD Change-Id: I705e438a6c9a7236b590e41243a5201719d62758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049856Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Cr-Commit-Position: refs/heads/master@{#740489}
-
Kristi Park authored
Flaky on MacOS: https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/17183 TBR=battre@chromium.org Bug: 1003661 Change-Id: I570c8ff44a394ad5bf62669d73f89d0060310fb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050041 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#740488}
-
Matt Menke authored
This is needed to correctly isolate any DNS requests made by PPAPI in the context of one page from those made in the context of other pages. This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/2008050. The original CL was reverted because the DNS layer auto-detects whether the current network supports IPv6, and the detection value was changing in the middle of tests. When the value changes, the cache key used for the DNS layer changes, which was resulting in cache misses. To fix the issue, the test now relies on IPv4 DNS lookups, which don't have this issue. Bug: 1021661 Change-Id: I959b81d0a3fc5973cde4ba7a0ccfd0c501ffc235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050743 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#740487}
-
Kristi Park authored
Example failures: https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20(1)/64102 https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/17727 TBR=tbansal@chromium.org,darin@chromium.org Bug: 1050143 Change-Id: I5587e526b060621454d91d872387b2baf5b3270b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050748Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#740486}
-
gogerald authored
Bug: 1051226 Change-Id: Idd065587ccd944ae8dfbc890887d939fea685c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050579 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#740485}
-
Manu Cornet authored
Change-Id: I55aadecb97945e5bf8e7f779437f96c93cce8b76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031929 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#740484}
-
David Munro authored
Create an empty page which I'll start adding Crostini disk management stuff to. Test: Manual, load settings and check it's there when flag is enabled. Bug: chromium:858815 Change-Id: Ibecf9bffccc25b8927d412eeca157b658edfbc8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040644Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#740483}
-
Nate Fischer authored
No change to logic. This moves version/channel info and MetricsProvider registration into AndroidMetricsServiceClient, to avoid copying in both WebView/WebLayer. Bug: 1015655 Test: manual - trigger UMA upload in WebView, inspect proto, verify Test: version and channel are correct Test: run_webview_instrumentation_test_apk -f AwMetricsIntegrationTest.* Test: run_components_unittests -f AndroidMetricsServiceClientTest.* Change-Id: I108ca9de3c37a8d72c566c8bb290009502a90bd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049207Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#740482}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3bc454cda8bc..b956ec9468e8 Created with: gclient setdep -r src-internal@b956ec9468e8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1041701,chromium:927262 Tbr: jbudorick@google.com Change-Id: I6118f5fa8ecd481291c7a74d7bbfe9e53e8bcc50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051243Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740481}
-
Amy Huang authored
Error introduced by https://github.com/llvm/llvm-project/commit/9ce6dc98 on implicit nullptr to bool conversions that clang used to warn on. Bug: 1051175 Change-Id: If13318abe4fcc6336104bf730e6671d82f1834af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050034 Commit-Queue: Amy Huang <akhuang@google.com> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#740480}
-
Raul Tambre authored
map() returns a list in Python 2. Python 3 returns an iterator. Wrapping in a list() results in the same behaviour on both. The backtrace line for tmpl_39c97377bd70465296e9ef54393504d947e7fcc4.py actually refers to the line in module-forward.h.tmpl. Pretty annoying to trace down! Traceback (most recent call last): File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 562, in <module> sys.exit(main()) File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 557, in main return args.func(args, remaining_args) File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 268, in _Generate processor._GenerateModule(args, remaining_args, generator_modules, File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 239, in _GenerateModule generator.GenerateFiles(filtered_args) File "C:\Google\chromium\src\mojo\public\tools\bindings\generators\mojom_cpp_generator.py", line 490, in GenerateFiles self.WriteWithComment(self._GenerateModuleForwardHeader(), File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\template_expander.py", line 37, in GeneratorInternal return ApplyTemplate(args[0], path_to_template, parameters, **kwargs) File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\template_expander.py", line 31, in ApplyTemplate return template.render(params) File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\..\..\..\..\..\..\..\third_party\jinja2\asyncsupport.py", line 76, in render return original_render(self, *args, **kwargs) File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\..\..\..\..\..\..\..\third_party\jinja2\environment.py", line 1008, in render return self.environment.handle_exception(exc_info, True) File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\..\..\..\..\..\..\..\third_party\jinja2\environment.py", line 780, in handle_exception reraise(exc_type, exc_value, tb) File "C:\Google\chromium\src\mojo\public\tools\bindings\pylib\mojom\generate\..\..\..\..\..\..\..\third_party\jinja2\_compat.py", line 37, in reraise raise value.with_traceback(tb) File "gen\mojo\public\tools\bindings\cpp_templates.zip\tmpl_39c97377bd70465296e9ef54393504d947e7fcc4.py", line 58, in <module> TypeError: object of type 'map' has no len() Bug: 941669 Change-Id: Ie00e7a9537f9ae0ac10b8a91c320fc37e7818fd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050376 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#740479}
-
Darwin Huang authored
Bug: 1046261, 1049131 Change-Id: I5e221665da64079ddf33603fdb5d012402c5d465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045076 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#740478}
-
Kristi Park authored
Correction for https://crrev.com/c/2050494, MEMORY_SANITIZER should be ADDRESS_SANITIZER TBR=hbos@chromium.org,phoglund@chromium.org Change-Id: Ibeea898c6490d38e7ae5eb7b065cbf083f89b788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051264Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#740477}
-
Sasha McIntosh authored
Extend Display::RemoveOverdrawQuads to track up to 10 occluding rects as a region in target space. cc::Region::GetRegionComplexity() exposes the number of rects contributing to a region. In the past, using regions as occluders without limiting the number of rects contributing to a region resulted in cases with significant CPU times. RemoveOverdrawQuadPerfTest benchmark results show little difference among kMaximumOccluderComplexity values when compared to pre-change results. See Occlusion Culling Improvements doc [1] for results details. [1] https://docs.google.com/document/d/1LeBa-f80FG4eioHpX706Th65FEoXcEzWmNgooZQyNSw/edit?usp=sharing#heading=h.dgeynqo2z2ly Test: viz_perftests Bug: 1022544 Change-Id: I1c844490fe57146d9448bcf408ee23dd627657ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040201 Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#740476}
-
- 11 Feb, 2020 11 commits
-
-
Sergey Ulanov authored
Previously fidl_library GN template required namespace parameter. It was separate from library_name mainly to workaround the lack of string_replace() function in GN. But that's not a problem anymore. This change updates fidl_library template to make namespace parameter optional. Now library_name can contain complete name of a FIDL library, e.g. "fuchsia.ui.gfx". namespace is still supported and works as before. Also updated all FIDL targets to specify namespace as part of library_name. Bug: 1050252 Change-Id: I3de83e244b3ef32449e170f06933beb58198aa0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045000 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#740475}
-
Nektarios Paisios authored
This patch starts the long journey of combining AXNodePosition and BrowserAccessibilityPosition into one class. It also takes a small step in combining AXTreeManager and AXTreeManagerMap into a single interface that will be used to manage a forest of AXTrees across Web, Views and chrome.automation. For now, this patch introduces TestAXTreeManager, which implements AXTreeManager and encapsulates AXTreeManagerMap. Currently, this class is used only in tests. The static method in AXNodePosition that is used to set a single AXTree as the tree to which the position belongs has been removed. This enables AXNodePosition to rely on the same tree ID as BrowserAccessibilityPosition at all its calls sites, especially in tests. An additional overload "GetNodeFromTree" has been added in AXTreeManager, that makes it easier to retrieve a node from the current tree without the need to always specify the tree ID. Some cleanup fixes have been introduced in test fixtures that now inherit from TestAXTreeManager. The constructors, destructors and move + assign operations have been fixed where they were missing or erroniously implemented, and some class comments have been cleaned up. R=dmazzoni@chromium.org, kschmi@microsoft.com, kbabbitt@microsoft.com Change-Id: I3d5e86e6e5ae77c2b47469d2c9eb44ae5093350e Bug: 1049261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039310 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Ethan Jimenez <ethavar@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#740474}
-
Brandon Wylie authored
TBR=jinsukkim@chromium.org Bug: 1051221 Change-Id: I57fdf8c492208c2cdd70ac0008c37f921dac450c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050578Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#740473}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b40d48a67c93..72e9f4d73f65 git log b40d48a67c93..72e9f4d73f65 --date=short --first-parent --format='%ad %ae %s' 2020-02-11 cnorthrop@google.com Vulkan: Update bug number in KHR ES 3.1 expectations 2020-02-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src 428455ca6121..45b9d01815d9 (2 commits) 2020-02-11 timvp@google.com Fix assignment of CacheOpResult::EnumCount Created with: gclient setdep -r src/third_party/angle@72e9f4d73f65 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: Ifd6dbd40e1a118deaee976c9eaced7235bd62d47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050813Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740472}
-
Kristi Park authored
This reverts commit ae806eaa. Reason for revert: Suspect for ExtendedCrashReportingTest.RecordsAnnotation and ActivityTrackerAnnotationTest.RegistersAtCreation components_unittests failures: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/99752 https://ci.chromium.org/p/chromium/builders/ci/win-asan/10270 Original change's description: > Refactor extended crash reporting initialization. > > Bug: 1044707 > Change-Id: I51ae9d5fd4d0972f9145927d265f36cef3a4e98c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037711 > Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740420} TBR=fdoray@chromium.org,bcwhite@chromium.org,chromium-reviews@chromium.org,joenotcharles@chromium.org,siggi@chromium.org,olivierlidupuis@gmail.com Change-Id: I019bfb0c1ce194dbe4c4f3237c9031851ec40b2e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1044707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050042Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#740471}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7e12fc7c. With Chromium commits locally applied on WPT: 5579aad0 "SharedWorker: Name shared workers identically in credentials mode WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: eae@chromium.org, szager@chromium.org: external/wpt/intersection-observer foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I9b97e813d58e375c473b3546b359485fe27e338a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050991Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740470}
-
Nasko Oskov authored
We are currently lacking explicit coverage for web documents starting a navigation to WebUI document. This is currently handled by FilterURL, which disallows the navigation and rewrites the URL to about:blank#blocked. The CL adds explicit tests for this behavior and those should be changed as we move towards blocking the navigation instead of rewriting the URL. Bug: 1002276 Change-Id: Ie61558b55e4bb3c887844b53b91f731b1e7029e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044335 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#740469}
-
Brandon Wylie authored
TBR=chouinard@chromium.org Bug: 1051213 Change-Id: Id2b6c0d8929e5eb09d9a7a063d216ea324e1b540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051288Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#740468}
-
Vadim Bendebury authored
A lot of new boards and Cr50 versions have been released since these enums were introduced. The integers reported by UMA were converted to 4 byte ASCII and looked up in the RLZ database found at go/chromeos-rlz. BUG=none TEST=none Change-Id: I4623b495bd2461a1eaadb5c4543c4a1622064d3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984627 Auto-Submit: Vadim Bendebury <vbendeb@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#740467}
-
Bo Liu authored
Implementation just list and returns all valid directories in the root profile directory. Bug: 1044581 Change-Id: I0cae48abf7ad6f2543478df582ef4e5d5b32f5b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048945Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#740466}
-
Scott Violet authored
This code is only compiled on android, so no need for chromeos ifdef. BUG=none TEST=none Change-Id: I4be1faeaf122d998a1b8aee4b5ccda31d85f0de2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050924Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#740465}
-