- 20 Aug, 2018 40 commits
-
-
Charlie Harrison authored
This is in preparation to add a struct UkmSource::Metadata, which would need to be used in //services. TBR=sky@chromium.org Bug: 873316 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0d33f6ece24b9176ff86310ef2e7347453b5ccfa Reviewed-on: https://chromium-review.googlesource.com/1179992Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#584441}
-
Juan Antonio Navarro Perez authored
Stories have been consinstently failing on N5X and Pixel 2 bots. TBR=nednguyen@google.com NOTRY=true Bug: 875859 Change-Id: I9d41fa293a90e6961eabc6b29711d8b824d469ce Reviewed-on: https://chromium-review.googlesource.com/1181140Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#584440}
-
Vadym Doroshenko authored
It contains a number of tiny clean ups: 1.Using range based for 2.Dropping autofill:: namespace in favor of using 3.Using map lookup instead of range based for by map. 4.Old comment removal in password_manager.cc Bug: 875768 Change-Id: I6d7c481139d59e8de35ec49ad58f9486de04359d Reviewed-on: https://chromium-review.googlesource.com/1177743 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#584439}
-
Sriram authored
Removing media/seek-to-currentTime.html infavor of the wpt test at wpt/html/semantics/embedded-content/media-elements/seeking/ Change-Id: I115785280c5fb0a9fdab449feea1f8a348b9271e Reviewed-on: https://chromium-review.googlesource.com/1181017Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#584438}
-
David Roger authored
This CL stops recording the user actions related to the regular sync confirmation when the consent bump is used. Adds a new bucket in the consent bump histogram for the "Abort" case. Bug: 871267 Change-Id: I35b4ce80c6da0e0fe871f6d10ab799e555960e05 Reviewed-on: https://chromium-review.googlesource.com/1179664 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#584437}
-
Juan Antonio Navarro Perez authored
They were disabled by mistake on the wrong platform. TBR=nednguyen@google.com NOTRY=true Bug: 874935 Change-Id: I9b50b481e97b9f2c01cde4cc43f1627ea4663c51 Reviewed-on: https://chromium-review.googlesource.com/1181135Reviewed-by:
-
Fredrik Söderquist authored
contextElement -> ContextElement Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: If22cc5a0624cfaf9e1e448198c891de3030bc889 Reviewed-on: https://chromium-review.googlesource.com/1181058Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#584435}
-
Ben L. Titzer authored
Minimum legal asm.js heap size is 4096 bytes. R=mslekova@chromium.org Change-Id: Ia23536c4cb1660125b21cbee399ecfdefb549e08 Reviewed-on: https://chromium-review.googlesource.com/1181060 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#584434}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/814f99cf275f..908689d04718 git log 814f99cf275f..908689d04718 --date=short --no-merges --format='%ad %ae %s' 2018-08-20 ssilkin@webrtc.org Fix calculation of number of active spatial layers. Created with: gclient setdep -r src/third_party/webrtc@908689d04718 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:none TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iea7d9471b05449d9774073dc8fca3a3f4f42f957 Reviewed-on: https://chromium-review.googlesource.com/1180860Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584433}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0e8d43a6. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23090 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I6311296098cbfbfc296428b6bc4cf9857f9ea856 Reviewed-on: https://chromium-review.googlesource.com/1181062 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#584432}
-
Alexander Timin authored
R=skyostil@chromium.org BUG=874497 Change-Id: Ia5546b2600b2502e3a5fa00c6631810af377d0de Reviewed-on: https://chromium-review.googlesource.com/1181027Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584431}
-
Peter Beverloo authored
A negative index is used to indicate the default, unset state of the action button index in the NotificationLaunchId, but this is not the right value to pass along to NotificationHandlers. Bug: 875091 Change-Id: I0d327eb1f3887904a674a6748cc6e9d60ec783c3 Reviewed-on: https://chromium-review.googlesource.com/1180973 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#584430}
-
Dominik Röttsches authored
Create an abstraction for platform specific font unique name matching and provide an implementation for Android that connect to the FontUniqueNameLookup service in RenderProcessHost, and retrieves a shared memory readonly region with a font lookup table. The font lookup table comes in the form of a protobuf that can be parsed using a library shared between content/browser and blink. On the first @font-face declaration that contains a src: local() value and is used in the text, connect to the service, and parse the lookup table, perform a lookup. Subsequent lookups will reuse the same table. After an Android firmware update which triggers a font rescan on the browser side service side, on a Nexus 6, rebuilding the index takes about 45ms. This is a one-time cost. After that, until the next firmware update, the browser process only needs to read the index file back from disk. On the renderer side, for the first font-face that uses src: local(), there is an initial IPC cost for retrieving the shared memory region and parsing the protobuf. Measurements on the previous implementation indicate that this takes less than 6ms. After that for the first and subsequent src: local() lookups, the cost is only the search through the in-memory list. Design doc in https://crbug.com/828317 Bug: 870223 Change-Id: I0bb200235dd7a9f29f3a5165a31e3c5c0cb7527e Reviewed-on: https://chromium-review.googlesource.com/1162166 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#584429}
-
tzik authored
std::swap overloads without exception specification are warned by cl.exe and clang-cl on C++17 mode, that belongs to -Wmicrosoft-exception-spec: ../../third_party/openvr/src/src/json/json.h(1227,13): error: 'swap<Json::Value, void>' is missing exception specification 'noexcept' [-Werror,-Wmicrosoft-exception-spec] inline void swap(Json::Value& a, Json::Value& b) { a.swap(b); } As ADL based dispatch is preferred for this case, and upstream jsoncpp[1] already does it, this CL adopts it too. [1]: Upstream jsoncpp commit: https://github.com/open-source-parsers/jsoncpp/commit/1d95628ba84189cd81fbabf70add5c1baf2912c5 OpenVR SDK has not rolled to this. Change-Id: I82494ef5aca5ff0df431f94f65ae8439c41977b5 Reviewed-on: https://chromium-review.googlesource.com/1179422Reviewed-by:Bill Orr <billorr@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#584428}
-
Friedrich Horschig authored
The failures affect all versions of decode-resize.js but the new expectations cover only http/tests/devtools/tracing/decode-resize.js. With this CL, all expectations are as well applied to virtual/threaded/http/tests/devtools/tracing/decode-resize.js TBR=caseq@chromium.org Bug: 847114 Change-Id: I35c53f7e2852afcf6bb0c82369a52845e73351ba Reviewed-on: https://chromium-review.googlesource.com/1181055Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#584427}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2c687ea6e0a9..6676079d2b79 git log 2c687ea6e0a9..6676079d2b79 --date=short --no-merges --format='%ad %ae %s' 2018-08-20 benjaminwagner@google.com [infra] Add comment regarding skcms use of mac_toolchain. Created with: gclient setdep -r src/third_party/skia@6676079d2b79 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I96749a25d4cfa99feb063a8dfaf2df3dd9157e44 Reviewed-on: https://chromium-review.googlesource.com/1181061Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584426}
-
stkhapugin@chromium.org authored
Makes the accelerator omnibox button in the bottom toolbar dismiss the find in page popup on press. Bug: 863002 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic293d90856a10d08c50edf8987c3eb4838c2c395 Reviewed-on: https://chromium-review.googlesource.com/1181046Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584425}
-
Friedrich Horschig authored
This test is very flaky for quite a while now. For details, check the linked bug. TBR=ramyan@chromium.org, sky@chromium.org Bug: 871010 Change-Id: I5d64a708f84d11a9b4981edc2cf53ad6b1a4151d Reviewed-on: https://chromium-review.googlesource.com/1181048Reviewed-by:
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c6b2cf82b09b..ee3986dc7034 git log c6b2cf82b09b..ee3986dc7034 --date=short --no-merges --format='%ad %ae %s' 2018-08-20 primiano@google.com TraceProcessor: Add magic ts_lower_bound to sched table Created with: gclient setdep -r src/third_party/perfetto@ee3986dc7034 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ia8d46f7c91cfdd9ed273ae4d0b17e3b042648a33 Reviewed-on: https://chromium-review.googlesource.com/1180859Reviewed-by:
perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584423}
-
Lucas Furukawa Gadani authored
Change-Id: I667124ece0bf1d0d39b493f859a284f028550036 Reviewed-on: https://chromium-review.googlesource.com/1179963Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#584422}
-
Danyao Wang authored
gCrWeb is not injected for placeholder URLs, so CRWJSWindowIDManager ends up repeatedly injecting window ID for NTPs, which interferes with injected JavaScript for the next web page. This fixes PaymentRequestMiscellaneousEGTest/testMultipleRequests. It was failing because the payment request messages were ignored due to mismatched window ID. Bug: 874637 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9a4f95d8f2f767c27a0c8dd953bb0d9914b6c0ed Reviewed-on: https://chromium-review.googlesource.com/1179221Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#584421}
-
Friedrich Horschig authored
As described in the linked bug, these tests should rather marked failing than reverting the rollout, so doing this now. They are failing _quite_ consistently but pass from time to time. TBR=robertma@chromium.org Bug: 875622 Change-Id: I34defdcd7ccda264b04acaf0ca90601668d35f80 Reviewed-on: https://chromium-review.googlesource.com/1181044Reviewed-by:
-
Yi Su authored
add an extra boolean arg to API in ImageDataFetcher and IOSImageDataFetcherWrapper to control cookies usage in requests. Change-Id: I1142ecf3b595f8ee060d28985183d28e0cdef218 Reviewed-on: https://chromium-review.googlesource.com/1174831Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#584419}
-
Peter Beverloo authored
The API hasn't been adopted by developers leading to practically zero usage. Given that there isn't a clear path to interoperability either, let's remove it. This has been approved per the following Intent to Remove on blink-dev: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/18r3whCBv0I The specification draft has been updated to mention its obsolescence: https://wicg.github.io/budget-api/ There are a few bits of browser-side budget-related code that are being used by push messaging. This CL also moves the relevant class (BudgetDatabase) to the push messaging directory, and updated it to maintain logic, while removing the dependency on the Mojo types. Bug: 873540, 874450 Change-Id: I98dcefe5b4333b969dd3c9bd4c09e9aaf9d65579 Reviewed-on: https://chromium-review.googlesource.com/1176083 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#584418}
-
Ramin Halavati authored
Profile preferences are removed from the persistent storage list for incognito mode. Since these preferences are not written from incognito mode, this change should not have any behavioral effect. Bug: 861722 Change-Id: I430d9ee9db15576d31c822483a088306df4099aa Reviewed-on: https://chromium-review.googlesource.com/1180218Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#584417}
-
Gauthier Ambard authored
On iPad, the LongPress tip should use the the kTabStripTabSwitcherGuide instead of the kTabSwitcherGuide. Bug: 875760 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I3dce36249a9b766e79473506770dd8fe565a0c28 Reviewed-on: https://chromium-review.googlesource.com/1180968Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#584416}
-
Sriram authored
The failure is very rare but there is one on the Mac build [1]. There is a possibility of playedTime being 0 in callPauseIfTimeIsReached() in video-played.js file which i believe is hitting in this case. [1]: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests/4724 BUG=874799 Change-Id: Iffe3ac49d20664eb9f824e2a1dd24aaa371dcbb2 Reviewed-on: https://chromium-review.googlesource.com/1181007Reviewed-by:
-
stkhapugin@chromium.org authored
Avoids resetting the scale when -resetTransform is called. Bug: 869379 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id649065208060cf1c3fbd4394947acad2f67cec3 Reviewed-on: https://chromium-review.googlesource.com/1180896Reviewed-by:
-
Jérôme Lebel authored
This is a reland of 72bd9335 Fixing 2 test problems: + ChromeSigninViewControllerTest.TestConsentWithOKGOTIT* UnifiedConsentService needs UnifiedConsentServiceClient, local and user preference service. To make the unittest working, the UnifiedConsentService is prevented to be created. + GoogleServicesSettingsTestCase.testOpenManageSyncedDataWebPageWhileSignedIn To open the manage synced data web page, the user should be signed in without unified consent. Original change's description: > [iOS] Using UnifiedConsentService::SetUnifiedConsentGiven() in the settings > > This CL enables unified consent given when the user signs in to Chrome. > This CL also disabled and enables unified consent given when the user > toggles the corresponding switch on and off in the Sync and other services > settings screen. > > Bug: 827072 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I5384052f4abe117e7816733e45dc4091afe55708 > Reviewed-on: https://chromium-review.googlesource.com/1165151 > Reviewed-by: Thomas Tangl <tangltom@chromium.org> > Reviewed-by: Mihai Sardarescu <msarda@chromium.org> > Reviewed-by: Sergio Collazos <sczs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581873} Bug: 827072 Change-Id: Ideb01f7c7a5bd2f5e1b6d927eb590b681283aad7 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1172402Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#584413}
-
Michael Lippautz authored
Bug: chromium:875044 Change-Id: I208aca1aeb3488d8880523c35f5e486962039ec6 Reviewed-on: https://chromium-review.googlesource.com/1179742 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#584412}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bd6c7f9f. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23089 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I694d18c78a1ed171d056338712357a681da1405f Reviewed-on: https://chromium-review.googlesource.com/1180856 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1c0cf3101d33..814f99cf275f git log 1c0cf3101d33..814f99cf275f --date=short --no-merges --format='%ad %ae %s' 2018-08-20 magjed@webrtc.org Android: Remove deprecated SurfaceTextureHelper methods 2018-08-20 titovartem@webrtc.org Eliminate SetClockOffset() from DirectTransport. 2018-08-20 peah@webrtc.org Correct audioproc_f to support the new echo canceller activation 2018-08-20 buildbot@webrtc.org Roll chromium_revision 63fab7f6..c092e144 (584203:584376) 2018-08-20 kwiberg@webrtc.org Use string_view instead of overloading for const string& and const char* Created with: gclient setdep -r src/third_party/webrtc@814f99cf275f The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:none TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic8362b4f383db101cab3bd20927d413a71df7763 Reviewed-on: https://chromium-review.googlesource.com/1180857Reviewed-by:
-
Friedrich Horschig authored
This disables all BrowserViewTests that haven't been disabled yet. Because these failures have always been Mac-only, reenable one disabled tests for non-Mac platforms. TBR=weili@chromium.org, bsep@chromium.org Bug: 875707 Change-Id: Ie0a24b706669d07577bf2413a61bd959d70950cc Reviewed-on: https://chromium-review.googlesource.com/1180975 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
-
Lutz Justen authored
Moves - ForceSafeSearchPolicyHandler - ForceYouTubeSafetyModePolicyHandler - BrowsingHistoryPolicyHandler - SecureOriginPolicyHandler out of configuration_policy_handler_list_factory.cc to the places that use the prefs. Merely a cleanup CL - no other changes. BUG=chromium:872717 TEST=tryjobs Change-Id: Ic234b0aac5f869abe9dcb99908d4ffb615bc4f2c Reviewed-on: https://chromium-review.googlesource.com/1169173 Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#584408}
-
Koji Ishii authored
Following bot results are included. 8933 8941 8946 8949 8953 8959 8963 8964 8967 8970 8979 8981 8982 8983 8984 8988 8989 8990 8991 8992 8997 8999 3 lines were removed and 6 lines were deflaked by consecutive results since 8679. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I393e199d65c61e2793264aa041c47bf8a4d08e8b Reviewed-on: https://chromium-review.googlesource.com/1178581 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#584407}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f62079a0f9e5..31458a557486 git log f62079a0f9e5..31458a557486 --date=short --no-merges --format='%ad %ae %s' 2018-08-20 anthonyalridge@google.com Create functionality in plotter to allow deletion of old plots Created with: gclient setdep -r src/third_party/catapult@31458a557486 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:866423 TBR=sullivan@chromium.org Change-Id: Ic5639c5ed7435989c3a78df3a2bf3399633b04c5 Reviewed-on: https://chromium-review.googlesource.com/1180848Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584406}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c7ca7b19c714..1c0cf3101d33 git log c7ca7b19c714..1c0cf3101d33 --date=short --no-merges --format='%ad %ae %s' 2018-08-20 oprypin@webrtc.org Stop using typeof() GNU extension 2018-08-20 titovartem@webrtc.org Introduce SimulatedNetworkReceiverInterface. Created with: gclient setdep -r src/third_party/webrtc@1c0cf3101d33 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:427584 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I9d8c9cb255a1b391cc583d15ebf7da1ad5ce37cd Reviewed-on: https://chromium-review.googlesource.com/1180854Reviewed-by:
-
Paul Jensen authored
One of the top crashers in net/ is out-of-memory with data URLs that comes when the string is needlessly duplicated during unescaping. Looks like data URLs are being used to load fonts. I'm unescaping in-place to avoid requiring two copies of the string. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8724c62b254623e5025478b27388e42d5c4a1473 Reviewed-on: https://chromium-review.googlesource.com/1169635Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#584404}
-
Guido Urdaneta authored
No-Try: true Change-Id: Ib2512dec81dcbf950c02eadf742828781d0fdb49 Reviewed-on: https://chromium-review.googlesource.com/1180962Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#584403}
-
Boris Sazonov authored
This CL moves the code from SigninView startAnimations/stopAnimations methods into separate AnimationLooper class that encapsulates animation looping logic. This class is then used in ConsentBumpMoreOptionsFragment to run the header animation. Bug: 869426 Change-Id: Ie305e4535adf27662d7d6724afc419b7bcfd8084 Reviewed-on: https://chromium-review.googlesource.com/1172688Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#584402}
-
