- 14 Aug, 2020 40 commits
-
-
Hesen Zhang authored
Bug: 1115755 Change-Id: I77d48a7d14e11e5a84dd4305011adbcaf4359873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354808 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#798299}
-
Henrique Nakashima authored
Two new classes IncognitoNotificationPresenceController and IncognitoProfileDestroyer now bind the TabModelSelector to the .incognito package, controlling respectively the incognito notification and the incognito Profile destruction. Since TabModelSelectorBase creates the TabModels only after native load, it acts as a relay for the events. It is changed to recognize that there are two TabModels, one normal and one incognito, so it can observe the incognito one. Splitting IncognitoTabModel into interface and impl keeps tests from having to depend on IncognitoTabModelImpl. Bug: 1109013 Change-Id: I697f8422777ec42b44ddf19af8abb82702e136a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343790 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#798298}
-
Weilun Shi authored
Change-Id: I67a0f21df7e3becd2e76e4971d040e9c1c4138ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354725 Commit-Queue: Weilun Shi <sweilun@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#798297}
-
adamta authored
Increase offset to fit ~2 cards before triggering infinite feed. Compute initial NTP scroll height in layout to only trigger infinite feed if the feed has loaded. Bug: 1085419 Change-Id: I9fccd5f135382d5574ccb6a7ce562339455c7564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355294 Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#798296}
-
Sophie Chang authored
This is only logged if we have a navigation to tie the event to and if there is actually a tuning version associated with the allowed optimization. Privacy doc: https://docs.google.com/document/d/1XnnJrIt6Uy81_H8FBclTRS5AI7XeZcHzZNshO-DMtrU/edit Bug: 1113287 Change-Id: If6570b62cce07b285d1129921b4e56838d0c3503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350799 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#798295}
-
W. James MacLean authored
The fourth (and final) CL in implementing origin-/site-keying of SiteInstances. https://crbug.com/1085275/#c2 lists the sequence of CLs and what each will accomplish. This CL adds the keying bit to SiteInfo, and updates MakeTie() and ComputeSiteInfo() to use it. It removes the prior hack in GetSiteForURL regarding isolated base origins, and adds/updates tests that involve isolated base origins. This CL also changes the order in which we check isolated origins, so that opt-in isolation requests take precedence over command-line isolation. Bug: 1067389, 1085275 Change-Id: I3f91fe94a1a61a7ef272d83232a6ff4e6e3bff3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269516 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#798294}
-
Michael Checo authored
Screenshots: Before: • http://shortn/_z0AhPafkbB After: • http://shortn/_GmWk2Ou5Gb BUG=1066273 TEST=manual inspection Change-Id: Ic1a47ff8f02b3c30f4800040c6f176ae41d79915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356670Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Michael Checo <michaelcheco@google.com> Cr-Commit-Position: refs/heads/master@{#798293}
-
Elly Fong-Jones authored
To create the dimming visual effect when showing a sheet in Big Sur, AppKit installs a new child window of the window with the sheet, which breaks NativeWidgetMacTest.WindowModalSheet. Bug: 1114245 Change-Id: Ib7185441e1c52e0990caa1c92f5f773431d66775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357633 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#798292}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4c3752c7f677..a3fcf2574157 2020-08-14 gijosh@google.com Add windows commandline to heapprofd api. 2020-08-14 fmayer@google.com Merge "Use libunwindstack warnings." 2020-08-14 lalitm@google.com Merge "Fix view-based annotation tracks in the UI." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:160400319 Tbr: perfetto-bugs@google.com Change-Id: Ie06ebb744780cdd643af9cf9b23a94d269a471ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356566Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798291}
-
Fabrice de Gans-Riberi authored
A Cast Streaming Session can have subsequent offer messages following the initial offer. This CL ignores subsequent offer messages to prevent a browser crash. Bug: 1116185 Change-Id: Id41b7012d5669996ba81ed9e416ceaf7d1f60b8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357675 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#798290}
-
Dominic Schulz authored
Run all the system_web_app_manager browser tests in a mode that installs by WebApplicationInfo in addition to the old manifest install. Also fix a missing feature where finalization misses the ChromeOSData when installing from a WebAppInfo Change-Id: I20a87982438d4713a0a458ba73a036288557219f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330814 Commit-Queue: Dominic Schulz <dominicschulz@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#798289}
-
Noah Rose Ledesma authored
Fix a crash caused by posting a callback to the UI thread with a pointer to a member variable without checking that the originating object is still alive. Bug: 1115364 Change-Id: Idf1594e8072d6269d3a0d2e04c17a583400e71c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353396Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Cr-Commit-Position: refs/heads/master@{#798288}
-
Lei Zhang authored
Despite some attempts to fix it, the test is still a bit flaky. Bug: 1078828 Change-Id: I16d6f8efc7aaa8c042f1f15f5887d25ffc78ea62 Tbr: olivierli@google.com Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357600Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#798287}
-
Yuke Liao authored
In order to promote browser_tests to CI to be shariffed to prevent regressions. Bug: 1111979 Change-Id: Ia01e3a124adc5acfbbceb763fb871d845309519a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356564 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Auto-Submit: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#798286}
-
zhaoyangli authored
The test was disabled due to flakiness, but it looks fine on try bots. Bug: 1109131 Change-Id: I9f113a468e5b415344b70510918ef07e791bfd75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354947 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#798285}
-
Clark DuVall authored
This reverts commit 98a0a1d3. Reason for revert: Seems this should be fixed by crrev.com/c/2354124. Original change's description: > Disable DownloadCallbackTest.testBasic on Android > > org.chromium.weblayer.test.DownloadCallbackTest.testBasic fails on > Android, > https://analysis.chromium.org/p/chromium/flake-portal/flakes/ > occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVybwsSBUZsYWtlImRjaHJvbWl1bUB3ZWJs > YXllcl9pbnN0cnVtZW50YXRpb25fdGVzdF9hcGtAb3JnLmNocm9taXVtLndlYmxheWVyLnRl > c3QuRG93bmxvYWRDYWxsYmFja1Rlc3QjdGVzdEJhc2ljDA, > disable it for now until it is fixed. > > TBR=jam@chromium.org > > Bug: 1116248 > Change-Id: I24f0ab8414f4b17ff3689f3686e3f58682c48b37 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354162 > Reviewed-by: Lan Wei <lanwei@chromium.org> > Commit-Queue: Lan Wei <lanwei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797990} TBR=jam@chromium.org,lanwei@chromium.org Change-Id: I0c18d0e319ee49770b5e453af435d22a5a0a182f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1116248, 1116311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357637Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#798284}
-
Anthony Vallee-Dubois authored
Bug: 1112795 Change-Id: I2bd6282c859c93ea2a193759713d2da08d2be5e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340003Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#798283}
-
Mehran Mahmoudi authored
This removes the existing uptime histogram and replaces it with multiple new histograms that are categorized by the exit cause. Format Bug: 1109991 Change-Id: I3d50585b860dafc55764929bd17bfa6c3fbb8241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349921Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#798282}
-
nancylingwang authored
Click the open with button at the browser url bar, then shutdown the system, it crashes due to access the null pointer. So add the null pointer checking to avoid the system crash. BUG=1116344 Change-Id: I4c45983f8d626eabd98a8e0f188c32255ffbe0b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353779 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#798281}
-
Egor Pasko authored
We intend to make a wider rollout/experiment of the feature to discard the code cache. No changes are expected in the lab. Update the config to confirm no effect on bots. Bug: 1045052 Change-Id: I5c0a6443f9cefac93391d957a1fcefffc72adea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356709Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#798280}
-
spdonghao authored
Bug: 1111824 Change-Id: I1b95c1c1c9f1b823e9b077cc9937d0a01f302f1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332317 Commit-Queue: Hao Dong <spdonghao@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#798279}
-
adoneria authored
Bug: 1109373 Change-Id: I012f3bc8021a7c2f7fc8a2f6349db1607aa82752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354556Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Anjali Doneria <adoneria@google.com> Cr-Commit-Position: refs/heads/master@{#798278}
-
Patrick To authored
xrEndSession should only be called in the XR_ERROR_SESSION_NOT_STOPPING per the OpenXr spec, so checking for the running state isn't necessary. Bug: 1116111 Change-Id: I089846d868441d8cd2d6d9bd82534859966d8772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357511Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Patrick To <patrto@microsoft.com> Cr-Commit-Position: refs/heads/master@{#798277}
-
Ahmed Fakhry authored
This CL fills in more impl of the capture session: - Paints the capture region according to the current selected source. - Add support for event handling. - Pressing ESC dismisses the session, while ENTER performs the capture and dismisses the session. BUG=1116137 TEST=Manual Change-Id: Ic86fd1230dea04d8d59ed19cbf7455e70d0a7795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354567Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#798276}
-
Elly Fong-Jones authored
This test asserts that closing a parent NSWindow deallocates the child NSWindow if the parent held the last reference. This is all well and good, but needs to account for AppKit's habit of autoreleasing refs to things while operating on them (eg, https://crbug.com/998773). Do this by allowing the autorelease pool to drain before checking for dealloc. Bug: 1114245 Change-Id: I46426f163b5fbdc3822ec4c4019c722cac787c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356910 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#798275}
-
Matthew Mourgos authored
Before this, sometimes the standardized icons are not given a white background circle when they appear within the shelf or launcher suggestion chips because the icons were incorrectly being detected as already circular shaped. This CL changes some of constants used for circle detection so that icons of smaller sizes are correctly detected as being non-circular. Bug: 1115812, 1113576 Change-Id: I51e04c63457bb48bb12a1898edc4e94467169362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355493Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#798274}
-
Wenbin Zhang authored
[benchmarking] disabling media.desktop/video.html?src=smpte_3840x2160_60fps_vp9.webm&seek on win-10_laptop_low_end-perf Per discussion on crbug.com/1114681#c2, disabling the story in win 10 low end laptop, using the tag win-laptop. Bug: chromium:1114681 Change-Id: I3dc6624093e8f0c93d813711b8b021ef6363f14f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355013 Auto-Submit: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#798273}
-
sczs authored
- Creates DiscoverFeedService, a BrowserState KeyedService - Creates DiscoverFeedServiceFactory to create and own DiscoverFeedServices - Initializes DiscoverFeedService in main controller. - Updates DiscoverFeedProvider interface with methods to start the Feed and update when the Identity changes. Bug: 1085419 Change-Id: Ie39653f6263915f9ef69b68d5c1e2182d15c7ab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344503Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#798272}
-
Haiyang Pan authored
As all Pixel 1s will be flashed to from NJH47F to PQ3A.190801.002 (See crbug.com/1111436#c17 for more detail), there won't be devices for android-nougat-arm64-rel Bug: 1111436, 1095778 Change-Id: Id80bb9e09ee96c743c47325a9cf99fe62c8d80af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356972 Commit-Queue: Haiyang Pan <hypan@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#798271}
-
Allen Bauer authored
Bug: 648382 Bug: 1010217 Change-Id: I1da966eb685b96832017317853c90fb3d744a491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353058 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#798270}
-
Dan Harrington authored
Bug: b/162435720 Change-Id: If23e4026e65ea28c6f78c7064dc05bb6c7cfcf86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354417 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#798269}
-
Xianzhu Wang authored
Background: transformed rasterization is used to render sharp text in a composited layer with fractional transform. It snaps the composited transform of the layer to whole pixels, then applies the fraction during rasterization. Previously we disallowed transformed rasterization in blink for directly composited layers (excluding backface-visibility:hidden and trivial 3d transforms such as translateZ(0)), especially for will-change:transform because change of fractional transform would cause re-rasterization which would defeat the purpose of will-change:transform. Now for a layer that was not eligible for transformed rasterization, calculate the initial raster translation which achieves sharp text rendering with the initial transform. When the transform of the layer changes, keep its original raster translation to avoid invalidation of tilings, to ensure animation performance. The rendered result will be blurry during animation but the initial rendering result is sharp. Remove blink-side transformed rasterization conditions and let cc decide it based on screen and draw transforms of the layers. Bug: 1111195 Change-Id: If0455be2f29e69cd7152c951626e6e8cc143b5bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351164Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#798268}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/241a4a92fb96..4c3752c7f677 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I44729297da477c5b71397cdf754dd76748d3fe4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355277Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798267}
-
cfredric authored
audioBitsPerSecond} for identifiability study. These web IDL annotations will automatically add instrumentation (using blink::Dactyloscoper) in the bindings code to record how much entropy these APIs leak about users' cross-site identity. Bug: 973801 Change-Id: I6c61c13bb5c98f65415678f000e5137d016ba55c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354153 Commit-Queue: Chris Fredrickson <cfredric@google.com> Reviewed-by:
Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#798266}
-
Sergey Ulanov authored
VideCaptureDeviceFuchsia wasn't handling sysmem buffer collection allocation failures. Fixed it to handle them properly. Also added a unittest. Bug: 1111761 Change-Id: Ic56f570dfd8826a3663c5752db15487289bff234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335651 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#798265}
-
Lindsay Pasricha authored
https://chromium.googlesource.com/external/github.com/google/EarlGrey.git/+log/a1c3b1271dcd..3f5086309f48 $ git log a1c3b1271..3f5086309 --date=short --no-merges --format='%ad %ae %s' 2020-08-10 tirodkar Fix touch injection for iOS 13.5+ device tests. 2020-08-10 tirodkar Ensure the failure handler prints the hierarchy for GREYAssertionDefines as well. 2020-08-07 albertbow Use GREYErrorMakeWithUserInfo for distant object. 2020-08-07 tirodkar Fix assertion error format when there's a single element mismatch. 2020-08-07 tirodkar GREYError cleanup of description dicts. 2020-08-06 chanheepark Override localizedDescription of GREYError to print out the whole error description. 2020-08-04 tirodkar Remove GREYScrollActionError from xcode proj. 2020-08-03 tirodkar Delete the old failure formatter. 2020-07-31 tirodkar Create new error macro for userInfo + description. 2020-07-29 tirodkar iOS 14 Keyboard support 2020-07-23 mobile-devx-github-bot Remove the #errors for tvOS, only return nil. 2020-07-23 tirodkar Moving error domains / code to GREYErrorConstants. 2020-07-22 chanheepark Add underlying error to scroll action failure. 2020-07-21 tirodkar Variable changes in GREYTimedIdlingResource. 2020-07-21 mobile-devx-github-bot Add tvOS support to AppFramework, TestLib, UILib. Created with: roll-dep src/ios/third_party/earl_grey2/src Bug: 1115121,1109205 Change-Id: I12d62cb5da31999c8294863c948aaedbd47a2de1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348536 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#798264}
-
nancylingwang authored
Sometimes, when shutdown the system, the instance could be updated, but the window might have been destroyed. Also ARC CTS might have the unusual event flow to set the task active when the window is killed. So observing all windows when update the instance could cause crash. Actually CL:2307669 added observing all windows mainly because browser tabs are not observed. So redo CL:2307669: 1. Observe browser tabs during the system init phase 2. Observe the new inserted tab To avoid crash, OnInstance checks whether the window is observed, and if not, remove the instance. BUG=1116041 BUG=1116033 b:163005244 Change-Id: Idfb675b61592176da183be092dcecff1e464ec2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355163 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#798263}
-
Jonathan Mengedoht authored
Integrate ChangePasswordUrlService in WellKnownChangePasswordNavigationThrottle to provide change password url overrides. ChangePasswordUrlService::GetChangePasswordUrl is now sync. Bug: 1086141 Change-Id: If843098ed0f384e1b118ccc91c346c7089ca226a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317191 Commit-Queue: Jonathan Mengedoht <mengedoht@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#798262}
-
Emily Stark authored
In some variants of the simplified domain field trials, we show the full URL on page load and elide to a simplified version of the domain after the user interacts with the page. Originally we considered any user interaction (as received via WebContentsObserver::DidGetUserInteraction) a trigger for elision, but then started ignoring mouse clicks in https://chromium-review.googlesource.com/c/chromium/src/+/2327289, to avoid flashing when the user clicks on links. This proved to be a bit too coarse, since we want to at least elide the URL when the user focuses a form text field. This CL thus elides the URL when WebContentsObserver::OnFocusChangedInPage() reports that an editable node has been focused. Bug: 1104280 Change-Id: Ib0b4a5b19d035c38a2e529c6f526c421f537cff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357074Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#798261}
-
Guillaume Jenkins authored
The experiment name for the Windows native spell checker integration does not match the name of the Chrome variation field trial configuration entry. This changes the name in the field trial configuration so it matches the Finch experiment name. Bug: 978460 Change-Id: If10344fd9312535b5e8c1917cf6d3c7a6a80fd7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356689 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#798260}
-