- 24 Jul, 2019 40 commits
-
-
Nick Diego Yamane authored
This CL adds event handling for XRandR |XEvent|s, re-fetching and updating display list dynamically and communicating |DisplayObserver|s about the changes. No unit tests are added due to the current dependency on XRandR/Xlib API. Bug: 891175 Test: None Change-Id: I96c5fe83fc4f1792503b34b0676b778b601d42d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709491 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#680591}
-
David Benjamin authored
This is in preparation for moving SSLConfigService lookups and other state management into SSLClientSocketContext, which will have an observer interface and such. For now, just change everything directly adjacent to where the object is created and used. Since every mention of SSLClientSocketContext is being touched anyway, take this opportunity to rename it to the short SSLClientContext, matching SSLServerContext. Bug: 951205 Change-Id: I4845f4302dd1c5a6655f4fc7bab7daf8b3ae5a95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708314Reviewed-by:
Steven Valdez <svaldez@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#680590}
-
Ben Mason authored
This reverts commit a45cf506. Reason for revert: Breaking official build. Original change's description: > Enable VR DFM conditional install for DD-ready devices > > The CL uses the new 'conditional modules' feature to auto-install the > VR DFM upon updating Chrome on supported devices. This should provide a > much better experience when launching Chrome from the DDH for the first > time on devices where the cost of having the VR DFM unused is minimal. > > This is only used on monochrome_bundle builds. > > Bug: 961796 > Change-Id: I79b095205b5dd947484738034bf50a2a0c4c8ca8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714144 > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Commit-Queue: Will Cassella <cassew@google.com> > Cr-Commit-Position: refs/heads/master@{#680060} TBR=tiborg@chromium.org,cassew@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 961796 Change-Id: I9ca741bb68f1d91c6b65e314fc2dc3c9f0cf5128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717265Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#680589}
-
Mike Dougherty authored
Increase the wait time to use standard constants for JS and UI waits. The tests previously used a custom timeout of one second which is too short to detect the change on iOS 13. Bug: 983355 Change-Id: Iec4fb542aa5fc9094651c45e7d20a4680a901570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717232 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#680588}
-
Kyle Milka authored
Bug: 987076 Change-Id: I95b263f6cd8fd970b3a90a88660a0fcf06b4b5af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717192Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#680587}
-
James Cook authored
This reverts commit b0f26697. Reason for revert: After more PM/UX discussion, we want to restore the search engine select menu in OS settings. Original change's description: > SplitSettings: Change OS search engine menu to link to browser setting > > After PM/UX discussion, we don't want to duplicate the search engine > drop-down between browser and OS settings. Instead, OS settings uses > an info label with a link to browser settings. > > Screenshots on bug: > https://bugs.chromium.org/p/chromium/issues/detail?id=960937#c7 > > Bug: 960937 > Change-Id: I622558c4c7238dc8f3d36d3a63305e7abc0f473a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640601 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#665641} TBR=jamescook@chromium.org,xiyuan@chromium.org Bug: 960937 Change-Id: I463e11f209afedc885fb07b1a12593f7450c1629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716968Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#680586}
-
Justin Cohen authored
Also fixes missing shard:1 on chromium.mac. Change-Id: If42a81850eac21afee5dd737bbd7c4030b06189a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715422 Commit-Queue: Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#680585}
-
Ken MacKay authored
Bug: internal b/137439407 Change-Id: Ia316552cfd0d884f1c55ce32603b426778f08cae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715765Reviewed-by:
Sergey Volk <servolk@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#680584}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7bf6d365. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" 6a6b173b "Add type option to showToast helper" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools hbos@chromium.org, hta@chromium.org: external/wpt/webrtc mkwst@chromium.org: external/wpt/upgrade-insecure-requests msisov@igalia.com: external/wpt/webvtt NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ief9c34fea91b2e0a0562533883905a0422c6203a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716600Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680583}
-
Peng Huang authored
This is a revert of a temporary fix https://chromium-review.googlesource.com/c/chromium/src/+/1594780 Bug: 958055 Change-Id: Ie00a41007512fef7f01492f851e96c14e5e54bc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717201Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#680582}
-
Justin Miron authored
These metric have been replaced by the new AdsPageLoadMetrics PeakWindowedPercent and have been marked obsolete in histograms.xml. This removes the population of the metric's histograms, and modifies unit/browser tests to use PeakWindowedPercent. BUG=979215 Change-Id: I6b5b4d6e57169a6571c916de8fd8faa3a1a3bdb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709977 Commit-Queue: Justin Miron <justinmiron@google.com> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#680581}
-
Mehran Mahmoudi authored
This changes the key functions In-Product Help layout. It also no longer shows the IPH for changes in cursor visibility. Bug: 983734 Change-Id: I8bffcb150e1d34a37c284db37c448c91f9f251a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716952 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#680580}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fb9acba203f7..594fe855a360 git log fb9acba203f7..594fe855a360 --date=short --no-merges --format='%ad %ae %s' 2019-07-24 halcanary@google.com gm: simplify several onName 2019-07-24 csmartdalton@google.com Add a workaround for PowerVRRogue to never disable color writes 2019-07-24 csmartdalton@google.com Add a gm for the labyrinth bug Created with: gclient setdep -r src/third_party/skia@594fe855a360 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@google.com Bug: chromium:913223 Change-Id: I0d911f0ba700198ac8529ed15957a91b7946b4f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717226Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680579}
-
Sam Goto authored
Bug: 670299 Change-Id: Ia1a4a387641c5c515537f2cc126e887f98c61be2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715768 Commit-Queue: Sam Goto <goto@chromium.org> Reviewed-by:
Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#680578}
-
Nick Diego Yamane authored
After crrev.com/c/1712955, //ui/base/x code can depend on X11EventSource directly (without causing GN circular deps), making GetTimestampForXWindow ui::XWindow::Delegate's function unneeded. So this CL removes it. Bug: 981606 Test: None (no behavior change) Change-Id: Ied47c2cd7bf0cccd45c0212d84de341145d89779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715308 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#680577}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/97321b687b38..672a48d0d2b9 git log 97321b687b38..672a48d0d2b9 --date=short --no-merges --format='%ad %ae %s' 2019-07-24 sprang@webrtc.org Add sprang@ as owner in modules/rtp_rtcp 2019-07-24 alessiob@webrtc.org Reland "Reland "Add plumbing of RtpPacketInfos to each AudioFrame as input for SourceTracker."" 2019-07-24 alessiob@webrtc.org Revert "Reland "Add plumbing of RtpPacketInfos to each AudioFrame as input for SourceTracker."" Created with: gclient setdep -r src/third_party/webrtc@672a48d0d2b9 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:982260,chromium:982260 Change-Id: I579b6cb9fae6ec594ed5ad9846c63454fca9f30a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717211Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680576}
-
Ayu Ishii authored
This change adds UMA tracking for SMSReceiver to help measure user experience of the API. Specifically, when a site calls navigator.sms.receive() this change will track the following. 1. Time from when the API is called, to when the API times out. 2. Time from when the API is called, to when the user manually cancels the call. More details on metrics and its motivation here in the API Design Doc [1]. [1] https://docs.google.com/document/d/1dB5UM9x8Ap2-bs6Xn0KnbC_B1KNLIUv4W05MunuXYh0/edit#heading=h.bbporvvwzoo7 Bug: 976332 Change-Id: Ica64097d2b759130eb349c8a37cfef2e4a303ae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713706Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#680575}
-
Jack Steinberg authored
This change allows users to show() toasts that will persist indefinitely by passing through duration: Infinity. The change also adds range boundaries to duration, so the value must be greater than 0. Bug: 985468, 972945 Change-Id: I694edab74aff7f99e770e7d37373329f5e663c99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713684 Commit-Queue: Jack Steinberg <jacksteinberg@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#680574}
-
Tommy Steimel authored
This CL adds an 8px border radius to the GMC dialog to match the specs. Bug: 982925 Change-Id: Ib72984982cbe7f5874176ef325aecfb9a80734b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716603Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#680573}
-
Emil A Eklund authored
Bug: 785230 Tbr: drott@chromium.org Change-Id: I1c258d841a667749e25f4c55bcf278da9f00a52b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717198Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#680572}
-
Simeon Anfinrud authored
This will print the keys of validators that were not properly unregistered before the DeviceCapabilitiesImpl destructor on debug builds. Bug: Internal b/138262808 Test: cast_shell_browsertests Change-Id: Ifda5d7f37844dceebc43902fabac0da86212e95a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715552Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#680571}
-
Nektarios Paisios authored
Accessibility selection returns tree positions that are adjusted taking into account ignored children. However, some ignored children are now included in the accessibility tree, and ax selection doesn't account for those. This is just a workaround to avoid crashes and unblock users from using GSuite until a re-write of the selection calculations in IA2 hypertext is undertaken using AXPosition. R=aleventhal@chromium.org Change-Id: I94287b344d0f8a6a0459ca0f769b9921a332d033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715752Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#680570}
-
Nicolas Ouellet-Payeur authored
This reverts commit d9dbade3. Reason for revert: python_script backend fails on waterfall, making the bots red (crbug/949382) Original change's description: > [Traffic Annotations] Run extractor.py on waterfall > > linux-annotator-rel and win-annotator-rel will now test traffic > annotations with extractor.py, as well as the clang tool. > > Also updates a traffic annotation in management_ui_handler.cc, since > extractor.py doesn't understand #ifdefs. As a workaround, this > CrOS-specific annotation is moved to a CrOS-only file. > > TESTED= > Ran traffic_annotation_auditor_tests.py locally, excluding the > --no-filtering configs. > > Bug: 966883 > Change-Id: I7848877f67635b50d8ce2a841019e49136a33b11 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692970 > Reviewed-by: Hector Carmona <hcarmona@chromium.org> > Reviewed-by: Ramin Halavati <rhalavati@chromium.org> > Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> > Cr-Commit-Position: refs/heads/master@{#675994} TBR=hcarmona@chromium.org,rhalavati@chromium.org,nicolaso@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 966883 Change-Id: Ic283e1ba2cd5720cfbb85553f2f1a482cbf28a20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715896Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#680569}
-
Jamie Madill authored
These are related to missing support in ANGLE. Bug: 987228 Tbr: piman@chromium.org Change-Id: I508b0bb9a27419d83520505eb39086c21764859c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715311Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#680568}
-
Doug Arnett authored
Creates and populates new UKM PreviewsDeferAllScript event to report the count of scripts force deferred in the mainframe. Bug: 978568 Change-Id: I7e7d87d0a181559832e1a4c6a1682db543790434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715109Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#680567}
-
Martin Kreichgauer authored
The Security Key settings subpage currently has a single monolithic browser proxy and associated message handler for three sets of logically independent functionality (PIN, credential management and reset). This change, splits them into three individual parts. This is a structural change only. No functional/behavior changes intended. Change-Id: Ie167ed58b4bd293764d6e784d80f922a43296551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688206 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#680566}
-
Findit authored
This reverts commit fdd7489f. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 680383 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZmRkNzQ4OWYxZjk1YTk4NDM3MWMwM2UxMThmZjE3YTQ2MGM2NTlmOAw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Mac%20ASan%2064%20Tests%20%281%29/55141 Sample Failed Step: content_browsertests Sample Flaky Test: BackForwardCacheBrowserTest.LoadingSubframeDoesNotPreventCaching Original change's description: > [bfcache] Don't cache pages that are still loading. > > To avoid the complexity of caching and restoring still-loading pages, > for now simply don't cache pages that haven't finished loading. > > Long term this logic will probably need to be extended to be more > complicated/permissive, to increase back-forward cache coverage. > > Change-Id: Ic06d9b3d425d3df95b8d09bea1561c000a96acc4 > Bug: 976697 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692414 > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Commit-Queue: Lowell Manners <lowell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#680383} Change-Id: Iedaebe0c40be92b34e2ad8d6ea650eb06044e2f2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 976697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715263 Cr-Commit-Position: refs/heads/master@{#680565}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/42937674ae09..87259987f65e Created with: gclient setdep -r src-internal@87259987f65e The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ifaff179d53a64a5448b110fec75b705d1c7e586f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717101Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680564}
-
Ella Ge authored
The test was failing in wpt because it passing non-integer value to test driver. This CL changes it to use "origin" instead. This CL rewrites the test to makes it cleaner, instead of adding event listener inside event listener. This CL also changes the test to send the "move" events after receiving pointerlockchange. Bug: 986277 Change-Id: I0f51523c3c90791339877b2e51afa8e9a4cc9d4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717195Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#680563}
-
yilkal authored
Bug: 945082, 945934 Change-Id: Ic11d227ba8de9929b6ff4803ad582346a132dd74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560466 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#680562}
-
Ce Chen authored
The instance of this class is accessed as an NoDestructor by the model component installer to notify the corresponding provider when model update is finished, to replace the current polling mechanism over DIR_ON_DEVICE_HEAD_SUGGEST in the provider. Consequently remove DIR_ON_DEVICE_HEAD_SUGGEST since it is no longer needed. May remove component updater from omnibox later if it is not needed neither. New component updater ID was previously approved in https://crrev.com/c/1710827. Tested on Nexus 5X for both new model download and pre installed model discovery. Note I cannot test on iOS, as looks like the Component needs to be registered at ios/chrome/app/main_controller.mm rather than chrome/browser/chrome_browser_main.cc for iOS (though I'm not sure what is the best way to register the component in iOS as chrome/browser/component_updater is currently not visible in ios/chrome/app/). However if I register at main_controller.mm, my dev app will crash at ComponentUnpacker::BeginUnzipping() when calling unzipper_->Unzip(...) before ComponentUnpacker::EndUnzipping(), with error http://screenshot/NqFrd299dnq and http://screenshot/g9RjyC34NaQ. Bug: 925072 Change-Id: I99f0baf2bef23a7927847d93467f4be8878931dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711030Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Ce Chen <cch@chromium.org> Cr-Commit-Position: refs/heads/master@{#680561}
-
Reilly Grant authored
This change creates a new class, BarcodeDetectorStatics, which owns the connection to BarcodeDetectionProvider. This allows it to implement the static methods on BarcodeDetector such as getSupportedFormats() without needing to create an instance of BarcodeDetector. This fixes an issue where getSupportedFormats() would reject when BarcodeDetection is unimplemented even if a successful connection to BarcodeDetectionProvider is made. It also avoids recreating the provider connection for every new BarcodeDetector. Bug: 983910 Change-Id: I7c7ea7df84f68bbed9b2bfc600852e4f4e5356cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706893 Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#680560}
-
Karan Bhatia authored
This CL marks the Extensions.DeclarativeWebRequest.WebViewRequestDeclarativeRules obsolete. We do not have any plans to do an explicit deprecation of the declarativeWebRequest API for webviews as of now. BUG=984304 Change-Id: I9eb9c92339511c295c01270d01bb74442ba56b21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716227Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#680559}
-
Sam Goto authored
Bug: 670299 Change-Id: I3aebfce7baf6e25fb07ead2a74951a051bdb91cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715915 Commit-Queue: Sam Goto <goto@chromium.org> Reviewed-by:
Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#680558}
-
Chris Hall authored
R=aboxhall,akihiroota Change-Id: Ie1cdf843655a7c0bea7fc162ffbd51b0ff53d755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682678 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Auto-Submit: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#680557}
-
rajendrant authored
This CL marks "loading" attribute support as experimental, so that WPT tests run with this attribute supported. Bug: 937986 Change-Id: I797a6e467e784c1740bdd77750f7b6a3460ca58b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700651Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#680556}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/8944f0205b04..fde94905fec0 git log 8944f0205b04..fde94905fec0 --date=short --no-merges --format='%ad %ae %s' 2019-07-24 enga@chromium.org Factor EncodingContext out of CommandEncoderBase. Created with: gclient setdep -r src/third_party/dawn@fde94905fec0 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I7a9ecca7f0564ea2e015181ffda10f8889118ac8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717093Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680555}
-
Richard Knoll authored
We want to show an illustration if there are no devices and no default apps available to choose from in the Click to Call dialog. Bug: 972059 Change-Id: I7b94662f1721f32c53278b3db2d0678824efc9ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715196Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Mitsuru Oshima (slow) <oshima@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#680554}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c8b0c582..776f729a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I89f34156535d2b3df88392478dd6f27b70e0590a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715895Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680553}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/361d65fd752e..a76f3b0bce96 git log 361d65fd752e..a76f3b0bce96 --date=short --no-merges --format='%ad %ae %s' 2019-07-24 treehugger-gerrit@google.com Merge "Demote some error logs" 2019-07-24 rsavitski@google.com Merge "traced_probes ftrace: switch back to single-threaded, nonblocking read(2)-only approach" 2019-07-24 eseckler@google.com Merge changes I5ba92202,I41f1d117 Created with: gclient setdep -r src/third_party/perfetto@a76f3b0bce96 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I0e6cae8629cfb90ede22a3c73604fa25985b42a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717092Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680552}
-