- 12 Jul, 2019 40 commits
-
-
Lei Zhang authored
We want to keep these around to keep an eye on Cloud Print stats. Bug: 970002 Change-Id: Ieaede81e06dd910d5297b7b3fecfa37897f776d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699744 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#676930}
-
Juan Antonio Navarro Perez authored
None of the subclasses use the argument, so it always gets the default value of ''. Confusingly this is only passed to the LegacyPageTest constructor, whose first and only argument is about cache clearing [1] and has nothing to do with names of actions. There was possibly an API change at some point and this only works because of a happy accident. [1]: https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry/page/legacy_page_test.py?rcl=1abe66f1c25324dc3e5c2bf84f3d5c5aed105196&l=48 Bug: 921000 Change-Id: I6fd512cf410d639f7fbca2d51db0ce801e6f2bef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699664 Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#676929}
-
W. James MacLean authored
Temporarily disable this test while we figure out why it's flaky. TBR=mpearson@chromium.org TBR=alexmos@chromium.org Bug: 959924 Change-Id: I9e9d1422b9575bb09be4eb209b8913131f0b45ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699086 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#676928}
-
Yoav Weiss authored
We suspect that for privacy reasons we may have to remove support for the onload and onerror events of link rel=prefetch. This CL adds use counters that will help us see if we should expect compatibility hurdles on that front. Change-Id: I25a72120f2ed10ab364fdd506c4c8fd1ae566f17 Bug: 983541 Change-Id: I25a72120f2ed10ab364fdd506c4c8fd1ae566f17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699674Reviewed-by:
Dominic Farolino <dom@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#676927}
-
Mohammad Refaat authored
Replaces methods of tab_test_util.h: GetCurrentTab() by GetCurrentWebState() GetNextTab() by GetNextWebState() GetTabAtIndexInCurrentMode(NSUInteger index) by GetWebStateAtIndexInCurrentMode(int index) Also with that chrome_test_util has a duplicate method GetCurrentWebState, i deleted it and replaced it usage by the one in tab_test_util.h Bug: 983291 Change-Id: I8242d5eae010ffb70d7757531906a55cac68972f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697438Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#676926}
-
rbpotter authored
When the zoom buttons are refocused with the keyboard, also ensure that the toolbar manager's keyboardNavigationActive boolean is reset to true. This value is cleared by Print Preview when focus returns to the Print Preview controls, to allow the zoom buttons to fade out. Bug: 982694 Change-Id: Ie4f9b00d48f44277271d43d415abedc51e0a3a64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695813 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#676925}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bc525d65a1f8..b99fd5d50cf8 git log bc525d65a1f8..b99fd5d50cf8 --date=short --no-merges --format='%ad %ae %s' 2019-07-12 mtklein@google.com initialize fPhase 2019-07-12 halcanary@google.com documentation/build, BUILDCONFIG: Visual Studio Build Tools 2019 2019-07-12 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-07-12 gkaiser@google.com GrGLGpu: Fix typo in 'if' check 2019-07-12 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-07-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 17462d53..5920a999 (452 commits) 2019-07-12 scroggo@google.com Reland "Update Wuffs version" 2019-07-12 mtklein@google.com bidirectional Labels 2019-07-12 borenet@google.com [infra] Update Windows bot version Created with: gclient setdep -r src/third_party/skia@b99fd5d50cf8 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@google.com Change-Id: If4880b4591d21edb9fe4bbdf2b1ede39bb99f4f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699329Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676924}
-
Adam Raine authored
A new class CompositorKeyframeColor was added to accommodate color values on the compositor. Compositor keyframe value factory will now create a CompositorKeyframeColor when the CSSValue can be casted to a CSSColorValue. Unit tests were changed to test color values on the compositor. Bug: 883721 Change-Id: I771e0ece5d546baa345d9b9aa4d49c451ee899f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695689 Commit-Queue: Adam Raine <asraine@google.com> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#676923}
-
Lei Zhang authored
Deprecate CompositeDocToPdf.Status and CompositePageToPdf.Status. The error rates are extremely low. If users are having issues with the PDF Compositor, the issues will manifest as printing bugs and users will notice and file bugs for them. Bug: 975373,975791 Change-Id: I158f1e6edd6cf39525fb606b6805e611f8da5ede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699346Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#676922}
-
Geoff Lang authored
BUG=979342 TBR=ynovikov@chromium.org Change-Id: Iabbc157ce22ab8304b373ba4e6b5a4aff45cb680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700106Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#676921}
-
Jorge Lucangeli Obes authored
I can't think of a good reason to block it and it generates a ton of logspam. BUG=None TEST=Build for soraka Chrome OS board, deploy. TEST='journalctl -g SECCOMP', no more set_robust_list(2) logs. R=mpdenton@chromium.org, rsesek@chromium.org Change-Id: I8cbfd4176ac7f1c5ef31080c910980c1ed13152b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700105 Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#676920}
-
ziyangch authored
-Used to control whether to expose "communication" device id. -Used to control whether to generate communication AudioParameters. Bug: internal: 136023597 Test: None. Change-Id: I8f855c1b1ef299517783221e2995f32c45908469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1683830 Commit-Queue: Ziyang Cheng <ziyangch@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#676919}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I89fff79db4678ba397b6e1eea38fe1274c5ee299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699332Reviewed-by:
-
Mounir Lamouri authored
Bug: 975210, 975330 Change-Id: I4251a0aed01a06b92c082ad538ef4448278de7ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691328Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#676917}
-
Alex Cooper authored
While updating the tests it was discovered that stageParameters set during the initial device/session creation weren't actually being respected or properly updated. This ensures that if stageParameters are initially set that they are appropriately updated. Bug: 983361 Change-Id: I7eb5762d074b2a3c7c808b68f5b96ffe914d145e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699247Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#676916}
-
Mehran Mahmoudi authored
Change-Id: I4d1d838d3952129b235386247151a228a90ebc46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699085Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#676915}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/93193c0ebf2f..97c4e24d49fa Created with: gclient setdep -r src-internal@97c4e24d49fa The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=wjmaclean@google.com,mpearson@google.com,hayato@google.com,pmarko@google.com Change-Id: I50f626b4d51a58de0572b0937c496dcb58548cd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699328Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676914}
-
Miyoung Shin authored
This CL replaces the use of std::unordered_set and std::unordered_map of std containers with WTF::HashSet and WTF::HashMap in scheduler/*, and removes unnecessary including <unordered_set> and <unordered_map> headers. Bug: 952716 Change-Id: I40fa847083b8883bcc5b22ae9c5d6295aaa04219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692402Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Jeremy Roman authored
Generated by: https://chromium-review.googlesource.com/c/chromium/src/+/1689216 Some existing uses of NULL are replaced with nullptr to remove presubmit errors. Bug: 981415 Change-Id: I9824a00bd16e27cf2f0e03e6c7127ffc457b56e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697372 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#676912}
-
Nicolò Mazzucato authored
Only in a debug build we can enter in the branch "content::hasWebUIScheme" (:758) if the scheme is either "chrome://" or "devtools://". Later, constructing the WebURILoader (in :772 before the patch), there is the assumption that the uri scheme is always kChromeUIScheme. This was causing me crash of devtools while I was trying to open it on a page under "devtools://devtools/...". The crash was generated by web_ui_url_loader_factory.cc:254, where `scheme_` was "chrome", while `request.url.scheme()` was "devtools" Change-Id: If02ea147d494ed64c7f7dc560095f223c11f7dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687408 Commit-Queue: Nicolò Mazzucato <nicomazz@google.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#676911}
-
David Bokan authored
The cursor locking logic doesn't gracefully handle the case where the cursor location is outside of the viewport. This leads to us locking the incorrect directions and trapping the cursor outside the viewport. This CL fixes the issue by always resetting the lock when we receive a mouse move outside the viewport. Bug: 983386 Change-Id: I33d7ab7fae0a14225663cca972dd665a9d83a4a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699258 Auto-Submit: David Bokan <bokan@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
-
Robbie Gibson authored
The comments on CL 1696967 had some changes, especially renaming the directories. However, it was submitted before uploading those changes, which are now in this new CL. Bug: 974255 Change-Id: I64c71ed15ea555df52c09805878c33f1938571dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700068Reviewed-by:
-
Xida Chen authored
This CL does some clean up to the csspaint/README.md. Some of the path to the files have changed after the Blink reformat. Bug: None Change-Id: If5f8778c1a157f64c14371d5a7477ba15506f558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699740Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#676908}
-
Mike Frysinger authored
The only reason we import the exceptions module (which doesn't exist in Python 3) is for the KeyError exception, but that's already in our global namespace. So use it directly. Bug: 983071 Test: `./grit/test_suite_all.py` passes Change-Id: I29bf4264d616f1884809ec90549ac9a8b79230a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699393Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#676907}
-
Mike Frysinger authored
Python 3 doesn't have the .iter* variants, so convert the few users over to the plain version. These files shouldn't be critical path enough to care about iterator-vs-generator difference in Python 2. Bug: 983071 Test: `./grit/test_suite_all.py` passes Change-Id: I44c9b6180120ee4bec828a04aec654c6879d7bc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699007Reviewed-by:
-
Dominic Battre authored
Bug: 975488 Change-Id: Ic1f2284b2de25241d38b2a1d264885e27f7c1e38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698533 Commit-Queue: Dominic Battré <battre@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Dominic Battré <battre@chromium.org> Reviewed-by:
-
Miguel Casas authored
ToT's VaVDA uses BufferAllocationMode::kNone for H264; in this mode both VaVDA and its client (media and graphics) pipeline shared the buffers; the amount of buffers is determined based on GetNumReferenceFrames() [1]. For small devices and/or many players, the client pipeline exhausts the allocated buffers and VaVDA enters into a busy loop which increases the power/cpu consumption (see bug for more details). This problem is specific to h264 because the amount of allocated buffers depends on the stream itself (whereas for vp8 and vp9 it's a constant). This CL fixes this regression by using BufferAllocationMode::kReduced for H264, thus limiting BufferAllocationMode::kNone for vp8 and vp9. (Ultimately the fix is to allocate buffers on demand inside VaVDA instead of relying on codec parameters, but that's the subject of the migration to VD see e.g. crrev.com/c/1619832). [1] https://cs.chromium.org/chromium/src/media/gpu/h264_decoder.cc?q=h264_decoder.cc&sq=package:chromium&dr&l=1430 Bug: 983247 Change-Id: Icd21191352e3d1c8abee2aa0818e7db38868553e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697528Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#676904}
-
Javier Ernesto Flores Robles authored
Bug: 974255 Change-Id: I347ef90bdb8be466daed846c7e7d790cc6c8da7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700062 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#676903}
-
Colin Blundell authored
As part of finalizing the code structure of IdentityManager in the codebase, this CL moves //components/signin/core/browser/webdata/ to //components/signin/public/webdata/. This change follows the structure proposed here: https://docs.google.com/document/d/1p_kahITGFgv7PehQ61-thRVR3Hrdaf3tLryMytTRPYs/edit# This change was entirely scripted. Using NOPRESUBMIT=true because an overly-aggressive check for the presence of NULL detects its presence in a string in a moved file; I don't want to change the string as part of this code move. NOPRESUBMIT=true TBR=eugenebut@chromium.org Bug: 952788 Change-Id: Id86b0248f31ebfa8efddbbebbddb7f4fda933566 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688848 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#676902}
-
Chris Lu authored
For iOS 13, the scroll position for iPad is slightly larger. This shouldn't make the test significantly more unreliable since it is just bumping it up 0.5. Bug: 983149 Change-Id: I588f9a7566959c15ea3fae492fa864a44c5e205e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697533Reviewed-by:
-
Gyuyoung Kim authored
Some files of //chrome/browser/signin have been including account_consistency_method.h even though they don't use AccountConsistencyMethod or DiceMethodGreaterOrEqual(). This CL removes all unnecessary account_consistency_method.h includes in //chorme/browser/signin. Bug: 970268 Change-Id: I5d511ca7d57ab913b770a8e87d4b1eb153abaab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699802Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#676900}
-
Daniel Bratell authored
In some non-default, extreme, jumbo builds, the kSeparator in content_index and the kSeparator in push_messaging ended up in the same translation unit which then prevented compilation. To avoid that, this patch renames them kSWRIdDescriptionSeparator and kOriginSWRIdSeparator. Bug: 973844 Change-Id: I6d29c3b1f1826613e30577870ed02612e30a368c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698521 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Auto-Submit: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#676899}
-
arthursonzogni authored
Clank Official Build Failure: ~~~ File "../../build/android/gyp/apkbuilder.py", line 383, in <module> main(sys.argv[1:]) File "../../build/android/gyp/apkbuilder.py", line 307, in main with zipfile.ZipFile(options.dex_file, 'r') as dex_zip: File "/usr/lib/python2.7/zipfile.py", line 770, in __init__ self._RealGetContents() File "/usr/lib/python2.7/zipfile.py", line 857, in _RealGetContents x._decodeExtra() File "/usr/lib/python2.7/zipfile.py", line 388, in _decodeExtra tp, ln = unpack('<HH', extra[:4]) struct.error: unpack requires a string argument of length 4 ~~~ This CL speculatively revert the CLs that seems to be linked with build failure. The bug happens while trying to zip dex file: ~~~ with zipfile.ZipFile(options.dex_file, 'r') as dex_zip: ~~~ and the following branch of CL deals with zip + dex files: Revert "dex.py: Remove obsolete flags, code clean-up." commit 35fc212e. https://chromium-review.googlesource.com/c/chromium/src/+/1694090/4 Revert "Android: Zipalign library dex files for incremental install" commit 209eac23. https://chromium-review.googlesource.com/c/chromium/src/+/1692492/6 TBR=agrieve@chromium.org Bug: 983519 Change-Id: Ia90b7f5d16b09ae29cf0617a09a80e5312ed858a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700064 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:Sam Maier <smaier@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#676898}
-
Mathias Carlen authored
We are seeing quite a few precondition failed errors in the autofill action. In order to help debug this further we are introducing two new fields in the unexpected error info proto. One field is the address map keys when the error occurred (i.e. a client memory addresses snapshot of the keys only, not their values which contain PII). A second field is what key was actually requested by the autofill action. Bug: b/136788056 Change-Id: I679456eecb81afba70b8a329823d82bd5c1fcb59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699604 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#676897}
-
Francois Doray authored
I suspect that this was caused by PageMsg being frozen. This was fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1690052. Bug: 918701, 981886 Change-Id: Ie1419b0436c932be8e41a6c735dacbf8338f21ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697137 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#676896}
-
Fernando Serboncini authored
TBR=juanmihd Bug: 983454 Change-Id: I2f0c8fac9e917ac509aa17d3d71b62e26dd8ec01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700103Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#676895}
-
Saman Sami authored
This reverts commit 6a44a630. Reason for revert: these tests are still failing on Android FYI bots. https://ci.chromium.org/p/chromium/builders/ci/Android%20FYI%20Release%20%28Nexus%205%29/19007 Original change's description: > Add viewport metadata tag to pixel video tests. > > 1. Add viewport metadata tag to the pixel video tests since they are run on > mobile devices(android). Without this tag, the webpages are not scaled > as expected according to device pixel ratio and hence was failing to match > color expectations. > > 2. This CL fixed 3 tests - Pixel_Video_MP4, > Pixel_Video_MP4_FourColors_Aspect_4x3 and Pixel_Video_MP4_FourColors_Rot_180. > > Bug: 925744 > Change-Id: I5dac913b158146f69c6b539d99fb386c3162eb8e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698981 > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: vikas soni <vikassoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#676650} TBR=zmo@chromium.org,kbr@chromium.org,vikassoni@chromium.org Change-Id: I73c25b707513ecd73e007a6942d82eb343d2fbd0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 925744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700162Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#676894}
-
Robbie Gibson authored
Bug: 976643 Change-Id: I13e7f454112ddfa9eed2779290fefd8dcaeee8a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691920Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#676893}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/80bb3116391c..25378d6a29ce git log 80bb3116391c..25378d6a29ce --date=short --no-merges --format='%ad %ae %s' 2019-07-12 ianelliott@google.com Vulkan: Split some SKIP expecations and put with correct bugs Created with: gclient setdep -r src/third_party/angle@25378d6a29ce The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Bug: None Change-Id: Ia3045c84739a8016d4f53618eb0ffc2357f325f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699994Reviewed-by:
-
Saman Sami authored
This reverts commit b9aec252. Reason for revert: GpuSwitchingToForegroundHang fails on Android FYI bots. Original change's description: > Added three more GPU watchdog tests > > These new tests covers OnBackgrounded, OnForegrounded and WillProcessTask > functions. > > Bug: 949839 > > Change-Id: I07ff5dfc168b584d26ca8f4fabc7a30b19f6e5f6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696543 > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Commit-Queue: Maggie Chen <magchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#676669} TBR=zmo@chromium.org,piman@chromium.org,magchen@chromium.org Change-Id: I4867be61c29f12c574e4df8d8414a3a69174e172 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 949839,983543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699196Reviewed-by:
-
