GitLab

For the main thread we seem to always run
v8::Isolate::RequestGarbageCollectionForTesting but it's
not the case on the worker thread, which seems to cause leaks
on the context object.

BUG=526424

Review URL: https://codereview.chromium.org/1316233004

git-svn-id: svn://svn.chromium.org/blink/trunk@201601 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Chromium's third_party/sqlite build config arranges for
third_party/sqlite to be part of the include path so that <sqlite3.h>
works in these files.  The system version of sqlite3.h can still be used
with the use_system_sqlite build override.

BUG=526828

Review URL: https://codereview.chromium.org/1317683008

git-svn-id: svn://svn.chromium.org/blink/trunk@201600 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=295792

Review URL: https://codereview.chromium.org/1300573002

git-svn-id: svn://svn.chromium.org/blink/trunk@201599 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We filed specific bugs.
Also, we confirmed form-validation-reportValidity.html just needs rebaseline.

BUG=526930,526898,526920,527262
TBR=kojii@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1305923006

git-svn-id: svn://svn.chromium.org/blink/trunk@201598 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://github.com/whatwg/xhr/issues/19

BUG=395931
R=dominicc@chromium.org

Review URL: https://codereview.chromium.org/1310543002

git-svn-id: svn://svn.chromium.org/blink/trunk@201597 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=527270,524804,527278,527281
NOTRY=true
TBR=pilgrim

Review URL: https://codereview.chromium.org/1302323007

git-svn-id: svn://svn.chromium.org/blink/trunk@201596 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves |{left,right}PositionOf()| for |VisiblePosition| to
"VisibleUnits.cpp" form "VisiblePosition.cpp" to make "VisiblePosition.cpp"
to simpler for improving code health and ease of templatizing |VisiblePosition|
class to introduce composed tree version.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1310953005

git-svn-id: svn://svn.chromium.org/blink/trunk@201595 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=521092
NOTRY=true

Review URL: https://codereview.chromium.org/1318043003

git-svn-id: svn://svn.chromium.org/blink/trunk@201594 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=
TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/1325033002 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201593 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch fixes HarfBuzzFace to round widths and bounds of glyphs
when SkPaint.isSubpixelText() is false.

SimpleFontData::platformWidthForGlyph() and platformBoundsForGlyph()
have this rounding. This difference in HarfBuzzFace caused poor text
positioning only in complex path.

Unlike SimpleFontData that uses round() for glyphBounds, this CL uses
roundOut() to avoid possible glyph rendering outside the visual
overflow rect. The same fix for SimpleFontData is in a separate CL[1].

[1] https://codereview.chromium.org/1326563003/

BUG=452914

Review URL: https://codereview.chromium.org/1316843005

git-svn-id: svn://svn.chromium.org/blink/trunk@201592 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Corresponding will* methods are declared on DOMDebugger agent already.

BUG=439376

Review URL: https://codereview.chromium.org/1327713002

git-svn-id: svn://svn.chromium.org/blink/trunk@201591 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When building the payload for POST data with files, Blink was
normalizing strings. Similar to crbug.com/427183, we're calling
normalizeAndEncode() when encode() is more appropriate, and matches
the behavior in other browsers.

BUG=341019
R=tkent@chromium.org

Review URL: https://codereview.chromium.org/1306073004

git-svn-id: svn://svn.chromium.org/blink/trunk@201590 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch implements paint offset cache as described in:
https://docs.google.com/document/d/1oY8P7a7G4W2LYOvT3VyqUNKOOek6S_e-jD2XjM_7g9U/view

This patch is large but only a few new concepts have been added:
1) A LayoutPoint for paint offset is now passed into all layout drawing
recorders.
2) The display item list temporarily stores the previous paint offsets.
These will be moved onto the LayoutObject themselves once
https://codereview.chromium.org/1315213002 lands.
3) If a new paint offset is detected during paint, the recorded offset is
updated and the layout object is marked as invalid in the display list.
4) Asserts have been added that paint offsets do not change between
phases. DisplayItemList::m_clientsWithPaintOffsetInvalidations checks
for emitting cached display items after the paint offset was invalidated.
DisplayItemList::invalidatePaintOffset checks for existing non-cached
display items added before the paint offset was invalidated.

BUG=508383

Review URL: https://codereview.chromium.org/1315993004

git-svn-id: svn://svn.chromium.org/blink/trunk@201589 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/1324943004

git-svn-id: svn://svn.chromium.org/blink/trunk@201588 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=509482

Review URL: https://codereview.chromium.org/1323913002

git-svn-id: svn://svn.chromium.org/blink/trunk@201587 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=524758
TBR=dpranke@chromium.org

Review URL: https://codereview.chromium.org/1320253003

git-svn-id: svn://svn.chromium.org/blink/trunk@201586 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=525930
TEST=conformance2/rendering/draw_buffers.html
R=bajones@chromium.org,kbr@chromium.org

Review URL: https://codereview.chromium.org/1315193013

git-svn-id: svn://svn.chromium.org/blink/trunk@201585 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Added some function-level documentation to:
- createObject
- willBeDestroyed
- virtualChildren

Those help explain some design decision of what they
are used for.

While documenting createObject, added a missing
ASSERT_NOT_REACHED to the implementation to state
our assumption clearly.

Review URL: https://codereview.chromium.org/1320373003

git-svn-id: svn://svn.chromium.org/blink/trunk@201584 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch causes rotate to use numerical interpolation when either from or to angle is 0deg.

The axis of rotation used will be the axis that has a non-zero angle. If both from and to axis are both zero, then the default (0, 0, 1) axis is used.

Patch by soonm@google.com

BUG=516577

Review URL: https://codereview.chromium.org/1322843002

git-svn-id: svn://svn.chromium.org/blink/trunk@201583 bbb929c8-8fbe-4397-9dbb-9b2b20218538

remove the old stuff.

This is a final installment in the series:
1) https://codereview.chromium.org/1318283003
2) https://codereview.chromium.org/1319073003.

BUG=521149
R=esprehn,dcheng

Review URL: https://codereview.chromium.org/1316233007

git-svn-id: svn://svn.chromium.org/blink/trunk@201582 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=526332

Review URL: https://codereview.chromium.org/1312903005

git-svn-id: svn://svn.chromium.org/blink/trunk@201581 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=526743,522622
TEST=webkit_unit_tests

Review URL: https://codereview.chromium.org/1311433008

git-svn-id: svn://svn.chromium.org/blink/trunk@201580 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201554

BUG=521764
TBR=schenney@chromium.org

Review URL: https://codereview.chromium.org/1312893009 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201579 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=526768

Review URL: https://codereview.chromium.org/1308213007

git-svn-id: svn://svn.chromium.org/blink/trunk@201578 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Tooltips should be used where they add value to the the user. This change removes instances where tooltips are used with the same text as is already displayed.

BUG=513066

Review URL: https://codereview.chromium.org/1262063003

git-svn-id: svn://svn.chromium.org/blink/trunk@201577 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=520259

Review URL: https://codereview.chromium.org/1311693004

git-svn-id: svn://svn.chromium.org/blink/trunk@201576 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/1322053002

git-svn-id: svn://svn.chromium.org/blink/trunk@201575 bbb929c8-8fbe-4397-9dbb-9b2b20218538

At least on windows dbg and linux dbg, mediasource-duration.html has
started crashing since I landed the removal of short-circuiting
redundant seeks to same time in Chromium yesterday
(https://crrev.com/a609797f).

BUG=527152
TBR=philipj@opera.com
TEST=http/tests/media/media-source/mediasource-duration.html

Review URL: https://codereview.chromium.org/1308063006

git-svn-id: svn://svn.chromium.org/blink/trunk@201574 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Overlay was sized to visible size, but it is not scaled together with the page.
Therefore, the correct size is equal to viewport size.

BUG=508136

Review URL: https://codereview.chromium.org/1327503002

git-svn-id: svn://svn.chromium.org/blink/trunk@201573 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Following Blink r201401, a plugin element's persisted plugin will be
cleared out upon the plugin element being removed from the tree or being
re-attached and there being no layout object. With Oilpan, this may
bring about disposal of the underlying plugin.

A disposed persisted plugin is consequently observable if subsequently
try to return the plugin wrapper object for the plugin element -- add
the required check so as to handle this properly.

R=haraken
BUG=526999

Review URL: https://codereview.chromium.org/1326603002

git-svn-id: svn://svn.chromium.org/blink/trunk@201572 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/1325833007

git-svn-id: svn://svn.chromium.org/blink/trunk@201571 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=vmpstr@chromium.org
BUG=525286
TEST=fast/hidpi/image-srcset-intrinsic-size-zero.html

Review URL: https://codereview.chromium.org/1326723002

git-svn-id: svn://svn.chromium.org/blink/trunk@201570 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This should not matter in regular case, as the Page, DatabaseClient and
InspectorDatabaseAgent all have the same lifetime.
But it looks like we can have DevTools initialized twice for the page in OOPIF case.

BUG=526162

Review URL: https://codereview.chromium.org/1323443004

git-svn-id: svn://svn.chromium.org/blink/trunk@201569 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The crash occurs because longpress may cause script to run (blur, focus event
handles) which  may detach the frame. To prevent crashing we protect FrameView
while handling the longpress event and also guard against |frame->settings()|
being NULL which happens when frame detaches.


BUG=519905

Review URL: https://codereview.chromium.org/1315983004

git-svn-id: svn://svn.chromium.org/blink/trunk@201568 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There was no explanation about LayoutBlock acting as the
concept of containing block. While at it, documented some
design decisions around the positioned descendant map.

Review URL: https://codereview.chromium.org/1304953005

git-svn-id: svn://svn.chromium.org/blink/trunk@201566 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add a new type of paint invalidation test for slimming paint v2.

- They are reftests, to check the correctness of painted result;
- Tracks paint invalidation objects and checks them against expected
  list.

This CL converts two paint/invalidation tests into the new style.

Will convert some fast/repaint and compositing/repaint tests into this
style for spv2 after this CL. The original tests are not suitable for
spv2 because
- it's hard to determine if a test is actually failing or needs
  rebaseline for spv2;
- they don't cover correctness of paint results.

BUG=524134

Review URL: https://codereview.chromium.org/1324763002

git-svn-id: svn://svn.chromium.org/blink/trunk@201565 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The chromium-side fix in https://crrev.com/a609797f appears to have
fixed the flakiness of this test, per the dashboard. This change removes
the flakiness expectation so we can now catch regressions impacting this
test in the future.

TBR=philipj@opera.com
BUG=526337, 399523, 303419, 284782, 266631
TEST=http/tests/media/media-source/mediasource-duration.html

Review URL: https://codereview.chromium.org/1325823005

git-svn-id: svn://svn.chromium.org/blink/trunk@201564 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We would like to be able to prioritize loading tasks, but in order to
do that we need to make sure loading tasks are posted to the right queue
to make sure tasks run in the expected order.  If this task is posted as
a timer, and loading tasks are prioritzed, it's possible
FrameHostMsg_DidStopLoading will be sent before the corresponding
FrameHostMsg_DidStartLoading ipc which causes various browser tests to
break.

BUG=497761,510398

Review URL: https://codereview.chromium.org/1312353004

git-svn-id: svn://svn.chromium.org/blink/trunk@201563 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Changed instrumentation-service-worker.js so the value NaN can be copied properly in cloneNotification.
- Added testing of NaN and null in serviceworker-notificationclick-event-data-reflection.html

BUG=525652

Review URL: https://codereview.chromium.org/1311413006

git-svn-id: svn://svn.chromium.org/blink/trunk@201562 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Uncontrolled window clients should now be allowed to register one-shot
background sync events, as long as they have a registered service worker.
This patch removes the old test (which expected exactly the opposite
behaviour.) Part 3 changes the behaviour in Chromium, and a new layout test for
the correct behaviour is added in part 4.

This is part 2 of a now-four-part blink-chromium-blink dance.
Part 1: https://codereview.chromium.org/1309393003
Part 2: https://codereview.chromium.org/1324903002 (this patch)
Part 3: https://codereview.chromium.org/1316743002
Part 4: https://codereview.chromium.org/1314453003

BUG=5188884

Review URL: https://codereview.chromium.org/1324903002

git-svn-id: svn://svn.chromium.org/blink/trunk@201561 bbb929c8-8fbe-4397-9dbb-9b2b20218538