GitLab

The Window Service operates in pixels. Any translations in the
transform need to be scaled by the dsf.

Based on sky@'s CL: http://crrev.com/c/966498 (copied in patch set 1)
This CL keeps existing scaling, etc. (SetTranslate first clears to identity).
(the original CL doesn't fix clicks on the overview window previews)

BUG=822917
TEST=chrome --enable-features=Mus --force-device-scale-factor=2 overview (F5) mouse hover/click works well

Change-Id: I1031d0a66dd5b014656ef974d382293e0da52906
Reviewed-on: https://chromium-review.googlesource.com/969072
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544386}

Change-Id: I93102ac63ae73770f0012a6a0b2c92030ad8b83e
Reviewed-on: https://chromium-review.googlesource.com/970244Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544385}

This CL adds account picker to the streamlined sign-in screen. It will
be wired up by subsequent CLs. RelativeLayout is used to avoid using
nested LinearLayouts and minimize the depth of the layout. Strings in
grd file are currently marked as not translateable as they haven't been
confirmed by the UI team yet.
This CL also adds initialization for ConsentTextTracker in
SigninFragmentBase.

Bug: 814728
Change-Id: I60ae3841998d5dd9c13d35583915e7fe443d3b31
Reviewed-on: https://chromium-review.googlesource.com/966902
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544384}

This CL changes the frame for the bounds, as a follow up for the
creation CL.

Bug: none
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ic1cea75158aac141c11807d82a2c910dbf792cea
Reviewed-on: https://chromium-review.googlesource.com/970476Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544383}

Bug: 820361
Change-Id: I1996da98a7b1d750f33f702a8251b46e566f900d
Reviewed-on: https://chromium-review.googlesource.com/969097
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544382}

BUG=794920
TBR=rsesek@chromium.org

Change-Id: I3ea15492e4f08a0879fdd0c5476a09bcf5db6836
Reviewed-on: https://chromium-review.googlesource.com/970477Reviewed-by: Alexander Potapenko <glider@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Alexander Potapenko <glider@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544381}

Bug: 782270
Change-Id: Idbc5696044aec4da0efed8c6f30f867e1b335fb9
Reviewed-on: https://chromium-review.googlesource.com/969605
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544380}

No production code is calling U2fDiscovery::Stop, and all observer
method implementations are no-ops.

Similarly, no U2fDiscovery has more than a single observer added, and
the only time that observer is removed is when both the discovery and
that observer (the owner) dies.

It sounds like we are not going to make use of this functionality in the
near future, so this CL removes:
 -- the ability to Stop() U2fDiscoveries, and
 -- the ability to have more than a single Observer per U2fDiscovery.

The CL also moves slightly more functionality into the U2fDiscovery base
class from derived classes, most importantly with the goal of making
sure the fake and production implementations function consistently in
the following areas:
 -- U2fDiscovery now keeps track of whether Start NotifyDiscoveryStarted
    have been called, and exposes corresponding getters.
 -- It is now enforced that Start() and NotifyDiscoveryStarted() can
    be called once each, and in this order, as well as that
    NotifyDeviceAdded cannot be called before Start() is called.
 -- It is now enforced that Observer::DiscoveryStarted is never invoked
    synchronously while Start() is still on the call stack.

Bug: 822244, 823686
Change-Id: Ia029646d43481a1a2ca58452577727f96d6aade1
Reviewed-on: https://chromium-review.googlesource.com/964301
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544379}

Adds new articles header view with a toggle button and
update logic to honor prefs::kArticlesListVisible.

Bug: 805638
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I882cb19c9dd1bf6c1c6d232dab0413e01835a402
Reviewed-on: https://chromium-review.googlesource.com/964993Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544378}

Also eliminate a few copies in TranslateTransformOperation::Blend.

Change-Id: Icb390e3da70e2c3b651c34758f8e0fefa7bb4484
Reviewed-on: https://chromium-review.googlesource.com/970821Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#544377}

Bug: 819848
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If57780e21ca7a865bb6d0318d3809db916c7db28
Reviewed-on: https://chromium-review.googlesource.com/969705Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544376}

A followup will hook this pref with a new enterprise policy to turn the
feature off.

Bug: 823700
Change-Id: I06096460a372941ba06f3bf3e9cc63b9084f82cd
Reviewed-on: https://chromium-review.googlesource.com/970729Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544375}

Using wpt-import in Chromium 86ab60eb.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/14253

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=kereliuk

No-Export: true
Change-Id: I5689b096bd9391d91b2e7dafbdf75f3c95734989
Reviewed-on: https://chromium-review.googlesource.com/970842
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544374}

https://skia.googlesource.com/skia.git/+log/ec77963bf32e..0060c3394c6b

$ git log ec77963bf..0060c3394 --date=short --no-merges --format='%ad %ae %s'
2018-03-19 joe [lottiecap] Moved over from buildbot repo.

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=jvanverth@chromium.org

Change-Id: Iece4b08b33d9a51ac98192a9d01b1c6d2e7f7c9a
Reviewed-on: https://chromium-review.googlesource.com/970727
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#544373}

https://chromium.googlesource.com/angle/angle.git/+log/aa5d883e0215..b391ec40837c

$ git log aa5d883e0..b391ec408 --date=short --no-merges --format='%ad %ae %s'
2018-03-12 oetuaho Generate code for looking up built-ins

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=jmadill@chromium.org

Change-Id: Ie1b40e2112a9b13f9fbaa4285c0be51819fbee03
Reviewed-on: https://chromium-review.googlesource.com/970481Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#544372}

Construction order is always base before derived, so having a default
implementation allows us to get around trying to call a pure virtual method
before it is set up.

This is orthogonal to the problem of whether the object is fully initialized
which will be added later to the loop that drains the marking stack.

The current implementation handles
- Draining at the event loop (which is a safepoint).
- Conservative GCs which are free to ignore the object if it is still
  under construction.

Bug: chromium:757440
Change-Id: Ib1f16fa80f99ac53b369bc184d42f947e58d2723
Reviewed-on: https://chromium-review.googlesource.com/949464
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544371}

This CL changes the ownership of base::Clock and base::TickClock from
injectee-owned to injecter-owned. Before this CL, these instances are
owned by the owner of the injectee or one of the injectees themselves.
That makes the ownership handling complex.

After this CL, the injectee of clocks never own the clock. Instead,
injecters owns a clock for testing, and a shared clock is used on the
production code.

Bug: 789079
Change-Id: I98eabd76f378c15bccf637c3d6748c2a2aba417e
Reviewed-on: https://chromium-review.googlesource.com/956167
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544370}

Make RendererScheduler aware of tasks which are run after frame has been
detached.

As there is no TaskQueue reference at this point (only TaskQueueImpl),
nullptr is passed to MetricsHelper. This patch ensures that
MetricsHelper supports that.

R=alexclarke@chromium.org,farahcharab@chromium.org

Change-Id: Id9b7f0efe6f384bf57b56420ff63382729e191a2
Reviewed-on: https://chromium-review.googlesource.com/970802
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544369}

In order to proceed the rollout for the password search feature in
http://cl/189730122, add the test group to the field trial config.

Change-Id: I281c4908826fee3247a66a29f94699044c9ec03e
Reviewed-on: https://chromium-review.googlesource.com/970344Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544368}

This CL adds a gesture recognizer delegate for the popup menu. It allows
the gesture to be sent to other gesture recognizers when the tap occurs
inside the container.
In particular, it will allow the content of the menu to receive the
gesture.

Bug: 822703
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4773824e7b7c4b5d1ea0713df34e87a10a9a40ee
Reviewed-on: https://chromium-review.googlesource.com/965068
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544367}

These tests are causing data races due to incorrect use of
base::FeatureList.

BUG=823713
TBR=nasko@chromium.org

Change-Id: Ia15c5fa8e067af17dfbe2e2de9f6489688f188ce
Reviewed-on: https://chromium-review.googlesource.com/970654Reviewed-by: Alexander Potapenko <glider@chromium.org>
Commit-Queue: Alexander Potapenko <glider@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544366}

This CL creates a table view used to display the elements of the popup
menus and the items to be presented by this table view.
It also creates the mediator used to create and manage the items.

Bug: 804770
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Icc861cc1d8d2c37bdc3d5dc70f2b072d657dd721
Reviewed-on: https://chromium-review.googlesource.com/966201
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544365}

https://swiftshader.googlesource.com/SwiftShader.git/+log/a124f04..f120c92

BUG=

TBR=kbr@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel,linux_chromium_cfi_rel_ng;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Change-Id: I6aef79f9df30f5c2c951d1dbeeab198512eea558
Reviewed-on: https://chromium-review.googlesource.com/970562Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544364}

In order to delete navigations, recents tabs and session entries,
a service needs to listen to history deletions and remove
this data when required. Because history deletions can not only be
triggered by UI but also by extensions, the listener should be created
at startup. Because ChromeBrowsingDataDelegate is not that small
and has a few other dependencies, a separate service in browsing_data/
is created.

Bug: 407074
Change-Id: If068023967d502ba663473d13ec7844d70e7ca14
Reviewed-on: https://chromium-review.googlesource.com/962762
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544363}

SurfaceTreeHost::UpdateHostWindowBounds() used to call
ui::Layer::SetFillsBoundsOpaquely() directly. With this CL, the method
is called through aura::Window::SetTransparent(). This is equivalent,
except that the |transparent_| bit of the aura::Window, on which
aura::WindowOcclusionTracker depends, is also updated.

This CL also adds a ScopedPauseOcclusionTracking instance to ensure
that occlusion isn't recomputed multiple times during a call to
SurfaceTreeHost::UpdateHostWindowBounds().

Bug: 668690
Change-Id: I4f6181d4e247f2a54d96569b3379964c9253246a
Reviewed-on: https://chromium-review.googlesource.com/970746Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544362}

Shrinks the apk size by another 12kb.

Bug: 742525
Change-Id: I97e889cca1adb52da69490c57094565121d0b52a
Reviewed-on: https://chromium-review.googlesource.com/970083
Commit-Queue: Richard Coles <torne@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544361}

This moves the high MEI bit from Document to Page.

BUG=821372

Change-Id: I51ba39c7251a9c511cab29db028e6f6bf7167124
Reviewed-on: https://chromium-review.googlesource.com/964526
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544360}

Bug: 813520
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I3f5b734202c69346c4681c11a40ebb58922f7e64
Reviewed-on: https://chromium-review.googlesource.com/969587Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544359}

These tests assume window closure via views::Widget::Close() is synchronous,
which is not guaranteed to be the case. Spinning the runloop allows async
window closure to happen properly in these tests, which fixes them for MacViews.

Bug: 817408
Change-Id: Ic2d0443283a46573631a628cf57d077514674326
Reviewed-on: https://chromium-review.googlesource.com/970725Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544358}

It is not necessary to disable web usage when clearing
off-the-record browsing data (as the WebKit bug is not
exercised in that case).

Bug: 821753
Change-Id: I62b011ac182f8e8b7107109a23ac8102da44e574
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/970466
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544357}

This adds std::move() around base::Callback instances where it looks
relevant, by applying `base_bind_rewriters -rewriter=add_std_move`.
https://crrev.com/c/970143, plus manual fixes.

Example:
  // Before:
  void set_callback(base::Closure cb) { g_cb = cb; }
  void RunCallback(base::Callback<void(int)> cb) { cb.Run(42); }
  void Post() {
    base::Closure task = base::Bind(&Foo);
    PostTask(FROM_HERE, task);
  }

  // After:
  void set_callback(base::Closure cb) { g_cb = std::move(cb); }
  void RunCallback(base::Callback<void(int)> cb) { std::move(cb).Run(42); }
  void Post() {
    base::Closure task = base::Bind(&Foo);
    PostTask(FROM_HERE, std::move(task));
  }

Specifically, it inserts std::move() if:
 - it's a pass-by-value parameter or non-const local variable.
 - the occurrence is the latest in its control flow.
 - no pointer is taken for the variable.
 - no capturing lambda exists for the variable.

Change-Id: I53853f9b9c8604994e2065af66ed4607af9c12ed
Reviewed-on: https://chromium-review.googlesource.com/970056Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544356}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/8ac76771..e57b381c

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: If9be0dc42c638ecf4a79c6b5450c3cd59cad72d6
Reviewed-on: https://chromium-review.googlesource.com/970724Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544355}

These tests are testing behavior of LocationBarView, which is only used when
there is a BrowserView, so testing them with a BrowserWindowCocoa doesn't work.

Bug: 817408
Change-Id: Ic0d4f2cd072d4561c0f7df2c881e9df3b65a7354
Reviewed-on: https://chromium-review.googlesource.com/970743Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544354}

Adds a test for detached requests with cross-origin server-side
redirects. Checks that both the initial and the following origin can set
cookies.

Bug: 816837
Change-Id: I98fd6ac0b617de20dfe2e074ddcbd80bb94e4bb4
Reviewed-on: https://chromium-review.googlesource.com/970643
Commit-Queue: Benoit L <lizeb@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544353}

This was accidentally deleted in crrev.com/c/575716.

Bug: 797809
Change-Id: I360915247c8fc093beed2426b760ec680cd50ccb
Reviewed-on: https://chromium-review.googlesource.com/949977Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544352}

Digital Asset Link verification consists of two parts, verifying the
link from the app to the website and verifying the link from the
website to the app. The first part is done client side and a developer
can easily satisfy this by putting a line in their app's manifest.
The second part is done server side and thus a developer cannot create
a link between their app and a locally running web server for
development.

This CL adds a command line Chrome flag that disables the server-side
check allowing developers to use trusted web activity on locally
hosted websites.

Change-Id: I47a00ec45e5016ef398e876c1b35be680b2284f8
Reviewed-on: https://chromium-review.googlesource.com/883467
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544351}

This CL extracts ConsentTextTracker from AccountSigninView and
implements consent recording in SigninFragmentBase by using
ConsentTextTracker.

Bug: 814728
Change-Id: I7c699e63bea7a2c61244e72956d4774d46d79556
Reviewed-on: https://chromium-review.googlesource.com/964841Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544350}

This is a purely cosmetic change, bring the order of the private
methods in line with the public ones. (The order of the public methods
was changed by a previous CL that made some of the methods virtual.)

Bug: 775415
Change-Id: I978cc34bc1ac6ffa579608030de3ac1343f7eb92
Reviewed-on: https://chromium-review.googlesource.com/966905Reviewed-by: Tommi <tommi@chromium.org>
Commit-Queue: Elad Alon <eladalon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544349}

chrome/android/java/src/PRESUBMIT.py currently contains one test:
checking for bad use of Notification.Builder.

This CL improves that test in two ways:
 * It makes it ignore the forbidden pattern in comments.
 * It adds a test for the presubmit check.

Bug: 821981
Change-Id: I5e2e362ed2168e479b446eccdca11e76a95e9e85
Reviewed-on: https://chromium-review.googlesource.com/966626
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544348}

https://webrtc.googlesource.com/src.git/+log/d2c8332e2b03..9047dac7576d

$ git log d2c8332e2..9047dac75 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=chromium:None,chromium:None,chromium:None,chromium:822799,chromium:680172,chromium:None,chromium:755660,chromium:None,chromium:None,chromium:None,chromium:755660


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ia063873eca78ba81cec927cf4374423586bb338f
Reviewed-on: https://chromium-review.googlesource.com/970723
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#544347}