GitLab

Notificaiton center now fires a focus event on a view that has no role (i.e. a client node). Allow for this so that we pick up on the window ax obj's name "notification center" and override client output to be $name (avoiding the role which provides no value).

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
BUG=643995
TEST=alt+shift+n

Review-Url: https://codereview.chromium.org/2383103003
Cr-Commit-Position: refs/heads/master@{#422607}

BUG=563793

Review-Url: https://codereview.chromium.org/2389973004
Cr-Commit-Position: refs/heads/master@{#422606}

It is possible to only have some of the image downloaded and attempt to
display an animation frame at the end. When this happens, we would purge
important frames.

BUG=652046

Review-Url: https://codereview.chromium.org/2382143004
Cr-Commit-Position: refs/heads/master@{#422605}

https://chromium.googlesource.com/chromium/src/+/cfa4d68b0

BUG=640256
TBR=malaykeshav@chromium.org

Review URL: https://codereview.chromium.org/2391533004 .

Cr-Commit-Position: refs/heads/master@{#422604}

Revert of cc/blimp: Add a LayerTreeHostRemote implementation. (patchset #16 id:300001 of https://codereview.chromium.org/2362073002/ )

Reason for revert:
cc_unittests on Mac-10.9 failing on chromium.mac/Mac10.9 Tests (dbg)
BUG=652502

BeginFrameArgsTest.Helpers (run #1):
[ RUN      ] BeginFrameArgsTest.Helpers
../../cc/output/begin_frame_args_unittest.cc:66: Failure
Value of: ::testing::PrintToString(args1)
  Actual: "64-byte object <B6-66 E8-02 01-00 00-00 F6-73 E8-02 01-00 00-00 16-00 00-00 A9-7F 00-00 E1-9C BD-01 01-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 FF-FF FF-FF FF-FF FF-FF 01-00 00-00 01-7F 00-00>"
Expected: std::string("BeginFrameArgs(NORMAL, 0, 0, -1us)")
Which is: "BeginFrameArgs(NORMAL, 0, 0, -1us)"
../../cc/output/begin_frame_args_unittest.cc:68: Failure
Value of: ::testing::PrintToString(args2)
  Actual: "64-byte object <B6-66 E8-02 01-00 00-00 F6-73 E8-02 01-00 00-00 1A-00 00-00 01-00 00-00 3B-9F BD-01 01-00 00-00 01-00 00-00 00-00 00-00 02-00 00-00 00-00 00-00 03-00 00-00 00-00 00-00 01-00 00-00 01-7F 00-00>"
Expected: std::string("BeginFrameArgs(NORMAL, 1, 2, 3us)")
Which is: "BeginFrameArgs(NORMAL, 1, 2, 3us)"
[  FAILED  ] BeginFrameArgsTest.Helpers (1 ms)

Original issue's description:
> cc/blimp: Add a LayerTreeHostRemote implementation.
>
> This sets up the framework for a LayerTreeHostRemote that implements
> the LayerTreeHost API when the compositor is running across a network
> boundary.
>
> This change only sets the framework for running/scheduling main frame
> updates and pushing the serialized state using the
> CompositorProtoStateSink. Subsequent patches will add state
> serialization.
>
> BUG=648442
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
>
> Committed: https://crrev.com/8d31bac41bbabd01f14eff89f0fc37cd9016c225
> Cr-Commit-Position: refs/heads/master@{#422555}

TBR=wez@chromium.org,dtrainor@chromium.org,danakj@chromium.org,khushalsagar@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=648442

Review-Url: https://codereview.chromium.org/2384333002
Cr-Commit-Position: refs/heads/master@{#422603}

https://chromium.googlesource.com/chromium/src/+/5556b4bf5

BUG=637264
TBR=malaykeshav@chromium.org

Review URL: https://codereview.chromium.org/2392783002 .

Cr-Commit-Position: refs/heads/master@{#422602}

Revert of bluetooth: Add device list retrieval for chrome://bluetooth-internals (patchset #16 id:280001 of https://codereview.chromium.org/2357383002/ )

Reason for revert:
generate_build_files failing on chromium.chrome/Google Chrome Win

BUG=652494

C:\b\c\b\win_chrome\src\buildtools\win\gn.exe gen //out/Release --check
  -> returned 1
ERROR at //build/split_static_library.gni:27:7: Dependency not allowed.
      static_library(current_name) {
      ^-----------------------------
The item //chrome/browser/ui:ui_0
can not depend on //device/bluetooth/public/interfaces:experimental_interfaces
because it is not in //device/bluetooth/public/interfaces:experimental_interfaces's visibility list: [
  //device/bluetooth:mojo
  //chrome/browser:browser
  //chrome/browser/ui:ui
]

GN gen failed: 1
step returned non-zero exit code: 1
@@@STEP_FAILURE@@@

Original issue's description:
> bluetooth: Add device list retrieval for chrome://bluetooth-internals
>
> Changes WebUI setup to a MojoWebUI for chrome://bluetooth-internals page.
> Adds mojom files for Bluetooth service definition and internals page handler.
> Adds basic Bluetooth device retrieval using starter Bluetooth service
> implementation for logging on web front end.
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
> BUG=651282
>
> Committed: https://crrev.com/e619ab633a89f1c845f5fdd7584344a5914b30a9
> Cr-Commit-Position: refs/heads/master@{#422570}

TBR=dpapad@chromium.org,dcheng@chromium.org,ortuno@chromium.org,scheib@chromium.org,mbrunson@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=651282

Review-Url: https://codereview.chromium.org/2389053002
Cr-Commit-Position: refs/heads/master@{#422601}

BUG=chromium:632933
R=lushnikov@chromium.org

Review-Url: https://codereview.chromium.org/2380413002
Cr-Commit-Position: refs/heads/master@{#422600}

Revert of mus: Use TooltipManagerAura in NativeWidgetMus. (patchset #9 id:160001 of https://codereview.chromium.org/2379073003/ )

Reason for revert:
sky@ reports that TooltipControllerCaptureTest.Capture is failing on local chromeos builds.

Original issue's description:
> mus: Use TooltipManagerAura in NativeWidgetMus.
>
> mash now shows tooltips on hover over items.
>
> BUG=599558
>
> Committed: https://crrev.com/1b3d5f1878974c14c21a29a13a93ef630c74d1f6
> Cr-Commit-Position: refs/heads/master@{#422562}

TBR=sky@chromium.org,jonross@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=599558

Review-Url: https://codereview.chromium.org/2384083005
Cr-Commit-Position: refs/heads/master@{#422599}

BUG=563793

Review-Url: https://codereview.chromium.org/2388983002
Cr-Commit-Position: refs/heads/master@{#422598}

https://chromium.googlesource.com/chromium/src/+/9dbb17e17

BUG=645938
TBR=robhogan@gmail.com

Review URL: https://codereview.chromium.org/2391643003 .

Cr-Commit-Position: refs/heads/master@{#422597}

The current EME spec has added defaults for some fields in
MediaKeySystemConfiguration, so update the code to specify
the defaults and match the latest algorithm.

As well, at least one of 'audioCapabilities' or 'videoCapabilities'
should be specified, so add a UseCounter if none are provided to
help determine when this can be enforced in the future.

Also update some of the EME tests to provide either
'audioCapabilities' or 'videoCapabilities' (or both)
when calling requestMediaKeySystemAccess().

BUG=616233
TEST=EME tests pass

Review-Url: https://codereview.chromium.org/2349813002
Cr-Commit-Position: refs/heads/master@{#422596}

Revert of cc: Remove frame queuing from the scheduler. (patchset #14 id:400001 of https://codereview.chromium.org/2339633003/ )

Reason for revert:
Highly likely that this is causing the flakes we are seeing in http://crbug.com/645736

Original issue's description:
> Reland of cc: Remove frame queuing from the scheduler. (patchset #1 id:1 of https://codereview.chromium.org/2336493002/ )
>
> Reason for revert:
> Reland after fixing screenshot grabber test and perf issues.
>
> Original issue's description:
> > Revert of cc: Remove frame queuing from the scheduler. (patchset #3 id:40001 of https://codereview.chromium.org/2323063004/ )
> >
> > Reason for revert:
> > Broke ChromeScreenshotGrabberTest.TakeScreenshot on  Linux ChromiumOS Tests (dbg)(1): https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/18015.
> >
> > Original issue's description:
> > > cc: Remove frame queuing from the scheduler.
> > >
> > > CC scheduler has a frame queuing mechanism called "retro frames". This
> > > has been responsible for a lot of complexity and hard to fix bugs. The
> > > original intent for adding retro frames was to allow the scheduler to
> > > handle multiple frames in flight but that goal doesn't seem feasible or
> > > even desirable any more. This CL removes the retro frames queue and
> > > instead makes the Scheduler end the previous frame when it receives a
> > > BeginFrame message.
> > >
> > > One surprising behavior was that SyntheticBFS MISSED frames would be
> > > queued as retro frames and this would convert the synchronous begin
> > > frame call (inside Scheduler::ProcessScheduledActions) to an
> > > asynchronous retro frame PostTask. To work around this the Scheduler
> > > keeps track of a single CancelableClosure that's used for MISSED frames.
> > >
> > > The above behavior was also causing the BeginFramesNotFromClient tests
> > > to work even though there was an extra MISSED frame in the queue. This
> > > is more elegantly solved in another way by using frame number to advance
> > > the task runner instead of just running pending tasks.
> > >
> > > Lastly SchedulerStateMachine is modified so that it's possible to end
> > > the previous frame and still have the same behavior as before in the
> > > commit to active tree (browser compositor) mode.
> > >
> > > R=brianderson@chromium.org,enne@chromium.org,danakj@chromium.org
> > > BUG=602485, 644992
> > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
> > >
> > > Committed: https://crrev.com/559280b26cc5672f5f054e8ac35281e804c14d78
> > > Cr-Commit-Position: refs/heads/master@{#417764}
> >
> > TBR=enne@chromium.org,brianderson@chromium.org,danakj@chromium.org,sunnyps@chromium.org
> > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > BUG=602485, 644992
> >
> > Committed: https://crrev.com/95beb47e50065959ee2f5b43cf431431e32e14cd
> > Cr-Commit-Position: refs/heads/master@{#417895}
>
> TBR=enne@chromium.org,brianderson@chromium.org,danakj@chromium.org,sammc@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=602485, 644992
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
>
> Committed: https://crrev.com/864a70f6f93a87ff374bf2aea2494d4d7d0150d7
> Cr-Commit-Position: refs/heads/master@{#421268}

TBR=enne@chromium.org,danakj@chromium.org,brianderson@chromium.org
BUG=602485, 644992
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2386183003
Cr-Commit-Position: refs/heads/master@{#422595}

BUG=651513
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2383513003
Cr-Commit-Position: refs/heads/master@{#422594}

If new XHR breakpoint with existing url is added then we need to enable existing breakpoint.

BUG=chromium:532411
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2391773002
Cr-Commit-Position: refs/heads/master@{#422593}

fast/borders/border-radius-with-box-shadow.html requires a trivial
rebaseline after

https://chromium.googlesource.com/skia.git/+/a3b45d4f7db953472df4f11ab1595964b65175f9

BUG=630695
TBR=bsalomon@chromium.org,reed@google.com
NOTRY=true

Review-Url: https://codereview.chromium.org/2389043002
Cr-Commit-Position: refs/heads/master@{#422592}

BUG=563793

Review-Url: https://codereview.chromium.org/2387053003
Cr-Commit-Position: refs/heads/master@{#422591}

This CL:

* Removes the Credits item from the menu since it will be merged into Help's
  overflow menu.
* Refactors the item layout so that we only needs one XML and specifying icon
  and text in the code.

BUG=613604

Review-Url: https://codereview.chromium.org/2383283002
Cr-Commit-Position: refs/heads/master@{#422590}

An extension function error should be set only through the use of the
response (i.e., ExtensionFunction::Error()), and setting it directly
can lead to confusion and incorrect results. Remove
ExtensionFunction::SetError(). Other subclasses (like
AsyncExtensionFunction) still have accessors, but will be updated as
they are converted.

Also disable two more input IME API tests that were always failing, but
silently passed because of passing success despite having an error.

BUG=648275

Review-Url: https://codereview.chromium.org/2386823002
Cr-Commit-Position: refs/heads/master@{#422589}

Support the ShelfID window property in mash.
(ShelfWindowWatcher uses this to find existing items)
Allow WM clients to set ShelfItemType and ShelfIconResourceId.
Define aura property keys in a shared location for chrome and ash.

Notify WmWindowObserver of certain white-listed property changes.
Add WmWindowProperty::INVALID_PROPERTY for key translation checks.

Add property utility functions to c/b/ui/ash for aura/ui windows.
Use SettingsWindowObserver in ChromeLauncherController (cash&mash).
Use separate aura/ui window trackers to watch for name changes.
(Can't use ash::WmWindow in Chrome... depends on ash internals)

Early return from Window::SetTitle if the values match.

TODO: Use ash/mus/property_util.h (move some to ash/public/cpp)?
TODO: Automatically propagate some props with an observer?

BUG=634150
TEST=chrome --mash shows task manager and settings shelf icons.
R=jamescook@chromium.org,sky@chromium.org,tsepez@chromium.org,

Review-Url: https://codereview.chromium.org/2381183002
Cr-Commit-Position: refs/heads/master@{#422588}

This fixes BrowserTest.ClearPendingOnFailUnlessNTP.

BUG=504347
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2380383004
Cr-Commit-Position: refs/heads/master@{#422587}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/8341c698..9c1db96f

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2390023002
Cr-Commit-Position: refs/heads/master@{#422586}

This CL allows the x11 injector to remap the last keycode to the character if
the character is not on the current keyboard layout.

BUG=645659

Review-Url: https://codereview.chromium.org/2346643003
Cr-Commit-Position: refs/heads/master@{#422585}

Currently, CC uses InnerViewportScrollLayer to designate scrolling of the
viewport. This is problematic as there's also non-scrolling uses of
InnerViewportScrollLayer and it's not clear which is which. This caused the
regression in the CL and is generally problematic because the semantics aren't
clear. I've created Viewport::MainScrollLayer to designate which viewport layer
is used for scrolling and replaced uses in the code that are semantically using
the "viewport scrolling representative".

I've also removed some viewport scrolling methods in LayerTreeHostImpl and
replaced them with calls into cc::Viewport.

Note, this patch doesn't actually change any behavior. The original CL that
caused the regression was reverted. The problem was that it missed some viewport
scrolling uses of InnerViewportScrollLayer. This patch makes it easy to change
the layer which represents the viewport. Once it lands I can reland the reverted
CL using the MainScrollLayer method.

BUG=651515
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2388563002
Cr-Commit-Position: refs/heads/master@{#422584}

The WebAPK server may send us the URL of the WebAPK to download prior to the
WebAPK being available at that URL. WebApkInstaller will sleep 2 seconds and
retry the download if the download fails.

BUG=649704
TBR=dfalcantara

Review-Url: https://codereview.chromium.org/2381023003
Cr-Commit-Position: refs/heads/master@{#422583}

R=bradnelson@chromium.org

Review-Url: https://codereview.chromium.org/2386273005
Cr-Commit-Position: refs/heads/master@{#422582}

Note: this is 1 of 3 CLs in different repos:

1. build CLs split up:
  - master: https://codereview.chromium.org/2382863002/
  - slaves: https://codereview.chromium.org/2382723004/
2. https://codereview.chromium.org/2347293003 (chromium) [this one]

(Considering not landing this one)
3. https://chromium-review.googlesource.com/386326 (infra)

BUG=613305
TBR=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2347293003
Cr-Commit-Position: refs/heads/master@{#422581}

Combines Variations.SeedFetchResponseCode and
Variations.FailedRequestErrorCode histograms.

It's useful to have error codes and http response codes in one.

BUG=652406

Review-Url: https://codereview.chromium.org/2384173003
Cr-Commit-Position: refs/heads/master@{#422580}

inspector/elements/elements-panel-correct-case.html is no longer flaky

BUG=623802

Review-Url: https://codereview.chromium.org/2386993003
Cr-Commit-Position: refs/heads/master@{#422579}

This function appears to take about a mean of 35ms during
startup according to UMA sampling profiler data. Also, the
current NTP doesn't need this CSS - since this is related to
the old local NTP, which currently only powers chrome://apps.

This also saves memory used by the generated CSS until the
first time it's used. The downside is there will be a delay
when loading this css - but given this codepath is only used
by chrome://apps page, this seems like a reasonable trade-off.

Note: The CSS will still be cached after the first request, since
NTPResourceCache caches it and we fetch it from there.

No intended functional changes. Expecting to see a 35ms
startup improvement in UMA when this lands.

BUG=651848

Review-Url: https://codereview.chromium.org/2381093002
Cr-Commit-Position: refs/heads/master@{#422578}

BUG=570711
TEST=none

Review-Url: https://codereview.chromium.org/2382023005
Cr-Commit-Position: refs/heads/master@{#422577}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/42b8c87e471284970ffbb20c7f2d96791f2973cd Converted the 3 nested steps into 1 step. (hzl@google.com)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=605572

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2388313002
Cr-Commit-Position: refs/heads/master@{#422576}

Also for deprecated flexbox

R=eae@chromium.org

Review-Url: https://codereview.chromium.org/2388673003
Cr-Commit-Position: refs/heads/master@{#422575}

Revert of Android: Free GLHelper context ashmem when it makes sense (patchset #4 id:60001 of https://codereview.chromium.org/2336043004/ )

Reason for revert:
Causes a null pointer crash. And also apparently doesn't work?

BUG=652050

Original issue's description:
> Android: Free GLHelper context ashmem when it makes sense
>
> Free the 'mapped_memory' that is used in readbacks through
> CopyFromCompositingSurface() when there is memory pressure
> in the system (or no activities are running and a readback
> completes).
>
> This memory gets lazily allocated during the first readback
> and it'd be the size of the texture after scaling. Freeing it
> is harmless at a slight reallocation cost when the next readback
> is triggered.
>
> BUG=641962
> TBR=boliu@chromium.org
>
> Committed: https://crrev.com/98f7c133cdef22c26922c56371f84989f7a2cd60
> Cr-Commit-Position: refs/heads/master@{#421357}

TBR=danakj@chromium.org,sievers@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=641962

Review-Url: https://codereview.chromium.org/2392623003
Cr-Commit-Position: refs/heads/master@{#422574}

BUG=563793

Review-Url: https://codereview.chromium.org/2390853002
Cr-Commit-Position: refs/heads/master@{#422573}

https://pdfium.googlesource.com/pdfium.git/+log/d61f958385be..76383db4906c

$ git log d61f95838..76383db49 --date=short --no-merges --format='%ad %ae %s'
2016-10-03 dsinclair Fix potentially uninitialized value.
2016-10-03 tsepez Rename CFX_WeakPtr::Clear() to DestroyObject()
2016-10-03 dsinclair Guard against double deletion of page views.

BUG=651632,652103

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2388133003
Cr-Commit-Position: refs/heads/master@{#422572}

BUG=none

Review-Url: https://codereview.chromium.org/2371393002
Cr-Commit-Position: refs/heads/master@{#422571}

Changes WebUI setup to a MojoWebUI for chrome://bluetooth-internals page.
Adds mojom files for Bluetooth service definition and internals page handler.
Adds basic Bluetooth device retrieval using starter Bluetooth service
implementation for logging on web front end.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
BUG=651282

Review-Url: https://codereview.chromium.org/2357383002
Cr-Commit-Position: refs/heads/master@{#422570}

Fixes scrolling when tapping an item in the drawer nav menu below the current
scroll position.

https://codereview.chromium.org/2230123002 made MainPageBehavior try scrolling
to a section synchronously, but settings-main updates the overscroll after a
setTimeout. We should be able to update the overscroll synchronously as well --
we originally had issues with tests but hopefully the code is now more robust.

This consolidates toggleScrolling_ into settings-main via the freeze-scroll
event.

Testing is difficult because of timing issues: we have to wait for the page
to be fully 100% loaded before testing scrolling, or sections could change
height and interfere with the test. But we don't have any way of knowing that.

BUG=644583
R=dschuyler@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2312423003
Cr-Commit-Position: refs/heads/master@{#422569}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/6efaefc15ef4..bd5814787caa

$ git log 6efaefc15..bd5814787 --date=short --no-merges --format='%ad %ae %s'
2016-10-03 achuith Disable testTrafficSettings on chromeos.

BUG=652385

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2388953002
Cr-Commit-Position: refs/heads/master@{#422568}