- 17 Nov, 2020 40 commits
-
-
Adam Langley authored
When a caBLEv2 tunnel server responds with a 410 status to a contact request it means that the contact ID is now invalid and should never be used again. This change notices that status code and erases pairings when that happens. (No UI changes since the UI for this is still unclear. I.e. the UI telling the user to check their phone still appears for the duration of the operation even through Chromium quickly knows that it's not going to work.) BUG=1002262 Change-Id: Iecf8fafe26d92aae1767df02267e1f2545d0ad0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538157 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#828047}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1605526350-20402e3f73add4bc72f047c8e3796b7e4e1e9320.profdata to chrome-win32-master-1605538580-853d8fcb404f37acc68f0179b58be2e881687944.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I54fd935ec92a7445d07b2cdd77b7ac70c4ef7049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542482Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828046}
-
Sammie Quon authored
Minimized and non minimized windows have their rounded corners applied in overview differently, minimized on the mirror view layer, and normal windows on the actual window layer. Due to the setup of the current logic, minimized windows do not reset the windows layer rounded corners on exit. This was problematic if the window was not minimized when entering, and then minimized at exit which is a common workflow in tablet mode. Bug: 1146240 Test: added tests Change-Id: I9b3f9c465bb1bdfc5bf1acbe727ea9743472edcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542605Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#828045}
-
Darren Shen authored
IME service always expects an OnInputMethodChanged message first, then an OnFocus. However, if we enable NativeInputMethodEngine and then immediately focus, it will send out OnFocus then OnInputMethodChanged. This is because OnInputMethodChanged is sent in an async callback, which may run after we send OnFocus. Move the code to send OnInputMethodChanged out of the callback and call it immediately after connecting to IME service. This is ok because Mojo will queue up any messages automatically if the IME service is not yet ready. Bug: b/172990698 Change-Id: I81bc0062f867131d0c8faf32411a845f676b5aeb Fixed: b/172990698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537443 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#828044}
-
Kenneth Russell authored
This reverts commit 7cc6fb54. Reason for revert: root cause of flakiness has been addressed. Original change's description: > Retry conformance/textures/misc/exif-orientation.html . > > A recent change, still being tracked down, has made this test flaky on > macOS and ChromeOS. > > Bug: 1146687 > Change-Id: If22497aeefa8fa582124dce83c1e8fcf53bde479 > No-Try: True > Tbr: jdarpinian@chromium.org > Tbr: schenney@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528295 > Commit-Queue: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Stephen Chenney <schenney@chromium.org> > Reviewed-by: James Darpinian <jdarpinian@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825595} TBR=kbr@chromium.org,jdarpinian@chromium.org,schenney@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1146687 Change-Id: I87b3bbdfc2d822f39bc6f113781ae4633464afcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543190Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#828043}
-
Kenichi Ishibashi authored
`resource_ids` isn't used anymore. Removing it simplifies retries of DoomUncommittedResources(). Bug: 1133143 Change-Id: I99183060434429615b294538b8d719e3f4c49397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542928Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#828042}
-
Matt Wolenetz authored
BUG=1149601 Change-Id: I6a38cd899ed4a862489616b5e1c7dfe608ea04a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541668 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#828041}
-
Andrew Xu authored
It is confusing that the count of items in the menu model is different from that of the item views in the context menu. In the current code, we have to insert the deletion command because MenuModelAdapter::ExecuteCommand() checks whether the command to execute is contained in the menu model. In this CL, the special command id (i.e. the item deletion command id) is removed. Instead, We use the command id to indicate which menu item is activated. When the clipboard history controller is notified of the activation, it queries the menu item specified by the command id about the action to take. This CL should not introduce any visual difference Bug: 1131556 Change-Id: I51b6c56aea656c1a2c764d756e616823c0bbf850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531063 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#828040}
-
Yuchen Liu authored
Implement LoadSession and RemoveSession for FuchsiaCdm: LoadSession -> fuchsia CDM::LoadLicenseSession RemoveSession -> fuchsia LicenseSession::GenerateLicenseRelease Bug: internal b/162078899 Test: https://storage.googleapis.com/m3u8_lag/persistent_license/index.html Change-Id: I151645ecaee800979690bd47936cc27584322acb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373403 Commit-Queue: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#828039}
-
Alexander Dunaev authored
This is a reland of 30a60064 The difference to the original change is that here media_unittests are added to the list of test suites that run with Wayland. Original change's description: > [ozone/x11] Enabled user input monitor unit tests. > > This CL adds Ozone platform initialisation to the user input monitor tests > so they can now work with Ozone enabled. > > Bug: 1109112 > Change-Id: I31f9dabf2da9eed85cd05fe27017899b0247f4bc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521144 > Commit-Queue: Alexander Dunaev <adunaev@igalia.com> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826638} Bug: 1109112 Change-Id: Id9de3d5985b9fe13c4b073b4f2731fc1df2966f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532776Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/master@{#828038}
-
Ryan Sturm authored
This also refactors the content/ accept header code to be in public along with the signed exchange accept header suffix. Bug: 1138648 Change-Id: Idf3f5d4f8b3034e301318bdb29d509ee46bc3d10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533331 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#828037}
-
Mitsuru Oshima authored
Bug: None Change-Id: Id30641a3ad725a93c0d05109a4d8115253805cf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537575Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#828036}
-
Ryan Sturm authored
When a prefetch is requested for a Google SRP via omnibox suggest hints, the query should include pf=cs. This adds a template URL case and a search data args field to accomplish this. If more sources of prediction become available, pf=c* should be used for those. Bug: 1148924 Change-Id: Icbbd9633c54199e23fee4f007d5e086dfe6041c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536987 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#828035}
-
Sammie Quon authored
The previous attempt [1] added checks for whether the starting or ending screenshot was taken. In the case of the starting screenshot missing, it would signal the animation to remove some RootWindowDeskSwitchAnimators, leading to a vector out of bounds. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2506356 Bug: 1148607 Test: added regression test Change-Id: I7f14df877cb93619a0ca8a85f5d0ad434dda3ad2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536934 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#828034}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e05d24f9..89e3ceea Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I14e3d94c3021b99edfbe7b26c6c144570f79265c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542844Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828033}
-
Patrick Noland authored
ownership to LBC This puts LocationBarCoordinator in charge of constructing and destroying UrlBarCoordinator, StatusCoordinator, and AutocompleteCoordinator. This allows us to wire a few more dependencies into constructors instead of via setters. The coordinators are still passed to LocationBarLayout for it to use via a new initialize() method that consolidates a few different setter methods on LocationBarLayout. initialize() helps avoid bugs that could arise when calling these setters out of order. There is an additional change to LocationBarLayoutTest that fixes a DCHECK when running tests on a debug build. Reland fixes: * shouldShowDeleteButton can get called before initialize() when, e.g. we re-create the activity for a theme change, so it should account for UrlCoordinator possibly being null. We call updateButtonVisibility when the coordinator gets set, so the state should remain fresh * LocationBarTablet called methods on StatusCoordinator before initialize(). The fix, moving them to initialize, is easy, but revealed a spurious assert in StatusView that has been removed. Bug: 1146057, 1146062, 11493484, 1149245, 1149382, 1149242 Change-Id: Ia6aba188821a64d94a5f27136b54dbc7540547b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541812 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#828032}
-
Nektarios Paisios authored
ax::mojom::Event::kTextSelectionChanged is deprecated and will be removed from Blink at the earliest opportunity. It has been "superseded by AXEventGenerator::EventType::DOCUMENT_SELECTION_CHANGED. This patch switches all platforms except Chrome OS to that event. However, the only platform that made use of the deprecated kTextSelectionChanged event was Windows. There, it is used to fire both native IAccessible2 and UI Automation events on the focused text field if present, including on the root of content editables. Note that native selection changed events need to be fired on the document object, the focused text field or content editable, and the focus of the selection. AX-Relnotes: n/a. R=dmazzoni@chromium.org, aleventhal@chromium.org Bug: 1049261 Change-Id: I86e29a758b49a7661b23d49f4eb9a8656aa98a30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518910 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Auto-Submit: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#828031}
-
Maggie Chen authored
Move GPU.SupportsDX12 and GPU.D3D12FeatureLevel from the GPU process to the browser process. These two histograms are lost when they are recorded in the info-collection GPU process. They are not allocated in the persistent histogram memory and the GPU process is terminated right after the histogram data is written. To preserve the data, we now record the histograms in the browser process. Bug: 775983, 1149617 Change-Id: Ia31195cfe5cc9a6ac86de830b53046285a49843e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542364Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#828030}
-
Piotr Bialecki authored
Adjust namespaces of the already-moved classes, as well as move the class that was still left behind. Bug: 843374 Change-Id: I0d53115cb883450bd250ecdb6d74b6c2b68f6455 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535215Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#828029}
-
Thomas Guilbert authored
debugger-inline-values-frames.js and reveal-execution-line.js are flaking across different bots. TBR: tasak@google.com Bug: 1149734 Change-Id: I17eda8a8f475aa98532771b122ef5d590a84c02b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543085Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#828028}
-
Bartek Nowierski authored
While investigating a perf regression bug, I tried this CL and it looks it improved 1~1.5% on a couple scenarios, so might be worth taking. https://pinpoint-dot-chromeperf.appspot.com/job/117de375520000 Drive by: change a nearby DCHECK_LE to PA_DCHECK while at it. Change-Id: I048898938286c3347aeaf6c5672a1bb79bc90b5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539221 Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#828027}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I0f4b9bbe80cccc936fb3caba46acd2b88fba511a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541904Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828026}
-
Dale Curtis authored
This always uses the unaccelerated path right now, if we find these cases are common, we will need to improve VideoFrameYUVConverter so the hardware based conversion process works. Note: This inlines the preferAcceleratedImageBitmap() function to make it more clear when the accelerated path is preferred. R=sandersd Bug: 1148800 Change-Id: I8f669ade90d9f4133ffe15a63c8c47d22a1dc286 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542671 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#828025}
-
Ravjit Singh Uppal authored
Added the option to switch to one time permission grant for Geolocations from the Page Info UI Bug: 1148335 Change-Id: I2b5f1c3d84138391c790d89c4db55ae21468e489 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530009 Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#828024}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e3efb253. With Chromium commits locally applied on WPT: cfe2227f "content-visibility: Rename tentnative test to non-tentative." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I552f8682ebb9246fb5e6e4d31c4c35eaa316f259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542609Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828023}
-
Ben Joyce authored
Collect the outputs and print it out as it would be if not ran in parallel. Bug: 1138506 Change-Id: I92a3e098f7ef4a02bfcf51d948810db91bf7d0bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535668Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#828022}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/da73999f798a..d4e6fb6573e0 2020-11-17 ehmaldonado@google.com [owners] Implement GetChangeApprovalStatus for Depot Tools If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: I4f32bc0f5596d1fcece641ec20c46562d5fc1ee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543442Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828021}
-
Kyle Horimoto authored
This CL removes the ConnectionStatus::kWaitingForConnectionInitiation enum value. In practice, we always get the OnConnectionInitiated() callback before the RequestConnection() callback is invoked, so this state should not exist. Bug: 1148152, 1106937 Change-Id: Ie659a875ae3a32ec62aa991398331617b2c33d2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542573 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#828020}
-
Liquan (Max) Gu authored
Before the CL, the error handling logic lives in CPRService#showAppSelector(). After the CL, CPRService#showAppSelector() returns the error to PRService, and PRService handles the error. Bug: 1148902 Change-Id: I992b449eb5d406db6c110ce9d300c6b68afd5528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536996Reviewed-by:
Nick Burris <nburris@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#828019}
-
evliu authored
This CL renames the "Live Captions" flag to "Live Caption". Bug: 1148994 Change-Id: I133513bd6912e9a5f9adb4023533546ef0c382a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538268Reviewed-by:
Abigail Klein <abigailbklein@google.com> Reviewed-by:
Evan Liu <evliu@google.com> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#828018}
-
Pavol Marko authored
Instead of using string constants, introduce an enum for the selected nameservers type. This is less error prone and easier to read. Bug: 1108922 Change-Id: I05cc167f42467af8a6b78cb688b8239e8a896c67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537678 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#828017}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/3e551b3ce67d..04515da400d5 2020-11-16 srisser@google.com Don't auto append value of stringified enums If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: If382c85f0b769fce5fae16b63bba80fa510b4430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542646Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828016}
-
Nate Chapin authored
NavigatorBase is a newly-added base class for Navigator and WorkerNavigator. Making Permissions a Supplement of NavigatorBase allows a single class to handle all of the work of exposing the navigator.permissions getter for both windows and workers, and greatly reduces boilerplate. Bug: 1147612 Change-Id: I45b857df7864ba50f38ebebd2afe358ae759914a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538056 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#828015}
-
Alfonso Garza authored
Two main changes to address flakiness: 1. Scroll to nickname before changing it. 2. Use grey_replaceText as recommended by EG. Evolved from previous CL https://chromium-review.googlesource.com/c/chromium/src/+/2380145 Fixed: 1106766, 1108809 Change-Id: I0acfc0980b95bc657d545c43d1a7e15410485747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493423 Commit-Queue: Alfonso Garza <alfonsogarza@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#828014}
-
Jeroen Dhollander authored
I tried compiling ChromeOS on a fresh installed gLinux and it failed: ACTION //chrome/browser/chromeos:device_policy_remover_generate(//build/toolchain/linux:clang_x64) FAILED: gen/chrome/browser/chromeos/device_policy_remover.cc python ../../chrome/browser/chromeos/policy/tools/generate_device_policy_remover.py gen/chrome/browser/chromeos/device_policy_remover.cc ../../third_party/protobuf/python pyproto pyproto/components/policy/proto Traceback (most recent call last): File "../../chrome/browser/chromeos/policy/tools/generate_device_policy_remover.py", line 63, in <module> sys.exit(main()) File "../../chrome/browser/chromeos/policy/tools/generate_device_policy_remover.py", line 31, in main from chrome_device_policy_pb2 import ChromeDeviceSettingsProto File "pyproto/components/policy/proto/chrome_device_policy_pb2.py", line 7, in <module> from google.protobuf import descriptor as _descriptor File "../../third_party/protobuf/python/google/protobuf/descriptor.py", line 38, in <module> import six ImportError: No module named six This is not easy to work around as it requires pip for Python2 which is no longer available in apt, so I tried running the script in Python3 and that seemed to work. Bug: crbug.com/1112471 Test: compiled Change-Id: I777c7a1c4562eec500ea487f48f0337b51735010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542063Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Cr-Commit-Position: refs/heads/master@{#828013}
-
Reilly Grant authored
Based on crash reports it appears possible for open() to return null without throwing an exception. getCameraParameters() handles this case gracefully by returning null but isZoomSupported() will then try to call release() on the null Camera. The release() call is unecessary because getCameraParameters() already releases the Camera on error. Bug: 1149283 Change-Id: I1a5522fa3179f3b6389e5dff83a0ca379f9f44ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542785 Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#828012}
-
James Cook authored
Chrome OS hides many paths from the user. Users can only browse to MyFiles, certain Android paths, and a selected set of mount points. For security-in-depth, Chrome OS restricts download paths to those directories and their subdirectories. Many of the path utilities functions used to check for these directories have ash dependencies that cannot be included in the lacros build. For now, restrict lacros downloads to the default Downloads directory and its subdirectories. We can revisit this as part of the Files work planned for early next year. Bug: 1148848 Test: expanded unit_tests coverage for lacros Change-Id: Ia7c41350dcfc29299579f9e7ecd4078e1eb00505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541124Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#828011}
-
Takashi Sakamoto authored
This reverts commit 4f35dbaf. Reason for revert: Suspect causing chromedriver_py_tests failures on (none) GPU on Mac: - main.MobileEmulationCapabilityTest.testNetworkConnectionDisabledByDefault - main.ChromeDriverTestLegacy.testMobileEmulationDisabledByDefault - main.ChromeDriverTest.testActionsMouseDrag - main.ChromeDriverTestLegacy.testMouseDoubleClick ...215 more failure(s) (219 total)... First build failure: https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/61407 Sample log: --- testWifiAndAirplaneModeEmulation (__main__.MobileEmulationCapabilityTest) ... ERROR testConnectToRemoteBrowser (__main__.RemoteBrowserTest) ... application requires at least Mac OS X version 10.11.0 (10.11.0), but is being run on 10.10.5 ( 10.10.5/14F2511), and so is exiting.Received signal 6 --- Original change's description: > mac: Update LSMinimumSystemVersion from 10.10 to 10.11 > > Bug: 1148931 > Change-Id: Ic0cdded0c1c4821689486cacd5790fce82c40c87 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537057 > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827937} TBR=avi@chromium.org,rsesek@chromium.org Change-Id: If527cdb6ffdde2807b2c9a2315316a8ae5699e24 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1148931 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542934Reviewed-by:
Takashi Sakamoto <tasak@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#828010}
-
Austin Sullivan authored
- This CL contains no behavioral changes - NFSManager stores flat_set of NFSWriterImpls rather than a UniqueReceiverSet of blink::mojom::NFSWriters - FileWriter destroys itself via disconnect handler - Opens the door for autoClose flag as described here: https://github.com/WICG/file-system-access/issues/236 Bug: 1135687 Change-Id: Icbc7375174ee2d48dca481d6490d5eddc282ccff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523653 Auto-Submit: Austin Sullivan <asully@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#828009}
-
mlcui authored
Googlers: a screenshot of the new sub-labels can be found here: http://screen/345FdDordriQRcu Fixed: 1146366 Test: Manual test Change-Id: I49ca8a731b7ef1d63d794368ff27b355298e382d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525463Reviewed-by:
My Nguyen <myy@chromium.org> Commit-Queue: Michael Cui <mlcui@google.com> Cr-Commit-Position: refs/heads/master@{#828008}
-